[U-Boot] [PATCH] [FIX] cmd_nand: fix help of nand erase subcommand

2011-05-19 Thread Daniel Hobi
Since commit 30486322 (nand erase: .spread, .part, .chip subcommands) the arguments off and size are no longer optional. Signed-off-by: Daniel Hobi Cc: Scott Wood --- common/cmd_nand.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/common/cmd_nand.c b/common

[U-Boot] [PATCH] [FIX] env_nand: zero-initialize variable nand_erase_options

2011-05-18 Thread Daniel Hobi
following NAND sectors/partitions. Signed-off-by: Daniel Hobi --- common/env_nand.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/common/env_nand.c b/common/env_nand.c index 980425a..14446a6 100644 --- a/common/env_nand.c +++ b/common/env_nand.c @@ -193,10 +193,8 @@ int

Re: [U-Boot] [PATCH V4 1/2] arm926ejs: fix linker file for newer ld support

2010-11-15 Thread Daniel Hobi
Hi Eric, On 10.11.2010 00:43, Eric Cooper wrote: > I have been periodically rebasing my patches for the Seagate DockStar > on master. But ever since the elf_reloc changes were merged, I have > been unable to get a working build. First I saw symptoms similar to > what Alexander Holler reported (f

Re: [U-Boot] kirkwood: CONFIG_SYS_INIT_SP_ADDR wrong?

2010-11-10 Thread Daniel Hobi
Hi Albert and Heiko, On 10.11.2010 17:46, Heiko Schocher wrote: > Daniel Hobi wrote: >> Why not add alignment to start.S? >> >> /* Set stackpointer in internal RAM to call board_init_f */ >> call_board_init_f: >> ldr sp, =(CONFIG_SYS_INIT_SP_ADDR) &g

Re: [U-Boot] kirkwood: CONFIG_SYS_INIT_SP_ADDR wrong?

2010-11-10 Thread Daniel Hobi
Hi Heiko, On 10.11.2010 16:40, Heiko Schocher wrote: > Daniel Hobi wrote: >> But you also added assembly code to setup the initial stack pointer in >> arch/arm/cpu/*/start.S (ie commit ab86f72c for arm926ejf) which reads: >> >> /* Set stackpointer in intern

Re: [U-Boot] kirkwood: CONFIG_SYS_INIT_SP_ADDR wrong?

2010-11-10 Thread Daniel Hobi
Hi Heiko, On 10.11.2010 16:02, Heiko Schocher wrote: > Daniel Hobi wrote: >> Reading your patch, I noticed that we don't align the early stack >> pointer to an 8-byte boundary which may lead to the problem described here: >> >> http://article.gmane.org/gman

Re: [U-Boot] kirkwood: CONFIG_SYS_INIT_SP_ADDR wrong?

2010-11-10 Thread Daniel Hobi
Hi Heiko, On 10.11.2010 15:15, Heiko Schocher wrote: > Daniel Hobi wrote: >> @Heiko: include/configs/km_arm.h may have the same problem. > > I made a patch for this, see: > > http://lists.denx.de/pipermail/u-boot/2010-November/081275.html Reading your patch, I noticed th

[U-Boot] kirkwood: CONFIG_SYS_INIT_SP_ADDR wrong?

2010-11-10 Thread Daniel Hobi
Hi Prafulla, In commit 0b20ed76 (Kirkwood: Changes specific to ARM relocation support), you set CONFIG_SYS_INIT_SP_ADDR to 0xC8012000 which is supposed to lie within the internal Security SRAM. However, the Kirkwood Functional Specification (chapter 2.13 Default Address Map) and arch/arm/include/

Re: [U-Boot] [PATCH V4 1/2] arm926ejs: fix linker file for newer ld support

2010-11-10 Thread Daniel Hobi
On 10.11.2010 13:48, Albert ARIBAUD wrote: > Le 10/11/2010 13:31, Daniel Hobi a écrit : >>>> But shouldn't this change be applied to all ARM linker scripts, ie >>>> arch/arm/cpu/*/u-boot.lds? >>> >>> Yes, it should. :) >> >> Can you pl

[U-Boot] [PATCH] tools/env: cleanup host build flags

2010-11-10 Thread Daniel Hobi
to cross-compile tools/env, override the HOSTCC variable as in this example: make tools env HOSTCC=bfin-uclinux-gcc Signed-off-by: Daniel Hobi --- tools/env/Makefile | 15 ++- 1 files changed, 10 insertions(+), 5 deletions(-) Let's fix these issues now and cleanup the

Re: [U-Boot] [WIP] tools/env: cleanup host build flags

2010-11-10 Thread Daniel Hobi
Hi Mike, On 10.11.2010 10:23, Mike Frysinger wrote: > On Monday, October 11, 2010 12:06:46 Daniel Hobi wrote: >> - use the cross compiler again (fw_printenv is intended for a >> hosted environment on the target). > > the cross-compiler used to create u-boot has no guarant

Re: [U-Boot] [PATCH V4 1/2] arm926ejs: fix linker file for newer ld support

2010-11-10 Thread Daniel Hobi
Hi Albert, On 09.11.2010 19:47, Albert ARIBAUD wrote: > Le 09/11/2010 19:24, Daniel Hobi a écrit : >> Thank you. This patch is required to get Kirkwood-based boards working >> again when using the CodeSourcery 2009q3 toolchain. > > (can't find the 2010q3 Lite toolch

Re: [U-Boot] [PATCH V4 1/2] arm926ejs: fix linker file for newer ld support

2010-11-09 Thread Daniel Hobi
and overlay with .bss. Tested-by: Daniel Hobi Thank you. This patch is required to get Kirkwood-based boards working again when using the CodeSourcery 2009q3 toolchain. But shouldn't this change be applied to all ARM linker scripts, ie arch/arm/cpu/*/u-boot.lds? And on many ARM platforms (i

Re: [U-Boot] [PATCH 4/4] tools/env: use host build flags

2010-11-09 Thread Daniel Hobi
Hi Steve, On 09.11.2010 01:01, Steve Sakoman wrote: > On Mon, Nov 8, 2010 at 3:15 PM, Wolfgang Denk wrote: >> In message you wrote: >>> It just occurred to me that this will no longer cross compile the fw_env >>> tool - effectively rendering the tool useless for me. >> >> Argh... Indeed, that's

[U-Boot] [WIP] tools/env: cleanup host build flags

2010-10-11 Thread Daniel Hobi
cross compiler again (fw_printenv is intended for a hosted environment on the target). Signed-off-by: Daniel Hobi Cc: Mike Frysinger Cc: Wolfgang Denk --- tools/env/Makefile | 15 ++- 1 files changed, 10 insertions(+), 5 deletions(-) Hi Scott, In commit d984fed0 (makefiles

[U-Boot] [PATCH] tools/imls: fix comment in Makefile

2010-10-11 Thread Daniel Hobi
Commit d984fed0 (makefiles: fixes for building build tools) changed the variable name FIT_CFLAGS to HOSTCFLAGS_NOPED but forgot to update to corresponding comment. Signed-off-by: Daniel Hobi Cc: Scott Wood Cc: Wolfgang Denk --- tools/imls/Makefile |2 +- 1 files changed, 1 insertions

[U-Boot] [PATCH 2/2 v2] tools/env: fail on invalid options

2010-09-16 Thread Daniel Hobi
Signed-off-by: Daniel Hobi --- v2: - print a hint to --help before returning tools/env/fw_env_main.c |4 1 files changed, 4 insertions(+), 0 deletions(-) Hi Wolfgang, On 15.09.2010 21:18, Wolfgang Denk wrote: > In message <1284572787-9842-2-git-send-email-daniel.h...@

[U-Boot] [PATCH 1/2] tools/env: allow option "-n" for fw_printenv

2010-09-15 Thread Daniel Hobi
out is correct. Signed-off-by: Daniel Hobi --- tools/env/fw_env_main.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/env/fw_env_main.c b/tools/env/fw_env_main.c index 82116b4..baf3a4d 100644 --- a/tools/env/fw_env_main.c +++ b/tools/env/fw_env_main.c @@

[U-Boot] [PATCH 2/2] tools/env: fail on invalid options

2010-09-15 Thread Daniel Hobi
Signed-off-by: Daniel Hobi --- tools/env/fw_env_main.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/tools/env/fw_env_main.c b/tools/env/fw_env_main.c index baf3a4d..381ed14 100644 --- a/tools/env/fw_env_main.c +++ b/tools/env/fw_env_main.c @@ -105,6 +105,8 @@ main

[U-Boot] [PATCH v3] Makefile: fix parallel build

2010-01-18 Thread Daniel Hobi
thus only one sub-make is spawned per directory. Signed-off-by: Daniel Hobi --- v3: - Add a comment why make _depend is required for these two subdirs v2: - Also build target depend in $(dir $(LDSCRIPT)) (suggested by Mike) - Break overlong line Makefile |5 - 1 files changed, 4

[U-Boot] [PATCH v2] Makefile: fix parallel build

2009-12-15 Thread Daniel Hobi
thus only one sub-make is spawned per directory. Signed-off-by: Daniel Hobi --- v2: - Break overlong line - Add comment about other directories to commit message - Also build target _depend in $(dir $(LDSCRIPT)) (as suggested by Mike) This requires the Makefile in $(dir $(LDSCRIPT)) to provide

Re: [U-Boot] [PATCH] Makefile: fix parallel build

2009-12-15 Thread Daniel Hobi
On 11.12.2009 20:25, Mike Frysinger wrote: > On Thursday 10 December 2009 08:41:07 Daniel Hobi wrote: >> During parallel build, the top Makefile spawns multiple sub-makes >> for targets in cpu/$(CPU). If cpu/$(CPU)/.depend is not present, the >> sub-makes may end up

[U-Boot] [PATCH] Makefile: fix parallel build

2009-12-10 Thread Daniel Hobi
. Stop. This patch serializes the creation of cpu/$(CPU)/.depend by adding cpu/$(CPU) to the depend target in the top Makefile. Signed-off-by: Daniel Hobi --- Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index 19b5ac0..2fd22c7 100644 --- a

[U-Boot] [PATCH] Fix computation in nand_util.c:get_len_incl_bad

2009-12-01 Thread Daniel Hobi
. 2) If there are bad blocks, the nand_{read,write}_skip_bad may choose the bad block unaware read/write code (if len_incl_bad == *length) which leads to corrupted data. Signed-off-by: Daniel Hobi --- @Scott: please review @Wolfgang: please consider for 2009.11 diff --git a/drivers/mtd/nand