Re: [RFC PATCH] mxs: Don't enable 4P2 reg if mx28 is powered only from DCDC_BATT without 5V

2023-12-19 Thread Cody Green
On Fri, Dec 15, 2023 at 7:23 PM Fabio Estevam wrote: > > On Fri, Dec 15, 2023 at 1:20 PM Fabio Estevam wrote: > > > Ok, what about the patch below? > > > > https://patchwork.ozlabs.org/project/uboot/patch/20230703205700.9120-1-c...@londelec.com/ > > > > Is this still needed? > > I looked in the

Re: [PATCH 2/2] mxs: Don't enable 4P2 reg if MXS is powered only from DCDC_BATT

2023-07-04 Thread Cody Green
On Tue, Jul 4, 2023 at 9:19 AM Lukasz Majewski wrote: Hi Lukasz, > > Hi Marek, Cody, > > > On 7/3/23 18:33, Cody Green wrote: > > > 'mxs_power_enable_4p2()' function call was added to > > > 'mxs_batt_boot()' in 'commit a0f97610757d' t

[PATCH v2 1/2] mxs: Fix VDDx brownout interrupt disable/enable

2023-07-04 Thread Cody Green
DDA_BO and ENIRQ_VDDD_BO. Signed-off-by: Cody Green Cc: Stefano Babic Cc: Marek Vasut Cc: Fabio Estevam Cc: Lukasz Majewski --- Changes for v2: - Commit message reworded to be more specific. arch/arm/cpu/arm926ejs/mxs/spl_power_init.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) di

Re: [PATCH 1/2] mxs: Fix VDDx brownout interrupt disable/enable

2023-07-04 Thread Cody Green
On Mon, Jul 3, 2023 at 5:40 PM Marek Vasut wrote: > > On 7/3/23 18:33, Cody Green wrote: > > HW_POWER_CTRL register contains brownout interrupt > > enable bits ENIRQ_VDDIO_BO, ENIRQ_VDDA_BO and > > ENIRQ_VDDD_BO. > > So what does this patch do (that is missing in th

[PATCH 2/2] mxs: Don't enable 4P2 reg if MXS is powered only from DCDC_BATT

2023-07-04 Thread Cody Green
x27; function if the MXS is powered only by the DCDC_BATT, because there is no reason to enable 4P2 regulator in this case. Also 5V brownout should not be enabled in 'mxs_power_init()' and linear regulator checks should be disabled in 'mxs_power_set_vddx()'. Signed-off-by: Cody Gr

[PATCH 1/2] mxs: Fix VDDx brownout interrupt disable/enable

2023-07-04 Thread Cody Green
HW_POWER_CTRL register contains brownout interrupt enable bits ENIRQ_VDDIO_BO, ENIRQ_VDDA_BO and ENIRQ_VDDD_BO. Signed-off-by: Cody Green Cc: Stefano Babic Cc: Marek Vasut Cc: Fabio Estevam --- arch/arm/cpu/arm926ejs/mxs/spl_power_init.c | 8 +--- 1 file changed, 5 insertions(+), 3