[U-Boot] [PATCH v5 3/3] spi: omap3: Convert to driver model

Ricard Tested-by: Christophe Ricard Signed-off-by: Jagan Teki Signed-off-by: Christophe Ricard --- Changes in v5: - Adding Christophe Ricard credit on omap3_spi driver dm conversion - Set priv->wordlen in omap3_spi_probe - Add OMAP3_SPI in drivers/spi/Kconfig Changes in v4: - rebase to mas

[U-Boot] [PATCH v5 2/3] spi: omap3: Make local functions as static

Attach static on local defined functions. Cc: Tom Rini Cc: Simon Glass Cc: Christophe Ricard Signed-off-by: Jagan Teki Signed-off-by: Christophe Ricard --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None drivers/spi/omap3_spi.c | 12 ++-- 1 file

[U-Boot] [PATCH v5 0/3] omap3_spi update after testing Jagan Teki v4 series.

in v5: - Few code style fixes reported by patman - Remove omap3_spi_txrx, omap3_spi_write, omap3_spi_read header in C file to avoid "externs should be avoided in .c files" patman warnings. - Adding Christophe Ricard credit on omap3_spi driver dm conversion - Set priv->wordlen in omap3

[U-Boot] [PATCH v5 1/3] spi: omap3: Move headers code inside the driver

Header file have macro's and register definition and some unneeded function proto types which becomes tunned further in future patches and entire driver code resides in one file for more readability. Cc: Tom Rini Cc: Simon Glass Cc: Christophe Ricard Signed-off-by: Jagan Teki Signed-o

Re: [U-Boot] [PATCH 3/4] spi: omap3: Convert to DM

patch 1 and 2 ? Best Regards Christophe On 10/02/2016 20:16, Jagan Teki wrote: On 8 February 2016 at 23:26, Jagan Teki wrote: On 8 February 2016 at 23:10, Tom Rini wrote: On Sat, Feb 06, 2016 at 11:27:21PM +0100, Christophe Ricard wrote: Hi Simon, Tom, I assume the approach you are taking is

Re: [U-Boot] [PATCH 3/4] spi: omap3: Convert to DM

, Simon Glass wrote: +Hans Hi Tom, On 21 January 2016 at 05:24, Tom Rini wrote: On Wed, Jan 20, 2016 at 07:46:15PM -0700, Simon Glass wrote: +Mugunthan, Tom On 17 January 2016 at 03:56, Christophe Ricard wrote: Convert omap3_spi driver to DM and keep compatibility with previous mode. Signed

[U-Boot] [PATCH v2 3/3] tpm: st33zp24: Add tpm st33zp24 spi support

Add support for TPM ST33ZP24 spi. The ST33ZP24 does have a spi interface. The transport protocol is proprietary. For spi we are relying only on DM_SPI. Reviewed-by: Simon Glass Signed-off-by: Christophe Ricard --- Changes in v2: - Adding Reviewed-by: Simon Glass README

[U-Boot] [PATCH v2 1/3] tpm: Rename tpm_tis_infineon.h to tpm_tis.h and move infineon specific stuff in tpm_infineon.c

Reviewed-by: Simon Glass Signed-off-by: Christophe Ricard --- Changes in v2: - Adding Reviewed-by: Simon Glass drivers/tpm/{tpm_tis_infineon.h => tpm_tis.h} | 17 + drivers/tpm/tpm_tis_infineon.c| 17 - 2 files changed, 17 insertions(+),

[U-Boot] [PATCH v2 2/3] tpm: st33zp24: Add tpm st33zp24 support with i2c

Add support for TPM ST33ZP24 family with i2c. For i2c we are relying only on DM_I2C. Reviewed-by: Simon Glass Signed-off-by: Christophe Ricard --- Changes in v2: - Adding Reviewed-by: Simon Glass README | 7 + drivers/tpm/Kconfig| 9

[U-Boot] [PATCH v2 0/3] Add support for st33zp24 i2c and spi TPMs

your guidance from my previous tentative and got able to convert omap24xx_i2c and omap3_spi drivers to DM. I will send them in a separate patchset for your review. Best Regards Christophe Changes in v2: - Adding Reviewed-by: Simon Glass Christophe Ricard (3): tpm: Rename tpm_tis_infineon.h to

[U-Boot] [PATCH v2 2/2] tpm: tpm_tis_lpc: fix typo

TPM_TIS_LPC is connected to the LPC bus, not I2C. Reviewed-by: Simon Glass Signed-off-by: Christophe Ricard --- Changes in v2: - Adding Reviewed-by: Simon Glass drivers/tpm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tpm/Kconfig b/drivers/tpm/Kconfig

[U-Boot] [PATCH v2 0/2] TPM minor fixes

Hi Simon, Please find in this serie one bug fix and a typo cleanup. This series is only adding mention to your review Best Regards Christophe Changes in v2: - Adding Reviewed-by: Simon Glass Christophe Ricard (2): tpm: Fix fault in case CONFIG_DM_TPM is set without any TPM tpm

[U-Boot] [PATCH v2 1/2] tpm: Fix fault in case CONFIG_DM_TPM is set without any TPM

In case CONFIG_DM_TPM was set without any TPM chipset configured a fault was generated (NULL pointer access). Reviewed-by: Simon Glass Signed-off-by: Christophe Ricard --- Changes in v2: - Adding Reviewed-by: Simon Glass common/cmd_tpm.c | 2 +- lib/tpm.c| 2 +- 2 files changed, 2

Re: [U-Boot] [PATCH 5/5] i2c: omap24xx: Convert fully to DM_I2C

for the 5th one ? Best Regards Christophe 2016-01-18 7:04 GMT+01:00 Heiko Schocher : > Hello Christophe, > > Am 17.01.2016 um 12:09 schrieb Christophe Ricard: > >> For several reasons: >> - code clarity >> - DM trends in u-boot >> ... >> >> It i

[U-Boot] [PATCH 5/5] i2c: omap24xx: Convert fully to DM_I2C

For several reasons: - code clarity - DM trends in u-boot ... It is better to make omap24xx_i2c driver 100% DM_I2C based. Signed-off-by: Christophe Ricard --- drivers/i2c/omap24xx_i2c.c | 447 + drivers/i2c/omap24xx_i2c.h | 154 2

[U-Boot] [PATCH 0/5] Convert omap24xx-i2c driver to Driver Model

Hi Simon, This patchset tries to convert the TI omap24xx_i2c driver to Driver Model. It has been tested on a TI BeagleBoard xM. Best Regards Christophe Christophe Ricard (5): i2c: omap24xx: Convert to DM i2c: omap24xx: Fix waitdelay value for I2C HS i2c: omap24xx: Remove unused

[U-Boot] [PATCH 4/5] i2c: omap24xx: Fix high speed trimming calculation

Work based on i2c-omap.c from linux kernel. fsscll/fssclh and hsscll/hssclh was always negative in high speed. i2c high speed frequency start after 400Khz. Signed-off-by: Christophe Ricard --- drivers/i2c/omap24xx_i2c.c | 17 + 1 file changed, 9 insertions(+), 8 deletions

[U-Boot] [PATCH 1/5] i2c: omap24xx: Convert to DM

Convert omap24xx_i2c driver to DM Signed-off-by: Christophe Ricard --- drivers/i2c/Kconfig| 8 ++ drivers/i2c/omap24xx_i2c.c | 280 +++-- 2 files changed, 277 insertions(+), 11 deletions(-) diff --git a/drivers/i2c/Kconfig b/drivers/i2c

[U-Boot] [PATCH 2/5] i2c: omap24xx: Fix waitdelay value for I2C HS

After several testings and experiment, it appears that waitdelay calculation formula was giving different behavior on the i2c status registers. Experiment shows waitdelay needs to be extended at least 4 times to get proper results. Signed-off-by: Christophe Ricard --- drivers/i2c

[U-Boot] [PATCH 3/5] i2c: omap24xx: Remove unused I2C_WAIT macro

I2C_WAIT macro is not used in the code. 200 is bound to a fixed 10 Hz i2c speed based on an existing formula: ( 1000 / speed ) * 2 where speed = 100 000. Signed-off-by: Christophe Ricard --- drivers/i2c/omap24xx_i2c.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/i2c

[U-Boot] [PATCH 3/4] spi: omap3: Convert to DM

Convert omap3_spi driver to DM and keep compatibility with previous mode. Signed-off-by: Christophe Ricard --- drivers/spi/Kconfig | 6 + drivers/spi/omap3_spi.c | 439 ++-- drivers/spi/omap3_spi.h | 14 +- 3 files changed, 402 insertions

[U-Boot] [PATCH 4/4] spi: omap3: Convert fully to DM_SPI

For several reasons: - code clarity - DM trends in u-boot ... It is better to make omap3_spi driver 100% DM_SPI based. Signed-off-by: Christophe Ricard --- drivers/spi/omap3_spi.c | 474 +++- drivers/spi/omap3_spi.h | 121 2 files

[U-Boot] [PATCH 0/4] Convert omap3-spi driver to Driver Model

Hi Simon, This patchset tries to convert the TI omap3_spi driver to Driver Model. It has been tested on a TI BeagleBoard xM. Best Regards Christophe Christophe Ricard (4): spi: omap3: Remove unused variable irqstatus in omap3_spi_txrx spi: spi-uclass: Set slave wordlen with

[U-Boot] [PATCH 1/4] spi: omap3: Remove unused variable irqstatus in omap3_spi_txrx

Remove unused variable irqstatus in omap3_spi_txrx Signed-off-by: Christophe Ricard --- drivers/spi/omap3_spi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/spi/omap3_spi.c b/drivers/spi/omap3_spi.c index 85f9e85..95cdfa3 100644 --- a/drivers/spi/omap3_spi.c +++ b/drivers/spi

[U-Boot] [PATCH 2/4] spi: spi-uclass: Set slave wordlen with SPI_DEFAULT_WORDLEN

In some case wordlen may not be set. Use SPI_DEFAULT_WORDLEN as default. Signed-off-by: Christophe Ricard --- drivers/spi/spi-uclass.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-uclass.c b/drivers/spi/spi-uclass.c index 677c020..5561f36 100644 --- a/drivers/spi/spi

[U-Boot] [PATCH 1/2] tpm: Fix fault in case CONFIG_DM_TPM is set without any TPM

In case CONFIG_DM_TPM was set without any TPM chipset configured a fault was generated (NULL pointer access). Signed-off-by: Christophe Ricard --- common/cmd_tpm.c | 2 +- lib/tpm.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common/cmd_tpm.c b/common

[U-Boot] [PATCH 2/2] tpm: tpm_tis_lpc: fix typo

TPM_TIS_LPC is connected to the LPC bus, not I2C. Signed-off-by: Christophe Ricard --- drivers/tpm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tpm/Kconfig b/drivers/tpm/Kconfig index 31b35f7..5a75f85 100644 --- a/drivers/tpm/Kconfig +++ b/drivers/tpm

[U-Boot] [PATCH 0/2] TPM minor fixes

Hi Simon, Please find in this serie one bug fix and a typo cleanup. Best Regards Christophe Christophe Ricard (2): tpm: Fix fault in case CONFIG_DM_TPM is set without any TPM tpm: tpm_tis_lpc: fix typo common/cmd_tpm.c| 2 +- drivers/tpm/Kconfig | 2 +- lib/tpm.c | 2

[U-Boot] [PATCH 2/3] tpm: st33zp24: Add tpm st33zp24 support with i2c

Add support for TPM ST33ZP24 family with i2c. For i2c we are relying only on DM_I2C. Signed-off-by: Christophe Ricard --- README | 7 + drivers/tpm/Kconfig| 9 + drivers/tpm/Makefile | 1 + drivers/tpm/tpm_tis_st33zp24_i2c.c

[U-Boot] [PATCH 3/3] tpm: st33zp24: Add tpm st33zp24 spi support

Add support for TPM ST33ZP24 spi. The ST33ZP24 does have a spi interface. The transport protocol is proprietary. For spi we are relying only on DM_SPI. Signed-off-by: Christophe Ricard --- README | 4 + drivers/tpm/Kconfig| 9 + drivers/tpm

[U-Boot] [PATCH 1/3] tpm: Rename tpm_tis_infineon.h to tpm_tis.h and move infineon specific stuff in tpm_infineon.c

Signed-off-by: Christophe Ricard --- drivers/tpm/{tpm_tis_infineon.h => tpm_tis.h} | 17 + drivers/tpm/tpm_tis_infineon.c| 17 - 2 files changed, 17 insertions(+), 17 deletions(-) rename drivers/tpm/{tpm_tis_infineon.h => tpm_tis.h} (86%)

[U-Boot] [PATCH 0/3] Add support for st33zp24 i2c and spi TPMs

guidance from my previous tentative and got able to convert omap24xx_i2c and omap3_spi drivers to DM. I will send them in a separate patchset as an RFC for your review. Best Regards Christophe Christophe Ricard (3): tpm: Rename tpm_tis_infineon.h to tpm_tis.h and move infineon specific stuff

[U-Boot] [PATCH v4 2/4] dm: tpm: Add Driver Model support for tpm_atmel_twi driver

tpm_atmel_twi can fit perfectly to the new UCLASS_TPM class. Signed-off-by: Christophe Ricard Reviewed-by: Tom Rini --- Changes in v4: None Changes in v3: None Changes in v2: None .../controlcenterd_36BIT_SDCARD_DEVELOP_defconfig | 2 + configs/controlcenterd_36BIT_SDCARD_defconfig

[U-Boot] [PATCH v4 1/4] dm: tpm: Move tpm_tis_i2c to tpm_i2c_infineon

As there is no TCG specification or recommendation for i2c TPM 1.2, move tpm_tis_i2c driver to tpm_i2c_infineon. Other tpm vendors like Atmel or STMicroelectronics may have a different transport protocol for i2c. Signed-off-by: Christophe Ricard Reviewed-by: Tom Rini --- Changes in v4

[U-Boot] [PATCH v4 3/4] dm: tpm: Remove every compilation switch for TPM driver model

As every TPM drivers support UCLASS_TPM, we can only rely on DM_TPM functions. This simplify a bit the code. Signed-off-by: Christophe Ricard Reviewed-by: Tom Rini --- Changes in v4: None Changes in v3: None Changes in v2: None common/cmd_tpm.c | 13 + drivers/tpm

[U-Boot] [PATCH v4 0/4] Move tpm_tis_i2c to tpm_tis_infineon and convert last tpm driver to use DM_TPM

switch for TPM driver model Changes in v3: - Adding mention to Tom Rini review Changes in v2: - Change existing users of config to use renamed Kconfig Christophe Ricard (4): dm: tpm: Move tpm_tis_i2c to tpm_i2c_infineon dm: tpm: Add Driver Model support for tpm_atmel_twi driver dm: tpm

[U-Boot] [PATCH v4 4/4] dm: tpm: Every TPM drivers should depends on DM_TPM

Every TPM drivers should now depends on DM_TPM and not only TPM. Signed-off-by: Christophe Ricard Reviewed-by: Tom Rini --- Changes in v4: None Changes in v3: None Changes in v2: None drivers/tpm/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tpm

Re: [U-Boot] [PATCH v3 2/4] dm: tpm: Add Driver Model support for tpm_atmel_twi driver

ober 2015 at 15:27, Simon Glass wrote: > > On 20 September 2015 at 21:00, Christophe Ricard > > wrote: > >> tpm_atmel_twi can fit perfectly to the new UCLASS_TPM class. > >> > >> Signed-off-by: Christophe Ricard > >> Reviewed-by: Tom Rini >

Re: [U-Boot] [PATCH v2] dm: tpm: Drop CONFIG_DM_TPM

Hi Simon, Acked-by: Christophe Ricard Best Regards Christophe On 03/10/2015 14:39, Simon Glass wrote: Now that all TPM drivers use driver model, we can drop the special driver model CONFIG option. Signed-off-by: Simon Glass --- Changes in v2: - Fix missing 'depends on DM' left

Re: [U-Boot] [PATCH v3 0/4] Move tpm_tis_i2c to tpm_tis_infineon and convert last tpm driver to use DM_TPM

Hi Simon, Any news on this patch serie ? Best Regards Christophe On 20/09/2015 22:00, Christophe Ricard wrote: Hi Simon, This patch serie move tpm_tis_i2c driver to tpm_tis_infineon. It also convert the latest tpm driver tpm_atmel_twi to DM_TPM. In this version i am only adding mention to

[U-Boot] [PATCH v3 4/4] dm: tpm: Every TPM drivers should depends on DM_TPM

Every TPM drivers should now depends on DM_TPM and not only TPM. Signed-off-by: Christophe Ricard Reviewed-by: Tom Rini --- Changes in v3: None drivers/tpm/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tpm/Kconfig b/drivers/tpm/Kconfig index

[U-Boot] [PATCH v3 3/4] dm: tpm: Remove every compilation switch for TPM driver model

As every TPM drivers support UCLASS_TPM, we can only rely on DM_TPM functions. This simplify a bit the code. Signed-off-by: Christophe Ricard Reviewed-by: Tom Rini --- Changes in v3: None common/cmd_tpm.c | 13 + drivers/tpm/tpm_tis_infineon.c | 1 - include/tis.h

[U-Boot] [PATCH v3 0/4] Move tpm_tis_i2c to tpm_tis_infineon and convert last tpm driver to use DM_TPM

Hi Simon, This patch serie move tpm_tis_i2c driver to tpm_tis_infineon. It also convert the latest tpm driver tpm_atmel_twi to DM_TPM. In this version i am only adding mention to Tom Rini review Best Regards Christophe Changes in v3: - Adding mention to Tom Rini review Christophe Ricard (4

[U-Boot] [PATCH v3 2/4] dm: tpm: Add Driver Model support for tpm_atmel_twi driver

tpm_atmel_twi can fit perfectly to the new UCLASS_TPM class. Signed-off-by: Christophe Ricard Reviewed-by: Tom Rini --- Changes in v3: None drivers/tpm/Kconfig | 2 +- drivers/tpm/tpm_atmel_twi.c | 74 - 2 files changed, 54 insertions

[U-Boot] [PATCH v3 1/4] dm: tpm: Move tpm_tis_i2c to tpm_i2c_infineon

As there is no TCG specification or recommendation for i2c TPM 1.2, move tpm_tis_i2c driver to tpm_i2c_infineon. Other tpm vendors like Atmel or STMicroelectronics may have a different transport protocol for i2c. Signed-off-by: Christophe Ricard Reviewed-by: Tom Rini --- Changes in v3

[U-Boot] [PATCH v2 4/4] dm: tpm: Every TPM drivers should depends on DM_TPM

Every TPM drivers should now depends on DM_TPM and not only TPM. Signed-off-by: Christophe Ricard --- Changes in v2: None drivers/tpm/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tpm/Kconfig b/drivers/tpm/Kconfig index ff2cdbe..3ab652c 100644 --- a

[U-Boot] [PATCH v2 3/4] dm: tpm: Remove every compilation switch for TPM driver model

As every TPM drivers support UCLASS_TPM, we can only rely on DM_TPM functions. This simplify a bit the code. Signed-off-by: Christophe Ricard --- Changes in v2: None common/cmd_tpm.c | 13 + drivers/tpm/tpm_tis_infineon.c | 1 - include/tis.h | 60

[U-Boot] [PATCH v2 2/4] dm: tpm: Add Driver Model support for tpm_atmel_twi driver

tpm_atmel_twi can fit perfectly to the new UCLASS_TPM class. Signed-off-by: Christophe Ricard --- Changes in v2: None drivers/tpm/Kconfig | 2 +- drivers/tpm/tpm_atmel_twi.c | 74 - 2 files changed, 54 insertions(+), 22 deletions(-) diff

[U-Boot] [PATCH v2 1/4] dm: tpm: Move tpm_tis_i2c to tpm_i2c_infineon

As there is no TCG specification or recommendation for i2c TPM 1.2, move tpm_tis_i2c driver to tpm_i2c_infineon. Other tpm vendors like Atmel or STMicroelectronics may have a different transport protocol for i2c. Signed-off-by: Christophe Ricard --- Changes in v2: - Change existing users of

[U-Boot] [PATCH v2 0/4] Move tpm_tis_i2c to tpm_tis_infineon and convert last tpm driver to use DM_TPM

Hi Simon, This patch serie move tpm_tis_i2c driver to tpm_tis_infineon. It also convert the latest tpm driver tpm_atmel_twi to DM_TPM. Apologies again for the delay :(. Best Regards Christophe Changes in v2: - Change existing users of config to use renamed Kconfig Christophe Ricard (4): dm

Re: [U-Boot] [PATCH 1/3] tpm: Move tpm_tis_i2c to tpm_i2c_infineon

, Christophe Ricard wrote: As there is no TCG specification or recommendation for i2c TPM 1.2, move tpm_tis_i2c driver to tpm_i2c_infineon. Other tpm vendors like atmel or stmicroelectronics may have a different transport protocol for i2c. Signed-off-by: Christophe Ricard --- README

Re: [U-Boot] [PATCH v2 20/28] tpm: Check that parse_byte_string() has data to parse

Hi Simon, Le 25/08/2015 06:13, Simon Glass a écrit : Hi Christophe, On 24 August 2015 at 14:22, Christophe Ricard wrote: Hi Simon, Print an error ? Are you sure ? I guess the comment is not accurate ;). Well returning NULL from parse_byte_string() will cause an error to be printed by the

Re: [U-Boot] [PATCH v2 06/28] tpm: Move the I2C TPM code into one file

Hi Simon, Le 25/08/2015 06:13, Simon Glass a écrit : Hi Christophe, On 24 August 2015 at 14:24, Christophe Ricard wrote: Hi Simon, I don't disagree with this patch (from patch 6 to patch 12). However, i believe it would be better to have this driver renamed tpm_i2c_infineon as shown

Re: [U-Boot] [PATCH v2 03/28] tpm: Add Kconfig options for TPMs

Hi Simon, This one looks good to me. Acked-by: Christophe Ricard Best Regards Christophe On 23/08/2015 02:31, Simon Glass wrote: Add new Kconfig options for TPMs in preparation for moving boards to use Kconfig for TPM configuration. Signed-off-by: Simon Glass --- Changes in v2: - Add a

Re: [U-Boot] [PATCH v2 06/28] tpm: Move the I2C TPM code into one file

Hi Simon, I don't disagree with this patch (from patch 6 to patch 12). However, i believe it would be better to have this driver renamed tpm_i2c_infineon as shown in my previous patch: http://lists.denx.de/pipermail/u-boot/2015-August/223582.html Could you update this ? Best Regards Christoph

Re: [U-Boot] [PATCH v2 27/28] tpm: Enable 'tpmtest' command for Chrome OS boards with TPMs

Acked-by: Christophe Ricard On 23/08/2015 02:31, Simon Glass wrote: This command provides a few useful tests so enable it for common boards. Signed-off-by: Simon Glass --- Changes in v2: None configs/chromebook_link_defconfig | 1 + configs/chromebox_panther_defconfig | 1 + configs

Re: [U-Boot] [PATCH v2 26/28] dm: tpm: Add a 'tpmtest' command

Hi Simon, Acked-by: Christophe Ricard I will try those tpm tests. Best Regards Christophe On 23/08/2015 02:31, Simon Glass wrote: These tests come from Chrome OS code. They are not particularly tidy but can be useful for checking that the TPM is behaving correctly. Some knowledge of TPM

Re: [U-Boot] [PATCH v2 23/28] dm: tpm: Convert LPC driver to driver model

Hi Simon, Acked-by: Christophe Ricard Best Regards Christophe On 23/08/2015 02:31, Simon Glass wrote: Convert the tpm_tis_lpc driver to use driver model and update boards which use it. Signed-off-by: Simon Glass --- Changes in v2: - Update driver for the new uclass interface configs

Re: [U-Boot] [PATCH v2 22/28] dm: tpm: Convert I2C driver to driver model

Hi Simon, This one looks good to me. Acked-by: Christophe Ricard Best Regards Christophe On 23/08/2015 02:31, Simon Glass wrote: Convert the tpm_tis_i2c driver to use driver model and update boards which use it. Signed-off-by: Simon Glass --- Changes in v2: - Update driver for v2 TPM

Re: [U-Boot] [PATCH v2 25/28] tpm: Add functions to access flags and permissions

Acked-by: Christophe Ricard On 23/08/2015 02:31, Simon Glass wrote: Add a few new functions which will be used by the test command in a future patch. Signed-off-by: Simon Glass --- Changes in v2: - Add new patch with functions to access flags and permissions include/tpm.h | 49

Re: [U-Boot] [PATCH v2 20/28] tpm: Check that parse_byte_string() has data to parse

Hi Simon, Print an error ? Are you sure ? I guess the comment is not accurate ;). Best Regards Christophe On 23/08/2015 02:31, Simon Glass wrote: Rather then crashing when there is no data, print an error. Acked-by: Christophe Ricard Signed-off-by: Simon Glass --- Changes in v2: None

Re: [U-Boot] [PATCH v2 21/28] exynos: x86: dts: Add tpm nodes to the device tree for Chrome OS devices

Hi Simon, This one looks good to me. Acked-by: Christophe Ricard Best Regards Christophe On 23/08/2015 02:31, Simon Glass wrote: Add a TPM node to the various Chromebooks so that driver can be converted to driver model. Signed-off-by: Simon Glass --- Changes in v2: - Add tpm device tree

Re: [U-Boot] [PATCH v2 17/28] dm: i2c: Add a command to adjust the offset length

Hi Simon, This one is fine with me. Acked-by: Christophe Ricard Best Regards Christophe On 23/08/2015 02:31, Simon Glass wrote: I2C chips can support a register offset, with registers accessible by sending this offset as the first part of any read or write transaction. Most I2C chips have a

Re: [U-Boot] [PATCH v2 18/28] tpm: Report tpm errors on the command line

Hi Simon, This one looks good to me. Acked-by: Christophe Ricard Best Regards Christophe On 23/08/2015 02:31, Simon Glass wrote: When a 'tpm' command fails, we set the return code but give no indication of failure. This can be confusing. Add an error message when any tpm com

Re: [U-Boot] [PATCH v2 15/28] dm: tpm: Add a uclass for Trusted Platform Modules

Hi Simon, This one looks good to me as well. Acked-by: Christophe Ricard Best Regards Christophe On 23/08/2015 02:31, Simon Glass wrote: Add a new uclass for TPMs which uses almost the same TIS (TPM Interface Specification) as is currently implemented. Since init() is handled by the normal

Re: [U-Boot] [PATCH v2 16/28] dm: tpm: Convert the TPM command and library to driver model

Hi Simon, This one looks good to me. Actually, i think atmel driver is trivial to move to driver model following the current TPM class. I would assume this will be changed very soon. Acked-by: Christophe Ricard Best Regards Christophe On 23/08/2015 02:31, Simon Glass wrote: Add driver model

Re: [U-Boot] [PATCH v2 12/28] tpm: tpm_tis_i2c: Simplify init code

Hi Simon, This one looks good to me. Acked-by: Christophe Ricard Best Regards Christophe On 23/08/2015 02:31, Simon Glass wrote: Move all the init and uninit code into one place. Signed-off-by: Simon Glass --- Changes in v2: None drivers/tpm/tpm_tis_i2c.c | 33

Re: [U-Boot] [PATCH v2 00/28] dm: Convert TPM drivers to driver model

Hi Simon, I like your updates but i have few comments: - I believe tpm_tis_i2c should be renamed as tpm_tis_infineon to be aligned with Linux naming. Also as there is no standard for i2c for tpm, every vendor does have their own low level transport protocol. I believe this is confusing. - I t

Re: [U-Boot] [PATCH v2 04/28] tpm: Convert board config TPM options to Kconfig

Hi Simon, This one looks good to me. Acked-by: Christophe Ricard Best Regards Christophe On 23/08/2015 02:31, Simon Glass wrote: Convert all TPM options to Kconfig and tidy up. Signed-off-by: Simon Glass Acked-by: Christophe Ricard --- Changes in v2: None configs

Re: [U-Boot] [PATCH 3/3] tpm: Add st33zp24 tpm with i2c and spi phy

Hi Simon, On 13/08/2015 17:55, Simon Glass wrote: Hi Christophe, On 9 August 2015 at 07:19, Christophe Ricard wrote: Add TPM st33zp24 tpm with i2c and spi phy. This is a port from Linux. This driver relies on tpm uclass. Signed-off-by: Christophe Ricard --- README

Re: [U-Boot] [PATCH 00/25] dm: Convert TPM drivers to driver model

Hi Simon, Thanks for the review and your comments. Please see mine below: On 13/08/2015 03:30, Simon Glass wrote: Hi Christophe, On 11 August 2015 at 15:50, christophe.ricard wrote: Hi Simon, I pretty much like the move to driver model for TPM. However, i have some few remarks: The current

Re: [U-Boot] [PATCH 2/3] tpm: Initial work to introduce TPM driver model

Hi Simon, On 13/08/2015 17:55, Simon Glass wrote: Hi Christophe, On 9 August 2015 at 07:19, Christophe Ricard wrote: drivers/tpm/tpm.c is a TPM core driver port from Linux. So far in u-boot only infineon i2c driver is using it but it could fit for others... Introduce a new tpm uclass so

Re: [U-Boot] [PATCH 08/25] tpm: tpm_tis_i2c: Drop struct tpm_vendor_specific

Hi Simon, On 13/08/2015 03:30, Simon Glass wrote: Hi Christophe, On 11 August 2015 at 15:47, christophe.ricard wrote: Hi Simon, Locality concept are valid almost on any chip assuming if no locality are supported the default one is locality 0. I would leave this change open for discussion. H

Re: [U-Boot] [PATCH 07/25] tpm: tpm_tis_i2c: Drop unnecessary methods

Hi Simon, On 13/08/2015 03:30, Simon Glass wrote: Hi Christophe, On 11 August 2015 at 15:47, christophe.ricard wrote: Hi Simon, As per my comment on patch 6, i would disagree as well on this one. It tpm_vendor_specific structure is convenient for ST33ZP24 for example. Best Regards Christoph

Re: [U-Boot] [PATCH 06/25] tpm: Move the I2C TPM code into one file

Hi Simon, On 13/08/2015 03:30, Simon Glass wrote: Hi Christophe, On 11 August 2015 at 15:42, christophe.ricard wrote: Hi Simon, I would basically disagree with this one. The code from tpm.c you are merging into tpm_tis_i2c may not only be used by tpm_tis_i2c as it is using data from TPM stan

Re: [U-Boot] [PATCH 0/3] Introduce TPM driver model and STMicroelectronics ST33ZP24 TPMs

> On 9 August 2015 at 07:19, Christophe Ricard > wrote: > > > > Hi, > > > > This patch serie introduce TPM driver model allowing to instantiate a TPM > > using U_BOOT_DEVICE macro for platform_data or device tree. > > > > As an information, there is no T

[U-Boot] [PATCH 3/3] tpm: Add st33zp24 tpm with i2c and spi phy

Add TPM st33zp24 tpm with i2c and spi phy. This is a port from Linux. This driver relies on tpm uclass. Signed-off-by: Christophe Ricard --- README | 11 + drivers/tpm/Makefile| 1 + drivers/tpm/st33zp24/Makefile | 7

[U-Boot] [PATCH 2/3] tpm: Initial work to introduce TPM driver model

, tpm_register_hardware & tpm_remove_hardware. Finally tis_init, tis_open, tis_close, tis_sendrecv are using ops allowing to introduce proprietary instructions. Also this patch convert tpm_i2c_infineon for using this tpm uclass. Signed-off-by: Christophe Ricard --- RE

[U-Boot] [PATCH 1/3] tpm: Move tpm_tis_i2c to tpm_i2c_infineon

As there is no TCG specification or recommendation for i2c TPM 1.2, move tpm_tis_i2c driver to tpm_i2c_infineon. Other tpm vendors like atmel or stmicroelectronics may have a different transport protocol for i2c. Signed-off-by: Christophe Ricard --- README

[U-Boot] [PATCH 0/3] Introduce TPM driver model and STMicroelectronics ST33ZP24 TPMs

, I2C, SPI) keeping the TPM command duration in common. Also, this serie introduce TPM1.2 from STMicroelectronics ST33ZP24 with I2C and SPI support. It has been ported from existing Linux drivers. This has been tested on Beagleboard xM. Best Regards Christophe Christophe Ricard (3): tpm: Move