Re: [U-Boot] [PATCH 6/8] usb: r8a66597: Convert to USB DM

2019-08-15 Thread Chris Brandt
On Thu, Aug 15, 2019, Marek Vasut wrote: > Convert the R8A66597 USB driver to DM and add support for DT probing. > Drop support for legacy non-DM and non-DT probing, since there are no > platform using that. I like the switch to DM :) Chris ___ U-Boot

Re: [U-Boot] [PATCH 1/8] usb: r8a66597: Remove CONFIG_SUPERH_ON_CHIP_R8A66597

2019-08-15 Thread Chris Brandt
On Thu, Aug 15, 2019, Marek Vasut wrote: > Signed-off-by: Marek Vasut > Cc: Chris Brandt The series Looks good. Thanks Marek! Chris ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2] serial: sh: Add support for R7S72100 (RZ/A1)

2018-01-20 Thread Chris Brandt
On Friday, January 19, 2018 1, Marek Vasut wrote: > I wonder if we really cannot get to the point where we can have a > universal build, add DT to it and be done with a board port. That'd be > real cool and it'd make things easy for people using the chip ... :) Then I'd be out of a job! ;) _

Re: [U-Boot] [PATCH v2] serial: sh: Add support for R7S72100 (RZ/A1)

2018-01-19 Thread Chris Brandt
On Friday, January 19, 2018, Marek Vasut wrote: > > u-boot has a specific job and is compiled for a specific board. There is > > no need for multi board booting. > > For now at least, it'd be real neat to have one u-boot build for generic > rz/a1 , concatenate DT to it and be done with a board por

Re: [U-Boot] [PATCH v2] serial: sh: Add support for R7S72100 (RZ/A1)

2018-01-19 Thread Chris Brandt
On Friday, January 19, 2018, Marek Vasut wrote: > > But as for DT, I think that's still a bit overkill for RZ/A series. > > Why so? Honestly, I don't see the value in it for small embedded systems. u-boot has a specific job and is compiled for a specific board. There is no need for multi board b

Re: [U-Boot] [PATCH v2] serial: sh: Add support for R7S72100 (RZ/A1)

2018-01-19 Thread Chris Brandt
On Friday, January 19, 2018 1, Marek Vasut wrote: > Applied, thanks ! Thank you! > btw. are you planning to do DT/DM conversion of the RZ/A1 ? DM, yes. DT, no We're working on adding DM to RZ/A's I2C and timer drivers now. Then we'll try submitting it. But as for DT, I think that's still a b

[U-Boot] [PATCH v2] serial: sh: Add support for R7S72100 (RZ/A1)

2018-01-16 Thread Chris Brandt
Add support for RZ/A1 series SoCs. Signed-off-by: Chris Brandt --- v2: * Rebased against current tree --- drivers/serial/serial_sh.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/serial/serial_sh.h b/drivers/serial/serial_sh.h index 1b8d742f1c..1ea95509d7

Re: [U-Boot] [PATCH] serial: sh: Add support for R7S72100 (RZ/A1)

2017-12-12 Thread Chris Brandt
On Monday, November 27, 2017, Chris Brandt wrote: > Add support for RZ/A1 series SoCs. > > Signed-off-by: Chris Brandt > --- > drivers/serial/serial_sh.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/serial/serial_sh.h b/drivers/se

[U-Boot] [PATCH v2] usb: r8a66597: convert wait loop to readw_poll_timeout

2017-11-29 Thread Chris Brandt
It is better to use an existing wait loop implementation. Signed-off-by: Chris Brandt --- v2: * return -ETIMEDOUT instead of -1 --- drivers/usb/host/r8a66597-hcd.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/usb/host/r8a66597-hcd.c b/drivers/usb

Re: [U-Boot] [PATCH] usb: r8a66597: convert wait loop to readw_poll_timeout

2017-11-29 Thread Chris Brandt
On Wednesday, November 29, 2017, Fabio Estevam wrote: > > + if (readw_poll_timeout(r8a66597->reg + DCPCTR, dcpctr, > > + dcpctr & BSTS, 1000) < 0) { > > + printf("DCPCTR BSTS timeout!\n"); > > + return -1

[U-Boot] [PATCH] usb: r8a66597: convert wait loop to readw_poll_timeout

2017-11-29 Thread Chris Brandt
It is better to use an existing wait loop implementation. Signed-off-by: Chris Brandt --- drivers/usb/host/r8a66597-hcd.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/usb/host/r8a66597-hcd.c b/drivers/usb/host/r8a66597-hcd.c index 28d2bc8454

Re: [U-Boot] [PATCH] usb: r8a66597: Add support for RZ/A series

2017-11-29 Thread Chris Brandt
On Tuesday, November 28, 2017, Marek Vasut wrote: > >>> So, I can't use wait_for_bit() > >> > >> Can we somehow extend wait_for_bit() ? > > > > It's a nice function, so it would be good if it worked with more than > > just 32-bit registers. > > > > However, it's used in 98 places at the moment, so

Re: [U-Boot] [PATCH] usb: r8a66597: Add support for RZ/A series

2017-11-28 Thread Chris Brandt
On Monday, November 27, 2017 1, Marek Vasut wrote: > > wait_for_bit() wants you to pass a direct address of a 32-bit register. > > The register I am waiting for is a 16-bit register and the hardware > > manual doesn't say 32-bit is allowed. > > When I do a 32-bit read on that address, I actually ge

[U-Boot] [PATCH v2] usb: r8a66597: Add support for RZ/A series

2017-11-27 Thread Chris Brandt
While the USB HW in the RZ/A is basically the same, there are some differences from the original versions that were in the SH SoCs. Signed-off-by: Chris Brandt --- v2 * Changed to CONFIG_RZA_USB to be set in Kconfig * Fixed multi-line comments * Switched to using setbits/clrbits --- drivers

Re: [U-Boot] [PATCH] usb: r8a66597: Add support for RZ/A series

2017-11-27 Thread Chris Brandt
Hello Marek, On Friday, November 17, 2017, Marek Vasut wrote: > > +#ifdef RZA_USB > > + dcpctr = r8a66597_read(r8a66597, DCPCTR); > > use wait_for_bit() . > > > + if ((dcpctr & PID) == PID_BUF) { > > + timeout2 = 1; > > + while (!(dcpctr & BSTS)) { > > +

[U-Boot] [PATCH] serial: sh: Add support for R7S72100 (RZ/A1)

2017-11-27 Thread Chris Brandt
Add support for RZ/A1 series SoCs. Signed-off-by: Chris Brandt --- drivers/serial/serial_sh.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/serial/serial_sh.h b/drivers/serial/serial_sh.h index 4d27122243..365d944b62 100644 --- a/drivers/serial/serial_sh.h +++ b

Re: [U-Boot] [PATCH] mmc: sh_mmcif: RZ/A1 does not support HS mode

2017-11-27 Thread Chris Brandt
On Monday, November 27, 2017, Jaehoon Chung wrote: > On 11/14/2017 05:41 AM, Chris Brandt wrote: > > Since RZ/A1 (R7S72100) does not support HS mode, remove it from the > > host caps. > > Doesn't HS mode? Then it's only supported the legacy mode? Sorry, ple

Re: [U-Boot] [PATCH] usb: r8a66597: Add support for RZ/A series

2017-11-17 Thread Chris Brandt
Thanks for the review. On Friday, November 17, 2017, Marek Vasut wrote: > > +#ifndef RZA_USB > > This should be turned into Kconfig entry, some CONFIG_... So you want RZA_USB in Kconfig, but is it OK if it is automatically selected when an RZ/A device is selected? For example: config R7S72100

Re: [U-Boot] [PATCH] mmc: sd_sdhi: add support for 32-bit data buffer

2017-11-14 Thread Chris Brandt
Hi Marek, On Tuesday, November 14, 2017, Marek Vasut wrote: > On 11/13/2017 09:51 PM, Chris Brandt wrote: > > Some controllers have a 32-bit data buffer register and do not allow > > any other access besides 32-bit read/write. > > > > Signed-off-by: Chris Brandt >

[U-Boot] [PATCH] usb: r8a66597: Add support for RZ/A series

2017-11-13 Thread Chris Brandt
While the USB HW in the RZ/A is basically the same, there are some differences from the original versions that were in the SH4 SoCs. Signed-off-by: Chris Brandt --- drivers/usb/host/r8a66597-hcd.c | 46 + drivers/usb/host/r8a66597.h | 25

[U-Boot] [PATCH] mmc: sd_sdhi: add support for 32-bit data buffer

2017-11-13 Thread Chris Brandt
Some controllers have a 32-bit data buffer register and do not allow any other access besides 32-bit read/write. Signed-off-by: Chris Brandt --- arch/arm/mach-rmobile/include/mach/sh_sdhi.h | 1 + drivers/mmc/sh_sdhi.c| 21 - 2 files changed, 21

[U-Boot] [PATCH] mmc: sh_mmcif: RZ/A1 does not support HS mode

2017-11-13 Thread Chris Brandt
Since RZ/A1 (R7S72100) does not support HS mode, remove it from the host caps. Signed-off-by: Chris Brandt --- drivers/mmc/sh_mmcif.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/mmc/sh_mmcif.c b/drivers/mmc/sh_mmcif.c index 1ff59f06d5..4b62795044 100644 --- a/drivers/mmc

Re: [U-Boot] Where should Renesas RZ/A go under arch/arm/ ????

2017-11-13 Thread Chris Brandt
Hello Nobuhiro On Sunday, November 12, 2017, Nobuhiro Iwamatsu wrote: > >> Maybe we can compromise on everything in mach-renesas?? > > > > OK, I can go with mach-renesas, thanks again! > > +1 > > Chirs,: > The reason we are using mach-rmobile is that the code merged first was > rmobile SoC. > As

[U-Boot] [PATCH] cosmetic: rmobile: renesas spelled wrong

2017-11-03 Thread Chris Brandt
Renesas was spelled wrong. Signed-off-by: Chris Brandt --- arch/arm/mach-rmobile/Kconfig.32 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-rmobile/Kconfig.32 b/arch/arm/mach-rmobile/Kconfig.32 index 89588aaf72..49d6206ac2 100644 --- a/arch/arm/mach-rmobile

Re: [U-Boot] [PATCH v2 0/3] net: update Ethernet for Renesas RZ/A1

2017-11-03 Thread Chris Brandt
On Friday, November 03, 2017, Chris Brandt wrote: > These are some fixes to support the Renesas RZ/A1 SoC. > You can see there were some considerations for RZ/A1 (R7S72100) > in the code already, but not completely enough to actually get > it working. > > This was tested on

[U-Boot] [PATCH v2 1/3] net: sh-eth: fix inl and outl definitions

2017-11-03 Thread Chris Brandt
The macros inl and outl maybe already be defined from file arch/arm/include/asm/io.h so there may be no reason to define them. And if you do try defined them here, you get a redefined complier warning. Signed-off-by: Chris Brandt --- drivers/net/sh_eth.h | 4 +++- 1 file changed, 3 insertions

[U-Boot] [PATCH v2 3/3] net: miiphybb: fix casting error

2017-11-03 Thread Chris Brandt
Since the return value is a signed int, if the leading MSB of rdreg is a 1, it will get signed extended and will return a negative value which is an error even though we read the correct value. Fixes: dfcc496ed7e2 ("net: mii: Changes not made by spatch") Signed-off-by: Chris Brandt --

[U-Boot] [PATCH v2 0/3] net: update Ethernet for Renesas RZ/A1

2017-11-03 Thread Chris Brandt
/testing). Chris Brandt (3): net: sh-eth: fix inl and outl definitions net: sh-eth: remove sh_eth_offset_rz table net: miiphybb: fix casting error drivers/net/phy/miiphybb.c | 2 +- drivers/net/sh_eth.h | 63 +++--- 2 files changed, 5 insertions

[U-Boot] [PATCH v2 2/3] net: sh-eth: remove sh_eth_offset_rz table

2017-11-03 Thread Chris Brandt
value to it. Therefore, just delete it use the gigabit one. Signed-off-by: Chris Brandt --- drivers/net/sh_eth.h | 59 +--- 1 file changed, 1 insertion(+), 58 deletions(-) diff --git a/drivers/net/sh_eth.h b/drivers/net/sh_eth.h index 2345c34368

Re: [U-Boot] Where should Renesas RZ/A go under arch/arm/ ????

2017-10-31 Thread Chris Brandt
Hi Tom, Thanks for the reply! On Tuesday, October 31, 2017 1, Tom Rini wrote: > On Tue, Oct 31, 2017 at 12:13:22PM +0000, Chris Brandt wrote: > > Hello, > > > > Since I've been supporting a u-boot for the Renesas RZ/A1 SoC for a > > while now, I thought I'd

[U-Boot] Where should Renesas RZ/A go under arch/arm/ ????

2017-10-31 Thread Chris Brandt
Hello, Since I've been supporting a u-boot for the Renesas RZ/A1 SoC for a while now, I thought I'd start upstreaming the drivers/patches I've acquired over the years. But, where should the core files and Kconfig go? The RZ/A1 series has a Cortex-A9. At first, I had made a directory under arch