Re: [U-Boot] [PATCH] net: phy: Set SUPPORTED_1000baseX_Half flag in ESTATUS_1000_XHALF case

2013-07-19 Thread Charles Coldwell
On Fri, Jul 19, 2013 at 12:55 PM, Tom Rini wrote: > On Fri, Jul 19, 2013 at 10:01:34AM -0300, Fabio Estevam wrote: > >> From: Fabio Estevam >> >> Commit de1d786e (add support for Xilinx 1000BASE-X phy (GTX)) introduced the >> checking for ESTATUS_1000_XHALF, but it incorrectly sets the >> SUPPORT

Re: [U-Boot] Ethernet support broken for Wandboard Quad on master

2013-07-19 Thread Charles Coldwell
9, 2013 at 09:38:42AM -0300, Fabio Estevam wrote: >> On Fri, Jul 19, 2013 at 7:25 AM, Sascha Silbe wrote: >> > Hello Charles, >> > >> > [CC += a few people that were CC'ed on the revert of Charles' patch] >> > >> > Charles Coldwell writes:

Re: [U-Boot] [PATCH] net: phy: Set SUPPORTED_1000baseX_Half flag in ESTATUS_1000_XHALF case

2013-07-19 Thread Charles Coldwell
On Fri, Jul 19, 2013 at 10:01 AM, Fabio Estevam wrote: > Hi Charles, > > On Fri, Jul 19, 2013 at 10:59 AM, Charles Coldwell wrote: >> On Fri, Jul 19, 2013 at 9:01 AM, Fabio Estevam wrote: >>> From: Fabio Estevam >>> >>> Commit de1d786e (add support f

Re: [U-Boot] [PATCH] net: phy: Set SUPPORTED_1000baseX_Half flag in ESTATUS_1000_XHALF case

2013-07-19 Thread Charles Coldwell
On Fri, Jul 19, 2013 at 9:01 AM, Fabio Estevam wrote: > From: Fabio Estevam > > Commit de1d786e (add support for Xilinx 1000BASE-X phy (GTX)) introduced the > checking for ESTATUS_1000_XHALF, but it incorrectly sets the > SUPPORTED_1000baseX_Full flag in this case. Signed-

Re: [U-Boot] Ethernet support broken for Wandboard Quad on master

2013-07-18 Thread Charles Coldwell
On Thu, Jul 18, 2013 at 11:44 AM, Fabio Estevam wrote: > > The following patch fixes it: > > --- a/drivers/net/phy/phy.c > +++ b/drivers/net/phy/phy.c > @@ -337,12 +337,8 @@ int genphy_parse_link(struct phy_device *phydev) > estatus = phy_read(phydev, MDIO_DEVAD_NONE, >

Re: [U-Boot] Ethernet support broken for Wandboard Quad on master

2013-07-18 Thread Charles Coldwell
On Thu, Jul 18, 2013 at 5:07 AM, Sascha Silbe wrote: > > > Charles, do you have any idea why your commit breaks ethernet support on > Wandboard Quad? I've never heard of the Wandboard Quad, so I suppose the short answer is "no". However, the philosophy of the patch I submitted was: 1. Check the

[U-Boot] [PATCH] add support for Xilinx 1000BASE-X phy (GTX)

2013-02-21 Thread Charles Coldwell
commit 39695029bc15041c809df3db4ba19bd729c447fa Author: Charles Coldwell Date: Tue Feb 19 08:27:33 2013 -0500 Changes to support the Xilinx 1000BASE-X phy (GTX/MGT) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index d0ed766..8a38ccb 100644 --- a/drivers/net/phy/phy.c +++ b

Re: [U-Boot] [PATCH] to support Xilinx 1000BASE-X phy (GTX)

2013-02-19 Thread Charles Coldwell
On Tue, 19 Feb 2013, Wolfgang Denk wrote: > > Your patch is white space corrupted. Please fix your mailer. commit 39695029bc15041c809df3db4ba19bd729c447fa Author: Charles Coldwell Date: Tue Feb 19 08:27:33 2013 -0500 Changes to support the Xilinx 1000BASE-X phy (GTX/MGT) diff -

Re: [U-Boot] patch to support Xilinx 1000BASE-X phy (GTX)

2013-02-19 Thread Charles Coldwell
and here it is again, in-line commit 39695029bc15041c809df3db4ba19bd729c447fa Author: Charles Coldwell Date: Tue Feb 19 08:27:33 2013 -0500 Changes to support the Xilinx 1000BASE-X phy (GTX/MGT) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index d0ed766..8a38ccb 100644