Re: [PATCH V3 0/3] cmd: env: select: Add output for available environment targets

2025-05-12 Thread Andy Shevchenko
On Mon, May 12, 2025 at 03:15:06PM +, Christoph Niedermaier wrote: > From: Andy Shevchenko > Sent: Monday, May 12, 2025 10:38 AM > > On Mon, May 12, 2025 at 08:22:19AM +, Christoph Niedermaier wrote: > >> From: Andy Shevchenko > >> Sent: Monday, May 12, 202

Re: [PATCH V3 0/3] cmd: env: select: Add output for available environment targets

2025-05-12 Thread Andy Shevchenko
On Mon, May 12, 2025 at 08:22:19AM +, Christoph Niedermaier wrote: > From: Andy Shevchenko > Sent: Monday, May 12, 2025 9:38 AM > > On Fri, May 09, 2025 at 09:00:40PM +0200, Christoph Niedermaier wrote: > >> Add the "-l" parameter to the "env se

Re: [PATCH V3 0/3] cmd: env: select: Add output for available environment targets

2025-05-12 Thread Andy Shevchenko
;-l" for the "env select" > command. What is the binary size increase with this change, please? -- With Best Regards, Andy Shevchenko

Re: [PATCH v1 1/1] x86: cpu: Describe board final hooks in the header

2025-05-09 Thread Andy Shevchenko
On Sat, Oct 19, 2024 at 05:51:00AM -0600, Simon Glass wrote: > On Fri, 18 Oct 2024 at 09:56, Andy Shevchenko > wrote: > > > > The new two declarations board_final_init() and board_final_cleanup() > > need a description. Add it here. > > > > Suggested-by:

Re: [PATCH] IOMUX: Fix stopping unused dropped consoles

2025-04-07 Thread Andy Shevchenko
gt; removing it from stdio/stderr/stdin. Good catch! Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko

Re: [PATCH 1/1] doc: replace invalid GPL-2.0+ SPDX identifier

2024-11-14 Thread Andy Shevchenko
t > message I can update everything excluding upstream dts files in one go. +1 here. There is nothing wrong with the GPL-2.0+. It's just old variant. FWIW, Linux kernel is okay to use it even in a new code. -- With Best Regards, Andy Shevchenko

Re: enabling W=1 by default

2024-10-28 Thread Andy Shevchenko
On Sat, Oct 26, 2024 at 11:10:40AM +0300, Ilias Apalodimas wrote: > On Wed, 23 Oct 2024 at 17:52, Andy Shevchenko > wrote: > > On Wed, Oct 23, 2024 at 09:52:09AM +0200, Alexander Dahl wrote: > > > Am Tue, Oct 22, 2024 at 04:23:07PM +0300 schrieb Andy Shevchenko: > > >

Re: [PATCH] efi_loader: Mark efi_bootmgr_release_uridp as static

2024-10-28 Thread Andy Shevchenko
On Sat, Oct 26, 2024 at 10:37:32AM +0300, Ilias Apalodimas wrote: > This is only used locally so make it static Missing period at the end. Otherwise LGTM, Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko

Re: [PATCH v1 1/1] efi_loader: Mark a function static

2024-10-24 Thread Andy Shevchenko
On Thu, Oct 24, 2024 at 08:18:40AM -0600, Tom Rini wrote: > On Thu, Oct 24, 2024 at 09:26:14AM +0300, Andy Shevchenko wrote: > > On Thu, Oct 24, 2024 at 07:03:24AM +0200, Heinrich Schuchardt wrote: > > > Am 22. Oktober 2024 15:18:45 MESZ schrieb Andy Shevchenko > > > :

Re: [PATCH v1 1/1] efi_loader: Mark a function static

2024-10-23 Thread Andy Shevchenko
On Thu, Oct 24, 2024 at 07:03:24AM +0200, Heinrich Schuchardt wrote: > Am 22. Oktober 2024 15:18:45 MESZ schrieb Andy Shevchenko > : > >On Tue, Oct 22, 2024 at 08:02:46AM +0200, Heinrich Schuchardt wrote: > >> On 10/21/24 16:40, Ilias Apalodimas wrote: > >> > O

Re: enabling W=1 by default

2024-10-23 Thread Andy Shevchenko
On Wed, Oct 23, 2024 at 09:52:09AM +0200, Alexander Dahl wrote: > Am Tue, Oct 22, 2024 at 04:23:07PM +0300 schrieb Andy Shevchenko: > > On Mon, Oct 21, 2024 at 06:32:21PM +0200, Simon Glass wrote: > > > On Mon, 21 Oct 2024 at 16:27, Andy Shevchenko > > > wrote: >

Re: enabling W=1 by default

2024-10-22 Thread Andy Shevchenko
On Mon, Oct 21, 2024 at 06:32:21PM +0200, Simon Glass wrote: > On Mon, 21 Oct 2024 at 16:27, Andy Shevchenko > wrote: > > > > looking at the redness of the output of `make W=1` here is the question: > > isn't it a good time to enable `make W=1` by default. Yes, I unde

Re: [PATCH v1 1/1] efi_loader: Mark a function static

2024-10-22 Thread Andy Shevchenko
On Tue, Oct 22, 2024 at 08:02:46AM +0200, Heinrich Schuchardt wrote: > On 10/21/24 16:40, Ilias Apalodimas wrote: > > On Mon, 21 Oct 2024 at 17:06, Andy Shevchenko > > wrote: > > > > > > efi_bootmgr_release_uridp_resource() is not used anywhere except > &

enabling W=1 by default

2024-10-21 Thread Andy Shevchenko
a few releases already, i.e. Werror by default and getting close to make a clean builds with that and make W=1` at least against default configurations (yeah, with U-Boot there is probably no default, but sandbox one). -- With Best Regards, Andy Shevchenko

[PATCH v1 1/1] : Mark a few functions static inline

2024-10-21 Thread Andy Shevchenko
previous prototype for ‘mux_control_put’ [-Wmissing-prototypes] include/mux.h:147:21: warning: no previous prototype for ‘devm_mux_control_get’ [-Wmissing-prototypes] include/mux.h:153:5: warning: no previous prototype for ‘dm_mux_init’ [-Wmissing-prototype ] Signed-off-by: Andy Shevchenko

[PATCH v1 1/1] mtd: Drop superfluous const qualifier

2024-10-21 Thread Andy Shevchenko
The compiler will ignore it anyway: include/linux/mtd/mtd.h:342:15: warning: type qualifiers ignored on function return type [-Wignored-qualifiers] Signed-off-by: Andy Shevchenko --- include/linux/mtd/mtd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux

[PATCH v1 1/1] efi_loader: Mark a function static

2024-10-21 Thread Andy Shevchenko
] Signed-off-by: Andy Shevchenko --- lib/efi_loader/efi_bootmgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_loader/efi_bootmgr.c b/lib/efi_loader/efi_bootmgr.c index 589d3996b680..79144962cd73 100644 --- a/lib/efi_loader/efi_bootmgr.c +++ b/lib/efi_loader/efi_bootmgr.c

[PATCH v1 1/1] cmd: nvedit: Mark a few functions static

2024-10-21 Thread Andy Shevchenko
‘do_env_callback’ [-Wmissing-prototypes] cmd/nvedit.c:384:5: warning: no previous prototype for ‘do_env_flags’ [-Wmissing-prototype ] Signed-off-by: Andy Shevchenko --- cmd/nvedit.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/cmd/nvedit.c b/cmd/nvedit.c index

Re: [PATCH v1 3/4] x86: cpu: Add a few prototypes to the header file

2024-10-18 Thread Andy Shevchenko
On Fri, Oct 18, 2024 at 08:55:00AM -0600, Simon Glass wrote: > On Fri, 18 Oct 2024 at 05:43, Andy Shevchenko > wrote: > > On Thu, Oct 17, 2024 at 04:11:48PM -0700, Simon Glass wrote: > > > On Wed, 9 Oct 2024 at 08:08, Andy Shevchenko > > > wrote: ... > > &g

[PATCH v1 1/1] x86: cpu: Describe board final hooks in the header

2024-10-18 Thread Andy Shevchenko
The new two declarations board_final_init() and board_final_cleanup() need a description. Add it here. Suggested-by: Simon Glass Signed-off-by: Andy Shevchenko --- arch/x86/include/asm/cpu.h | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/x86/include/asm/cpu.h b/arch

Re: [PATCH v1 3/4] x86: cpu: Add a few prototypes to the header file

2024-10-18 Thread Andy Shevchenko
On Thu, Oct 17, 2024 at 04:11:48PM -0700, Simon Glass wrote: > On Wed, 9 Oct 2024 at 08:08, Andy Shevchenko > wrote: > > On Tue, Oct 08, 2024 at 07:55:33PM -0600, Simon Glass wrote: > > > On Sat, 5 Oct 2024 at 13:14, Andy Shevchenko > > > wrote: > > > >

Re: [PATCH v1 3/4] x86: cpu: Add a few prototypes to the header file

2024-10-09 Thread Andy Shevchenko
On Tue, Oct 08, 2024 at 07:55:33PM -0600, Simon Glass wrote: > On Sat, 5 Oct 2024 at 13:14, Andy Shevchenko > wrote: > > > > The compiler is not happy to have no prototypes for the functions that > > are not defined static. Add them. This helps avoiding the compiler warn

Re: [PATCH v1 1/4] x86: cpu: Use default print_cpuinfo() for all

2024-10-09 Thread Andy Shevchenko
On Tue, Oct 08, 2024 at 07:56:43PM -0600, Simon Glass wrote: > On Sat, 5 Oct 2024 at 13:14, Andy Shevchenko > wrote: > > > > Most of the copies of the print_cpuinfo() call the default method. > > Remove all of those in order to have only the default one when > >

[PATCH v1 1/1] cmd: irq: Move do_irqinfo() prototype to a header file

2024-10-05 Thread Andy Shevchenko
Move do_irqinfo() prototype to a header file, otherwise compiler is not happy: arch/x86/lib/interrupts.c:130:5: warning: no previous prototype for ‘do_irqinfo’ [-Wmissing-prototypes] Signed-off-by: Andy Shevchenko --- cmd/irq.c | 3 --- include/irq_func.h | 3 +++ 2 files changed

[PATCH v1 1/4] x86: cpu: Use default print_cpuinfo() for all

2024-10-05 Thread Andy Shevchenko
‘print_cpuinfo’ [-Wmissing-prototypes] Signed-off-by: Andy Shevchenko --- arch/x86/cpu/broadwell/cpu.c | 12 arch/x86/cpu/coreboot/coreboot.c | 5 - arch/x86/cpu/cpu.c | 6 +- arch/x86/cpu/efi/app.c | 5

[PATCH v1 4/4] x86: cpu: Add missing header inclusion

2024-10-05 Thread Andy Shevchenko
:41:5: warning: no previous prototype for ‘cpu_x86_get_desc’ [-Wmissing-prototypes] arch/x86/cpu/cpu_x86.c:55:5: warning: no previous prototype for ‘cpu_x86_get_count’ [-Wmissing-prototypes] Add missing header inclusion. Signed-off-by: Andy Shevchenko --- arch/x86/cpu/cpu_x86.c | 1 + 1 file

[PATCH v1 3/4] x86: cpu: Add a few prototypes to the header file

2024-10-05 Thread Andy Shevchenko
previous prototype for ‘board_final_cleanup’ [-Wmissing-prototypes] arch/x86/cpu/cpu.c:307:5: warning: no previous prototype for ‘reserve_arch’ [-Wmissing-prototypes] Signed-off-by: Andy Shevchenko --- arch/x86/include/asm/cpu.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch

[PATCH v1 2/4] x86: cpu: Mark a few functions static

2024-10-05 Thread Andy Shevchenko
previous prototype for ‘mtrr_write_all’ [-Wmissing-prototypes] arch/x86/cpu/i386/interrupt.c:240:6: warning: no previous prototype for ‘__do_irq’ [-Wmissing-prototypes] Signed-off-by: Andy Shevchenko --- arch/x86/cpu/cpu.c| 2 +- arch/x86/cpu/i386/interrupt.c | 2 +- arch/x86/cpu

[PATCH v1 0/4] x86: Clean up and fix to avoid compiler warnings

2024-10-05 Thread Andy Shevchenko
Some fixes to avoid compiler warnings with `make W=1`. The idea to continue this for at least some of the x86 related code. Andy Shevchenko (4): x86: cpu: Use default print_cpuinfo() for all x86: cpu: Mark a few functions static x86: cpu: Add a few prototypes to the header file x86: cpu

Re: [PATCH v3 03/25] mbedtls: add mbedtls into the build system

2024-06-05 Thread Andy Shevchenko
On Wed, Jun 05, 2024 at 12:35:37PM +0300, Ilias Apalodimas wrote: > On Wed, 5 Jun 2024 at 12:30, Andy Shevchenko > wrote: > > On Tue, Jun 04, 2024 at 05:50:08PM -0400, Raymond Mao wrote: > > > On Tue, 4 Jun 2024 at 16:17, Andy Shevchenko < > > > andriy.

Re: [PATCH v3 03/25] mbedtls: add mbedtls into the build system

2024-06-05 Thread Andy Shevchenko
On Tue, Jun 04, 2024 at 05:50:08PM -0400, Raymond Mao wrote: > On Tue, 4 Jun 2024 at 16:17, Andy Shevchenko < > andriy.shevche...@linux.intel.com> wrote: > > On Tue, May 28, 2024 at 07:09:14AM -0700, Raymond Mao wrote: ... > > > This patch series requires mbedtl

Re: [PATCH v3 02/25] mbedtls: Add script to update MbedTLS subtree

2024-06-05 Thread Andy Shevchenko
On Wed, Jun 05, 2024 at 10:11:04AM +0300, Ilias Apalodimas wrote: > On Tue, 4 Jun 2024 at 23:10, Andy Shevchenko > wrote: > > On Fri, May 31, 2024 at 09:32:38AM +0300, Ilias Apalodimas wrote: > > > On Tue, 28 May 2024 at 17:10, Raymond Mao wrote: ... > > >

Re: [PATCH v3 03/25] mbedtls: add mbedtls into the build system

2024-06-04 Thread Andy Shevchenko
onfigure by the user! Can you rather make it modular and maybe create a separate documentation for the most important options (I do not believe one needs _all_ of them to be set / tuned)? -- With Best Regards, Andy Shevchenko

Re: [PATCH v3 02/25] mbedtls: Add script to update MbedTLS subtree

2024-06-04 Thread Andy Shevchenko
sg}" > > +elif [ "$1" = "pick" ] > move then 'then' one line up and add a ; > == 'pick' Ditto. > > +then > > +remote_add_and_fetch > > +git cherry-pick -x --strategy=subtree \ > > +-Xsubtree=lib/mbedtls/external/mbedtls/ "$2" > > +else > > +echo "usage: $0 " > > +echo " pull or pick" > > +echo " release tag [pull] or commit id [pick]" > > +fi Sheel should be written as much as portable and less verbose. -- With Best Regards, Andy Shevchenko

Re: [PATCH 0/4] Adding support to load secure firmware for HS devices

2024-05-21 Thread Andy Shevchenko
On Tue, May 21, 2024 at 11:52:47AM -0600, Tom Rini wrote: > On Tue, May 21, 2024 at 08:48:54PM +0300, Andy Shevchenko wrote: > > On Tue, May 21, 2024 at 10:45:41AM -0600, Tom Rini wrote: > > > On Tue, May 21, 2024 at 07:35:55PM +0300, Andy Shevchenko wrote: > > > >

Re: [PATCH 0/4] Adding support to load secure firmware for HS devices

2024-05-21 Thread Andy Shevchenko
On Tue, May 21, 2024 at 10:45:41AM -0600, Tom Rini wrote: > On Tue, May 21, 2024 at 07:35:55PM +0300, Andy Shevchenko wrote: > > On Tue, May 21, 2024 at 10:21:45AM -0600, Tom Rini wrote: > > > On Tue, May 21, 2024 at 07:12:09PM +0300, Andy Shevchenko wrote: > > > >

Re: [PATCH 0/4] Adding support to load secure firmware for HS devices

2024-05-21 Thread Andy Shevchenko
On Tue, May 21, 2024 at 10:21:45AM -0600, Tom Rini wrote: > On Tue, May 21, 2024 at 07:12:09PM +0300, Andy Shevchenko wrote: > > On Tue, May 21, 2024 at 08:59:17PM +0530, Kumar, Udit wrote: > > > On 5/21/2024 7:59 PM, Andy Shevchenko wrote: > > > > On Tue, May 21,

Re: [PATCH 0/4] Adding support to load secure firmware for HS devices

2024-05-21 Thread Andy Shevchenko
On Tue, May 21, 2024 at 08:59:17PM +0530, Kumar, Udit wrote: > On 5/21/2024 7:59 PM, Andy Shevchenko wrote: > > On Tue, May 21, 2024 at 04:26:44PM +0530, Udit Kumar wrote: ... > > Are you Cc'ing random people with this? > > Please don't do it. > > I use

Re: [PATCH 0/4] Adding support to load secure firmware for HS devices

2024-05-21 Thread Andy Shevchenko
es, secure version of rproc firmware should be loaded, > which is appended by sec keyword[0]. > but currently non-secure firmware is loaded even for secure devices. > So adding support for loading secure firmware on Secured devices. Are you Cc'ing random people with this? Please

Re: [PATCH 073/149] board: intel: Remove and add needed includes

2024-05-02 Thread Andy Shevchenko
On Tue, Apr 30, 2024 at 08:42:00PM -0600, Tom Rini wrote: > Remove from this board vendor directory and when needed > add missing include files directly. Acked-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko

Re: [PATCH 08/16] edison: Remove empty config header

2024-01-28 Thread Andy Shevchenko
On Mon, Jan 22, 2024 at 05:39:12PM -0500, Tom Rini wrote: > Now that we support having CONFIG_SYS_CONFIG_NAME be unset to indicate a > lack of board.h file, unset this on the edison platform and remove > the otherwise empty file. Acked-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko

Re: [PATCH v2 1/4] acpi: fix FADT table

2023-12-15 Thread Andy Shevchenko
ld DSDT must be ignored. We should not fill > unused fields. ... > v2: > no change Have you seen my email? -- With Best Regards, Andy Shevchenko

Re: [PATCH 3/3] cmd: acpi: check HW reduced flag in acpi list

2023-12-15 Thread Andy Shevchenko
s aspects into account. But since it doesn't affect my area of interest in U-Boot, I won't prevent you from doing this way, it's up to the U-Boot maintainers how to proceed with it. -- With Best Regards, Andy Shevchenko

Re: [PATCH 1/3] acpi: fix FADT table

2023-12-15 Thread Andy Shevchenko
ld DSDT must be ignored. We should not fill > unused fields. Is it dictated by the specifications? Please, put the reference here in the commit message (section X.Y.Z "Goo bar"). ... >From code perspective LGTM. -- With Best Regards, Andy Shevchenko

Re: Setting up boot chain ACPI on ARM with STM32MPU

2023-11-29 Thread Andy Shevchenko
On Wed, Nov 29, 2023 at 6:25 PM Andy Shevchenko wrote: > On Wed, Nov 29, 2023 at 5:29 PM Ba Gia Bao Phan > wrote: > > > > Hello everyone, > > > > I am a trainee at STMicroelectronics France. I am working on a project > > "Setting up a boot chain ACPI&qu

Re: Setting up boot chain ACPI on ARM with STM32MPU

2023-11-29 Thread Andy Shevchenko
27;t know > if it functioned or not. Did anyone here succeed in setting up ACPI on ARM by > U-boot? > > What are the differences between x86 and ARM platforms when enabling ACPI? > The architecture of my board STM32PMU is ARM so can I apply the technique > used on platform x86 for my board? -- With Best Regards, Andy Shevchenko

Re: [PATCH v1 1/1] Makefile.lib: Always rebuild DSDT

2023-11-29 Thread Andy Shevchenko
On Wed, Mar 30, 2022 at 12:21:25PM +0300, Andy Shevchenko wrote: > On Mon, Oct 25, 2021 at 09:52:45PM +0300, Andy Shevchenko wrote: > > On Mon, Oct 25, 2021 at 09:18:56AM -0600, Simon Glass wrote: > > > On Mon, 25 Oct 2021 at 01:34, Andy Shevchenko > > > wrote: > &g

Re: [PATCH v3 2/2] cmd: acpi: fix acpi list command

2023-11-20 Thread Andy Shevchenko
On Mon, Nov 20, 2023 at 01:34:22PM +0100, Heinrich Schuchardt wrote: > On 11/20/23 12:28, Andy Shevchenko wrote: > > On Sat, Nov 18, 2023 at 11:52:48PM +0100, Heinrich Schuchardt wrote: ... > > (Side question: Do you use --histogram when preparing patches? if no, try > >

Re: [PATCH v3 2/2] cmd: acpi: fix acpi list command

2023-11-20 Thread Andy Shevchenko
e tmp = rsdt->entry[i]; if (!tmp) break; hdr = map_sysmem(tmp, 0); -- With Best Regards, Andy Shevchenko

Re: [PATCH v2 1/2] Reland "x86: Move FACP table into separate functions""

2023-08-31 Thread Andy Shevchenko
; Signed-off-by: Simon Glass > Signed-off-by: Andy Shevchenko Not sure this is correct SoB chain. In kernel project we would do Co-developed-by: Andy Shevchenko Signed-off-by: Andy Shevchenko Signed-off-by: Simon Glass > --- > (Now fixed - thank you Andy!) Right, Tested-by: Andy Sh

Re: [PATCH v1 2/2] x86: Prevent from missing the FADT chaining

2023-08-25 Thread Andy Shevchenko
On Fri, Aug 25, 2023 at 04:51:41PM +0300, Andy Shevchenko wrote: ... > +static inline int acpi_add_fadt(struct acpi_ctx *ctx, struct acpi_fadt *fadt) > +{ > + acpi_add_table(ctx, fadt); > + acpi_inc(ctx, sizeof(struct acpi_fadt)); > + return 0; > +} Ideally

[PATCH v1 2/2] x86: Prevent from missing the FADT chaining

2023-08-25 Thread Andy Shevchenko
Recent approach with FADT writer shows that there is a room for subtle errors. Prevent this from happening again by introducing acpi_add_fadt() helper. Signed-off-by: Andy Shevchenko --- arch/x86/cpu/apollolake/acpi.c | 6 +- arch/x86/cpu/baytrail/acpi.c | 6 +- arch/x86/cpu/quark

[PATCH v1 1/2] TO BE FOLDED: x86: tangier: Add FADT to the chain

2023-08-25 Thread Andy Shevchenko
The Simon's patch missed the FADT to be added to the chain, hence all the issues on Intel Tangier. Signed-off-by: Andy Shevchenko --- arch/x86/cpu/tangier/acpi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/cpu/tangier/acpi.c b/arch/x86/cpu/tangier/acpi.c index 01b3055

Re: [PATCH 1/2] Reland "x86: Move FACP table into separate functions""

2023-08-25 Thread Andy Shevchenko
On Fri, Aug 25, 2023 at 04:25:29PM +0300, Andy Shevchenko wrote: > On Fri, Aug 25, 2023 at 04:17:58PM +0300, Andy Shevchenko wrote: > > On Fri, Aug 25, 2023 at 02:06:34PM +0300, Andy Shevchenko wrote: > > > On Thu, Aug 24, 2023 at 12:23:32PM -0600, Simon Glass wrote: > > &g

Re: [PATCH 1/2] Reland "x86: Move FACP table into separate functions""

2023-08-25 Thread Andy Shevchenko
On Fri, Aug 25, 2023 at 04:17:58PM +0300, Andy Shevchenko wrote: > On Fri, Aug 25, 2023 at 02:06:34PM +0300, Andy Shevchenko wrote: > > On Thu, Aug 24, 2023 at 12:23:32PM -0600, Simon Glass wrote: > > > Each board has its own way of creating this table. Rathe

Re: [PATCH 1/2] Reland "x86: Move FACP table into separate functions""

2023-08-25 Thread Andy Shevchenko
On Fri, Aug 25, 2023 at 02:06:34PM +0300, Andy Shevchenko wrote: > On Thu, Aug 24, 2023 at 12:23:32PM -0600, Simon Glass wrote: > > Each board has its own way of creating this table. Rather than calling the > > acpi_create_fadt() function for each one from a common acpi_write_fadt

Re: [PATCH 1/2] Reland "x86: Move FACP table into separate functions""

2023-08-25 Thread Andy Shevchenko
On Fri, Aug 25, 2023 at 02:10:05PM +0300, Andy Shevchenko wrote: > On Fri, Aug 25, 2023 at 02:06:34PM +0300, Andy Shevchenko wrote: > > On Thu, Aug 24, 2023 at 12:23:32PM -0600, Simon Glass wrote: > > > Each board has its own way of creating this table. Rathe

Re: [PATCH 1/2] Reland "x86: Move FACP table into separate functions""

2023-08-25 Thread Andy Shevchenko
On Fri, Aug 25, 2023 at 02:06:34PM +0300, Andy Shevchenko wrote: > On Thu, Aug 24, 2023 at 12:23:32PM -0600, Simon Glass wrote: > > Each board has its own way of creating this table. Rather than calling the > > acpi_create_fadt() function for each one from a common acpi_write_fadt

Re: [PATCH 1/2] Reland "x86: Move FACP table into separate functions""

2023-08-25 Thread Andy Shevchenko
I have a bit of time to debug more. -- With Best Regards, Andy Shevchenko

Re: [PATCH 00/22] x86: Move some boards to text environment

2023-08-07 Thread Andy Shevchenko
On Mon, Aug 07, 2023 at 03:30:25PM +0200, Michael Nazzareno Trimarchi wrote: > On Mon, Aug 7, 2023 at 3:04 PM Andy Shevchenko > wrote: > > On Mon, Aug 07, 2023 at 02:44:31PM +0200, Michael Nazzareno Trimarchi wrote: > > > Hi Pali > > > > > >

Re: [PATCH 00/22] x86: Move some boards to text environment

2023-08-07 Thread Andy Shevchenko
; > > > > > I can see the philosophy was that someone who touched the changed file > > > should be copied for review. > > > We certainly could argue that and just get the list solely from the > > > MAINTAINERS file. > > > > > > Regards, > > > Bin > > > > -- > Michael Nazzareno Trimarchi > Co-Founder & Chief Executive Officer > M. +39 347 913 2170 > mich...@amarulasolutions.com > __ > > Amarula Solutions BV > Joop Geesinkweg 125, 1114 AB, Amsterdam, NL > T. +31 (0)85 111 9172 > i...@amarulasolutions.com > www.amarulasolutions.com -- With Best Regards, Andy Shevchenko

Re: [PATCH 00/22] x86: Move some boards to text environment

2023-07-31 Thread Andy Shevchenko
eries. Patch wise it looks good to me Reviewed-by: Andy Shevchenko # Intel Edison Where can I read about this new edison.env file and what is expected to be there? > doc: Explain how to avoid the distro-boot scripts > env: Use include/env for text-environment includes > env: Explai

Re: [PATCH v2] IOMUX: Fix access past end of console_devices

2022-04-07 Thread Andy Shevchenko
putting the > assignment in the loop condition allows us to ensure that i is checked > beforehand. This isn't a bug, but it does make valgrind stop complaining. Acked-by: Andy Shevchenko > Fixes: 400797cad3 ("IOMUX: Split out for_each_console_dev() helper macro") > Sign

Re: [PATCH] IOMUX: Fix access past end of console_devices

2022-03-31 Thread Andy Shevchenko
On Wed, Mar 30, 2022 at 01:25:59PM -0400, Sean Anderson wrote: > On 3/30/22 1:13 PM, Andy Shevchenko wrote: > > On Wed, Mar 30, 2022 at 7:49 PM Sean Anderson wrote: > > > > Also I don't like to have workarounds for the broken tools. > > But if you still want to h

Re: [PATCH] IOMUX: Fix access past end of console_devices

2022-03-30 Thread Andy Shevchenko
];\ i++, dev = console_devices[file][i]) ? -- With Best Regards, Andy Shevchenko

Re: [PATCH] IOMUX: Fix access past end of console_devices

2022-03-30 Thread Andy Shevchenko
On Wed, Mar 30, 2022 at 8:05 PM Sean Anderson wrote: > On 3/30/22 1:01 PM, Andy Shevchenko wrote: > > On Wed, Mar 30, 2022 at 7:49 PM Sean Anderson wrote: ... > >> #define for_each_console_dev(i, file, dev) \ > >> - for (i = 0, de

Re: [PATCH] IOMUX: Fix access past end of console_devices

2022-03-30 Thread Andy Shevchenko
On Wed, Mar 30, 2022 at 8:01 PM Andy Shevchenko wrote: > On Wed, Mar 30, 2022 at 7:49 PM Sean Anderson wrote: ... > > #define for_each_console_dev(i, file, dev) \ > > - for (i = 0, dev = console_devices[file][i]; \ > > When we enter the loop, th

Re: [PATCH] IOMUX: Fix access past end of console_devices

2022-03-30 Thread Andy Shevchenko
devices[file][i]) > + for (i = 0; i < cd_count[file] && \ Not the case anymore. > + (dev = console_devices[file][i]); i++) -- With Best Regards, Andy Shevchenko

[PATCH v1 1/1] Revert "x86: Move FACP table into separate functions"

2022-03-30 Thread Andy Shevchenko
INTL 0 As a result Linux kernel can't find mandatory tables and fails to boot. Hence, revert it for good. This reverts commit 379d3c1fd6aa490b1ad5697525cfc89b615cf25a. BugLink: https://lore.kernel.org/all/20220131225930.GJ7515@bill-the-cat/ Signed-off-by: Andy Shevchenko --- arch/x86/cpu

Re: [ANN] U-Boot v2022.04-rc1 released

2022-03-30 Thread Andy Shevchenko
On Sat, Feb 12, 2022 at 05:02:00PM +0200, Andy Shevchenko wrote: > On Fri, Feb 11, 2022 at 9:15 PM Andy Shevchenko > wrote: > > On Fri, Feb 11, 2022 at 8:46 PM Andy Shevchenko > > wrote: > > > On Fri, Feb 11, 2022 at 8:31 PM Andy Shevchenko > > > wrote: &

Re: [PATCH v1 1/2] hexdump: Introduce debug APIs

2022-03-30 Thread Andy Shevchenko
On Sat, Nov 13, 2021 at 11:14:28AM -0700, Simon Glass wrote: > On Tue, 9 Nov 2021 at 05:03, Andy Shevchenko > wrote: > > > > debug_hex_dump() and debug_hex_dump_bytes() conditionally print > > the dump based on DEBUG definition. > > > > Signed-off-by: A

[PATCH v1 1/1] Makefile.lib: Re-use $(UBOOTINCLUDE) in dtc_cpp_flags

2022-03-30 Thread Andy Shevchenko
As in ASL case use same basic set of the inclusions. Signed-off-by: Andy Shevchenko --- scripts/Makefile.lib | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index c14da10de780..2ff39d39dc8a 100644 --- a/scripts/Makefile.lib

Re: [ANN] U-Boot v2022.04-rc5 released

2022-03-30 Thread Andy Shevchenko
is cycle, April 4th 2022. > Thanks all! What is the status of the ACPI series that broke at least Edison at rc1 time? Simon never returned to me with answers to my questions. P.S. I'll re-test today rc5. -- With Best Regards, Andy Shevchenko

Re: [PATCH v1 1/1] Makefile.lib: Always rebuild DSDT

2022-03-30 Thread Andy Shevchenko
On Mon, Oct 25, 2021 at 09:52:45PM +0300, Andy Shevchenko wrote: > On Mon, Oct 25, 2021 at 09:18:56AM -0600, Simon Glass wrote: > > On Mon, 25 Oct 2021 at 01:34, Andy Shevchenko > > wrote: > > > On Sun, Oct 24, 2021 at 11:00 PM Simon Glass wrote: > > > >

Re: [ANN] U-Boot v2022.04-rc1 released

2022-03-30 Thread Andy Shevchenko
On Fri, Feb 11, 2022 at 09:54:38PM +0200, Andy Shevchenko wrote: > On Fri, Feb 11, 2022 at 09:47:52PM +0200, Andy Shevchenko wrote: > > On Fri, Feb 11, 2022 at 12:31:46PM -0700, Simon Glass wrote: > > > On Fri, 11 Feb 2022 at 12:29, Andy Shevchenko > > > wrote: > &

[PATCH v1 1/1] efi_loader: initrddump: Actually use the custom CFLAGS

2022-03-30 Thread Andy Shevchenko
nitrddump.o: warning: relocation in read-only section `.text.efi_main' ld.bfd: warning: creating DT_TEXTREL in a shared object Remove wrong 'exit' suffix from the custom CFLAGS variable. Fixes: 65ab48d69ddb ("efi_selftest: provide initrddump test tool") Signed-off-by: Andy Shevc

Re: [ANN] U-Boot v2022.04-rc1 released

2022-02-12 Thread Andy Shevchenko
On Fri, Feb 11, 2022 at 9:15 PM Andy Shevchenko wrote: > On Fri, Feb 11, 2022 at 8:46 PM Andy Shevchenko > wrote: > > On Fri, Feb 11, 2022 at 8:31 PM Andy Shevchenko > > wrote: > > > On Mon, Jan 31, 2022 at 05:59:30PM -0500, Tom Rini wrot

Re: [ANN] U-Boot v2022.04-rc1 released

2022-02-11 Thread Andy Shevchenko
On Fri, Feb 11, 2022 at 09:47:52PM +0200, Andy Shevchenko wrote: > On Fri, Feb 11, 2022 at 12:31:46PM -0700, Simon Glass wrote: > > On Fri, 11 Feb 2022 at 12:29, Andy Shevchenko > > wrote: > > > On Fri, Feb 11, 2022 at 9:26 PM Simon Glass wrote: ... > > > To

Re: [ANN] U-Boot v2022.04-rc1 released

2022-02-11 Thread Andy Shevchenko
On Fri, Feb 11, 2022 at 09:47:52PM +0200, Andy Shevchenko wrote: > On Fri, Feb 11, 2022 at 12:31:46PM -0700, Simon Glass wrote: > > On Fri, 11 Feb 2022 at 12:29, Andy Shevchenko > > wrote: > > > On Fri, Feb 11, 2022 at 9:26 PM Simon Glass wrote: > > > >

Re: [ANN] U-Boot v2022.04-rc1 released

2022-02-11 Thread Andy Shevchenko
On Fri, Feb 11, 2022 at 12:31:46PM -0700, Simon Glass wrote: > On Fri, 11 Feb 2022 at 12:29, Andy Shevchenko > wrote: > > On Fri, Feb 11, 2022 at 9:26 PM Simon Glass wrote: > > > On Fri, 11 Feb 2022 at 11:28, Andy Shevchenko > > > wrote: > > > > On

Re: [ANN] U-Boot v2022.04-rc1 released

2022-02-11 Thread Andy Shevchenko
On Fri, Feb 11, 2022 at 9:26 PM Simon Glass wrote: > On Fri, 11 Feb 2022 at 11:28, Andy Shevchenko > wrote: > > On Mon, Jan 31, 2022 at 05:59:30PM -0500, Tom Rini wrote: ... > FWIW here is my tboot flash script for Edison: This is rather unbriking script, DFU (luckily) w

Re: [ANN] U-Boot v2022.04-rc1 released

2022-02-11 Thread Andy Shevchenko
On Fri, Feb 11, 2022 at 8:46 PM Andy Shevchenko wrote: > > On Fri, Feb 11, 2022 at 8:31 PM Andy Shevchenko > wrote: > > > > On Mon, Jan 31, 2022 at 05:59:30PM -0500, Tom Rini wrote: > > > Hey all, > > > > > > It's release day and so here&#

Re: [ANN] U-Boot v2022.04-rc1 released

2022-02-11 Thread Andy Shevchenko
On Fri, Feb 11, 2022 at 8:31 PM Andy Shevchenko wrote: > > On Mon, Jan 31, 2022 at 05:59:30PM -0500, Tom Rini wrote: > > Hey all, > > > > It's release day and so here's v2022.04-rc1. While there's much in here > > that needed to come in, there'

Re: [ANN] U-Boot v2022.04-rc1 released

2022-02-11 Thread Andy Shevchenko
6] Hardware name: Intel Corporation Merrifield/BODEGA BAY, BIOS 542 2015.01.21:18.19.48 [0.857666] RIP: 0010:pci_read+0x47/0x80 ... Bisection started... Simon, can you prioritize setting up Edison to make it available for tests? -- With Best Regards, Andy Shevchenko

Re: [PATCH v3 1/2] binman: Do not pollute source tree when build with `make O=...`

2021-12-23 Thread Andy Shevchenko
is $(srctree), and creates cache just in the middle > > of the source tree. Move cache to the current directory. > > > > Signed-off-by: Andy Shevchenko > > --- > > v3: avoided crash (Simon), preserved tree hierarchy > > tools/binman/main.py | 13 - >

[PATCH v3 2/2] binman: Use less hard coded magic when inserting new PATH

2021-12-06 Thread Andy Shevchenko
Instead of joining hard coded '..' to the run-time path of the executable, take just a dirname out of it. Besides that, use $(srctree) where it makes sense. Signed-off-by: Andy Shevchenko --- v3: avoided crash (Simon), reused one level up folder variable tools/binman/ma

[PATCH v3 1/2] binman: Do not pollute source tree when build with `make O=...`

2021-12-06 Thread Andy Shevchenko
Importing libraries in Python caches the bytecode by default. Since we run scripts in source tree it ignores the current directory settings, which is $(srctree), and creates cache just in the middle of the source tree. Move cache to the current directory. Signed-off-by: Andy Shevchenko --- v3

Re: [PATCH v2 1/2] binman: Do not pollute source tree when build with `make O=...`

2021-12-06 Thread Andy Shevchenko
On Fri, Dec 03, 2021 at 10:29:10PM +0200, Andy Shevchenko wrote: > On Fri, Dec 03, 2021 at 01:13:12PM -0700, Simon Glass wrote: ... > Ah, you mean you run it manually and not via `make`. > > os.environ.get('srctree', '') > > should help I supp

Re: [PATCH v2 1/2] binman: Do not pollute source tree when build with `make O=...`

2021-12-03 Thread Andy Shevchenko
On Fri, Dec 03, 2021 at 01:13:12PM -0700, Simon Glass wrote: > On Fri, 3 Dec 2021 at 00:55, Andy Shevchenko > wrote: > > On Friday, December 3, 2021, Simon Glass wrote: > >> On Tue, 30 Nov 2021 at 12:04, Andy Shevchenko > >> wrote: ... > >> This loo

Re: [PATCH v2 1/2] binman: Do not pollute source tree when build with `make O=...`

2021-12-02 Thread Andy Shevchenko
On Friday, December 3, 2021, Simon Glass wrote: > Hi Andy, > > On Tue, 30 Nov 2021 at 12:04, Andy Shevchenko > wrote: > > > > Importing libraries in Python caches the bytecode by default. > > Since we run scripts in source tree it ignores the current directory &g

Re: [PATCH 00/40] RFC: rpi: Enable ACPI booting on ARM with Raspberry Pi 4

2021-12-01 Thread Andy Shevchenko
create mode 100644 board/raspberrypi/rpi/rpi4.dsc > create mode 100644 board/raspberrypi/rpi/sdhc.asl > create mode 100644 board/raspberrypi/rpi/spcrminiuart.aslc > create mode 100644 board/raspberrypi/rpi/spcrpl011.aslc > create mode 100644 board/raspberrypi/rpi/ssdtthermal.asl > create mode 100644 board/raspberrypi/rpi/uart.asl > create mode 100644 board/raspberrypi/rpi/xhci.asl > create mode 100644 doc/usage/acpi.rst > create mode 100644 lib/acpi/acpi_writer.c > create mode 100644 lib/acpi/base.c > create mode 100644 lib/acpi/csrt.c > create mode 100644 lib/acpi/dsdt.c > create mode 100644 lib/acpi/facs.c > create mode 100644 lib/acpi/ssdt.c > > -- > 2.34.0.rc2.393.gf8c9666880-goog > -- With Best Regards, Andy Shevchenko

Re: [PATCH 40/40] RFC: rpi: Enable booting with ACPI tables

2021-12-01 Thread Andy Shevchenko
pass `earlycon` to see if it gives anything. Nevertheless, I'm in favour of this series, thanks! For patches 21 and 27 (are they the only ones that touch tangier?) take my Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko

Re: [PATCH v1 1/1] binman: Do not pollute source tree when build with `make O=...`

2021-11-30 Thread Andy Shevchenko
On Tue, Nov 30, 2021 at 9:06 PM Tom Rini wrote: > On Tue, Nov 30, 2021 at 08:58:25PM +0200, Andy Shevchenko wrote: > > On Tue, Nov 30, 2021 at 8:52 PM Tom Rini wrote: > > > On Tue, Nov 30, 2021 at 09:42:04PM +0300, Andy Shevchenko wrote: > > > > +# > > &g

[PATCH v2 1/2] binman: Do not pollute source tree when build with `make O=...`

2021-11-30 Thread Andy Shevchenko
Importing libraries in Python caches the bytecode by default. Since we run scripts in source tree it ignores the current directory settings, which is $(srctree), and creates cache just in the middle of the source tree. Move cache to the current directory. Signed-off-by: Andy Shevchenko --- v2

[PATCH v2 2/2] binman: Use less hard coded magic when inserting new PATH

2021-11-30 Thread Andy Shevchenko
Instead of joining hard coded '..' to the run-time path of the executable, take just a dirname out of it. Besides that, use $(srctree) where it makes sense. Signed-off-by: Andy Shevchenko --- v2: new patch tools/binman/main.py | 12 +++- 1 file changed, 7 insertions(+), 5

Re: [PATCH v1 1/1] binman: Do not pollute source tree when build with `make O=...`

2021-11-30 Thread Andy Shevchenko
On Tue, Nov 30, 2021 at 8:52 PM Tom Rini wrote: > On Tue, Nov 30, 2021 at 09:42:04PM +0300, Andy Shevchenko wrote: > > +# > > +# Do not pollute source tree with cache files: > > +# https://stackoverflow.com/a/60024195/2511795 > > +# https:/

[PATCH v1 1/1] binman: Do not pollute source tree when build with `make O=...`

2021-11-30 Thread Andy Shevchenko
Importing libraries in Python caches the bytecode by default. Since we run scripts in source tree it ignores the current directory settings, which is $(srctree), and creates cache just in the middle of the source tree. Move cache to the current directory. Signed-off-by: Andy Shevchenko

Re: ignore more files in Git?

2021-11-30 Thread Andy Shevchenko
On Tue, Nov 30, 2021 at 5:28 PM Andy Shevchenko wrote: > On Tue, Nov 30, 2021 at 3:23 PM Tom Rini wrote: > > On Tue, Nov 30, 2021 at 03:06:23PM +0200, Andy Shevchenko wrote: > > > > > Am I doing something wrong? > > > > > > $ git status --ignored > &

Re: ignore more files in Git?

2021-11-30 Thread Andy Shevchenko
On Tue, Nov 30, 2021 at 3:23 PM Tom Rini wrote: > > On Tue, Nov 30, 2021 at 03:06:23PM +0200, Andy Shevchenko wrote: > > > Am I doing something wrong? > > > > $ git status --ignored > > On branch edison-acpi > > Your branch is up to date with 'gh-a

ignore more files in Git?

2021-11-30 Thread Andy Shevchenko
ache__/ tools/concurrencytest/__pycache__/ tools/dtoc/__pycache__/ tools/patman/__pycache__/ nothing to commit, working tree clean -- With Best Regards, Andy Shevchenko

  1   2   3   4   5   6   7   8   9   10   >