Re: [PATCH u-boot v2019.04-aspeed-openbmc] ARM: dts: aspeed: Add Ampere's BMC platform (AST2600)

2024-03-25 Thread Andrew Jeffery
Hi Chanh, On Tue, 2024-03-19 at 14:21 +0700, Chanh Nguyen wrote: > Add the initial version of the device tree for the Ampere BMC > platform, which is equipped with the Aspeed AST2600 BMC SoC. > > Signed-off-by: Chanh Nguyen > --- > arch/arm/dts/Makefile | 1 + > arch/arm/dts/ast2600

Re: [PATCH] image: Control FIT signature verification at runtime

2022-02-28 Thread Andrew Jeffery
On Tue, 1 Mar 2022, at 08:42, Alex G. wrote: > On 2/27/22 19:29, Andrew Jeffery wrote: >> >> >> On Tue, 15 Feb 2022, at 13:55, Andrew Jeffery wrote: >>> On Tue, 15 Feb 2022, at 13:42, Dhananjay Phadke wrote: >>>> On 2/14/2022 3:13 PM, Patrick Willia

Re: [PATCH] image: Control FIT signature verification at runtime

2022-02-27 Thread Andrew Jeffery
On Tue, 15 Feb 2022, at 13:55, Andrew Jeffery wrote: > On Tue, 15 Feb 2022, at 13:42, Dhananjay Phadke wrote: >> On 2/14/2022 3:13 PM, Patrick Williams wrote: >>> On Mon, Feb 14, 2022 at 11:14:53AM -0800, Dhananjay Phadke wrote: >>>> There's a key-requir

Re: [PATCH 0/3] gpio: Add AST2[456]00 GPIO driver

2022-02-16 Thread Andrew Jeffery
On Wed, 16 Feb 2022, at 19:02, Ryan Chen wrote: > Hello Andrew, > This patch series are ok, Please help add Reviewed-by: Ryan Chen > Thanks Ryan. This is all that's necessary! Andrew

[PATCH 3/3] configs: evb-ast2[56]00: Enable GPIO control

2022-02-15 Thread Andrew Jeffery
Build in the driver for the Aspeed GPIO controller and turn on the `gpio` shell command. Signed-off-by: Andrew Jeffery --- configs/evb-ast2500_defconfig | 3 +++ configs/evb-ast2600_defconfig | 3 +++ 2 files changed, 6 insertions(+) diff --git a/configs/evb-ast2500_defconfig b/configs/evb

[PATCH 1/3] gpio: Add Aspeed GPIO driver

2022-02-15 Thread Andrew Jeffery
The Aspeed GPIO driver supports the GPIO controllers found in the AST2400, AST2500 and AST2600 BMC SoCs. The implementation is a cut-down copy of the upstream Linux kernel driver, adapted for u-boot. Signed-off-by: Andrew Jeffery --- drivers/gpio/Kconfig | 7 + drivers/gpio/Makefile

[PATCH 2/3] ARM: dts: ast2500: Add ngpios property to GPIO node

2022-02-15 Thread Andrew Jeffery
Populate gpio_count in the gpio subsystem for the AST2500. Signed-off-by: Andrew Jeffery --- arch/arm/dts/ast2500.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/dts/ast2500.dtsi b/arch/arm/dts/ast2500.dtsi index 98359bf92425..ee66ef67042b 100644 --- a/arch/arm/dts/ast2500

[PATCH 0/3] gpio: Add AST2[456]00 GPIO driver

2022-02-15 Thread Andrew Jeffery
7;ve lightly tested the driver as-presented under qemu. That said, as the code has been lifted from Aspeed's SDK (and in-turn from Linux) the implementation has seen much wider testing. Please review! Andrew Andrew Jeffery (3): gpio: Add Aspeed GPIO driver ARM: dts: ast2500: Add ngpios proper

Re: [PATCH] image: Control FIT signature verification at runtime

2022-02-14 Thread Andrew Jeffery
On Tue, 15 Feb 2022, at 13:42, Dhananjay Phadke wrote: > On 2/14/2022 3:13 PM, Patrick Williams wrote: >> On Mon, Feb 14, 2022 at 11:14:53AM -0800, Dhananjay Phadke wrote: >>> There's a key-requirement policy already implemented [1]. >>> >>> [1] >>> https://lore.kernel.org/u-boot/cover.159764301

Re: [PATCH] image: Control FIT signature verification at runtime

2022-02-14 Thread Andrew Jeffery
On Tue, 15 Feb 2022, at 09:43, Patrick Williams wrote: > On Mon, Feb 14, 2022 at 11:14:53AM -0800, Dhananjay Phadke wrote: >> On 2/13/2022 5:13 PM, Andrew Jeffery wrote: >> >> We can decouple HW RoT and runtime control on enforcing secure boot >> (requirin

Re: [PATCH] image: Control FIT signature verification at runtime

2022-02-14 Thread Andrew Jeffery
On Tue, 15 Feb 2022, at 05:44, Dhananjay Phadke wrote: > On 2/13/2022 5:13 PM, Andrew Jeffery wrote: >> Right, I think this question is an indication that I could write a more >> informative commit message, so if we converge on something acceptable >> I'll update it

Re: [PATCH] image: Control FIT signature verification at runtime

2022-02-13 Thread Andrew Jeffery
Hi Alex, thanks for taking a look at the patch. On Sun, 13 Feb 2022, at 05:25, Alex G. wrote: > On 1/30/22 21:41, Andrew Jeffery wrote: >> Some platform designs include support for disabling secure-boot via a >> jumper on the board. Sometimes this control can be separate from t

Re: [PATCH] image: Control FIT signature verification at runtime

2022-02-08 Thread Andrew Jeffery
-of-trust for the platform. Add support for this latter >> scenario >> by allowing boards to implement board_fit_image_require_verfied(), which is >> then invoked in the usual FIT verification paths. >> >> Signed-off-by: Andrew Jeffery >> --- >> Hi,

Re: [PATCH] gpio: Add gpio_request_by_line_name()

2022-01-31 Thread Andrew Jeffery
Hi Fabio, thanks for taking a look. On Tue, 1 Feb 2022, at 02:40, Fabio Estevam wrote: > On Mon, Jan 31, 2022 at 9:55 AM Andrew Jeffery wrote: >> >> Add support for the upstream gpio-line-names property already described >> in the common GPIO binding document[1]. The ability

[PATCH] image: Control FIT signature verification at runtime

2022-01-31 Thread Andrew Jeffery
(), which is then invoked in the usual FIT verification paths. Signed-off-by: Andrew Jeffery --- Hi, This patch is extracted from and motivated by a series adding run-time control of FIT signature verification to u-boot in OpenBMC: https://lore.kernel.org/openbmc/20220131012538.73021-1-and

[PATCH] gpio: Add gpio_request_by_line_name()

2022-01-31 Thread Andrew Jeffery
/devicetree-org/dt-schema/blob/3c35bfee83c2e38e2ae7af5f83eb89ca94a521e8/dtschema/schemas/gpio/gpio.yaml#L17 Signed-off-by: Andrew Jeffery --- Hi, This patch is extracted from and motivated by a series adding run-time control of FIT signature verification to u-boot in OpenBMC: https