Should I send the patch again with version updated?
Regards,
Amul Kumar Saha
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Add command for changing Flex-OneNAND SLC / MLC boundary.
Also onenand commands work for Flex-OneNAND.
Signed-off-by: Rohit Hagargundgi
Signed-off-by: Amul Kumar Saha
---
common/cmd_onenand.c | 106 +++---
include/configs/apollon.h |2
2 files
Hi Scott,
> On Fri, Nov 06, 2009 at 05:17:44PM +0530, Amul Kumar Saha wrote:
>> - printk("Bad blocks %d at 0x%x\n",
>> -(u32)(ofs >> this->erase_shift), (u32)ofs);
>> + printk("Bad blocks %lu at 0x%x\n",
>> +(u32)onenand_blo
. Note that this
> function is not specified as inline in Linux.
>
Accepted and corrected
> There are some other fairly significant differences with Linux later in
> the patch -- is this due to missing functionality that u-boot doesn't
> need, or something else?
>
Yes, there a
Hi Scott,
>
> You seem to have stripped a copyright notice that was added in the Linux
> version of patch 1/3.
>
Updated in the current patch.
Regards,
Amul Kumar Saha
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.den
Add command for changing Flex-OneNAND SLC / MLC boundary.
Also onenand commands work for Flex-OneNAND.
Signed-off-by: Rohit Hagargundgi
Signed-off-by: Amul Kumar Saha
---
common/cmd_onenand.c | 90 +-
include/configs/apollon.h |2 -
2
Define and use CONFIG_ENV_ADDR_FLEX and CONFIG_ENV_SIZE_FLEX
for storing environment variables.
Signed-off-by: Rohit Hagargundgi
Signed-off-by: Amul Kumar Saha
---
common/env_onenand.c | 10 ++
include/configs/apollon.h |2 ++
2 files changed, 12 insertions(+)
diff --git a
This patch adds support for Flex-OneNAND devices.
Signed-off-by: Rohit Hagargundgi
Signed-off-by: Amul Kumar Saha
---
drivers/mtd/onenand/onenand_base.c | 740 +++-
drivers/mtd/onenand/onenand_bbt.c | 14
drivers/mtd/onenand/onenand_uboot.c |4
include
Define and use CONFIG_ENV_ADDR_FLEX and CONFIG_ENV_SIZE_FLEX
for storing environment variables.
Signed-off-by: Rohit Hagargundgi
Signed-off-by: Amul Kumar Saha
---
common/env_onenand.c | 10 ++
include/configs/apollon.h |2 ++
2 files changed, 12 insertions(+)
diff --git a
This patch adds support for Flex-OneNAND devices.
Signed-off-by: Rohit Hagargundgi
Signed-off-by: Amul Kumar Saha
---
drivers/mtd/onenand/onenand_base.c | 733 +++-
drivers/mtd/onenand/onenand_bbt.c | 14
drivers/mtd/onenand/onenand_uboot.c |4
include
Add command for changing Flex-OneNAND SLC / MLC boundary.
Also onenand commands work for Flex-OneNAND.
Signed-off-by: Rohit Hagargundgi
Signed-off-by: Amul Kumar Saha
---
common/cmd_onenand.c | 90 +-
include/configs/apollon.h |2 -
2
.
Patch 3/3: Flex-OneNAND SLC / MLC boundary setting.
Regards,
Amul Kumar Saha
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
OneNAND commands now work for Flex-OneNAND.
Add command for changing Flex-OneNAND SLC / MLC boundary.
Signed-off-by: Rohit Hagargundgi
Signed-off-by: Amul Kumar Saha
---
common/cmd_onenand.c | 103 --
include/configs/apollon.h |2
2 files
Hi Scott,
>> I believe that typecasting a UL to an int, is OK.
>> Do let me know.
>
> The compiler will implicitly cast unsigned long to int. The explicit cast
> is unnecessary clutter which makes it harder to find casts that aren't OK.
Accepted and changed.
Thank You
Amul.
___
Hi Scott,
>
>> + int blocks = (int) onenand_block(this, from + len)
>> +- onenand_block(this, from);
>
> Why the (int) cast? onenand_block() already returns int.
>
Resolved
>> - if (end_block > (mtd->size >> this->erase_shift))
>> - end_block = mtd->size >> this->erase_shift;
>> + if (e
t;> "to/from memory address 'addr', skipping bad blocks.\n"
>> - "onenand erase [force] [off size] - erase 'size' bytes from\n"
>> + "onenand erase [force] [off size] - erase 'size' bytes from off\n"
>
> Quotes aroun
eshift++;
>> + } else {
>> + mtd->numeraseregions -= 1;
>> + mtd->eraseregions[i].numblocks +=
>> + this->boundary[die] + 1;
>> + ofs += (this->boundary[die] + 1) << (eraseshift - 1);
>> + }
>> + if (this->boundary[die] != maxbdry) {
&
17 matches
Mail list logo
