Re: [PATCH v2] rockchip: rockchip-inno-usb2: Fix Synchronous Abort on usb start

2025-07-02 Thread Alex Shumsky
from 2019 installed by STB manufacturer). There is no Sync Abort with upstream SPL/TPL. Looks like NULL dereference are still there but some SPL/TPL init code prevents it from aborting. On Thu, Jul 3, 2025 at 9:05 AM Alex Shumsky wrote: > > Fix NULL pointer dereference that happen when ro

[PATCH v2] rockchip: rockchip-inno-usb2: Fix Synchronous Abort on usb start

2025-07-02 Thread Alex Shumsky
30d90f3367 ("clk: Ensure the parent clocks are enabled while reparenting") Co-authored-by: Jonas Karlman Signed-off-by: Alex Shumsky --- Changes in v2: - rework patch (add NULL check to code instead of dts modification) drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 19 +++

Re: [PATCH] rockchip: rk3328: Fix Synchronous Abort on usb start

2025-06-07 Thread Alex Shumsky
On Sun, May 25, 2025 at 8:35 PM Alex Shumsky wrote: > > Oops, I forgot Reply-All and some messages missed list. Sorry about that. > > Jonas and I have found NULL pointer dereference in > rockchip_usb2phy_clkout_ctl: > https://github.com/u-boot/u-boot/blob/df2ed552f0b05591090369

Re: [PATCH] rockchip: rk3328: Fix Synchronous Abort on usb start

2025-05-25 Thread Alex Shumsky
On 2025-05-24 18:02, Jonas Karlman wrote: > > Hi Alex, > > > > On 2025-05-24 16:20, Alex Shumsky wrote: > >> Remove incorrect assigned-clock-parents in rk3328-u-boot.dtsi. > >> This incorrect parent has become a problem since recent commit with parent > >&g

[PATCH] rockchip: rk3328: Fix Synchronous Abort on usb start

2025-05-24 Thread Alex Shumsky
Ensure the parent clocks are enabled while reparenting") Signed-off-by: Alex Shumsky --- arch/arm/dts/rk3328-u-boot.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/dts/rk3328-u-boot.dtsi b/arch/arm/dts/rk3328-u-boot.dtsi index b0e50a973a..39dcc2313b 100644 ---

Re: [PATCH v5] rockchip: board: Increase rng-seed size to make it sufficient for modern Linux

2024-10-16 Thread Alex Shumsky
On Wed, Oct 16, 2024 at 4:22 AM Dragan Simic wrote: > > Hello Alex, > > Thanks for the v5. Please see a few comments below. > > On 2024-10-15 23:28, Alex Shumsky wrote: > > Increase rng-seed size to make Linux happy and initialize rng pool > > instantly. > &

[PATCH v6] rockchip: board: Increase rng-seed size to make it sufficient for modern Linux

2024-10-16 Thread Alex Shumsky
/git/torvalds/linux.git/tree/drivers/char/random.c?h=v5.19#n551 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/char/random.c?h=v5.18#n236 Signed-off-by: Alex Shumsky Fixes: d2048bafae40 ("rockchip: board: Add board_rng_seed() for all Rockchip devices") R

[PATCH v5] rockchip: board: Increase rng-seed size to make it sufficient for modern Linux

2024-10-15 Thread Alex Shumsky
/git/torvalds/linux.git/tree/drivers/char/random.c?h=v5.19#n551 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/char/random.c?h=v5.18#n236 Signed-off-by: Alex Shumsky Fixes: d2048bafae40 ("rockchip: board: Add board_rng_seed() for all Rockchip devices") R

[PATCH] i2c: i2c-gpio: add support for i2c-gpio,sda-output-only

2024-10-15 Thread Alex Shumsky
Some I2C slave devices are read-only and don't even answer with NACK. For example FD65x segment LED controllers. Make them usable with i2c-gpio,sda-output-only that are already supported by Linux 6.3+. Signed-off-by: Alex Shumsky --- doc/device-tree-bindings/i2c/i2c-gpio.txt | 2 ++ dr

Re: [PATCH v4] rockchip: board: Increase rng-seed size to make it sufficient for modern Linux

2024-10-15 Thread Alex Shumsky
On Tue, Oct 15, 2024 at 12:34 PM Quentin Schulz wrote: > I'm wondering if we have somewhere some documentation on the environment > variables that exist and what they used for because this would be a nice > addition. At the very least, we can mention this variable in: > - include/fdt_support.h for

[PATCH v4] rockchip: board: Increase rng-seed size to make it sufficient for modern Linux

2024-10-14 Thread Alex Shumsky
/git/torvalds/linux.git/tree/drivers/char/random.c?h=v5.19#n551 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/char/random.c?h=v5.18#n236 Signed-off-by: Alex Shumsky Fixes: d2048bafae40 ("rockchip: board: Add board_rng_seed() for all Rockchip devices") R

[PATCH v3] rockchip: board: Increase rng-seed size to make it sufficient for modern Linux

2024-10-14 Thread Alex Shumsky
/7234e2ea0edd00bfb6bb2159e55878c19885ce68/drivers/char/random.c#L632 https://elixir.bootlin.com/linux/v5.18/source/drivers/char/random.c#L236 https://elixir.bootlin.com/linux/v5.19/source/drivers/char/random.c#L551 Signed-off-by: Alex Shumsky Fixes: d2048bafae40 ("rockchip: board: Add board_rng

[PATCH v2] rockchip: board: Increase rng-seed size to make it sufficient for modern Linux

2024-10-14 Thread Alex Shumsky
rng-seed: # dmesg | grep crng [0.00] random: crng init done https://github.com/torvalds/linux/blob/7234e2ea0edd00bfb6bb2159e55878c19885ce68/drivers/char/random.c#L632 Signed-off-by: Alex Shumsky Fixes: d2048bafae40 ("rockchip: board: Add board_rng_seed() for all Rockchip de

[PATCH] rockchip: board: Increase rng-seed size to make it sufficient for modern Linux

2024-10-13 Thread Alex Shumsky
rng-seed: # dmesg | grep crng [0.00] random: crng init done https://github.com/torvalds/linux/blob/7234e2ea0edd00bfb6bb2159e55878c19885ce68/drivers/char/random.c#L632 Signed-off-by: Alex Shumsky Fixes: d2048ba ("rockchip: board: Add board_rng_seed() for all Rockchip de

[PATCH v2] fs: btrfs: fix out of bounds write

2024-06-18 Thread Alex Shumsky
Fix btrfs_read/read_and_truncate_page write out of bounds of destination buffer. Old behavior break bootstd malloc'd buffers of exact file size. Previously this OOB write have not been noticed because distroboot usually read files into huge static memory areas. Signed-off-by: Alex Shumsky

[PATCH] fs: btrfs: fix out of bounds write

2024-06-17 Thread Alex Shumsky
Fix btrfs_read/read_and_truncate_page write out of bounds of destination buffer. Old behavior break bootstd malloc'd buffers of exact file size. Previously this OOB write have not been noticed because distroboot usually read files into huge static memory areas. Signed-off-by: Alex Sh