Re: [PATCH] x86: Update cbmem driver

2023-08-13 Thread Alex Sadovsky
Dear Simon and other developers, > - cursor = cbmem_console_p->buffer_cursor++; > - if (cursor < cbmem_console_p->buffer_size) > - cbmem_console_p->buffer_body[cursor] = data; > + pos = cons->cursor++; > + if (pos < cons->size) > + cons->body[pos] = data; Whi

Re: [PATCH 1/1] efi_loader: improve documentation of enum efi_test_phase

2021-03-28 Thread Alex Sadovsky
Dear Heinrich, > * Avoid a warning warning: "Incorrect use of kernel-doc format". > * Remove duplicate text. > * Clarify usage of EFI_SETTING_VIRTUAL_ADDRESS_MAP. This is a duplicate text too: `a warning warning'.

Re: Contributor meeting notes 19-Jan-21

2021-01-19 Thread Alex Sadovsky
Hi Simon, I think I should add my $0.02 here. > We already IRC a lot. This is partly about getting to know each other. > What is the benefit of jitsi? I believe I am permitted to use it, Jitsi is a free and lightweight solution: it's free/open-source and there's also a free public server (more

Re: [PATCH v7] Add support for stack-protector

2021-01-14 Thread Alex Sadovsky
Dear Joel, > Add support for stack protector for UBOOT, SPL, and TPL > as well as new pytest for stackprotector > > Signed-off-by: Joel Peshkin > Cc: Simon Glass > Cc: Heinrich Schuchardt > > Changes for v7: >    - Fix commit message >    - add __builtin_extract_return_addr() calls > Changes fo

Re: [PATCH] Add support for stack-protector

2021-01-10 Thread Alex Sadovsky
Hi, > + > +unsigned long __stack_chk_guard = 0xfeedf00ddeadbeef; sizeof(unsigned long) isn't always 8, even gcc issues a warning when it's invoked with proper options (e.g. 32-bit build): > warning: conversion from ‘long long unsigned int’ to ‘long unsigned int’ > changes value from ‘1836960239

Re: [U-Boot] U-Boot PXA support

2019-05-30 Thread Alex Sadovsky
> - HP iPAQ Pocket PC h2200 > > A consumer device with PXA255 from back in 2002. There has not been any > activity on h2200 from its maintainer Lukasz Dalek for almost 5 years > now. Without anybody actually owning such hardware stepping up it will > be quite impossible to maintain. I still have o

Re: [U-Boot] U-Boot PXA support

2019-05-21 Thread Alex Sadovsky
On 21/05/2019, Marek Vasut wrote: > On 5/21/19 11:50 AM, Alex Sadovsky wrote: >> It's slightly off-topic but I wonder whether this ongoing deprecation >> of ARMv4 and ARMv5 (first in GCC, then in U-Boot) really simplifies >> anything at all. >> There are tons o

Re: [U-Boot] U-Boot PXA support

2019-05-21 Thread Alex Sadovsky
It's slightly off-topic but I wonder whether this ongoing deprecation of ARMv4 and ARMv5 (first in GCC, then in U-Boot) really simplifies anything at all. There are tons of devices that are still working good and there are even ARMv5-based MCUs that are still produced (such as CH561 manufactured by

Re: [U-Boot] [PATCH 1/1] ubifs: no NULL check needed before free

2017-11-21 Thread Alex Sadovsky
Hi Heinrich and Heiko, do you see anything strange in this code (it was more obvious before the patch but it can still be spotted)? I should say that it's too late to check for "file != NULL" after the "file->private_data" dereference. Maybe it should look like this: if (file)

Re: [U-Boot] [PATCH] arm: zynq: Remove double const qualifier

2017-11-21 Thread Alex Sadovsky
Hi Michal, I'm sorry to disturb you and others but it looks like you've removed a bit too much. There are two different types of usage of the "const" modifier in the areas that are touched by your patch: 1) for function prototypes/implementation - "const" before the function name is senseless, fun

Re: [U-Boot] [PATCH] arch/arm/lib/relocate.S: Remove unreachable code

2017-03-18 Thread Alex Sadovsky
Hi, Tom > We support neither xscale nor ARMv4 at this point in time, so remove > this code. AFAIR, compiler sets __XSCALE__ when one specifies -mcpu=xscale option. This option is currently set by CONFIG_CPU_PXA and there are boards in U-Boot that are based on PXA CPU and depends on this config ite

[U-Boot] [PATCH RESEND] usb: gadget: pxa25x_udc: fix use-before-initialized bug

2015-01-08 Thread Alex Sadovsky
order of initialization. Signed-off-by: Alex Sadovsky --- I'm resending the patch with fixed 'Signed-off-by:' and 'From:' fields. There are no changes in patch contents. drivers/usb/gadget/pxa25x_udc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a