Re: [PATCH v3 1/2] CI testing: add http server to CI tests

2025-05-19 Thread Adriano Cordova Fedeli
Thanks for the review, but please use the v4 of this series. On Mon, 19 May 2025 at 03:06, Ilias Apalodimas wrote: > On Wed, 14 May 2025 at 19:17, Adriano Cordova wrote: > > > > Add an http server to CI tests so that HTTP booting and > > loading can be tested. > > > > Signed-off-by: Adriano Cor

Re: [PATCH 1/3] efi_loader: initrddump: use efi_uintn_t in printx

2025-05-07 Thread Adriano Cordova Fedeli
On Wed, 7 May 2025 at 11:03, Heinrich Schuchardt wrote: > Am 7. Mai 2025 16:46:17 MESZ schrieb Adriano Cordova : > >Use efi_uintn_t so that it also works in 32-bits. > > > >Signed-off-by: Adriano Cordova > >--- > > lib/efi_loader/initrddump.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 delet

Re: [PATCH 1/2] efi_loader: bootbin: split initrd registration and installation

2025-05-01 Thread Adriano Cordova Fedeli
Hi Heinrich, Calling efi_initrd_register to both save the initrd device path and install the initrd LF2 protocol complicates error handling. efi_bootmgr also calls efi_initrd_register, but many functions are called between that and do_bootefi_exec. If any fail, we should uninstall the protocol. Th

Re: [PATCH] efi_loader: bootbin: do not load an initrd if none is provided

2025-04-28 Thread Adriano Cordova Fedeli
Thanks, I updated the patch and split it into two On Mon, 28 Apr 2025 at 10:32, Ilias Apalodimas wrote: > Hi Adriano, > > On Mon, 28 Apr 2025 at 02:45, Adriano Cordova wrote: > > > > Do not try to create an initrd device path nor try to register > > an initrd with the EFI_LOAD_FILE2_PROTOCOL if

Re: [PATCH v2 2/2] efi_loader: efi_net: let efi_net_set_dp properly update the device path

2025-01-27 Thread Adriano Cordova Fedeli
Hi Heinrich and Tom, On Sun, 26 Jan 2025 at 12:59, Tom Rini wrote: > On Sat, Jan 04, 2025 at 12:05:24AM +0100, Heinrich Schuchardt wrote: > > On 06.12.24 18:18, Adriano Cordova wrote: > > > This commit fixes an use after free introduced in Commit e55a4acb54 > > > (" efi_loader: net: set EFI boot

Re: [PATCH] lwip: fix code style issues

2024-11-28 Thread Adriano Cordova Fedeli
On Thu, 7 Nov 2024 at 08:29, Jerome Forissier wrote: > Fix various code style issues in the lwIP code. > > Reported-by: Tom Rini > Signed-off-by: Jerome Forissier > --- > cmd/net-common.c | 9 +++- > cmd/net-lwip.c| 37 +++- > include/net-c