[PATCH v2 6/6] sunxi: add support for Liontron H-A133L board

2025-05-10 Thread Andre Przywara
The Liontron H-A133L is an industrial development board based on the Allwinner A133 SoC. It uses LPDDR4 DRAM, eMMC, and an AXP707 PMIC. Add a defconfig with the required DRAM settings. Signed-off-by: Andre Przywara --- configs/liontron-h-a133l_defconfig | 37 ++ 1 fi

[PATCH v2 5/6] arm64: dts: allwinner: a100: add Liontron H-A133L board support

2025-05-10 Thread Andre Przywara
The H-A133L board is an industrial development board made by Liontron. It contains a number of dedicated JST connectors, to connect external peripherals. It features: - Allwinner A133 SoC (4 * Arm Cortex-A53 cores at up to 1.6 GHz) - 1 GiB, 2 GiB or 4 GiB of LPDDR4 DRAM - between 16 and 128 GiB eM

[PATCH v2 4/6] arm64: dts: allwinner: a100: set maximum MMC frequency

2025-05-10 Thread Andre Przywara
The manual for the Allwinner A133 SoC mentions that the maximum supported MMC frequency is 150 MHz, for all of the MMC devices. Describe that in the DT entry, to help drivers setting the right interface frequency. Fixes: fcfbb8d9ec58 ("arm64: allwinner: a100: Add MMC related nodes") Signed-off-by

[PATCH v2 3/6] arm64: dts: allwinner: a100: Add CPU Operating Performance Points table

2025-05-10 Thread Andre Przywara
Add an Operating Performance Points table for the CPU cores to enable Dynamic Voltage & Frequency Scaling on the A100. Signed-off-by: Shuosheng Huang [masterr3c0rd@epochal.quest: fix typos in -cpu-opp, use compatible] Signed-off-by: Cody Eksal Link: https://patch.msgid.link/20241031070232.17930

[PATCH v2 2/6] sunxi: add support for the Allwinner A100/A133 SoC

2025-05-10 Thread Andre Przywara
The Allwinner A100 SoC has been around for a while, mostly on cheap tablets, but didn't generate much interest in the community so far. There were some efforts by two Allwinner employees in 2020, which led to basic upstream Linux support for that SoC, although this momentum dried up pretty quickly,

[PATCH v2 1/6] sunxi: A133: add DRAM init code

2025-05-10 Thread Andre Przywara
From: Cody Eksal This adds preliminary support for the DRAM controller in the Allwinner A100/A133 SoCs. This is work in progress, and has rough edges, but works on at least three different boards. It contains support for DDR4 and LPDDR4. [Andre: formatting fixes, adapt to mainline, drop unused p

[PATCH v2 0/6] sunxi: Allwinner A133 SoC support

2025-05-10 Thread Andre Przywara
This is an update to that early post of the Allwinner A133 SoC support, now much more serious, and also adding support for a development board. The DRAM init code was heavily updated, also rebased to apply on latest mainline. Some uncontroversial and simple patches from v1 have been merged, so this

[PATCH v2] riscv: dts: jh7110: override syscrg assigned clock rates with defaults

2025-05-10 Thread E Shattow
JH7110 drivers are missing support for CPU frequency scaling, so override upstream device-tree to use default clock rates for syscrg. This override duplicates a portion of jh7110-common-u-boot.dtsi file planned for removal. Signed-off-by: E Shattow Reviewed-by: Leo Liang --- arch/riscv/dts/jh71

[PATCH v2] clk: Fix clk_set_parent() regression

2025-05-10 Thread Jonas Karlman
The commit ac30d90f3367 ("clk: Ensure the parent clocks are enabled while reparenting") add a call to clk_enable() for the parent clock. For clock drivers that do not implement the enable() ops, like most Rockchip clock drivers, this now cause the set_parent() ops to never be called when CLK_CCF=n

Re: [PATCH v4 06/22] fdt: Redo devicetree setup

2025-05-10 Thread Jonas Karlman
Hi Simon, On 2025-05-10 15:42, Simon Glass wrote: > The existing logic for handling receiving a devicetree from a previous > phase is quite complicated. Simplify it in preparation for introducing > standard passage. > > Add a Kconfig called OF_PASSAGE which indicates that the devicetree > must co

Re: [PATCH v2 3/4] doc: pytest: Document the test_net_boot test

2025-05-10 Thread Tom Rini
On Sat, May 10, 2025 at 01:25:27PM +0200, Simon Glass wrote: > On Thu, 8 May 2025 at 00:11, Tom Rini wrote: > > > > Add the test_net_boot.py test to the generated documentation. While most > > of this was already commented correctly for inclusion the biggest > > problem was examples of code withou

Re: [PATCH v2] efi_loader: Disable ANSI output for tests

2025-05-10 Thread Tom Rini
On Sat, May 10, 2025 at 02:54:38PM +0200, Simon Glass wrote: > We don't want ANSI escape-sequences written in tests since it is a pain > to check the output with ut_assert_nextline() et al. > > Provide a way to tests to request that these characters not be sent. > > Add a proper function comment

[PATCH v4 00/22] passage: Define a standard for firmware data flow

2025-05-10 Thread Simon Glass
This series adds a standard way of passing information between different firmware phases. This already exists in U-Boot at a very basic level, in the form of a bloblist containing an spl_handoff structure, but the intent here is to define something useful across projects. The need for this is gr

[PATCH v4 20/22] passage: Add docs for spl_handoff

2025-05-10 Thread Simon Glass
This tag already exists in U-Boot. Add documentation, following the format set out. Signed-off-by: Simon Glass --- (no changes since v1) board/sandbox/stdpass_check.c | 15 --- include/handoff.h | 10 +++--- 2 files changed, 15 insertions(+), 10 deletions(-) diff -

[PATCH v4 18/22] sandbox: Add a way of checking structs for standard passage

2025-05-10 Thread Simon Glass
Add a file which can be used to check that structs used in standard passage do compile. No other validation is done at present, but could be considered later. Signed-off-by: Simon Glass --- (no changes since v1) board/sandbox/Makefile| 3 ++- board/sandbox/stdpass_check.c | 34 +++

[PATCH v4 22/22] CI: Add tests for gitlab and azure

2025-05-10 Thread Simon Glass
Add tests that check that SPL can generate a standard passage on ARM and that U-Boot proper can accept it successfully. - Finish the commit message Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add test for aarch64 - Add tests for azure .azure-pipelines.yml | 6 +

[PATCH v4 21/22] passage: Add checks for pre-existing blobs

2025-05-10 Thread Simon Glass
Add checks / documentation for blobs which are already in the list. This brings U-Boot up to the standard required by the standard-passage documentation. Signed-off-by: Simon Glass --- (no changes since v1) board/sandbox/stdpass_check.c | 70 - include/stdpass/tpm2_eventlog.h | 42

[PATCH v4 19/22] passage: Add documentation

2025-05-10 Thread Simon Glass
Add documentation about standard passage and update the maintainers. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Fix 'that' typo - Update docs for the various code changes Changes in v2: - Add comments about how to pass standard passage to EFI - Add comments about pas

[PATCH v4 17/22] passage: Add a qemu test for ARM

2025-05-10 Thread Simon Glass
Check that the standard passage works on ARM, by setting it up in SPL and making sure that it comes through correctly in U-Boot proper. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add conditions to avoid enaling the test on qemu_arm_sbsa - Add support for a 64-bit test

[PATCH v4 16/22] xferlist: Drop old xferlist code

2025-05-10 Thread Simon Glass
This is not needed now, as the startup protocol is handled in arch-specific code early in boot. Drop BLOBLIST_PASSAGE_MANDATORY as well, as OF_BLOBLIST is enough to cover this. With standard passage the devicetree is accessed before the bloblist is inited. Signed-off-by: Simon Glass --- (no cha

[PATCH v4 15/22] arm: qemu: Add a 64-bit SPL build

2025-05-10 Thread Simon Glass
Add an 64-bit SPL build for qemu so we can test the standard passage feature. Include a binman definition so that SPL and U-Boot are in the same image. This requires adding a proper devicetree file for qemu_arm. It is only used for the SPL build. Avoid using the QEMU devicetree in U-Boot proper,

[PATCH v4 14/22] arm: qemu: Add an SPL build

2025-05-10 Thread Simon Glass
Add an SPL build for qemu so we can test the standard passage feature. Include a binman definition so that SPL and U-Boot are in the same image. This requires adding a proper devicetree file for qemu_arm. It is only used for the SPL build. Avoid using the QEMU devicetree in U-Boot proper, so we c

[PATCH v4 13/22] vexpress_fvp: Update to use the new Kconfig options

2025-05-10 Thread Simon Glass
We need to enable CONFIG_BLOBLIST_PASSAGE sand CONFIG_PASSAGE_IN so that U-Boot is built with support for accepting an incoming standard passage. Update the defconfig accordingly. Signed-off-by: Simon Glass --- Changes in v4: - Add new patch to update vexpress_fvp to use the new Kconfig options

[PATCH v4 12/22] passage: arm: Add the arch-specific standard passage impl

2025-05-10 Thread Simon Glass
Add implementations for 32- and 64-bit ARM. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Update registers to match the Firmware Handoff protocol Changes in v2: - Add new patch with the arm-specific standard passage implementation arch/arm/cpu/armv7/cpu.c | 18 +++

[PATCH v4 11/22] passage: spl: Support passing the passage to U-Boot

2025-05-10 Thread Simon Glass
Create a new arch-specific way of creating a standard passage for the next phase. Signed-off-by: Simon Glass --- Changes in v4: - Fix 'to' typo Changes in v2: - Make the stdpass calling standard arch-specific common/spl/spl.c | 26 +- 1 file changed, 21 insertions(+),

[PATCH v4 10/22] passage: spl: Support adding the dtb to the passage bloblist

2025-05-10 Thread Simon Glass
Add an option for SPL to add a devicetree to the passage bloblist, so SPL can provide the devicetree to U-Boot. Fix a few long lines while we are here. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Rebase on -master - Update the commit message to mention the long lines

[PATCH v4 09/22] passage: arm: Accept a passage from the previous phase

2025-05-10 Thread Simon Glass
Accept a bloblist and control devicetree from a previous phase in registers 0 to 3, as documented in the Firmware Handoff specification[1]. Note that there is currently a weak function called save_boot_params() which happens to save the same registers as are needed for this protocol. But it seems

[PATCH v4 08/22] bloblist: Adjust how the bloblist is received from passage

2025-05-10 Thread Simon Glass
With standard passage we can read the bloblist from global_data. Update the implementation to handle this, thus simplifying the code somewhat. Shrink the log_msg_ret() string back down to a more normal size. Note that if OF_BLOBLIST is enabled, this code should never be reached unless there is a

[PATCH v4 07/22] fdt: Support reading FDT from standard passage

2025-05-10 Thread Simon Glass
Add an option to receive the FDT using standard passage from a previous phase. Rename the FDT source to 'passage' to match the old terminology, which was only partially added. Signed-off-by: Simon Glass --- (no changes since v1) env/common.c | 2 +- include/fdtdec.h | 4 ++-- lib/fdtdec.

[PATCH v4 06/22] fdt: Redo devicetree setup

2025-05-10 Thread Simon Glass
The existing logic for handling receiving a devicetree from a previous phase is quite complicated. Simplify it in preparation for introducing standard passage. Add a Kconfig called OF_PASSAGE which indicates that the devicetree must come from standard passage. Signed-off-by: Simon Glass --- Cha

[PATCH v4 05/22] passage: Support an incoming passage

2025-05-10 Thread Simon Glass
Plumb in the ability for U-Boot proper to accept an incoming standard passage from a previous phase, such as SPL or TF-A. This allows data to be passed from binary to binary when firmware is booting. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add passage_valid() to de

[PATCH v4 04/22] spl: Rename jump_to_image_no_args()

2025-05-10 Thread Simon Glass
This is about to become a misnomer since with standard passage we need to pass arguments to U-Boot. Rename the function. Also rename the local variable to 'jumper' to avoid a conflict. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Split the jump_to_image_no_args() chang

[PATCH v4 03/22] x86: Move Intel GNVS file into the common include directory

2025-05-10 Thread Simon Glass
Move this so we can include it from sandbox, needed since it is in a bloblist and must have a check. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/cpu/apollolake/acpi.c| 2 +- arch/x86/cpu/intel_common/acpi.c | 2 +- arch/x86/include/asm/arc

[PATCH v4 02/22] spl: Tidy up the header includes

2025-05-10 Thread Simon Glass
These are out of order. Fix them. Signed-off-by: Simon Glass --- (no changes since v1) common/spl/spl.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/common/spl/spl.c b/common/spl/spl.c index 76fd56dfe4b..abbca9acde0 100644 --- a/common/spl/s

[PATCH v4 01/22] emulation: fdt: Allow using U-Boot's device tree with QEMU

2025-05-10 Thread Simon Glass
At present it is impossible to change the qemu_arm64 defconfig to obtain a devicetree from the U-Boot build. This is necessary for FIT validation, for example, where the signature node must be compiled into U-Boot. A proposed change to QEMU to allow device tree additions has been blocked for seve

[PATCH v3 03/10] ext4: Avoid expr in declaration in ext4fs_get_bgdtable()

2025-05-10 Thread Simon Glass
Move the expression into the body of the function so the ordering can be adjusted. Signed-off-by: Simon Glass --- (no changes since v1) fs/ext4/ext4_write.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/ext4/ext4_write.c b/fs/ext4/ext4_write.c index d109ed6e90d..8e6

[PATCH v3 02/10] Bring in linux/overflow.h

2025-05-10 Thread Simon Glass
From: Simon Glass Add this file from Linux v6.14 so we can use it to add overflow checks, rather than using compiler built-ins directly. Signed-off-by: Simon Glass Suggested-by: Tom Rini Reviewed-by: Tom Rini Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Add new pat

[PATCH v3 00/10] ext4: Overflow fixes

2025-05-10 Thread Simon Glass
This series fixes some potential overflows in the ext4 code with invalid or malicious filesystems. To assist with this and future work, it brings in overflow.h and part of limits.h from Linux. Changes in v3: - Split out into separate patches for easier review Changes in v2: - Add new patch to br

[PATCH v3 07/10] ext4: Replace multiplication with an existing variable

2025-05-10 Thread Simon Glass
Since gdsize_total is known to be a multiple of blksz, there is no need to recompute the value later in the function. Just use the variable, to avoid what might look like an overflow. Signed-off-by: Simon Glass --- (no changes since v1) fs/ext4/ext4_write.c | 2 +- 1 file changed, 1 insertion(

[PATCH v3 10/10] ext4: Check for overflow when allocating tables

2025-05-10 Thread Simon Glass
An overflow could cause too little memory to be allocated, thus potentially causing undefined behaviour. Add a check for overflow. Since blk_bmaps and inode_bmaps use the same size, share the variable. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Use Linux macros inste

[PATCH v3 09/10] ext4: Make sure there is at least one sector per block

2025-05-10 Thread Simon Glass
The implementation assumes that a sector can fit in a block, so add a check for this. Signed-off-by: Simon Glass --- (no changes since v1) fs/ext4/ext4_write.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/ext4/ext4_write.c b/fs/ext4/ext4_write.c index 9b1e26e86a7..a48d1fd26be 10064

[PATCH v3 08/10] ext4: Set a max limit on block-size in ext4fs_init()

2025-05-10 Thread Simon Glass
The block size is typically around 4K. Complain if it is much larger, since this can cause problems with 32-bit arithmetic. Signed-off-by: Simon Glass --- (no changes since v1) fs/ext4/ext4_write.c | 4 1 file changed, 4 insertions(+) diff --git a/fs/ext4/ext4_write.c b/fs/ext4/ext4_writ

[PATCH v3 06/10] ext4: Bail out of no_blk_pergdt() if there are no blocks

2025-05-10 Thread Simon Glass
If the size is too small, return an error, since no_blk_pergdt is assumed to be non-zero in the following code. Signed-off-by: Simon Glass --- (no changes since v1) fs/ext4/ext4_write.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/ext4/ext4_write.c b/fs/ext4/ext4_write.c index ae26

[PATCH v3 04/10] ext4: Create a var for the number of blocks to allocate

2025-05-10 Thread Simon Glass
Since this expression might overflow, put it in a variable. Signed-off-by: Simon Glass --- (no changes since v1) fs/ext4/ext4_write.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/ext4/ext4_write.c b/fs/ext4/ext4_write.c index 8e6179c4a99..86420d1c9d7 100644 --- a/f

[PATCH v3 05/10] ext4: Check for overflow of block count

2025-05-10 Thread Simon Glass
An overflow could cause too little memory to be allocated, thus potentially causing undefined behaviour. Add a check for overflow. Signed-off-by: Simon Glass --- (no changes since v1) fs/ext4/ext4_write.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/ext4/ext4_write

[PATCH v3 01/10] Bring in linux/limits.h

2025-05-10 Thread Simon Glass
From: Simon Glass Add part of this file from Linux v6.14 so we can include it from the linux/overflow.h file. Drop the relevant section from kernel.h The top of the file is omitted since it defines things used in mbedos and we get an error on SIZE_MAX. Signed-off-by: Simon Glass Signed-off-by:

Re: [PATCH v3 00/22] passage: Define a standard for firmware data flow

2025-05-10 Thread Simon Glass
Hi Tom, On Thu, 1 May 2025 at 23:11, Tom Rini wrote: > > On Thu, May 01, 2025 at 02:57:00PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Thu, 1 May 2025 at 10:04, Tom Rini wrote: > > > > > > On Wed, Apr 30, 2025 at 07:39:29PM -0600, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Wed,

Re: [PATCH v3 10/22] passage: arm: Accept a passage from the previous phase

2025-05-10 Thread Simon Glass
Hi Heinrich, On Sun, 4 May 2025 at 11:16, Heinrich Schuchardt wrote: > > Am 17. April 2025 20:15:52 MESZ schrieb Simon Glass : > >Accept a bloblist and control devicetree from a previous phase in > >registers 0 to 3, as documented in the Firmware Handoff > >specification[1]. > > > >[1] https://fi

[PATCH v2] efi_loader: Disable ANSI output for tests

2025-05-10 Thread Simon Glass
We don't want ANSI escape-sequences written in tests since it is a pain to check the output with ut_assert_nextline() et al. Provide a way to tests to request that these characters not be sent. Add a proper function comment while we are here, to encourage others. Signed-off-by: Simon Glass ---

[PATCH] net: xgmac: Augment mdio read/write with cl-45 format support

2025-05-10 Thread Nikunj Kela
Currently, clause-22 format is supported. This change adds support for clause-45 format. Signed-off-by: Nikunj Kela --- drivers/net/dwc_eth_xgmac.c | 67 +++-- 1 file changed, 49 insertions(+), 18 deletions(-) diff --git a/drivers/net/dwc_eth_xgmac.c b/drivers/ne

Re: [PATCH] efi_loader: Disable ANSI output for tests

2025-05-10 Thread Mark Kettenis
> From: Simon Glass > Date: Sat, 10 May 2025 13:36:24 +0200 Hi Simon, > We don't want ANSI characters written in tests since it is a pain to > check the output with ut_assert_nextline() et al. You probably shouldn't use the term "ANSI characters" here when you really mean "ANSI escape sequences

[PATCH] efi_loader: Disable ANSI output for tests

2025-05-10 Thread Simon Glass
We don't want ANSI characters written in tests since it is a pain to check the output with ut_assert_nextline() et al. Provide a way to tests to request that ANSI characters not be sent. Add a proper function comment while we are here, to encourage others. Signed-off-by: Simon Glass --- inclu

Re: [PATCH v2 1/3] Bring in linux/limits.h

2025-05-10 Thread Simon Glass
Hi Tom, On Wed, 7 May 2025 at 17:47, Tom Rini wrote: > > On Wed, May 07, 2025 at 09:23:23AM -0600, Tom Rini wrote: > > On Wed, May 07, 2025 at 10:47:13AM +0200, Simon Glass wrote: > > > Hi Tom, > > > > > > On Fri, 18 Apr 2025 at 15:39, Tom Rini wrote: > > > > > > > > On Fri, Apr 18, 2025 at 04:5

Re: [PATCH 3/3] doc: pytest: Document the test_button test

2025-05-10 Thread Simon Glass
On Thu, 8 May 2025 at 23:42, Tom Rini wrote: > > Add this test to the documentation. No changes to the test itself were > required. > > Signed-off-by: Tom Rini > --- > Cc: Heinrich Schuchardt > Cc: Simon Glass > --- > doc/develop/pytest/index.rst | 1 + > doc/develop/pytest/test_button.r

Re: [PATCH 2/3] doc: pytest: Document the test_bootmenu test

2025-05-10 Thread Simon Glass
On Thu, 8 May 2025 at 23:42, Tom Rini wrote: > > Add this test to the documentation. There was already a function comment > that included the argument, so convert it to the right style to be > rendered correctly in output. > > Signed-off-by: Tom Rini > --- > Cc: Heinrich Schuchardt > Cc: Simon G

Re: [PATCH 1/3] doc: pytest: Document the test_bind test

2025-05-10 Thread Simon Glass
On Thu, 8 May 2025 at 23:42, Tom Rini wrote: > > Add this test to the documentation. None of the functions had comments, > so attempt to explain what each does. > > Signed-off-by: Tom Rini > --- > Cc: Heinrich Schuchardt > Cc: Simon Glass > --- > doc/develop/pytest/index.rst | 1 + > doc/

Re: [PATCH 0/3] doc: Document remaining test_b* tests

2025-05-10 Thread Simon Glass
Hi Tom, On Thu, 8 May 2025 at 23:42, Tom Rini wrote: > > Hey all, > > This short series is a follow-up to my last series. It could have been > longer, but I think this is a good point to get some feedback on a few > points. > > As background, something I wondered about and the answer seems to be

Re: [PATCH v2 01/18] abuf: Add a helper for initing and allocating a buffer

2025-05-10 Thread Simon Glass
Hi Tom, On Tue, 6 May 2025 at 21:48, Tom Rini wrote: > > On Tue, May 06, 2025 at 03:23:39PM +0200, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 5 May 2025 at 22:38, Tom Rini wrote: > > > > > > On Thu, May 01, 2025 at 07:37:01AM -0600, Simon Glass wrote: > > > > > > > This construct appears in

Re: [PATCH v2 0/3] booti: Remove the SYS_BOOTM_LEN limit for booti

2025-05-10 Thread Simon Glass
Hi Tom, On Tue, 6 May 2025 at 18:32, Tom Rini wrote: > > On Tue, May 06, 2025 at 03:24:21PM +0200, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 5 May 2025 at 20:14, Tom Rini wrote: > > > > > > On Thu, May 01, 2025 at 07:18:32AM -0600, Simon Glass wrote: > > > > > > > This series restores the o

Re: [PATCH 00/11] regex patches

2025-05-10 Thread Simon Glass
On Tue, 6 May 2025 at 16:15, Rasmus Villemoes wrote: > > This started as a rather simple patch, 1/11, adding the ability to > more conveniently do regex matching in shell. > > But with that, it became very easy to see what the slre library can > and especially what it cannot do, and that way I fou

Re: [PATCH] doc: document test command

2025-05-10 Thread Simon Glass
On Tue, 6 May 2025 at 22:55, Rasmus Villemoes wrote: > > Add documentation for the test command, including the newly added =~ > operator and some gotchas wrt. the numeric comparisons. > > Signed-off-by: Rasmus Villemoes > --- > > This should be considered on top of > https://lore.kernel.org/u-boo

Re: [PATCH 3/3] doc: pytest: Document the test_efi_loader test

2025-05-10 Thread Simon Glass
On Thu, 8 May 2025 at 01:25, Tom Rini wrote: > > Add this test to the documentation. We need to add a code-block > annotation to the example and indent it correctly. We also need to > document the do_test_efi_helloworld_net function and that in turn means > changing the documentation to test_efi_h

Re: [PATCH 2/3] doc: pytest: Document the test_bootstage test

2025-05-10 Thread Simon Glass
On Thu, 8 May 2025 at 01:25, Tom Rini wrote: > > Add this test to the documentation. We need to move the import to follow > the main comment so that it renders correctly, and add a code-block > annotation to the example and indent it correctly. Next, neither of the > functions had comments themsel

Re: [PATCH 1/3] doc: pytest: Document the test_net test

2025-05-10 Thread Simon Glass
On Thu, 8 May 2025 at 01:25, Tom Rini wrote: > > Add this test to the documentation. While the diff appears large at > first, the only changes within the test are to move the imports to > follow the pydoc comment and then to code-block and indent the example > configuration. > > Signed-off-by: Tom

Re: [PATCH v2 3/4] doc: pytest: Document the test_net_boot test

2025-05-10 Thread Simon Glass
On Thu, 8 May 2025 at 00:11, Tom Rini wrote: > > Add the test_net_boot.py test to the generated documentation. While most > of this was already commented correctly for inclusion the biggest > problem was examples of code without a code-block notation. This in turn > broke parsing. Add the missing

Re: [PATCH v2 4/4] test: test_net_boot: Add more comments

2025-05-10 Thread Simon Glass
On Thu, 8 May 2025 at 00:11, Tom Rini wrote: > > Some of the functions were missing pydoc comments. Add them so they will > be included in the documentation. > > Reported-by: Heinrich Schuchardt > Signed-off-by: Tom Rini > --- > Cc: Heinrich Schuchardt > Cc: Simon Glass > --- > test/py/tests/

Re: [PATCH v2 2/4] doc: pytest: Framework for documenting tests and document test_000_version

2025-05-10 Thread Simon Glass
Hi Tom, On Thu, 8 May 2025 at 00:11, Tom Rini wrote: > > In order to easily document pytests, we need to include the autodoc > extension. We also need to make sure that for building the docs, CI > includes pytest and that we have PYTHONPATH configured such that it will > find all of the tests and

Re: [PATCH v2 1/4] doc: Start improving our pytest documentation

2025-05-10 Thread Simon Glass
On Thu, 8 May 2025 at 00:11, Tom Rini wrote: > > Begin the work of documenting all of our pytests. To do this, we should > have a directory under develop for it as there will be a large number of > new files. As the current document is referenced externally in a number > of locations, add the sphi

Re: U-Boot support for wolfTPM and firmware update for SLB9672/SLB9673

2025-05-10 Thread Simon Glass
Hi David, On Thu, 8 May 2025 at 00:41, David Garske wrote: > > Hi Denx, > > We at wolfSSL have developed a port for wolfTPM in U-Boot. The patch allows > using the current built-in TPM 2.0 support or switching to wolfTPM via > CONFIG_TPM_WOLF=y. It also supports TPM 2.0 firmware update for the

Re: [PATCH 3/3] wip: binman: Move processing after templates

2025-05-10 Thread Simon Glass
Hi Moteen, On Fri, 9 May 2025 at 08:10, Moteen Shah wrote: > > Hey Simon, > A gentle ping on this. > > Regards, > Moteen > > On 28/04/25 16:53, Moteen Shah wrote: > > Hey Simon, > > Thanks for the suggestions and review. > > > > On 23/04/25 17:59, Simon Glass wrote: > >> Do the bootph processing

[PATCH 25/25] patman: Add basic documentation for new features

2025-05-10 Thread Simon Glass
Describe the new subcommands and how they should be used in a normal workflow. Note that the naming of branches is very rigid, or 'opinionated' in marketing terms. Patman can track a single branch for each version of a series and they must all be named the same, except for the version-number suffi

[PATCH 23/25] patman: Implement the upstream subcommand

2025-05-10 Thread Simon Glass
Add a command to allow managing the upstream tree. This is very basic so far, only allowing setting the name and URL. Further work may allow checking whether series apply cleaning on the upstream tree, etc. Signed-off-by: Simon Glass --- tools/patman/cmdline.py | 38

[PATCH 21/25] patman: Update send function to return whether it sent

2025-05-10 Thread Simon Glass
Indicate whether 'git send-email' was actually called, so that we don't bother waiting for patchwork to receive our series if it wasn't. The 'git send-email' seems to always return a code of 0 even if nothing was sent, so we cannot use clues there. Ideally we would watch the output to determine wh

[PATCH 22/25] patman: Implement the series subcommand

2025-05-10 Thread Simon Glass
Add a command to support management of series. These are local branches which may have been sent to the mailing list, so may appear on the patchwork server. The new functionality uses a database, stored in a local file. Various operations are supported: - add a new series - send a series an

[PATCH 20/25] patman: Support aliases for commands and subcommands

2025-05-10 Thread Simon Glass
It is laborious to type long commands, so add some aliases to speed up use of patman. For now, allow 'pw' for patchwork and 'st' for status. Signed-off-by: Simon Glass --- tools/patman/cmdline.py | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/tools/patma

[PATCH 17/25] patman: Introduce basic database support in Series

2025-05-10 Thread Simon Glass
This class manages a series, i.e. a group of patches with a possible cover letter. Add some properties for recording basic patchwork info, including the database ID. Signed-off-by: Simon Glass --- tools/patman/series.py | 15 +++ 1 file changed, 15 insertions(+) diff --git a/tools/

[PATCH 19/25] patman: Implement the patchwork subcommand

2025-05-10 Thread Simon Glass
Add a command to allow setting and getting the patchwork project. This is needed so that patman can use the correct ID when talking to the patchwork server. To support testing, allow passing in the test database, patchwork object and Cseries object. Fake versions can then easily be provided for ce

[PATCH 18/25] patman: Improve Series support for patchwork links

2025-05-10 Thread Simon Glass
Update Series with a way to better manage the Series-links lines in patches. Use this in the 'status' subcommand instead of the existing primitive method of expecting a link without a version prefix. Signed-off-by: Simon Glass --- tools/patman/control.py | 25 --- tools/patman/s

[PATCH 16/25] patman: Support returning the parsers to use

2025-05-10 Thread Simon Glass
The parsing tests need to be able to try invalid arguments to make sure that these are handled correctly. Provide a way to return the parsers being used, as well as to pass in the parsers to use. This feature is needed in test_series_no_subcmd(), for example. Signed-off-by: Simon Glass --- tool

[PATCH 15/25] patman: Use -c to show patch comments

2025-05-10 Thread Simon Glass
We chose -C as the flag to enable showing comments because -c was used in 'patman send' to specify the patch count. Now that the 'send' parser is separated we don't need to do this and it is OK to use the same flag in a different subcommand. We want to have a flag for cover-letter comments, so it

[PATCH 14/25] patman: Enhance implementation of file-based defaults

2025-05-10 Thread Simon Glass
Patman allows defaults for its command-line flags to be read from a file. The implementation of this does not fully work with subcommands, since we don't want a default for those. Also, it relies on being able to parse any sort of cmdline in order to figure out the options that are available. But

[PATCH 12/25] patman: Update status command support cover-letter info

2025-05-10 Thread Simon Glass
Add support to the status module for reading and supporting cover letters, including comments. Plumb this through to the patchwork module. The actual support in the latter is not yet integrated. Signed-off-by: Simon Glass --- tools/patman/func_test.py | 16 + tools/patman/patchwork.py |

[PATCH 13/25] patman: Enhance patchwork interface to support Cseries

2025-05-10 Thread Simon Glass
Add various new requests to the Patchwork class, so we can obtain the required information. This includes cover letters and comments. Signed-off-by: Simon Glass --- tools/patman/patchwork.py | 428 +- 1 file changed, 424 insertions(+), 4 deletions(-) diff --

[PATCH 10/25] patman: Add a helper for managing cseries

2025-05-10 Thread Simon Glass
Add a module which includes helper functions for dealing with Cseries objects. Signed-off-by: Simon Glass --- tools/patman/__init__.py|6 +- tools/patman/cser_helper.py | 1524 +++ 2 files changed, 1527 insertions(+), 3 deletions(-) create mode 100644 to

[PATCH 11/25] patman: Add a Cseries class

2025-05-10 Thread Simon Glass
This is the main class for dealing with series, across branches and the database. Signed-off-by: Simon Glass --- tools/patman/__init__.py |2 +- tools/patman/cseries.py | 1165 ++ 2 files changed, 1166 insertions(+), 1 deletion(-) create mode 100644 too

[PATCH 09/25] patman: Add a simple database implementation

2025-05-10 Thread Simon Glass
For recording series information, patman needs a database. Add a module which uses sqlite3 for this. It has a basic schema, enough to support a series subcommand. Signed-off-by: Simon Glass --- tools/patman/__init__.py | 3 +- tools/patman/database.py | 823 +++

[PATCH 08/25] patman: Avoid touching the system or local config

2025-05-10 Thread Simon Glass
Set the git variables to ensure that any local gitconfig is not used or affected by the tests. Signed-off-by: Simon Glass --- tools/patman/test_common.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/patman/test_common.py b/tools/patman/test_common.py index bc27b2d3cef..7da995dda

[PATCH 07/25] patman: Add a fourth series for testing

2025-05-10 Thread Simon Glass
Create one more series to use for testing. This one has four separate patches. Signed-off-by: Simon Glass --- tools/patman/test_common.py | 31 ++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/tools/patman/test_common.py b/tools/patman/test_common.py

[PATCH 06/25] patman: Move common test code into a new module

2025-05-10 Thread Simon Glass
The func_test file is quite large. In order to allow new tests to be added to a separate file, move the common test code into a separate class, to be inherited by other classes. Drop unnecessary imports in func_test Signed-off-by: Simon Glass --- tools/patman/__init__.py| 2 +- tools/pat

[PATCH 04/25] patman: Use python3 with /usr/bin/env

2025-05-10 Thread Simon Glass
If python2 is available then we must specify python3 here. Update the test to handle this. Signed-off-by: Simon Glass --- tools/patman/func_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/patman/func_test.py b/tools/patman/func_test.py index 00aed8786e8..da8110

[PATCH 05/25] patman: Add a test for collecting a PATCH prefix

2025-05-10 Thread Simon Glass
Add one more test for completeness, since this occurs commonly. Signed-off-by: Simon Glass --- tools/patman/func_test.py | 8 1 file changed, 8 insertions(+) diff --git a/tools/patman/func_test.py b/tools/patman/func_test.py index da81101ea93..55abf52bdb5 100644 --- a/tools/patman/fun

[PATCH 03/25] u_boot_pylib: Add more functions to gitutil

2025-05-10 Thread Simon Glass
Add functions for checking a branch, showing a commit, etc. to support the new functionality. Git version 2.34.1 ignores --stat if --quiet is given, so adjust the args so that this performs as expected. Signed-off-by: Simon Glass --- tools/u_boot_pylib/gitutil.py | 96 +

[PATCH 02/25] patman: Deal with git safe-directory warning

2025-05-10 Thread Simon Glass
When running tests where the .git directory is not owned by the current user, various warnings are produced and the tests fail. This happens in CI. For patman itself, modify the gitutil.get_top_level() function to return None in this case. Ensure that the warning is not shown, since it creates abo

[PATCH 00/25] patman: Support beter management of series

2025-05-10 Thread Simon Glass
Patman provides good facilities for preparing and sending out series. It also has a way to collect review/test tags from Patchwork in preparation for sending the next series. But so far it lacks series management. This series provides a few new subcommands, mainly 'series', which: - maintains a l

[PATCH 01/25] u_boot_pylib: Correct pylint warnings in gitutil

2025-05-10 Thread Simon Glass
Correct various pylint warnings in this file. The remaining ones are three functions with too many arguments (R0913 and R0918) and use of global (W0603). Signed-off-by: Simon Glass --- tools/u_boot_pylib/gitutil.py | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff -

[PATCH] ARM: stm32mp: Correct sign extension for memory address in dram_bank_mmu_setup()

2025-05-10 Thread Lukasz Majewski
On a system based on stm32mp157c, with 1GiB SDRAM (starting from 0xC000) and CONFIG_PHYS_64BIT enabled (so the phys_addr_t becomes 'unsigned long long') the mainline u-boot hangs. It is caused by marking for this memory region the TLB entry as invalid in the dram_bank_mmu_setup(). To be more