[PATCH v2 4/6] net: eth_bootdev_hunt() should not run DHCP

2024-11-26 Thread Heinrich Schuchardt
Currently when booting dhcp_run() may be executed multiple times: once in eth_bootdev_hunt() and once in the network booting bootmeth. We need to call eth_bootdev_hunt() when setting up the EFI sub-system to supply the simple network protocol. We don't need an IP address set up. We can reduce the

[PATCH v2 6/6] efi_loader: run bootdev_hunt() to find ESP

2024-11-26 Thread Heinrich Schuchardt
Some hard devices need specific routines to scan for block devices, e.g. NVMe (nvme scan), SCSI (scsi start). Invoke bootdev_hunt() to find all block devices. Reviewed-by: Ilias Apalodimas Reviewed-by: Simon Glass Signed-off-by: Heinrich Schuchardt --- v2: no change --- cmd/bootmenu.c

[PATCH 2/2] configs: starfive_visionfive2: allocate bounce buffer from heap

2024-11-26 Thread Sughosh Ganu
The boards using this config have a mmc controller IP which is unable to access memory regions above 4GB. Enable the CONFIG_BOUNCE_BUFFER_ALLOC config for these platforms. This symbol forces the allocation of the bounce buffer to be done from the U-Boot heap area. Signed-off-by: Sughosh Ganu ---

[PATCH 0/2] bouncebuf: Allow allocation from U-Boot heap

2024-11-26 Thread Sughosh Ganu
Certain platforms have IP's which are unable to access memory locations above a particular address. Add a config symbol which forces the bounce buffer to be allocated from U-Boot's heap area, and enable this option on the starfive visionfive2 boards which have this issue. @E Shattow - Since you

[PATCH 1/2] bouncebuf: allow for allocating bounce buffer frome heap

2024-11-26 Thread Sughosh Ganu
The current bounce buffer logic checks if the user passed buffer is DMA aligned, and if so, the same buffer is used. This can be an issue on platforms which have certain IP's that are unable to access memory addresses above a certain point. Introduce a config symbol that can be used by such platfor

[PATCH v2 5/6] cmd: bootmenu: add parameter -e for UEFI boot options

2024-11-26 Thread Heinrich Schuchardt
The bootmenu command can display * menu entries defined by environment variables * menu entries defined by UEFI boot options Not in all cases showing the UEFI boot options is desired. Provide a new parameter '-e' to select the display of UEFI boot options. Reviewed-by: Ilias Apalodimas Signed-o

[PATCH v2 3/6] CI: xilinx_versal_virt: disable USB_DWC3

2024-11-26 Thread Heinrich Schuchardt
The CI uses the following command to launch xilinx_versal_virt_defconfig: qemu-system-aarch64 -M xlnx-versal-virt \ -display none -m 4G -serial mon:stdio \ -device loader,file=u-boot,cpu-num=0 'usb start' or invoking eth_bootdev_hunt leads to a crash when function dwc3_core_init() tri

[PATCH v2 0/6] efi_loader: run bootdev_hunt() to find ESP

2024-11-26 Thread Heinrich Schuchardt
When initializing the EFI sub-system we need all block devices and the NIC to be probed. Extensions should have been applied to the device-tree. Our current implementation only guarantees that bound block devices are probed. But this misses out devices where binding requires specific routines to b

[PATCH v2 2/6] configs: sandbox_deconfig: remove CONFIG_AMIGA_PARTITION

2024-11-26 Thread Heinrich Schuchardt
We do not actually test the code. Scanning for Amiga partitions of the sandbox is extremely slow, especially on the partially implemented USB device. For build testing the other sandbox defconfigs are good enough. Signed-off-by: Heinrich Schuchardt --- v2: no change --- configs/sandbox_

[PATCH v2 1/6] test: fix test_extension.py

2024-11-26 Thread Heinrich Schuchardt
test_extension.py assumes that no extension is known at test start. This assumption is wrong because we do not come out of reboot. A prior test may have already hunted for the extension bootdev. Remove the invalid assert. Signed-off-by: Heinrich Schuchardt --- v2: no change --- test/py/

[PATCH] arm: mach-k3: fix typo in devstat macro name

2024-11-26 Thread Prasanth Babu Mantena
Fix spelling mistake in the board init files of j721e and j721s2. s/WKUP_DEVSTAT_MCU_OMLY_MASK/WKUP_DEVSTAT_MCU_ONLY_MASK Signed-off-by: Prasanth Babu Mantena --- arch/arm/mach-k3/include/mach/j721e_hardware.h | 2 +- arch/arm/mach-k3/include/mach/j721s2_hardware.h | 2 +- arch/arm/mach-k3/j72

[PATCH] configs: versal2: Enable OPTEE support

2024-11-26 Thread Venkatesh Yadav Abbarapu
Add OPTEE support for versal2 platform. Signed-off-by: Venkatesh Yadav Abbarapu --- configs/amd_versal2_virt_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configs/amd_versal2_virt_defconfig b/configs/amd_versal2_virt_defconfig index 08e607700c..b4aebf3e9f 100644 --- a/configs

RE: [PATCH] mtd: spi-nor: Enable mt35xu512aba_fixups for all mt35xx flashes

2024-11-26 Thread Abbarapu, Venkatesh
Hi Prasanth, > -Original Message- > From: Prasanth Mantena > Sent: Tuesday, November 26, 2024 10:38 AM > To: Abbarapu, Venkatesh > Cc: u-boot@lists.denx.de; j-humphr...@ti.com; Simek, Michal > ; ja...@amarulasolutions.com; vigne...@ti.com; u- > kum...@ti.com; tr...@konsulko.com; sean...@

Re: [PATCH v3 1/4] debug_uart: Replace debug functions with dummies if CONFIG_DEBUG_UART is not set

2024-11-26 Thread Kever Yang
Hi Lukasz,     I got a new error base on patch [1], see full log here [2]. +/binman/rom/intel-mrc (mrc.bin): +In file included from lib/efi/efi_stub.c:12: +include/debug_uart.h:205:9: error: stray '#' in program +  205 | #warning "DEBUG_UART not defined!" +  | ^ +lib/efi/efi_

Re: [PATCH v5 08/14] efi_loader: net: set EFI bootdevice device path to HTTP when loaded from wget

2024-11-26 Thread Adriano Córdova
El lun, 25 nov 2024 a las 12:40, Heinrich Schuchardt () escribió: > On 25.11.24 01:58, Adriano Cordova wrote: > > Set the device path of the efi boot device to an HTTP device path > > (as formed by efi_dp_from_http) when the next boot stage is loaded > > using wget (i.e., when wget is used with wg

[PATCH] bios_emulator: fix garbled printing of disassembled SET* instructions

2024-11-26 Thread Yuri Zaporozhets
When DEBUG_DECODE_F is enabled in bios_emulator, the printing of SET{O,NO,B,NB,Z,NZ,BE,NBE,S,NS,P,TP,L,NL,LE,NLE} instructions is not followed by newline and is, therefore, immediately followed by the printed address of a new instruction. This garbles the output and makes it very difficult to read.

[PATCH] bios_emulator: fix garbled printing of disassembled BSF instruction

2024-11-26 Thread Yuri Zaporozhets
When DEBUG_DECODE_F is enabled in bios_emulator, the printing of BSF instructions is garbled because the '\n' symbol is used instead of the correct '\t'. Fix that. Signed-off-by: Yuri Zaporozhets --- drivers/bios_emulator/x86emu/ops2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) d

Re: [PATCH v2 2/2] fdt: Swap the signature for board_fdt_blob_setup()

2024-11-26 Thread Patrice CHOTARD
On 11/2/24 18:49, Simon Glass wrote: > This returns a devicetree and updates a parameter with an error code. > Swap it, since this fits better with the way U-Boot normally works. It > also (more easily) allows leaving the existing pointer unchanged. > > No yaks were harmed in this change, but t

Re: [PATCH] Makefile: avoid non-standard sed expressions

2024-11-26 Thread Marek Vasut
On 11/26/24 8:12 PM, Mark Kettenis wrote: The '?' that is used in the sed expression that determines MK_ARCH is part of the extended regular expression syntax, but the default behaviour of sed as specified by POSIX is to use only basic regular expression syntax. Use the equivalent '\{0,1\}' inst

[PATCH] arm: kirkwood: Enable bootstd and other modernization for OpenRD boards

2024-11-26 Thread Tony Dinh
Enable bootstd for OpenRD boards Update defconfigs to the latest u-boot requirements Remove JFFS2 support. See JFFS2 Vulnerability[1]. Move default envs to text-base environment [1] https://lore.kernel.org/u-boot/20241114233005.GN3600562@bill-the-cat/T/#m2fc25da1d2c019bc3cd8676991fdd64b8a21aa9b

Re: [GIT PULL] Please pull u-boot-imx-next-20241126

2024-11-26 Thread Tom Rini
0600) > > are available in the Git repository at: > > https://gitlab.denx.de/u-boot/custodians/u-boot-imx.git > tags/u-boot-imx-next-20241126 > > for you to fetch changes up to a488d9f26e37bcb5776bc8a2dadb708f1ac9cfdc: > > board: phytec: phycore-imx8mm: Add EEP

Re: [GIT PULL] Please pull u-boot-dfu-next-20241126

2024-11-26 Thread Tom Rini
0f9b2a12e3fc6339d6af5a154bded769d911: > > Merge tag 'v2025.01-rc3' into next (2024-11-25 17:34:08 -0600) > > are available in the Git repository at: > > https://source.denx.de/u-boot/custodians/u-boot-dfu.git > tags/u-boot-dfu-next-20241126 > > for y

[PATCH 1/1] efi_loader: avoid writing message in Exit() boot service

2024-11-26 Thread Heinrich Schuchardt
We should not write messages in UEFI API functions. This may lead to incorrect screen layout in UEFI application. For single statements after if clause we don't need braces. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_boottime.c | 7 +++ 1 file changed, 3 insertions(+), 4 dele

Re: [PATCH 05/13] efi_loader: Move some memory-function comments to header

2024-11-26 Thread Tom Rini
On Tue, Nov 26, 2024 at 11:50:40PM +0100, Heinrich Schuchardt wrote: > On 11/26/24 23:33, Tom Rini wrote: > > On Tue, Nov 26, 2024 at 01:04:25PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Tue, 26 Nov 2024 at 08:55, Tom Rini wrote: > > > > > > > > On Tue, Nov 26, 2024 at 08:37:33AM -0

Re: [PATCH 05/13] efi_loader: Move some memory-function comments to header

2024-11-26 Thread Heinrich Schuchardt
On 11/26/24 23:33, Tom Rini wrote: On Tue, Nov 26, 2024 at 01:04:25PM -0700, Simon Glass wrote: Hi Tom, On Tue, 26 Nov 2024 at 08:55, Tom Rini wrote: On Tue, Nov 26, 2024 at 08:37:33AM -0700, Simon Glass wrote: Hi Heinrich, On Tue, 26 Nov 2024 at 02:35, Heinrich Schuchardt wrote: On 25.

Re: [PATCH 05/13] efi_loader: Move some memory-function comments to header

2024-11-26 Thread Tom Rini
On Tue, Nov 26, 2024 at 01:04:25PM -0700, Simon Glass wrote: > Hi Tom, > > On Tue, 26 Nov 2024 at 08:55, Tom Rini wrote: > > > > On Tue, Nov 26, 2024 at 08:37:33AM -0700, Simon Glass wrote: > > > Hi Heinrich, > > > > > > On Tue, 26 Nov 2024 at 02:35, Heinrich Schuchardt > > > wrote: > > > > > >

Re: Odd error with cn9130, asix88179 and xhci

2024-11-26 Thread Chris Packham
On Mon, Nov 25, 2024 at 1:09 PM Chris Packham wrote: > > On Sat, Nov 23, 2024 at 3:40 PM Tom Rini wrote: > > > > On Wed, Nov 20, 2024 at 11:29:43AM +1300, Chris Packham wrote: > > > Hi U-Boot, > > > > > > We've hit a weird problem at $dayjob with a board using the Marvell > > > CN9130 SoC and usi

Re: [PATCH] nand: Add a watch command

2024-11-26 Thread Michael Nazzareno Trimarchi
Hi Miquel On Tue, Nov 28, 2023 at 11:56 AM Miquel Raynal wrote: > > This is a debug command to monitor the retention state of the data on > the array. The command needs a duplication of the mtd_read_oob() > function to actually return the maximum number of bitflips encountered > while reading the

Re: [PATCH 05/13] efi_loader: Move some memory-function comments to header

2024-11-26 Thread Simon Glass
Hi Tom, On Tue, 26 Nov 2024 at 08:55, Tom Rini wrote: > > On Tue, Nov 26, 2024 at 08:37:33AM -0700, Simon Glass wrote: > > Hi Heinrich, > > > > On Tue, 26 Nov 2024 at 02:35, Heinrich Schuchardt > > wrote: > > > > > > On 25.11.24 21:44, Simon Glass wrote: > > > > Exported functions should be doc

Re: [PATCH 00/20] Support for the RK3576

2024-11-26 Thread Detlev Casanova
Hi Heiko On Thursday, 21 November 2024 09:27:11 EST Heiko Stuebner wrote: > This adds support for the RK3576 SoC from Rockchip. > > Currently supported (and tested) features are accessing and reading from > sdhci and sdmmc devices as well as pxe-booting via the network interface. > > As can be s

[PATCH] Makefile: avoid non-standard sed expressions

2024-11-26 Thread Mark Kettenis
The '?' that is used in the sed expression that determines MK_ARCH is part of the extended regular expression syntax, but the default behaviour of sed as specified by POSIX is to use only basic regular expression syntax. Use the equivalent '\{0,1\}' instead as suggested by the OpenBSD re_format(7)

Re: [PATCH 16/20] rockchip: otp: Add support for RK3576

2024-11-26 Thread Quentin Schulz
Hi Heiko, On 11/21/24 3:27 PM, Heiko Stuebner wrote: Add support for RK3588 compatible. RK3576? Cheers, Quentin

Re: [PATCH 11/20] arm: rockchip: Add RK3576 arch core support

2024-11-26 Thread Quentin Schulz
Hi Heiko, On 11/21/24 3:27 PM, Heiko Stuebner wrote: From: Xuhui Lin The Rockchip RK3588 is a ARM-based SoC with quad-core Cortex-A72 Probably rather RK3576 :) and quad-core Cortex-A53 including 6TOPS NPU, Mali-G52 MC3, HDMI Out, DP, eDP, MIPI DSI, MIPI CSI2, LPDDR4/4X/5, eMMC5.1, SD3.0/MM

Re: [PATCH 10/20] arm: rockchip: add RK3576-specific syscon ids

2024-11-26 Thread Quentin Schulz
Hi Heiko, On 11/21/24 3:27 PM, Heiko Stuebner wrote: From: Detlev Casanova The rk3576 defines some more different syscons, namely the IOC-syscon holding io-controller registers and sdgmac holding settings for the gmac controller. Signed-off-by: Detlev Casanova Signed-off-by: Heiko Stuebner

Re: [GIT PULL] Please pull u-boot-dfu-20241126

2024-11-26 Thread Tom Rini
DMA buffer" > (2024-11-18 08:24:06 -0600) > > are available in the Git repository at: > > https://source.denx.de/u-boot/custodians/u-boot-dfu.git > tags/u-boot-dfu-20241126 > > for you to fetch changes up to 35d967f5a8219adc47628247a98c302b1870313e: > > usb: ci

Re: [PATCH 09/20] rockchip: mkimage: Add rk3576 support

2024-11-26 Thread Quentin Schulz
Hi Heiko, On 11/21/24 3:27 PM, Heiko Stuebner wrote: From: Xuhui Lin Add support for rk3576 package header in mkimage tool. Signed-off-by: Heiko Stuebner --- tools/rkcommon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/rkcommon.c b/tools/rkcommon.c index 3e52236b15a..d89c7d3

Re: Please pull u-boot-marvell/master

2024-11-26 Thread Tom Rini
On Tue, Nov 26, 2024 at 01:24:13PM +0100, Stefan Roese wrote: > Hi Tom, > > please pull the next batch of Marvell Marvell related patches: > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

RE: [PATCH V3 2/3] arm64: imx8mp: Read values from M24C32-D write-lockable page on DHCOM i.MX8MP

2024-11-26 Thread Christoph Niedermaier
From: Marek Vasut Sent: Sunday, November 24, 2024 10:02 PM > On 11/21/24 6:21 PM, Christoph Niedermaier wrote: > > [...] > >> +struct eeprom_id_page { >> +u8 id[3]; /* Identifier 'D', 'H', 'E' - 'D' is at index 0 >> */ >> +u8 version;/* 0x10 -- Version 1.0 */

[PATCH v2 2/2] net-lwip: zero terminate string with headers in wget_lwip_fill_info()

2024-11-26 Thread Adriano Cordova
This patch comes as a companion to the same patch but for the legacy net stack. Commit 1327c2a8d6 ("net/lwip: wget: integrate struct wget_info into wget code") introduced function wget_fill_info() which retrieves the headers from the HTTP server response. As we want to parse the

[PATCH v2 1/2] net: zero terminate string with headers in wget_fill_info()

2024-11-26 Thread Adriano Cordova
From: Heinrich Schuchardt Commit 2dd076a9c1b4 ("net: wget: integrate struct wget_info into legacy wget code") introduced function wget_fill_info() which retrieves the headers from the HTTP server response. As we want to parse the string in later patches we need to ensure that it is NUL terminated

Re: [PATCH v2 4/6] net: eth_bootdev_hunt() must not try to boot

2024-11-26 Thread Heinrich Schuchardt
On 26.11.24 16:38, Simon Glass wrote: Hi Heinrich, On Tue, 26 Nov 2024 at 00:42, Heinrich Schuchardt wrote: On 11/26/24 01:32, Simon Glass wrote: Hi Heinrich, On Sat, 23 Nov 2024 at 14:46, Heinrich Schuchardt wrote: eth_bootdev_hunt() should not execute dhcp_run() as this itself would lo

Re: [PATCH] common/board_f: init malloc earlier

2024-11-26 Thread Caleb Connolly
Hi Simon, On 26/11/2024 16:38, Simon Glass wrote: > Hi Caleb, > > On Tue, 26 Nov 2024 at 05:22, Caleb Connolly > wrote: >> >> Hi Simon, >> >> On 26/11/2024 01:32, Simon Glass wrote: >>> Hi Caleb, >>> >>> On Sun, 24 Nov 2024 at 11:38, Caleb Connolly >>> wrote: Currently the early mal

Re: [PATCH 08/20] rockchip: sdram: honor CFG_SYS_SDRAM_BASE when defining ram regions

2024-11-26 Thread Quentin Schulz
Hi Heiko, On 11/21/24 3:27 PM, Heiko Stuebner wrote: Currently the sdram code for arm64 expects CFG_SYS_SDRAM_BASE to be 0. The ram being in front and the device-area behind it. The upcoming RK3576 uses a different layout, with the device area in front the ram, which then also extends past the

Re: [PATCH 00/13] efi: Tidy up confusion between pointers and addresses

2024-11-26 Thread Tom Rini
On Tue, Nov 26, 2024 at 08:39:05AM -0700, Simon Glass wrote: > Hi Heinrich, > > On Tue, 26 Nov 2024 at 02:10, Heinrich Schuchardt wrote: > > > > On 25.11.24 21:44, Simon Glass wrote: > > > The EFI-loader implementation converts things back and forth between > > > addresses and pointers, with not

Re: [PATCH 1/1] net: zero terminate string with headers in wget_fill_info()

2024-11-26 Thread Adriano Córdova
El mar, 26 nov 2024 a las 12:35, Jerome Forissier (< jerome.foriss...@linaro.org>) escribió: > > > On 11/25/24 18:16, Heinrich Schuchardt wrote: > > Commit 2dd076a9c1b4 ("net: wget: integrate struct wget_info into legacy > > wget code") introduced function wget_fill_info() which retrieves the > >

Re: [PATCH 05/13] efi_loader: Move some memory-function comments to header

2024-11-26 Thread Tom Rini
On Tue, Nov 26, 2024 at 08:37:33AM -0700, Simon Glass wrote: > Hi Heinrich, > > On Tue, 26 Nov 2024 at 02:35, Heinrich Schuchardt wrote: > > > > On 25.11.24 21:44, Simon Glass wrote: > > > Exported functions should be documented in the header file, not the > > > implementation. We tend to make su

Re: [PATCH 02/13] efi_loader: Convert efi_get_memory_map() to return pointers

2024-11-26 Thread Simon Glass
Hi Heinrich, On Tue, 26 Nov 2024 at 02:27, Heinrich Schuchardt wrote: > > On 25.11.24 21:44, Simon Glass wrote: > > This function should return pointers, not addresses. Add the conversion. > > > > Signed-off-by: Simon Glass > > --- > > > > lib/efi_loader/efi_memory.c | 5 + > > 1 file cha

Re: [PATCH 00/13] efi: Tidy up confusion between pointers and addresses

2024-11-26 Thread Simon Glass
Hi Ilias, On Tue, 26 Nov 2024 at 01:13, Ilias Apalodimas wrote: > > Hi Simon > > Apart from the comments on the other patches, the SCT memory tests > crash with this series. Please run it locally before sending a v2. I did briefly get it running on my laptop, but not for x86_64. I understand fro

Re: [PATCH 07/13] efi_loader: Make more use of ulong

2024-11-26 Thread Simon Glass
Hi Heinrich, On Tue, 26 Nov 2024 at 03:13, Heinrich Schuchardt wrote: > > On 26.11.24 09:00, Ilias Apalodimas wrote: > > Hi Simon, > > > > > > On Mon, 25 Nov 2024 at 22:45, Simon Glass wrote: > >> > >> One of the confusing parts of the EFI loader is that it uses u64 for > >> addresses, whereas t

Re: [PATCH 07/13] efi_loader: Make more use of ulong

2024-11-26 Thread Simon Glass
Hi Ilias, On Tue, 26 Nov 2024 at 01:01, Ilias Apalodimas wrote: > > Hi Simon, > > > On Mon, 25 Nov 2024 at 22:45, Simon Glass wrote: > > > > One of the confusing parts of the EFI loader is that it uses u64 for > > addresses, whereas the rest of U-Boot typically uses ulong. > > > > There is a cas

Re: [PATCH] Revert "efi_memory: do not add U-Boot memory to the memory map"

2024-11-26 Thread Simon Glass
Hi Sughosh, On Thu, 21 Nov 2024 at 00:53, Sughosh Ganu wrote: > > On Tue, 12 Nov 2024 at 18:48, Simon Glass wrote: > > > > A bisect of Ubuntu 2022.04 boot-failure on qemu-x86_64 resulted in this > > patch. I am not sure how to investigate it. > > > > The boot hangs at some point during booting o

Re: [PATCH 08/13] efi_loader: Tidy up use of addresses

2024-11-26 Thread Simon Glass
Hi Heinrich, On Tue, 26 Nov 2024 at 03:22, Heinrich Schuchardt wrote: > > On 25.11.24 21:44, Simon Glass wrote: > > The EFI loader's memory implementation is quite confusing. The EFI spec > > requires that addresses are used in the calls to allocate_pages(), etc. > > This is unavoidable. > > > >

Re: [PATCH 1/2] test: add command to 'Lab failure' timeout message

2024-11-26 Thread Simon Glass
On Sat, 23 Nov 2024 at 14:29, Heinrich Schuchardt wrote: > > When a timeout occurs while executing a command a 'Lab failure' message is > written and testing is stopped. The user is left in the dark about the > failure cause. > > ! _pytest.outcomes.Exit: Lab failure: Marking connection bad - n

Re: [PATCH v2 4/6] net: eth_bootdev_hunt() must not try to boot

2024-11-26 Thread Simon Glass
Hi Heinrich, On Tue, 26 Nov 2024 at 00:42, Heinrich Schuchardt wrote: > > On 11/26/24 01:32, Simon Glass wrote: > > Hi Heinrich, > > > > On Sat, 23 Nov 2024 at 14:46, Heinrich Schuchardt > > wrote: > >> > >> eth_bootdev_hunt() should not execute dhcp_run() as this itself would load > >> a file a

Re: [PATCH 00/13] efi: Tidy up confusion between pointers and addresses

2024-11-26 Thread Simon Glass
Hi Heinrich, On Tue, 26 Nov 2024 at 02:10, Heinrich Schuchardt wrote: > > On 25.11.24 21:44, Simon Glass wrote: > > The EFI-loader implementation converts things back and forth between > > addresses and pointers, with not much consistency in how this is done. > > > > Within most of U-Boot a point

Re: [PATCH] common/board_f: init malloc earlier

2024-11-26 Thread Simon Glass
Hi Caleb, On Tue, 26 Nov 2024 at 05:22, Caleb Connolly wrote: > > Hi Simon, > > On 26/11/2024 01:32, Simon Glass wrote: > > Hi Caleb, > > > > On Sun, 24 Nov 2024 at 11:38, Caleb Connolly > > wrote: > >> > >> Currently the early malloc initialisation is done partially in > >> board_init_f_init_r

Re: [PATCH 05/13] efi_loader: Move some memory-function comments to header

2024-11-26 Thread Simon Glass
Hi Heinrich, On Tue, 26 Nov 2024 at 02:35, Heinrich Schuchardt wrote: > > On 25.11.24 21:44, Simon Glass wrote: > > Exported functions should be documented in the header file, not the > > implementation. We tend to make such updates on a piecemeal basis to > > avoid a 'flag day'. Move some commen

Re: [PATCH 06/13] efi_loader: Use the enum for memory type

2024-11-26 Thread Simon Glass
Hi Heinrich, On Tue, 26 Nov 2024 at 02:44, Heinrich Schuchardt wrote: > > On 25.11.24 21:44, Simon Glass wrote: > > Rather than an integer, it is better to use the enum provided, when > > referring to an EFI memory-type. Update existing uses. > > The C standard provides no definition of the size

Re: [PATCH 1/1] net: zero terminate string with headers in wget_fill_info()

2024-11-26 Thread Jerome Forissier
On 11/25/24 18:16, Heinrich Schuchardt wrote: > Commit 2dd076a9c1b4 ("net: wget: integrate struct wget_info into legacy > wget code") introduced function wget_fill_info() which retrieves the > headers from the HTTP server response. As we want to parse the string in > later patches we need to ens

Re: [PATCH v6 04/11] riscv: dts: jh7110: Move common code to the new jh7110-common-u-boot.dtsi

2024-11-26 Thread E Shattow
On Sun, Nov 24, 2024 at 4:33 PM Hal Feng wrote: > > To support JH7110 based boards besides v1.3B, > add a common dtsi and add common code to it. > > Tested-by: E Shattow > Signed-off-by: Hal Feng > --- > arch/riscv/dts/jh7110-common-u-boot.dtsi | 144 ++ > ...10-starfive-vi

Re: [PATCH v6 02/11] riscv: dts: jh7110: Make u-boot device trees adapting to upstream DT

2024-11-26 Thread E Shattow
On Sun, Nov 24, 2024 at 4:33 PM Hal Feng wrote: > > Add u-boot features to the U-Boot device tree. > > Tested-by: E Shattow > Acked-by: Sumit Garg > Signed-off-by: Hal Feng > --- > ...10-starfive-visionfive-2-v1.3b-u-boot.dtsi | 35 --- > arch/riscv/dts/jh7110-u-boot.dtsi

Re: [PATCH v2] net: lwip: dhcp: support arguments for TFTP file download

2024-11-26 Thread Jerome Forissier
Hi Tom, On 11/23/24 03:42, Tom Rini wrote: > On Thu, Nov 14, 2024 at 06:20:07PM +0100, Jerome Forissier wrote: > >> The dhcp command is supposed to have the following syntax as per >> "help dhcp": >> >> dhcp [loadAddress] [[hostIPaddr:]bootfilename] >> >> In other words, any arguments should be

[PATCH] net: lwip: wget: fix legacy syntax

2024-11-26 Thread Jerome Forissier
Commit 356011f7ac25 ("lwip: fix code style issues") has inadvertently broken the support for the legacy syntax: => wget 192.168.0.16:test.bin invalid uri, no file path Invalid URL. Use http(s):// The reason is two calls to strncpy() were replaced by strlcpy() without paying attention to the fa

Re: [PATCH 1/2] rng: msm: add support for newer Qualcomm hwrandom IPs

2024-11-26 Thread Alexey Minnekhanov
25.11.2024 20:12, Neil Armstrong wrote: On recent Qualcomm SoCs, the hardware random generator is initialized and handled by the firmware because shared between different Execution Environments (EE), thus the initialization step should be skipped. Also support the newer "TRNG" found on SM8550 an

Re: [PATCH v6 07/11] configs: visionfive2: Enable MULTI_DTB_FIT for JH7110 based board DT

2024-11-26 Thread E Shattow
On Sun, Nov 24, 2024 at 4:33 PM Hal Feng wrote: > > So JH7110 based boards can select their own DT at runtime. > > Tested-by: E Shattow > Signed-off-by: Hal Feng > --- > configs/starfive_visionfive2_defconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/configs/starfive_visionfive

[PATCH 1/1] cmd/rng: fix long help text

2024-11-26 Thread Heinrich Schuchardt
The number of bytes may only be specified if a device number id provided. Correct the formatting. Signed-off-by: Heinrich Schuchardt --- cmd/rng.c | 4 ++-- doc/usage/cmd/rng.rst | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/cmd/rng.c b/cmd/rng.c index 2fb

Re: [PATCH v6 08/11] riscv: dts: jh7110: Support multiple DTBs in a Fit image

2024-11-26 Thread E Shattow
Hi Hal, this is better than it was before, thank you. On Sun, Nov 24, 2024 at 4:33 PM Hal Feng wrote: > > Support multiple DTBs for JH7110 based boards, so they can > select the correct DT at runtime. > > Tested-by: E Shattow > Signed-off-by: Hal Feng > --- > arch/riscv/dts/jh7110-common-u-boo

Re: [PATCH v2 3/6] configs: xilinx_versal_virt: disable USB_DWC3

2024-11-26 Thread Tom Rini
On Tue, Nov 26, 2024 at 09:05:47AM +0100, Heinrich Schuchardt wrote: > On 11/26/24 08:56, Michal Simek wrote: > > > > > > On 11/25/24 21:09, Heinrich Schuchardt wrote: > > > > > > > > > Michal Simek mailto:michal.si...@amd.com>> > > > schrieb am Mo., 25. Nov. 2024, 19:04: > > > > > > > > > >

Re: [PATCH v2 0/4] Add QOS support for J722S and AM62P

2024-11-26 Thread Devarsh Thakkar
On 26/11/24 12:36, Jayesh Choudhary wrote: > Add QOS support for DSS in TI K3 SoC to route the DSS traffic through > RT queue by setting orderID as 15: > - J722S > - AM62P > > Changelog v1->v2: > - Rebased on the tip of next branch > - Corrected the commit message in patch 2/4 > > v1: >

[GIT PULL] Please pull u-boot-dfu-next-20241126

2024-11-26 Thread Mattijs Korpershoek
: https://source.denx.de/u-boot/custodians/u-boot-dfu.git tags/u-boot-dfu-next-20241126 for you to fetch changes up to abadcda24b100b8eb0f138085cca6595518cec85: bootstd: android: don't read whole partition sizes (2024-11-26 10:04:40 +0100) ---

Re: [PATCH v6 05/11] riscv: dts: jh7110: Add u-boot device tree for JH7110 based boards

2024-11-26 Thread E Shattow
On Sun, Nov 24, 2024 at 4:33 PM Hal Feng wrote: > > To support the other JH7110 based boards, add u-boot > device tree for them. > > Tested-by: E Shattow > Reviewed-by: E Shattow > Cc: Heinrich Schuchardt > Cc: H Bell > Signed-off-by: Hal Feng > --- > arch/riscv/dts/jh7110-milkv-mars-u-boot.

[GIT PULL] Please pull u-boot-dfu-20241126

2024-11-26 Thread Mattijs Korpershoek
ng changes since commit 0e6432e19f9c812b4986ca7fd8e6db9fd2c199d3: Merge patch series "Fix boot failure due to misaligned DMA buffer" (2024-11-18 08:24:06 -0600) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-dfu.git tags/u-boot-dfu-202411

Re: [PATCH v4 00/20] imx8qxp: siemens board: updates / sync with mainline

2024-11-26 Thread Fabio Estevam
On Sat, Nov 23, 2024 at 1:53 PM Heiko Schocher wrote: > > Updating the imx8qxp based siemens board. The current > state of the siemens imx8qxp board is in an old not > really working state. > > This series brings mainline back working on the siemens > deneb board, the guedi board is dropped as not

[PATCH 2/2] drivers: serial: serial_omap: Fix TI OMAP UART U-Boot driver to support higher baudrates

2024-11-26 Thread Gokul Praveen
Move to OMAP specific implementation of certain ops functions as the UART prints on the serial console fail for baudrates greater than 460800. The MDR1 register is responsible for determining the speed mode at which the UART should operate for OMAP specific devices. The baud divisor is used to set

[PATCH 1/2] serial: ns16550: Increase scope of ops functions

2024-11-26 Thread Gokul Praveen
Increase scope of ops functions and do some clean up for usage in device -specific UART drivers. Remove the static functionality of ops functions and migrate certain macros to header file for usage in device-specific drivers. Signed-off-by: Gokul Praveen --- drivers/serial/ns16550.c | 25 ++

[PATCH 0/2] UART support for higher baudrate

2024-11-26 Thread Gokul Praveen
The OMAP specific UART driver is changed from a generic implementation of certain ops functions to an OMAP specific implementation of it to add support for higher baudrates for OMAP devices. Hence to support the above change, static functionality of ops functions in generic ns16550 UART U-Boot dri

Please pull u-boot-marvell/master

2024-11-26 Thread Stefan Roese
Hi Tom, please pull the next batch of Marvell Marvell related patches: - mvebu: Disable JFFS2 support for Kirkwood and Armada XP boards (Tony) - kirkwood: Enable bootstd for Sheevaplug board (Tony) - mvebu: Add Allied Telesis x250

Re: [PATCH] common/board_f: init malloc earlier

2024-11-26 Thread Caleb Connolly
Hi Simon, On 26/11/2024 01:32, Simon Glass wrote: > Hi Caleb, > > On Sun, 24 Nov 2024 at 11:38, Caleb Connolly > wrote: >> >> Currently the early malloc initialisation is done partially in >> board_init_f_init_reserve() (on arm64 at least), which configures >> gd->malloc_base. But it isn't actu

[PATCH 0/2] AM62A DWC3: Add support for USB DFU boot in OTG mode

2024-11-26 Thread Siddharth Vadapalli
Hello, This series adds support for USB DFU boot on TI's AM62A SoC which has two instances of DWC3 USB Controllers namely USB0 and USB1. The USB0 instance of the USB Controller supports USB DFU boot: ROM => tiboot3.bin => tispl.bin => u-boot.img USB DFU Boot requires the USB Controller to be conf

[PATCH 1/2] usb: dwc3-generic: set "mode" based on caller of dwc3_generic_probe()

2024-11-26 Thread Siddharth Vadapalli
There are only two callers of "dwc3_generic_probe()", namely: 1. dwc3_generic_peripheral_probe() 2. dwc3_generic_host_probe() Currently, the "mode" is set based on the device-tree node of the platform device. Also, the DWC3 core doesn't support updating the "mode" dynamically at runtime if it is se

[PATCH 2/2] board: ti: am62ax: env: include environment for DFU

2024-11-26 Thread Siddharth Vadapalli
Include the TI K3 DFU environment to support DFU Boot and DFU Flash. Signed-off-by: Siddharth Vadapalli --- board/ti/am62ax/am62ax.env | 1 + 1 file changed, 1 insertion(+) diff --git a/board/ti/am62ax/am62ax.env b/board/ti/am62ax/am62ax.env index 97122fb57ba..96d9e1e2797 100644 --- a/board/ti/

Re: [PATCH] board: phytec: phycore-imx8mm: Add EEPROM detection initialisation

2024-11-26 Thread Fabio Estevam
On Fri, Nov 22, 2024 at 11:06 AM Yunus Bas wrote: > > Add EEPROM detection initialisation for phyCORE-i.MX8MM. > > Signed-off-by: Yunus Bas Applied for -next, thanks.

Re: [PATCH v4 0/3] Add support for all variants of the phyCORE-i.MX93 SOM

2024-11-26 Thread Fabio Estevam
On Wed, Nov 20, 2024 at 1:32 PM Christoph Stoidner wrote: > > The phyCORE-i.MX 93 is available in various variants (e.g. different ram > sizes, eMMC HS400 yes/no). It's eeprom contains information which features > the existing module supports. > > Extend the existing board-code to support all the

[GIT PULL] Please pull u-boot-imx-next-20241126

2024-11-26 Thread Fabio Estevam
ot-imx.git tags/u-boot-imx-next-20241126 for you to fetch changes up to a488d9f26e37bcb5776bc8a2dadb708f1ac9cfdc: board: phytec: phycore-imx8mm: Add EEPROM detection initialisation (2024-11-25 23:08:24 -0300) u-boot-imx-next-20241126 -- CI: https://source.denx.de/u-boot/

Re: [PATCH v2 3/6] configs: xilinx_versal_virt: disable USB_DWC3

2024-11-26 Thread Michal Simek
On 11/26/24 09:34, Heinrich Schuchardt wrote: On 11/26/24 08:57, Michal Simek wrote: On 11/25/24 19:48, Tom Rini wrote: On Mon, Nov 25, 2024 at 07:44:15PM +0100, Michal Simek wrote: On 11/25/24 19:08, Tom Rini wrote: On Mon, Nov 25, 2024 at 07:03:41PM +0100, Michal Simek wrote: On 1

Re: [PATCH v3] toradex: tdx-cfg-block: rework modules pid4 handling

2024-11-26 Thread Francesco Dolcini
+Fabio On Mon, Nov 25, 2024 at 05:49:10PM +, Vitor Soares wrote: > From: Vitor Soares > > The module pid4 currently corresponds to the index of the toradex_module > array. If a new pid4 is introduced that does not follow the sequence of > the previous entries, it will create a gap in the arr

Re: [PATCH 0/2] configs: JH7110: enable EFI_LOADER_BOUNCE_BUFFER

2024-11-26 Thread E Shattow
On Mon, Nov 25, 2024 at 10:32 PM E Shattow wrote: > > On Fri, Nov 22, 2024 at 6:33 AM Loic Devulder wrote: > > > > Hi guys! > > > > I played with latest openSUSE TW image [1] for VisionFive2 and I also had > > an issue but not exactly > > the same Andreas had. Booting the OS from an sdcard gave

Re: [PATCH 08/13] efi_loader: Tidy up use of addresses

2024-11-26 Thread Heinrich Schuchardt
On 25.11.24 21:44, Simon Glass wrote: The EFI loader's memory implementation is quite confusing. The EFI spec requires that addresses are used in the calls to allocate_pages(), etc. This is unavoidable. This usage then filters down to various functions within the implementation. This is unfortun

Re: [PATCH 07/13] efi_loader: Make more use of ulong

2024-11-26 Thread Heinrich Schuchardt
On 26.11.24 09:00, Ilias Apalodimas wrote: Hi Simon, On Mon, 25 Nov 2024 at 22:45, Simon Glass wrote: One of the confusing parts of the EFI loader is that it uses u64 for addresses, whereas the rest of U-Boot typically uses ulong. You are confusing sandbox virtual addresses (phys_addr_t) w

Re: [PATCH 0/6] ufs: core: initial cleanup and defines sync with Linux v6.12

2024-11-26 Thread Neil Armstrong
On 26/11/2024 07:43, Love Kumar wrote: Hi, On 20/11/24 2:52 pm, Neil Armstrong wrote: This serie fixes the build and checkpatch warnings, and does a split of the ufs.h into a separate ufshci.h which helps syndhronizing the defines from Linux v6.12. No functional changes intended, tests on hard

Re: [PATCH 06/13] efi_loader: Use the enum for memory type

2024-11-26 Thread Heinrich Schuchardt
On 25.11.24 21:44, Simon Glass wrote: Rather than an integer, it is better to use the enum provided, when referring to an EFI memory-type. Update existing uses. The C standard provides no definition of the size of the integer used to implement enums. It could use u8, u16, u32, or u64. As EFI a

Re: [PATCH 2/4] fastboot: blk: add block device flashing configuration

2024-11-26 Thread Mattijs Korpershoek
On lun., nov. 25, 2024 at 23:41, Dmitrii Merkurev wrote: > Hey Neil. > > Will do it by the end of the year. Only tested it with a virtio-block > though. > > On Thu, Nov 21, 2024 at 12:44 PM wrote: > >> Hi Dmitrii, >> >> So you plan to send a new version of this patchset ? >> >> It would be very

Re: [PATCH] board: theobroma-systems: Update TF-A setup steps for RK3588 boards

2024-11-26 Thread Quentin Schulz
Hi Daniel, On 11/26/24 9:27 AM, Daniel Semkowicz wrote: ddrbin_tool interface has been changed. Additional chip_name argument is now required to modify ddr binary file. Update documentation to be consistent with the new interface. Update BL31 and ROCKCHIP_TPL file paths to match current version

Re: [PATCH 05/13] efi_loader: Move some memory-function comments to header

2024-11-26 Thread Heinrich Schuchardt
On 25.11.24 21:44, Simon Glass wrote: Exported functions should be documented in the header file, not the implementation. We tend to make such updates on a piecemeal basis to avoid a 'flag day'. Move some comments related to memory allocation to follow the convention. Signed-off-by: Simon Glass

Re: [PATCH 04/13] efi_loader: Update startimage_exit self-test to check error

2024-11-26 Thread Heinrich Schuchardt
On 26.11.24 07:29, Ilias Apalodimas wrote: On Mon, 25 Nov 2024 at 22:45, Simon Glass wrote: Check for an error returned from the decompress() function, just in case. Signed-off-by: Simon Glass --- lib/efi_selftest/efi_selftest_startimage_exit.c | 6 -- 1 file changed, 4 insertions(+)

Re: [PATCH 03/13] efi_loader: Show the resulting memory address from an alloc

2024-11-26 Thread Heinrich Schuchardt
On 25.11.24 21:44, Simon Glass wrote: Update efi_allocate_pool_ext() to log the pointer returned from this call, which can be helpful when debugging. Signed-off-by: Simon Glass --- lib/efi_loader/efi_boottime.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/efi_loader/efi_bootti

Re: [PATCH 02/13] efi_loader: Convert efi_get_memory_map() to return pointers

2024-11-26 Thread Heinrich Schuchardt
On 25.11.24 21:44, Simon Glass wrote: This function should return pointers, not addresses. Add the conversion. Signed-off-by: Simon Glass --- lib/efi_loader/efi_memory.c | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c index

Re: [PATCH 01/13] efi: Define fields in struct efi_mem_desc

2024-11-26 Thread Heinrich Schuchardt
On 25.11.24 21:44, Simon Glass wrote: There is quite a bit of confusion in the EFI code as to whether a field contains an address or a pointer. As a first step towards resolving this, document the memory-descriptor struct, indicating that it holds addresses, not pointers. Signed-off-by: Simon Gl

Re: [PATCH] drivers: fastboot: Enable flashing support for UFS

2024-11-26 Thread Mattijs Korpershoek
Hi Varadarajan, Thank you for the patch. On mar., nov. 26, 2024 at 10:46, Varadarajan Narayanan wrote: > On Mon, Nov 25, 2024 at 06:59:40PM +0100, Caleb Connolly wrote: >> Hi Varadarajan, >> >> On 25/11/2024 12:03, Varadarajan Narayanan wrote: >> > MMC and UFS seem to execute very similar step

Re: [PATCH 00/13] efi: Tidy up confusion between pointers and addresses

2024-11-26 Thread Heinrich Schuchardt
On 25.11.24 21:44, Simon Glass wrote: The EFI-loader implementation converts things back and forth between addresses and pointers, with not much consistency in how this is done. Within most of U-Boot a pointer is a void * and an address is a ulong No. It is phys_addr_t that was introduced to h

  1   2   >