[PATCH v2] sunxi: defconfig: Add pstore support for pinephone

2024-11-05 Thread Andrey Skvortsov
pstore will allow users to catch kernel crashes and report them to developers. Modern (Android) phones have pstore usually enabled to get information about kernel crash, since it's the simplest way to get kernel backtrace on mobile device without serial console. Usually it's enabled by default in d

Re: [PATCH 3/4] lmb: Add basic io_lmb functionality

2024-11-05 Thread Janne Grunau
On Wed, Nov 06, 2024 at 12:48:45AM +0530, Sughosh Ganu wrote: > On Fri, 1 Nov 2024 at 15:47, Janne Grunau wrote: > > > > These functions can be used with struct lmb pointers and will be used to > > manage IOVA space in the apple_dart iommu driver. This restores part of > > the pointer base struct

Re: [PATCH 0/4] Fix IOVA allocation in Apple dart iommu after global LMB mem map changes

2024-11-05 Thread Janne Grunau
On Wed, Nov 06, 2024 at 12:43:01AM +0530, Sughosh Ganu wrote: > On Sun, 3 Nov 2024 at 23:06, Janne Grunau wrote: > > > > On Sun, Nov 03, 2024 at 07:53:36PM +0530, Sughosh Ganu wrote: > > > On Sat, 2 Nov 2024 at 16:00, Mark Kettenis > > > wrote: > > > > > > > > > From: Sughosh Ganu > > > > > Dat

Re: [PATCH 2/4] arm: mach-k3: am62p: Add QoS support for DSS

2024-11-05 Thread Jayesh Choudhary
Hello All, On 06/11/24 12:09, Jayesh Choudhary wrote: Enable Quality of Service (QoS) blocks for Display SubSystem (DSS), by servicing the DSS - DDR traffic from the Real-Time (RT) queue. This is done by setting the DSS DMA orderID to greater than 7. The C7x and VPAC can overwhelm the DSS's acc

[PATCH 3/4] configs: j722s_evm_r5_defconfig: Enable CONFIG_K3_QOS

2024-11-05 Thread Jayesh Choudhary
Enable CONFIG_K3_QOS to set QoS registers in R5 boot stage. Signed-off-by: Jayesh Choudhary --- configs/j722s_evm_r5_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/j722s_evm_r5_defconfig b/configs/j722s_evm_r5_defconfig index e574be9e19..d119e46ff1 100644 --- a/configs/j72

[PATCH 4/4] configs: am62p_evm_r5_defconfig: Enable CONFIG_K3_QOS

2024-11-05 Thread Jayesh Choudhary
Enable CONFIG_K3_QOS to set QoS registers in R5 boot stage. Signed-off-by: Jayesh Choudhary --- configs/am62px_evm_r5_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/am62px_evm_r5_defconfig b/configs/am62px_evm_r5_defconfig index 4f7be44cfb..edff75de74 100644 --- a/configs/

[PATCH 0/4] Add QOS support for J722S and AM62P

2024-11-05 Thread Jayesh Choudhary
Add QOS support for DSS in TI K3 SoC to route the DSS traffic through RT queue by setting orderID as 15: - J722S - AM62P Jayesh Choudhary (4): arm: mach-k3: j722s: Add QoS support for DSS arm: mach-k3: am62p: Add QoS support for DSS configs: j722s_evm_r5_defconfig: Enable CONFIG_K3_QOS con

[PATCH 2/4] arm: mach-k3: am62p: Add QoS support for DSS

2024-11-05 Thread Jayesh Choudhary
Enable Quality of Service (QoS) blocks for Display SubSystem (DSS), by servicing the DSS - DDR traffic from the Real-Time (RT) queue. This is done by setting the DSS DMA orderID to greater than 7. The C7x and VPAC can overwhelm the DSS's access to the DDR because of their higher frequency DDR acce

[PATCH 1/4] arm: mach-k3: j722s: Add QoS support for DSS

2024-11-05 Thread Jayesh Choudhary
Enable Quality of Service (QoS) blocks for Display SubSystem (DSS), by servicing the DSS - DDR traffic from the Real-Time (RT) queue. This is done by setting the DSS DMA orderID to greater than 7. The C7x and VPAC can overwhelm the DSS's access to the DDR because of their higher frequency DDR acce

Re: [u-boot PATCH] fs: btrfs: hide 'Cannot lookup file' errors on 'load'

2024-11-05 Thread Qu Wenruo
在 2024/11/6 11:59, Dominique Martinet 写道: Running commands such as 'load mmc 2:1 $addr $path' when path does not exists historically do not print any error on filesystems such as ext4 or fat. Changing the root filesystem to btrfs would make existing boot script print 'Cannot lookup file xxx' e

Re: [PATCH] libfdt: Fix build with swig 4.3.0

2024-11-05 Thread David Gibson
On Thu, Oct 31, 2024 at 07:36:15AM -0500, Rob Herring wrote: > On Tue, Oct 29, 2024 at 8:10 PM David Gibson > wrote: > > > > On Tue, Oct 29, 2024 at 08:52:52PM +0800, Xi Ruoyao wrote: > > > On Sat, 2024-10-26 at 12:34 +, Rudi Heitbaum wrote: > > > > Call SWIG_AppendOutput instead of SWIG_Pytho

Re: [PATCH v3 13/13] board: starfive: spl: Support multiple DTBs for JH7110 based boards

2024-11-05 Thread Hal Feng
On 11/5/2024 2:47 PM, Heinrich Schuchardt wrote: > On 11/5/24 04:43, Hal Feng wrote: >> Get product ID and PCB version from EEPROM, use them to select >> the correct DTB. >> >> Signed-off-by: Hal Feng >> --- >>   board/starfive/visionfive2/spl.c | 25 +++-- >>   1 file changed,

Re: [PATCH] boot: image-board: Mismatch a type between variable and return value

2024-11-05 Thread Marek Vasut
On 11/6/24 12:47 AM, Jaehoon Chung wrote: -Original Message- From: Marek Vasut Sent: Wednesday, November 6, 2024 7:57 AM To: Jaehoon Chung ; u-boot@lists.denx.de Cc: tr...@konsulko.com; s...@chromium.org; marek.vasut+rene...@mailbox.org; laurent.pinch...@ideasonboard.com; m.szyprow...@

[u-boot PATCH] fs: btrfs: hide 'Cannot lookup file' errors on 'load'

2024-11-05 Thread Dominique Martinet
From: Dominique Martinet Running commands such as 'load mmc 2:1 $addr $path' when path does not exists historically do not print any error on filesystems such as ext4 or fat. Changing the root filesystem to btrfs would make existing boot script print 'Cannot lookup file xxx' errors, confusing cus

Re: [PATCH v9 1/7] usb: onboard-hub: Add reset-gpio support

2024-11-05 Thread Marek Vasut
On 10/30/24 7:43 AM, Venkatesh Yadav Abbarapu wrote: As part of the reset, sets the direction of the pin to output before toggling the pin. Delay of millisecond is added in between low and high to meet the setup and hold time requirement of the reset. Signed-off-by: Venkatesh Yadav Abbarapu Rev

Re: [PATCH] armv8: cpu: Implement allow_unaligned()

2024-11-05 Thread Sam Protsenko
On Fri, Nov 1, 2024 at 6:46 AM Heinrich Schuchardt wrote: > [snip] > > +void allow_unaligned(void) > > +{ > > + set_sctlr(get_sctlr() & ~CR_A); > > Looking at the ARM documentation SCTLR_EL2 is a 64bit register. > > https://developer.arm.com/documentation/ddi0595/2021-06/AArch64-Registers/SC

Re: [PATCH v5 6/6] common: android_ab: fix slot suffix for abc block

2024-11-05 Thread Sam Protsenko
On Tue, Nov 5, 2024 at 9:06 AM Mattijs Korpershoek wrote: > > Hi Sam, > Hey Mattijs, [snip] > >> @@ -328,7 +328,8 @@ int ab_select_slot(struct blk_desc *dev_desc, struct > >> disk_partition *part_info, > >> * or the device tree. > >> */ > >> me

Re: [PATCH v12 00/13] net: tcp: improve tcp support in legacy stack

2024-11-05 Thread Tom Rini
On Tue, Nov 05, 2024 at 12:03:49PM -0700, Simon Glass wrote: > Hi Tom, > > On Tue, 5 Nov 2024 at 11:26, Tom Rini wrote: > > > > On Tue, Nov 05, 2024 at 09:07:17AM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Tue, 5 Nov 2024 at 08:47, Tom Rini wrote: > > > > > > > > On Tue, Nov 05, 2024

Re: wget bug report

2024-11-05 Thread Andrew Goodbody
On 05/11/2024 17:50, Jerome Forissier wrote: On 11/5/24 15:12, Simon Glass wrote: Hi Jerome, On Tue, 5 Nov 2024 at 05:12, Jerome Forissier wrote: Hello Simon, On 10/27/24 17:16, Simon Glass wrote: Hi Jerome, Just something I noticed earlier...when running 'ut lib' I see this failure on

RE: [PATCH] boot: image-board: Mismatch a type between variable and return value

2024-11-05 Thread Jaehoon Chung
> -Original Message- > From: Marek Vasut > Sent: Wednesday, November 6, 2024 7:57 AM > To: Jaehoon Chung ; u-boot@lists.denx.de > Cc: tr...@konsulko.com; s...@chromium.org; marek.vasut+rene...@mailbox.org; > laurent.pinch...@ideasonboard.com; m.szyprow...@samsung.com > Subject: Re: [PATC

Re: [PATCH v12 00/13] net: tcp: improve tcp support in legacy stack

2024-11-05 Thread Mikhail Kshevetskiy
On 06.11.2024 02:00, Tom Rini wrote: > On Tue, Nov 05, 2024 at 09:59:57PM +0300, Mikhail Kshevetskiy wrote: >> On 05.11.2024 21:26, Tom Rini wrote: >>> On Tue, Nov 05, 2024 at 09:07:17AM -0700, Simon Glass wrote: Hi Tom, On Tue, 5 Nov 2024 at 08:47, Tom Rini wrote: > On Tue, N

RE: [PATCH] board: rpi: Change from CONFIG_ARM64 to CONFIG_PHYS_64BIT

2024-11-05 Thread Jaehoon Chung
> -Original Message- > From: Tom Rini > Sent: Wednesday, November 6, 2024 7:39 AM > To: Jaehoon Chung > Cc: u-boot@lists.denx.de; mbrug...@suse.com; pbrobin...@gmail.com > Subject: Re: [PATCH] board: rpi: Change from CONFIG_ARM64 to CONFIG_PHYS_64BIT > > On Wed, Nov 06, 2024 at 07:19:3

[PATCH 2/2] ARM: dts: imx: Switch to using upstream DT on DH i.MX6 DHCOM

2024-11-05 Thread Marek Vasut
Enable OF_UPSTREAM to use upstream DT and add nxp/imx/ prefix to the DEFAULT_DEVICE_TREE. And thereby directly build DTB from dts/upstream/src/ including *-u-boot.dtsi files from arch/$(ARCH)/dts/ directory. Signed-off-by: Marek Vasut --- Cc: Andreas Geisreiter Cc: Christoph Niedermaier Cc: Fab

[PATCH 1/2] ARM: dts: imx6dl: Add support for i.MX6DL DHCOM SoM on PDK2 carrier board

2024-11-05 Thread Marek Vasut
Add support for the DH electronics i.MX6DL DHCOM SoM and a PDK2 evaluation board. The evaluation board features three serial ports, USB OTG, USB host with an USB hub, Fast or Gigabit ethernet, eMMC, uSD, SD, analog audio, PCIe and HDMI video output. All of the aforementioned features except for mS

Re: [PATCH v12 00/13] net: tcp: improve tcp support in legacy stack

2024-11-05 Thread Tom Rini
On Tue, Nov 05, 2024 at 09:59:57PM +0300, Mikhail Kshevetskiy wrote: > > On 05.11.2024 21:26, Tom Rini wrote: > > On Tue, Nov 05, 2024 at 09:07:17AM -0700, Simon Glass wrote: > >> Hi Tom, > >> > >> On Tue, 5 Nov 2024 at 08:47, Tom Rini wrote: > >>> On Tue, Nov 05, 2024 at 08:15:25AM -0700, Simon

Re: [PATCH] boot: image-board: Mismatch a type between variable and return value

2024-11-05 Thread Marek Vasut
On 11/5/24 11:11 PM, Jaehoon Chung wrote: phys_addr_t can be used unsigned long long type with CONFIG_PHYS_64BIT. But hextoul() is always returning to unsigned long. It can be assigned to unexpected value. To avoid wrong behavior, change from hextoul() to simple_strtoull(). Fixes: a4df06e41fa2 (

Re: [PATCH] board: rpi: Change from CONFIG_ARM64 to CONFIG_PHYS_64BIT

2024-11-05 Thread Tom Rini
On Wed, Nov 06, 2024 at 07:19:36AM +0900, Jaehoon Chung wrote: > initrd_high is dependent with CONFIG_PHYS_64BIT configuration. > Even though CONFIG_ARM64 is not enabled, CONFIG_PHYS_64BIT can be > enabled. > > Signed-off-by: Jaehoon Chung > --- > board/raspberrypi/rpi/rpi.env | 2 +- > 1 file c

[PATCH] board: rpi: Change from CONFIG_ARM64 to CONFIG_PHYS_64BIT

2024-11-05 Thread Jaehoon Chung
initrd_high is dependent with CONFIG_PHYS_64BIT configuration. Even though CONFIG_ARM64 is not enabled, CONFIG_PHYS_64BIT can be enabled. Signed-off-by: Jaehoon Chung --- board/raspberrypi/rpi/rpi.env | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/raspberrypi/rpi/rpi.e

[PATCH 10/11] rockchip: rk3288-miqi: Fix slow Ethernet initializion

2024-11-05 Thread Jonas Karlman
For some reason the Ethernet PHY reset delay is set to 1 second, this cause an unneccecery long boot delay. MiQi use RTL8211 Ethernet PHY, datasheet list an initial 10ms delay and then a 30-76ms delay before accessing registers. Change to use 80ms delay instead of a full second to speed up Ethern

Re: [PATCH] imx9: Improve boot device auto-selection

2024-11-05 Thread Szőke Benjamin
2024. 11. 01. 13:30 keltezéssel, Fabio Estevam írta: On Fri, Nov 1, 2024 at 7:56 AM Szőke Benjamin wrote: If both CONFIG_ENV_IS_IN_MMC=y and CONFIG_ENV_IS_NOWHERE=y are in the config, CONFIG_ENV_IS_IN_MMC=y will be overrideing default CONFIG_ENV_IS_NOWHERE settings, so in imx9 defconfig it is

[PATCH] boot: image-board: Mismatch a type between variable and return value

2024-11-05 Thread Jaehoon Chung
phys_addr_t can be used unsigned long long type with CONFIG_PHYS_64BIT. But hextoul() is always returning to unsigned long. It can be assigned to unexpected value. To avoid wrong behavior, change from hextoul() to simple_strtoull(). Fixes: a4df06e41fa2 ("boot: fdt: Change type of env_get_bootm_low

[PATCH 08/11] rockchip: rk3288-miqi: Drop USE_PREBOOT Kconfig option

2024-11-05 Thread Jonas Karlman
After the migration to use standard boot, storage media devices should automatically be initialized in the order listed in boot_targets env. Drop USE_PREBOOT to speed up boot when booting from SD-card or eMMC. Signed-off-by: Jonas Karlman --- configs/miqi-rk3288_defconfig | 1 - 1 file changed,

[PATCH] bios_emulator: for non-x86, print warnings if PM_{inp, outp}* access is attempted

2024-11-05 Thread Yuri Zaporozhets
Currently the PM_{inp,outp}* macros are completely broken on non-x86 architectures, because they will essentially access random memory locations if called (and produce a lot of rightful compilation warnings too). For now, replace those macros with warnings (until the code is fixed), so the user a

[PATCH 11/11] rockchip: rk3288-miqi: Change to use FIT

2024-11-05 Thread Jonas Karlman
Change to use FIT and FIT_SIGNATURE when loading U-Boot proper in SPL to allow checksum validation and fallback loading of FIT from a different mmc device. Signed-off-by: Jonas Karlman --- configs/miqi-rk3288_defconfig | 7 +++ 1 file changed, 7 insertions(+) diff --git a/configs/miqi-rk328

[PATCH 09/11] rockchip: rk3288-miqi: Migrate to OF_UPSTREAM

2024-11-05 Thread Jonas Karlman
The device tree for mqmaker MiQi in dts/upstream can be used as-is by U-Boot, migrate board to OF_UPSTREAM. The change to use DT from dts/upstream will include minor changes and fixes related to work led and usb otg. Signed-off-by: Jonas Karlman --- arch/arm/dts/Makefile | 1 -

[PATCH 05/11] rockchip: rk3288-miqi: Include required DT nodes in xPL

2024-11-05 Thread Jonas Karlman
Add bootph- props to emmc, sdmmc, uart and related pinctrl nodes to ensure devices and pinctrl can be used in xPL and U-Boot pre-reloc. Remove the explicit bootph-all prop from the pinctrl node, any bootph- prop will automatically be propagated to the pinctrl node. Signed-off-by: Jonas Karlman -

[PATCH 07/11] rockchip: rk3288-miqi: Drop use of silent console and late boardinfo

2024-11-05 Thread Jonas Karlman
Current use of SILENT_CONSOLE hide valuable information when something goes wrong during boot, drop this Kconfig option to allow user to see e.g. from what media U-Boot proper is loaded from. A second Model line is printed on console due to DISPLAY_BOARDINFO_LATE, drop this Kconfig option to remov

[PATCH 06/11] rockchip: rk3288-miqi: Include sdmmc regulator in SPL

2024-11-05 Thread Jonas Karlman
Add bootph props and enable related Kconfig options to include the sdmmc regulator in SPL. Also enable SPL_DM_SEQ_ALIAS to ensure aliases is handled correctly in SPL. Signed-off-by: Jonas Karlman --- arch/arm/dts/rk3288-miqi-u-boot.dtsi | 5 + configs/miqi-rk3288_defconfig| 3 +++ 2

[PATCH 02/11] rockchip: rk3288-miqi: Remove unused work led node from xPL

2024-11-05 Thread Jonas Karlman
The work led is not used in xPL on rk3288-miqi, remove bootph props from the work led node to exclude it from xPL control FDT. Signed-off-by: Jonas Karlman --- arch/arm/dts/rk3288-miqi-u-boot.dtsi | 9 - 1 file changed, 9 deletions(-) diff --git a/arch/arm/dts/rk3288-miqi-u-boot.dtsi b

[PATCH 03/11] rockchip: rk3288-miqi: Set ethaddr env based on cpuid

2024-11-05 Thread Jonas Karlman
Enable Kconfig options to read cpuid from efuse and set cpuid#, serial# and ethaddr env vars based on the value read from efuse. Signed-off-by: Jonas Karlman --- configs/miqi-rk3288_defconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configs/miqi-rk3288_defconfig b/c

[PATCH 04/11] rockchip: rk3288-miqi: Use TPL with common bss and stack addresses

2024-11-05 Thread Jonas Karlman
Migrate to use TPL, common bss, stack and malloc heap size and addresses to unify memory use in TPL, SPL and pre-reloc. ENV_OFFSET is using the default value of 0x3f8000 and is also dropped. Signed-off-by: Jonas Karlman --- arch/arm/mach-rockchip/rk3288/Kconfig | 2 ++ configs/miqi-rk3288_defc

[PATCH 01/11] rockchip: rk3288-miqi: Sort u-boot.dtsi nodes alphabetically

2024-11-05 Thread Jonas Karlman
Sort the nodes in rk3288-miqi-u-boot.dtsi in alphabetical order. This has no intended change to board DT, this only rearrange nodes in preparation for future changes. Signed-off-by: Jonas Karlman --- arch/arm/dts/rk3288-miqi-u-boot.dtsi | 12 ++-- 1 file changed, 6 insertions(+), 6 dele

[PATCH 00/11] rockchip: rk3288-miqi: Migrate to OF_UPSTREAM

2024-11-05 Thread Jonas Karlman
This series migrate MiQi to use OF_UPSTREAM, ensure devices and pinctrl is included in xPL control FDT, set ethaddr based on cpuid and finally change to use FIT with checksum validation. I do not have a MiQi board and have only done limited runtime test, with adjusted sdram props, on a Tinker Boar

Re: [PATCH v2 4/9] docker: Adjust packages for arm64

2024-11-05 Thread Tom Rini
On Tue, Nov 05, 2024 at 12:20:51PM -0700, Simon Glass wrote: > HI Tom, > > On Tue, 5 Nov 2024 at 09:45, Tom Rini wrote: > > > > On Tue, Nov 05, 2024 at 09:26:10AM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Tue, 5 Nov 2024 at 09:11, Tom Rini wrote: > > > > > > > > On Tue, Nov 05, 2024

[PATCH 1/1] board: qemu-arm: select CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR

2024-11-05 Thread Heinrich Schuchardt
qemu_arm64_defconfig with CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=n leads to a build error: arch/arm/lib/crt0_64.S:85: Error: constant expression expected at operand 2 -- `ldr x0,=((CFG_SYS_INIT_RAM_ADDR+CFG_SYS_INIT_RAM_SIZE-480))' We do not define CFG_SYS_INIT_RAM_ADDR and CFG_SYS_INIT_R

Re: [PATCH v2 4/9] docker: Adjust packages for arm64

2024-11-05 Thread Simon Glass
HI Tom, On Tue, 5 Nov 2024 at 09:45, Tom Rini wrote: > > On Tue, Nov 05, 2024 at 09:26:10AM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 5 Nov 2024 at 09:11, Tom Rini wrote: > > > > > > On Tue, Nov 05, 2024 at 09:07:33AM -0700, Simon Glass wrote: > > > > The package names are slightly d

[PATCH 00/13] rockchip: rk3288-tinker: Migrate to OF_UPSTREAM

2024-11-05 Thread Jonas Karlman
This series migrate Tinker Board to use OF_UPSTREAM, cleanup devices and pinctrl included in xPL control FDT and finally change to use FIT with checksum validation. TPL continue to OF_PLATDATA after this series, however boot testing was done with and without use of OF_PLATDATA. Features tested on

Re: [PATCH 4/9] docker: Adjust packages for arm64

2024-11-05 Thread Simon Glass
Hi Tom, Heinrich, On Mon, 4 Nov 2024 at 14:34, Tom Rini wrote: > > On Mon, Nov 04, 2024 at 09:58:50PM +0100, Heinrich Schuchardt wrote: > > > > > > Am 4. November 2024 14:39:48 MEZ schrieb Simon Glass : > > >The package names are slightly different for arm64 and we don't seem to > > >have a linux

Re: [PATCH 3/4] lmb: Add basic io_lmb functionality

2024-11-05 Thread Sughosh Ganu
On Fri, 1 Nov 2024 at 15:47, Janne Grunau wrote: > > These functions can be used with struct lmb pointers and will be used to > manage IOVA space in the apple_dart iommu driver. This restores part of > the pointer base struct lmb API from before commit ed17a33fed29 ("lmb: > make LMB memory map per

Re: [PATCH 0/4] Fix IOVA allocation in Apple dart iommu after global LMB mem map changes

2024-11-05 Thread Sughosh Ganu
On Sun, 3 Nov 2024 at 23:06, Janne Grunau wrote: > > On Sun, Nov 03, 2024 at 07:53:36PM +0530, Sughosh Ganu wrote: > > On Sat, 2 Nov 2024 at 16:00, Mark Kettenis wrote: > > > > > > > From: Sughosh Ganu > > > > Date: Fri, 1 Nov 2024 17:17:22 +0530 > > > > > > > > On Fri, 1 Nov 2024 at 15:47, Jann

Re: [PATCH v12 00/13] net: tcp: improve tcp support in legacy stack

2024-11-05 Thread Simon Glass
Hi Tom, On Tue, 5 Nov 2024 at 11:26, Tom Rini wrote: > > On Tue, Nov 05, 2024 at 09:07:17AM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 5 Nov 2024 at 08:47, Tom Rini wrote: > > > > > > On Tue, Nov 05, 2024 at 08:15:25AM -0700, Simon Glass wrote: > > > > Hi Peter, > > > > > > > > On Tue

Re: [PATCH v12 00/13] net: tcp: improve tcp support in legacy stack

2024-11-05 Thread Mikhail Kshevetskiy
On 05.11.2024 21:26, Tom Rini wrote: > On Tue, Nov 05, 2024 at 09:07:17AM -0700, Simon Glass wrote: >> Hi Tom, >> >> On Tue, 5 Nov 2024 at 08:47, Tom Rini wrote: >>> On Tue, Nov 05, 2024 at 08:15:25AM -0700, Simon Glass wrote: Hi Peter, On Tue, 5 Nov 2024 at 06:10, Peter Robinson

Re: [PATCH next 1/5] pinctrl: rockchip: allow to build for TPL

2024-11-05 Thread Paul Kocialkowski
Hi, Le Tue 05 Nov 24, 16:36, Quentin Schulz a écrit : > From: Quentin Schulz > > A later commit will make use of the pinctrl driver in TPL so let's add > the ability to build the Rockchip pinctrl driver in TPL. > > Signed-off-by: Quentin Schulz Reviewed-by: Paul Kocialkowski Just a nit belo

Re: [PATCH 2/4] rockchip: rk3399-rockpro64: Hook sysreset gpio to enable full reset

2024-11-05 Thread Paul Kocialkowski
nism and avoid any possible side-effect of partially-reset > > units. > > > > Signed-off-by: Paul Kocialkowski > > Since patches 3 and 4 seems to be a bit controversial, maybe send patches 1 > and 2 in a different patch series so those can be merged separately? > > You may want

Re: [PATCH next 4/5] rockchip: rk3399: allow to handle sysreset-gpio in TPL

2024-11-05 Thread Paul Kocialkowski
Hi again, Le Tue 05 Nov 24, 16:36, Quentin Schulz a écrit : > From: Quentin Schulz > > If TPL_GPIO and TPL_PINCTRL_ROCKCHIP are enabled and a sysreset-gpio is > provided in the TPL Device Tree, this will trigger a system reset > similar to what's currently been done in SPL whenever the RK3399 "w

[PATCH] net: net_utils: Move ip_to_string to lib/net_utils.c

2024-11-05 Thread Adriano Cordova
The function string_to_ip is already in net_utils, which is compiled unconditionally, but ip_to_string is currently only accessible if the legacy network stack is selected. This commit puts ip_to_string in net_utils.c and removes it from the legacy network code. Signed-off-by: Adriano Cordova ---

Re: [PATCH next 0/5] rockchip: rk3399: allow to trigger sysreset in TPL

2024-11-05 Thread Paul Kocialkowski
k3399: allow to handle sysreset-gpio in TPL > rockchip: configs: puma-rk3399: do the system reset in TPL > > arch/arm/mach-rockchip/rk3399/rk3399.c | 58 > +++--- > arch/arm/mach-rockchip/tpl.c | 6 > configs/puma-rk3399_defcon

Re: [PATCH next 3/5] rockchip: tpl: allow to call board/SoC-specific code before DRAM init

2024-11-05 Thread Paul Kocialkowski
Hi, Le Tue 05 Nov 24, 16:36, Quentin Schulz a écrit : > From: Quentin Schulz > > This defines a weak tpl_board_init function that can be used for running > board/SoC-specific code before the DRAM init happens, similarly to > spl_board_init() for SPL. > > Signed-off-by: Quentin Schulz Reviewed

Re: [PATCH next 5/5] rockchip: configs: puma-rk3399: do the system reset in TPL

2024-11-05 Thread Paul Kocialkowski
Hi, Le Tue 05 Nov 24, 16:36, Quentin Schulz a écrit : > From: Quentin Schulz > > RK3399 Puma can trigger a full system reset at runtime by toggling a > GPIO. This is done whenever the system has NOT cold booted (i.e. from a > power cycle). For RK3399 Puma, this is currently done in SPL but only

Re: [PATCH next 4/5] rockchip: rk3399: allow to handle sysreset-gpio in TPL

2024-11-05 Thread Paul Kocialkowski
Hi, Le Tue 05 Nov 24, 16:36, Quentin Schulz a écrit : > From: Quentin Schulz > > If TPL_GPIO and TPL_PINCTRL_ROCKCHIP are enabled and a sysreset-gpio is > provided in the TPL Device Tree, this will trigger a system reset > similar to what's currently been done in SPL whenever the RK3399 "warm" >

Re: [PATCH next 2/5] rockchip: rk3399: merge CRU check within rk3399_force_power_on_reset

2024-11-05 Thread Paul Kocialkowski
Hi, Le Tue 05 Nov 24, 16:36, Quentin Schulz a écrit : > From: Quentin Schulz > > To prepare to support forcing power on reset from TPL which would have > the exact same logic, just in an earlier stage, let's merge the CRU > check that triggers the power on reset with the rest of the logic. > >

Re: [PATCH v12 00/13] net: tcp: improve tcp support in legacy stack

2024-11-05 Thread Tom Rini
On Tue, Nov 05, 2024 at 09:07:17AM -0700, Simon Glass wrote: > Hi Tom, > > On Tue, 5 Nov 2024 at 08:47, Tom Rini wrote: > > > > On Tue, Nov 05, 2024 at 08:15:25AM -0700, Simon Glass wrote: > > > Hi Peter, > > > > > > On Tue, 5 Nov 2024 at 06:10, Peter Robinson wrote: > > > > > > > > On Tue, 5 No

Re: wget bug report

2024-11-05 Thread Jerome Forissier
On 11/5/24 15:12, Simon Glass wrote: > Hi Jerome, > > On Tue, 5 Nov 2024 at 05:12, Jerome Forissier > wrote: >> >> Hello Simon, >> >> On 10/27/24 17:16, Simon Glass wrote: >>> Hi Jerome, >>> >>> Just something I noticed earlier...when running 'ut lib' I see this >>> failure on sandbox: >>> >>>

[PATCH next RFC 5/5] ram: rk3399: fail DRAM init when pctl channel init fails instead of hanging

2024-11-05 Thread Quentin Schulz
From: Quentin Schulz Instead of hanging via an infinite while loop, propagate the fail to the caller and let it handle the fail. For RK3399, this means that panic() will be called, (by default) resetting the CPU and giving another chance at doing a DRAM init. Signed-off-by: Quentin Schulz ---

[PATCH next RFC 2/5] ram: rk3399: fail probe if DRAM init failed

2024-11-05 Thread Quentin Schulz
From: Quentin Schulz We should fail the probe of the DRAM device if the DRAM init failed so let's return a negative error-code if rk3399_dmc_init returns non-zero. Signed-off-by: Quentin Schulz --- drivers/ram/rockchip/sdram_rk3399.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH next RFC 4/5] ram: rk3399: merge two consecutive ifs with same condition

2024-11-05 Thread Quentin Schulz
From: Quentin Schulz Nothing changes channel_mask in the first if block of the same condition so it is safe to merge the two if blocks with the same condition into one. No intended change in behavior. Signed-off-by: Quentin Schulz --- drivers/ram/rockchip/sdram_rk3399.c | 5 + 1 file chan

[PATCH next RFC 3/5] rockchip: spl/tpl: panic when DRAM init failed

2024-11-05 Thread Quentin Schulz
From: Quentin Schulz A failed DRAM init is synonym with a broken board, so let's panic instead of silently skipping the rest of the xPL stage and making it fail later in some other code parts. This also has the benefit of (by default) resetting the CPU which could help recover the device without

[PATCH next RFC 1/5] ram: rk3399: allow to fail DRAM init if pctl_start fails

2024-11-05 Thread Quentin Schulz
From: Quentin Schulz pctl_start() can fail but how this is handled currently is by calling hang() directly in the driver instead of propagating the error and letting other code handling it. This prepares for a future commit which removes the hang() in favor of letting Rockchip's arch code handle

[PATCH next RFC 0/5] rockchip: panic() when DRAM init fails

2024-11-05 Thread Quentin Schulz
arm/mach-rockchip/tpl.c| 6 ++ drivers/ram/rockchip/sdram_rk3399.c | 24 +++- 3 files changed, 16 insertions(+), 21 deletions(-) --- base-commit: 56accc56b9aab87ef4809ccc588e1257969cd271 change-id: 20241105-rk3399-dram-init-207325c2d9ca Best regards, -- Quentin Schulz

Re: [PATCH RFC v1] Dockerfile: Have "sandbox" build with i386 toolchain not x86_64 toolchain

2024-11-05 Thread Simon Glass
Hi Tom, On Tue, 5 Nov 2024 at 09:54, Tom Rini wrote: > > A long time ago, we had to use "i386" and "x86_64" toolchains for our > x86 platforms, depending on the target. We then moved to being able to > use the single "i386" toolchain to support all x86 platforms. At the > same time, we had been b

[PATCH RFC v1] Dockerfile: Have "sandbox" build with i386 toolchain not x86_64 toolchain

2024-11-05 Thread Tom Rini
A long time ago, we had to use "i386" and "x86_64" toolchains for our x86 platforms, depending on the target. We then moved to being able to use the single "i386" toolchain to support all x86 platforms. At the same time, we had been building sandbox with our "x86_64" toolchain in CI. When x86 switc

Re: [PATCH v2 4/9] docker: Adjust packages for arm64

2024-11-05 Thread Tom Rini
On Tue, Nov 05, 2024 at 09:26:10AM -0700, Simon Glass wrote: > Hi Tom, > > On Tue, 5 Nov 2024 at 09:11, Tom Rini wrote: > > > > On Tue, Nov 05, 2024 at 09:07:33AM -0700, Simon Glass wrote: > > > The package names are slightly different for arm64 and we don't seem to > > > have a linux-image-kvm p

SPL crashes when trying to load legacy image from NOR (on MIPS)

2024-11-05 Thread Ezra Buehler
Since commit 6cc2182c84a ("spl: nor: Don't allocate header on stack") the MT7688/MIPS-based GARDENA smart Gateway no longer boots. The root cause seems to be a read of an unaligned 32 bit value from the SPI NOR flash (image_get_magic() called by spl_parse_image_header()). Before, having the legacy

Re: [PATCH v2 4/9] docker: Adjust packages for arm64

2024-11-05 Thread Simon Glass
Hi Tom, On Tue, 5 Nov 2024 at 09:11, Tom Rini wrote: > > On Tue, Nov 05, 2024 at 09:07:33AM -0700, Simon Glass wrote: > > The package names are slightly different for arm64 and we don't seem to > > have a linux-image-kvm package. Provide a different set for arm64 > > > > Signed-off-by: Simon Glas

[PATCH v2] boot/image-board.c: boot_get_fpga(): pass compatible flag to fpga_load()

2024-11-05 Thread Peter Korsgaard
For E.G. signed FPGA bitstreams, similar to how it is done for the FPGA loading from SPL since commit 71f1a5392aad ("spl: fit: pass real compatible flags to fpga_load()"). Signed-off-by: Peter Korsgaard --- Changes since v1: - Reference correct SPL commit boot/image-board.c | 16 +--

Re: [PATCH] boot/image-board.c: boot_get_fpga(): pass compatible flag to fpga_load()

2024-11-05 Thread Peter Korsgaard
On 10/28/24 17:55, Peter Korsgaard wrote: For E.G. signed FPGA bitstreams, similar to how it is done for the FPGA loading from SPL since commit 282eed50ecb7 ("fpga: pass compatible flags to fpga_load()"). Ups, that should have been commit 71f1a5392aad ("spl: fit: pass real compatible flags to

[PATCH 02/13] rockchip: rk3288-tinker: Sort u-boot.dtsi nodes alphabetically

2024-11-05 Thread Jonas Karlman
Sort the nodes in rk3288-tinker u-boot.dtsi files in alphabetical order. This has no intended change to board DTs and only rearrange nodes in preparation for future changes. Signed-off-by: Jonas Karlman --- arch/arm/dts/rk3288-tinker-s-u-boot.dtsi | 8 ++--- arch/arm/dts/rk3288-tinker-u-boot.d

Re: [PATCH v2 4/9] docker: Adjust packages for arm64

2024-11-05 Thread Tom Rini
On Tue, Nov 05, 2024 at 09:07:33AM -0700, Simon Glass wrote: > The package names are slightly different for arm64 and we don't seem to > have a linux-image-kvm package. Provide a different set for arm64 > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Swap order so that amd64 is the e

[PATCH v2 9/9] CI: Add platform variable

2024-11-05 Thread Simon Glass
Add a list of possible platforms that can be used by gitlab runners. Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- (no changes since v1) .gitlab-ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 0aeda53bc2d..e152060b046 100644 --- a/.gitla

[PATCH v2 7/9] docker: Drop coreboot for arm64

2024-11-05 Thread Simon Glass
This isn't needed for sandbox builds and coreboot isn't much used on arm64, nor does U-Boot have a build that supports running from coreboot on any ARM target. So drop it. Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- (no changes since v1) tools/docker/Dockerfile | 6 -- 1 file ch

[PATCH v2 8/9] docker: Fix LegacyKeyValueFormat warning with PYTHONPATH

2024-11-05 Thread Simon Glass
Fix a warning due to the syntax used for PYTHONPATH: LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 304) Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt Reviewed-by: Tom Rini --- (no changes since v1) tools/docker/Doc

[PATCH v2 5/9] docker: Drop grub for arm64

2024-11-05 Thread Simon Glass
This doesn't build on arm64 at present, so drop it for now. We only expect to run sandbox tests, so perhaps it isn't needed. The error seems to be due to not using the correct toolchains: ./configure: line 32517: /opt/gcc-13.2.0-nolibc/aarch64-linux/ bin/aarch64-linux-gcc: No such file o

[PATCH v2 6/9] docker: Drop tracing for arm64

2024-11-05 Thread Simon Glass
This doesn't build on arm64 at present, so drop it for now. This can be revisited if we wish to support arm64 for the sandbox trace-test. The error is: /usr/bin/ld: /usr/local/lib64/libtracefs.so: undefined reference to `trace_seq_vprintf' Signed-off-by: Simon Glass --- (no changes sin

[PATCH v2 4/9] docker: Adjust packages for arm64

2024-11-05 Thread Simon Glass
The package names are slightly different for arm64 and we don't seem to have a linux-image-kvm package. Provide a different set for arm64 Signed-off-by: Simon Glass --- Changes in v2: - Swap order so that amd64 is the exception tools/docker/Dockerfile | 12 +++- 1 file changed, 7 inser

[PATCH v2 3/9] docker: Support building for multiple architectures

2024-11-05 Thread Simon Glass
Add instructions on how to build the file for multiple architectures. Add a message indicating what is happening. Update the documentation as well. Drop the 'sudo' since these should not be needed if Docker is correctly configured. Signed-off-by: Simon Glass --- Changes in v2: - Update docs als

[PATCH v2 2/9] test: Adjust print_ut test to use unsigned char

2024-11-05 Thread Simon Glass
Since char is unsigned on arm64, this test currently fails. It seems better to use unsigned anyway, since 0xff is written into the string at the start. Update the terminator-assert to use a character instead of a byte. Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt --- Changes in v

[PATCH v2 1/9] sandbox: efi_loader: Correct use of addresses as pointers

2024-11-05 Thread Simon Glass
The cache-flush function is incorrect which causes a crash in the remoteproc tests with arm64. Fix both problems by using map_sysmem() to convert an address to a pointer and map_to_sysmem() to convert a pointer to an address. Also update the image-loader's cache-flushing logic. Signed-off-by: Si

Re: [PATCH v3 01/19] bootstd: Move bootflow-adding to bootstd

2024-11-05 Thread Simon Glass
Hi Tom, On Tue, 5 Nov 2024 at 08:39, Tom Rini wrote: > > On Tue, Nov 05, 2024 at 08:13:04AM -0700, Simon Glass wrote: > > Hi Heinrich, > > > > On Mon, 4 Nov 2024 at 15:15, Heinrich Schuchardt wrote: > > > > > > On 11/4/24 18:50, Simon Glass wrote: > > > > This relates to more than just the bootd

[PATCH v2 0/9] CI: Set up for an arm64 runner

2024-11-05 Thread Simon Glass
All gitlab runners are currently amd64 machines. This series attempts to create a docker image which can also support arm64 so that sandbox tests can be run on it. Changes in v2: - Drop message about EFI_LOADER - Use '\0' instead of 0 - Update docs also - Add comments to the ARG variables - Swap o

Re: [PATCH v12 00/13] net: tcp: improve tcp support in legacy stack

2024-11-05 Thread Simon Glass
Hi Tom, On Tue, 5 Nov 2024 at 08:47, Tom Rini wrote: > > On Tue, Nov 05, 2024 at 08:15:25AM -0700, Simon Glass wrote: > > Hi Peter, > > > > On Tue, 5 Nov 2024 at 06:10, Peter Robinson wrote: > > > > > > On Tue, 5 Nov 2024 at 13:03, Simon Glass wrote: > > > > > > > > Hi Tom, > > > > > > > > On M

Re: [PATCH 5/9] docker: Drop grub for arm64

2024-11-05 Thread Simon Glass
Hi Tom, On Tue, 5 Nov 2024 at 08:44, Tom Rini wrote: > > On Tue, Nov 05, 2024 at 08:15:05AM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 4 Nov 2024 at 06:56, Tom Rini wrote: > > > > > > On Mon, Nov 04, 2024 at 06:39:49AM -0700, Simon Glass wrote: > > > > > > > This doesn't build on arm6

Re: [PATCH v12 00/13] net: tcp: improve tcp support in legacy stack

2024-11-05 Thread Peter Robinson
On Tue, 5 Nov 2024 at 15:15, Simon Glass wrote: > > Hi Peter, > > On Tue, 5 Nov 2024 at 06:10, Peter Robinson wrote: > > > > On Tue, 5 Nov 2024 at 13:03, Simon Glass wrote: > > > > > > Hi Tom, > > > > > > On Mon, 4 Nov 2024 at 16:32, Tom Rini wrote: > > > > > > > > On Mon, Oct 28, 2024 at 05:31

[PATCH 13/13] rockchip: rk3288-tinker: Change to use FIT

2024-11-05 Thread Jonas Karlman
Change to use FIT and FIT_SIGNATURE when loading U-Boot proper in SPL to allow checksum validation and fallback loading of FIT from a different mmc device. Checksum validation of FIT adds around 140 ms to boot time: Before: MarkElapsed Stage 0 0 reset 13

[PATCH 12/13] rockchip: rk3288-tinker: Fix slow Ethernet initializion

2024-11-05 Thread Jonas Karlman
For some reason the Ethernet PHY reset delay is set to 1 second, this cause an unneccecery long boot delay. Tinker Board use RTL8211E or RTL8211F Ethernet PHY, datasheet list an initial 10ms delay and then a 30-76ms delay before accessing registers. Change to use 80ms delay instead of a full seco

[PATCH 11/13] rockchip: rk3288-tinker: Migrate to OF_UPSTREAM

2024-11-05 Thread Jonas Karlman
The device tree for ASUS Tinker Board and S variant in dts/upstream can be used as-is by U-Boot, migrate board to OF_UPSTREAM. The change to use DT from dts/upstream will include minor changes and fixes related to leds and regulators. Signed-off-by: Jonas Karlman --- arch/arm/dts/Makefile

[PATCH 10/13] rockchip: rk3288-tinker: Drop USE_PREBOOT Kconfig option

2024-11-05 Thread Jonas Karlman
After the migration to use standard boot, storage media should automatically be initialized in the order listed in boot_targets env. Drop USE_PREBOOT to speed up boot with ~12 seconds when booting from e.g. SD-card or eMMC. Before: 3,048,599 2,056 main_loop 3,050,717 2,118 usb_st

[PATCH 08/13] rockchip: rk3288-tinker: Use common bss and stack addresses

2024-11-05 Thread Jonas Karlman
Migrate to use common bss, stack and malloc heap size and addresses to unify memory use in TPL, SPL and pre-reloc. Ensure SYS_MALLOC_F_LEN and TPL variant stay at 0x2000 and is unaffected on other boards not changed to use common malloc heap size. ENV_OFFSET is using the default value of 0x3f8000

[PATCH 09/13] rockchip: rk3288-tinker: Drop use of silent console and late boardinfo

2024-11-05 Thread Jonas Karlman
Current use of SILENT_CONSOLE hide valuable information when something goes wrong during boot, drop this Kconfig option to allow user to see e.g. from what media U-Boot proper is loaded from. A second Model line is printed on console due to DISPLAY_BOARDINFO_LATE, drop this Kconfig option to remov

[PATCH 07/13] rockchip: rk3288-tinker: Sync defconfig options from rk3288-tinker-s

2024-11-05 Thread Jonas Karlman
Add missing Kconfig options used by the rk3288-tinker-s variant. Signed-off-by: Jonas Karlman --- configs/tinker-rk3288_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configs/tinker-rk3288_defconfig b/configs/tinker-rk3288_defconfig index 851c312d4db5..0c2fd573b67b 100644 --- a

[PATCH 03/13] rockchip: rk3288-tinker: Only include required DT nodes in TPL

2024-11-05 Thread Jonas Karlman
Drop the unneeded bootph-all prop from dmc node, it is already defined in soc u-boot.dtsi. Remove booth-all prop from gpio7 node, this node is not needed in TPL. Adjust bootph props to include pinctrl related nodes for UART2. Remove the explicit bootph-all prop from the pinctrl node, any bootph-

  1   2   >