[PATCH V3] cpu: imx8_cpu: Avoid revision to corrupt device tree

2024-10-17 Thread Peng Fan (OSS)
From: Peng Fan U-Boot device tree is padded just after U-Boot proper. After the whole stuff loaded to DRAM space, the device tree area is conflict with BSS region before U-Boot relocation. So any write to BSS area before reloc_fdt will corrupt the device tree. Without the fix, there is issue tha

Re: [PATCH] binman: Add option for pointing to external description

2024-10-17 Thread Michal Simek
Hi Simon, On 10/18/24 01:23, Simon Glass wrote: Hi Michal, On Wed, 16 Oct 2024 at 00:00, Michal Simek wrote: Hi Simon, On 10/15/24 14:48, Simon Glass wrote: Hi Michal, On Thu, 10 Oct 2024 at 07:03, Michal Simek wrote: On 10/9/24 23:14, Simon Glass wrote: Hi Michal, On Wed, 9 Oct 20

Re: Please pull u-boot-dm

2024-10-17 Thread Tom Rini
On Thu, Oct 17, 2024 at 05:23:40PM -0600, Simon Glass wrote: > Hi Tom, > > I have kept back some of the coreboot patches until the docker change > is applied. It needs a newer version of coreboot. > > - Simon > > https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/22775 > https://dev

Re: [PATCH] binman: Add option for pointing to external description

2024-10-17 Thread Michal Simek
On 10/17/24 19:54, Tom Rini wrote: On Wed, Oct 16, 2024 at 07:59:59AM +0200, Michal Simek wrote: Hi Simon, On 10/15/24 14:48, Simon Glass wrote: Hi Michal, On Thu, 10 Oct 2024 at 07:03, Michal Simek wrote: On 10/9/24 23:14, Simon Glass wrote: Hi Michal, On Wed, 9 Oct 2024 at 07:21,

Re: [PATCH v2 0/3] image: android: misc fixes when using on Qualcomm platforms

2024-10-17 Thread Guillaume LA ROQUE
Hi, thanks for this fixes. I just test this series on Khadas VIM3 with android image version 2 non A/B  and AB, on TI AM62P with android image version 4 with AB, both boards boot fine. Tested-by: Guillaume La Roque Guillaume Le 17/10/2024 à 16:44, Neil Armstrong a écrit : When trying to us

Re: [PATCH 0/8] rockchip: Add support for FriendlyElec NanoPC-T6 LTS

2024-10-17 Thread Dragan Simic
Hello Jonas and Marcin, On 2024-10-17 22:00, Jonas Karlman wrote: This series picks minimum required commits from v6.12-rc1-dts to add initial support for the FriendlyElec NanoPC-T6 LTS variant. The adc-uclass and rockchip-saradc drivers are adopted to support cases when DM_REGULATOR is disable

Re: [PATCH 1/8] arm64: dts: rockchip: prepare NanoPC-T6 for LTS board

2024-10-17 Thread Sumit Garg
On Fri, 18 Oct 2024 at 01:30, Jonas Karlman wrote: > > From: Marcin Juszkiewicz > > FriendlyELEC introduced a second version of NanoPC-T6 SBC. > > Create common include file and make NanoPC-T6 use it. Following > patches will add LTS version. > > Signed-off-by: Marcin Juszkiewicz > Link: > http

Re: [PATCH 6/6] DONOTMERGE: For testing only

2024-10-17 Thread Aniket Limaye
On 17/10/24 23:24, Tom Rini wrote: On Thu, Oct 17, 2024 at 11:59:13AM +0530, Aniket Limaye wrote: From: Reid Tonking This just provides some useful print outs and the proper config to test the functionality. For J7200 boards that do not have efuse burned in, the hardcoded 76 is needed

Re: [PATCH v3 3/8] bootstd: Avoid depending on BLK

2024-10-17 Thread Tom Rini
On Thu, Oct 17, 2024 at 04:12:02PM -0700, Simon Glass wrote: > In principle bootstd can work without block devices, even if it does > require driver model to be enabled in that case. > > The use of a 'depends on BLK' for BOOTSTD conflicts with the way 'BLK' > is now defined, producing recursive e

Re: [PATCH 23/34] bootstd: Maintain a list of images

2024-10-17 Thread Heinrich Schuchardt
Am 18. Oktober 2024 01:24:02 MESZ schrieb Simon Glass : >We want to keep track of images which are loaded, or those which could >perhaps be loaded. This will make it easier to manage memory allocation, >as well as permit removal of the EFI set_efi_bootdev() hack. Please, keep in mind that files

Re: [PATCH v6 06/12] efi: Use the same filename for all sandbox builds

2024-10-17 Thread Heinrich Schuchardt
Am 18. Oktober 2024 05:05:08 MESZ schrieb Simon Glass : >Hi Tom, > >On Thu, 17 Oct 2024 at 18:17, Tom Rini wrote: >> >> On Thu, Oct 17, 2024 at 05:23:19PM -0600, Simon Glass wrote: >> > Hi Heinrich, >> > >> > On Mon, 30 Sept 2024 at 17:23, Heinrich Schuchardt >> > wrote: >> > > >> > > On 26.0

Re: [PATCH 1/1] cmd: upl: correct printf code

2024-10-17 Thread Neha Malcom Francis
Hi Heinrich On 18/10/24 08:16, Heinrich Schuchardt wrote: Building on 32-bit results in a build failure: cmd/upl.c:75:51: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘size_t’ {aka ‘unsigned int’} [-Wformat=] 75 | printf("UPL ha

Re: [PATCH 15/34] image: Add a new type for extlinux

2024-10-17 Thread Tom Rini
On Thu, Oct 17, 2024 at 05:23:54PM -0600, Simon Glass wrote: > Add an image type for the extlinux.cfg file, which U-Boot supports > reading. > > Signed-off-by: Simon Glass > --- > > boot/image.c| 1 + > include/image.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/boot/image.

Re: [PATCH 26/34] efi: Simplify reading files by using the common function

2024-10-17 Thread Tom Rini
On Thu, Oct 17, 2024 at 05:24:05PM -0600, Simon Glass wrote: > The efiload_read_file() does similar things to a common function, so > update it to use that instead. > > Signed-off-by: Simon Glass This is probably the first of a few commits that should read "bootmeth_efi:" not "efi:" I think. -

Re: [PATCH 23/34] bootstd: Maintain a list of images

2024-10-17 Thread Tom Rini
On Thu, Oct 17, 2024 at 05:24:02PM -0600, Simon Glass wrote: > We want to keep track of images which are loaded, or those which could > perhaps be loaded. This will make it easier to manage memory allocation, > as well as permit removal of the EFI set_efi_bootdev() hack. Please stop calling it a

Re: [PATCH v6 06/12] efi: Use the same filename for all sandbox builds

2024-10-17 Thread Simon Glass
Hi Tom, On Thu, 17 Oct 2024 at 18:17, Tom Rini wrote: > > On Thu, Oct 17, 2024 at 05:23:19PM -0600, Simon Glass wrote: > > Hi Heinrich, > > > > On Mon, 30 Sept 2024 at 17:23, Heinrich Schuchardt > > wrote: > > > > > > On 26.09.24 23:59, Simon Glass wrote: > > > > Sandbox is not a real architect

[PATCH 8/8] membuf: Support a flag for being full

2024-10-17 Thread Simon Glass
At present the membuf implementation wastes a slot in the fifo so it can detect the difference between a full and an empty buffer. Add the option of supporting a boolean flag, if desired. For now it is off. The code-size penalty is non-zero, but the space penalty is small and could be reduced on

[PATCH 7/8] membuf: Minor code-style improvements

2024-10-17 Thread Simon Glass
Show the start in end in the comment. Comment a missing variable in membuf_readline() and fix its line length. Signed-off-by: Simon Glass --- include/membuf.h | 6 -- lib/membuf.c | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/include/membuf.h b/include/membuf.h

[PATCH 6/8] membuf: Add some tests

2024-10-17 Thread Simon Glass
Add tests for the membuf implementation. Signed-off-by: Simon Glass --- test/lib/Makefile | 1 + test/lib/membuf.c | 239 ++ 2 files changed, 240 insertions(+) create mode 100644 test/lib/membuf.c diff --git a/test/lib/Makefile b/test/lib/Makefile

[PATCH 5/8] membuf: Correct implementation of membuf_dispose()

2024-10-17 Thread Simon Glass
This should free the pointer, not the address of the pointer. Fix it. Signed-off-by: Simon Glass --- lib/membuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/membuf.c b/lib/membuf.c index b13998ccdbd..695d16d051e 100644 --- a/lib/membuf.c +++ b/lib/membuf.c @@ -384,6

[PATCH 4/8] membuf: Include stdbool

2024-10-17 Thread Simon Glass
This uses a bool type so include the required header. Signed-off-by: Simon Glass --- include/membuf.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/membuf.h b/include/membuf.h index 17616d5577e..636ed703ee7 100644 --- a/include/membuf.h +++ b/include/membuf.h @@ -9,6 +9,8 @@ #i

[PATCH 3/8] membuf: Rename struct

2024-10-17 Thread Simon Glass
Rename the struct to match the function prefix and filenames. Signed-off-by: Simon Glass --- arch/sandbox/include/asm/serial.h | 2 +- boot/bootmeth_extlinux.c | 2 +- common/console.c | 24 +- drivers/usb/emul/sandbox_keyb.c | 2 +- include/asm-ge

[PATCH 2/8] membuff: Rename the files to membuf

2024-10-17 Thread Simon Glass
Rename the C and header files to use the membuf basename, to match the functions. Add a MAINTAINERS entry while we are here. Signed-off-by: Simon Glass --- MAINTAINERS | 7 +++ include/asm-generic/global_data.h | 2 +- include/{membuff.h => membuf.h} | 0 lib/Makefi

[PATCH 1/8] membuff: Rename functions to have membuf_ prefix

2024-10-17 Thread Simon Glass
The double 'f' is not necessary and is a bit annoying as elsewhere in U-Boot we use 'buf'. Rename all the functions before it is used more widely. Signed-off-by: Simon Glass --- boot/bootmeth_extlinux.c| 6 +-- common/console.c| 32 ++--- drivers/serial/sandbox.

[PATCH 0/8] membuff: Add tests and update to support a flag for empty/full

2024-10-17 Thread Simon Glass
The membuff implementation curently has no tests. It also assumes that head and tail can never correspond unless the buffer is empty. This series provides a compile-time flag to support a 'full' flag. It also adds some tests of the main routines. The data structure is also renamed to membuf which

[PATCH 1/1] cmd: upl: correct printf code

2024-10-17 Thread Heinrich Schuchardt
Building on 32-bit results in a build failure: cmd/upl.c:75:51: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘size_t’ {aka ‘unsigned int’} [-Wformat=] 75 | printf("UPL handoff written to %lx size %lx\n", addr, abuf_size(&buf));

Re: [PATCH v2 0/4] Cleanup dma device in spl and move dma channel[0]

2024-10-17 Thread Tom Rini
On Wed, 09 Oct 2024 20:26:59 +0530, Prasanth Babu Mantena wrote: > The channel allocation and deallocation for dma copy was happening on every > dma transfer. This is a overhead for transactions like NAND, which does > page reads recursively for complete data. > > So, moving the dma allocation to

Re: [PATCH] arm: dts: k3-j722s-binman: Add support for HS-SE

2024-10-17 Thread Tom Rini
On Wed, 09 Oct 2024 16:34:47 +0530, Jayesh Choudhary wrote: > J722S SOC have two variants as HS-FS and HS-SE. > Add binman support for HS-SE variant. > > Applied to u-boot/master, thanks! -- Tom

Re: [PATCH] arm: mach-k3: j784s4: Add clk and power support for wkup_uart

2024-10-17 Thread Tom Rini
On Mon, 07 Oct 2024 16:37:09 +0530, Bhavya Kapoor wrote: > Add clk and device data which can be used by wkup_uart driver > to configure clocks and PSC. > > Applied to u-boot/master, thanks! -- Tom

Re: [PATCH v1 1/1] cmd: irq: Move do_irqinfo() prototype to a header file

2024-10-17 Thread Tom Rini
On Sat, 05 Oct 2024 22:14:29 +0300, Andy Shevchenko wrote: > Move do_irqinfo() prototype to a header file, otherwise compiler is not > happy: > > arch/x86/lib/interrupts.c:130:5: warning: no previous prototype for > ‘do_irqinfo’ [-Wmissing-prototypes] > > Applied to u-boot/master, thanks!

Re: [PATCH] arm: mach-k3: am62: fixup thermal cooling device cpus

2024-10-17 Thread Tom Rini
On Wed, 02 Oct 2024 09:41:33 +0200, Parth Pancholi wrote: > AM62x devices now support CPU throttling based on thermal alerts > with a Linux commit 10e7bfd8114c ("arm64: dts: ti: k3-am62: Enable > CPU freq throttling on thermal alert"). However, this functionality > does not work correctly across a

Re: [PATCH] lib: fdtdec: Parse the gzip/lzo headers only when dependencies have met

2024-10-17 Thread Tom Rini
On Tue, 01 Oct 2024 10:56:47 +0100, Prabhakar wrote: > It might happen that CONFIG_GZIP and CONFIG_LZO are enabled but we might > have CONFIG_MULTI_DTB_FIT_LZO enabled in this case in the code path of > uncompress_blob() we parse the gzip headers first which results in > `Error: Bad gzipped data`

Re: [PATCH] Extend usage for OF_OVERLAY_LIST beyond SPL

2024-10-17 Thread Tom Rini
On Mon, 30 Sep 2024 12:20:36 +0200, Jan Kiszka wrote: > Allow to use OF_OVERLAY_LIST also for the case that the overlays just > need be built, e.g. when they will be picked up by binman as artifacts > of the final U-Boot image. The IOT2050 boards have such a need when > switching to OF_UPSTREAM. >

[PATCH 3/3] block: make blk_create_device() static

2024-10-17 Thread Heinrich Schuchardt
There are no users of the blk_create_device() function outside the uclass. Let's make it static. This will ensure that new block drivers will use blk_create_devicef(). Signed-off-by: Heinrich Schuchardt --- drivers/block/blk-uclass.c | 19 --- include/blk.h | 17

[PATCH 2/3] efi_driver: use blk_create_devicef()

2024-10-17 Thread Heinrich Schuchardt
The EFI block device driver is the only user of blk_create_device() outside the block device uclass. Use blk_create_devicef() instead like other block device drivers. Signed-off-by: Heinrich Schuchardt --- lib/efi_driver/efi_block_device.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletio

[PATCH 1/3] rockchip: block: simplify rkmtd driver

2024-10-17 Thread Heinrich Schuchardt
By using blk_create_devicef() instead of blk_create_devicef() the driver can be simplified and brought into line with other block device drivers. Signed-off-by: Heinrich Schuchardt --- drivers/block/rkmtd.c | 21 ++--- 1 file changed, 2 insertions(+), 19 deletions(-) diff --git

[PATCH 0/3] block: make blk_create_device() static

2024-10-17 Thread Heinrich Schuchardt
There should be a defined interface between block devices drivers and the block class layer. Most drivers already use blk_create_devicef() to generate block devices. The EFI block device driver and the Rockchip rkmtd driver are the exceptions. * Convert the remaining drivers to use blk_create_devi

[PATCH v2 2/2] sandbox: add bootmethod EFI boot-manager

2024-10-17 Thread Heinrich Schuchardt
The EFI boot-manager is the default method to boot EFI binaries. We should be able to use it on the Sandbox. * Enable EFI boot-manager bootmethod on the sandbox. * Adjust unit tests to reflect the additional boot method. Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass Reviewed-by: M

[PATCH v2 1/2] efi_loader: reduce noisiness if ESP is missing

2024-10-17 Thread Heinrich Schuchardt
EFI variables can be stored in a file on the EFI system partition. If that partition is missing we are writing two error messages per variable. This is too noisy. Just warn once about the missing ESP. Signed-off-by: Heinrich Schuchardt --- v2: new patch --- lib/efi_loader/efi_var_file.c

[PATCH v2 0/2] sandbox: add bootmethod EFI boot-manager

2024-10-17 Thread Heinrich Schuchardt
The EFI boot-manager is the default method to boot EFI binaries. We should be able to use it on the Sandbox. * Enable EFI boot-manager bootmethod on the sandbox. * Adjust unit tests to reflect the additional boot method. * Reduce the noisyness of the EFI sub-system if not ESP is available. v2:

RE: [PATCH V2] cpu: imx8_cpu: Avoid revision to corrupt device tree

2024-10-17 Thread Peng Fan
> Subject: Re: [PATCH V2] cpu: imx8_cpu: Avoid revision to corrupt > device tree > > On Thu, Oct 17, 2024 at 4:08 AM Peng Fan (OSS) > wrote: > > > > From: Peng Fan > > > > U-Boot device tree is padded just after U-Boot proper. > > After the whole stuff loaded to DRAM space, the device tree area

Re: [PATCH 1/1] sandbox: add bootmethod EFI boot-manager

2024-10-17 Thread Heinrich Schuchardt
On 10/18/24 01:23, Simon Glass wrote: Hi Heinrich, On Fri, 11 Oct 2024 at 08:27, Mattijs Korpershoek wrote: Hi Heinrich, Thank you for the patch. On mer., oct. 09, 2024 at 00:32, Heinrich Schuchardt wrote: The EFI boot-manager is the default method to boot EFI binaries. We should be abl

Re: [PATCH v6 06/12] efi: Use the same filename for all sandbox builds

2024-10-17 Thread Tom Rini
On Thu, Oct 17, 2024 at 05:23:19PM -0600, Simon Glass wrote: > Hi Heinrich, > > On Mon, 30 Sept 2024 at 17:23, Heinrich Schuchardt wrote: > > > > On 26.09.24 23:59, Simon Glass wrote: > > > Sandbox is not a real architecture, but within U-Boot it is real enough. > > > We should not need to preten

Re: [PATCH v4 0/5] Adjust initial EFI memory-allocation to be in the U-Boot region

2024-10-17 Thread Tom Rini
On Thu, Oct 17, 2024 at 05:22:52PM -0600, Simon Glass wrote: > Hi Ilias, > > On Tue, 15 Oct 2024 at 07:32, Ilias Apalodimas > wrote: > > > > On Tue, 15 Oct 2024 at 16:26, Simon Glass wrote: > > > > > > Hi Ilias, > > > > > > On Mon, 14 Oct 2024 at 22:28, Ilias Apalodimas > > > wrote: > > > > > >

[PATCH v4 0/8] bootstd: sunxi: Migrate to standard boot

2024-10-17 Thread Simon Glass
This series attempts to migrate all sunxi boards to use standard boot, along with a text environment. Changes in v4: - Reword Kconfig - Add a name for the bootflow - Drop UUID_GPT_SYSTEM and UUID_GPT_ESP definitions - Drop special case for ARM64's devicetree subdir - Drop unwanted quotations and i

[PATCH 00/34] bootstd: Support recording images

2024-10-17 Thread Simon Glass
This series provides a way to keep track of the images used in bootstd, including the type of each image. At present this is sort-of handled by struct bootflow but in quite an ad-hoc way. The structure has become quite large and is hard to query. Future work will be able to reduce its size. Ultim

[PATCH v4 8/8] sunxi: Move to text environment

2024-10-17 Thread Simon Glass
Convert these boards to use a text environment. For the boards check, the only differences are extra spaces after the semicolons in 'dfu_alt_info_ram' and 'partitions', both of which are permitted. Add in the special boot command for old kernels, dropping the unnecessary and confusing hex prefixe

[PATCH v4 7/8] env: Provide a work-around for unquoting fdtfile

2024-10-17 Thread Simon Glass
Some boards use a CONFIG option to specify the value of this variable. This is normally handled by efi_get_distro_fdt_name() but in the case of sunxi this does not work, since 'soc' is sunxi, but the files are in the allwinner directory. Provide a work-around for this particular case. Signed-off-

[PATCH v4 6/8] sunxi: Drop old distro boot variables

2024-10-17 Thread Simon Glass
These are not needed as bootstd handles the boot now. Drop them. Keep BOOTCMD_SUNXI_COMPAT for now since it does not relate to distro boot. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Keep BOOTCMD_SUNXI_COMPAT include/configs/sunxi-common.h | 75 +---

[PATCH v4 5/8] sunxi: Move to bootstd

2024-10-17 Thread Simon Glass
Drop support for distroboot and move to using bootstd instead. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Convert the other DISTRO_DEFAULTS in the Kconfig too arch/arm/Kconfig | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/Kc

[PATCH v4 4/8] sunxi: Add a bootmeth for FEL

2024-10-17 Thread Simon Glass
Add support for booting from a script loaded over FEL. This mirrors the bootcmd_fel provided by distro boot. Signed-off-by: Simon Glass Reviewed-by: Mattijs Korpershoek --- Changes in v4: - Reword Kconfig - Add a name for the bootflow Changes in v2: - Put the FEL bootmeth before all other glob

[PATCH v4 3/8] bootstd: Avoid depending on BLK

2024-10-17 Thread Simon Glass
In principle bootstd can work without block devices, even if it does require driver model to be enabled in that case. The use of a 'depends on BLK' for BOOTSTD conflicts with the way 'BLK' is now defined, producing recursive errors through multiple different paths, one of which is this (with Links

[PATCH v4 2/8] bootstd: Avoid calling unavailable block functions

2024-10-17 Thread Simon Glass
When BLK is not enabled but BOOTSTD is, some features of standard boot become unavailable. Add a check for this in the only site that is currently apparent. Signed-off-by: Simon Glass --- (no changes since v1) boot/bootdev-uclass.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/boot/bo

[PATCH v4 1/8] blk: Make functions available unconditionally

2024-10-17 Thread Simon Glass
Some boards still don't enable BLK but we want to be able to at least compile the code which relies on this. For example, bootstd includes calls to blk_...() functions, albeit with a check for BLK so that the code is eliminated by the compiler. Reduce the scope of the BLK #ifdef to help with this.

[PATCH 34/34] bootstd: Add a simple command to list images

2024-10-17 Thread Simon Glass
Add a new 'bootstd images' command, which lists the images which have been loaded. Update some existing tests to use it. Provide some documentation about images in general and this command in particular. Use a more realistic kernel command-line to make the test easier to follow. Signed-off-by: S

[PATCH 33/34] bootstd: Update cros bootmeth to record images

2024-10-17 Thread Simon Glass
Record images loaded by this bootmeth. Signed-off-by: Simon Glass --- boot/bootmeth_cros.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/boot/bootmeth_cros.c b/boot/bootmeth_cros.c index 3e60fd5da07..10aefe046ca 100644 --- a/boot/bootmeth_cros.c +++ b/boot/

[PATCH 32/34] bootstd: Avoid showing an invalid buffer address

2024-10-17 Thread Simon Glass
When the buffer address is not set, say so, rather than showing an address which looks very strange, on sandbox. Signed-off-by: Simon Glass --- cmd/bootflow.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/cmd/bootflow.c b/cmd/bootflow.c index 3e9769e0d42..1c1146ce11e

[PATCH 31/34] Update bootmeth_alloc_other() to record images

2024-10-17 Thread Simon Glass
Update this function to add the image to the list. Signed-off-by: Simon Glass --- boot/bootmeth-uclass.c | 15 ++- boot/bootmeth_script.c | 4 ++-- include/bootmeth.h | 3 ++- 3 files changed, 18 insertions(+), 4 deletions(-) diff --git a/boot/bootmeth-uclass.c b/boot/bootmet

[PATCH 30/34] boot: Update pxe bootmeth to record images

2024-10-17 Thread Simon Glass
Record images loaded by this bootmeth. Signed-off-by: Simon Glass --- boot/bootmeth_pxe.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/boot/bootmeth_pxe.c b/boot/bootmeth_pxe.c index 0643d280f21..3e5008ab317 100644 --- a/boot/bootmeth_pxe.c +++ b/boot/bootm

[PATCH 29/34] boot: Update extlinux pxe_getfile_func() to include type

2024-10-17 Thread Simon Glass
Add a file-type parameter to this function and update all users. Add a proper comment to the function which we are here. This will allow tracking of the file types loaded by the extlinux bootmeth. Signed-off-by: Simon Glass --- boot/bootmeth_extlinux.c | 5 +++-- boot/bootmeth_pxe.c | 5

[PATCH 28/34] efi: Check the filename-allocation in the network path

2024-10-17 Thread Simon Glass
If the filename cannot be set we should give up. Add the missing error check. Signed-off-by: Simon Glass --- boot/bootmeth_efi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/boot/bootmeth_efi.c b/boot/bootmeth_efi.c index e1e378481b9..548d5f71b2a 100644 --- a/boot/bootmeth_efi.c +++ b/

[PATCH 27/34] bootmeth: Update the read_file() method to include a type

2024-10-17 Thread Simon Glass
We want to record the type of each file which is loaded. Add an new parameter for this, to the read_file() method. Update all users. Make bootmeth_common_read_file() store information about the image that is read. Signed-off-by: Simon Glass --- boot/bootmeth-uclass.c | 22 +++

[PATCH 26/34] efi: Simplify reading files by using the common function

2024-10-17 Thread Simon Glass
The efiload_read_file() does similar things to a common function, so update it to use that instead. Signed-off-by: Simon Glass --- boot/bootmeth_efi.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/boot/bootmeth_efi.c b/boot/bootmeth_efi.c index 2ad6d3b4ace..f3d

[PATCH 25/34] boot: pxe: Drop the duplicate comment on get_pxe_file()

2024-10-17 Thread Simon Glass
This function is exported, so document it in the header file. Drop the duplicate comment in the C file. Signed-off-by: Simon Glass --- boot/pxe_utils.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/boot/pxe_utils.c b/boot/pxe_utils.c index d6a4b2cb859..4fd26524286 100644 --- a/

[PATCH 24/34] bootstd: Update bootmeth_alloc_file() to record images

2024-10-17 Thread Simon Glass
As a first step to recording images and where they came from, update this function to do so, since it is used by two bootmeths Signed-off-by: Simon Glass --- boot/bootmeth-uclass.c | 17 - boot/bootmeth_extlinux.c | 2 +- boot/bootmeth_script.c | 3 ++- include/bootmeth.h

[PATCH 23/34] bootstd: Maintain a list of images

2024-10-17 Thread Simon Glass
We want to keep track of images which are loaded, or those which could perhaps be loaded. This will make it easier to manage memory allocation, as well as permit removal of the EFI set_efi_bootdev() hack. Add a list of these, attached to the bootflow. For now the list is empty. Signed-off-by: Sim

[PATCH 22/34] bootstd: cros: Correct the x86-setup address

2024-10-17 Thread Simon Glass
This should really use an address rather than the buffer. Update it in the command. Signed-off-by: Simon Glass --- cmd/bootflow.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cmd/bootflow.c b/cmd/bootflow.c index 5f656814b29..3e9769e0d42 100644 --- a/cmd/bootflow.c +++

[PATCH 21/34] test: boot: Update bootflow_iter() for console checking

2024-10-17 Thread Simon Glass
This test checks console output so should have the UTF_CONSOLE flag. Add it. Signed-off-by: Simon Glass --- test/boot/bootflow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/boot/bootflow.c b/test/boot/bootflow.c index 8ea284098e7..efb82ee628b 100644 --- a/test/boot/

[PATCH 20/34] test: Drop the duplicate line in setup_bootmenu_image()

2024-10-17 Thread Simon Glass
The mkimage call is done twice. Remove the duplicate. Signed-off-by: Simon Glass --- test/py/tests/test_ut.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/test/py/tests/test_ut.py b/test/py/tests/test_ut.py index 39aa1035e34..9166c8f6b6e 100644 --- a/test/py/tests/test_ut.py +++ b/test/

[PATCH 19/34] test: Expand implementation of ut_list_has_dm_tests()

2024-10-17 Thread Simon Glass
This function assumes that all tests in a suite are being run. This means that it can sometimes call dm_test_restore() when it should not. The impact of this is that it is not possible, for example, to run 'ut bootstd bootflow_cros' and then check the state of bootstd afterwards, since all devices

[PATCH 18/34] image: Add a new type for a command-line string

2024-10-17 Thread Simon Glass
Some bootmeths package a commandline into the bootflow. Add support for this as a file type. Signed-off-by: Simon Glass --- boot/image.c| 1 + include/image.h | 1 + 2 files changed, 2 insertions(+) diff --git a/boot/image.c b/boot/image.c index eaba9eb4332..f75b1e7841c 100644 --- a/boot/i

[PATCH 17/34] image: Add a new type for logo images

2024-10-17 Thread Simon Glass
Add an image type for logo images, which U-Boot supports reading within the PXE code. Signed-off-by: Simon Glass --- boot/image.c| 1 + include/image.h | 1 + 2 files changed, 2 insertions(+) diff --git a/boot/image.c b/boot/image.c index b13644b03dc..eaba9eb4332 100644 --- a/boot/image.c

[PATCH 16/34] image: Add a new type for EFI apps

2024-10-17 Thread Simon Glass
Add an image type for EFI applications, which U-Boot supports reading. Signed-off-by: Simon Glass --- boot/image.c| 1 + include/image.h | 1 + 2 files changed, 2 insertions(+) diff --git a/boot/image.c b/boot/image.c index cf16fb7fbf7..b13644b03dc 100644 --- a/boot/image.c +++ b/boot/imag

[PATCH 15/34] image: Add a new type for extlinux

2024-10-17 Thread Simon Glass
Add an image type for the extlinux.cfg file, which U-Boot supports reading. Signed-off-by: Simon Glass --- boot/image.c| 1 + include/image.h | 1 + 2 files changed, 2 insertions(+) diff --git a/boot/image.c b/boot/image.c index abac254e026..cf16fb7fbf7 100644 --- a/boot/image.c +++ b/boot

[PATCH 14/34] bootstd: Move the bootflow list into an alist

2024-10-17 Thread Simon Glass
Use an alist for this data structure as it is somewhat simpler to manage. This means that bootstd holds a simple list of bootflow structs and can drop it at will, without chasing down lists. Signed-off-by: Simon Glass --- boot/bootdev-uclass.c | 47 +-- b

[PATCH 13/34] bootstd: Drop the bootdev-specific list of bootflows

2024-10-17 Thread Simon Glass
This list is only used by two functions, which can be updated to iterate through the global list. Take this approach, which allows the bootdev list to be dropped. Overall this makes the code slightly more complicated, but will allow moving the bootflow list into an alist Signed-off-by: Simon Glas

[PATCH 12/34] bootstd: Add a function to get bootstd only if available

2024-10-17 Thread Simon Glass
Provide a function which is safe to call in the 'unbind' path, which returns the bootstd priv data if available. Signed-off-by: Simon Glass --- boot/bootstd-uclass.c | 11 +++ include/bootstd.h | 17 + 2 files changed, 28 insertions(+) diff --git a/boot/bootstd-ucla

[PATCH 10/34] bootstd: Move bootflow-adding to bootstd

2024-10-17 Thread Simon Glass
This relates to more than just the bootdev, since there is a global list of bootflows. Move the function to the bootstd file and rename it. Signed-off-by: Simon Glass --- boot/bootdev-uclass.c | 25 - boot/bootstd-uclass.c | 25 + cmd/bootflow.c

[PATCH 11/34] bootstd: Move bootflow-clearing to bootstd

2024-10-17 Thread Simon Glass
This relates to more than just the bootdev, since there is a global list of bootflows. Move the function to the bootstd file and rename it. Signed-off-by: Simon Glass --- boot/bootdev-uclass.c | 19 +-- boot/bootstd-uclass.c | 15 +++ cmd/bootflow.c| 2 +- i

[PATCH 09/34] test: boot: Use a consistent name for the script bootmeth

2024-10-17 Thread Simon Glass
In the bootflow tests the script bootmeth is bound with the name bootmeth_script whereas the others have a name without the bootmeth_ prefix. Adjust it to be the same. Signed-off-by: Simon Glass --- test/boot/bootflow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/bo

[PATCH 08/34] dm: core: Add a function to see if a device exists

2024-10-17 Thread Simon Glass
All the uclass functions for finding a device end up creating a uclass if it doesn't exist. Add a function which instead returns NULL in this case. This is useful when in the 'unbind' path, since we don't want to undo any unbinding which has already happened. Signed-off-by: Simon Glass --- dri

[PATCH 07/34] alist: Add a way to efficiently filter an alist

2024-10-17 Thread Simon Glass
Unlike linked lists, it is inefficient to remove items from an alist, particularly if it is large. If most items need to be removed, then the time-complexity approaches O(n2). Provide a way to do this efficiently, by working through the alist once and copying elements down. Signed-off-by: Simon G

[PATCH 06/34] alist: Add a function to empty the list

2024-10-17 Thread Simon Glass
Sometimes it is useful to empty the list without de-allocating any of the memory used, e.g. when the list will be re-populated immediately afterwards. Add a new function for this. Signed-off-by: Simon Glass --- include/alist.h | 7 +++ lib/alist.c | 5 + test/lib/alist.c | 42 +

[PATCH 05/34] alist: Add for-loop helpers

2024-10-17 Thread Simon Glass
Add some macros which permit easy iteration through an alist, similar to those provided by the 'list' implementation. Signed-off-by: Simon Glass --- include/alist.h | 50 lib/alist.c | 7 + test/lib/alist.c | 74 +++

[PATCH 04/34] alist: Add a way to get the next element

2024-10-17 Thread Simon Glass
Add a new function which returns the next element after the one provided, if it exists in the list. Signed-off-by: Simon Glass --- include/alist.h | 34 +++ lib/alist.c | 21 +++ test/lib/alist.c | 52

[PATCH 03/34] alist: Expand the comment for alist_get()

2024-10-17 Thread Simon Glass
Add a better description for this macro. Signed-off-by: Simon Glass --- include/alist.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/include/alist.h b/include/alist.h index a727f1c7dfa..2c78ede201e 100644 --- a/include/alist.h +++ b/include/alist.h @@ -116,7 +116,12

[PATCH 02/34] alist: Add a comment for alist_init_struct()

2024-10-17 Thread Simon Glass
Comment this macro so that it is clear how to use it. Signed-off-by: Simon Glass --- include/alist.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/alist.h b/include/alist.h index 0343946bc4a..a727f1c7dfa 100644 --- a/include/alist.h +++ b/include/alist.h @@ -198,6 +198,12 @@

[PATCH 01/34] alist: Mention the error condition in alist_add_placeholder()

2024-10-17 Thread Simon Glass
Update the function comment to note that this function can return NULL if it runs out of memory. Signed-off-by: Simon Glass --- include/alist.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/alist.h b/include/alist.h index 68d268f01af..0343946bc4a 100644 --- a/

Please pull u-boot-dm

2024-10-17 Thread Simon Glass
Hi Tom, I have kept back some of the coreboot patches until the docker change is applied. It needs a newer version of coreboot. - Simon https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/22775 https://dev.azure.com/simon0972/u-boot/_build/results?buildId=69&view=results The followin

Re: [PATCH 1/4] serial: fix circular rx buffer edge case

2024-10-17 Thread Simon Glass
Hi Rasmus, On Wed, 9 Oct 2024 at 05:03, Rasmus Villemoes wrote: > > Simon Glass writes: > > > On Thu, 3 Oct 2024 at 08:10, Rasmus Villemoes wrote: > >> > >> drivers/serial/serial-uclass.c | 10 ++ > >> include/serial.h | 4 ++-- > >> 2 files changed, 8 insertions(+), 6 d

Re: [PATCH] binman: Add option for pointing to external description

2024-10-17 Thread Simon Glass
Hi Michal, On Wed, 16 Oct 2024 at 00:00, Michal Simek wrote: > > Hi Simon, > > On 10/15/24 14:48, Simon Glass wrote: > > Hi Michal, > > > > On Thu, 10 Oct 2024 at 07:03, Michal Simek wrote: > >> > >> > >> > >> On 10/9/24 23:14, Simon Glass wrote: > >>> Hi Michal, > >>> > >>> On Wed, 9 Oct 2024 a

Re: [PATCH 1/1] sandbox: add bootmethod EFI boot-manager

2024-10-17 Thread Simon Glass
Hi Heinrich, On Fri, 11 Oct 2024 at 08:27, Mattijs Korpershoek wrote: > > Hi Heinrich, > > Thank you for the patch. > > On mer., oct. 09, 2024 at 00:32, Heinrich Schuchardt > wrote: > > > The EFI boot-manager is the default method to boot EFI binaries. > > We should be able to use it on the San

Re: [PATCH v6 06/12] efi: Use the same filename for all sandbox builds

2024-10-17 Thread Simon Glass
Hi Heinrich, On Mon, 30 Sept 2024 at 17:23, Heinrich Schuchardt wrote: > > On 26.09.24 23:59, Simon Glass wrote: > > Sandbox is not a real architecture, but within U-Boot it is real enough. > > We should not need to pretend it is x86 or ARM anywhere in the code. > > > > Also we want to be able to

Re: [PATCH v3 8/8] sunxi: Move to text environment

2024-10-17 Thread Simon Glass
Hi Andre, On Wed, 2 Oct 2024 at 18:46, Andre Przywara wrote: > > On Sun, 1 Sep 2024 16:27:34 -0600 > Simon Glass wrote: > > Hi Simon, > > > Convert these boards to use a text environment. > > > > For the boards check, the only differences are extra spaces after the > > semicolons in 'dfu_alt_in

Re: [PATCH v3 4/8] sunxi: Add a bootmeth for FEL

2024-10-17 Thread Simon Glass
Hi Andre, On Wed, 2 Oct 2024 at 12:03, Andre Przywara wrote: > > Hi Simon, > > On 01/09/2024 23:27, Simon Glass wrote: > > Add support for booting from a script loaded over FEL. This mirrors the > > bootcmd_fel provided by distro boot. > > > > Signed-off-by: Simon Glass > > Reviewed-by: Mattijs

Re: [PATCH v3 03/15] efi: memory: use the lmb API's for allocating and freeing memory

2024-10-17 Thread Simon Glass
Hi Tom, On Tue, 15 Oct 2024 at 13:05, Tom Rini wrote: > > On Tue, Oct 15, 2024 at 07:10:27AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 14 Oct 2024 at 17:07, Tom Rini wrote: > > > > > > On Mon, Oct 14, 2024 at 03:55:05PM -0600, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Mon

Re: [PATCH v4 0/5] Adjust initial EFI memory-allocation to be in the U-Boot region

2024-10-17 Thread Simon Glass
Hi Ilias, On Tue, 15 Oct 2024 at 07:32, Ilias Apalodimas wrote: > > On Tue, 15 Oct 2024 at 16:26, Simon Glass wrote: > > > > Hi Ilias, > > > > On Mon, 14 Oct 2024 at 22:28, Ilias Apalodimas > > wrote: > > > > > > Hi Simon, > > > > > > On Sat, 12 Oct 2024 at 00:23, Simon Glass wrote: > > > > >

Re: ll_entry_count returns 0 even though the linker list has 5 entries

2024-10-17 Thread Simon Glass
+U-Boot Mailing List On Thu, 17 Oct 2024 at 03:03, Osman wrote: > > Hello Simon, > > The problem is solved after enabling SPL_OPENSBI in my case, it would have > been better if I knew the reason for it but I can't see how the linker list > is related to opensbi configuration. Thank you for your

Re: [PATCH v9 24/37] common: Enable BLOBLIST_TABLES on arm

2024-10-17 Thread Simon Glass
Hi Patrick, On Wed, 16 Oct 2024 at 00:16, Patrick Rudolph wrote: > > Allow to use BLOBLIST_TABLES on arm to store ACPI or other tables. > > Signed-off-by: Patrick Rudolph > Cc: Tom Rini > --- > Changelog v9: > - default to BLOBLIST_ALLOC on arm > - Move default for BLOBLIST_SIZE_RELOC up > ---

Re: [PATCH v9 21/37] arm: lib: Add GICV2 driver

2024-10-17 Thread Simon Glass
On Wed, 16 Oct 2024 at 00:16, Patrick Rudolph wrote: > > Add a generic GICV2 driver that: > - parses the DT and generates the ACPI MADT subtables > - implement of_xlate() and allows irq_get_by_index() to return the > correct interrupt mappings > > Map DT interrupts to ARM GIC interrupts as follo

  1   2   3   >