U-Boot qemu_arm64_defconfig crashes under KVM

2024-10-08 Thread Ahmad Fatoum
Hi, This is a heads up that the U-Boot image generated by qemu_arm64_defconfig crashes during xhci-pci probe when running under KVM on a native ARM host: Bus xhci_pci: Register 8001040 NbrPorts 8 Starting the controller "Synchronous Abort" handler, esr 0x9610, far 0x10090040 elr:

Re: [PATCH 2/2] arm64: versal: Wire USB0 in distro boot

2024-10-08 Thread Michal Simek
On 10/9/24 03:56, Simon Glass wrote: Hi Michal, On Mon, 30 Sept 2024 at 05:05, Michal Simek wrote: For unknown reason USB host hasn't been described for distro boot that's why wire it now. Signed-off-by: Michal Simek --- include/configs/xilinx_versal.h | 7 +++ 1 file changed, 7

Re: [PATCH v2 2/3] arm64: dts: rockchip: Add Hardkernel ODROID-M1S

2024-10-08 Thread Sumit Garg
On Wed, 9 Oct 2024 at 01:36, Jonas Karlman wrote: > > The Hardkernel ODROID-M1S is a single-board computer based on Rockchip > RK3566 SoC. It features e.g. 4/8 GB LPDDR4 RAM, 64 GB eMMC, SD-card, > GbE LAN, HDMI 2.0, M.2 NVMe and USB 2.0/3.0. > > Add initial support for eMMC, SD-card, Ethernet, HD

Re: [PATCH v2 1/3] arm64: dts: rockchip: Correct vendor prefix for Hardkernel ODROID-M1

2024-10-08 Thread Sumit Garg
On Wed, 9 Oct 2024 at 01:36, Jonas Karlman wrote: > > The vendor prefix for Hardkernel ODROID-M1 is incorrectly listed as > rockchip. Use the proper hardkernel vendor prefix for this board, while > at it also drop the redundant soc prefix. > > Fixes: fd3583267703 ("arm64: dts: rockchip: Add Hardke

Re: [PATCH v3 3/3] mtd: nand: raw: atmel: Fix pulse read timing for certain NAND flashes

2024-10-08 Thread Balamanikandan.Gunasundar
On 30/09/24 1:37 pm, Alexander Dahl wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hello, > > Am Tue, May 28, 2024 at 12:32:44PM +0200 schrieb Alexander Dahl: >> Hei hei, >> >> Am Mon, Apr 15, 2024 at 09:57:55AM +0200 schrieb Alexander D

Re: [PATCH v8 05/27] sha1: Remove sha1 non-watchdog API

2024-10-08 Thread Tom Rini
On Fri, Oct 04, 2024 at 11:24:28AM -0400, Raymond Mao wrote: > Hi Rasmus, > > On Fri, 4 Oct 2024 at 03:50, Rasmus Villemoes > wrote: > > > Raymond Mao writes: > > > > > We don't need an API specially for non-watchdog since sha1_csum_wd > > > supports it by disabling CONFIG_HW_WATCHDOG and CONFI

Re: [PATCH v8 01/27] CI: Exclude MbedTLS subtree for CONFIG checks

2024-10-08 Thread Simon Glass
On Thu, 3 Oct 2024 at 15:51, Raymond Mao wrote: > > Since MbedTLS is an external repo with its own coding style, > exclude it from Azure and gitlab CI CONFIG checks. > > Signed-off-by: Raymond Mao > Reviewed-by: Tom Rini > Reviewed-by: Ilias Apalodimas > --- > Changes in v2 > - Initial patch. >

Re: [PATCH v8 00/27] Integrate MbedTLS v3.6 LTS with U-Boot

2024-10-08 Thread Simon Glass
On Thu, 3 Oct 2024 at 15:51, Raymond Mao wrote: > > Integrate MbedTLS v3.6 LTS (currently v3.6.0) with U-Boot. > > Motivations: > > > 1. MbedTLS is well maintained with LTS versions. > 2. LWIP is integrated with MbedTLS and easily to enable HTTPS. > 3. MbedTLS recently switched licens

Re: [PATCH] cmd: Make bootvx independent of bootelf

2024-10-08 Thread Tom Rini
On Tue, Oct 08, 2024 at 07:57:25PM -0600, Simon Glass wrote: > Hi, > > On Tue, 8 Oct 2024 at 07:45, Tom Rini wrote: > > > > On Sun, 29 Sep 2024 18:27:39 +0900, Daniel Palmer wrote: > > > > > There are lots of usecases for running baremetal ELF > > > binaries via bootelf but if you enable bootelf

Re: [PATCH 1/1] sandbox: add bootmethod EFI boot-manager

2024-10-08 Thread Simon Glass
On Tue, 8 Oct 2024 at 16:32, Heinrich Schuchardt wrote: > > The EFI boot-manager is the default method to boot EFI binaries. > We should be able to use it on the Sandbox. > > * Enable EFI boot-manager bootmethod on the sandbox. > * Adjust unit tests to reflect the additional boot method. > > Signe

Re: [PATCH v10 00/13] net: tcp: improve tcp support

2024-10-08 Thread Simon Glass
Hi Mikhail, On Mon, 7 Oct 2024 at 14:55, Mikhail Kshevetskiy wrote: > > U-Boot support of LWIP is not ready for a moment, but we already have > some kind of tcp support. Unfrotunately this support is really bad. spelling > > Some of the known issues: > * tcp packet from other connection can br

Re: [PATCH] cmd: Make bootvx independent of bootelf

2024-10-08 Thread Simon Glass
Hi, On Tue, 8 Oct 2024 at 07:45, Tom Rini wrote: > > On Sun, 29 Sep 2024 18:27:39 +0900, Daniel Palmer wrote: > > > There are lots of usecases for running baremetal ELF > > binaries via bootelf but if you enable bootelf you > > get bootvx as well and you probably don't want or need > > it. > > >

Re: [PATCH v2] Revert "mmc: dw_mmc: Extract FIFO data transfer into a separate routine"

2024-10-08 Thread Simon Glass
On Tue, 8 Oct 2024 at 13:18, Jonas Karlman wrote: > > The commit 0252924ac6d4 ("mmc: dw_mmc: Extract FIFO data transfer into a > separate routine") unintentionally changed behavior of the FIFO data > transfer routine. > > When data is read and size reaches 0 the original loop would wait on > DWMCI

Re: [PATCH] test: Fix skip check for sleep command test

2024-10-08 Thread Simon Glass
On Tue, 8 Oct 2024 at 06:09, Andrew Goodbody wrote: > > When the config option CMD_MISC was renamed to CMD_SLEEP the check > in the test for the sleep command was not updated. Do that now. > > Fixes: 16060854095 ("cmd: Rename CMD_MISC to CMD_SLEEP") > Signed-off-by: Andrew Goodbody > --- > > tes

Re: [PATCH] net: wget: check strict_strtoul() return value

2024-10-08 Thread Simon Glass
On Tue, 8 Oct 2024 at 03:47, Jerome Forissier wrote: > > Check the return value of strict_strtoul() when processing the > Content-Length header as recommended by Coverity [1]. > > [1] https://lists.denx.de/pipermail/u-boot/2024-October/567050.html > > Reported-by: Coverity (CID 510464) > Signed-of

Re: [PATCH v4 2/2] binman: add fast authentication method for i.MX8M signing

2024-10-08 Thread Simon Glass
On Tue, 1 Oct 2024 at 07:58, Brian Ruley wrote: > > Using the PKI tree with SRKs as intermediate CA isn't necessary or even > desirable in some situations (boot time, for example). Add the possibility > to use the "fast authentication" method where the image and CSF are both > signed using the SRK

Re: [PATCH v3 4/6] cmd: bcb: introduce 'ab_dump' command to print BCB block content

2024-10-08 Thread Simon Glass
On Tue, 8 Oct 2024 at 14:18, Dmitry Rokosov wrote: > > It's really helpful to have the ability to dump BCB block for debugging > A/B logic on the board supported this partition schema. > > Command 'bcb ab_dump' prints all fields of bootloader_control struct > including slot_metadata for all presen

Re: [PATCH v3 1/2] binman: cosmetic: code formatting fixes

2024-10-08 Thread Simon Glass
Hi Brian, On Mon, 7 Oct 2024 at 06:33, Brian Ruley wrote: > > On Wed, Oct 02, 2024 at 04:55:30PM -0600, Simon Glass wrote: > > > > Hi Brian, > > > > On Wed, 2 Oct 2024 at 00:41, Brian Ruley > > wrote: > > > > > > On Mon, Sep 30, 2024 at 12:52:24PM -0600, Simon Glass wrote: > > > > > > > > WARNI

Re: [PATCH v4 0/7] Add AVS support for J721S2

2024-10-08 Thread Simon Glass
Hi Manorit, On Mon, 7 Oct 2024 at 22:48, Manorit Chawdhry wrote: > > Hi Simon, > > On 09:23-20241007, Simon Glass wrote: > > Hi Manorit, > > > > On Fri, 4 Oct 2024 at 00:24, Manorit Chawdhry wrote: > > > > > > This series adds support for AVS on J721S2. > > > > What is AVS? You should write an a

Re: [PATCH v1] arm: global_data: add scmi pointer

2024-10-08 Thread Simon Glass
Hi Peng, On Mon, 7 Oct 2024 at 20:59, Peng Fan wrote: > > > Subject: Re: [PATCH v1] arm: global_data: add scmi pointer > > > > On Sun, Oct 06, 2024 at 05:52:28PM +0800, alice@oss.nxp.com > > wrote: > > > From: Peng Fan > > > > > > Add scmi device and channel pointer for i.MX9. > > > > > > Si

Re: [PATCH v3 2/6] treewide: bcb: move ab_select command to bcb subcommands

2024-10-08 Thread Simon Glass
On Tue, 8 Oct 2024 at 14:18, Dmitry Rokosov wrote: > > To enhance code organization, it is beneficial to consolidate all A/B > BCB management routines into a single super-command. > The 'bcb' command is an excellent candidate for this purpose. > > This patch integrates the separate 'ab_select' com

Re: [PATCH v1 1/1] cmd: irq: Move do_irqinfo() prototype to a header file

2024-10-08 Thread Simon Glass
On Sat, 5 Oct 2024 at 13:14, Andy Shevchenko wrote: > > Move do_irqinfo() prototype to a header file, otherwise compiler is not > happy: > > arch/x86/lib/interrupts.c:130:5: warning: no previous prototype for > ‘do_irqinfo’ [-Wmissing-prototypes] > > Signed-off-by: Andy Shevchenko > --- > cmd

Re: [PATCH v1 2/4] x86: cpu: Mark a few functions static

2024-10-08 Thread Simon Glass
On Sat, 5 Oct 2024 at 13:14, Andy Shevchenko wrote: > > Some functions are not used anywhere except the same file > where they are defined. Mark them static. This helps avoiding > the compiler warnings: > > arch/x86/cpu/cpu.c:343:6: warning: no previous prototype for > ‘detect_coreboot_table_at

Re: [PATCH v1 1/4] x86: cpu: Use default print_cpuinfo() for all

2024-10-08 Thread Simon Glass
On Sat, 5 Oct 2024 at 13:14, Andy Shevchenko wrote: > > Most of the copies of the print_cpuinfo() call the default method. > Remove all of those in order to have only the default one when > no `cpu` command is compiled. > > This also helps avoiding compiler warning, e.g.: > > arch/x86/cpu/tangie

Re: modify live DT with OF_LIVE breaking phy_connect?

2024-10-08 Thread Simon Glass
Hi Tim, On Mon, 7 Oct 2024 at 14:16, Tim Harvey wrote: > > Greetings, > > I have a need to adjust the U-Boot device-tree live with some board > revision specific fixups. It would seem I need to enable OF_LIVE to do > so but when I do this on imx8mm U-Boot proper seems to fail > phy_connect() call

Re: [PATCH 2/2] arm64: versal: Wire USB0 in distro boot

2024-10-08 Thread Simon Glass
Hi Michal, On Mon, 30 Sept 2024 at 05:05, Michal Simek wrote: > > For unknown reason USB host hasn't been described for distro boot that's > why wire it now. > > Signed-off-by: Michal Simek > --- > > include/configs/xilinx_versal.h | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a

Re: [PATCH 10/13] i2c: rzg2l: include u-boot/schedule.h

2024-10-08 Thread Simon Glass
On Thu, 3 Oct 2024 at 15:29, Rasmus Villemoes wrote: > > This TU currently relies on getting a declaration of schedule() > through some nested include. Include the proper header directly. > > Signed-off-by: Rasmus Villemoes > --- > drivers/i2c/rz_riic.c | 1 + > 1 file changed, 1 insertion(+) >

Re: [PATCH v1 3/4] x86: cpu: Add a few prototypes to the header file

2024-10-08 Thread Simon Glass
On Sat, 5 Oct 2024 at 13:14, Andy Shevchenko wrote: > > The compiler is not happy to have no prototypes for the functions that > are not defined static. Add them. This helps avoiding the compiler warnings: > > arch/x86/cpu/cpu.c:197:13: warning: no previous prototype for > ‘board_final_init’ [-

Re: [PATCH] binman: Add option for pointing to external description

2024-10-08 Thread Simon Glass
Hi Michal, On Mon, 7 Oct 2024 at 07:05, Michal Simek wrote: > > Adding binman node with target images description can be unwanted feature > but as of today there is no way to disable it. > Also on size constrained systems it is not useful to add binman description > to DTB. > Introduce BINMAN_EXT

Re: [PATCH 3/3] ARM: dts: stm32: Generate u-boot.itb using binman on DH STM32 DHSOM

2024-10-08 Thread Simon Glass
On Fri, 4 Oct 2024 at 16:59, Marek Vasut wrote: > > Describe the u-boot.its generation in stm32mp15xx-dhsom-u-boot.dtsi > binman {} DT node as a replacement for current CONFIG_SPL_FIT_SOURCE > use, dispose of both u-boot-dhcom.its and u-boot-dhcor.its. > > Use fdt-SEQ/config-SEQ to generate a list

Re: [PATCH v11 04/29] sandbox: add dummy driver ETH_SANDBOX_LWIP

2024-10-08 Thread Simon Glass
On Thu, 3 Oct 2024 at 09:23, Jerome Forissier wrote: > > Introduce ETH_SANDBOX_LWIP which enables a mock driver similar to > ETH_SANDOX but without the dependencies on the legacy network stack > (NET) so that it may be enabled when the lwIP stack (NET_LWIP) is > introduced. The driver does nothing

Re: [PATCH] WIP: binman: expand test coverage to nxpimx8mcst

2024-10-08 Thread Simon Glass
Hi Brian, On Mon, 7 Oct 2024 at 07:02, Brian Ruley wrote: > > Add coverage for IMX8M code siging. Create PKI tree and other assets > required by `cst' using `hab4_pki_tree.sh' script in `cst_3.4.1' [1]. > > [1] https://www.nxp.com/webapp/Download?colCode=IMX_CST_TOOL_NEW > > Signed-off-by: Brian

Re: [PATCH v1 4/4] x86: cpu: Add missing header inclusion

2024-10-08 Thread Simon Glass
On Sat, 5 Oct 2024 at 13:14, Andy Shevchenko wrote: > > Without asm/cpu_x86.h inclusion a compiler is not happy: > > arch/x86/cpu/cpu_x86.c:14:5: warning: no previous prototype for > ‘cpu_x86_bind’ [-Wmissing-prototypes] > arch/x86/cpu/cpu_x86.c:29:5: warning: no previous prototype for > ‘cp

Re: [PATCH 09/13] lib/sha*: include u-boot/schedule.h instead of cyclic.h

2024-10-08 Thread Simon Glass
On Thu, 3 Oct 2024 at 15:29, Rasmus Villemoes wrote: > > These library routines obviously do not make use of the > cyclic_register() etc. API, but do need to call schedule(). Include > the proper header. > > Eventually, their ifdef logic should be updated to avoid talking about > CONFIG_WATCHDOG.

Re: [PATCH 08/13] watchdog.h: change include of cyclic.h to u-boot/schedule.h

2024-10-08 Thread Simon Glass
On Thu, 3 Oct 2024 at 15:29, Rasmus Villemoes wrote: > > Nobody relies on getting the cyclic API declared by including the > watchdog.h header, but for historical reasons, many TUs include > watchdog.h to get a declaration of schedule(). Now that we have a > dedicated header for just that, include

Re: [PATCH 07/13] cyclic: make cyclic_run static

2024-10-08 Thread Simon Glass
On Thu, 3 Oct 2024 at 15:29, Rasmus Villemoes wrote: > > The only caller left is schedule(); everybody outside cyclic.c now > calls or references schedule(). > > Signed-off-by: Rasmus Villemoes > --- > common/cyclic.c | 2 +- > include/cyclic.h | 12 > 2 files changed, 1 insertion

Re: [PATCH 06/13] test: dm: wdt: replace cyclic_run() by schedule()

2024-10-08 Thread Simon Glass
On Thu, 3 Oct 2024 at 15:29, Rasmus Villemoes wrote: > > This is the last place outside of cyclic.c that references > cyclic_run() directly. Replace by schedule(), so that cyclic_run() can > be made private. This also better matches what I believe commit > 29caf9305b6f ("cyclic: Use schedule() ins

Re: [PATCH 05/13] fs/cramfs: use schedule instead of cyclic_run as callback

2024-10-08 Thread Simon Glass
On Thu, 3 Oct 2024 at 15:29, Rasmus Villemoes wrote: > > Prior to commit 29caf9305b6f ("cyclic: Use schedule() instead of > WATCHDOG_RESET()") we had > > /* Currently only needed for fs/cramfs/uncompress.c */ > static inline void watchdog_reset_func(void) > { >WATCHDOG_RESET(); > } > > and

Re: [PATCH 03/13] led: include cyclic.h in led_sw_blink.c

2024-10-08 Thread Simon Glass
On Thu, 3 Oct 2024 at 15:28, Rasmus Villemoes wrote: > > This makes use of the cyclic API but relies on implicitly getting the > appropriate declarations through some nested include. Include the > cyclic.h header directly. > > Signed-off-by: Rasmus Villemoes > --- > drivers/led/led_sw_blink.c |

Re: [PATCH 02/13] cyclic: introduce u-boot/schedule.h

2024-10-08 Thread Simon Glass
On Thu, 3 Oct 2024 at 15:28, Rasmus Villemoes wrote: > > I noticed an "unnecessary" include of in > global_data.h, in the sense that nothing in cyclic.h is needed in > order to define 'struct global_data'. > > Well, it's not unnecessary, as it implicitly ensures that everybody > gets a declaratio

Re: [PATCH 01/13] doc: cyclic: remove reference to WATCHDOG_RESET

2024-10-08 Thread Simon Glass
On Thu, 3 Oct 2024 at 15:28, Rasmus Villemoes wrote: > > WATCHDOG_RESET is no more. Replace the reference by schedule(). > > While here, rearrange the sentence a bit so that "cyclic_run()" > becomes the object and "the main function responsible for calling all > registered cyclic functions" a pare

Re: [PATCH] sandbox: dts: Add missing sandbox, emul phandle to sandbox-pmic

2024-10-08 Thread Simon Glass
On Sat, 5 Oct 2024 at 08:34, Marek Vasut wrote: > > This phandle was missing in the sandbox DT, add it, otherwise sandbox-i2c > driver cannot look up the emulator via i2c_emul_find(). This fixes the > following i2c_emul_find() error: > > " > $ ./u-boot -Dc "" > ... >i2c_emul_find() No emul

Re: [PATCH 11/13] ddr: altera: include u-boot/schedule.h

2024-10-08 Thread Simon Glass
On Thu, 3 Oct 2024 at 15:30, Rasmus Villemoes wrote: > > These TUs currently rely on getting a declaration of schedule() > through some nested include. Include the proper header directly. > > Signed-off-by: Rasmus Villemoes > --- > drivers/ddr/altera/sdram_n5x.c | 1 + > drivers/ddr/altera/sdr

Re: [PATCH 12/13] boot: cedit: include u-boot/schedule.h

2024-10-08 Thread Simon Glass
On Thu, 3 Oct 2024 at 15:30, Rasmus Villemoes wrote: > > This TU currently relies on getting a declaration of schedule() > through some nested include. Include the proper header directly. > > Signed-off-by: Rasmus Villemoes > --- > boot/cedit.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed

Re: [PATCH 3/4] serial: add build-time sanity check of CONFIG_SERIAL_RX_BUFFER_SIZE

2024-10-08 Thread Simon Glass
On Thu, 3 Oct 2024 at 08:11, Rasmus Villemoes wrote: > > The help text says it must be a power of 2, and the implementation > does rely on that. Enforce it. > > A violation gives a wall of text, but the last few lines should be > reasonably obvious: > > drivers/serial/serial-uclass.c:334:9: note:

Re: [PATCH v11 01/29] net: recv(): return -EAGAIN instead of 0 when no cleanup is expected

2024-10-08 Thread Simon Glass
On Thu, 3 Oct 2024 at 09:23, Jerome Forissier wrote: > > Note: patch posted separately [0]. > > [0] > http://patchwork.ozlabs.org/project/uboot/patch/20240927142038.879037-1-jerome.foriss...@linaro.org/ > > Some drivers do not behave properly when free_pkt() is called with a > length of zero. It

Re: [PATCH 2/4] serial: do not overwrite not-consumed characters in rx buffer

2024-10-08 Thread Simon Glass
On Thu, 3 Oct 2024 at 08:10, Rasmus Villemoes wrote: > > Before the previous patch, pasting a string of length x > > CONFIG_SERIAL_RX_BUFFER_SIZE results in getting the > last (x%CONFIG_SERIAL_RX_BUFFER_SIZE) characters from that string. > > With the previous patch, one instead gets the last > CON

Re: [PATCH 1/4] serial: fix circular rx buffer edge case

2024-10-08 Thread Simon Glass
On Thu, 3 Oct 2024 at 08:10, Rasmus Villemoes wrote: > > The current implementation of the circular rx buffer falls into a > common trap with circular buffers: It keeps the head/tail indices > reduced modulo the buffer size. The problem with that is that it makes > it impossible to distinguish "bu

Re: [PATCH 2/3] image-host: fix 'unknown error' error message

2024-10-08 Thread Simon Glass
On Mon, 16 Sept 2024 at 02:25, wrote: > > From: Alexander Kochetkov > > Fix error message like this: > Can't add verification data for node 'fdt-1' () > > We get unknown error because we decode error as fdt error > but actually it is system error. > > Signed-off-by: Alexander Kochetkov > --- >

Re: [PATCH 2/4] boot: Add logic to enable booting from fallback option

2024-10-08 Thread Simon Glass
On Wed, 2 Oct 2024 at 07:26, Martyn Welch wrote: > > The "fallback" extlinux config option allows us to set an alternative > default boot option for when it has been detected that the default is > failing. Implement the logic required to boot from this option when > desired. > > Signed-off-by: Mar

Re: [PATCH 1/4] boot: pxe_utils: Add fallback support

2024-10-08 Thread Simon Glass
On Wed, 2 Oct 2024 at 07:26, Martyn Welch wrote: > > When configured correctly, we can detect when boot fails after the boot > process has been handed over to the kernel through the use of U-Boot's > bootcount support. In some instances, such as when we are performing > atomic updates via a system

Re: [PATCH 3/4] bootstd: Add command to enable setting of bootmeth specific properties

2024-10-08 Thread Simon Glass
On Wed, 2 Oct 2024 at 07:26, Martyn Welch wrote: > > We have previously added logic to allow a "fallback" option to be > specified in the extlinux configuration. Provide a command that allows > us to set this as the preferred default option when booting. > > Combined with the bootcount functionali

Re: [PATCH v11 02/29] Make AVB_VERIFY depend on FASTBOOT

2024-10-08 Thread Simon Glass
On Thu, 3 Oct 2024 at 09:23, Jerome Forissier wrote: > > Note: Patch posted separately [0]. > > [0] > http://patchwork.ozlabs.org/project/uboot/patch/20241002144845.1439316-1-jerome.foriss...@linaro.org/ > > AVB_BUF_ADDR, which is under "if AVB_VERIFY", defaults to > FASTBOOT_BUF_ADDR. Therefore

Re: [PATCH 4/4] test: Add tests for the bootmeth set command

2024-10-08 Thread Simon Glass
On Wed, 2 Oct 2024 at 07:26, Martyn Welch wrote: > > We have added a "set" sub command to bootmeth, add some tests to check > it's operation. > > Signed-off-by: Martyn Welch > --- > test/boot/bootmeth.c | 47 > 1 file changed, 47 insertions(+) > Revi

Re: [RESEND PATCH v4 00/10] mtd: spinand: initial support of ecc engines

2024-10-08 Thread Simon Glass
Hi Mikhail, On Tue, 1 Oct 2024 at 14:45, Mikhail Kshevetskiy wrote: > > This patch series: > * sync spinand driver code with linux-6.10 > * sync spinand flash support with linux-6.10 > * add initial support of ecc engines > > Up to now only software ecc is supported, but other engines can be a

Re: [PATCH v11 05/29] test: boot: fix bootdev_test_any for when DSA_SANDBOX is disabled

2024-10-08 Thread Simon Glass
On Thu, 3 Oct 2024 at 09:23, Jerome Forissier wrote: > > When DSA_SANDBOX is not set, the sandbox tests fail as follows: > > $ ./test/py/test.py --build-dir=$(pwd) -k bootdev_test_any > [...] > Test: bootdev_test_any: bootdev.c > test/boot/bootdev.c:156, bootdev_test_any(): "mmc2" = media->nam

Re: [PATCH 4/4] serial: embed the rx buffer in struct serial_dev_priv

2024-10-08 Thread Simon Glass
On Thu, 3 Oct 2024 at 08:11, Rasmus Villemoes wrote: > > The initialization of upriv->buf doesn't check for a NULL return. But > there's actually no point in doing a separate, unconditional malloc() > in post_probe; we can just make serial_dev_priv contain the rx buffer > itself, and let the (larg

Re: [PATCH 1/3] binman: fix passing loadables to mkimage on first run

2024-10-08 Thread Simon Glass
On Mon, 16 Sept 2024 at 02:25, wrote: > > From: Alexander Kochetkov > > FIT use mkimage from BuildSectionData() to build FIT entry contents. > BuildSectionData() get called several times during building FIT image. > > Currently when fit inserts loadables, it use self._loadables property that > co

Re: [PATCH 3/3] binman: implement signing FIT images during image build

2024-10-08 Thread Simon Glass
On Mon, 16 Sept 2024 at 02:25, wrote: > > From: Alexander Kochetkov > > The patch implement new property 'fit,sign' that can be declared > at the top-level 'fit' node. If that option is declared, fit tryies > to detect private keys directory among binman include directories. > That directory than

Re: [PATCH 0/3] Implement signing FIT images during image build

2024-10-08 Thread Simon Glass
Hi, On Mon, 16 Sept 2024 at 02:24, wrote: > > From: Alexander Kochetkov > > Hello! > > I've done verified boot on Radxa Rock 3A. I've embedded public key in U-Boot > SPL and signed FIT image configuration. All the work was done during U-Boot > image build. For some use cases building and signing

[PATCH 6/6] cmd: Add a command to show the memory map

2024-10-08 Thread Simon Glass
U-Boot has a fairly rigid memory map which is normally not visible unless debugging is enabled in board_f.c Add a 'memmap' command which shows it. This command does not cover arch-specific pieces but gives a good overview of where things are. Signed-off-by: Simon Glass --- cmd/Kconfig

[PATCH 5/6] bootstage: Allow counting memory without strings

2024-10-08 Thread Simon Glass
The bootstage array includes pointers to strings but not the strings themselves. The strings are added when stashing, but including them in the size calculation gives an inflated view of the amount of space used by the array. Update this function so it can return the amount of memory used by the b

[PATCH 4/6] global_data: Add some more accessors

2024-10-08 Thread Simon Glass
Add accessors for bloblist, bootstage, trace and video to avoid needing more #ifdefs in the C code. Signed-off-by: Simon Glass --- include/asm-generic/global_data.h | 30 ++ 1 file changed, 30 insertions(+) diff --git a/include/asm-generic/global_data.h b/include/a

[PATCH 3/6] am65x: Use map_to_sysmem() to convert from pointer

2024-10-08 Thread Simon Glass
The board_init_f() function for am65x is a bit confusing, since it uses the variable name 'pool_addr' to hold a pointer. It then casts it to an address to pass to mem_alloc_init() Rename the variable and use mapmem to convert to an address. Signed-off-by: Simon Glass --- arch/arm/mach-k3/am65x

[PATCH 2/6] common: Tidy up how malloc() is inited

2024-10-08 Thread Simon Glass
The call to malloc() is a bit strange. The naming of the arguments suggests that an address is passed, but in fact it is a pointer, at least in the board_init_r() function and SPL equivalent. Update it to work as described. Add a function comment as well. Note that this does adjustment does not e

[PATCH 1/6] common: Fix up malloc() comment in reserve_noncached()

2024-10-08 Thread Simon Glass
The function name has changed, so update it. Signed-off-by: Simon Glass --- common/board_f.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/common/board_f.c b/common/board_f.c index 154675d0e40..2e04a47b546 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -501,

[PATCH 0/6] Allow showing the memory map

2024-10-08 Thread Simon Glass
This little series adds a new 'memmap' command, intended to show the layout of memory within U-Boot and how much memory is available for loading images. Simon Glass (6): common: Fix up malloc() comment in reserve_noncached() common: Tidy up how malloc() is inited am65x: Use map_to_sysmem()

Re: [PATCH] net: correct wget_connected debug messages

2024-10-08 Thread Peter Robinson
On Wed, 9 Oct 2024 at 00:02, Heinrich Schuchardt wrote: > > * Remove duplicate debug message in wget_connected() > * Correct typo 'Connctd' > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Peter Robinson > --- > net/wget.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > d

[PATCH] net: correct wget_connected debug messages

2024-10-08 Thread Heinrich Schuchardt
* Remove duplicate debug message in wget_connected() * Correct typo 'Connctd' Signed-off-by: Heinrich Schuchardt --- net/wget.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/net/wget.c b/net/wget.c index b4251e0f293..f978adc9f0a 100644 --- a/net/wget.c +++ b/net/wge

[PATCH 1/1] net/wget: set filesize

2024-10-08 Thread Heinrich Schuchardt
Environment variable filesize is needed for man use cased, e.g. * write file to device * calculate hash Let wget set the variable. Signed-off-by: Heinrich Schuchardt --- net/wget.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/wget.c b/net/wget.c index f978adc9f0a..635f82efbb3 100644

[PATCH 1/1] net/wget: set filesize

2024-10-08 Thread Heinrich Schuchardt
Environment variable filesize is needed for man use cased, e.g. * write file to device * calculate hash Let wget set the variable. Signed-off-by: Heinrich Schuchardt --- net/wget.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/wget.c b/net/wget.c index f978adc9f0a..635f82efbb3 100644

[PATCH 1/1] sandbox: add bootmethod EFI boot-manager

2024-10-08 Thread Heinrich Schuchardt
The EFI boot-manager is the default method to boot EFI binaries. We should be able to use it on the Sandbox. * Enable EFI boot-manager bootmethod on the sandbox. * Adjust unit tests to reflect the additional boot method. Signed-off-by: Heinrich Schuchardt --- arch/sandbox/dts/test.dts | 4

Re: [PATCH v2 3/3] board: rockchip: Add Hardkernel ODROID-M1S

2024-10-08 Thread Jonas Karlman
Hi Peter, On 2024-10-08 23:34, Peter Robinson wrote: > On Tue, 8 Oct 2024 at 21:07, Jonas Karlman wrote: >> >> The Hardkernel ODROID-M1S is a single-board computer based on Rockchip >> RK3566 SoC. It features e.g. 4/8 GB LPDDR4 RAM, 64 GB eMMC, SD-card, >> GbE LAN, HDMI 2.0, M.2 NVMe and USB 2.0/

Re: [PATCH v2 00/14] Make EFI memory allocations synchronous with LMB

2024-10-08 Thread Heinrich Schuchardt
On 10/8/24 20:14, Sughosh Ganu wrote: This is part two of the series to have the EFI and LMB modules have a coherent view of memory. Part one of this goal was to change the LMB module to have a global and persistent memory map. Those patches have now been applied to the next branch. These patche

Re: [PATCH v2 2/3] arm64: dts: rockchip: Add Hardkernel ODROID-M1S

2024-10-08 Thread Jonas Karlman
Hi Peter, On 2024-10-08 23:22, Peter Robinson wrote: > On Tue, 8 Oct 2024 at 21:07, Jonas Karlman wrote: >> >> The Hardkernel ODROID-M1S is a single-board computer based on Rockchip >> RK3566 SoC. It features e.g. 4/8 GB LPDDR4 RAM, 64 GB eMMC, SD-card, >> GbE LAN, HDMI 2.0, M.2 NVMe and USB 2.0/

Re: [PATCH 1/1] boot: type boormethod

2024-10-08 Thread Peter Robinson
On Tue, 8 Oct 2024 at 21:52, Heinrich Schuchardt wrote: > > %s/boormethod/bootmethod/ > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Peter Robinson > --- > boot/bootstd-uclass.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/boot/bootstd-uclass.c b/boot/bootstd-

Re: [PATCH v2 3/3] board: rockchip: Add Hardkernel ODROID-M1S

2024-10-08 Thread Peter Robinson
On Tue, 8 Oct 2024 at 21:07, Jonas Karlman wrote: > > The Hardkernel ODROID-M1S is a single-board computer based on Rockchip > RK3566 SoC. It features e.g. 4/8 GB LPDDR4 RAM, 64 GB eMMC, SD-card, > GbE LAN, HDMI 2.0, M.2 NVMe and USB 2.0/3.0. > > Features tested on a ODROID-M1S 8GB rev1.0 20230906

Re: [PATCH v2 2/3] arm64: dts: rockchip: Add Hardkernel ODROID-M1S

2024-10-08 Thread Peter Robinson
On Tue, 8 Oct 2024 at 21:07, Jonas Karlman wrote: > > The Hardkernel ODROID-M1S is a single-board computer based on Rockchip > RK3566 SoC. It features e.g. 4/8 GB LPDDR4 RAM, 64 GB eMMC, SD-card, > GbE LAN, HDMI 2.0, M.2 NVMe and USB 2.0/3.0. > > Add initial support for eMMC, SD-card, Ethernet, HD

Re: [PATCH] rockchip: Migrate to use USB_DWC3_GENERIC on RK3328

2024-10-08 Thread Peter Robinson
On Tue, 8 Oct 2024 at 20:52, Jonas Karlman wrote: > > After the full convertion of usb gadget interrupt handling to > usb_gadget_generic_ops, it is now possible to use DM_USB_GADGET, > DWC2_OTG and DWC3_GENERIC together without causing a build error. > > Change to use USB_DWC3_GENERIC instead of U

[PATCH 1/1] boot: type boormethod

2024-10-08 Thread Heinrich Schuchardt
%s/boormethod/bootmethod/ Signed-off-by: Heinrich Schuchardt --- boot/bootstd-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/boot/bootstd-uclass.c b/boot/bootstd-uclass.c index 5de8efce19a..fdb8d69e320 100644 --- a/boot/bootstd-uclass.c +++ b/boot/bootstd-uclass.c @

[PATCH v3 2/6] treewide: bcb: move ab_select command to bcb subcommands

2024-10-08 Thread Dmitry Rokosov
To enhance code organization, it is beneficial to consolidate all A/B BCB management routines into a single super-command. The 'bcb' command is an excellent candidate for this purpose. This patch integrates the separate 'ab_select' command into the 'bcb' group as the 'ab_select' subcommand, mainta

[PATCH v3 5/6] common: android_ab: fix slot suffix for abc block

2024-10-08 Thread Dmitry Rokosov
To align with the official Android BCB (Bootloader Control Block) specifications, it's important to note that the slot_suffix should start with an underscore symbol. For a comprehensive understanding of the expected slot_suffix format in userspace, please refer to the provided reference [1]. Link

[PATCH v3 4/6] cmd: bcb: introduce 'ab_dump' command to print BCB block content

2024-10-08 Thread Dmitry Rokosov
It's really helpful to have the ability to dump BCB block for debugging A/B logic on the board supported this partition schema. Command 'bcb ab_dump' prints all fields of bootloader_control struct including slot_metadata for all presented slots. Output example: = > board# bcb ab_dump ubi 0#mi

[PATCH v3 6/6] test/py: introduce test for ab_dump command

2024-10-08 Thread Dmitry Rokosov
The ab_dump command allows you to display ABC data directly on the U-Boot console. During an A/B test execution, this test verifies the accuracy of each field within the ABC data. Reviewed-by: Simon Glass Reviewed-by: Mattijs Korpershoek Signed-off-by: Dmitry Rokosov --- test/py/tests/test_and

[PATCH v3 3/6] cmd: bcb: change strcmp() usage style in the do_bcb_ab_select()

2024-10-08 Thread Dmitry Rokosov
In the entire cmd/bcb.c file, the return value of strcmp() is not directly compared to 0. Therefore, it would be better to maintain this style in the new do_bcb_ab_select() function as well. Reviewed-by: Mattijs Korpershoek Reviewed-by: Simon Glass Signed-off-by: Dmitry Rokosov --- cmd/bcb.c |

[PATCH v3 0/6] android_ab: introduce bcb ab_dump command and provide several bcb fixes

2024-10-08 Thread Dmitry Rokosov
lude/configs/ti_omap5_common.h | 4 +- test/py/tests/test_android/test_ab.py | 31 ++-- 18 files changed, 252 insertions(+), 128 deletions(-) --- base-commit: fbe16bc28014dc1ed957f5fee7e53d6eee781aa9 change-id: 20241008-android_ab_master-d86d71c839ae Best regards, -- Dmitry Rokosov

[PATCH v3 1/6] include/android_ab: move ab_select_slot() documentation to @ notation

2024-10-08 Thread Dmitry Rokosov
There are new function documentation requirements in U-Boot, so apply these changes for android_ab. Reviewed-by: Mattijs Korpershoek Reviewed-by: Simon Glass Signed-off-by: Dmitry Rokosov --- boot/android_ab.c| 43 --- include/android_ab.h | 7 -

[PATCH v2 3/3] board: rockchip: Add Hardkernel ODROID-M1S

2024-10-08 Thread Jonas Karlman
The Hardkernel ODROID-M1S is a single-board computer based on Rockchip RK3566 SoC. It features e.g. 4/8 GB LPDDR4 RAM, 64 GB eMMC, SD-card, GbE LAN, HDMI 2.0, M.2 NVMe and USB 2.0/3.0. Features tested on a ODROID-M1S 8GB rev1.0 20230906: - SD-card boot - eMMC boot - Ethernet - PCIe/NVMe - USB gadg

[PATCH v2 2/3] arm64: dts: rockchip: Add Hardkernel ODROID-M1S

2024-10-08 Thread Jonas Karlman
The Hardkernel ODROID-M1S is a single-board computer based on Rockchip RK3566 SoC. It features e.g. 4/8 GB LPDDR4 RAM, 64 GB eMMC, SD-card, GbE LAN, HDMI 2.0, M.2 NVMe and USB 2.0/3.0. Add initial support for eMMC, SD-card, Ethernet, HDMI, PCIe and USB. Signed-off-by: Jonas Karlman Link: https:/

[PATCH v2 1/3] arm64: dts: rockchip: Correct vendor prefix for Hardkernel ODROID-M1

2024-10-08 Thread Jonas Karlman
The vendor prefix for Hardkernel ODROID-M1 is incorrectly listed as rockchip. Use the proper hardkernel vendor prefix for this board, while at it also drop the redundant soc prefix. Fixes: fd3583267703 ("arm64: dts: rockchip: Add Hardkernel ODROID-M1 board") Reviewed-by: Aurelien Jarno Signed-off

[PATCH v2 0/3] board: rockchip: Add Hardkernel ODROID-M1S

2024-10-08 Thread Jonas Karlman
This series add support for the RK3566 based Hardkernel ODROID-M1S and also correct the board compatible used for Hardkernel ODROID-M1. Features tested on a ODROID-M1S 8GB rev1.0 20230906: - SD-card boot - eMMC boot - Ethernet - PCIe/NVMe - USB gadget - USB host Changes in v2: - Fix clean apply o

Re: [PATCH v2 00/14] Make EFI memory allocations synchronous with LMB

2024-10-08 Thread Heinrich Schuchardt
On 10/8/24 20:14, Sughosh Ganu wrote: This is part two of the series to have the EFI and LMB modules have a coherent view of memory. Part one of this goal was to change the LMB module to have a global and persistent memory map. Those patches have now been applied to the next branch. These patche

[PATCH] rockchip: Migrate to use USB_DWC3_GENERIC on RK3328

2024-10-08 Thread Jonas Karlman
After the full convertion of usb gadget interrupt handling to usb_gadget_generic_ops, it is now possible to use DM_USB_GADGET, DWC2_OTG and DWC3_GENERIC together without causing a build error. Change to use USB_DWC3_GENERIC instead of USB_XHCI_DWC3 to complte the migration initiated in commit 1bc4

[PATCH v2] Revert "mmc: dw_mmc: Extract FIFO data transfer into a separate routine"

2024-10-08 Thread Jonas Karlman
The commit 0252924ac6d4 ("mmc: dw_mmc: Extract FIFO data transfer into a separate routine") unintentionally changed behavior of the FIFO data transfer routine. When data is read and size reaches 0 the original loop would wait on DWMCI_INTMSK_DTO or timeout. The remaining size to read and buf posit

[PATCH v2 14/14] efi_memory: rename variable to highlight overlap with free memory

2024-10-08 Thread Sughosh Ganu
The functions to add a memory region to the EFI memory map have a variable, overlap_only_ram, which is used to indicate if a new memory region needs to be carved out from the free, or conventional memory. The name overlap_only_ram is a bit confusing, as other allocated memory regions, like boot-ser

[PATCH v2 13/14] lmb: remove call to efi_lmb_reserve()

2024-10-08 Thread Sughosh Ganu
The EFI memory allocations are now being done through the LMB module. With this change, there is no need to get the EFI memory map and set aside EFI allocated memory. Signed-off-by: Sughosh Ganu --- Changes since V1: * Do not remove the inclusion of efi_loader.h as it is now needed for the lmb_

[PATCH v2 12/14] efi_memory: do not add RAM memory to the memory map

2024-10-08 Thread Sughosh Ganu
The EFI_CONVENTIONAL_MEMORY type, which is the usable RAM memory is now being managed by the LMB module. Remove the addition of this memory type to the EFI memory map. This memory now gets added to the EFI memory map as part of the LMB memory map update event handler. Signed-off-by: Sughosh Ganu

[PATCH v2 11/14] x86: e820: use the lmb API for adding RAM memory

2024-10-08 Thread Sughosh Ganu
The EFI_CONVENTIONAL_MEMORY type is now being managed through the LMB module. Add a separate function, lmb_arch_add_memory() to add the RAM memory to the LMB memory map. The efi_add_known_memory() function is now used for adding any other memory type to the EFI memory map. Signed-off-by: Sughosh G

[PATCH v2 10/14] layerscape: use the lmb API's to add RAM memory

2024-10-08 Thread Sughosh Ganu
The EFI memory allocations are now being done through the LMB module, and hence the memory map is maintained by the LMB module. Use the lmb_arch_add_memory() API function to add the usable RAM memory to the LMB's memory map. Signed-off-by: Sughosh Ganu --- Changes since V1: None arch/arm/cpu/ar

[PATCH v2 09/14] lmb: allow for boards to specify memory map

2024-10-08 Thread Sughosh Ganu
Some architectures have special or unique aspects which need consideration when adding memory ranges to the list of available memory map. Enable this config in such scenarios which allow architectures and boards to define their own memory map. Signed-off-by: Sughosh Ganu --- Changes since V1: Non

  1   2   >