Re: [PATCH v3 29/40] efi_loader: Shorten the app rules

On Sun, 11 Aug 2024 at 17:52, Simon Glass wrote: > > We have quite a few apps now, so create a way to specify them as a list > rather than repeating the same rules again and again. > > Signed-off-by: Simon Glass > Reviewed-by: Heinrich Schuchardt > --- > > (no changes since v1) > > lib/efi_load

Re: [PATCH v2 00/10] rockchip: pinctrl: Add support for pinmux status cmd

Hi Jonas, On 2024/8/3 06:56, Jonas Karlman wrote: This series includes some cleanup, add support for using the pinmux status cmd and add support for the gpio request ops. Following is an example on a Radxa ROCK 5A (RK3588S): => pinmux dev pinctrl dev: pinctrl => pinmux status GPIO0

Re: [PATCH 1/1] board: rockchip: Add support for rk3588 GenBook

On 2024-08-12 02:37, Andy Yan wrote: At 2024-08-12 05:26:36, "Dragan Simic" wrote: Hello Andy, Please see a few comments below. On 2024-08-11 12:02, Andy Yan wrote: Add support for Cool Pi GenBook. Specification: - Rockchip RK3588 - LPDDR5X 8/32 GB - eMMC 64 GB - HDMI Type A out x 1 - USB 3

Re:Re: [PATCH 1/1] board: rockchip: Add support for rk3588 GenBook

Hello Dragan， At 2024-08-12 05:26:36, "Dragan Simic" wrote: >Hello Andy, > >Please see a few comments below. > >On 2024-08-11 12:02, Andy Yan wrote: >> Add support for Cool Pi GenBook. >> >> Specification: >> - Rockchip RK3588 >> - LPDDR5X 8/32 GB >> - eMMC 64 GB >> - HDMI Type A out x 1 >> - U

[PULL] u-boot-usb/master

The following changes since commit 7bd2559cb30a4e800db519e88a22a25f13c753ec: Merge tag 'tpm-master-09082024' of https://source.denx.de/u-boot/custodians/u-boot-tpm.git (2024-08-09 14:00:04 -0600) are available in the Git repository at: git://source.denx.de/u-boot-usb.git master for you to

Re: [PATCH 1/1] board: rockchip: Add support for rk3588 GenBook

Hello Andy, Please see a few comments below. On 2024-08-11 12:02, Andy Yan wrote: Add support for Cool Pi GenBook. Specification: - Rockchip RK3588 - LPDDR5X 8/32 GB - eMMC 64 GB - HDMI Type A out x 1 - USB 3.0 Host x 1 - USB-C 3.0 with DisplayPort AltMode - PCIE M.2 E Key for RTL8852BE Wirele

[PATCH v3] env: remove vars that are not in default env

current env_set_default_vars() doesn't delete var that are not in the imported env. hashtable removes vars that are not in the imported env but present in the current env only if H_NOCLEAR flag is not set. This change is to avoid passing H_NOCLEAR flag if specific vars are passed to env_set_defaul

Re: [PATCH v2] usb: dwc3: support USB 3.1 controllers

On 4/23/24 4:15 PM, Caleb Connolly wrote: The revision is different for these, add the additional check as in xhci-dwc3 core_init code. Reviewed-by: Marek Vasut Thanks !

[PATCH v3 38/40] efi: Avoid using sandbox virtio devices

While sandbox supports virtio it cannot support actually using the block devices to read files, since there is nothing on the other end of the 'virtqueue'. A recent change makes EFI probe all block devices, whether used or not. This is apparently required by EFI, although it violates U-Boot's lazy

[PATCH v3 37/40] efi: Add a test app

Add a simple app to use for testing. This is intended to do whatever it needs to for testing purposes. For now it just prints a message and exits boot services. Signed-off-by: Simon Glass --- (no changes since v1) lib/efi_loader/Kconfig | 10 ++ lib/efi_loader/Makefile | 1 + lib/efi_l

[PATCH v3 35/40] bootstd: Add debugging for efi bootmeth

Add a little debugging so we can see what is happening. Signed-off-by: Simon Glass --- (no changes since v1) boot/bootmeth_efi.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/boot/bootmeth_efi.c b/boot/bootmeth_efi.c index 39232eb2e25..99887a89f02 100644 --- a

[PATCH v3 33/40] bootstd: Make bootdev_next_prio() continue after failure

When a device fails to probe, the next device should be tried, until either we find a suitable device or run out of devices. A device should never be tried twice. When we run out of devices of a particular priority, the hunter should be used to generate devices of the next priority. Only if all at

[PATCH v3 36/40] efi: Disable ANSI output for tests

We don't want ANSI characters written in tests since it is a pain to check the output with ut_assert_nextline() et al. Provide a way to tests to request that ANSI characters not be sent. Add a proper function comment while we are here, to encourage others. Signed-off-by: Simon Glass --- (no ch

[PATCH v3 40/40] efi: Add a test for the efi bootmeth

Add a simple test of booting with the EFI bootmeth, which runs the app and checks that it can call 'exit boot-services' (to check that all the device-removal code doesn't break anything) and then exit back to U-Boot. This uses a disk image containing the testapp, ready for execution by sandbox whe

[PATCH v3 39/40] test: Set up an image suitable for EFI testing

Create a new disk for use with tests, which contains the new 'testapp' EFI app specifically intended for testing the EFI loader. Attach it to the USB device, since most testing is currently done with mmc. Initially this image will be used to test the EFI bootmeth. Fix a stale comment in prep_mmc

[PATCH v3 34/40] efi: Use the same filename for all sandbox builds

Sandbox is not a real architecture, but within U-Boot it is real enough. We should not need to pretend it is x86 or ARM anywhere in the code. Also we want to be able to locate the sandbox app using a single filename, 'bootsbox.efi', to avoid needing tests to produce different files on each host ar

[PATCH v3 32/40] Revert "bootdev: avoid infinite probe loop"

This turns out to be insufficient to fix the problem, since when bootdev_next_prio() exits, the caller has no idea that this really is the end. Nor is it, since there may be other devices which should be checked. The caller iterates which calls iter_incr() which calls bootdev_next_prio() again, wh

[PATCH v3 31/40] efi: Show the vendor in helloworld

Show the vendor name so it is clear which firmware is being used, e.g. whether U-Boot is providing the boot services. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Reword commit message - Use 'Firmware vendor' instead of just 'Vendor' lib/efi_loader/helloworld.c | 3 ++

[PATCH v3 30/40] efi_loader: Shorten the app rules further

Add a way to factor out the CFLAGS changes for each app, since they are all the same. Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt Reviewed-by: Ilias Apalodimas --- (no changes since v1) lib/efi_loader/Makefile | 15 +-- 1 file changed, 5 insertions(+), 10 deletion

[PATCH v3 29/40] efi_loader: Shorten the app rules

We have quite a few apps now, so create a way to specify them as a list rather than repeating the same rules again and again. Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt --- (no changes since v1) lib/efi_loader/Makefile | 31 +-- 1 file changed, 9 i

[PATCH v3 28/40] efi: arm: x86: riscv: Drop crt0/relocal extra- rules

The link rule (for $(obj)/%_efi.so) in scripts/Makefile.lib handles pulling in efi_crt0.o and efi_reloc.o so drop the 'extra' rules. Signed-off-by: Simon Glass Suggested-by: Heinrich Schuchardt --- Changes in v3: - Add new patch to drop crt0/relocal extra- rules arch/arm/lib/Makefile | 7 -

[PATCH v3 27/40] efi_loader: Rename and move CMD_BOOTEFI_HELLO_COMPILE

This is not actually a command so the name is confusing. Use BOOTEFI_HELLO_COMPILE instead. Put it in the efi_loader directory with the other such config options. The link rule (for $(obj)/%_efi.so) in scripts/Makefile.lib handles pulling in efi_crt0.o and efi_reloc.o so drop the 'extra' rules. S

[PATCH v3 26/40] efi_loader: Put back copyright message

This was lost in a later commit, so add it back. Signed-off-by: Simon Glass Fixes: dd860b90ff4 ("efi_loader: print boot device and file path in") --- (no changes since v1) lib/efi_loader/helloworld.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/efi_loader/helloworld.c b/lib/efi_l

[PATCH v3 25/40] efi: Use puts() in cout so that console recording works

At present EFI output to the console uses fputs() which bypasses the console-recording feature. This makes it impossible for tests to check the output of an EFI app. There doesn't seem to be any need to do this bypass, so adjust it to simply use the puts() function. Signed-off-by: Simon Glass Re

[PATCH v3 24/40] test: mbr: Drop a duplicate test

The test currently runs twice as it is declared twice. Unwind this. Signed-off-by: Simon Glass --- (no changes since v1) test/cmd/mbr.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/test/cmd/mbr.c b/test/cmd/mbr.c index ec19cf3793c..2beaf9a75c5 100644 --- a/test/cmd/mbr.c +++ b/tes

[PATCH v3 23/40] test: mbr: Use RAM for the buffers

The normal approach with sandbox is to use a fixed memory address in the RAM, to avoid needing to create a map for transient local variables. Update this test to use this approach. Signed-off-by: Simon Glass --- (no changes since v1) test/cmd/mbr.c | 52 ++-

[PATCH v3 22/40] test: mbr: Use a constant for the block size

It isn't that important to factor out constants in tests, but in this case we have 0x200 and 512 used. The commands don't use the constant as they use a block count ('1'). It doesn't create more code to use a constant, so create one. Signed-off-by: Simon Glass --- Changes in v3: - use SZ_512 ins

[PATCH v3 21/40] test: mbr: Unmap the buffers after use

This tests maps some local variables into sandbox's address space. Make sure to unmap them afterwards. Note that the normal approach with sandbox is to use a fixed memory address in the RAM, to avoid needing to create a map for transient local variables. Signed-off-by: Simon Glass Fixes: 04291ee

[PATCH v3 20/40] cmd: Fix memory-mapping in cmp command

This unmaps a different address from what was mapped. Fix it. Signed-off-by: Simon Glass --- (no changes since v1) cmd/mem.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/cmd/mem.c b/cmd/mem.c index 274348068c2..4d6fde28531 100644 --- a/cmd/me

[PATCH v3 19/40] read: Tidy up use of map_sysmem() in the read command

Rename the variable to 'ptr' since it is a pointer, not an address. Make sure to unmap the pointer. Signed-off-by: Simon Glass --- Changes in v3: - Correct the commit subject and message cmd/read.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/cmd/read.c b/cmd/

[PATCH v3 18/40] mmc: Use map_sysmem() with buffers in the mmc command

The current implementation casts an address to a pointer. Make it more sandbox-friendly by using map_sysmem(). Rename the variable to 'ptr' since it is a pointer, not an address. Signed-off-by: Simon Glass --- (no changes since v1) cmd/mmc.c | 15 +-- 1 file changed, 9 insertions(

[PATCH v3 17/40] sandbox: Implement reference counting for address mapping

An address may be mapped twice and unmapped twice. Delete the mapping only when the last user unmaps it. Fix a missing comment while here. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/cpu/cpu.c | 14 ++ arch/sandbox/include/asm/state.h | 3 +++ 2 fi

[PATCH v3 14/40] sandbox: Update cpu to use logging

Use log_debug() instead of including the function name in the string. Add one more debug for PCI. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/cpu/cpu.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/arch/sandbox/cpu/cpu.c b/arch/sandb

[PATCH v3 16/40] sandbox: Add some debugging to pci_io

Add a little debugging to this driver. Convert the existing debugging to use logging. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/lib/pci_io.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/arch/sandbox/lib/pci_io.c b/arch/sandbox/lib/pci_io.

[PATCH v3 15/40] sandbox: Unmap old tags

So far unmapping has not been implemented. This means that if one test maps a pointer to an address with map_sysmem(), then a second test can use that same pointer, by mapping the address back to a pointer with map_to_sysmem(). This is not really desirable, even if it doesn't cause any problems at

[PATCH v3 13/40] sandbox: Change the range used for memory-mapping tags

Sandbox keeps a table of addresses which map to pointers which are outside its emulated DRAM. The current range from 1000 conflicts with the PCI range, meaning that if PCI mapping is on, that particular address can be decoded by PCI instead of the table. Fix this by moving the range up to the

[PATCH v3 12/40] test: mbr: Adjust test to drop 0x

U-Boot commands typically don't need 0x to specify hex, since they use hex by default. Adding 0x in this test is confusing since it suggests that it is necessary. Drop it from the file. Also use the %#x construct to get the 0x when needed. Signed-off-by: Simon Glass --- (no changes since v1)

[PATCH v3 11/40] test: mbr: Adjust test to use lower-case hex

Switch to lower-case hex which is more commonly used in U-Boot. Signed-off-by: Simon Glass --- (no changes since v1) test/cmd/mbr.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/test/cmd/mbr.c b/test/cmd/mbr.c index 235b363290e..4c884af10c7 100644 --- a/test/cmd/mb

[PATCH v3 10/40] dm: usb: Deal with USB keyboard persisting across tests

Clear any USB-keyboard devices before running a unit test, to avoid using a stale udevice pointer in stdio. Add a long comment to explain this situation and why this solution seems best, at least for now. Signed-off-by: Simon Glass --- (no changes since v1) common/console.c | 34 +

[PATCH v3 09/40] usb: Add DEV_FLAGS_DM to stdio for USB keyboard

This device contains a pointer to struct udevice so set the flag indicating that, just to be tidy. Signed-off-by: Simon Glass --- (no changes since v1) common/usb_kbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/usb_kbd.c b/common/usb_kbd.c index b834b2f703d..1d

[PATCH v3 08/40] log: Add a new log category for the console

Add a new category which covers the console, including the stdio drivers. Signed-off-by: Simon Glass --- (no changes since v1) common/console.c | 2 ++ common/log.c | 1 + include/log.h| 2 ++ 3 files changed, 5 insertions(+) diff --git a/common/console.c b/common/console.c index 63f7

[PATCH v3 07/40] usb: Drop old non-DM code

The driver model deadline for USB was in 2019, so drop the old USB keyboard code, to avoid needing to deal with the extra code path. Drop the unnecessary #ifdef around USB_KBD_BOOT_REPORT_SIZE while we are here. Signed-off-by: Simon Glass --- (no changes since v1) cmd/usb.c | 20 ---

[PATCH v3 06/40] bootstd: Create a function to reset USB

Set up a function for this, since it needs to be used from multiple test files. This test file is only used on sandbox, where USB is enabled, so drop the local declaration of usb_started Signed-off-by: Simon Glass --- Changes in v3: - Include the usb.h header file in all cases test/boot/bootd

[PATCH v3 05/40] scripts: Update pylint.base

There have been quite a few changes in the Python scripts, so update the pylint baseline. This was created using: make pylint cp pylint.cur scripts/pylint.base Signed-off-by: Simon Glass --- (no changes since v1) scripts/pylint.base | 462 ++-- 1

[PATCH v3 04/40] test/py: Fix some pylint warnings in test_ut.py

Tidy up most of these warnings. Remaining are four of these: R0914: Too many local variables which can only by fixed by splitting things into functions, so that is left for another time. Part of this change was done by the flynt tool. Signed-off-by: Simon Glass --- (no changes since v1)

[PATCH v3 03/40] bootstd: Add UT_TESTF_CONSOLE_REC to bootflow tests

Quite a few tests use console recording without indicating this, using the UT_TESTF_CONSOLE_REC flag. Fix this to avoid strange failures. Signed-off-by: Simon Glass --- (no changes since v1) test/boot/bootflow.c | 59 +++- 1 file changed, 31 insertions(+

[PATCH v3 02/40] nvmxip: Avoid probing on boot

Devices should be probed when they are used, not before. Drop this boot-time probing. Signed-off-by: Simon Glass --- (no changes since v1) drivers/mtd/nvmxip/nvmxip-uclass.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/mtd/nvmxip/nvmxip-uclass.c b/drivers/mtd/nvmxip/nvmxi

[PATCH v3 01/40] nvmxip: Drop the message on probe

We should not need to announce this device. Drop the message. Signed-off-by: Simon Glass --- (no changes since v1) drivers/mtd/nvmxip/nvmxip-uclass.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nvmxip/nvmxip-uclass.c b/drivers/mtd/nvmxip/nvmxip-uclass.c i

[PATCH v3 00/40] efi: Add a test for EFI bootmeth

The test coverage for the EFI bootmeth is incomplete since it does not actually boot the application. This series creates a simple test for this purpose. It includes a surprising number patches to make this work: - sandbox memory-mapping conflict with PCI - the fix for that causes the mbr test to

[PATCH v2 18/18] i2c: Remove CFG_SYS_I2C_DIRECT_BUS

Now that this is always 1, remove it and the associated dead code. Signed-off-by: Simon Glass --- Changes in v2: - Drop patch "pg-wcom: Drop CFG_SYS_I2C_MAX_HOPS" README | 7 +-- drivers/i2c/i2c_core.c | 104 - include/i2c.h |

[PATCH v2 17/18] i2c: Remove CFG_SYS_I2C_MAX_HOPS

Now that this is always 0, remove it and the associated dead code. Signed-off-by: Simon Glass --- (no changes since v1) README | 10 +- cmd/i2c.c | 23 --- drivers/i2c/i2c_core.c | 37 - include/i2c.h

[PATCH v2 16/18] i2c: Drop i2c_get_bus_num_fdt() and i2c_reset_port_fdt()

These functions are 11 years old and are only used by one board. Drop them. Signed-off-by: Simon Glass --- (no changes since v1) include/i2c.h | 18 -- 1 file changed, 18 deletions(-) diff --git a/include/i2c.h b/include/i2c.h index 282f3cd700f..f468b52cd7b 100644 --- a/includ

[PATCH v2 15/18] i2c: Drop CFG_SYS_MAX_I2C_BUS

Only one board uses this option and it is very old. Let's drop it. Signed-off-by: Simon Glass --- (no changes since v1) include/configs/ethernut5.h | 3 --- include/i2c.h | 14 -- 2 files changed, 17 deletions(-) diff --git a/include/configs/ethernut5.h b/include/co

[PATCH v2 14/18] i2c: Remove I2C_GET_BUS()

This is very old, predating even the legacy I2C support, so drop it. Signed-off-by: Simon Glass --- (no changes since v1) include/i2c.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/include/i2c.h b/include/i2c.h index 1d1430b74a6..b6727bb2a73 100644 --- a/include/i2c.h +++ b/includ

[PATCH v2 13/18] i2c: Remove I2C_SET_BUS()

This is very old, predating even the legacy I2C support, so drop it. Signed-off-by: Simon Glass --- (no changes since v1) drivers/power/power_i2c.c | 5 - include/i2c.h | 7 --- 2 files changed, 12 deletions(-) diff --git a/drivers/power/power_i2c.c b/drivers/power/power_i

[PATCH v2 12/18] octeon: Drop OCTEON_I2C_FDT dead code

This option is not defined by any board, so drop the code. Signed-off-by: Simon Glass --- (no changes since v1) arch/mips/mach-octeon/octeon_fdt.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/arch/mips/mach-octeon/octeon_fdt.c b/arch/mips/mach-octeon/octeon_fdt.c index c74fe9d9fb

[PATCH v2 11/18] i2c: Drop reference to SYS_I2C_INIT_BOARD

This is not now used by any boards, so drop it. Signed-off-by: Simon Glass --- (no changes since v1) doc/I2C_Edge_Conditions | 10 -- drivers/i2c/soft_i2c.c | 11 --- 2 files changed, 4 insertions(+), 17 deletions(-) diff --git a/doc/I2C_Edge_Conditions b/doc/I2C_Edge_Conditi

[PATCH v2 10/18] fsl: mxc: Drop legacy I2c

Drop some old code from the mxc_i2c and ddr/fsl drivers. This will allow removal of very old common I2C code. Signed-off-by: Simon Glass --- Changes in v2: - Leave pg_wcom alone as its boards were converted drivers/ddr/fsl/main.c | 3 +-- drivers/i2c/mxc_i2c.c | 1 + 2 files changed, 2 insert

[PATCH v2 09/18] date: Drop the legacy I2C code

Drop two generations of old code in this command. All boards should use driver model for I2C from 2021. Signed-off-by: Simon Glass --- (no changes since v1) cmd/date.c | 26 -- 1 file changed, 26 deletions(-) diff --git a/cmd/date.c b/cmd/date.c index bdb3e199b43..8614

[PATCH v2 08/18] rtc: Drop CFG_SYS_RTC_BUS_NUM

This option is very old and the migration deadline was years ago. Drop it so that the I2C system can be simplified. Signed-off-by: Simon Glass --- (no changes since v1) README| 5 - cmd/date.c| 6 -- include/configs/ls1028aqds.h | 1 - inclu

[PATCH v2 07/18] MPC837XERDB: ethernut5: work_92105: Drop CMD_DATE

These use pre-driver model code and it is several years since the migration deadline. Disable the 'date' command so that this old code can be removed. Signed-off-by: Simon Glass --- (no changes since v1) configs/MPC837XERDB_defconfig | 1 - configs/ethernut5_defconfig | 1 - configs/work_921

[PATCH v2 06/18] mx28 / mx51: Drop CMD_DATE

These use pre-driver model code and it is several years since the migration deadline. Disable the 'date' command so that this old code can be removed. Signed-off-by: Simon Glass --- (no changes since v1) configs/mx28evk_defconfig | 1 - configs/mx51evk_defconfig | 1 - 2 files changed, 2 delet

[PATCH v2 05/18] armv8: ls2085a: Drop CMD_DATE

These boards use pre-driver model code and it is several years since the migration deadline. Disable the 'date' command so that this old code can be removed. Signed-off-by: Simon Glass --- (no changes since v1) configs/ls2080aqds_nand_defconfig | 1 - configs/ls2080aqds_qspi_defconfig | 1 - c

[PATCH v2 04/18] mips: malta: Drop CMD_DATE

These boards use pre-driver model code and it is several years since the migration deadline. Disable the 'date' command so that this old code can be removed. Signed-off-by: Simon Glass --- (no changes since v1) configs/malta64_defconfig | 1 - configs/malta64el_defconfig | 1 - configs/malta

[PATCH v2 03/18] i2c: Remove CFG_I2C_MULTI_BUS

This is used by a few boards but we are years past the migration date, so let's drop it now. Signed-off-by: Simon Glass --- Changes in v2: - Drop omap3_beagle.h change as that board was removed README | 7 --- include/configs/sniper.h | 14 -- include/configs

[PATCH v2 02/18] i2c: Remove IC2_xxx enum

This is only used by devkit3250 which is being removed. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) drivers/usb/host/ohci-lpc32xx.c | 4 include/i2c.h | 6 -- 2 files changed, 10 deletions(-) diff --git a/drivers/usb/host/ohci-lpc32xx.c b/drivers/u

[PATCH v2 01/18] i2c: Remove board_i2c_init()

This function is not used, so drop it. Signed-off-by: Simon Glass --- (no changes since v1) include/i2c.h | 8 1 file changed, 8 deletions(-) diff --git a/include/i2c.h b/include/i2c.h index 4e59009cd93..8d91b24b43b 100644 --- a/include/i2c.h +++ b/include/i2c.h @@ -972,14 +972,6 @@

[PATCH v2 00/18] i2c: Chip away at some old code

This series aims to remove some of the older contents of i2c.h so that we can move towards having just the dm API. It does not remove any boards, but instead removes functionality. Changes in v2: - Drop omap3_beagle.h change as that board was removed - Leave pg_wcom alone as its boards were conve

Re: Selecting serial device for console

Hi Fiona, On Sat, 10 Aug 2024 at 04:14, Fiona Klute wrote: > > Hi Simon, Mark, > > thanks for your replies! > > Am 08.08.24 um 16:28 schrieb Simon Glass: > > Hi Mark, > > > > On Tue, 6 Aug 2024 at 16:33, Mark Kettenis wrote: > >> > >>> From: Simon Glass > >>> Date: Tue, 6 Aug 2024 15:50:44 -060

Re: [PATCH v2 37/39] efi: Avoid using sandbox virtio devices

Hi Tom, On Thu, 8 Aug 2024 at 14:06, Tom Rini wrote: > > On Thu, Aug 08, 2024 at 12:44:05PM -0600, Simon Glass wrote: > > Hi Heinrick, Tom, > > > > On Tue, 6 Aug 2024 at 19:56, Tom Rini wrote: > > > > > > On Wed, Aug 07, 2024 at 03:47:21AM +0200, Heinrich Schuchardt wrote: > > > > On 06.08.24 14

Re: [PATCH v2 06/39] bootstd: Create a function to reset USB

Hi Heinrich, On Thu, 8 Aug 2024 at 15:12, Heinrich Schuchardt wrote: > > On 07.08.24 16:36, Simon Glass wrote: > > Hi Heinrich, > > > > On Tue, 6 Aug 2024 at 19:56, Heinrich Schuchardt wrote: > >> > >> On 06.08.24 14:58, Simon Glass wrote: > >>> Set up a function for this, since it needs to be u

Re: [PATCH 07/21] Revert "net: wget: Support retransmission a dropped packet"

+Ying-Chun Liu (PaulLiu) Hi Yasuharu, On Sat, 10 Aug 2024 at 20:48, Yasuharu Shibata wrote: > > Dear Simon, > > Could you inform me how the wget test was broken? > As I explained in the commit log, I fixed the bug in specific conditions. > Without the details of how the break happened, > it is

Re: [PATCH v2 36/39] efi: Add a test app

Hi Heinrich, On Thu, 8 Aug 2024 at 15:17, Heinrich Schuchardt wrote: > > On 07.08.24 16:36, Simon Glass wrote: > > Hi Heinrich, > > > > On Tue, 6 Aug 2024 at 19:47, Heinrich Schuchardt wrote: > >> > >> On 06.08.24 14:58, Simon Glass wrote: > >>> Add a simple app to use for testing. This is inten

Re: [PATCH v2 11/14] spl: mmc: Try to clean up raw-mode options

Hi Quentin, On Tue, 6 Aug 2024 at 08:53, Quentin Schulz wrote: > > Hi Simon, > > On 7/21/24 5:25 PM, Simon Glass wrote: > > Make the raw-mode options depend on SPL_SYS_MMCSD_RAW_MODE in a more > > direct way. This makes it easier to understand the options with > > 'make menuconfig'. > > > > There

Re: [PATCH v2 07/14] log: Avoid including function names by default

Hi Quentin, On Tue, 6 Aug 2024 at 08:16, Quentin Schulz wrote: > > Hi Simon, > > On 7/21/24 5:25 PM, Simon Glass wrote: > > Unless function names are requested, the logging system should not > > compile these into the code. Adjust the macros to handle this. > > > > This means that turning on func

Re: [PATCH v2 06/14] mmc: Use logging instead of pr_err()

Hi Quentin, On Tue, 6 Aug 2024 at 08:10, Quentin Schulz wrote: > > Hi Simon, > > On 7/21/24 5:25 PM, Simon Glass wrote: > > Use the log subsystem instead of dev, to avoid including function names > > in the code. > > > > The CONFIG_LOGF_FUNC option can be used to enable the function name. > > > >

Re: [PATCH v2 05/14] mmc: Use logging instead of printf()

Hi Quentin, On Tue, 6 Aug 2024 at 08:01, Quentin Schulz wrote: > > Hi Simon, > > On 7/21/24 5:25 PM, Simon Glass wrote: > > The code makes quite a few uses of __func__ which puts the function > > name into the resulting SPL image. Use the log subsystem instead, to > > reduce size. > > > > The CON

Re: [PATCH v2 04/14] spl: Remove remaining #ifdef in spl_parse_image_header()

Hi Quentin, On Tue, 6 Aug 2024 at 07:24, Quentin Schulz wrote: > > Hi Simon, > > On 7/21/24 5:25 PM, Simon Glass wrote: > > Define spl_set_header_raw_uboot() always so we can drop the last #ifdef > > in this function. > > > > Signed-off-by: Simon Glass > > Reviewed-by: Sean Anderson > > --- > >

Re: I think I found a typographical error

Hi, On Sat, 10 Aug 2024 at 07:40, 김태현 wrote: > > Hi, I was looking in the 'arch > arm > cpu > armv7 > start.S' and I think I > found a typographical error. > > On line 45, 'This allows U-Boot to loaded to ...' should be 'This allows > U-Boot to *be* loaded to ...' > > Please check if it's right o

Re: [PATCH v4 00/21] Universal Payload initial series

Hi Tom, On Sat, 10 Aug 2024 at 12:25, Tom Rini wrote: > > On Wed, 07 Aug 2024 16:47:18 -0600, Simon Glass wrote: > > > Universal Payload (UPL) is an Industry Standard for firmware > > components[1]. UPL is designed to improve interoperability within the > > firmware industry, allowing mixing and

Re: [PATCH] sandbox: Fix pinmux warnings with non-test devicetrees

Hi Sean, On Sat, 10 Aug 2024 at 07:52, Sean Anderson wrote: > > The sandbox pinmux driver is used in the non-test devicetree as well as > the test one. I didn't realize this when I modified the driver for > tests, and so broke the regular use case (which only resulted in > warnings). First, makin

Re: [PATCH] pinmux: generic: Use ENOENT instead of ENOSYS

On Sat, 10 Aug 2024 at 07:59, Sean Anderson wrote: > > ENOSYS should only be used when a subsystem is completely absent. > Convert its use in pinctrl-generic to ENOENT, which better reflects the > error condition (that a function/group/pin is missing). > > Signed-off-by: Sean Anderson > --- > >

Re: [PATCH v2 3/3] efi: Show the location of the bounce buffer

+Marek Vasut too Hi Heinrich, On Fri, 9 Aug 2024 at 13:02, Heinrich Schuchardt wrote: > > > > Am 9. August 2024 20:36:35 MESZ schrieb Simon Glass : > >Hi Heinrich, > > > >On Fri, 9 Aug 2024 at 11:32, Heinrich Schuchardt wrote: > >> > >> On 01.08.24 19:36, Simon Glass wrote: > >> > The EFI_LOADE

Re: [PATCH v2] env: remove vars that are not in default env

Hi Ravi, On Fri, 9 Aug 2024 at 13:36, Ravi Minnikanti wrote: > > > current env_set_default_vars() doesn't delete > var that are not in the imported env. hashtable > removes vars that are not in the imported > env but present in the current env only if H_NOCLEAR > flag is not set. > > This change

[PATCH 1/1] cmd: add rdcycle test to RISC-V exception command

Some versions of KVM don't allow access to the cycle CSR. Provide a command 'exception rdcycle' for testing. If the cycle CSR is accessible, we get an output like: => exception rdcycle cycle = 0x41f7563de If the cycle CSR is not accessible, we get an output like: => exception rdcyc

[PATCH v3 12/15] spl: mmc: Try to clean up raw-mode options

Make the raw-mode options depend on SPL_SYS_MMCSD_RAW_MODE in a more direct way. This makes it easier to understand the options with 'make menuconfig'. There are three different ways of specifying the offset: - sector offset - partition number - partition type So make these a choice, so it is mo

[PATCH v3 15/15] blk: Correct comment for blk_get_devnum_by_uclass_idname()

Update the comment to match the function. Fix the indentation while we are here. Signed-off-by: Simon Glass Reviewed-by: Sean Anderson Reviewed-by: Quentin Schulz --- Changes in v3: - Rebase to -next include/blk.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includ

[PATCH v3 14/15] spl: Create a function to init spl_load_info

Rather than having every caller set this up individually, create a common init function. This allows new fields to be added without the risk of them being left uninited. Signed-off-by: Simon Glass Reviewed-by: Michael Trimarchi --- Changes in v3: - Rebase on -next arch/arm/mach-imx/spl_imx_ro

[PATCH v3 13/15] spl: Use unified inline functions for spl_load_info

Rather than declaring completely separate functions, put the code for each case into the same function. This makes it easier to read. Signed-off-by: Simon Glass Reviewed-by: Sean Anderson Reviewed-by: Quentin Schulz --- (no changes since v1) include/spl.h | 18 +++--- 1 file chan

[PATCH v3 11/15] spl: mmc: Adjust args of spl_mmc_find_device()

At present spl_mmc_load() is the only caller of this function, passing it a boot_device, an index into the available MMC devices. Pass the device number instead, since it is known by the caller and simplifies the code. Signed-off-by: Simon Glass Reviewed-by: Sean Anderson Reviewed-by: Quentin Sc

[PATCH v3 10/15] spl: mmc: Handle error codes consistently

Use 'ret' as the return code, since it may not be an error and this is the common name in U-Boot. Make sure to return the error code when given, rather than transforming it into -1 (-EPERM). Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Update 'return ret' to 'return 0'

[PATCH v3 09/15] spl: mmc: Drop checks for CONFIG_SPL_LIBCOMMON_SUPPORT

This check is not needed now, since printf() resolved to nothing if not available. Drop the #ifdefs Signed-off-by: Simon Glass Reviewed-by: Sean Anderson Reviewed-by: Quentin Schulz --- (no changes since v1) common/spl/spl_mmc.c | 20 +--- 1 file changed, 1 insertion(+), 19 d

[PATCH v3 08/15] log: Avoid including function names by default

Unless function names are requested, the logging system should not compile these into the code. Adjust the macros to handle this. This means that turning on function names at runtime won't work unless CONFIG_LOGF_FUNC is enabled. We could perhaps split this into a separate option if that is a prob

[PATCH v3 07/15] mmc: Use logging instead of pr_err()

Use the log subsystem instead of dev, to avoid including function names in the code. The CONFIG_LOGF_FUNC option can be used to enable the function name. Signed-off-by: Simon Glass Reviewed-by: Sean Anderson --- Changes in v3: - Fix 'enver' typo while we are here - Put enhanced size back to de

[PATCH v3 06/15] mmc: Use logging instead of printf()

The code makes quite a few uses of __func__ which puts the function name into the resulting SPL image. Use the log subsystem instead, to reduce size. The CONFIG_LOGF_FUNC option can be used to enable the function name. Signed-off-by: Simon Glass --- Changes in v3: - Keep hex prefix on values wh

[PATCH v3 05/15] spl: Remove remaining #ifdef in spl_parse_image_header()

Define spl_set_header_raw_uboot() always so we can drop the last #ifdef in this function. Signed-off-by: Simon Glass Reviewed-by: Sean Anderson Reviewed-by: Quentin Schulz --- (no changes since v2) Changes in v2: - Avoid changing comment common/spl/spl.c | 10 -- 1 file changed, 4 i

[PATCH v3 04/15] spl: Remove some #ifdefs in spl_parse_image_header()

This function has a number of unnecessary #ifdefs so remove them. Signed-off-by: Simon Glass Reviewed-by: Sean Anderson Reviewed-by: Quentin Schulz --- (no changes since v1) common/spl/spl.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/common/s

[PATCH v3 03/15] spl: Correct use of CMD_BOOTI and CMD_BOOTZ

These should have a CONFIG_ prefix. Add it. Signed-off-by: Simon Glass Fixes: 7a0d88076b9 ("Add in the ability to load and boot an uncompr...") Reviewed-by: Sean Anderson Reviewed-by: Quentin Schulz --- (no changes since v1) common/spl/spl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 delet

[PATCH v3 02/15] rockchip: Move the default timer init to a common file

Rather than repeating the same code in two files (SPL and TPL), move it to a shared filed. Signed-off-by: Simon Glass Reviewed-by: Dragan Simic Reviewed-by: Quentin Schulz --- (no changes since v2) Changes in v2: - Drop unused constants from spl.c file arch/arm/include/asm/arch-rockchip/tim

[PATCH v3 01/15] configs: Resync with savedefconfig

Rsync all defconfig files using moveconfig.py Signed-off-by: Simon Glass --- (no changes since v1) configs/am62px_evm_a53_defconfig | 4 ++-- configs/am64x_evm_a53_defconfig| 6 +++--- configs/j721e_beagleboneai64_a72_defconfig | 4 ++-- configs/j721e_evm_a72_defconfig

  1   2   >