Re: [PATCH v2] tools: Add script to update git subtree projects

2024-07-22 Thread Ilias Apalodimas
On Mon, 22 Jul 2024 at 22:31, Raymond Mao wrote: > > Recently we are introducing multiple git subtree projects and > it is the right time to have a universal script to update > various subtrees and replace the dts/update-dts-subtree.sh. > > update-subtree.sh is a wrapper of git subtree commands. >

Re: [PATCH] efi_loader: add /dtbs search path

2024-07-22 Thread Ilias Apalodimas
On Mon, 22 Jul 2024 at 20:55, Caleb Connolly wrote: > > Add an additional search path /dtbs, this is where dtbs are installed on > postmarketOS and potentially other distros. > > Signed-off-by: Caleb Connolly > --- > lib/efi_loader/efi_fdt.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --

Re: [PATCH] efi_loader: add /dtbs search path

2024-07-22 Thread Heinrich Schuchardt
On 7/22/24 19:55, Caleb Connolly wrote: Add an additional search path /dtbs, this is where dtbs are installed on postmarketOS and potentially other distros. Signed-off-by: Caleb Connolly --- lib/efi_loader/efi_fdt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/efi_loader/efi_fd

Re: [PATCH v2 0/5] arm: exynos: Enable TRNG for E850-96 board

2024-07-22 Thread Minkyu Kang
Hi, 2024년 7월 23일 (화) 03:17, Sam Protsenko 님이 작성: > Hi Minkyu, > > Can you please take a look at this series? And also my MMC series [1] > has been pending for a while now, if it's ok with you -- can you > please apply it? > > Thanks! > > [1] https://lists.denx.de/pipermail/u-boot/2024-July/55960

Re: [PATCH v3 7/8] dts: starfive: Add JH7110 Cadence USB dts node

2024-07-22 Thread E Shattow
On Mon, Jul 22, 2024 at 6:29 PM Minda Chen wrote: > > > > > > > On Sat, Jul 20, 2024 at 6:47 PM E Shattow wrote: > > > > > > Hi, I am testing on Milk-V Mars CM Lite, and I add to these devicetree > > > changes at runtime from board/starfive/visionfive2/spl.c > > > > > > On Thu, Jul 18, 2024 at 6:

[ANN] U-Boot v2024.10-rc1 released

2024-07-22 Thread Tom Rini
Hey all, It's release day and here is -rc1. Looking at my own queue, I think it's in OK shape, but there's a few things I want to take still, and I need to check some other areas for mature changes to pull in as well. In terms of a changelog, git log --merges v2024.07..v2024.10-rc1 contains what

Re: [GIT PULL] Please pull u-boot-imx-master-20240722

2024-07-22 Thread Tom Rini
g repo [1] into > dts/upstream (2024-07-20 11:15:22 -0600) > > are available in the Git repository at: > > https://gitlab.denx.de/u-boot/custodians/u-boot-imx.git > tags/u-boot-imx-master-20240722 > > for you to fetch changes up to a9c962941e119017eb9d5985c5c214d9711c9433

Re: [PATCH v2] tools: Add script to update git subtree projects

2024-07-22 Thread Tom Rini
On Mon, Jul 22, 2024 at 12:30:50PM -0700, Raymond Mao wrote: > Recently we are introducing multiple git subtree projects and > it is the right time to have a universal script to update > various subtrees and replace the dts/update-dts-subtree.sh. > > update-subtree.sh is a wrapper of git subtree

Re: [PATCH v3 7/8] dts: starfive: Add JH7110 Cadence USB dts node

2024-07-22 Thread Minda Chen
> > On Sat, Jul 20, 2024 at 6:47 PM E Shattow wrote: > > > > Hi, I am testing on Milk-V Mars CM Lite, and I add to these devicetree > > changes at runtime from board/starfive/visionfive2/spl.c > > > > On Thu, Jul 18, 2024 at 6:38 PM Minda Chen > wrote: > > > > > > Add Jh7110 Cadence USB dts no

Re: [PATCH v2 4/4] usb: gadget: atmel: Add DM_USB_GADGET support

2024-07-22 Thread Marek Vasut
On 7/22/24 10:23 PM, Zixun LI wrote: [...] +static int usba_udc_probe(struct udevice *dev) +{ + struct usba_priv_data *priv = dev_get_priv(dev); + int ret; + + ret = usba_udc_clk_init(dev, &priv->clks); + if (ret) + return ret; + + controller = &udc_c

Re: [PATCH v2 3/4] usb: gadget: atmel: Add attach/detach support

2024-07-22 Thread Marek Vasut
On 7/22/24 10:23 PM, Zixun LI wrote: Add controller attach/detach support by using usb_gadget_ops.pullup() method. Signed-off-by: Zixun LI Reviewed-by: Marek Vasut Thanks !

Re: [PATCH v2 2/4] usb: gadget: atmel: Code refactor part 2

2024-07-22 Thread Marek Vasut
On 7/22/24 10:23 PM, Zixun LI wrote: - Rename atmel_usba_start() / atmel_usba_stop() to usba_udc_enable() / usba_udc_disable(), remove atmel_ prefix to be inline with other functions. Also avoid confusion with DM start() / stop() functions. - Replace printf() by log_err() - Spelling paramte

Re: [PATCH v2 1/4] usb: gadget: atmel: Code refactor part 1

2024-07-22 Thread Marek Vasut
On 7/22/24 10:23 PM, Zixun LI wrote: - Sort includes - Forward declare controller structures Please pick some more descriptive subject for this patch than "refactor part 1". If this was only sorting includes as a singular patch doing one change, the subject could well be "usb: gadget: atmel:

[PATCH 15/15] include: Remove duplicate newlines

2024-07-22 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- Cc: Francesco Dolcini Cc: Sean Anderson Cc: Simon Glass Cc: Tom Rini Cc: u-boot@lists.denx.de --- include/ata.h| 2 -- include/blkmap.h | 1 - include/bzlib.h | 6 -- include

[PATCH 12/15] include: usb: Remove duplicate newlines

2024-07-22 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- include/usb/ci_udc.h | 1 - include/usb/ulpi.h | 2 -- include/usb/xhci.h | 4 3 files changed, 7 deletions(-) diff --git a/include/usb/ci_udc.h b/include/usb/ci_udc.h index 06adb2bb4d3..9f15dbabe53 10064

[PATCH 11/15] include: u-boot: Remove duplicate newlines

2024-07-22 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- include/u-boot/sha512.h | 1 - include/u-boot/zlib.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/include/u-boot/sha512.h b/include/u-boot/sha512.h index 90bd96a3f8c..83c2119cd26 100644 --- a/include/u-b

[PATCH 13/15] include: valgrind: Remove duplicate newlines

2024-07-22 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- include/valgrind/memcheck.h | 6 -- include/valgrind/valgrind.h | 15 --- 2 files changed, 21 deletions(-) diff --git a/include/valgrind/memcheck.h b/include/valgrind/memcheck.h index 501cb14ed8a.

[PATCH 14/15] include: zfs: Remove duplicate newlines

2024-07-22 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- include/zfs/spa.h | 1 - include/zfs/zfs.h | 1 - include/zfs/zfs_acl.h | 1 - 3 files changed, 3 deletions(-) diff --git a/include/zfs/spa.h b/include/zfs/spa.h index cd2ddf58e77..df01d4964fb 100644 --- a

[PATCH 10/15] include: power: Remove duplicate newlines

2024-07-22 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- include/power/max17042_fg.h | 1 - include/power/tps65910.h| 1 - 2 files changed, 2 deletions(-) diff --git a/include/power/max17042_fg.h b/include/power/max17042_fg.h index ec8377d3707..e417012459d 100644 --

[PATCH 08/15] include: mtd: Remove duplicate newlines

2024-07-22 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- include/mtd/ubi-user.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/mtd/ubi-user.h b/include/mtd/ubi-user.h index 8d472cc0138..cc95fa2edea 100644 --- a/include/mtd/ubi-user.h +++ b/include/mtd/ubi-use

[PATCH 06/15] include: jffs2: Remove duplicate newlines

2024-07-22 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- include/jffs2/jffs2.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/jffs2/jffs2.h b/include/jffs2/jffs2.h index 651f94cf381..e986508c2cc 100644 --- a/include/jffs2/jffs2.h +++ b/include/jffs2/jffs2.h

[PATCH 09/15] include: net: Remove duplicate newlines

2024-07-22 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- include/net/sntp.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/net/sntp.h b/include/net/sntp.h index 30b44d1c066..5dd9aa36fea 100644 --- a/include/net/sntp.h +++ b/include/net/sntp.h @@ -9,7 +9,6 @@

[PATCH 07/15] include: linux: Remove duplicate newlines

2024-07-22 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- include/linux/asn1.h | 1 - include/linux/bitops.h | 1 - include/linux/byteorder/swab.h | 2 -- include/linux/edd.h | 1 - include/linux/err.h | 1 - include/

[PATCH 05/15] include: fsl-mc: Remove duplicate newlines

2024-07-22 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- include/fsl-mc/fsl_dprc.h | 1 - include/fsl-mc/fsl_mc_cmd.h | 1 - include/fsl-mc/fsl_qbman_portal.h | 2 -- 3 files changed, 4 deletions(-) diff --git a/include/fsl-mc/fsl_dprc.h b/include/fsl-mc/f

[PATCH 04/15] include: firmware: Remove duplicate newlines

2024-07-22 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- include/firmware/imx/sci/rpc.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/firmware/imx/sci/rpc.h b/include/firmware/imx/sci/rpc.h index 85af6f3996e..28adec2a8e1 100644 --- a/include/firmware/imx/sci

[PATCH 03/15] include: dt-bindings: Remove duplicate newlines

2024-07-22 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- include/dt-bindings/clock/mt8516-clk.h | 1 - include/dt-bindings/clock/qcom,gcc-msm8996.h | 1 - include/dt-bindings/clock/qcom,rpmh.h| 1 - include/dt-bindings/clock/tegra210-car.h | 1 - includ

[PATCH 02/15] include: dm: Remove duplicate newlines

2024-07-22 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- include/dm/of_addr.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/dm/of_addr.h b/include/dm/of_addr.h index e7f3a280817..5fb5a4855b4 100644 --- a/include/dm/of_addr.h +++ b/include/dm/of_addr.h @@ -44

[PATCH 01/15] include: asm-generic: Remove duplicate newlines

2024-07-22 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- include/asm-generic/int-ll64.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/asm-generic/int-ll64.h b/include/asm-generic/int-ll64.h index 7451718a61c..aa572021cc0 100644 --- a/include/asm-generic/int-

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

2024-07-22 Thread Fabio Estevam
On Thu, Jul 11, 2024 at 2:56 AM Michael Nazzareno Trimarchi wrote: > I will rephrase the commit message It looks good as is. Applied all, thanks.

Re: [PATCH v2 1/4] udoo_neo: Convert to watchdog driver model

2024-07-22 Thread Fabio Estevam
On Fri, Jul 19, 2024 at 5:33 PM Fabio Estevam wrote: > > Commit 68dcbdd594d4 ("ARM: imx: Add weak default reset_cpu()") caused > the 'reset' command in U-Boot to not cause a board reset. > > Fix it by switching to the watchdog driver model via sysreset, which > is the preferred method for implemen

Re: [PATCH] imx93-u-boot: Describe the CPU clocks in the devicetree

2024-07-22 Thread Fabio Estevam
On Thu, Jul 18, 2024 at 1:55 PM Fabio Estevam wrote: > > Currently, there is an error when the i.MX93 CPU frequency is > read: > > Could not read CPU frequency: -2 > CPU: NXP i.MX93(52) Rev1.1 A55 at 0 MHz > > Fix it by describing the A55 clock nodes in the devicetree, like done > on other i.MX

Re: [PATCH] clk: imx6q: Add definition for IMX6QDL_CLK_PWM1

2024-07-22 Thread Fabio Estevam
On Fri, Jul 12, 2024 at 8:10 PM Emil Kronborg wrote: > > Enabling CONFIG_CMD_PWM, and consequently CONFIG_DM_PWM, causes the pwm > command to fail due to a missing clock. > > => pwm enable 0 0 > Enable clock-controller@20c4000 failed > Failed to enable per_clk > pwm: '0' not found

Re: [PATCH] clk: imx6q: Add definition for IMX6QDL_CLK_I2C3

2024-07-22 Thread Fabio Estevam
On Fri, Jul 12, 2024 at 8:10 PM Emil Kronborg wrote: > > Commit 727fa4539ca2 ("clk: Add support for I2C clocks on NXP's imx6q SoC > which use CCF") added I2C clocks for I2C1 and I2C2, but not I2C3. > Consequently, devices using I2C3 fail after enabling CONFIG_CLK_IMX6Q > and thus CONFIG_CLK. There

Re: [PATCH] kontron-sl-mx6ul: switch to DM_SERIAL

2024-07-22 Thread Fabio Estevam
On Sat, Jul 20, 2024 at 12:54 PM Anatolij Gustschin wrote: > > Enable DM_SERIAL to avoid board removal warning. > > Signed-off-by: Anatolij Gustschin > Cc: Frieder Schrempf Applied, thanks.

Re: [PATCH] mx6boards: convert to DM_I2C and DM_SERIAL

2024-07-22 Thread Fabio Estevam
On Sat, Jul 20, 2024 at 12:36 PM Anatolij Gustschin wrote: > > Rework to remove use of legacy I2C API. Also switch > to DM_SERIAL to avoid board removal warning. > > Signed-off-by: Anatolij Gustschin > Cc: Eric Bénard Applied, thanks.

Re: [PATCH] nitrogen6x: convert to DM_I2C and DM_SERIAL

2024-07-22 Thread Fabio Estevam
On Sat, Jul 20, 2024 at 9:50 AM Anatolij Gustschin wrote: > > Rework to remove use of legacy I2C API. Also switch > to DM_SERIAL to avoid board removal warning. > > Signed-off-by: Anatolij Gustschin > Cc: Troy Kisky Applied, thanks.

[GIT PULL] Please pull u-boot-imx-master-20240722

2024-07-22 Thread Fabio Estevam
: https://gitlab.denx.de/u-boot/custodians/u-boot-imx.git tags/u-boot-imx-master-20240722 for you to fetch changes up to a9c962941e119017eb9d5985c5c214d9711c9433: kontron-sl-mx6ul: switch to DM_SERIAL (2024-07-22 17:55:35 -0300) u-boot-imx-master-20240722 --

Re: [PATCH v2] tools: Add script to update git subtree projects

2024-07-22 Thread Jerome Forissier
On 7/22/24 21:30, Raymond Mao wrote: > Recently we are introducing multiple git subtree projects and > it is the right time to have a universal script to update > various subtrees and replace the dts/update-dts-subtree.sh. > > update-subtree.sh is a wrapper of git subtree commands. > > Usage:

Re: [PATCH 01/40] drivers: ata: Remove duplicate newlines

2024-07-22 Thread Tom Rini
On Sat, 20 Jul 2024 14:40:26 +0200, Marek Vasut wrote: > Drop all duplicate newlines. No functional change. > > Applied to u-boot/master, thanks! -- Tom

Re: [PATCH 01/37] board: BuS: Remove duplicate newlines

2024-07-22 Thread Tom Rini
On Fri, 19 Jul 2024 12:48:38 +0200, Marek Vasut wrote: > Drop all duplicate newlines. No functional change. > > Applied to u-boot/master, thanks! -- Tom

Re: [GIT PULL] u-boot-riscv/master

2024-07-22 Thread Tom Rini
On Mon, Jul 22, 2024 at 04:29:39PM +0800, Leo Liang wrote: > Hi Tom, > > The following changes since commit 5024a96db8ea6ff2e814f4599af9e5faf09296b7: > > Subtree merge tag 'v6.10-dts' of devicetree-rebasing repo [1] into > dts/upstream (2024-07-20 11:15:22 -0600) > > are available in the Git

[PATCH v2] tools: Add script to update git subtree projects

2024-07-22 Thread Raymond Mao
Recently we are introducing multiple git subtree projects and it is the right time to have a universal script to update various subtrees and replace the dts/update-dts-subtree.sh. update-subtree.sh is a wrapper of git subtree commands. Usage: From U-Boot top directory, run $ ./tools/update-subtre

Re: [PATCH v2 0/5] arm: exynos: Enable TRNG for E850-96 board

2024-07-22 Thread Sam Protsenko
Hi Minkyu, Can you please take a look at this series? And also my MMC series [1] has been pending for a while now, if it's ok with you -- can you please apply it? Thanks! [1] https://lists.denx.de/pipermail/u-boot/2024-July/559602.html On Mon, Jul 15, 2024 at 10:17 PM Sam Protsenko wrote: > >

[PATCH v2] warp7: Convert to OF_UPSTREAM

2024-07-22 Thread Fabio Estevam
Instead of using the local imx7s-warp devicetree copies from U-Boot, convert the imx7s-warp board to OF_UPSTREAM so that the upstream kernel devicetree can be used instead. Signed-off-by: Fabio Estevam --- Changes since v1: - Also change warp7_bl33_defconfig. arch/arm/dts/Makefile | 1

[PATCH v3 38/38] doc: samsung: Mention enabled eMMC in E850-96 board doc

2024-07-22 Thread Sam Protsenko
eMMC is enabled on E850-96 board now. Mention that in the board documentation. Signed-off-by: Sam Protsenko --- Changes in v3: - (none) Changes in v2: - (none) doc/board/samsung/e850-96.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/board/samsung/e850-96.r

[PATCH v3 37/38] configs: e850-96: Enable MMC

2024-07-22 Thread Sam Protsenko
Enable MMC subsystem and DW MMC driver support to make eMMC functional. Also enable a couple of related commands so the user can make use of eMMC from U-Boot shell. Signed-off-by: Sam Protsenko --- Changes in v3: - (none) Changes in v2: - (none) configs/e850-96_defconfig | 10 +- 1

[PATCH v3 36/38] arm: dts: exynos: Remove outdated DW MMC properties in all Exynos dts

2024-07-22 Thread Sam Protsenko
Upstream properties were added to device trees to follow current Linux kernel. DW MMC driver was updated accordingly. Safely remove outdated MMC properties. Details on removed properties are as follows: * samsung,removable: replaced by non-removable * samsung,bus-width: replaced by bus-width * sam

[PATCH v3 35/38] mmc: exynos_dw_mmc: Improve coding style

2024-07-22 Thread Sam Protsenko
Fix most of checkpatch warnings and other obvious style issues. No functional change. Signed-off-by: Sam Protsenko --- Changes in v3: - (none) Changes in v2: - (none) arch/arm/mach-exynos/include/mach/dwmmc.h | 36 +-- drivers/mmc/exynos_dw_mmc.c | 26 +++

[PATCH v3 34/38] mmc: exynos_dw_mmc: Use dev->name as driver's displayed name

2024-07-22 Thread Sam Protsenko
Reduce U-Boot footprint by reusing dev->name as a driver's displayed name. This changes boot device name (and "mmc info" output) from "EXYNOS DWMMC" to something like "mmc@1210". Signed-off-by: Sam Protsenko --- Changes in v3: - (none) Changes in v2: - (none) drivers/mmc/exynos_dw_mmc.

[PATCH v3 33/38] mmc: exynos_dw_mmc: Don't call dwmci_setup_cfg() after add_dwmci()

2024-07-22 Thread Sam Protsenko
add_dwmci() is already calling dwmci_setup_cfg() internally, there is no needed to call dwmci_setup_cfg() again in case when add_dwmci() is used (for non-DM cases). Fix it by calling dwmci_setup_cfg() only in DM cases, when add_dwmci() wasn't called. Also, this assignment: host->mmc = &plat->m

[PATCH v3 32/38] mmc: exynos_dw_mmc: Pull all init code into probe function

2024-07-22 Thread Sam Protsenko
There is no logical sense to split the initialization code between multiple functions. Pull both do_dwmci_init() and exynos_dwmci_core_init() into exynos_dwmmc_probe() to make the code more simple and obvious. No functional change. Signed-off-by: Sam Protsenko --- Changes in v3: - (none) Chan

[PATCH v3 31/38] mmc: exynos_dw_mmc: Add support for ARM64 Exynos chips

2024-07-22 Thread Sam Protsenko
Add the compatible entry and corresponding chip data for Exynos7 compatible chips, which covers modern ARM64 based Exynos chips. They have some differences w.r.t. old ARM32 Exynos chips: - CLKSEL register offset is different - 64-bit IDMAC descriptor and 64-bit IDMAC registers are used (imp

[PATCH v3 29/38] mmc: exynos_dw_mmc: Read and use DDR timing when available

2024-07-22 Thread Sam Protsenko
DDR timing values should be defined in "samsung,dw-mshc-ddr-timing" dts property, and used when DDR MMC mode is selected. Read that value from dts and use it. If it's not available, use SDR timing values instead. This change is following upstream Linux kernel implementation. Signed-off-by: Sam Pro

[PATCH v3 30/38] mmc: exynos_dw_mmc: Set requested freq in get_mmc_clk() callback

2024-07-22 Thread Sam Protsenko
By now exynos_dw_mmc driver was relying on the correct CIU clock frequency being set on driver init. But dw_mmc core is actually trying to change CIU clock rate dynamically, on init and in set_ios() callback, which it's requesting via host->get_mmc_clk() callback (the name is misleading: although i

[PATCH v3 28/38] mmc: exynos_dw_mmc: Move quirks from struct dwmci_host to chip data

2024-07-22 Thread Sam Protsenko
host->quirks field is only used internally in exynos_dw_mmc.c driver. To avoid cluttering the scope of struct dwmci_host, move quirks field into Exynos driver's chip data, where it can be statically defined. No functional change. Signed-off-by: Sam Protsenko --- Changes in v3: - (none) Change

[PATCH v3 27/38] mmc: exynos_dw_mmc: Read common clock-frequency property

2024-07-22 Thread Sam Protsenko
Instead of using non-standard "bus_hz" dts property, read common "clock-frequency" property used in upstream Linux kernel. It's safe to do so, as "clock-frequency" property was already added to corresponding nodes in all affected Exynos device tree files. No functional change. Signed-off-by: Sam

[PATCH v3 26/38] mmc: exynos_dw_mmc: Read common bus-width property

2024-07-22 Thread Sam Protsenko
Instead of using non-standard "samsung,bus-width" dts property, read common "bus-width" property used in upstream Linux kernel. It's safe to do so, as "bus-width" property was already added to corresponding nodes in all affected Exynos device tree files. No functional change. Signed-off-by: Sam P

[PATCH v3 25/38] mmc: exynos_dw_mmc: Refactor fixed CIU clock divider

2024-07-22 Thread Sam Protsenko
Some chips like Exynos4412 have fixed internal CIU clock divider. Instead of reading it from non-standard "div" dts property, store its value in the driver internally, in static chip data associated with corresponding compatible. This makes it possible to avoid using host->div for storing it, so th

[PATCH v3 24/38] mmc: exynos_dw_mmc: Abstract CLKSEL register

2024-07-22 Thread Sam Protsenko
CLKSEL register offset may vary between different Exynos chips, e.g. on ARM64 vs ARM32 chips. Provide a way to specify its offset value for each compatible instead of hard-coding its value in read/write calls. No functional change. Signed-off-by: Sam Protsenko --- Changes in v3: - (none) Chan

[PATCH v3 23/38] mmc: exynos_dw_mmc: Read upstream SDR timing properties

2024-07-22 Thread Sam Protsenko
The obsolete "samsung,timing" dts property is now split into "samsung,dw-mshc-ciu-div" (for holding the internal DW MMC divider value) and "samsung,dw-mshc-sdr-timing" (for actual timing values) in upstream Linux kernel. Rework the driver to make use of new properties instead of the old one. All af

[PATCH v3 22/38] mmc: exynos_dw_mmc: Convert to use livetree API

2024-07-22 Thread Sam Protsenko
Update the driver to use livetree API instead of FDT one. No functional change. Signed-off-by: Sam Protsenko --- Changes in v3: - (none) Changes in v2: - Moved exynos_dwmmc_of_to_plat() under #ifdef CONFIG_DM_MMC stanza drivers/mmc/exynos_dw_mmc.c | 17 - 1 file changed, 8

[PATCH v3 21/38] mmc: exynos_dw_mmc: Use .of_to_plat for device tree parsing

2024-07-22 Thread Sam Protsenko
exynos_dwmci_get_config() is called from the probe function and used to read data from device tree. Make use of .of_to_plat driver callback instead, and convert exynos_dwmci_get_config() to match its signature. No functional change. Signed-off-by: Sam Protsenko --- Changes in v3: - (none) Cha

[PATCH v3 20/38] mmc: exynos_dw_mmc: Obtain and use CIU clock via CCF API

2024-07-22 Thread Sam Protsenko
New Exynos chips should implement clock drivers using CCF framework. In that case corresponding CCF functions can be used to get/set the clock rates. Moreover, already existing get_mmc_clk() and set_mmc_clk() calls are only implemented for CONFIG_CPU_V7A (i.e. ARM32 chips). In case of ARM64 chips t

[PATCH v3 19/38] mmc: exynos_dw_mmc: Don't call pinmux functions on ARM64 chips

2024-07-22 Thread Sam Protsenko
Pinmux configuration on ARM64 platforms must be performed during startup in pinctrl driver using info from device tree. exynos_pinmux_config() and pinmux_decode_periph_id() are only available on ARM32 platforms, so don't call those functions on ARM64 platforms. Instead of the latter function, use "

[PATCH v3 16/38] arm: exynos: Add header guard for dwmmc.h

2024-07-22 Thread Sam Protsenko
Add missing header guard to prevent possible build errors. Fixes: 77b55e8cfcee ("ARM: exynos: move SoC sources to mach-exynos") Signed-off-by: Sam Protsenko --- Changes in v3: - (none) Changes in v2: - (none) arch/arm/mach-exynos/include/mach/dwmmc.h | 5 + 1 file changed, 5 insertions

[PATCH v3 18/38] mmc: exynos_dw_mmc: Fix getting private data in exynos_dwmci_board_init()

2024-07-22 Thread Sam Protsenko
In case of CONFIG_DM_MMC, host->priv actually holds (struct udevice *), and not (struct dwmci_exynos_priv_data *). This makes *priv pointer invalid and may lead to Synchronous Abort during its dereference later in exynos_dwmci_board_init(). Fix it by extracting exynos_dwmmc_get_priv() helper from e

[PATCH v3 17/38] mmc: exynos_dw_mmc: Fix obtaining the base address of controller

2024-07-22 Thread Sam Protsenko
Getting the base address with outdated fdtdec_get_addr() API and further casting it to (void *) leads to next build warning on ARM64 platforms: In function 'exynos_dwmci_get_config': warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] hos

[PATCH v3 15/38] dt-bindings: exynos: Update bindings doc for DW MMC controller

2024-07-22 Thread Sam Protsenko
Update the bindings doc for Exynos DW MMC block to follow the upstream example and reflect the latest changes made in corresponding Linux kernel bindings. Signed-off-by: Sam Protsenko --- Changes in v3: - (none) Changes in v2: - (none) doc/device-tree-bindings/exynos/dwmmc.txt | 46 +++

[PATCH v3 14/38] arm: dts: exynos: Add upstream DW MMC properties to all Exynos dts

2024-07-22 Thread Sam Protsenko
Some device tree properties for DW MMC block were updated in Linux kernel. Let's follow its example and rework corresponding properties in all Exynos device trees. Don't remove outdated properties yet, it'll be done later once DW MMC driver is updated accordingly to read the updated properties inst

[PATCH v3 11/38] mmc: dw_mmc: Replace fifoth_val property with fifo-depth

2024-07-22 Thread Sam Protsenko
Replace fifoth_val property with its fifo-depth counterpart in all DW MMC drivers. fifo-depth is a common property used in upstream Linux kernel. The FIFOTH register value will be calculated using fifo-depth value in DW MMC core (dw_mmc.c). This change reduces code duplication in platform drivers,

[PATCH v3 13/38] mmc: dw_mmc: Improve coding style

2024-07-22 Thread Sam Protsenko
Fix most of checkpatch warnings and other obvious style issues. No functional change. Signed-off-by: Sam Protsenko Reviewed-by: Quentin Schulz --- Changes in v3: - (none) Changes in v2: - Added R-b tag from Quentin drivers/mmc/dw_mmc.c | 69 ++-- include/dwmmc.h | 1

[PATCH v3 12/38] mmc: dw_mmc: Fix kernel-doc comments in dwmmc.h

2024-07-22 Thread Sam Protsenko
Rework kernel-doc comments in dwmmc.h header so it's actually possible to generate a proper documentation from it usin scripts/kernel-doc script, with no errors. No functional change. Signed-off-by: Sam Protsenko --- Changes in v3: - (none) Changes in v2: - (none) include/dwmmc.h | 41 +++

[PATCH v3 10/38] mmc: dw_mmc: Add support for 64-bit IDMAC

2024-07-22 Thread Sam Protsenko
Some DW MMC blocks (e.g. those on modern Exynos chips) support 64-bit DMA addressing mode. 64-bit DW MMC variants differ from their 32-bit counterparts: - the register layout is a bit different (because there are additional IDMAC registers present for storing upper part of 64-bit addresses)

[PATCH v3 09/38] mmc: dw_mmc: Improve 32-bit IDMAC descriptor namings

2024-07-22 Thread Sam Protsenko
Prepare for adding 64-bit IDMAC descriptors by renaming current 32-bit descriptor and its fields accordingly. While at it, make use of virt_to_phys() to make it more obvious in which places the physical addresses have to be used. No functional change. Signed-off-by: Sam Protsenko --- Changes in

[PATCH v3 08/38] mmc: dw_mmc: Extract setting the DMA descriptor into a separate routine

2024-07-22 Thread Sam Protsenko
Make dwmci_prepare_data() function easier to read by extracting the preparation of IDMAC descriptor into a dedicated function. No functional change. Signed-off-by: Sam Protsenko Reviewed-by: Quentin Schulz --- Changes in v3: - (none) Changes in v2: - Added R-b tag from Quentin drivers/mm

[PATCH v3 06/38] mmc: dw_mmc: Extract FIFO data transfer into a separate routine

2024-07-22 Thread Sam Protsenko
FIFO data transfer is implemented as quite a massive chunk of code. Extract it into a dedicated function to make dwmci_data_transfer() easier to read and reduce the indentation level of the code. No functional change. Signed-off-by: Sam Protsenko --- Changes in v3: - (none) Changes in v2: -

[PATCH v3 07/38] mmc: dw_mmc: Extract DMA transfer handling code into a separate routine

2024-07-22 Thread Sam Protsenko
Make dwmci_send_cmd() easier to read by moving the DMA transfer handling code into a dedicated function. No functional change. Signed-off-by: Sam Protsenko Reviewed-by: Quentin Schulz --- Changes in v3: - (none) Changes in v2: - Added R-b tag from Quentin drivers/mmc/dw_mmc.c | 51 ++

[PATCH v3 05/38] mmc: dw_mmc: Extract divider update to a separate function

2024-07-22 Thread Sam Protsenko
Extract the clock divider update into dwmci_update_div() function. It's a procedure recommended in TRM, so it's better to keep it in a dedicated function to make the code clearer. While at it also extract the clock control code into a separate routine to avoid code duplication in dwmci_setup_bus()

[PATCH v3 04/38] mmc: dw_mmc: Extract FIFO init into a separate routine

2024-07-22 Thread Sam Protsenko
Move FIFO threshold initialization into a separate function to make dwmci_init() more readable. No functional change. Signed-off-by: Sam Protsenko Reviewed-by: Quentin Schulz --- Changes in v3: - (none) Changes in v2: - Added R-b tag from Quentin drivers/mmc/dw_mmc.c | 25 +++

[PATCH v3 03/38] mmc: dw_mmc: Extract waiting for data busy into a separate routine

2024-07-22 Thread Sam Protsenko
Waiting for data busy is a logically separate operation and should be implemented as a separate routine. Follow Linux kernel example and extract it from dwmci_send_cmd(). This way it doesn't clutter dwmci_send_cmd() function, and can be reused later in other cases. No functional change. Signed-of

[PATCH v3 02/38] mmc: dw_mmc: Move struct idmac to dw_mmc.c

2024-07-22 Thread Sam Protsenko
struct idmac is only used in dw_mmc.c, so move it there from dwmmc.h to avoid cluttering the interface in the header. No functional change. Signed-off-by: Sam Protsenko Reviewed-by: Quentin Schulz --- Changes in v3: - (none) Changes in v2: - Added R-b tag from Quentin drivers/mmc/dw_mmc.

[PATCH v3 01/38] mmc: dw_mmc: Remove unused version field from struct dwmci_host

2024-07-22 Thread Sam Protsenko
Nobody seems to use it, so just remove it. No functional change. Signed-off-by: Sam Protsenko Reviewed-by: Quentin Schulz --- Changes in v3: - (none) Changes in v2: - Added R-b tag from Quentin include/dwmmc.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/dwmmc.h b/include/d

[PATCH v3 00/38] mmc: dw_mmc: Enable eMMC on E850-96 board

2024-07-22 Thread Sam Protsenko
Bring 64-bit support to dw_mmc core and Exynos dw_mmc drivers, and enable it on E850-96 board. Additionally do some related cleanups and device tree updates. 64-bit version of DesignWare MMC can be often found on modern ARM64 chips. It's different from its older 32-bit version (which is already im

[PATCH] efi_loader: add /dtbs search path

2024-07-22 Thread Caleb Connolly
Add an additional search path /dtbs, this is where dtbs are installed on postmarketOS and potentially other distros. Signed-off-by: Caleb Connolly --- lib/efi_loader/efi_fdt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/efi_loader/efi_fdt.c b/lib/efi_loader/efi_fdt.c index 86ba00c

RE: usb gadget driver initialization issue

2024-07-22 Thread Zixun Li
> -Original Message- > From: Marek Vasut > Sent: Saturday, July 20, 2024 22:12 > > Can you please send an RFC patch ? > > > I see recently there are many DM related reworking, please forgive me > > if it's already on the Todo list. > > It is not on the ToDo list, no. > > +CC Mattijs H

Re: [RFC PATCH v2 00/48] Make U-Boot memory reservations coherent

2024-07-22 Thread Sughosh Ganu
On Mon, 22 Jul 2024 at 23:03, Tom Rini wrote: > > On Mon, Jul 22, 2024 at 11:58:18AM +0530, Sughosh Ganu wrote: > > On Mon, 8 Jul 2024 at 19:32, Tom Rini wrote: > > > > > > On Thu, Jul 04, 2024 at 01:04:56PM +0530, Sughosh Ganu wrote: > > > > > > > The aim of this patch series is to fix the curre

Re: [PATCH v5 04/11] doc: uefi: document dynamic UUID generation

2024-07-22 Thread Sughosh Ganu
hi Caleb, On Fri, 19 Jul 2024 at 18:14, Caleb Connolly wrote: > > Document how platforms can generate GUIDs at runtime rather than > maintaining a list of UUIDs per-board. > > Reviewed-by: Ilias Apalodimas > Signed-off-by: Caleb Connolly > --- > doc/develop/uefi/uefi.rst | 27 +

Re: [RFC PATCH v2 00/48] Make U-Boot memory reservations coherent

2024-07-22 Thread Tom Rini
On Mon, Jul 22, 2024 at 11:58:18AM +0530, Sughosh Ganu wrote: > On Mon, 8 Jul 2024 at 19:32, Tom Rini wrote: > > > > On Thu, Jul 04, 2024 at 01:04:56PM +0530, Sughosh Ganu wrote: > > > > > The aim of this patch series is to fix the current state of > > > incoherence between modules when it comes t

Re: [PATCH V6 2/6] doc: ti: k3: Add TIFS Stub documentation

2024-07-22 Thread Nishanth Menon
On 12:33-20240719, Dhruva Gole wrote: > + > +.. k3_rst_include_end_boot_firmwares > +.. k3_rst_include_start_lpm_firmware s/lpm/tifsstub ? > + > +* **TIFS Stub** - A small piece of code that helps restore the remaining > + context and resume the TIFS firmware when resuming from Low Power M

Re: [PATCH v4 08/29] hash: integrate hash on mbedtls

2024-07-22 Thread Raymond Mao
Hi Simon, On Sat, 20 Jul 2024 at 08:36, Simon Glass wrote: > Hi Tom, > > On Fri, 19 Jul 2024 at 16:25, Tom Rini wrote: > > > > On Fri, Jul 19, 2024 at 04:05:09PM +0100, Simon Glass wrote: > > > Hi Raymond, > > > > > > On Thu, 18 Jul 2024 at 17:46, Raymond Mao > wrote: > > > > > > > > Hi Simon,

Re: [PATCH v4 08/29] hash: integrate hash on mbedtls

2024-07-22 Thread Raymond Mao
Hi Tom, On Sat, 20 Jul 2024 at 13:13, Tom Rini wrote: > On Sat, Jul 20, 2024 at 01:36:02PM +0100, Simon Glass wrote: > > Hi Tom, > > > > On Fri, 19 Jul 2024 at 16:25, Tom Rini wrote: > > > > > > On Fri, Jul 19, 2024 at 04:05:09PM +0100, Simon Glass wrote: > > > > Hi Raymond, > > > > > > > > On

Re: [PATCH] tools: Add script to update git subtree projects

2024-07-22 Thread Jerome Forissier
On 7/19/24 16:12, Raymond Mao wrote: > Recently we are introducing multiple git subtree projects and > it is the right time to have a universal script to update > various subtrees and replace the dts/update-dts-subtree.sh. > > update-subtree.sh is a wrapper of git subtree commands. > > Usage:

Re: [PATCH v2 02/14] spl: Correct use of CMD_BOOTI and CMD_BOOTZ

2024-07-22 Thread Quentin Schulz
Hi Simon, On 7/21/24 5:25 PM, Simon Glass wrote: These should have a CONFIG_ prefix. Add it. Signed-off-by: Simon Glass Fixes: 7a0d88076b9 ("Add in the ability to load and boot an uncompr...") Reviewed-by: Sean Anderson --- (no changes since v1) common/spl/spl.c | 4 ++-- 1 file changed,

Re: [RFC PATCH v2 38/48] lib: Kconfig: add a config symbol for getting lmb memory map updates

2024-07-22 Thread Sughosh Ganu
On Mon, 22 Jul 2024 at 18:00, Ilias Apalodimas wrote: > > On Fri, 5 Jul 2024 at 22:51, Tom Rini wrote: > > > > On Thu, Jul 04, 2024 at 01:05:34PM +0530, Sughosh Ganu wrote: > > > > > Add a Kconfig symbol to enable getting updates on any memory map > > > changes that might be done by the LMB modul

Re: [PATCH] kontron-sl-mx6ul: switch to DM_SERIAL

2024-07-22 Thread Frieder Schrempf
On 20.07.24 5:54 PM, Anatolij Gustschin wrote: > Enable DM_SERIAL to avoid board removal warning. > > Signed-off-by: Anatolij Gustschin > Cc: Frieder Schrempf Reviewed-by: Frieder Schrempf > --- > configs/kontron-sl-mx6ul_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/co

Re: [RFC PATCH v2 38/48] lib: Kconfig: add a config symbol for getting lmb memory map updates

2024-07-22 Thread Ilias Apalodimas
On Fri, 5 Jul 2024 at 22:51, Tom Rini wrote: > > On Thu, Jul 04, 2024 at 01:05:34PM +0530, Sughosh Ganu wrote: > > > Add a Kconfig symbol to enable getting updates on any memory map > > changes that might be done by the LMB module. This notification > > mechanism can then be used to have a synchro

Re: [RFC PATCH v2 19/48] lmb: remove the lmb_init_and_reserve() function

2024-07-22 Thread Ilias Apalodimas
On Thu, 4 Jul 2024 at 10:37, Sughosh Ganu wrote: > > With the changes to make the LMB reservations persistent, the common > memory regions are being added during board init. Remove the > now superfluous lmb_init_and_reserve() function. > > Signed-off-by: Sughosh Ganu > --- > Changes since V1: > *

[PATCH v2] mtd: nand: raw: atmel: Use ONFI ECC params if available

2024-07-22 Thread Zixun LI
When ECC parameters are not specified in DT, first try ONFI ECC parameters before fallback to maximum strength. It's the Linux driver behavior since the driver rewriting in f88fc12. >From then 2 nand system refactors have been done in 6a1b66d6 and 53576c7b, chip->ecc_strength_ds and chip->ecc_ste

Re: [PATCH 3/3] usb: gadget: atmel: Add DM_USB_GADGET support

2024-07-22 Thread Marek Vasut
On 7/22/24 10:47 AM, Zixun LI wrote: Add driver model support by using the uclass UCLASS_USB_GADGET_GENERIC. Disable local usb_gadget_register_driver()/usb_gadget_unregister_driver() implementation which is implemented in udc-core.c when DM_USB_GADGET is enabled. Compared to Linux driver only s

Re: [PATCH 2/3] usb: gadget: atmel: Add attach/detach support

2024-07-22 Thread Marek Vasut
On 7/22/24 10:47 AM, Zixun LI wrote: Add controller attach/detach support by using usb_gadget_ops.pullup() method. Signed-off-by: Zixun LI --- drivers/usb/gadget/atmel_usba_udc.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/dr

  1   2   >