Re: [PATCH v2 1/2] virtio: New virtio_gpu driver

2024-07-19 Thread Jiaxun Yang
在2024年7月19日七月 下午11:05,Simon Glass写道: > Hi Jiaxun, > > On Wed, 17 Jul 2024 at 15:34, Jiaxun Yang wrote: >> >> >> >> 在2024年5月24日五月 下午9:02,Jiaxun Yang写道: >> > This driver is implemened based on latest VirtIO spec. >> > It follows operation prodcure as defined in the spec. >> > >> > It implemented

Re: [PATCH 01/14] rockchip: Move the default timer init to a common file

2024-07-19 Thread Dragan Simic
Hello Simon, On 2024-07-20 08:16, Simon Glass wrote: Rather than repeating the same code in two files (SPL and TPL), move it to a shared filed. Signed-off-by: Simon Glass Looking good to me. Thanks for the patch. Reviewed-by: Dragan Simic --- arch/arm/include/asm/arch-rockchip/timer.h

[PATCH 14/14] blk: Correct comment for blk_get_devnum_by_uclass_idname()

2024-07-19 Thread Simon Glass
Update the comment to match the function. Fix the indentation while we are here. Signed-off-by: Simon Glass --- include/blk.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/blk.h b/include/blk.h index 7c7cf7f2b10..1fc9a5b8471 100644 --- a/include/blk.h +++ b/inc

[PATCH 13/14] spl: Create a function to init spl_load_info

2024-07-19 Thread Simon Glass
Rather than having every caller set this up individually, create a common init function. This allows new fields to be added without the risk of them being left uninited. Signed-off-by: Simon Glass --- arch/arm/mach-imx/spl_imx_romapi.c | 14 ++--- arch/arm/mach-sunxi/spl_spi_sunxi.c | 3 +

[PATCH 12/14] spl: Use unified inline functions for spl_load_info

2024-07-19 Thread Simon Glass
Rather than declaring completely separate functions, put the code for each case into the same function. This makes it easier to read. Signed-off-by: Simon Glass --- include/spl.h | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/include/spl.h b/include/spl.

[PATCH 10/14] spl: mmc: Adjust args of spl_mmc_find_device()

2024-07-19 Thread Simon Glass
At present spl_mmc_load() is the only caller of this function, passing it a boot_device, an index into the available MMC devices. Pass the device number instead, since it is known by the caller and simplifies the code. Signed-off-by: Simon Glass --- common/spl/spl_mmc.c | 12 1 fil

[PATCH 09/14] spl: mmc: Handle error codes consistently

2024-07-19 Thread Simon Glass
Use 'ret' as the return code, since it may not be an error and this is the common name in U-Boot. Make sure to return the error code when given, rather than transforming it into -1 (-EPERM). Signed-off-by: Simon Glass --- common/spl/spl_mmc.c | 129 ++- 1

[PATCH 08/14] spl: mmc: Drop checks for CONFIG_SPL_LIBCOMMON_SUPPORT

2024-07-19 Thread Simon Glass
This check is not needed now, since printf() resolved to nothing if not available. Drop the #ifdefs Signed-off-by: Simon Glass --- common/spl/spl_mmc.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/common/spl/spl_mmc.c b/common/spl/spl_mmc.c index ccab

[PATCH 07/14] log: Avoid including function names by default

2024-07-19 Thread Simon Glass
Unless function names are requested, the logging system should not compile these into the code. Adjust the macros to handle this. Enable CONFIG_LOGF_FUNC logging for sandbox since the tests expect the function names to be included. Fix up the pinmux test which checks a logging statement. Signed-o

[PATCH 06/14] mmc: Use logging instead of pr_err()

2024-07-19 Thread Simon Glass
Use the log subsystem instead of dev, to avoid including function names in the code. The CONFIG_LOGF_FUNC option can be used to enable the function name. Signed-off-by: Simon Glass --- drivers/mmc/mmc.c | 49 --- 1 file changed, 25 insertions(+), 24

[PATCH 05/14] mmc: Use logging instead of printf()

2024-07-19 Thread Simon Glass
The code makes quite a few uses of __func__ which puts the function name into the resulting SPL image. Use the log subsystem instead, to reduce size. The CONFIG_LOGF_FUNC option can be used to enable the function name. Signed-off-by: Simon Glass --- drivers/mmc/sdhci.c | 46 +++

[PATCH 04/14] spl: Remove remaining #ifdef in spl_parse_image_header()

2024-07-19 Thread Simon Glass
Define spl_set_header_raw_uboot() always so we can drop the last #ifdef in this function. Signed-off-by: Simon Glass --- common/spl/spl.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/common/spl/spl.c b/common/spl/spl.c index 02567e766f1..745efdd9b28 100644

[PATCH 03/14] spl: Remove some #ifdefs in spl_parse_image_header()

2024-07-19 Thread Simon Glass
This function has a number of unnecessary #ifdefs so remove them. Signed-off-by: Simon Glass --- common/spl/spl.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/common/spl/spl.c b/common/spl/spl.c index 6f4a8bfb3f4..02567e766f1 100644 --- a/common/s

[PATCH 02/14] spl: Correct use of CMD_BOOTI and CMD_BOOTZ

2024-07-19 Thread Simon Glass
These should have a CONFIG_ prefix. Add it. Signed-off-by: Simon Glass Fixes: 7a0d88076b9 ("Add in the ability to load and boot an uncompr...") --- common/spl/spl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/spl/spl.c b/common/spl/spl.c index 7794ddccade..6f4

[PATCH 01/14] rockchip: Move the default timer init to a common file

2024-07-19 Thread Simon Glass
Rather than repeating the same code in two files (SPL and TPL), move it to a shared filed. Signed-off-by: Simon Glass --- arch/arm/include/asm/arch-rockchip/timer.h | 3 ++ arch/arm/mach-rockchip/Makefile| 4 +-- arch/arm/mach-rockchip/spl.c | 21 + arch/

[PATCH RFC] usb: gadget: atmel: Add DM_USB_GADGET support

2024-07-19 Thread Zixun Li
Add driver model support by using the uclass UCLASS_USB_GADGET_GENERIC. Disable local usb_gadget_register_driver()/usb_gadget_unregister_driver() implementation which is implemented in udc-core.c when DM_USB_GADGET is enabled. Compared to Linux driver sam9x60 and sama7g5 DT bindings are not inclu

Re: [PATCH 1/1] board: fix compatible property Milk-V Mars CM

2024-07-19 Thread E Shattow
On Fri, Jul 19, 2024 at 4:12 PM Heinrich Schuchardt wrote: > > For the Milk-V Mars CM (lite) we have only been copying sizeof(void *) > bytes to the compatible property instead of the whole string list. This const char array must be so that we may get an accurate data length with sizeof() but it

[PATCH v2] board: keymile: convert to CONFIG_DM_I2C

2024-07-19 Thread Anatolij Gustschin
The conversion to DM_I2C is mandatory, rework to remove use of legacy I2C API. Signed-off-by: Anatolij Gustschin Cc: Aleksandar Gerasimovski Cc: Holger Brunck Cc: Tomas Alvarez Vanoli --- Changes in v2: - convert pg_wcom_expu1_update_defconfig and pg_wcom_seli8_update_defconfig files - r

[PATCH 1/1] board: fix compatible property Milk-V Mars CM

2024-07-19 Thread Heinrich Schuchardt
For the Milk-V Mars CM (lite) we have only been copying sizeof(void *) bytes to the compatible property instead of the whole string list. Fixes: de3229599d4f ("board: add support for Milk-V Mars CM") Reported-by: E Shattow Signed-off-by: Heinrich Schuchardt --- board/starfive/visionfive2/spl.c

Re: [PATCH] sunxi: dts: arm/arm64: update devicetree files from Linux-v6.10

2024-07-19 Thread Andre Przywara
Hi Tom, Sorry for top posting, am on the road. First: The Allwinner drivers in U-Boot work with mainline kernel DTs for ages, so there are no code changes required. We manually sync the DTs from the kernel for years, but I always do one change: In kernel v5.13 the Allwinner IRQ controller (not t

[PATCH] board: beagle: convert to CONFIG_DM_I2C

2024-07-19 Thread Anatolij Gustschin
Rework to remove use of legacy I2C API. Signed-off-by: Anatolij Gustschin Cc: Tom Rini --- board/beagle/beagle/beagle.c | 41 +- configs/omap3_beagle_defconfig | 2 +- include/configs/omap3_beagle.h | 3 --- 3 files changed, 26 insertions(+), 20 deletions(-)

[PATCH 1/1] doc: define html_context in conf.py

2024-07-19 Thread Heinrich Schuchardt
The dictionary html_context is not passed into conf.py but must be created there. See https://dev.readthedocs.io/en/latest/design/theme-context.html#customizing-the-context Fixes: df86796028df ("doc: enable ReadTheDocs addon management") Signed-off-by: Heinrich Schuchardt --- doc/conf.py | 4 +++

[PATCH v2 4/4] udoo-neo: Convert to OF_UPSTREAM

2024-07-19 Thread Fabio Estevam
Instead of using the local imx6sx-udoo-neo devicetree copies from U-Boot, convert the imx6sx-udoo-neo boards to OF_UPSTREAM so that the upstream kernel devicetrees can be used instead. Tested on a imx6sx-udoo-neo-full board. Signed-off-by: Fabio Estevam --- Changes since v1: - Newly introdu

[PATCH v2 3/4] udoo-neo: Do not print devicetree model

2024-07-19 Thread Fabio Estevam
The udoo_neo_defconfig target supports several board variants. All of these variants use the imx6sx-udoo-neo-basic devicetree in U-Boot. Currently, the devicetree model as well as the board variant name are shown: ... Model: UDOO Neo Basic Board: UDOO Neo FULL ... Printing the devicetree

[PATCH v2 2/4] udoo_neo: Select LTO

2024-07-19 Thread Fabio Estevam
u-boot.img has grown in such a way that it overwrites the environment region. Select CONFIG_LTO to help reducing the U-Boot binary size and add a build-time size check to avoid U-Boot to overlap the environment region. Signed-off-by: Fabio Estevam --- Changes since v1: - Newly introduced. conf

[PATCH v2 1/4] udoo_neo: Convert to watchdog driver model

2024-07-19 Thread Fabio Estevam
Commit 68dcbdd594d4 ("ARM: imx: Add weak default reset_cpu()") caused the 'reset' command in U-Boot to not cause a board reset. Fix it by switching to the watchdog driver model via sysreset, which is the preferred method for implementing the watchdog reset. With the watchdog driver model in p

Re: [PATCH v6 06/24] soc: qcom: cmd-db: adjust probe for U-Boot

2024-07-19 Thread Caleb Connolly
On 19/07/2024 17:04, Simon Glass wrote: Hi Caleb, On Tue, 16 Jul 2024 at 08:16, Caleb Connolly wrote: On 16/07/2024 09:04, Simon Glass wrote: Hi Caleb, On Mon, 15 Jul 2024 at 22:42, Caleb Connolly wrote: On 15/07/2024 13:39, Simon Glass wrote: On Mon, 15 Jul 2024 at 11:08, Caleb

Re: [PATCH 01/20] arm: Remove pg_wcom boards

2024-07-19 Thread Anatolij Gustschin
Hi Simon, On Fri, 19 Jul 2024 10:50:16 +0200 Anatolij Gustschin ag...@denx.de wrote: > Hello Simon, > > On Thu, 18 Jul 2024 18:35:52 +0100 > Simon Glass s...@chromium.org wrote: > > > These board has not been converted to CONFIG_DM_I2C by the deadline: > > > >pg_wcom_expu1 > >pg_wcom_e

[PATCH] board: keymile: convert to CONFIG_DM_I2C

2024-07-19 Thread Anatolij Gustschin
The conversion to DM_I2C is mandatory, rework to remove use of legacy I2C API. Signed-off-by: Anatolij Gustschin Cc: Aleksandar Gerasimovski Cc: Holger Brunck Cc: Tomas Alvarez Vanoli --- board/keymile/Kconfig | 3 --- board/keymile/common/common.c |

Re: [PATCH] env: mmc: Fix env loading with CONFIG_SYS_MMC_ENV_PART

2024-07-19 Thread Tom Rini
On Fri, Jul 19, 2024 at 05:38:54PM +0200, Mattijs Korpershoek wrote: > When CONFIG_SYS_MMC_ENV_PART=2, the environment is loaded from > the USER partition (hwpart=0) instead of from the > BOOT1 partition (hwpart=2). > > IS_ENABLED() cannot be used for non-boolean KConfig options. > Its documentat

[PATCH] udoo_neo: Convert to watchdog driver model

2024-07-19 Thread Fabio Estevam
Commit 68dcbdd594d4 ("ARM: imx: Add weak default reset_cpu()") caused the 'reset' command in U-Boot to not cause a board reset. Fix it by switching to the watchdog driver model via sysreset, which is the preferred method for implementing the watchdog reset. Signed-off-by: Fabio Estevam ---

Re: Pull request efi-2024-10-rc1-3

2024-07-19 Thread Tom Rini
On Fri, Jul 19, 2024 at 04:26:43PM +0200, Heinrich Schuchardt wrote: > Dear Tom, > > The following changes since commit 45956736ac7c9c8b04522789c20fb45ff95a: > > Merge patch series "bootstd: Add Android support" (2024-07-18 > 17:03:47 -0600) > > are available in the Git repository at: >

Re: [PATCH] imx93-u-boot: Describe the CPU clocks in the devicetree

2024-07-19 Thread Fabio Estevam
Hi Sébastien, On Fri, Jul 19, 2024 at 12:47 PM Sébastien Szymanski wrote: > I did look at imx8mm.dtsi but the clock IMX8MM_CLK_ARM is not defined in > U-Boot and in Linux it's defined as: > > hws[IMX8MM_CLK_ARM] = imx_clk_hw_cpu("arm", "arm_a53_core", > hws[

Re: [PATCH] imx93-u-boot: Describe the CPU clocks in the devicetree

2024-07-19 Thread Sébastien Szymanski
On 7/19/24 16:13, Fabio Estevam wrote: Hi Sébastien, On Fri, Jul 19, 2024 at 11:00 AM Sébastien Szymanski wrote: +&A55_0 { + clocks = <&clk IMX93_CLK_ARM_PLL>; Why IMX93_CLK_ARM_PLL and not IMX93_CLK_A55_SEL ? IMX93_CLK_A55_SEL is a mux that can select between a55_alt versus arm_pll.

[PATCH] env: mmc: Fix env loading with CONFIG_SYS_MMC_ENV_PART

2024-07-19 Thread Mattijs Korpershoek
str = CONFIG_ENV_MMC_PARTITION; --- base-commit: 45956736ac7c9c8b04522789c20fb45ff95a change-id: 20240719-fix-mmc-env-boot1-a8d4b4512a29 Best regards, -- Mattijs Korpershoek

Re: [PATCH v4 08/29] hash: integrate hash on mbedtls

2024-07-19 Thread Tom Rini
On Fri, Jul 19, 2024 at 04:05:09PM +0100, Simon Glass wrote: > Hi Raymond, > > On Thu, 18 Jul 2024 at 17:46, Raymond Mao wrote: > > > > Hi Simon, > > > > On Fri, 5 Jul 2024 at 04:36, Simon Glass wrote: > >> > >> Hi, > >> > >> On Wed, Jul 3, 2024, 09:56 Ilias Apalodimas > >> wrote: > >> > > >>

Re: [PATCH] tools: Add script to update git subtree projects

2024-07-19 Thread Tom Rini
On Fri, Jul 19, 2024 at 07:12:43AM -0700, Raymond Mao wrote: > Recently we are introducing multiple git subtree projects and > it is the right time to have a universal script to update > various subtrees and replace the dts/update-dts-subtree.sh. > > update-subtree.sh is a wrapper of git subtree

Re: [PATCHv1 1/3] mp: imx9: add cpu command support

2024-07-19 Thread Simon Glass
Hi Zhiqiang, On Fri, 19 Jul 2024 at 12:28, Zhiqiang Hou wrote: > > From: Tao Yang > > Implement the cpu command to kick cpu core to run barematel or RTOS > applications. > > Signed-off-by: Tao Yang > Signed-off-by: Hou Zhiqiang > --- > arch/arm/mach-imx/imx9/Makefile | 4 +- > arch/arm/mach-

Re: [PATCH v2 1/2] virtio: New virtio_gpu driver

2024-07-19 Thread Simon Glass
Hi Jiaxun, On Wed, 17 Jul 2024 at 15:34, Jiaxun Yang wrote: > > > > 在2024年5月24日五月 下午9:02,Jiaxun Yang写道: > > This driver is implemened based on latest VirtIO spec. > > It follows operation prodcure as defined in the spec. > > > > It implemented multihead (mirroring) support as well. > > > > Signed

Re: [PATCH 02/13] doc: Move bootstd into its own directory

2024-07-19 Thread Simon Glass
Hi Tom, On Tue, 16 Jul 2024 at 17:18, Tom Rini wrote: > > On Tue, Jul 16, 2024 at 08:04:38AM +0100, Simon Glass wrote: > > Hi Heinrich, > > > > On Mon, 15 Jul 2024 at 22:58, Heinrich Schuchardt > > wrote: > > > > > > On 7/15/24 12:13, Simon Glass wrote: > > > > Before adding more files, move th

Re: [PATCH 06/18] tests/test_event_dump: Relax match rule for output

2024-07-19 Thread Simon Glass
Hi Jiaxun, On Wed, 17 Jul 2024 at 15:29, Jiaxun Yang wrote: > > event_dump.py relies on addr2line to obtain source location > information, however newer addr2line is unable to determine > line numbers for some functions. Is this a bug in the tool? > > With addr2line from binutils 2.34 we got: >

Re: [PATCH 03/18] doc/sphinx: Remove usage of six

2024-07-19 Thread Simon Glass
On Wed, 17 Jul 2024 at 15:29, Jiaxun Yang wrote: > > We don't support python2 any more so there is no point to > use six here. > > Signed-off-by: Jiaxun Yang > --- > doc/sphinx/kfigure.py | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > Reviewed-by: Simon Glass

Re: [PATCH 02/18] py: Replace distutils.core with setuptools

2024-07-19 Thread Simon Glass
On Wed, 17 Jul 2024 at 15:29, Jiaxun Yang wrote: > > distutils is deprecated long ago and being removed in python 3.12. > > Signed-off-by: Jiaxun Yang > --- > tools/binman/setup.py | 2 +- > tools/buildman/requirements.txt | 1 + > tools/dtoc/setup.py | 2 +- > 3 files chan

Re: [PATCH 01/18] binman: Replace pkg_resources with importlib.resources

2024-07-19 Thread Simon Glass
On Wed, 17 Jul 2024 at 15:29, Jiaxun Yang wrote: > > pkg_resources is deprecated long ago and being removed in python 3.12. > > Reimplement functions with importlib.resources. > > Link: https://docs.python.org/3/library/importlib.resources.html > Signed-off-by: Jiaxun Yang > --- > tools/binman/c

Re: [PATCH 05/18] binman: Workaround lz4 cli padding in test cases

2024-07-19 Thread Simon Glass
On Wed, 17 Jul 2024 at 15:29, Jiaxun Yang wrote: > > Newer lz4 util is not happy with any padding at end of file, > it would abort with error message like: > > Stream followed by undecodable data at position 43. > > Workaround by skipping testCompUtilPadding test case and manually > strip padding

Re: [PATCH v4 08/29] hash: integrate hash on mbedtls

2024-07-19 Thread Simon Glass
Hi Raymond, On Thu, 18 Jul 2024 at 17:46, Raymond Mao wrote: > > Hi Simon, > > On Fri, 5 Jul 2024 at 04:36, Simon Glass wrote: >> >> Hi, >> >> On Wed, Jul 3, 2024, 09:56 Ilias Apalodimas >> wrote: >> > >> > Hi Raymond >> > >> > On Tue, 2 Jul 2024 at 21:27, Raymond Mao wrote: >> > > >> > > Int

Re: [PATCH v6 06/24] soc: qcom: cmd-db: adjust probe for U-Boot

2024-07-19 Thread Simon Glass
Hi Caleb, On Tue, 16 Jul 2024 at 08:16, Caleb Connolly wrote: > > > > On 16/07/2024 09:04, Simon Glass wrote: > > Hi Caleb, > > > > On Mon, 15 Jul 2024 at 22:42, Caleb Connolly > > wrote: > >> > >> > >> > >> On 15/07/2024 13:39, Simon Glass wrote: > >>> On Mon, 15 Jul 2024 at 11:08, Caleb Conno

Pull request efi-2024-10-rc1-3

2024-07-19 Thread Heinrich Schuchardt
Dear Tom, The following changes since commit 45956736ac7c9c8b04522789c20fb45ff95a: Merge patch series "bootstd: Add Android support" (2024-07-18 17:03:47 -0600) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-efi.git tags/efi-2024-10-rc1-3 for y

Re: [PATCHv1 1/2] mp: imx8m: add cpu command support

2024-07-19 Thread Fabio Estevam
Hi Zhiqiang, On Fri, Jul 19, 2024 at 11:01 AM Z.Q. Hou wrote: > This patch is to add the needed functions to enable cmd/mp.c, which is well > known, so I don't think it's necessary to add an example to the commit log. I have never used cmd/mp.c. I see several other Layerscape boards use it. H

[PATCH] tools: Add script to update git subtree projects

2024-07-19 Thread Raymond Mao
Recently we are introducing multiple git subtree projects and it is the right time to have a universal script to update various subtrees and replace the dts/update-dts-subtree.sh. update-subtree.sh is a wrapper of git subtree commands. Usage: From U-Boot top directory, run $ ./tools/update-subtre

Re: [PATCH] imx93-u-boot: Describe the CPU clocks in the devicetree

2024-07-19 Thread Fabio Estevam
Hi Sébastien, On Fri, Jul 19, 2024 at 11:00 AM Sébastien Szymanski wrote: > > +&A55_0 { > > + clocks = <&clk IMX93_CLK_ARM_PLL>; > > Why IMX93_CLK_ARM_PLL and not IMX93_CLK_A55_SEL ? IMX93_CLK_A55_SEL is a mux that can select between a55_alt versus arm_pll. The real CPU clock is IMX93_CLK_

Re: [PATCH] imx93-u-boot: Describe the CPU clocks in the devicetree

2024-07-19 Thread Sébastien Szymanski
Hello Fabio, On 7/18/24 18:54, Fabio Estevam wrote: Currently, there is an error when the i.MX93 CPU frequency is read: Could not read CPU frequency: -2 CPU: NXP i.MX93(52) Rev1.1 A55 at 0 MHz Fix it by describing the A55 clock nodes in the devicetree, like done on other i.MX SoCs. With thi

[PATCH 3/3] usb: dwc3: invalidate dcache on buffer used in interrupt handling

2024-07-19 Thread Neil Armstrong
On Qualcomm systems, the setup buffer and even buffers are in a bad state at interrupt handling, so invalidate the dcache lines for the setup_buf and event buffer to make sure we read correct data written by the hardware. This fixes the following error: dwc3-generic-peripheral usb@a60: UNKNOWN

[PATCH 2/3] usb: dwc3: fix dcache flush range calculation

2024-07-19 Thread Neil Armstrong
The current flush operation will omit doing a flush/invalidate on the first and last bytes if the base address and size are not aligned with DMA_MINALIGN. This causes operation failures Qualcomm platforms. Take in account the alignment and size of the buffer and also flush the previous and last c

[PATCH 1/3] usb: dwc3: allocate setup_buf with dma_alloc_coherent()

2024-07-19 Thread Neil Armstrong
Also allocate the setup_buf with dma_alloc_coherent() since it's also consumed by the hardware DMA. Signed-off-by: Neil Armstrong --- drivers/usb/dwc3/core.h | 2 ++ drivers/usb/dwc3/ep0.c| 4 ++-- drivers/usb/dwc3/gadget.c | 8 3 files changed, 8 insertions(+), 6 deletions(-) di

[PATCH 0/3] dwc3: gadget: properly fix cache operations

2024-07-19 Thread Neil Armstrong
/ep0.c| 6 -- drivers/usb/dwc3/gadget.c | 10 ++ drivers/usb/dwc3/io.h | 13 - 4 files changed, 24 insertions(+), 7 deletions(-) --- base-commit: 3f772959501c99fbe5aa0b22a36efe3478d1ae1c change-id: 20240719-u-boot-dwc3-gadget-dcache-fixup-ea1e92758663 Best regards

RE: [PATCHv1 1/2] mp: imx8m: add cpu command support

2024-07-19 Thread Z.Q. Hou
Hi Fabio, Thanks a lot for your comments! > -Original Message- > From: Fabio Estevam > Sent: Friday, July 19, 2024 7:33 PM > To: Z.Q. Hou > Cc: u-boot@lists.denx.de; sba...@denx.de; dl-uboot-imx > ; tr...@konsulko.com; Peng Fan ; > Yi Zhao ; Jiafei Pan > Subject: Re: [PATCHv1 1/2] mp:

[PATCH v5 09/11] tools: mkeficapsule: support generating dynamic GUIDs

2024-07-19 Thread Caleb Connolly
Add support for generating GUIDs that match those generated internally by U-Boot for capsule update fw_images when using dynamic UUIDs. Dynamic UUIDs in U-Boot work by taking a namespace UUID and hashing it with the board compatible and fw_image name. This feature just provides a way to determine

[PATCH v5 08/11] tools: mkeficapsule: use u-boot UUID library

2024-07-19 Thread Caleb Connolly
Replace the use of libuuid with U-Boot's own UUID library. This prepares us to add support for generating v5 GUIDs. Signed-off-by: Caleb Connolly --- tools/Makefile | 8 tools/mkeficapsule.c | 53 ++-- 2 files changed, 10 insertions

[PATCH v5 11/11] test: lib/uuid: add tests for UUID version/variant bits

2024-07-19 Thread Caleb Connolly
Add a test to check the version/variant bits of v4 and v5 UUIDs. Signed-off-by: Caleb Connolly --- test/lib/uuid.c | 36 1 file changed, 36 insertions(+) diff --git a/test/lib/uuid.c b/test/lib/uuid.c index 2c6cfd42ddc3..63d36e120623 100644 --- a/test/lib/uu

[PATCH v5 10/11] test: lib/uuid: add unit tests for dynamic UUIDs

2024-07-19 Thread Caleb Connolly
Add some basic unit tests to validate that the UUID generation behaves as expected. This matches the implementation in efi_loader for sandbox and a Qualcomm board and should catch any regressions. Signed-off-by: Caleb Connolly --- test/lib/uuid.c | 82

[PATCH v5 07/11] include: export uuid.h

2024-07-19 Thread Caleb Connolly
Move this header to include/u-boot/ so that it can be used by external tools. Signed-off-by: Caleb Connolly --- arch/arm/mach-rockchip/board.c | 2 +- board/cobra5272/flash.c| 2 +- board/gardena/smart-gateway-mt7688/board.c | 2 +- board/socrates/socrates.c

[PATCH v5 06/11] lib: uuid: supporting building as part of host tools

2024-07-19 Thread Caleb Connolly
Adjust the UUID library code so that it can be compiled as part of a host tool. This removes the one redundant log_debug() call, as well as the incorrectly defined LOG_CATEGORY. In general this is a fairly trivial change, just adjusting includes and disabling list_guid. This will be used by a ne

[PATCH v5 05/11] sandbox: switch to dynamic UUIDs

2024-07-19 Thread Caleb Connolly
Migrate sandbox over to generating it's capsule update image GUIDs dynamically from the namespace and board/image info. Update the reference and tests to use the new GUIDs. Signed-off-by: Caleb Connolly --- board/sandbox/sandbox.c | 16 include/s

[PATCH v5 04/11] doc: uefi: document dynamic UUID generation

2024-07-19 Thread Caleb Connolly
Document how platforms can generate GUIDs at runtime rather than maintaining a list of UUIDs per-board. Reviewed-by: Ilias Apalodimas Signed-off-by: Caleb Connolly --- doc/develop/uefi/uefi.rst | 27 +++ 1 file changed, 27 insertions(+) diff --git a/doc/develop/uefi/uef

[PATCH v5 03/11] efi: add a helper to generate dynamic UUIDs

2024-07-19 Thread Caleb Connolly
Introduce a new helper efi_capsule_update_info_gen_ids() which populates the capsule update fw images image_type_id field. This allows for determinstic UUIDs to be used that can scale to a large number of different boards and board variants without the need to maintain a big list. We call this fro

[PATCH v5 02/11] lib: uuid: add UUID v5 support

2024-07-19 Thread Caleb Connolly
Add support for generating version 5 UUIDs, these are determistic and work by hashing a "namespace" UUID together with some unique data. One intended usecase is to allow for dynamically generate payload UUIDs for UEFI capsule updates, so that supported boards can have their own UUIDs without needin

[PATCH v5 01/11] efi: define struct efi_guid

2024-07-19 Thread Caleb Connolly
This let's us forward declare efi_guid_t in the UUID code without pulling in efi.h Signed-off-by: Caleb Connolly --- include/efi.h | 2 +- tools/eficapsule.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/efi.h b/include/efi.h index c3c4b93f860a..b92c961a2afd

[PATCH v5 00/11] efi: CapsuleUpdate: support for dynamic UUIDs

2024-07-19 Thread Caleb Connolly
As more boards adopt support for the EFI CapsuleUpdate mechanism, there is a growing issue of being able to target updates to them properly. The current mechanism of hardcoding UUIDs for each board at compile time is unsustainable, and maintaining lists of GUIDs is similarly cumbersome. In this se

RE: [PATCH] imx93-u-boot: Describe the CPU clocks in the devicetree

2024-07-19 Thread Peng Fan
> Subject: [PATCH] imx93-u-boot: Describe the CPU clocks in the > devicetree > > Currently, there is an error when the i.MX93 CPU frequency is > read: > > Could not read CPU frequency: -2 > CPU: NXP i.MX93(52) Rev1.1 A55 at 0 MHz > > Fix it by describing the A55 clock nodes in the devicetree,

Re: [PATCHv1 1/2] mp: imx8m: add cpu command support

2024-07-19 Thread Fabio Estevam
On Fri, Jul 19, 2024 at 6:47 AM Zhiqiang Hou wrote: > > From: Hou Zhiqiang > > Implement the cpu command to kick cpu core to run barematel or RTOS > applications. s/barematel/baremetal Please add documentation explaining how to run this command, how it was tested, etc. > --- /dev/null > +++ b/

[PATCHv1 3/3] configs: imx93-11x11-evk: enable CONFIG_MP to support cpu command

2024-07-19 Thread Zhiqiang Hou
From: Tao Yang Enable the cpu command support for the default config. Signed-off-by: Tao Yang Signed-off-by: Hou Zhiqiang --- configs/imx93_11x11_evk_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/imx93_11x11_evk_defconfig b/configs/imx93_11x11_evk_defconfig index 2246

[PATCHv1 2/3] imx93_evk: add definition MAX_CPUS

2024-07-19 Thread Zhiqiang Hou
From: Tao Yang Add definition for determining the implemented CPU numbers. Signed-off-by: Tao Yang Signed-off-by: Hou Zhiqiang --- include/configs/imx93_evk.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/configs/imx93_evk.h b/include/configs/imx93_evk.h index

[PATCHv1 1/3] mp: imx9: add cpu command support

2024-07-19 Thread Zhiqiang Hou
From: Tao Yang Implement the cpu command to kick cpu core to run barematel or RTOS applications. Signed-off-by: Tao Yang Signed-off-by: Hou Zhiqiang --- arch/arm/mach-imx/imx9/Makefile | 4 +- arch/arm/mach-imx/imx9/mp.c | 81 + 2 files changed, 84 inserti

[PATCHv1 0/3] Enable the 'cpu' command for i.MX93 EVK board

2024-07-19 Thread Zhiqiang Hou
From: Hou Zhiqiang This patch set is to enable the 'cpu' command for i.MX93 EVK, so that it can kick one CPU core to run the barematel or RTOS applicatons under U-Boot. Tao Yang (3): mp: imx9: add cpu command support imx93_evk: add definition CONFIG_MAX_CPUS configs: imx93-11x11-evk: enabl

[PATCH 3/4] ufs: split flush and invalidate to only invalidate when required

2024-07-19 Thread Neil Armstrong
There is no need to flush and invalidate all data updated by the driver, mainly because on ARM platforms flush also invalidates the cachelines. Split the function in two and add the appropriate cacheline invalidates after the UFS DMA operation finishes to make sure we read from memory. Flushing t

[PATCH 4/4] ufs: use dcache helpers for scsi_cmd data and only invalidate if necessary

2024-07-19 Thread Neil Armstrong
Now we have proper flush and invalidate helpers, we can use them directly to operate on the scsi_cmd data. Likewise, we do not need to flush then invalidate, just flush _or_ invalidate depending on the data direction. Signed-off-by: Neil Armstrong --- drivers/ufs/ufs.c | 13 - 1 fil

[PATCH 2/4] ufs: fix dcache flush and invalidate range calculation

2024-07-19 Thread Neil Armstrong
The current calculation will omit doing a flush/invalidate on the last cacheline if the base address is not aligned with DMA_MINALIGN. This causes commands failures and write corruptions on Qualcomm platforms. Signed-off-by: Neil Armstrong --- drivers/ufs/ufs.c | 16 1 file cha

[PATCH 1/4] ufs: allocate descriptors with size aligned with DMA_MINALIGN

2024-07-19 Thread Neil Armstrong
Align the allocation size with DMA_MINALIGN to make sure we do not flush/invalidate data from following allocations. Signed-off-by: Neil Armstrong --- drivers/ufs/ufs.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/ufs/ufs.c b/drivers/ufs/ufs.c index e4400f3

[PATCH 0/4] ufs: properly fix cache operations

2024-07-19 Thread Neil Armstrong
only invalidate if necessary drivers/ufs/ufs.c | 74 +-- 1 file changed, 44 insertions(+), 30 deletions(-) --- base-commit: 3f772959501c99fbe5aa0b22a36efe3478d1ae1c change-id: 20240719-u-boot-ufs-dcache-fixup-d9a980a97835 Best regards, -- Neil

Re: [PATCH] riscv: dts: jh7110: Enable PLL node in SPL

2024-07-19 Thread E Shattow
On Tue, Jul 16, 2024 at 3:59 AM Leo Liang wrote: > > On Thu, Jul 11, 2024 at 12:55:05PM -0700, E Shattow wrote: > > [EXTERNAL MAIL] > > > > Ping. This regression still exists and is now in stable release. > > Should we revert this change or how must it be fixed? > > > > -E > > > > Hi all, > > I t

[PATCH 37/37] board: xilinx: Remove duplicate newlines

2024-07-19 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- board/xilinx/zynq/zynq-microzed/ps7_init_gpl.c | 2 -- board/xilinx/zynq/zynq-zc702/ps7_init_gpl.c| 2 -- board/xilinx/zynq/zynq-zc706/ps7_init_gpl.c| 2 -- board/xilinx/zynq/zynq-zed/ps7_init_gpl.c |

[PATCH 36/37] board: vscom: Remove duplicate newlines

2024-07-19 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- board/vscom/baltos/board.c | 1 - 1 file changed, 1 deletion(-) diff --git a/board/vscom/baltos/board.c b/board/vscom/baltos/board.c index 2c91e9fac43..cea25f8c900 100644 --- a/board/vscom/baltos/board.c +++ b/boa

[PATCH 35/37] board: toradex: Remove duplicate newlines

2024-07-19 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- board/toradex/apalis_imx6/apalis_imx6.c | 2 -- board/toradex/colibri_imx6/colibri_imx6.c | 2 -- board/toradex/colibri_imx7/colibri_imx7.c | 1 - 3 files changed, 5 deletions(-) diff --git a/board/toradex/apali

[PATCH 34/37] board: ti: Remove duplicate newlines

2024-07-19 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- board/ti/am335x/board.c | 1 - board/ti/am43xx/board.c | 1 - board/ti/am57xx/board.c | 1 - board/ti/ks2_evm/ddr3_cfg.c | 1 - board/ti/panda/panda_mux_data.h | 1 - 5 files changed, 5

[PATCH 33/37] board: theadorable: Remove duplicate newlines

2024-07-19 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- board/theadorable/theadorable.c | 1 - 1 file changed, 1 deletion(-) diff --git a/board/theadorable/theadorable.c b/board/theadorable/theadorable.c index cca5c3d33b5..d7234532fe6 100644 --- a/board/theadorable/the

[PATCH 32/37] board: terasic: Remove duplicate newlines

2024-07-19 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- board/terasic/de1-soc/qts/iocsr_config.h | 1 - board/terasic/de1-soc/qts/pll_config.h | 1 - board/terasic/de10-nano/qts/iocsr_config.h | 1 - board/terasic/de10-nano/qts/pll_config.h | 1 -

[PATCH 31/37] board: tcl: Remove duplicate newlines

2024-07-19 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- board/tcl/sl50/board.c | 1 - board/tcl/sl50/mux.c | 1 - 2 files changed, 2 deletions(-) diff --git a/board/tcl/sl50/board.c b/board/tcl/sl50/board.c index 2e54ede62d6..484b4e24428 100644 --- a/board/tcl/sl50/b

[PATCH 30/37] board: synopsys: Remove duplicate newlines

2024-07-19 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- board/synopsys/emsdp/emsdp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/board/synopsys/emsdp/emsdp.c b/board/synopsys/emsdp/emsdp.c index adec7d32199..ffa544fa963 100644 --- a/board/synopsys/emsdp/emsdp.c +

[PATCH 29/37] board: sr1500: Remove duplicate newlines

2024-07-19 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- board/sr1500/qts/iocsr_config.h | 1 - board/sr1500/qts/pll_config.h | 1 - 2 files changed, 2 deletions(-) diff --git a/board/sr1500/qts/iocsr_config.h b/board/sr1500/qts/iocsr_config.h index 2622b960314..f9476

[PATCH 28/37] board: softing: Remove duplicate newlines

2024-07-19 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- board/softing/vining_fpga/qts/iocsr_config.h | 1 - board/softing/vining_fpga/qts/pll_config.h | 1 - 2 files changed, 2 deletions(-) diff --git a/board/softing/vining_fpga/qts/iocsr_config.h b/board/softing/vi

[PATCH 27/37] board: socrates: Remove duplicate newlines

2024-07-19 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- board/socrates/ddr.c | 1 - board/socrates/nand.c | 1 - board/socrates/sdram.c | 1 - board/socrates/tlb.c | 1 - 4 files changed, 4 deletions(-) diff --git a/board/socrates/ddr.c b/board/socrates/ddr.c inde

[PATCH 26/37] board: siemens: Remove duplicate newlines

2024-07-19 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- board/siemens/common/board_am335x.c | 1 - board/siemens/pxm2/pmic.h | 1 - 2 files changed, 2 deletions(-) diff --git a/board/siemens/common/board_am335x.c b/board/siemens/common/board_am335x.c index 4

[PATCH 25/37] board: qualcomm: Remove duplicate newlines

2024-07-19 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- board/qualcomm/dragonboard410c/dragonboard410c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/board/qualcomm/dragonboard410c/dragonboard410c.c b/board/qualcomm/dragonboard410c/dragonboard410c.c index bd2e213

[PATCH 24/37] board: opalkelly: Remove duplicate newlines

2024-07-19 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- board/opalkelly/zynq/zynq-syzygy-hub/ps7_init_gpl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/board/opalkelly/zynq/zynq-syzygy-hub/ps7_init_gpl.c b/board/opalkelly/zynq/zynq-syzygy-hub/ps7_init_gpl.c inde

[PATCH 23/37] board: mntre: Remove duplicate newlines

2024-07-19 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- board/mntre/imx8mq_reform2/imx8mq_reform2.c | 2 -- board/mntre/imx8mq_reform2/lpddr4_timing.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/board/mntre/imx8mq_reform2/imx8mq_reform2.c b/board/mntre/imx8m

[PATCH 22/37] board: logicpd: Remove duplicate newlines

2024-07-19 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- board/logicpd/omap3som/omap3logic.h | 1 - 1 file changed, 1 deletion(-) diff --git a/board/logicpd/omap3som/omap3logic.h b/board/logicpd/omap3som/omap3logic.h index ba63aa04c34..55d8f429513 100644 --- a/board/lo

[PATCH 21/37] board: l+g: Remove duplicate newlines

2024-07-19 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- board/l+g/vinco/vinco.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/board/l+g/vinco/vinco.c b/board/l+g/vinco/vinco.c index 066d315baa2..39e7ff633b3 100644 --- a/board/l+g/vinco/vinco.c +++ b/board/l+g/vin

[PATCH 20/37] board: kontron: Remove duplicate newlines

2024-07-19 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- board/kontron/pitx_imx8m/pitx_imx8m.c | 1 - board/kontron/pitx_imx8m/spl.c| 2 -- 2 files changed, 3 deletions(-) diff --git a/board/kontron/pitx_imx8m/pitx_imx8m.c b/board/kontron/pitx_imx8m/pitx_imx8m.

[PATCH 19/37] board: is1: Remove duplicate newlines

2024-07-19 Thread Marek Vasut
Drop all duplicate newlines. No functional change. Signed-off-by: Marek Vasut --- board/is1/qts/iocsr_config.h | 1 - board/is1/qts/pll_config.h | 1 - 2 files changed, 2 deletions(-) diff --git a/board/is1/qts/iocsr_config.h b/board/is1/qts/iocsr_config.h index e54af2caed4..619b8a6706e 10064

  1   2   >