>
> Hi,
>
> On Sun, Jun 23, 2024 at 6:28 PM Minda Chen
> wrote:
> >
> >
> >
> > >
> > > Minda, can you test USB Host function on VisionFive2? I guess that
> > > it is connected to the USB-C port. For the boards with JH7110 and
> > > not any
> > > VL805 USB controller this Cadence USB is the on
Hi,
On Sun, Jun 23, 2024 at 6:28 PM Minda Chen wrote:
>
>
>
> >
> > Minda, can you test USB Host function on VisionFive2? I guess that it is
> > connected to the USB-C port. For the boards with JH7110 and not any
> > VL805 USB controller this Cadence USB is the only way to have host USB. It
> >
Hi, sorry, pls ping :)
Thanks
On 02.06.2024 23:08, Arseniy Krasnov wrote:
> Based on Linux kernel:
> commit f922bd798bb9 ("mtd: rawnand: add an option to specify NAND chip as a
> boot device")
>
> Allow to define a NAND chip as a boot device. This can be helpful
> for the selection of the ECC a
+Cc: he...@sntech.de
+Cc: k...@kernel.org
Hello Peter and Fukaumi,
On 2024-06-23 15:08, Peter Robinson wrote:
On Sun, 23 Jun 2024 at 13:21, Dragan Simic wrote:
On 2024-06-23 06:15, FUKAUMI Naoki wrote:
> rk3328-rock-pi-e-v3.dts is identical to rk3328-rock-pi-e.dts in
> upstream. only differen
On Mon, 24 Jun 2024 at 00:52, Simon Glass wrote:
>
> Hi Ilias,
>
> On Sun, 23 Jun 2024 at 05:49, Ilias Apalodimas
> wrote:
> >
> > Simon reports that after enabling all algorithms on the TPM some boards
> > fail since they don't have enough storage to accommodate the ~5KB growth.
> >
> > The choi
Am 23. Juni 2024 22:30:33 MESZ schrieb Simon Glass :
>Since write_smbios_table() returns an address, we cannot use it to
>return and error number. Also, failing on sysinfo_detect() breaks
IS_ERR_VALUE() could serve as template for conveying errors in addresses.
>existing boards, e.g. chromeb
Hi Simon,
On Mon, 24 Jun 2024 at 00:52, Simon Glass wrote:
>
> Hi Ilias,
>
> On Sun, 23 Jun 2024 at 05:48, Ilias Apalodimas
> wrote:
> >
> > We currently return 'No space left on device' if the eventlong buffer
> > we allocated is not enough. On a similar check later on that function
> > during
Commit ee1d8aa5ecf7 ("spmi: msm: support controller version 7") broke
support for channels > 128 on v5 controllers, resulting in some
peripherals (like the power button / pon) working but others (like
gpios) reading bogus data.
Correct max_channels for v5 controllers.
Fixes: ee1d8aa5ecf7 ("spmi:
>
> Minda, can you test USB Host function on VisionFive2? I guess that it is
> connected to the USB-C port. For the boards with JH7110 and not any
> VL805 USB controller this Cadence USB is the only way to have host USB. It is
> very much wanted to have host USB. Thanks! -E
>
In VF2, PCIe0 con
On 6/21/24 4:11 AM, Caleb Connolly wrote:
* Factor out the common pattern of checking the dr_mode property on
the usb node and it's parent
* Respect the usb-role-switch property, rather than requiring dr_mode be
set
* Override OTG mode with the value in role-switch-default-mode
The devicet
Hi,
thank you for your comment!
On 6/24/24 05:22, Dragan Simic wrote:
+Cc: he...@sntech.de
+Cc: k...@kernel.org
Hello Peter and Fukaumi,
On 2024-06-23 15:08, Peter Robinson wrote:
On Sun, 23 Jun 2024 at 13:21, Dragan Simic wrote:
On 2024-06-23 06:15, FUKAUMI Naoki wrote:
> rk3328-rock-pi-e
Hi Ilias,
On Sun, 23 Jun 2024 at 05:49, Ilias Apalodimas
wrote:
>
> Simon reports that after enabling all algorithms on the TPM some boards
> fail since they don't have enough storage to accommodate the ~5KB growth.
>
> The choice of hash algorithms is determined by the platform and the TPM
> con
Hi Ilias,
On Sun, 23 Jun 2024 at 05:48, Ilias Apalodimas
wrote:
>
> We currently return 'No space left on device' if the eventlong buffer
> we allocated is not enough. On a similar check later on that function
> during the call to tcg2_log_init() we return 'No buffer space
> available'. So switch
Hi Tom,
On Fri, 21 Jun 2024 at 16:12, Tom Rini wrote:
>
> On Fri, Jun 21, 2024 at 01:38:07PM -0600, Simon Glass wrote:
> > Hi Tom,
> >
> > On Fri, 21 Jun 2024 at 13:19, Tom Rini wrote:
> > >
> > > On Fri, Jun 21, 2024 at 11:55:42AM -0600, Simon Glass wrote:
> > > > Hi Tom,
> > > >
> > > > On Fri
Add a way to run tests on a real hardware lab. This is in the very early
experimental stages. There are only 23 boards and 3 of those are broken!
(bob, ff3399, samus). A fourth fails due to problems with the TPM tests.
To try this, assuming you have gitlab access, set SJG_LAB=1, e.g.:
git push
This can take a while and involve multiple steps (e.g. turning the board
back off). Add a section for it and show the output.
Signed-off-by: Simon Glass
---
(no changes since v1)
test/py/u_boot_console_base.py | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/test/py/u_bo
Send the Labgrid quit characters to ask it to exit gracefully. This
typically allows it to power off the board being used.
If that doesn't work, try the less graceful approach.
Signed-off-by: Simon Glass
---
(no changes since v1)
test/py/u_boot_spawn.py | 17 +++--
1 file changed,
There is a very annoying bug at present where the terminal echos part
of the first command sent to the board. This happens because the
terminal is still set to echo for a period until Labgrid starts up and
can change this.
Fix this by disabling echo (and other terminal features) as soon as the
spa
Fix a typo in a comment.
Signed-off-by: Simon Glass
---
(no changes since v1)
test/py/u_boot_console_base.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/py/u_boot_console_base.py b/test/py/u_boot_console_base.py
index e2e78179555..f610fa9a6f8 100644
--- a/test/py/u
We expect commands to be echoed and this should happen quite quickly,
since U-Boot is sitting at the prompt waiting for a command.
Reduce the timeout for this situation. Try to produce a more useful
error message when something goes wrong. Also handle the case where the
connection has gone away si
There is quite a bit of code in pytest to try to start up U-Boot on a
board, with timeouts, expects, etc.
This is tedious to maintain and is peripheral to the test system's
purpose. It seems better to put this logic in the lab itself, where is
can provide such support.
With Labgrid we can use the
Use the new handle_exception() function from ConsoleBase also.
Signed-off-by: Simon Glass
---
(no changes since v1)
test/py/u_boot_console_base.py | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/test/py/u_boot_console_base.py b/test/py/u_boot_console_base.py
in
When the connection to a board dies, assume it is dead forever until
some user action is taken. Skip all remaining tests. This avoids CI
runs taking an hour, with hundreds of 30-second timeouts all to no
avail.
Signed-off-by: Simon Glass
---
(no changes since v1)
test/py/conftest.py | 19 +
The tests currently catch a very board Exception in each case. This is
thrown even in the event of a coding error.
We want to handle exceptions differently depending on their severity,
so that we can avoid hour-long delays waiting for a board that is
clearly broken.
As a first step, create some n
There is quite a bit of code to deal with receiving data from the target
so move it into its own receive() function.
Signed-off-by: Simon Glass
---
(no changes since v1)
test/py/u_boot_spawn.py | 39 +++
1 file changed, 27 insertions(+), 12 deletions(-)
dif
In Labgrid there is the concept of a 'role', which is similar to the
U-Boot board ID in U-Boot's pytest subsystem.
The role indicates both the target and information about the U-Boot
build to use. It can also provide any amount of other configuration.
The information is obtained using the 'labgrid
The settings are decoded in two places. Combine them into a new
function, before (in a future patch) expanding the number of items.
Signed-off-by: Simon Glass
---
(no changes since v1)
test/py/conftest.py | 41 -
1 file changed, 28 insertions(+), 13 dele
When a test returns -EAGAIN this should not be considered a failure.
Fix what seems to be a problem case, where the pytests see a failure
when a test has merely been skipped.
Signed-off-by: Simon Glass
---
(no changes since v1)
test/test-main.c | 16 +++-
1 file changed, 11 inserti
Sometimes we know that the board is already running the right software,
so provide an option to allow running of tests directly, without first
resetting the board.
This saves time when re-running a test where only the Python code is
changing.
Signed-off-by: Simon Glass
---
(no changes since v1)
When a board is finished with, the lab may want to power it off, or
perform some other function. Add a new script which is called when tests
are complete.
Signed-off-by: Simon Glass
---
(no changes since v1)
test/py/u_boot_console_exec_attach.py | 10 ++
1 file changed, 10 insertions(+
Some tests may output things to stderr. Ensure that this output is not
dropped, by redirecting it to stdout
Signed-off-by: Simon Glass
---
(no changes since v1)
test/py/u_boot_spawn.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/test/py/u_boot_spawn.py b/test/py/u_boot_spawn.py
index
Declare a constant rather than open-coding the same value twice.
Signed-off-by: Simon Glass
---
(no changes since v1)
test/py/u_boot_console_base.py | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/test/py/u_boot_console_base.py b/test/py/u_boot_console_base.py
index
When Labgrid is used, it can get U-Boot ready for running tests. It
prints a message when it has done so.
Add logic to detect this message and accept it.
Signed-off-by: Simon Glass
---
(no changes since v1)
test/py/u_boot_console_base.py | 9 +
1 file changed, 5 insertions(+), 4 delet
Labgrid provides access to a hardware lab in an automated way. It is
possible to boot U-Boot on boards in the lab without physically touching
them. It relies on relays, USB UARTs and SD muxes, among other things.
By way of background, about 4 years ago I wrong a thing called Labman[1]
which allowe
Since write_smbios_table() returns an address, we cannot use it to
return and error number. Also, failing on sysinfo_detect() breaks
existing boards, e.g. chromebook_link
Correct this by logging and swallowing the error.
Signed-off-by: Simon Glass
Fixes: a5a57562856 ("lib: smbios: Detect system
Some configuration is now in variables with a CFG_ prefix. Add these to
the .cfg file so that we can see everything in one place. Sort the
options so they are easier to find and compare.
Signed-off-by: Simon Glass
---
Changes in v2:
- Add new patch to update u-boot.cfg with CFG_... options
scr
The current test doesn't check anything about the output. If a bug
results in junk before the output, this is not currently detected.
Add a check for the first line being the one expected.
Signed-off-by: Simon Glass
---
(no changes since v1)
test/py/tests/test_help.py | 6 +-
1 file chang
When a real board fails we don't want to decode the exception. Reserve
that behaviour for sandbox. Also avoid raising a new exception on
failure - just re-raise the existing one.
Signed-off-by: Simon Glass
---
(no changes since v1)
test/py/u_boot_console_sandbox.py | 2 +-
test/py/u_boot_spaw
When a driver is not registered properly it is not clear which one it
is. Adjust test_dm_compat() to show this.
Signed-off-by: Simon Glass
---
(no changes since v1)
test/py/tests/test_dm.py | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/test/py/tests/test_dm.py b/test/
This setting pads out the function names. Adjust the test to handle
this, since some boards use it.
Signed-off-by: Simon Glass
---
(no changes since v1)
test/py/tests/test_log.py | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/test/py/tests/test_log.py b/test/py
Tests for standard boot need disks to be set up, which can only be done
on sandbox, since adjusting disks on real hardware is not currently
supported. Mark the init function as sandbox-only.
Signed-off-by: Simon Glass
---
(no changes since v1)
test/py/tests/test_ut.py | 1 +
1 file changed, 1
This should use the driver macros so that the driver appears in the
linker list. Fix this.
Fixes: 8587839f19d ("pinctrl: meson: add axg support")
Reviewed-by: Neil Armstrong
Signed-off-by: Simon Glass
---
(no changes since v1)
drivers/pinctrl/meson/pinctrl-meson-axg-pmx.c | 2 +-
drivers/pin
This feature is not present on older Chromebooks, so disable the
setting.
Signed-off-by: Simon Glass
Reviewed-by: Ilias Apalodimas
---
(no changes since v1)
configs/chromebook_link64_defconfig| 1 +
configs/chromebook_link_defconfig | 1 +
configs/chromebook_samus_defconfig | 1 +
This binary does not prevent the system from booting. Mark it optional
so that U-Boot can be built without it.
Signed-off-by: Simon Glass
---
(no changes since v1)
arch/arm/dts/sunxi-u-boot.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/dts/sunxi-u-boot.dtsi b/arch/arm/dts/s
Since commit 0dba45864b2a ("arm: Init the debug UART") the debug UART is
set up in _main() before early_system_init() is called.
Add a suitable board_debug_uart_init() function to set up the UART in
SPL.
Signed-off-by: Simon Glass
---
(no changes since v1)
arch/arm/mach-omap2/am33xx/board.c |
The relocation offset can change in some initcall sequences. Handle
this and make sure it is used for all debugging statements in
init_run_list()
Update the trace test to match.
Signed-off-by: Simon Glass
Reviewed-by: Caleb Connolly
---
(no changes since v1)
lib/initcall.c | 6 +
This part of driver model is a little subtle, so add some more comments
to promote better understanding.
Signed-off-by: Simon Glass
---
(no changes since v1)
drivers/core/lists.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/core/lists.c b/drivers/core/lists.c
i
Some versions of trace-cmd (or some machines?) show one less dot in the
CPU list.
Signed-off-by: Simon Glass
---
(no changes since v1)
test/py/tests/test_trace.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/py/tests/test_trace.py b/test/py/tests/test_trace.py
index
This series includes a number of mostly unrelated changes which are in
service of running U-Boot on a lab using Labgrid.
Changes in v2:
- Add new patch to update u-boot.cfg with CFG_... options
Simon Glass (14):
trace: Update test to tolerate different trace-cmd version
dm: core: Enhance comm
+Cc: he...@sntech.de
+Cc: k...@kernel.org
Hello Peter and Fukaumi,
On 2024-06-23 15:08, Peter Robinson wrote:
On Sun, 23 Jun 2024 at 13:21, Dragan Simic wrote:
On 2024-06-23 06:15, FUKAUMI Naoki wrote:
> rk3328-rock-pi-e-v3.dts is identical to rk3328-rock-pi-e.dts in
> upstream. only differen
Enable SPL DTO support to apply matching SoM specific DTOs to cater
for the SoM differences in DH i.MX8MP DHCOM PDK2 configuration. This
is already enabled in DH i.MX8MP DHCOM PDK3 configuration so align
the two configurations.
Fixes: ad1158c50e0e ("arm64: dts: imx8mp: Switch to DT overlays for i.
When running within a Python venv we must use the 'coverage' tool (which
is within the venv) so that the venv packages are used in preference to
system packages. Otherwise the coverage tests run in a different
environment from the normal tests and may fail due to missing packages.
Handle this by d
Binman includes a good set of tests covering all of its functionality.
This includes a code-coverage test.
However to date the code-coverage test has not been checked
automatically by CI, relying on people to run 'binman test -T'
themselves.
Plug the gap to avoid bugs creeping in future.
Signed-
The feature to set the toolchain path does not seem to be needed. It
causes problems with venv (see [1]). Let's remove it.
Add some tests while we are here.
It does not look like any docs changes are needed for this.
[1]
https://patchwork.ozlabs.org/project/uboot/patch/20240621131423.2363294-6-
Fix 'Thie' and capitalise 'unicode'.
Signed-off-by: Simon Glass
Suggested-by: Heinrich Schuchardt
---
(no changes since v2)
Changes in v2:
- Add new patch to fix a few typos in toolchain code
tools/buildman/toolchain.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/
This is used by some Binman entry types, so add it to allow more tests
to pass.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
---
(no changes since v2)
Changes in v2:
- Add to buildman requirements instead
tools/buildman/requirements.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a
Add this package so we can run code-coverage tests for Binman.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
---
(no changes since v2)
Changes in v2:
- Add to buildman requirements instead
tools/buildman/requirements.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/buildman/r
Binman has 100% code coverage to ensure that future changes and
refactors do not break existing entry types. This is a critical feature,
given that it is relied on to produce images for all sorts of different
SoCs and vendors.
With the NXP additions the 'binman test -T' step was missed, so the
Bin
Buildman uses all available CPUs by default, so running more than one or
two concurrent processes is not normally useful.
However in some CI cases we want to be able to run several jobs at once
to save time. For example, in a lab situation we may want to run a test
on 20 boards at a time, since on
Buildman retries a failed build when processing a branch, but does not
do this when building current source. It is useful to do this retry in
both cases, so add the logic for it.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 8
1 file changed,
When a file is removed by a commit (e.g. include/common.h yay!) it can
cause incremental build failures since one of the dependency files from
a previous build may mention the file.
Add an option to run 'make mrproper' automatically when a build fails.
This can be used to automatically resolve the
When this flag is enabled, 'make mrproper' is always used when
reconfiguring, so there is no point in doing it again.
Update this.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/bui
Pass this in so the caller can change it independently of the member
variable.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/tools/buildman/builderthread.py b/tools/bu
Pass this in so the caller can change it independently of the member
variable.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/tools/buildman/builderthread.py b/tools/buildman/bu
Pass this in so the caller can change it independently of the member
variable.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/tools/buildman/builderthread.py b/tools/buildman/build
Add assumed sizes so that Binman can check that the U-Boot binaries do
not grow too large.
Signed-off-by: Simon Glass
---
(no changes since v1)
arch/x86/dts/u-boot.dtsi | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/x86/dts/u-boot.dtsi b/arch/x86/dts/u-boot.dtsi
index e0de331809
This cannot ever go at offset 0 since the descriptor is there. Use a
better offset for the ME, as used by link and coral, for example.
This matters when we start using assumed sizes for missing blobs.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/binman/etype/intel_descriptor.py
Binman has a the useful feature of handling missing external blobs
gracefully, including allowing them to be missing, deciding whether the
resulting image is functional or not and faking blobs when this is
necessary for particular tools (e.g. mkimage).
This feature is widely used in CI. One drawba
Reduce the length of the underline for this header, to match the
heading itself.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/binman/entry.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/binman/entry.py b/tools/binman/entry.py
index 42e0b7b9145..2ed65
Correct formatting errors in the documentation.
Regenerate the entries.rst file to include this recent addition.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/binman/entries.rst| 35 +
tools/binman/etype/ti_secure.py | 45 +-
Regenerate the entries.rst file to include this recent addition.
Note that more docs are needed here, to actually describe the entry
type.
Note also that the entry type needs Binman tests added.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/binman/entries.rst | 22 ++
Somehow the class documentation has got out of sync with the generated
entries.rst file. Regenerating it causes errors, so correct these and
regenerate the entries.rst file.
Signed-off-by: Simon Glass
Fixes: 809f28e7213 ("binman: capsule: Use dumped capsule header...")
---
(no changes since v1)
This series includes patches to update buildman to support Labgrid
better and some minor binman fixes and improvements.
Changes in v2:
- Move the binman assume-size feature into this series
Simon Glass (14):
binman: efi: Correct entry docs
binman: Regenerate nxp docs
binman: ti: Regenerate
Now that am335x_evm boots OK on the Beaglebone black, drop the latter
and update the docs to cover the change.
Also add a few updates about 'make fit' and drop the note about the
security review, as U-Boot's verified boot has had quite extensive
review now.
Signed-off-by: Simon Glass
Reviewed-by
This causes a hang, so disable it. Unfortunately the RAM-size fix does
not resolve the problem and I am unsure what is wrong. As soon as the
cache is enabled the board appears to hang.
Fixes: 6d8cdfd1536 ("rockchip: spl: Enable caches to speed up checksum
validation")
Signed-off-by: Simon Glass
The code here is confusing due to large blocks which are #ifdefed out.
Add a function phase_sdram_init() which returns whether SDRAM init
should happen in the current phase, using that as needed to control the
code flow.
This increases code size by about 500 bytes in SPL when the cache is on,
sinc
At present gd->ram_size is 0 in SPL, meaning that it is not possible to
enable the cache. Correct this by always populating the RAM size
correctly.
This increases code size by about 500 bytes in SPL, since it must call
the rather large rockchip_sdram_size() function.
Signed-off-by: Simon Glass
-
The dcache may not be enabled in SPL. Add a check to avoid trying to
use an undefined function.
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
---
(no changes since v1)
common/spl/spl_atf.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/common/spl/spl_atf.c b/common/s
On some boards, the bloblist is created in SPL once SDRAM is ready. It
cannot be accessed until that point, so is not available early in SPL.
Add a condition to avoid a hang in this case.
This fixes a hang in chromebook_coral
Fixes: 70fe2385943 ("fdt: Allow the devicetree to come from a bloblist
With a recent change, regulators_enable_boot_on() returns an error if a
regulator is already set. Check for and handle this situation.
Fixes: d99fb64a98a power: regulator: Only run autoset once for each regulator
Reviewed-by: Jonas Karlman
Reviewed-by: Quentin Schulz
Signed-off-by: Simon Glass
Add better logging for power init so that CONFIG_LOG_ERROR_RETURN can
be enabled.
Signed-off-by: Simon Glass
Reviewed-by: Quentin Schulz
---
(no changes since v2)
Changes in v2:
- Remove the superfluous if() and drop the debug() as well
board/google/veyron/veyron.c | 30 -
Set a size limit for this board so that we get a build error if it grows
too much.
Note that the limit is approximately, since it does not include the FDT,
microcode and fdtmap, which can change in size. However this board is
fairly stable, so overflowing this limit will likely result in the image
It does not make sense to enable all SHA algorithms unless they are
needed. It bloats the code and in this case, causes chromebook_link to
fail to build. That board does use the TPM, but not with measured boot,
nor EFI.
Since EFI_TCG2_PROTOCOL already selects these options, we just need to
add the
This cannot be enabled early in boot since some other init is needed.
At this point it is unclear exactly what init is needed, so disable
the debug UART to avoid a hang.
Signed-off-by: Simon Glass
---
(no changes since v1)
configs/nyan-big_defconfig | 1 -
1 file changed, 1 deletion(-)
diff -
There is no need to remove input files. It makes it harder to diagnose
failures. Keep the payload file.
There is no test for this condition, but one could be added.
Signed-off-by: Simon Glass
Acked-by: Sughosh Ganu
---
Changes in v4:
- Drop Fixes tag
tools/binman/etype/efi_capsule.py | 1 -
The tool must return an error code when invalid arguments are provided,
otherwise binman has no way of knowing that anything went wrong.
Correct this.
Signed-off-by: Simon Glass
Fixes: fab430be2f4 ("tools: add mkeficapsule command for UEFI...")
---
(no changes since v1)
tools/mkeficapsule.c |
Tools cannot be assumed to be present. Add a check for this with the
mkeficpasule tool.
Signed-off-by: Simon Glass
Fixes: b617611b27a ("binman: capsule: Add support for generating...")
---
(no changes since v1)
tools/binman/etype/efi_capsule.py | 4
1 file changed, 4 insertions(+)
diff -
Now that this tool has a version number, collect it.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/binman/btool/mkeficapsule.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/binman/btool/mkeficapsule.py
b/tools/binman/btool/mkeficapsule.py
index ef1d
Tools should have an option to obtain the version, so add this to the
mkeficapsule tool.
Signed-off-by: Simon Glass
---
(no changes since v1)
doc/mkeficapsule.1 | 4
tools/mkeficapsule.c | 8 +++-
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/doc/mkeficapsule.1 b/do
This series includes fixes to get some rockchip and nvidia boards
working again. It also drops the broken Beaglebone Black config and
provides a devicetree fix for coral (x86).
Note that since this series fixes bugs, it is targeted at -master
Changes in v4:
- Drop Fixes tag
- Add new patch to set
Adjust indentation from spaces to tab (+optional two spaces) as in
coding style with command like:
$ sed -e 's/^/\t/' -i */Kconfig
Signed-off-by: Anand Moon
---
boot/Kconfig | 8
cmd/Kconfig | 20 ++--
disk/Kconfig | 2 +-
lib/Kconfig | 2 +-
net/Kco
On 2024-06-23 06:15, FUKAUMI Naoki wrote:
> rk3328-rock-pi-e-v3.dts is identical to rk3328-rock-pi-e.dts in
> upstream. only difference between v3.0 and prior ver. is, using
> rk3328-sdram-ddr4-666.dtsi instead of rk3328-sdram-ddr3-666.dtsi.
>
> here is console output from ROCK Pi E v3.0:
>
> ```
On Sun, 23 Jun 2024 at 13:21, Dragan Simic wrote:
>
> Hello Fukaumi,
>
> On 2024-06-23 06:15, FUKAUMI Naoki wrote:
> > rk3328-rock-pi-e-v3.dts is identical to rk3328-rock-pi-e.dts in
> > upstream. only difference between v3.0 and prior ver. is, using
> > rk3328-sdram-ddr4-666.dtsi instead of rk332
Hello Fukaumi,
On 2024-06-23 06:15, FUKAUMI Naoki wrote:
rk3328-rock-pi-e-v3.dts is identical to rk3328-rock-pi-e.dts in
upstream. only difference between v3.0 and prior ver. is, using
rk3328-sdram-ddr4-666.dtsi instead of rk3328-sdram-ddr3-666.dtsi.
I think you'll need to get the device tree
Simon reports that after enabling all algorithms on the TPM some boards
fail since they don't have enough storage to accommodate the ~5KB growth.
The choice of hash algorithms is determined by the platform and the TPM
configuration. Failing to cap a PCR in a bank which the platform left
active is
This function was used on measured boot to retrieve the number of active
PCR banks and was designed to work with the TCG protocols.
Since we now have the need to retrieve the active PCRs outside the
measured boot context -- e.g use the in the command line, decouple the
function.
Create one that wi
efi_tcg2.h already includes tpm-v2.h. Remove it
Reviewed-by: Heinrich Schuchardt
Signed-off-by: Ilias Apalodimas
---
lib/efi_loader/efi_tcg2.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/efi_loader/efi_tcg2.c b/lib/efi_loader/efi_tcg2.c
index b4915cab6be7..19fe4720ef48 100644
--- a/l
The previous patch is moving the TPM TCG headers in their own file for
a cleaner API. Move the functions in their own file as well.
Signed-off-by: Ilias Apalodimas
---
include/tpm-v2.h | 190 -
include/tpm_tcg2.h | 189
lib/Makefile | 2 +
lib/tpm-v2.c |
commit 97707f12fdab ("tpm: Support boot measurements") moved out code
from the EFI subsystem into the TPM one to support measurements when
booting with !EFI.
Those were moved directly into the TPM subsystem and in the tpm-v2.c
library. In hindsight, it would have been better to move it in new
file
commit 97707f12fdab ("tpm: Support boot measurements") moved some of the
EFI TCG code to the TPM subsystem. Those definitions are now in tpm-v2.h.
Let's remove the stale entries
Reviewed-by: Heinrich Schuchardt
Signed-off-by: Ilias Apalodimas
---
include/efi_tcg2.h | 8
1 file changed,
1 - 100 of 105 matches
Mail list logo
