Re: [PATCH] eth: asix88179: reset during probe

2024-06-22 Thread Marek Vasut
On 6/18/24 4:57 PM, Caleb Connolly wrote: In some cases (consistently in my case with an embedded board) the ethernet controller will time out on the first init but always succeed after reset. Let's reset the controller during probe so we always start with it in a known state, and don't have wai

[RFC] rockchip: add support for Radxa ROCK Pi E v3.0 which uses DDR4 SDRAM

2024-06-22 Thread FUKAUMI Naoki
rk3328-rock-pi-e-v3.dts is identical to rk3328-rock-pi-e.dts in upstream. only difference between v3.0 and prior ver. is, using rk3328-sdram-ddr4-666.dtsi instead of rk3328-sdram-ddr3-666.dtsi. here is console output from ROCK Pi E v3.0: ``` U-Boot TPL 2024.07-rc4-dirty (Jun 23 2024 - 12:53:09) D

[PULL] u-boot-usb/master

2024-06-22 Thread Marek Vasut
This can also go into next if you prefer. The following changes since commit fe2ce09a0753634543c32cafe85eb87a625f76ca: Merge branch 'master' of https://source.denx.de/u-boot/custodians/u-boot-watchdog (2024-06-18 08:34:56 -0600) are available in the Git repository at: git://source.denx.de

Re: [PATCH 1/2] usb: dwc2: Extract USB DWC2 register definitions

2024-06-22 Thread Marek Vasut
On 5/22/24 4:22 PM, Kongyang Liu wrote: Hi, sorry for the late reply. diff --git a/drivers/usb/common/dwc2_core.c b/drivers/usb/common/dwc2_core.c new file mode 100644 index 00..2fa11fd59d --- /dev/null +++ b/drivers/usb/common/dwc2_core.c @@ -0,0 +1,53 @@ +// SPDX-License-Identifier:

[PATCH] board: mpfs_icicle: change maintainer to Conor

2024-06-22 Thread Conor Dooley
From: Conor Dooley Padmarao is leaving Microchip soon, and suggested that I should take over maintaining the Icicle in U-Boot in his stead. Suggested-by: Padmarao Begari Signed-off-by: Conor Dooley --- CC: Padmarao Begari CC: Conor Dooley CC: Cyril Jean CC: Tom Rini CC: u-boot@lists.denx.d

[PATCH] phy: rockchip: inno-hdmi: Fix missing readl base addr

2024-06-22 Thread Jagan Teki
inno_poll passes the reg offset that is used by readl_poll_sleep_timeout without any base addr. Fix it. Bug: inno_hdmi_phy phy@ff43: Pre-PLL locking failed inno_hdmi_phy phy@ff43: PHY: Failed to power on phy@ff43: -110. failed to power on phy (ret=-110) inno_hdmi_phy phy@ff43: Pre

Re: [PATCH 2/7] efi_loader: fix the return values on efi_tcg

2024-06-22 Thread Ilias Apalodimas
On Sat, 22 Jun 2024 at 21:01, Heinrich Schuchardt wrote: > > > > Am 22. Juni 2024 18:09:40 MESZ schrieb Ilias Apalodimas > : > >Hi Heinrich, > > > >[...] > > > >> > rc = tpm2_submit_command(dev, input_param_block, > >> >output_param_block, &resp_buf_size); >

Re: [PATCH 2/7] efi_loader: fix the return values on efi_tcg

2024-06-22 Thread Heinrich Schuchardt
Am 22. Juni 2024 18:09:40 MESZ schrieb Ilias Apalodimas : >Hi Heinrich, > >[...] > >> > rc = tpm2_submit_command(dev, input_param_block, >> >output_param_block, &resp_buf_size); >> > @@ -714,19 +721,20 @@ efi_tcg2_get_active_pcr_banks(struct >> > efi_tcg2_

Re: [PATCH 4/7] tpm: Move TCG into a separate library

2024-06-22 Thread Ilias Apalodimas
On Sat, 22 Jun 2024 at 19:36, Ilias Apalodimas wrote: > > Hi > > again many thanks for the quick review > > On Sat, 22 Jun 2024 at 19:25, Heinrich Schuchardt wrote: > > > > On 22.06.24 16:35, Ilias Apalodimas wrote: > > > commit 97707f12fdab ("tpm: Support boot measurements") moved out code > > >

Pull request doc-2024-07-rc5-2

2024-06-22 Thread Heinrich Schuchardt
Dear Tom, The following changes since commit fe2ce09a0753634543c32cafe85eb87a625f76ca: Merge branch 'master' of https://source.denx.de/u-boot/custodians/u-boot-watchdog (2024-06-18 08:34:56 -0600) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-efi.g

Re: [PATCH 7/7] tpm: allow the user to select the compiled algorithms

2024-06-22 Thread Ilias Apalodimas
On Sat, 22 Jun 2024 at 19:34, Heinrich Schuchardt wrote: > > On 22.06.24 16:35, Ilias Apalodimas wrote: > > Simon reports that after enabling all algorithms on the TPM some boards > > fail since they don't have enough storage to accommodate the ~5KB growth. > > > > The choice of hash algorithms ar

Re: [PATCH] efi_loader: adjust config options for capsule updates

2024-06-22 Thread Ilias Apalodimas
On Sat, 22 Jun 2024 at 19:36, Heinrich Schuchardt wrote: > > On 20.06.24 22:15, Ilias Apalodimas wrote: > > EFI_IGNORE_OSINDICATIONS is used to ignore OsIndications if setvariable > > at runtime is not supported and allow the platform to perform capsule > > updates on disk. With the recent changes

Re: [PATCH 4/7] tpm: Move TCG into a separate library

2024-06-22 Thread Ilias Apalodimas
Hi again many thanks for the quick review On Sat, 22 Jun 2024 at 19:25, Heinrich Schuchardt wrote: > > On 22.06.24 16:35, Ilias Apalodimas wrote: > > commit 97707f12fdab ("tpm: Support boot measurements") moved out code > > from the EFI subsystem into the TPM one to support measurements when > >

Re: [PATCH] efi_loader: adjust config options for capsule updates

2024-06-22 Thread Heinrich Schuchardt
On 20.06.24 22:15, Ilias Apalodimas wrote: EFI_IGNORE_OSINDICATIONS is used to ignore OsIndications if setvariable at runtime is not supported and allow the platform to perform capsule updates on disk. With the recent changes boards can conditionally enable setvariable at runtime using EFI_RT_VOL

Re: [PATCH 7/7] tpm: allow the user to select the compiled algorithms

2024-06-22 Thread Heinrich Schuchardt
On 22.06.24 16:35, Ilias Apalodimas wrote: Simon reports that after enabling all algorithms on the TPM some boards fail since they don't have enough storage to accommodate the ~5KB growth. The choice of hash algorithms are determined by the platform and the TPM configuration. Failing to cap a PC

Re: [PATCH 2/7] efi_loader: fix the return values on efi_tcg

2024-06-22 Thread Ilias Apalodimas
Hi Heinrich, [...] > > rc = tpm2_submit_command(dev, input_param_block, > >output_param_block, &resp_buf_size); > > @@ -714,19 +721,20 @@ efi_tcg2_get_active_pcr_banks(struct > > efi_tcg2_protocol *this, > > u32 *active_pcr_banks)

Re: [PATCH 1/7] tpm: fix the return code, if the eventlog buffer is full

2024-06-22 Thread Heinrich Schuchardt
On 22.06.24 16:35, Ilias Apalodimas wrote: We currently return 'No space left on device' if the eventlong buffer we allocated is not enough. On a similar check later on that function during the call to tcg2_log_init() we return 'No buffer space available'. So switch both error codes to -ENOBUFS s

Re: [PATCH 3/7] efi_loader: remove duplicate TCG algo definitions

2024-06-22 Thread Heinrich Schuchardt
On 22.06.24 16:35, Ilias Apalodimas wrote: commit 97707f12fdab ("tpm: Support boot measurements") moved some of the EFI TCG code to the TPM subsystem. Those definitions are now in tpm-v2.h. Let's remove the duplicate entries The constants are not duplicate but unused. 97707f12fdab introduced di

Re: [PATCH 2/7] efi_loader: fix the return values on efi_tcg

2024-06-22 Thread Heinrich Schuchardt
On 22.06.24 16:35, Ilias Apalodimas wrote: A while back we moved the core functions of the EFI TCG protocol to the TPM APIs in order for them to be used with bootm, booti etc. Some prototypes changed from returning efi_status_t to int, which is more appropriate for the non-EFI APIs. However, some

Re: [PATCH 5/7] efi_loader: remove unneeded header files

2024-06-22 Thread Heinrich Schuchardt
On 22.06.24 16:35, Ilias Apalodimas wrote: efi_tcg2.h already includes tpm-v2.h. Remove it Signed-off-by: Ilias Apalodimas Reviewed by: Heinrich Schuchardt --- lib/efi_loader/efi_tcg2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/efi_loader/efi_tcg2.c b/lib/efi_loader/efi_tcg

Re: [PATCH 4/7] tpm: Move TCG into a separate library

2024-06-22 Thread Heinrich Schuchardt
On 22.06.24 16:35, Ilias Apalodimas wrote: commit 97707f12fdab ("tpm: Support boot measurements") moved out code from the EFI subsystem into the TPM one to support measurements when booting with !EFI. Those were moved directly into the TPM subsystem and in the tpm-v2.c library. In hindsight, it

Re: [PATCH 1/1] efi_selftest: can't have measured device-tree with kaslr-seed

2024-06-22 Thread Ilias Apalodimas
On Sat, 22 Jun 2024 at 17:58, Heinrich Schuchardt wrote: > > On 18.06.24 17:54, Ilias Apalodimas wrote: > > On Tue, 18 Jun 2024 at 15:24, Heinrich Schuchardt > > wrote: > >> > >> Test that we don't have a /chosen/kaslr-seed property if we measure the > >> device-tree. > >> > >> Signed-off-by: Hei

Re: [PATCH 1/1] efi_selftest: can't have measured device-tree with kaslr-seed

2024-06-22 Thread Heinrich Schuchardt
On 18.06.24 17:54, Ilias Apalodimas wrote: On Tue, 18 Jun 2024 at 15:24, Heinrich Schuchardt wrote: Test that we don't have a /chosen/kaslr-seed property if we measure the device-tree. Signed-off-by: Heinrich Schuchardt --- lib/efi_selftest/efi_selftest_fdt.c | 7 +++ 1 file changed,

Re: [PATCH 1/2] tpm: Fix return code, if the eventlog buffer is full

2024-06-22 Thread Ilias Apalodimas
On Thu, 20 Jun 2024 at 22:19, Ilias Apalodimas wrote: > > On Thu, 20 Jun 2024 at 22:16, Ilias Apalodimas > wrote: > > > > We currently return 'No space left on device' if the eventlong buffer > > we allocated is not enough. On a similar check later on that function > > during the call to tcg2_log

[PATCH 7/7] tpm: allow the user to select the compiled algorithms

2024-06-22 Thread Ilias Apalodimas
Simon reports that after enabling all algorithms on the TPM some boards fail since they don't have enough storage to accommodate the ~5KB growth. The choice of hash algorithms are determined by the platform and the TPM configuration. Failing to cap a PCR in a bank which the platform left active is

[PATCH 6/7] tpm: Untangle tpm2_get_pcr_info()

2024-06-22 Thread Ilias Apalodimas
This function was used on measured boot to retrieve the number of active PCR banks and was designed to work with the TCG protocols. Since we now have the need to retrieve the active PCRs outside the measured boot context -- e.g use the in the command line, decouple the function. Create one that wi

[PATCH 5/7] efi_loader: remove unneeded header files

2024-06-22 Thread Ilias Apalodimas
efi_tcg2.h already includes tpm-v2.h. Remove it Signed-off-by: Ilias Apalodimas --- lib/efi_loader/efi_tcg2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/efi_loader/efi_tcg2.c b/lib/efi_loader/efi_tcg2.c index 10c09caac35a..c654d2cbd704 100644 --- a/lib/efi_loader/efi_tcg2.c +++ b/lib

[PATCH 4/7] tpm: Move TCG into a separate library

2024-06-22 Thread Ilias Apalodimas
commit 97707f12fdab ("tpm: Support boot measurements") moved out code from the EFI subsystem into the TPM one to support measurements when booting with !EFI. Those were moved directly into the TPM subsystem and in the tpm-v2.c library. In hindsight, it would have been better to move it in new file

[PATCH 3/7] efi_loader: remove duplicate TCG algo definitions

2024-06-22 Thread Ilias Apalodimas
commit 97707f12fdab ("tpm: Support boot measurements") moved some of the EFI TCG code to the TPM subsystem. Those definitions are now in tpm-v2.h. Let's remove the duplicate entries Signed-off-by: Ilias Apalodimas --- include/efi_tcg2.h | 8 1 file changed, 8 deletions(-) diff --git a/

[PATCH 2/7] efi_loader: fix the return values on efi_tcg

2024-06-22 Thread Ilias Apalodimas
A while back we moved the core functions of the EFI TCG protocol to the TPM APIs in order for them to be used with bootm, booti etc. Some prototypes changed from returning efi_status_t to int, which is more appropriate for the non-EFI APIs. However, some of the EFI callsites never changed and we en

[PATCH 1/7] tpm: fix the return code, if the eventlog buffer is full

2024-06-22 Thread Ilias Apalodimas
We currently return 'No space left on device' if the eventlong buffer we allocated is not enough. On a similar check later on that function during the call to tcg2_log_init() we return 'No buffer space available'. So switch both error codes to -ENOBUFS since we are always checking a buffer and not

[PATCH 0/7] The great TCG deduplication saga

2024-06-22 Thread Ilias Apalodimas
Hi all, A while back some TPM measured boot code was moved out of EFI in order to support !EFI boot methods, e.g bootm, booti etc. Back then we decided to move the code in the TPM subsystem directly. In hindsight, we should have created a different library file that hosts all the TCG specific bits

Re: [PATCH v3 16/18] rockchip: Avoid #ifdefs in RK3399 SPL

2024-06-22 Thread Simon Glass
Hi Kever, On Fri, 21 Jun 2024 at 21:49, Kever Yang wrote: > > Hi Simon, > > On 2024/6/21 22:57, Simon Glass wrote: > > Hi Jonas, > > > > On Fri, 21 Jun 2024 at 00:45, Jonas Karlman wrote: > >> Hi Simon, > >> > >> On 2024-06-21 01:06, Simon Glass wrote: > >>> The code here is confusing due to lar

Re: [PATCH v4 00/14] Introduce the lwIP network stack

2024-06-22 Thread Maxim Uvarov
пт, 21 июн. 2024 г. в 21:42, Fabio Estevam : > > Hi Tim and Jerome, > > On Fri, Jun 21, 2024 at 1:08 PM Tim Harvey wrote: > > > I tried your to-upstream/v5-wip branch > > (042bea36eb9731079a3d7afffe3774d79e06ac5d) and it behaves the same. Do > > you have something else to try/test? > > Yes, when I

Re: [PATCH RFC] gpio: Fix probing of gpio-hogs

2024-06-22 Thread Chris Webb
Tom Rini wrote: Adding Marek, as the author of commit 48b3ecbedf82 ("gpio: Get rid of gpio_hog_probe_all()"). Thanks! I don't claim this is the correct way to fix this, just that it works. Specifically, the two things I found that got gpio-hog working were (a) adding an explicit probe

Re: [PATCH 1/3] pxe: Add debugging for booting

2024-06-22 Thread Michael Nazzareno Trimarchi
Hi On Wed, Jun 19, 2024 at 2:34 PM Simon Glass wrote: > > Show which boot protocol is being used. > > Signed-off-by: Simon Glass > --- > > boot/pxe_utils.c | 15 +++ > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/boot/pxe_utils.c b/boot/pxe_utils.c > index 4b22b