Re: [PATCH 1/1] bootflow: always initialize bootflow_iter_set_dev parameters

2024-04-10 Thread Nam Cao
On 11/Apr/2024 Heinrich Schuchardt wrote: > method_flags may be passed uninitialized to bootflow_iter_set_dev() > if dev is not NULL. > > Always initialize method_flags. > > Addresses-Coverity-ID: 467057 Uninitialized scalar variable > Signed-off-by: Heinrich Schuchardt Reviewed-by: Nam Cao >

Re: [PATCH] usb: musb-new: sunxi: support usage with DM_USB_GADGET

2024-04-10 Thread John Watts
On Sun, Dec 31, 2023 at 03:38:37PM -0500, Aren Moynihan wrote: > Add support for building the sunxi-musb driver with DM_USB_GADGET > including adding a separate IRQ handling function and registering the > driver with the musb system differently. Hi there, Were you aware of this similar patch? ht

Re: [PATCH v2 0/2] sunxi, usb: UDC/DM gadget model support

2024-04-10 Thread John Watts
Hi there, I've tested this patch and it seems to support the gadget model, but I'm having a lot of USB errors. What device did you test this on? John. On Thu, Jun 08, 2023 at 01:56:29PM -0600, Sam Edwards wrote: > Happy Thursday, U-Boot list! > > Here is attempt 2 at making this USB controller

Re: [PATCH] ubi: Depend on MTD

2024-04-10 Thread Michael Nazzareno Trimarchi
Hi On Thu, Apr 11, 2024 at 7:06 AM John Watts wrote: > > UBI required MTD to build correctly, add it as a Kconfig dependency. > > Signed-off-by: John Watts > --- > While working with UBI on my SPI NAND patch series I found it was > possible to enable it without enabling the MTD subsystem. > Add

[PATCH] xilinx: Enable NVMEM framework for all platforms

2024-04-10 Thread Michal Simek
Boards which have for example MAC address in eeprom but not in Xilinx format (legacy or FRU) could reference it via nvmem cells. For example: &gem0 { nvmem-cells = <&mac>; nvmem-cell-names = "mac-address"; }; &eeprom { #address-cells = <1>; #size-cells = <1>;

Re: [PATCH 1/2] lmb: Avoid to add identical region in lmb_add_region_flags()

2024-04-10 Thread Patrice CHOTARD
On 4/10/24 17:28, Tom Rini wrote: > On Mon, Mar 11, 2024 at 03:39:17PM +0100, Patrice Chotard wrote: > >> In case lmb_add_region_flags() is called with the same parameter than >> an already existing lmb and this lmb is adjacent to its previous lmb with >> different flag, this lmb is added again

On upgrade from uboot v2017 Comphy-0: UNCONNECTED

2024-04-10 Thread Lev Olshvang
Hello list, My board is Marvell Armada 3720 Espressobin variant I am trying to upgrade from uboot v2017 to latest one I was able to get to uboot shell prompt after disabling almost all and leaving only network. For a network board has Marvell switch. I added some debug prints to drivers/phy/marvel

[PATCH 2/2] sunxi: Support UART2 on the T113

2024-04-10 Thread John Watts
The T113 supports UART2 on PD1 and PD2. Add it as an option. Signed-off-by: John Watts --- arch/arm/mach-sunxi/board.c | 4 include/sunxi_gpio.h| 1 + 2 files changed, 5 insertions(+) diff --git a/arch/arm/mach-sunxi/board.c b/arch/arm/mach-sunxi/board.c index f5da50b43a..4176543cd

[PATCH 1/2] sunxi: Support UART1 on the T113

2024-04-10 Thread John Watts
The T113 supports UART1 on pins PG6 and PG7, add support for it here. Signed-off-by: John Watts --- arch/arm/mach-sunxi/board.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-sunxi/board.c b/arch/arm/mach-sunxi/board.c index f4dbb2a740..f5da50b43a 100644 -

[PATCH 0/2] sunxi: Support UART1 and UART2 on the T113

2024-04-10 Thread John Watts
The T113 supports UART1 and UART2 on PG and PD pins respectively. Add support for these in U-Boot so we can use them. Note: I'm not entirely sure if the PD pins should be default, they overlap with the LCD pins. I am however using this on a real board. Signed-off-by: John Watts --- John Watts (2

[PATCH] ubi: Depend on MTD

2024-04-10 Thread John Watts
UBI required MTD to build correctly, add it as a Kconfig dependency. Signed-off-by: John Watts --- While working with UBI on my SPI NAND patch series I found it was possible to enable it without enabling the MTD subsystem. Add a Kconfig option to solve this. --- drivers/mtd/ubi/Kconfig | 1 + 1

[PATCH] boot: Pass baud rate to stdout-path

2024-04-10 Thread John Watts
Linux might use the wrong baud rate such as 9600 by default, make sure to specify it when passing the serial port over. Signed-off-by: John Watts --- On my board at least (a sunxi T113) the serial console will initialize as 9600 baud instead of the set baud. Pass the baud with the serial device t

Re: [PATCH 0/8] SUNIV SPI NAND support in SPL

2024-04-10 Thread John Watts
Hello, I've used this code extensively, incorporated it in to an RFC branch of mine during development and reviewed it in the process. John. Reviewed-by: John Watts Tested-by: John Watts On Fri, Oct 14, 2022 at 11:05:12AM +0800, Icenowy Zheng wrote: > This patchset tries to extend SPI-based b

Re: [PATCH v1 1/2] sunxi: SPL SPI: Add SPI boot support for the Allwinner R528/T113 SoCs

2024-04-10 Thread John Watts
Hi there, I've been using my own independent implementation of this patch but today I gave this one a test in my tree and found out it works. The code looks fine in comparison, so here's a Tested-by and a Reviewed-by. John. Tested-by: John Watts Reviewed-by: John Watts On Sat, Nov 11, 2023 a

[PATCH RFC 15/15] spl: Support loading FIT images in UBI

2024-04-10 Thread John Watts
The FIT loader doesn't support access through UBI, so load the FIT image ourself in to memory then boot it normally. Signed-off-by: John Watts --- common/spl/spl_ubi.c | 34 ++ 1 file changed, 30 insertions(+), 4 deletions(-) diff --git a/common/spl/spl_ubi.c b/c

[PATCH RFC 14/15] spl: Support SPI NAND boot in UBI

2024-04-10 Thread John Watts
UBI supports traditional NAND and oneNAND devices already, so add support for booting from SPI NAND devices. Signed-off-by: John Watts --- common/spl/spl_ubi.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/common/spl/spl_ubi.c b/common/spl/spl_ubi.c index d7

[PATCH RFC 13/15] sunxi: Implement spinand_ helpers

2024-04-10 Thread John Watts
These are used by NAND-aware loaders such as UBI. Signed-off-by: John Watts --- arch/arm/mach-sunxi/spl_spi_sunxi.c | 21 + 1 file changed, 21 insertions(+) diff --git a/arch/arm/mach-sunxi/spl_spi_sunxi.c b/arch/arm/mach-sunxi/spl_spi_sunxi.c index 602ebfe8c5..d6b03678d0 1

[PATCH RFC 12/15] nand: Add spinand_ helper functions

2024-04-10 Thread John Watts
These are implemented by the board-specific SPL code for use with NAND-aware loaders like UBI. Signed-off-by: John Watts --- include/nand.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/nand.h b/include/nand.h index 220ffa202e..9fb8941dce 100644 --- a/include/nand.h +++ b/includ

[PATCH RFC 11/15] sunxi: Use SPL_SPINAND for configuration

2024-04-10 Thread John Watts
Use the newly created SPL_SPINAND configuration options instead of sunxi-only options. No backwards compatibility is needed as the SPI NAND patches are not mainline yet. Signed-off-by: John Watts --- arch/arm/mach-sunxi/Kconfig | 16 arch/arm/mach-sunxi/spl_spi_sunxi.c

[PATCH RFC 10/15] spl: Add SPL_SPINAND configuration options

2024-04-10 Thread John Watts
Boards that support SPI NAND need to specify the page and eraseblock size. Add those as Kconfig options. Signed-off-by: John Watts --- common/spl/Kconfig | 21 + 1 file changed, 21 insertions(+) diff --git a/common/spl/Kconfig b/common/spl/Kconfig index 6405374bcc..51d1f9f59

[PATCH RFC 08/15] spl: Add BOOT_DEVICE_SPINAND option

2024-04-10 Thread John Watts
Currently there are two different boot device options: SPI and NAND. One is intended for SPI NOR operation, the other is intended for dedicated NAND operation. Add a new option for SPI NAND operation. Signed-off-by: John Watts --- arch/arm/include/asm/spl.h | 1 + arch/mips/include/asm/spl.

[PATCH RFC 09/15] sunxi: Implement BOOT_DEVICE_SPINAND in SPL

2024-04-10 Thread John Watts
Instead of trying to boot from SPI NAND then SPI NOR in series, select one based on the current boot device. Signed-off-by: John Watts --- arch/arm/include/asm/arch-sunxi/spl.h | 1 + arch/arm/mach-sunxi/board.c | 5 - arch/arm/mach-sunxi/spl_spi_sunxi.c | 28 ++

[PATCH RFC 07/15] sunxi: Separate boot device and boot position

2024-04-10 Thread John Watts
While MMC1 and MMC2 each currently have only one upper byte possibility, SPI NAND has quite a few. To solve this, split up the byte handling across two functions in preparation for SPI NAND support. I have not tested this patch to validate that MMC SPL offsets are working. It looks like it should

[PATCH RFC 06/15] sunxi: enable support for SPI NAND booting on SUNIV

2024-04-10 Thread John Watts
From: Icenowy Zheng As we added support for SPI NAND to the existing SPL SPI codepath, route the boot code to it when it detects the BROM loads SPL from SPI NAND, as for SoCs with both SPI NAND and boot media indicator support, the boot media indicator is the same for SPI NOR and NAND. Signed-of

[PATCH RFC 05/15] sunxi: SPL SPI: add initial support for booting from SPI NAND

2024-04-10 Thread John Watts
From: Icenowy Zheng This commit adds support for booting from SPI NAND to SPL SPI code by mimicing the behavior of boot ROM (use fixed page size and sequentially try SPI NOR and NAND). Signed-off-by: Icenowy Zheng Tested-by: Samuel Holland # Orange Pi Zero Plus --- arch/arm/mach-sunxi/Kconfig

[PATCH RFC 04/15] sunxi: SPL SPI: allow multiple boot attempt

2024-04-10 Thread John Watts
From: Icenowy Zheng As we're going to add support for SPI NAND to this code, add code that allows multiple boot attempts with different load offsets and functions. To keep compatibility with loading raw binary on SPI NOR, a bool parameter is used to allow booting without valid magic number when

[PATCH RFC 03/15] sunxi: SPL SPI: add support for read command with 2 byte address

2024-04-10 Thread John Watts
From: Icenowy Zheng This kind of read command is utilized in SPI NANDs for reading data inside a selected page, which is obviously smaller than how much 2 byte address can address. So 2 bytes are used for the address and one dummy byte is needed after the real address. As the address is sent out

[PATCH RFC 02/15] sunxi: SPL SPI: extract code for doing SPI transfer

2024-04-10 Thread John Watts
From: Icenowy Zheng To support SPI NAND flashes, more commands than Read (03h) are needed. Extract the code for doing SPI transfer from the reading code for code reuse. Signed-off-by: Icenowy Zheng Reviewed-by: Samuel Holland Tested-by: Samuel Holland # Orange Pi Zero Plus --- arch/arm/mach

[PATCH RFC 01/15] sunxi: SPL SPI: Add SPI boot support for the Allwinner R528/T113 SoCs

2024-04-10 Thread John Watts
From: Maksim Kiselev R528/T113 SoCs uses the same SPI IP as the H6, also have the same clocks and reset bits layout, but the CCU base is different. Another difference is that the new SoCs do not have a clock divider inside. Instead of this we should configure sample mode depending on input clock

[PATCH RFC 00/15] Support SPI NAND booting on the T113

2024-04-10 Thread John Watts
This series is my current working and tested setup for booting from SPI NAND chips on the Allwinner T113. I have included the following patches from others. I may have modified them to work with the latest mainline: https://lore.kernel.org/all/20221014030520.3067228-1-...@icenowy.me/ https://lore

[PATCH v5 5/5] imx93: convert to OF_UPSTREAM

2024-04-10 Thread Peng Fan (OSS)
From: Peng Fan Convert all i.MX93 boards to OF_UPSTREAM. Add lpi2c2 nodes for imx93-11x11-evk-u-boot.dtsi. Add usbotg1 nodes in imx93-u-boot.dtsi and board u-boot.dtsi. The nodes could be removed after upstream linux supports them. Signed-off-by: Peng Fan --- arch/arm/dts/Makefile

[PATCH v5 4/5] clk: imx93: fix anatop base

2024-04-10 Thread Peng Fan (OSS)
From: Peng Fan The PLL clk needs use anatop base, otherwise wrong PLL address will be used. Fixes: 9c153e46661b ("clk: imx: add i.MX93 CCF driver") Signed-off-by: Peng Fan --- drivers/clk/imx/clk-imx93.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/imx/clk-im

[PATCH v5 3/5] cpu: drop imx9_cpu

2024-04-10 Thread Peng Fan (OSS)
From: Peng Fan This was wrongly committed, no user, remove it. Signed-off-by: Peng Fan --- drivers/cpu/imx9_cpu.c | 224 - 1 file changed, 224 deletions(-) diff --git a/drivers/cpu/imx9_cpu.c b/drivers/cpu/imx9_cpu.c deleted file mode 100644 ind

[PATCH v5 2/5] serial: lpuart: use ipg clk for i.MX7ULP

2024-04-10 Thread Peng Fan (OSS)
From: Peng Fan To i.MX7ULP compatible lpuart, there is only ipg clk, no per clk. So add a devtype check for i.MX7ULP. Signed-off-by: Peng Fan --- drivers/serial/serial_lpuart.c | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/drivers/serial/seri

[PATCH v5 1/5] gpio: imx_rgpio2p: support one address

2024-04-10 Thread Peng Fan (OSS)
From: Peng Fan The i.MX8ULP/93 gpio dt-schema have been updated to only have one address entry, update the driver to support it. Signed-off-by: Peng Fan --- drivers/gpio/imx_rgpio2p.c | 42 ++ 1 file changed, 38 insertions(+), 4 deletions(-) diff --git

[PATCH v5 0/5] imx93: Conver to OF_UPSTREAM

2024-04-10 Thread Peng Fan (OSS)
A few nodes were added to soc and board u-boot.dtsi(lpi2c, usbotg), those nodes could be dropped after upstream linux supports them. To support OF_UPSTREAM, a few driver changes are included. For TMU, still use U-Boot node, I will prepare a kernel update, then back to U-Boot support. Mathieu: pl

Re: [PATCH] clk: imx8mp: add pwm clocks support

2024-04-10 Thread Sean Anderson
On 4/10/24 23:18, Sean Anderson wrote: On 3/10/23 10:15, Tommaso Merciai wrote: Add clocks support for the PWM controllers. This is ported from Linux v6.3.0-rc1 Signed-off-by: Tommaso Merciai ---   drivers/clk/imx/clk-imx8mp.c | 24   1 file changed, 24 insertions(+) d

Re: [PATCH] clk: imx8mp: add pwm clocks support

2024-04-10 Thread Sean Anderson
On 3/10/23 10:15, Tommaso Merciai wrote: Add clocks support for the PWM controllers. This is ported from Linux v6.3.0-rc1 Signed-off-by: Tommaso Merciai --- drivers/clk/imx/clk-imx8mp.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/clk/imx/clk-imx8mp.c

Re: [PATCH 1/1] clk: sifive: avoid declaring static variables in includes

2024-04-10 Thread Sean Anderson
On 2/16/24 18:18, Heinrich Schuchardt wrote: The existing code is unnecessarily convoluted: Arrays __prci_init_clocks_fu[5|7]40 are initialized with data. In separate includes fu[5|7]40-prci.h the size of the arrays is provided as constants. By moving the structures prci_clk_fu[5|7]40 to the r

Re: [PATCH] clk: sifive: check wrpll_configure_for_rate() return value

2024-04-10 Thread Sean Anderson
On 2/16/24 12:06, Heinrich Schuchardt wrote: wrpll_configure_for_rate() might fail. We should check the return value. Fixes: d56d79ed27c6 ("drivers: clk: add fu740 support") Signed-off-by: Heinrich Schuchardt --- drivers/clk/sifive/sifive-prci.c | 4 +++- 1 file changed, 3 insertions(+), 1 d

Re: [PATCH 1/1] clk: sifive: append missing \n to messages

2024-04-10 Thread Sean Anderson
On 2/16/24 11:35, Heinrich Schuchardt wrote: If multiple messages are written, line-feeds improve the readability. Fixes: c40b6df87fc0 ("clk: Add SiFive FU540 PRCI clock driver") Signed-off-by: Heinrich Schuchardt --- drivers/clk/analogbits/wrpll-cln28hpc.c | 6 +++--- 1 file changed, 3 inse

Re: [PATCH] clk: Fix error message in clk_get_bulk

2024-04-10 Thread Sean Anderson
On 3/9/24 07:27, Jan Kiszka wrote: From: Jan Kiszka Fix a logical inversion of the printed text. Signed-off-by: Jan Kiszka --- drivers/clk/clk-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c index ed6e60bc484.

Re: [PATCH v3] clk: set initial best mux parent to current parent with CLK_MUX_ROUND_CLOSEST

2024-04-10 Thread Sean Anderson
On 3/12/24 04:52, Yang Xiwen wrote: On 3/11/2024 5:34 PM, Maxime Ripard wrote: On Thu, Mar 07, 2024 at 07:18:05PM +0800, Yang Xiwen wrote: On 3/7/2024 4:48 PM, Maxime Ripard wrote: Hi, On Thu, Mar 07, 2024 at 10:03:50AM +0800, Yang Xiwen via B4 Relay wrote: From: Yang Xiwen Originally, the

Re: [PATCH] clk: Propagate clk_set_rate() if CLK_SET_PARENT_RATE present

2024-04-10 Thread Sean Anderson
On 3/7/24 19:04, Sam Protsenko wrote: Sometimes clocks provided to a consumer might not have .set_rate operation (like gate or mux clocks), but have CLK_SET_PARENT_RATE flag set. In that case it's usually possible to find a parent up the tree which is capable of setting the rate (div, pll, etc).

Re: [PATCH 1/1] sandbox: use sane access rights for files

2024-04-10 Thread Sean Anderson
On 4/10/24 04:38, Heinrich Schuchardt wrote: When writing an executable, allowing other users to modify it introduces a security issue. Generally we should avoid giving other users write access to our files by default. Replace chmod(777) by chmod(755) and chmod(644). Fixes: 47f5fcfb4169 ("sand

Re: [PATCH 1/1] sandbox: don't call os_close with invalid file descriptor

2024-04-10 Thread Sean Anderson
On 4/10/24 17:50, Heinrich Schuchardt wrote: If open() fails it returns -1. Calling close() with this value makes no sense. Return -EIO instead. Addresses-Coverity-ID: 185828 Improper use of negative value Signed-off-by: Heinrich Schuchardt --- arch/sandbox/cpu/os.c | 2 +- 1 file changed, 1

Re: [PATCH 1/2] dm: core: add support for fallback drivers

2024-04-10 Thread Sean Anderson
On 4/10/24 15:44, Tom Rini wrote: On Wed, Apr 10, 2024 at 07:27:17PM +0200, Heinrich Schuchardt wrote: Am 10. April 2024 19:06:57 MESZ schrieb Caleb Connolly : Introduce support for a uclass to provide a fallback/stub driver which can be used when no device is found for a given node. This mi

Re: [PATCH v2 00/16] pxe: Allow extlinux booting without CMDLINE enabled

2024-04-10 Thread Tom Rini
On Thu, 14 Dec 2023 21:18:58 -0700, Simon Glass wrote: > This series is the culmanation of the current line of refactoring > series. It adjusts pxe to call the booting functionality directly > rather than going through the command-line interface. > > With this is is possible to boot using the ext

Tinkering Problems when Compiling on Apple Silicon

2024-04-10 Thread Maxwell Leo
Dear Das U-Boot Developers: I recently tried to compile the OpenWRT system on a Mac with Apple Silicon, but encountered problems related to U-Boot. The problem is that the compiler is not adding system Python3 library by default when compiling the PyModule in some libs, pylibfdt, for example. I

Re: [PATCH 1/1] tools: use adequate entropy source for initialization vector

2024-04-10 Thread Heinrich Schuchardt
On 4/11/24 01:46, Mark Kettenis wrote: From: Heinrich Schuchardt Date: Thu, 11 Apr 2024 01:31:16 +0200 The random() function is unsafe to initialize cryptographic data. Use getrandom() which reads from /dev/urandom instead. getrandom() is available on Linux sine release 3.17 and on BSD. NACK

Re: [PATCH 1/1] tools: use adequate entropy source for initialization vector

2024-04-10 Thread Mark Kettenis
> From: Heinrich Schuchardt > Date: Thu, 11 Apr 2024 01:31:16 +0200 > > The random() function is unsafe to initialize cryptographic data. > Use getrandom() which reads from /dev/urandom instead. > > getrandom() is available on Linux sine release 3.17 and on BSD. NACK getrandom() isn't evailabl

[PATCH 1/1] tools: use adequate entropy source for initialization vector

2024-04-10 Thread Heinrich Schuchardt
The random() function is unsafe to initialize cryptographic data. Use getrandom() which reads from /dev/urandom instead. getrandom() is available on Linux sine release 3.17 and on BSD. Addresses-Coverity-ID: 312953 Calling risky function Signed-off-by: Heinrich Schuchardt --- tools/image-host.c

[PATCH 1/1] efi_loader: sanitize efi_tcg2_final_events_table definition

2024-04-10 Thread Heinrich Schuchardt
The length of the variable name typically is not 1. Neither the length of the variable name nor the size of the appended data is known in the include. * Define the size of element variable_name as variable. * Remove the unusable element variable_data. Addresses-Coverity-ID: 467400 Out-of-bounds r

[PATCH 1/1] bootflow: always initialize bootflow_iter_set_dev parameters

2024-04-10 Thread Heinrich Schuchardt
method_flags may be passed uninitialized to bootflow_iter_set_dev() if dev is not NULL. Always initialize method_flags. Addresses-Coverity-ID: 467057 Uninitialized scalar variable Signed-off-by: Heinrich Schuchardt --- boot/bootflow.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) di

Re: [PATCH 00/13] Complete decoupling of zboot logic from commands

2024-04-10 Thread Tom Rini
On Sun, 03 Dec 2023 17:29:25 -0700, Simon Glass wrote: > This series refactors the zboot code to allow it to be used with > CONFIG_COMMAND disabled. > > A new zboot_run() function is used to boot a zimage. > > This is cmde (part e of CMDLINE refactoring) > It depends on dm/cmdd-working > which d

[PATCH 1/1] sandbox: don't call os_close with invalid file descriptor

2024-04-10 Thread Heinrich Schuchardt
If open() fails it returns -1. Calling close() with this value makes no sense. Return -EIO instead. Addresses-Coverity-ID: 185828 Improper use of negative value Signed-off-by: Heinrich Schuchardt --- arch/sandbox/cpu/os.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/s

[PATCH] cmd: bootm: add ELF file support

2024-04-10 Thread Maxim Moskalets
From: Maxim Moskalets Some operating systems (e.g. seL4) and embedded applications are ELF images. It is convenient to use FIT-images to implement trusted boot. Added "elf" image type for booting using bootm command. Signed-off-by: Maxim Moskalets --- boot/bootm_os.c | 24

[PATCH v2] board: zynqmp: Move zynqmp commands from board/ to arch/

2024-04-10 Thread Charlie Johnston
The zynqmp cmds.c is currently tied to the board but the commands contained within are more closely tied to the architecture. To allow usage of those commands when the architecture is ZynqMP but the board is not, this change moves the cmds into the arch/ tree. The source file is renamed to zynqmp.

[PATCH v2 0/1] arch: zynqmp: Make zynqmp command more accessible.

2024-04-10 Thread Charlie Johnston
While working on a third-party board using a ZynqMP, I was unable to use the zynqmp command even with the proper config definitions. While that command appears tied to the architecture, it was being included based on the board selection instead. This patch series moves the command to be accessible

Re: [GIT PULL] xilinx patches for v2024.07-rc1

2024-04-10 Thread Tom Rini
On Wed, Apr 10, 2024 at 04:53:41PM +0200, Michal Simek wrote: > Hi Tom, > > please apply these patches to your tree. Gitlab CI is not showing any issue > and buildman for our platforms is also not showing any issue. > > If you have time please take a look at this > https://lore.kernel.org/r/CAHT

Re: [PATCH 2/2] arm: dts: k3: Remove unneeded ti, sci-sysreset binding and nodes

2024-04-10 Thread Jon Humphreys
Andrew Davis writes: > This extra binding is non-standard and now unneeded as we bind the > sysreset driver automatically. This matches what is done in Linux > and allows us to more closely match the DTBs. Remove the binding > and all users. > > Signed-off-by: Andrew Davis > --- > arch/arm/dts/

Re: [PATCH 1/2] firmware: ti_sci: Bind sysreset driver when enabled

2024-04-10 Thread Jon Humphreys
Andrew Davis writes: > The sysreset TI-SCI API is available with TI-SCI always, there is no need > for a DT node to describe the availability of this. If the sysreset driver > is available then bind it during ti-sci probe. > > Remove the unneeded device tree matching. > > Signed-off-by: Andrew Da

Re: [PATCH 1/2] dm: core: add support for fallback drivers

2024-04-10 Thread Tom Rini
On Wed, Apr 10, 2024 at 07:27:17PM +0200, Heinrich Schuchardt wrote: > > > Am 10. April 2024 19:06:57 MESZ schrieb Caleb Connolly > : > >Introduce support for a uclass to provide a fallback/stub driver which > >can be used when no device is found for a given node. This might be > >useful for han

Re: [PATCH] arm: mach-k3: security: Lower verbosity of cert message for GP

2024-04-10 Thread Jon Humphreys
Andrew Davis writes: > When we find a certificate on an image to be booted on a GP device we > print out a message explaining that the certificate is being skipped. > This message is rather long and is printed for every image. Shorten > the message and make the long version into a debug message.

Re: [PATCH 01/13] ti:keys Add EFI signature list

2024-04-10 Thread Jon Humphreys
Ilias Apalodimas writes: > On Tue, 9 Apr 2024 at 23:14, Andrew Davis wrote: >> >> On 4/9/24 2:26 PM, Heinrich Schuchardt wrote: >> > On 4/9/24 14:14, Andrew Davis wrote: >> >> On 4/8/24 10:34 PM, Heinrich Schuchardt wrote: >> >>> On 4/8/24 23:33, Jonathan Humphreys wrote: >> EFI signature l

[PATCH] arm: mach-k3: security: Lower verbosity of cert message for GP

2024-04-10 Thread Andrew Davis
When we find a certificate on an image to be booted on a GP device we print out a message explaining that the certificate is being skipped. This message is rather long and is printed for every image. Shorten the message and make the long version into a debug message. Signed-off-by: Andrew Davis -

Re: [PATCH 3/7] dts: j721e: binman: Include firmware capsules binman nodes

2024-04-10 Thread Andrew Davis
On 4/10/24 1:24 PM, Jon Humphreys wrote: Andrew Davis writes: On 4/8/24 5:17 PM, Jonathan Humphreys wrote: Signed-off-by: Jonathan Humphreys --- arch/arm/dts/k3-j721e-binman.dtsi | 32 +++ 1 file changed, 32 insertions(+) diff --git a/arch/arm/dts/k3-j721e-b

Re: [PATCH 3/7] dts: j721e: binman: Include firmware capsules binman nodes

2024-04-10 Thread Jon Humphreys
Andrew Davis writes: > On 4/8/24 5:17 PM, Jonathan Humphreys wrote: >> Signed-off-by: Jonathan Humphreys >> --- >> arch/arm/dts/k3-j721e-binman.dtsi | 32 +++ >> 1 file changed, 32 insertions(+) >> >> diff --git a/arch/arm/dts/k3-j721e-binman.dtsi >> b/arch/arm/d

[PATCH] configs: am64x_evm_*_defconfig: Increase offsets for eMMC raw boot

2024-04-10 Thread Judith Mendez
EMMC boot can fail due to the size of R5 SPL image growing beyond the 500KB of memory allocated in eMMC. Update offsets for eMMMC raw boot to load each binary from the correct address in eMMC according to the following eMMC layout: boot0/1 partition 0x0+

Re: [PATCH v2 1/3] mtd: spi-nore-core: Fix 4KB erase opcode for s25fs-s

2024-04-10 Thread Dhruva Gole
On Apr 09, 2024 at 15:20:20 +0900, tkuw584...@gmail.com wrote: > From: Takahiro Kuwano > > The correct 4KB erase opcode should be selected based on the address width > currently used. > > Fixes: 562d166a13 ("mtd: spi-nor-core: Add fixups for s25fs512s") > Signed-off-by: Takahiro Kuwano > --- >

Re: [PATCH v2 2/3] mtd: spi-nor-id: Use INFO6 macro for S25FL-S

2024-04-10 Thread Dhruva Gole
On Apr 09, 2024 at 15:20:21 +0900, tkuw584...@gmail.com wrote: > From: Takahiro Kuwano > > The 6th ID byte is needed to distiguish S25FL-S and S25FS-S families. > > Signed-off-by: Takahiro Kuwano > --- > drivers/mtd/spi/spi-nor-ids.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH v2 4/4] qcom_defconfig: enable pinctrl for new qcm2290/sm6115/sm8250

2024-04-10 Thread Caleb Connolly
Enable the clock and pinctrl drivers for qcm2290, sm6115, and sm8250. Signed-off-by: Caleb Connolly --- configs/qcom_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configs/qcom_defconfig b/configs/qcom_defconfig index a0921ad55519..5e08ea392386 100644 --- a/configs/qcom_defconf

[PATCH v2 3/4] pinctrl: qcom: add sm8250 pinctrl driver

2024-04-10 Thread Caleb Connolly
This SoC features a pinctrl block with north, south, and west tiles accessible to the AP. Signed-off-by: Caleb Connolly --- drivers/pinctrl/qcom/Kconfig | 7 +++ drivers/pinctrl/qcom/Makefile | 1 + drivers/pinctrl/qcom/pinctrl-sm8250.c | 99 +++

[PATCH v2 2/4] pinctrl: qcom: add sm6115 pinctrl driver

2024-04-10 Thread Caleb Connolly
This SoC features a pinctrl block with west, east, and south tiles. Signed-off-by: Caleb Connolly --- drivers/pinctrl/qcom/Kconfig | 7 ++ drivers/pinctrl/qcom/Makefile | 1 + drivers/pinctrl/qcom/pinctrl-sm6115.c | 200 ++ 3 files changed, 20

[PATCH v2 0/4] qcom: pinctrl drivers for qcm2290/sm6115/sm8250

2024-04-10 Thread Caleb Connolly
Introduce pinctrl drivers for three new SoCs and enable them. Signed-off-by: Caleb Connolly --- Changes in v2: - Fix a few formatting issues - Link to v1: https://lore.kernel.org/r/20240408-b4-qcom-rbx-soc-v1-0-900db37b8...@linaro.org --- Caleb Connolly (4): pinctrl: qcom: add qcm2290 pin

[PATCH v2 1/4] pinctrl: qcom: add qcm2290 pinctrl driver

2024-04-10 Thread Caleb Connolly
This SoC has a basic pinctrl block with no tiles. Signed-off-by: Caleb Connolly --- drivers/pinctrl/qcom/Kconfig | 7 drivers/pinctrl/qcom/Makefile | 1 + drivers/pinctrl/qcom/pinctrl-qcm2290.c | 70 ++ 3 files changed, 78 insertions(+)

Re: [PATCH] trace: use dynamic string buffer in make_flamegraph()

2024-04-10 Thread Tom Rini
On Tue, 02 Apr 2024 13:29:16 +0200, Vincent Stehlé wrote: > The str[] buffer declared in make_flamegraph() is used to hold strings > representing the full call-stacks recorded in traces. The size of this > buffer is currently 500 characters and this works well for the documented > examples. > > H

Re: [PATCH 1/1] net: dw_eth_qos: Add missing \n in error messages.

2024-04-10 Thread Tom Rini
On Tue, 02 Apr 2024 10:39:34 +0200, Heinrich Schuchardt wrote: > Missing line-feeds in error messages lead to output like: > > phy_startup() failed: -110FAILED: -110=> > > Output like the following is much easier to read: > > phy_startup() failed: -110 > FAILED: -110 > => > > [

Re: [PATCH] lib: add missing line breaks in debug messages

2024-04-10 Thread Tom Rini
On Sat, 30 Mar 2024 14:11:21 +0300, Maxim Moskalets wrote: > Add missing line breaks to improve debug log readability. > > Applied to u-boot/master, thanks! -- Tom

Re: [PATCH v2 1/1] fs: ext4: all file paths are absolute

2024-04-10 Thread Tom Rini
On Wed, 27 Mar 2024 09:09:27 +0100, Heinrich Schuchardt wrote: > U-Boot only knows absolute file paths. It is inconsistent to require that > saving to an ext4 file system should use a leading '/' while reading does > not. Remove the superfluous check. > > Applied to u-boot/master, thanks! --

Re: [PATCH 1/1] net: nfs: fix file handle length in NFSv3

2024-04-10 Thread Tom Rini
On Tue, 26 Mar 2024 10:34:31 +0100, Sébastien Szymanski wrote: > The NFS protocol uses file handles to refer to file or directory. > In NFSv2 file handles have a fixed size of 32 bytes. > In NFSv3 file handles have a variable length up to 64 bytes. This is > also true for the MOUNT protocol. [1] >

Re: [PATCH 1/1] rtc: goldfish_rtc_probe should be static

2024-04-10 Thread Tom Rini
On Thu, 21 Mar 2024 21:16:13 +0100, Heinrich Schuchardt wrote: > There is no need to export goldfish_rtc_probe(). > > Applied to u-boot/master, thanks! -- Tom

Re: [PATCH v2] tools: open FIT image read-only

2024-04-10 Thread Tom Rini
On Thu, 21 Mar 2024 19:31:54 +0100, Ahelenia Ziemiańska wrote: > Open for reading as O_RDONLY instead of O_RDWR: > the only usage of the fd is for the single read() below; > this prevented > mkimage -f auto -A arm64 \ > -T kernel -C lz4 -d Image-6.6.15.lz4 \ > -b

Re: [PATCH 1/1] fs: ext4: make "File System is consistent\n" a debug message

2024-04-10 Thread Tom Rini
On Wed, 20 Mar 2024 14:23:52 +0100, Heinrich Schuchardt wrote: > When accessing an ext2 system the message "File System is consistent\n" is > shown after each write. This is superfluous noise. Only write a debug > message. > > Applied to u-boot/master, thanks! -- Tom

Re: [PATCH v2] build: Revive and update LDR format support

2024-04-10 Thread Tom Rini
On Tue, 19 Mar 2024 22:16:07 -0400, Greg Malysa wrote: > LDR format files are used primarily by Analog Devices processors but may > be of interest to other vendors. Previously support existed for this > format as part of the U-Boot build, but it has been unmaintained and > unused for a long time.

Re: [PATCH] scripts/Makefile.spl: Use 'sort' in SHRUNK_ARCH_DTB rule

2024-04-10 Thread Tom Rini
On Tue, 19 Mar 2024 12:51:31 -0400, Tom Rini wrote: > With configs such as "am64x_evm_a53" or "imx8mp_venice" which list > multiple device trees to build we get a warning such as: > scripts/Makefile.spl:578: target 'spl/dts/freescale/' given more than once in > the same rule > > If we sort this

Re: [PATCH] fs: ext4: Change the Settings of file permissions

2024-04-10 Thread Tom Rini
On Tue, 19 Mar 2024 17:20:40 +0800, Jixiong Hu wrote: > When a file is created in the linux and corresponding file permission > is set, if the file needs to be modified in uboot during the startup > process, the modified file permission will be reset to 755. Therefore, > when the ext4fs_write() fu

Re: [PATCH] cmd: sysboot: null check filename

2024-04-10 Thread Tom Rini
On Mon, 18 Mar 2024 23:16:36 +, Caleb Connolly wrote: > Currently if ${bootfile} is unset and sysboot is invoked with no > filename specified then U-Boot will crash will a null-pointer > dereference. Add the missing check and a matching error print. > > Applied to u-boot/master, thanks! --

Re: [PATCH] arm64: Fix map_range() not splitting mapped blocks

2024-04-10 Thread Tom Rini
On Mon, 18 Mar 2024 19:35:49 +, Pierre-Clément Tosi wrote: > The implementation of map_range() creates the requested mapping by > walking the page tables, iterating over multiple PTEs and/or descending > into existing table mappings as needed. When doing so, it assumes any > pre-existing valid

Re: [PATCH 1/2] dm: core: add support for fallback drivers

2024-04-10 Thread Heinrich Schuchardt
Am 10. April 2024 19:06:57 MESZ schrieb Caleb Connolly : >Introduce support for a uclass to provide a fallback/stub driver which >can be used when no device is found for a given node. This might be >useful for handling non-essential clock controllers like the RPMh on >Qualcomm platforms, or dur

[PATCH 1/2] dm: core: add support for fallback drivers

2024-04-10 Thread Caleb Connolly
Introduce support for a uclass to provide a fallback/stub driver which can be used when no device is found for a given node. This might be useful for handling non-essential clock controllers like the RPMh on Qualcomm platforms, or during early bringup to get UART output before a real clock driver h

[PATCH 2/2] clk: introduce a fallback stub driver

2024-04-10 Thread Caleb Connolly
Add a stub_clk driver which does absolutely nothing and is configured as the fallback stub for UCLASS_CLK. If there is a dependency on a clock device which is not supported by any existing driver, and CONFIG_CLK_STUB is enabled, then the stub driver will kick in. This is intended to be useful duri

[PATCH 0/2] dm: add support for stubbing optional devices

2024-04-10 Thread Caleb Connolly
rivers/core/Kconfig | 20 drivers/core/uclass.c | 24 +++- include/dm/uclass.h| 3 +++ 6 files changed, 90 insertions(+), 1 deletion(-) --- change-id: 20240410-b4-stub-drivers-1c1565bb06a6 base-commit: 56c4a3aa2ed15b64eabd067a10be2091d28a5f2f // Caleb (they/them)

[PATCH v2 2/2] qcom_defconfig: enable the Qualcomm Synopsys eUSB2 PHY driver

2024-04-10 Thread Neil Armstrong
Enable the Qualcomm Synopsys eUSB2 PHY driver in Qualcomm defconfig. Signed-off-by: Neil Armstrong --- configs/qcom_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/qcom_defconfig b/configs/qcom_defconfig index 1abb57345ff..b0ae5eb4df3 100644 --- a/configs/qcom_defconfig +++

[PATCH v2 1/2] phy: qcom: add Synopsys eUSB2 PHY driver

2024-04-10 Thread Neil Armstrong
Add a driver for the new Synopsys eUSB2 PHY found in the SM8550 and SM8650 SoCs. Signed-off-by: Neil Armstrong --- drivers/phy/qcom/Kconfig | 8 + drivers/phy/qcom/Makefile | 1 + drivers/phy/qcom/phy-qcom-snps-eusb2.c | 366 + 3 fil

[PATCH v2 0/2] phy: qcom: add support for the Qualcomm Synopsys eUSB2 PHY

2024-04-10 Thread Neil Armstrong
Add support for the new Qualcomm Synopsys eUSB2 PHY found in the SM8550 and SM8650 SoCs. Finally enable the driver in the Qualcomm defconfig. Signed-off-by: Neil Armstrong --- Changes in v2: - fixed driver build failure due to missin } - Link to v1: https://lore.kernel.org/r/20240405-topic-sm8x

[PATCH v2 3/3] button: qcom-pmic: add support for pmk8350 button configs

2024-04-10 Thread Neil Armstrong
Finally add the entries for the qcom,pmk8350-pwrkey and qcom,pmk8350-resin found on PMICs used with SM8350 and later SoCs. Signed-off-by: Neil Armstrong --- drivers/button/button-qcom-pmic.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/button/button-qcom-pmic.c b

[PATCH v2 2/3] button: qcom-pmic: move node name checks to btn_data struct

2024-04-10 Thread Neil Armstrong
Move node name checks to a proper data struct with all information for the supported subnodes. Replace the key offset defines with the Linux driver ones. Signed-off-by: Neil Armstrong --- drivers/button/button-qcom-pmic.c | 84 ++- 1 file changed, 56 insertio

[PATCH v2 1/3] gpio: qcom_pmic_gpio: add support for pm8550-gpio

2024-04-10 Thread Neil Armstrong
Add support for PM8550 GPIO controller variant, keep read-only until the GPIO and Pinctrl setup is fixed for new PMICs. Signed-off-by: Neil Armstrong --- drivers/gpio/qcom_pmic_gpio.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/qcom_pmic_g

[PATCH v2 0/3] qcom: support SPMI buttons on SM8550 and SM8650

2024-04-10 Thread Neil Armstrong
First add PMIC gpio variant on pm8550-gpio, then rework the qcom-pmic button driver to support data structs for each PMIC variant and finally add the data for the pmk8350 button configs. Signed-off-by: Neil Armstrong --- Changes in v2: - added missing qcom,pmk8350-pon compatible - Link to v1: ht

  1   2   >