RE: [PATCH 1/1] .mailmap entry for Masahisa Kojima

2024-03-20 Thread kojima.masahisa
Hi Heinrich, > -Original Message- > From: Heinrich Schuchardt > Sent: Monday, March 18, 2024 7:47 PM > To: Tom Rini > Cc: u-boot@lists.denx.de; Heinrich Schuchardt > ; Kojima, Masahisa/小島 雅久 > > Subject: [PATCH 1/1] .mailmap entry for Masahisa Kojima > > The Linaro mail address is not

RE: [PATCH] efi_loader: accept append write with valid size and data

2024-03-20 Thread kojima.masahisa
> -Original Message- > From: Heinrich Schuchardt > Sent: Thursday, March 21, 2024 3:21 PM > To: Kojima, Masahisa/小島 雅久 > Cc: u-boot@lists.denx.de; ilias.apalodi...@linaro.org > Subject: Re: [PATCH] efi_loader: accept append write with valid size and data > > On 3/18/24 03:46, kojima.ma

Re: [PATCH] efi_loader: accept append write with valid size and data

2024-03-20 Thread Heinrich Schuchardt
On 3/18/24 03:46, kojima.masah...@socionext.com wrote: Hi Heinrich, -Original Message- From: Heinrich Schuchardt Sent: Friday, March 15, 2024 4:58 PM To: Kojima, Masahisa/小島 雅久 Cc: u-boot@lists.denx.de; Ilias Apalodimas Subject: Re: [PATCH] efi_loader: accept append write with valid

Re: [PATCH v3 04/11] imx8mp: power-domain: Don't power off pd_bus

2024-03-20 Thread Sumit Garg
On Thu, 21 Mar 2024 at 11:06, Marek Vasut wrote: > > On 3/15/24 11:41 AM, Sumit Garg wrote: > > On Fri, 15 Mar 2024 at 14:53, Marek Vasut wrote: > >> > >> On 3/15/24 6:31 AM, Sumit Garg wrote: > >>> On Thu, 14 Mar 2024 at 09:45, Marek Vasut wrote: > > On 3/12/24 8:03 AM, Sumit Garg wro

Re: [PATCH 1/5] usb: dwc3-generic: implement Qualcomm wrapper

2024-03-20 Thread Marek Vasut
On 3/13/24 7:22 PM, Caleb Connolly wrote: [...] +static inline void dwc3_qcom_setbits(void __iomem *base, u32 offset, u32 val) +{ +    u32 reg; + +    reg = readl(base + offset); +    reg |= val; +    writel(reg, base + offset); Use setbits_le32() . +    /* ensure that above write is throug

Re: [PATCH v3 04/11] imx8mp: power-domain: Don't power off pd_bus

2024-03-20 Thread Marek Vasut
On 3/15/24 11:41 AM, Sumit Garg wrote: On Fri, 15 Mar 2024 at 14:53, Marek Vasut wrote: On 3/15/24 6:31 AM, Sumit Garg wrote: On Thu, 14 Mar 2024 at 09:45, Marek Vasut wrote: On 3/12/24 8:03 AM, Sumit Garg wrote: power_domain_on/off() isn't refcounted and power domain bus shouldn't be tur

Re: [PATCH v3 12/14] dts: sdm845-db845c: add u-boot fixups

2024-03-20 Thread Sumit Garg
On Wed, 20 Mar 2024 at 18:04, Caleb Connolly wrote: > > > > On 20/03/2024 12:33, Caleb Connolly wrote: > > > > > > On 19/03/2024 13:55, Sumit Garg wrote: > >> On Tue, 19 Mar 2024 at 17:52, Caleb Connolly > >> wrote: > >>> > >>> The USB VBUS supply for the type-A port is enabled via a GPIO regula

Re: [PATCH 3/3] cmd: bootefi: error handling bootefi selftest

2024-03-20 Thread Ilias Apalodimas
On Sat, 16 Mar 2024 at 11:37, Heinrich Schuchardt wrote: > > If bootefi selftest is executed and a problem with the device-tree > installation occurs, efi_install_fdt() writes sensible error messages. > It never returns EFI_INVALID_PARAMETER. It neither makes sense to check > for EFI_INVALID_PARAM

Re: [PATCH 1/3] efi_loader: correct handling of EFI binary return code

2024-03-20 Thread Ilias Apalodimas
Hi Heinrich On Sat, 16 Mar 2024 at 11:37, Heinrich Schuchardt wrote: > > Running an EFI binary loaded via tftp using the bootefi command results in > showing the usage help. The commit message sounds a bit off. The real problem is removing protocols from a non existent handle right? The help mes

Re: [PATCH 1/1] fs: ext4: all file paths are absolute

2024-03-20 Thread Michael Nazzareno Trimarchi
On Wed, Mar 20, 2024 at 2:25 PM Heinrich Schuchardt wrote: > > U-Boot only knows absolute file paths. It is inconsistent to require that > saving to an ext4 file system should use a leading '/' wile reading does > not. Remove the superfluous check. > Just a typo, "wile reading" Michael > Report

Re: [PATCH 2/3] cmd: bootefi: Don't show usage help if EFI binary fails.

2024-03-20 Thread Ilias Apalodimas
On Sat, 16 Mar 2024 at 11:37, Heinrich Schuchardt wrote: > > If an EFI binary returns an error code EFI_INVALID_PARAMETER, we show the > usage help for the bootefi command: > > Shell> exit 0x8002 > ## Application failed, r = 2 > bootefi - Boots an EFI payload from memory >

Re: [PATCH v2 2/4] boot: fdt: Clean up env_get_bootm_size()

2024-03-20 Thread Laurent Pinchart
On Wed, Mar 20, 2024 at 09:52:34PM +0100, Marek Vasut wrote: > On 3/18/24 5:18 PM, Laurent Pinchart wrote: > > >> @@ -142,7 +140,7 @@ phys_size_t env_get_bootm_size(void) > >> > >>s = env_get("bootm_low"); > >>if (s) > >> - tmp = (phys_size_t)simple_strtoull(s, NULL, 16); > >>

Re: [PATCH 1/2] usb: udc: dwc3: Fold board dm_usb_gadget_handle_interrupts() into DWC3 gadget

2024-03-20 Thread Marek Vasut
On 3/18/24 1:47 PM, Caleb Connolly wrote: On 17/03/2024 04:42, Marek Vasut wrote: The dm_usb_gadget_handle_interrupts() has no place in board code. Move this into DWC3 driver. The OMAP implementation is special, add new weak dwc3_uboot_interrupt_status() function to decide whether DWC3 interru

[PATCH v3 5/5] boot: fdt: Move usable variable below updated comment

2024-03-20 Thread Marek Vasut
Move the variable below comment which explains what the variable means. Update the comment. No functional change. Reviewed-by: Laurent Pinchart Suggested-by: Laurent Pinchart Signed-off-by: Marek Vasut --- Cc: Heinrich Schuchardt Cc: Kuninori Morimoto Cc: Laurent Pinchart Cc: Simon Glass Cc

[PATCH v3 4/5] boot: fdt: Drop lmb_alloc*() typecasts

2024-03-20 Thread Marek Vasut
The lmb_alloc_base() returns phys_addr_t , map_sysmem() accepts phys_addr_t as first parameter. Declare 'addr' as phys_addr_t and get rid of the casts. Reviewed-by: Laurent Pinchart Reported-by: Laurent Pinchart Signed-off-by: Marek Vasut --- Cc: Heinrich Schuchardt Cc: Kuninori Morimoto Cc:

[PATCH v3 3/5] boot: fdt: Clean up env_get_bootm_mapsize()

2024-03-20 Thread Marek Vasut
Reduce tmp variable use and remove unnecessary type cast in env_get_bootm_mapsize(). This aligns the env variable parsing with env_get_bootm_low(). No functional change. Signed-off-by: Marek Vasut --- Cc: Heinrich Schuchardt Cc: Kuninori Morimoto Cc: Laurent Pinchart Cc: Simon Glass Cc: Tom R

[PATCH v3 2/5] boot: fdt: Clean up env_get_bootm_size()

2024-03-20 Thread Marek Vasut
Reduce tmp variable use and remove unnecessary type cast in env_get_bootm_size(). This aligns the env variable parsing with env_get_bootm_low(). No functional change. Signed-off-by: Marek Vasut --- Cc: Heinrich Schuchardt Cc: Kuninori Morimoto Cc: Laurent Pinchart Cc: Simon Glass Cc: Tom Rini

[PATCH v3 1/5] boot: fdt: Change type of env_get_bootm_low() to phys_addr_t

2024-03-20 Thread Marek Vasut
Change type of ulong env_get_bootm_low() to phys_addr_t env_get_bootm_low(). The PPC/LS systems already treat env_get_bootm_low() result as phys_addr_t, while the function itself still returns ulong. This is potentially dangerous on 64bit systems, where ulong might not be large enough to hold the c

Re: [PATCH v2 2/4] boot: fdt: Clean up env_get_bootm_size()

2024-03-20 Thread Marek Vasut
On 3/18/24 5:18 PM, Laurent Pinchart wrote: @@ -142,7 +140,7 @@ phys_size_t env_get_bootm_size(void) s = env_get("bootm_low"); if (s) - tmp = (phys_size_t)simple_strtoull(s, NULL, 16); + tmp = simple_strtoull(s, NULL, 16); else t

Re: [PATCH v4 0/5] Qualcomm DWC3 USB support

2024-03-20 Thread Caleb Connolly
On 20/03/2024 20:01, Marek Vasut wrote: > On 3/20/24 3:30 PM, Caleb Connolly wrote: >> This series enables support for Qualcomm platforms in the DWC3 driver, >> adds support for arbitrary sector sizes to the USB mass storage gadget, >> and fixes an issue with the CDC ACM driver where it wouldn't

Re: [PATCH v4 0/5] Qualcomm DWC3 USB support

2024-03-20 Thread Marek Vasut
On 3/20/24 3:30 PM, Caleb Connolly wrote: This series enables support for Qualcomm platforms in the DWC3 driver, adds support for arbitrary sector sizes to the USB mass storage gadget, and fixes an issue with the CDC ACM driver where it wouldn't initialise the USB device. Additionally, it fixes

Re: [PATCH v3] cmd: mtd: OTP access support

2024-03-20 Thread Arseniy Krasnov
Hello On 20.03.2024 21:01, Michael Nazzareno Trimarchi wrote: > Hi > > On Wed, Mar 13, 2024 at 8:27 AM Arseniy Krasnov > wrote: >> >> Add access to OTP region. It supports info, dump, write and lock >> operations. Usage example: >> >> 'mtd otpread nand0 u 0 1024' - dump 1024 bytes of user area s

[PATCH v4] cmd: mtd: OTP access support

2024-03-20 Thread Arseniy Krasnov
Add access to OTP region. It supports info, dump, write and lock operations. Usage example: 'mtd otpread nand0 u 0 1024' - dump 1024 bytes of user area starting from offset 0 of device 'nand0'. 'mtd otpwrite nand0 10 11223344' - write binary data 0x11, 0x22, 0x33, 0x44 to offset 10 to user area

Re: [PATCH v3] cmd: mtd: OTP access support

2024-03-20 Thread Michael Nazzareno Trimarchi
Hi On Wed, Mar 13, 2024 at 8:27 AM Arseniy Krasnov wrote: > > Add access to OTP region. It supports info, dump, write and lock > operations. Usage example: > > 'mtd otpread nand0 u 0 1024' - dump 1024 bytes of user area starting > from offset 0 of device 'nand0'. > > 'mtd otpwrite nand0 10 11223

Re: [PATCH 1/1] fs: ext4: all file paths are absolute

2024-03-20 Thread Patrice CHOTARD
On 3/20/24 14:25, Heinrich Schuchardt wrote: > U-Boot only knows absolute file paths. It is inconsistent to require that > saving to an ext4 file system should use a leading '/' wile reading does > not. Remove the superfluous check. > > Reported-by: Patrice Chotard > Signed-off-by: Heinrich Sc

[PATCH v1] board: toradex: verdin-am62_r5: Increase SPL_STACK_R_MALLOC_SIMPLE_LEN

2024-03-20 Thread Hiago De Franco
From: Hiago De Franco Increase the SPL_STACK_R_MALLOC_SIMPLE_LEN to 0x20 to accommodate the size of tispl.bin fit image. With the recent upgrade of ti-linux-firmware from version v9.1.0 to v9.2.5, the size of tispl.bin fit image has increased to 1.4MB, causing allocation errors in the R5 SPL:

Re: [PATCH] efi_loader: Add absolute path to EFI_VAR_FILE_NAME

2024-03-20 Thread Patrice CHOTARD
On 3/20/24 14:05, Heinrich Schuchardt wrote: > On 20.03.24 12:53, Ilias Apalodimas wrote: >> Hi Patrice, >> >> On Wed, 20 Mar 2024 at 12:31, Patrice Chotard >> wrote: >>> >>> If the ESP partition is formatted in ext4, we got the following error : >>> >>> STM32MP>  setenv -e -nv -bs -rt -v OsInd

Re: [PATCH] efi_loader: Add absolute path to EFI_VAR_FILE_NAME

2024-03-20 Thread Patrice CHOTARD
On 3/20/24 12:53, Ilias Apalodimas wrote: > Hi Patrice, > > On Wed, 20 Mar 2024 at 12:31, Patrice Chotard > wrote: >> >> If the ESP partition is formatted in ext4, we got the following error : >> >> STM32MP> setenv -e -nv -bs -rt -v OsIndications =0x0004 >> GUID: 8be4df61-93ca-11d

Re: [PATCH] tools: copyfile: use 64k instead of 512 buffer

2024-03-20 Thread Dragan Simic
Hello Ahelenia, Please see my comments below. On 2024-03-20 14:08, Ahelenia Ziemiańska wrote: This is an incredible pessimisation: s/pessimisation/optimization/ mkimage took >200ms (and 49489 writes (of which 49456 512)), now it takes 110ms (and 419 writes (of which 386 64k)). sendfil

Re: [PATCH] tools: open FIT image for reading as O_RDONLY instead of O_RDWR

2024-03-20 Thread Dragan Simic
Hello Ahelenia, Please see my comments below. On 2024-03-20 14:08, Ahelenia Ziemiańska wrote: The only usage of the fd is for the single read() below; this prevented mkimage -f auto -A arm64 \ -T kernel -C lz4 -d Image-6.6.15.lz4 \ -b mt8173-elm-hana-6.6.

Re: [PATCH 1/2] spl: Introduce architecture specific init function

2024-03-20 Thread Andre Przywara
On Wed, 20 Mar 2024 11:33:16 -0400 Tom Rini wrote: Hi, > On Wed, Mar 20, 2024 at 08:52:30PM +0530, Devarsh Thakkar wrote: > > Hi Tom, Lukas, > > > > Thanks for the patch Lukas. > > > > On 20/03/24 20:00, Tom Rini wrote: > > > On Wed, Mar 20, 2024 at 02:19:26PM +0100, lukas.funke-...@weidmuel

Re: [PATCH 1/2] spl: Introduce architecture specific init function

2024-03-20 Thread Tom Rini
On Wed, Mar 20, 2024 at 08:52:30PM +0530, Devarsh Thakkar wrote: > Hi Tom, Lukas, > > Thanks for the patch Lukas. > > On 20/03/24 20:00, Tom Rini wrote: > > On Wed, Mar 20, 2024 at 02:19:26PM +0100, lukas.funke-...@weidmueller.com > > wrote: > > > >> From: Lukas Funke > >> > >> Some architectu

Re: [PATCH 1/2] spl: Introduce architecture specific init function

2024-03-20 Thread Devarsh Thakkar
Hi Tom, Lukas, Thanks for the patch Lukas. On 20/03/24 20:00, Tom Rini wrote: > On Wed, Mar 20, 2024 at 02:19:26PM +0100, lukas.funke-...@weidmueller.com > wrote: > >> From: Lukas Funke >> >> Some architectures use spl_board_init() in their architecture specific >> implementation. Board develo

[PATCH v4 14/14] qcom_defconfig: enable USB

2024-03-20 Thread Caleb Connolly
Enable support for the DWC3 USB controller and required dependencies for Qualcomm boards, specifically the DB845c: * IOMMU / SMMU * USB high-speed PHYs * Mass storage and ACM gadgets Signed-off-by: Caleb Connolly --- configs/qcom_defconfig | 52 --

[PATCH v4 13/14] qcom_defconfig: enable livetree

2024-03-20 Thread Caleb Connolly
Qualcomm FDTs are on the larger size, and with the addition of DT modifications during board_init() it makes sense to enable OF_LIVE globally. The cost of building the tree should be offset by the increased efficiency at which we can walk it. Some rough measurements with CONFIG_BOOTSTAGE suggests

[PATCH v4 12/14] dts: sdm845-db845c: add u-boot fixups

2024-03-20 Thread Caleb Connolly
The USB VBUS supply for the type-A port is enabled via a GPIO regulator. This is incorrectly modelled in Linux where only the PCIe dependency is expressed. Add a U-Boot specific dtsi snippet so that this supply will get enabled when initialising USB. Signed-off-by: Caleb Connolly --- arch/arm/dt

[PATCH v4 11/14] mach-snapdragon: fixup power-domains

2024-03-20 Thread Caleb Connolly
We don't support the RPM(h)PD power domains in U-Boot, and we don't need to - the necessary resources are on, and we aren't going to enter any low power modes. We could try using a no-op device, but this requires adding a compatible for every platform, and just pollutes the driver model. So instea

[PATCH v4 10/14] mach-snapdragon: fixup USB nodes

2024-03-20 Thread Caleb Connolly
We don't support USB super-speed in U-Boot yet, we lack the SS PHY drivers, however from my testing even with a PHY driver there seem to be other issues when talking to super-speed peripherals. In pursuit of maintaining upstream DT compatibility, and simplifying porting for new devices, let's impl

[PATCH v4 09/14] serial: msm-geni: support livetree

2024-03-20 Thread Caleb Connolly
When using OF_LIVE, the debug UART driver won't be probed if it's a subnode of the geni-se-qup controller. Add a NOP driver for the controller to correctly discover its child nodes. Reviewed-by: Neil Armstrong Reviewed-by: Sumit Garg Signed-off-by: Caleb Connolly --- drivers/serial/serial_msm_

[PATCH v4 08/14] gpio: msm_gpio: add .set_flags op

2024-03-20 Thread Caleb Connolly
The .direction_input and .direction_output ops are deprecated, and don't seem to behave properly for us. Implement our own .set_flags op to handle this correctly. Reviewed-by: Sumit Garg Signed-off-by: Caleb Connolly --- drivers/gpio/msm_gpio.c | 27 +-- 1 file changed,

[PATCH v4 07/14] clk/qcom: sdm845: add USB clocks

2024-03-20 Thread Caleb Connolly
Most devices only initialise the USB clocks for us if we boot via "fastboot boot", add the missing clock configuration to get both USB ports working regardless of the bootloader state. Reviewed-by: Sumit Garg Signed-off-by: Caleb Connolly --- drivers/clk/qcom/clock-sdm845.c | 25 +++

[PATCH v4 06/14] clk/qcom: sdm845: add gdscs

2024-03-20 Thread Caleb Connolly
Define the GDSC power domains for SDM845. Reviewed-by: Neil Armstrong Reviewed-by: Sumit Garg Signed-off-by: Caleb Connolly --- drivers/clk/qcom/clock-sdm845.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/clk/qcom/clock-sdm845.c b/drivers/clk/qcom/clock-sdm84

[PATCH v4 05/14] clk/qcom: use offsets for RCG registers

2024-03-20 Thread Caleb Connolly
The RCG registers always have the same offsets, so only store the base CMD register address and calculate the others relative to that. Reviewed-by: Sumit Garg Signed-off-by: Caleb Connolly --- drivers/clk/qcom/clock-apq8016.c | 39 + drivers/clk/qcom/clock-apq8096.c | 28 +

[PATCH v4 04/14] mach-snapdragon: disable power-domains for pre-reloc drivers

2024-03-20 Thread Caleb Connolly
Some devices like the UART and clock controller reference an RPM(h) power domain. We don't support this device in U-Boot, so add DM_FLAG_DEFAULT_PD_CTRL_OFF to tell DM core not to try and enable the power domain. Reviewed-by: Sumit Garg Signed-off-by: Caleb Connolly --- drivers/clk/qcom/clock-q

[PATCH v4 02/14] phy: qcom: add Qualcomm QUSB2 USB PHY driver

2024-03-20 Thread Caleb Connolly
From: Bhupesh Sharma The Snapdragon 845 and several other Qualcomm SoCs feature this USB high-speed phy. Add a driver for it based on the Linux driver, with support for the SDM845, and the QCM2290 and SM6115 SoCs which will gain support in U-Boot in future patches. Signed-off-by: Bhupesh Sharma

[PATCH v4 03/14] phy: qcom: Add SNPS femto v2 USB HS phy

2024-03-20 Thread Caleb Connolly
From: Bhupesh Sharma Some Qualcomm SoCs newer than SDM845 feature a so-called "7nm phy" driver, notable the SM8250 SoC which will gain U-Boot support in upcoming patches. Introduce a driver based on the Linux driver. Signed-off-by: Bhupesh Sharma [code cleanup, align symbol names with Linux, s

[PATCH v4 01/14] mailmap: update Bhupesh's email address

2024-03-20 Thread Caleb Connolly
Update Bhupesh's email to his new one. Reviewed-by: Neil Armstrong Signed-off-by: Caleb Connolly --- Cc: Bhupesh Sharma --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index d1f08f3eca8a..f6e0847b2168 100644 --- a/.mailmap +++ b/.mailmap @@ -29,8 +29,9 @@

[PATCH v4 00/14] Qualcomm platform USB support

2024-03-20 Thread Caleb Connolly
wer domain support [2]. A feature branch based on qcom-next with the necessary dependencies for testing the Dragonboard845c can be found at [3]. [1]: https://lore.kernel.org/u-boot/20240320-b4-qcom-usb-v4-0-41be48017...@linaro.org [2]: https://lore.kernel.org/u-boot/20240311213334.3567389-1-volo

Re: [PATCH 1/2] clk: clk-imx8qxp: Add LPUART IPG entries

2024-03-20 Thread Tom Rini
On Wed, Mar 20, 2024 at 10:41:51AM -0400, Sean Anderson wrote: > On 3/19/24 15:04, Tom Rini wrote: > > On Mon, Mar 18, 2024 at 09:14:53PM -0300, Fabio Estevam wrote: > > > Hi Tom and Sean, > > > > > > On Fri, Mar 8, 2024 at 5:13 PM Fabio Estevam wrote: > > > > > > > > Since commit cc7df0b9e8bc (

Re: [PATCH 1/2] clk: clk-imx8qxp: Add LPUART IPG entries

2024-03-20 Thread Sean Anderson
On 3/19/24 15:04, Tom Rini wrote: On Mon, Mar 18, 2024 at 09:14:53PM -0300, Fabio Estevam wrote: Hi Tom and Sean, On Fri, Mar 8, 2024 at 5:13 PM Fabio Estevam wrote: Since commit cc7df0b9e8bc ("serial: lpuart: Enable IPG clock") the colibri-imx8qxp board no longer boots. The reason is that

Re: [PATCH] clk: Propagate clk_set_rate() if CLK_SET_PARENT_RATE present

2024-03-20 Thread Sean Anderson
On 3/20/24 10:02, Yang Xiwen wrote: On 3/20/2024 2:42 AM, Sam Protsenko wrote: On Thu, Mar 7, 2024 at 6:04 PM Sam Protsenko wrote: Sometimes clocks provided to a consumer might not have .set_rate operation (like gate or mux clocks), but have CLK_SET_PARENT_RATE flag set. In that case it's usua

[PATCH v4 5/5] iommu: qcom-smmu: fix debugging

2024-03-20 Thread Caleb Connolly
The priv struct was wrong in dump_boot_mappings(). Causing errors when compiling with -DDEBUG. Fix this. Reviewed-by: Mattijs Korpershoek Reviewed-by: Neil Armstrong Signed-off-by: Caleb Connolly --- drivers/iommu/qcom-hyp-smmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[PATCH v4 4/5] usb: gadget: UMS: support multiple sector sizes

2024-03-20 Thread Caleb Connolly
UFS storage often uses a 4096-byte sector size, add support for dynamic sector sizes based loosely on the Linux implementation. Reviewed-by: Mattijs Korpershoek Reviewed-by: Neil Armstrong Signed-off-by: Caleb Connolly --- cmd/usb_mass_storage.c | 4 -- drivers/usb/gadget/f_mass

[PATCH v4 3/5] usb: gadget: CDC ACM: call usb_gadget_initialize

2024-03-20 Thread Caleb Connolly
To actually use the gadget the peripheral driver must be probed and we must call g_dnl_clear_detach(). Otherwise acm_stdio_start() will always fail to find a UDC on DT platforms. Reviewed-by: Mattijs Korpershoek Reviewed-by: Neil Armstrong Signed-off-by: Caleb Connolly --- drivers/usb/gadget/f

[PATCH v4 2/5] usb: dwc3: select DM_USB_GADGET

2024-03-20 Thread Caleb Connolly
DWC3 platforms depend on DM_USB_GADGET for gadget drivers to work, otherwise compilation fails due to no implementation of dm_usb_gadget_handle_interrupts(). Reviewed-by: Mattijs Korpershoek Reviewed-by: Neil Armstrong Signed-off-by: Caleb Connolly --- drivers/usb/dwc3/Kconfig | 1 + 1 file ch

[PATCH v4 1/5] usb: dwc3-generic: implement Qualcomm wrapper

2024-03-20 Thread Caleb Connolly
The Qualcomm specific dwc3 wrapper isn't hugely complicated, implemented the missing initialisation for host and gadget mode. Reviewed-by: Mattijs Korpershoek Reviewed-by: Marek Vasut Reviewed-by: Neil Armstrong Signed-off-by: Caleb Connolly --- drivers/usb/dwc3/dwc3-generic.c | 81 ++

[PATCH v4 0/5] Qualcomm DWC3 USB support

2024-03-20 Thread Caleb Connolly
This series enables support for Qualcomm platforms in the DWC3 driver, adds support for arbitrary sector sizes to the USB mass storage gadget, and fixes an issue with the CDC ACM driver where it wouldn't initialise the USB device. Additionally, it fixes a syntax bug in the Qualcomm SMMU driver, an

Re: [PATCH 1/2] spl: Introduce architecture specific init function

2024-03-20 Thread Tom Rini
On Wed, Mar 20, 2024 at 02:19:26PM +0100, lukas.funke-...@weidmueller.com wrote: > From: Lukas Funke > > Some architectures use spl_board_init() in their architecture specific > implementation. Board developers should be able to add board specific > implementation via spl_board_init(). Hence, in

RE: [PATCH v2 6/6] cmd: nand: Add new optional sub-command 'onfi'

2024-03-20 Thread Mihai.Sain
Hi Alex, Override the ONFI timing mode at runtime. Signed-off-by: Alexander Dahl --- I used the same board sam9x75-curiosity to test mode 5 😊 I forced in nfc driver the mode 5: + if (conf->timings.sdr.tRC_min < 2) And I ran t

Re: [PATCH] clk: Propagate clk_set_rate() if CLK_SET_PARENT_RATE present

2024-03-20 Thread Yang Xiwen
On 3/20/2024 2:42 AM, Sam Protsenko wrote: On Thu, Mar 7, 2024 at 6:04 PM Sam Protsenko wrote: Sometimes clocks provided to a consumer might not have .set_rate operation (like gate or mux clocks), but have CLK_SET_PARENT_RATE flag set. In that case it's usually possible to find a parent up the

Re: [PATCH v3 02/14] phy: qcom: add Qualcomm QUSB2 USB PHY driver

2024-03-20 Thread Caleb Connolly
Hi Sumit, >> +static inline void qusb2_write_mask(void __iomem *base, u32 offset, u32 val, >> + u32 mask) >> +{ >> + u32 reg; >> + >> + reg = readl(base + offset); >> + reg &= ~mask; >> + reg |= val & mask; >> + writel(reg, base + off

Re: [PATCH 1/1] fs: ext4: all file paths are absolute

2024-03-20 Thread Ilias Apalodimas
On Wed, 20 Mar 2024 at 15:25, Heinrich Schuchardt wrote: > > U-Boot only knows absolute file paths. It is inconsistent to require that > saving to an ext4 file system should use a leading '/' wile reading does > not. Remove the superfluous check. > > Reported-by: Patrice Chotard > Signed-off-by:

[PATCH 1/1] fs: ext4: all file paths are absolute

2024-03-20 Thread Heinrich Schuchardt
U-Boot only knows absolute file paths. It is inconsistent to require that saving to an ext4 file system should use a leading '/' wile reading does not. Remove the superfluous check. Reported-by: Patrice Chotard Signed-off-by: Heinrich Schuchardt --- fs/ext4/ext4_common.c | 5 - 1 file chang

[PATCH 1/1] fs: ext4: make "File System is consistent\n" a debug message

2024-03-20 Thread Heinrich Schuchardt
When accessing an ext2 system the message "File System is consistent\n" is shown after each write. This is superfluous noise. Only write a debug message. Signed-off-by: Heinrich Schuchardt --- fs/ext4/ext4_journal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/ext4

[PATCH 1/2] spl: Introduce architecture specific init function

2024-03-20 Thread lukas . funke-oss
From: Lukas Funke Some architectures use spl_board_init() in their architecture specific implementation. Board developers should be able to add board specific implementation via spl_board_init(). Hence, introduce a spl_arch_init() method which is called right before spl_board_init() for architect

[PATCH 2/2] arm64: zynq(mp): Rename spl_board_init() to spl_arch_init()

2024-03-20 Thread lukas . funke-oss
From: Lukas Funke Rename spl_board_init() to spl_arch_init(). Architecture specific implementation should be separated from board specific implementation in order to be extended by board developers. Signed-off-by: Lukas Funke --- arch/arm/Kconfig | 4 ++-- arch/arm/mach-zynq/spl.c

[PATCH 0/2] Introduce spl_arch_init() for architecture specific initialization

2024-03-20 Thread lukas . funke-oss
From: Lukas Funke Currently some architectures use spl_board_init() for their architecture specific initialization. This prohibits board developers from adding board init code using said function. This series introduces a new function in order to separate arch init code from board init code.

Re: [PATCH v2 8/8] board: add support for Qualcomm SA8155P-ADP board

2024-03-20 Thread Caleb Connolly
On 19/03/2024 21:18, Volodymyr Babchuk wrote: > > Hi, > > Volodymyr Babchuk writes: > >> Caleb Connolly writes: >> >>> On 11/03/2024 18:23, Volodymyr Babchuk wrote: Hi Caleb, Caleb Connolly writes: > On 06/03/2024 21:24, Volodymyr Babchuk wrote: >> >> Hi Caleb, >

Re: [PATCH v3 14/14] qcom_defconfig: enable USB

2024-03-20 Thread Caleb Connolly
On 20/03/2024 05:40, Sumit Garg wrote: > On Tue, 19 Mar 2024 at 17:52, Caleb Connolly > wrote: >> >> Enable support for the DWC3 USB controller and required dependencies for >> Qualcomm boards, specifically the DB845c: >> * IOMMU / SMMU >> * USB high-speed PHYs >> * Mass storage and ACM gadget

[PATCH] tools: copyfile: use 64k instead of 512 buffer

2024-03-20 Thread Ahelenia Ziemiańska
This is an incredible pessimisation: mkimage took >200ms (and 49489 writes (of which 49456 512)), now it takes 110ms (and 419 writes (of which 386 64k)). sendfile is much more appropriate for this and is done in one syscall, but doesn't bring any significant speedups over 64k r/w at the 13M s

[PATCH] tools: open FIT image for reading as O_RDONLY instead of O_RDWR

2024-03-20 Thread Ahelenia Ziemiańska
The only usage of the fd is for the single read() below; this prevented mkimage -f auto -A arm64 \ -T kernel -C lz4 -d Image-6.6.15.lz4 \ -b mt8173-elm-hana-6.6.15.dtb outf when the inputs were unwriteable. Link: https://bugs.debian.org/1063097 Signed-off-by

Re: [PATCH] efi_loader: Add absolute path to EFI_VAR_FILE_NAME

2024-03-20 Thread Heinrich Schuchardt
On 20.03.24 12:53, Ilias Apalodimas wrote: Hi Patrice, On Wed, 20 Mar 2024 at 12:31, Patrice Chotard wrote: If the ESP partition is formatted in ext4, we got the following error : STM32MP> setenv -e -nv -bs -rt -v OsIndications =0x0004 GUID: 8be4df61-93ca-11d2-aa0d-00e098032b8c

RE: [PATCH v2 6/6] cmd: nand: Add new optional sub-command 'onfi'

2024-03-20 Thread Mihai.Sain
Hi Alex, -- Override the ONFI timing mode at runtime. Signed-off-by: Alexander Dahl --- Tested-by: Mihai Sain I tested your new command on a new board/soc sam9x75-curiosity 😊 I find it very very useful ! I also rounded the master clock to 270 MHz 😊 Tha

Re: [PATCH] board: amlogic: fix buffler overflow in serial & usid read

2024-03-20 Thread Tom Rini
On Wed, Mar 20, 2024 at 09:26:29AM +0100, Neil Armstrong wrote: > On 20/03/2024 06:28, Dan Carpenter wrote: > > On Tue, Mar 19, 2024 at 03:53:24PM +0100, Neil Armstrong wrote: > > > While meson_sm_read_efuse() doesn't overflow, the string is not > > > zero terminated and env_set() will buffer overf

Re: [PATCH] arm: mach-k3: Fix config check for FS_LOADER

2024-03-20 Thread Tom Rini
On Thu, Mar 14, 2024 at 08:03:10PM +0530, MD Danish Anwar wrote: > load_firmware() API calls fs-loader APIs and checks for CONFIG_FS_LOADER > before calling those APIs. The if check only checks for CONFIG_FS_LOADER > but not for CONFIG_SPL_FS_LOADER. > > When CONFIG_FS_LOADER is enabled, load_fir

Re: [PATCH v4] test/py: reset: Add a test for reset command

2024-03-20 Thread Tom Rini
On Tue, Mar 12, 2024 at 02:18:33PM +0530, Love Kumar wrote: > Add a test for reset commands which performs resetting of CPU, It does > COLD reset by default and WARM reset with -w option. > > Signed-off-by: Love Kumar Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP sig

Re: [PATCH v4] test/py: saveenv: Add a test for saveenv command

2024-03-20 Thread Tom Rini
On Tue, Mar 12, 2024 at 02:16:10PM +0530, Love Kumar wrote: > Add test case for saveenv command in non-JTAG bootmode which saves the > u-boot environment variables in persistent storage. > > Signed-off-by: Love Kumar Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP sign

Re: [PATCH v4] Makefile: use shell to calculate map_size

2024-03-20 Thread Tom Rini
On Sun, Mar 10, 2024 at 10:53:52PM +0100, Leon M. Busch-George wrote: > From: "Leon M. Busch-George" > > The error message "bc: command not found" is easily missed since the > build continues. > bc is not a part of coreutils or base-devel. POSIX sh can also do the > calculation. > > Signed-off-

Re: [PATCH] arm: Check FEAT_CCIDX when parsing ccsidr_el1 register

2024-03-20 Thread Tom Rini
On Sun, Mar 10, 2024 at 11:29:58AM +0100, Lukasz Wiecaszek wrote: > Current Cache Size ID Register (ccsidr_el1) has two "flavors" > depending on whether FEAT_CCIDX is implemented or not. > When FEAT_CCIDX is implemented Associativity parameter > is coded on bits [23:3] and NumSets parameter on bit

Re: [PATCH] arm64: gic: Add power up sequence for GIC-600

2024-03-20 Thread Tom Rini
On Wed, Mar 06, 2024 at 04:54:41PM +0530, Venkatesh Yadav Abbarapu wrote: > Arm's GIC-600 features a Power Register (GICR_PWRR), > which needs to be programmed to enable redistributor > operation. Power on the redistributor and wait until > the power on state is reflected by checking the bit > GI

Re: [PATCH 1/4] configs: j7200_evm_*_defconfig: Enable OSPI configs

2024-03-20 Thread Tom Rini
On Wed, Mar 06, 2024 at 12:07:46PM +0530, Aniket Limaye wrote: > Add the necessary configs required for OSPI functionality. > Also update the ospi flash partition offsets as per the devicetree. > > Signed-off-by: Aniket Limaye > Reviewed-by: Udit Kumar For the series, applied to u-boot/next, t

Re: [PATCH v6] remoteproc: uclass: Add methods to load firmware to rproc and boot rproc

2024-03-20 Thread Tom Rini
On Wed, Mar 20, 2024 at 11:19:01AM +0530, MD Danish Anwar wrote: > Hi Tom, > > On 20/03/24 4:10 am, Tom Rini wrote: > > On Wed, Feb 28, 2024 at 05:36:45PM +0530, MD Danish Anwar wrote: > > > >> Add APIs to set a firmware_name to a rproc and boot the rproc with the > >> same firmware. > >> > >> Cl

Re: [PATCH v3 12/14] dts: sdm845-db845c: add u-boot fixups

2024-03-20 Thread Caleb Connolly
On 20/03/2024 12:33, Caleb Connolly wrote: > > > On 19/03/2024 13:55, Sumit Garg wrote: >> On Tue, 19 Mar 2024 at 17:52, Caleb Connolly >> wrote: >>> >>> The USB VBUS supply for the type-A port is enabled via a GPIO regulator. >>> This is incorrectly modelled in Linux where only the PCIe dep

Re: [PATCH v3 12/14] dts: sdm845-db845c: add u-boot fixups

2024-03-20 Thread Caleb Connolly
On 19/03/2024 13:55, Sumit Garg wrote: > On Tue, 19 Mar 2024 at 17:52, Caleb Connolly > wrote: >> >> The USB VBUS supply for the type-A port is enabled via a GPIO regulator. >> This is incorrectly modelled in Linux where only the PCIe dependency is >> expressed. > > Can we send a fix for the

Re: [PATCH v2 5/6] mtd: nand: raw: atmel: Fix comment in timings preparation

2024-03-20 Thread Michael Nazzareno Trimarchi
On Wed, Mar 20, 2024 at 10:02 AM Alexander Dahl wrote: > > Introduced with commit 6a8dfd57220d ("nand: atmel: Add DM based NAND > driver") when driver was initially ported from Linux. The context > around this and especially the code itself suggests 'read' is meant > instead of write. > > The fix

Re: [PATCH v2] rpi: Copy eth MAC address from fw DT to loaded DT

2024-03-20 Thread Peter Robinson
Hi Martin, > I reworked the commit message because I noticed the upstream Linux kernel has > a > difference with the Raspberry Pi fork of the kernel regarding the algorithm > used to determine the MAC address of the smsc95xx. So looking at this on an original 3B because that's what I had booted

[PATCH 1/2] arm: mach-k3: am62: Get a53 max cpu frequency by speed grade

2024-03-20 Thread Joao Paulo Goncalves
From: Joao Paulo Goncalves AM62 SoC has multiple speed grades. Add function to return max A53 CPU frequency based on grade. Fastest grade's max frequency also depends on PMIC voltage, to simplify implementation use the smaller value. Suggested-by: Vignesh Raghavendra Signed-off-by: Joao Paulo G

[PATCH 2/2] arm: mach-k3: am625: Fixup a53 cpu frequency by speed grade

2024-03-20 Thread Joao Paulo Goncalves
From: Joao Paulo Goncalves The maximum frequency of the A53 CPU on the AM62 depends on the speed grade of the SoC. However, this value is hardcoded in the DT for all AM62 variants, potentially causing specifications to be exceeded. Moreover, setting a common lower frequency for all variants incre

[PATCH 0/2] arm: mach-k3: am62: change a53 clock frequency by speed grade

2024-03-20 Thread Joao Paulo Goncalves
From: Joao Paulo Goncalves This series introduces a method to dynamically set the AM62 A53 CPU frequency based on its speed grade. It adds a new function to retrieve the A53 frequency value by reading the speed grade from the hardware. Subsequently, it adjusts the Cortex R5 device tree at runtime

Re: [PATCH] efi_loader: Add absolute path to EFI_VAR_FILE_NAME

2024-03-20 Thread Ilias Apalodimas
Hi Patrice, On Wed, 20 Mar 2024 at 12:31, Patrice Chotard wrote: > > If the ESP partition is formatted in ext4, we got the following error : > > STM32MP> setenv -e -nv -bs -rt -v OsIndications =0x0004 > GUID: 8be4df61-93ca-11d2-aa0d-00e098032b8c (EFI_GLOBAL_VARIABLE_GUID) > Attribute

[PATCH] arm64: zynqmp: Add bootcmd_usb4 variable

2024-03-20 Thread Michal Simek
From: Shubhangi Shrikrushna Mahalle Add "bootcmd_usb4" variable to boot through usb4 device. Signed-off-by: Shubhangi Shrikrushna Mahalle Signed-off-by: Michal Simek --- It should be the part of https://lore.kernel.org/r/20240305110256.153308-1-venkatesh.abbar...@amd.com --- board/xilinx/zy

[PATCH] arm64: zynqmp: Also support JTAG as alternative boot mode

2024-03-20 Thread Michal Simek
if (reg >> BOOT_MODE_ALT_SHIFT) condition rules out alternative jtag boot mode which is 0. When 0 was used origin(HW) boot mode was used instead. That's why directly fill reg variable with requested boot mode and don't let code to read value back. "else" part of code remain unchanged. Signed-off-b

[PATCH] efi_loader: Add absolute path to EFI_VAR_FILE_NAME

2024-03-20 Thread Patrice Chotard
If the ESP partition is formatted in ext4, we got the following error : STM32MP> setenv -e -nv -bs -rt -v OsIndications =0x0004 GUID: 8be4df61-93ca-11d2-aa0d-00e098032b8c (EFI_GLOBAL_VARIABLE_GUID) Attributes: 0x7 Value: : 04 00 00 00 00 00 00 00 .

Re: [PATCH v2] board: amlogic: fix buffler overflow in seria, mac & usid read

2024-03-20 Thread Viacheslav
Hi! Good catch. for jethub devices: Acked-by: Viacheslav Bocharov 20/03/2024 11.46, Neil Armstrong wrote: While meson_sm_read_efuse() doesn't overflow, the string is not zero terminated and env_set*() will buffer overflow and add random characters to environment. Signed-off-by: Neil Armstron

[PATCH v2 5/6] mtd: nand: raw: atmel: Fix comment in timings preparation

2024-03-20 Thread Alexander Dahl
Introduced with commit 6a8dfd57220d ("nand: atmel: Add DM based NAND driver") when driver was initially ported from Linux. The context around this and especially the code itself suggests 'read' is meant instead of write. The fix is the same as accepted in Linux already with mainline Linux kernel

[PATCH v2 4/6] mtd: nand: raw: atmel: Introduce optional debug commands

2024-03-20 Thread Alexander Dahl
For now adds one new command 'hsmc' with a single subcommand 'decode' to read and display the content of the registers of the Static Memory Controllers (SMC/HSMC) found in different at91 SoCs. Needed to get a better picture on what raw nand core and atmel nand controller driver try to set as timin

[PATCH v2 6/6] cmd: nand: Add new optional sub-command 'onfi'

2024-03-20 Thread Alexander Dahl
Override the ONFI timing mode at runtime. Signed-off-by: Alexander Dahl --- Notes: v2: - initial patch version (not present in v1) cmd/Kconfig | 10 ++ cmd/nand.c | 61 drivers/mtd/nand/raw/nand_base.c | 2

[PATCH v2 2/6] mtd: nand: raw: Port another option flag from Linux

2024-03-20 Thread Alexander Dahl
Introduced in upstream Linux with commit 7a08dbaedd365 for release v5.0. When the new atmel nand driver was backported to U-Boot with commit 6a8dfd57220d ("nand: atmel: Add DM based NAND driver") that definition was added to the driver instead of the header file. Move it over to the other definit

[PATCH v2 1/6] mtd: nand: raw: Use macro nand_to_mtd() where appropriate

2024-03-20 Thread Alexander Dahl
In every other place in this file the macro is used, make it consistent. Fixes: 9d1806fadc24 ("mtd: nand: Get rid of mtd variable in function calls") Signed-off-by: Alexander Dahl Reviewed-by: Michael Trimarchi --- Notes: v1: - initial patch version v2: - collected tags d

[PATCH v2 0/6] mtd: nand: raw: Collected improvements

2024-03-20 Thread Alexander Dahl
Hello everyone, while working on NAND flash support for a custom board based on the at91 SAM9X60 SoC I stumbled over some issues in the raw nand subsystem. Four of six patches are minor fixes. Patch 4 introduces a new subcommand for the new atmel nand controller driver. Patch 6 introduces a new

  1   2   >