回覆: [PATCH] net: phy: ncsi: Correct the endian of the checksum

2024-03-02 Thread Jacky Chou
Hi Dan Carpenter, I have verified it on the little-endian platform, such as ASPEED AST2600. I think put_unaligned_be32() and htonl() functions have no effect on big-endian platforms. And keep put_unaligned_be32() to help access the unaligned memory, such as pchecksum variable. Thanks, Jacky _

Re: [PULL] u-boot-sh/master-riic

2024-03-02 Thread Tom Rini
On Sat, Mar 02, 2024 at 05:52:43PM +0100, Marek Vasut wrote: > The following changes since commit abd4fb5ac13215733569925a06991e0a182ede14: > > Merge patch series "Dockerfile: Build coreboot from source" (2024-02-27 > 16:28:57 -0500) > > are available in the Git repository at: > > https://

Re: [PATCH 00/19] ARM: renesas: Rename R-Mobile to Renesas

2024-03-02 Thread Tom Rini
On Tue, 27 Feb 2024 17:05:40 +0100, Marek Vasut wrote: > Rename R-Mobile to Renesas all over the place because the chips are > made by Renesas, while only a subset of them is from the R-Mobile line. > > Marek Vasut (19): > ARM: renesas: Drop remnants of R8A7740 support > ARM: renesas: Drop un

[PATCH] fdt: Fix bootm_low handling

2024-03-02 Thread Marek Vasut
According to README CFG_SYS_BOOTMAPSZ section, in case both "bootm_low" and "bootm_size" variables are defined, "bootm_mapsize" variable is not defined and CFG_SYS_BOOTMAPSZ macro is not defined, all data for the Linux kernel must be between "bootm_low" and "bootm_low" + "bootm_size". Currently, f

Re: [PATCH v1 2/2] rockchip: spl-boot-order: Improve debugging message when device isn't found

2024-03-02 Thread Dragan Simic
Hello Christopher, On 2024-03-02 15:50, Christopher Obbard wrote: When debugging the SPL boot order, the node ID of a device which hasn't been found is printed but it can be quite hard to relate that to the specific devicetree node. To aid debugging, print the node path as well as the ID. Ori

Re: [PATCH v1 1/2] rockchip: spl-boot-order: Fix spelling succes→success

2024-03-02 Thread Dragan Simic
Hello Christopher, On 2024-03-02 15:50, Christopher Obbard wrote: Fix a simple spelling mistake in a comment. I'd suggest that the main part of the patch subject is adjusted a bit, e.g. to something like "fix a typo". Otherwise, looking good to me. Reviewed-by: Dragan Simic Signed-off-by:

Re: [PATCH v1 0/5] TEE: minor cleanup

2024-03-02 Thread Igor Opaniuk
Hello Ilias, On Fri, Mar 1, 2024 at 10:41 AM Ilias Apalodimas < ilias.apalodi...@linaro.org> wrote: > Hi Igor, > > On Thu, 29 Feb 2024 at 21:11, Igor Opaniuk wrote: > > > > Hi Ilias, > > > > On Wed, Feb 14, 2024 at 7:34 PM Igor Opaniuk > wrote: > >> > >> - Address some spelling errors and typos

[PATCH v2 5/5] tee: remove common.h inclusion

2024-03-02 Thread Igor Opaniuk
The usage of the common.h include file is deprecated [1], and has already been removed from several files. Get rid of all inclusions in the "drivers/tee" directory, and replace it with required include files directly where needed. [1] doc/develop/codingstyle.rst Signed-off-by: Igor Opaniuk ---

[PATCH v2 4/5] test: py: add optee_rpmb tests

2024-03-02 Thread Igor Opaniuk
Add read/write tests for optee_rpmb cmd. Signed-off-by: Igor Opaniuk --- (no changes since v1) test/py/tests/test_optee_rpmb.py | 20 1 file changed, 20 insertions(+) create mode 100644 test/py/tests/test_optee_rpmb.py diff --git a/test/py/tests/test_optee_rpmb.py b/test

[PATCH v2 3/5] cmd: optee_rpmb: build cmd for sandbox

2024-03-02 Thread Igor Opaniuk
Support CMD_OPTEE_RPMB for SANDBOX configurations. Test: $ ./u-boot -d arch/sandbox/dts/test.dtb ... => optee_rpmb write_pvalue test_variable test_value Wrote 11 bytes => optee_rpmb read_pvalue test_variable 11 Read 11 bytes, value = test_value Reviewed-by: Mattijs Korpershoek Tested-by: Mattijs

[PATCH v2 2/5] tee: sandbox: fix spelling errors

2024-03-02 Thread Igor Opaniuk
Fix spelling errors in comments. Reviewed-by: Heinrich Schuchardt Reviewed-by: Ilias Apalodimas Signed-off-by: Igor Opaniuk --- Changes in v2: - Applied R-b tags drivers/tee/sandbox.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/tee/sandbox.c b/drivers/

[PATCH v2 1/5] tee: optee: fix description in Kconfig

2024-03-02 Thread Igor Opaniuk
Fix OPTEE_TA_AVB symbol description in Kconfig: s/"write"rb"/"write_rb"/g Reviewed-by: Heinrich Schuchardt Reviewed-by: Ilias Apalodimas Signed-off-by: Igor Opaniuk --- Changes in v2: - Applied R-b tags drivers/tee/optee/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PATCH v2 0/5] TEE: minor cleanup

2024-03-02 Thread Igor Opaniuk
- Address some spelling errors and typos - Support CMD_OPTEE_RPMB for SANDBOX configurations and add python tests - Remove common.h inclusion for drivers/tee Changes in v2: - Fixed chimp_optee.c:37:9: error: implicit declaration of function 'memset' - Applied R-b and T-b tags Igor Opaniuk (5):

Re: [PATCH v1 2/2] rockchip: rock-pi-4-rk3399: Enable booting from SPI flash

2024-03-02 Thread Dragan Simic
Hello Christopher, On 2024-03-02 15:34, Christopher Obbard wrote: Some variants of the ROCK Pi 4 series contain an SPI flash chip, which can be booted from. This patch enables support in U-Boot for building the image for the SPI flash, support for booting U-Boot from the SPI flash chip and supp

Re: [PATCH v1 2/2] rockchip: rock-pi-4-rk3399: Enable booting from SPI flash

2024-03-02 Thread Jonas Karlman
Hi Christopher, On 2024-03-02 17:12, Christopher Obbard wrote: > Hi Jonas, > > On Sat, 2024-03-02 at 16:28 +0100, Jonas Karlman wrote: >> Hi Christopher, >> >> On 2024-03-02 15:34, Christopher Obbard wrote: >>> Some variants of the ROCK Pi 4 series contain an SPI flash chip, which can >>> be boot

Re: [PATCH] Makefile: use shell to calculate map_size

2024-03-02 Thread Dragan Simic
Hello Leon, On 2024-03-02 14:17, Leon M. Busch-George wrote: From: "Leon M. Busch-George" The error message "bc: command not found" is easily missed since the build continues. bc is not a part of coreutils or base-devel. POSIX sh can also do the calculation. Signed-off-by: Leon M. Busch-Georg

[PATCH v3 3/6] rockchip: Use common bss and stack addresses on RK3328

2024-03-02 Thread Jonas Karlman
With the stack and text base used by U-Boot SPL and proper on RK3328 there is a high likelihood of overlapping when U-Boot proper + FDT nears or exceeded 1 MiB in size. Currently the following memory layout is typically used on RK3328: [0, 256K) - SPL binary [ 256K, 2M) - TF-A / reserved [

[PATCH v3 5/6] rockchip: Use common bss and stack addresses on RK356x

2024-03-02 Thread Jonas Karlman
Currently the following memory layout is typically used on RK356x: [0, 256K) - SPL binary [ 256K, 2M) - TF-A / reserved [ -X, 4M) - SPL pre-reloc stack (SPL_STACK) [-128K, 4M) - pre-reloc malloc heap (SPL_SYS_MALLOC_F_LEN) [ -X, 6M) - SPL reloc stack (SPL_STACK_R_ADDR) [ 5M, 6

[PATCH v3 4/6] rockchip: Use common bss and stack addresses on RK3399

2024-03-02 Thread Jonas Karlman
With the stack and text base used by U-Boot SPL and proper on RK3399 there is a high likelihood of overlapping when U-Boot proper + FDT nears or exceeded 1 MiB in size. Currently the following memory layout is typically used on RK3399: [0, 256K) - SPL binary [ 256K, 2M) - TF-A / reserved [

[PATCH v3 6/6] rockchip: Use common bss and stack addresses on RK3588

2024-03-02 Thread Jonas Karlman
Currently the following memory layout is typically used on RK3588: [0, 256K) - SPL binary [ 256K, 2M) - TF-A / reserved [ -X, 4M) - SPL pre-reloc stack (SPL_STACK) [ 3.5M, 4M) - pre-reloc malloc heap (SPL_SYS_MALLOC_F_LEN) [ -X, 6M) - SPL reloc stack (SPL_STACK_R_ADDR) [ 5M, 6

[PATCH v3 2/6] rockchip: Use common bss and stack addresses on RK3308

2024-03-02 Thread Jonas Karlman
Currently the following memory layout is typically used on RK3308: [0, 256K) - SPL binary [ 256K, 2M) - TF-A / reserved [ -X, 4M) - SPL pre-reloc stack (SPL_STACK) [ -8K, 4M) - pre-reloc malloc heap (SPL_SYS_MALLOC_F_LEN) [ 4M, +8K) - SPL bss (SPL_BSS_START_ADDR, SPL_BSS_MAX_SIZE)

[PATCH v3 1/6] rockchip: Add common default bss and stack addresses

2024-03-02 Thread Jonas Karlman
On Rockchip the typical aarch64 boot steps are as follows: - BROM load TPL to SRAM - TPL init full DRAM - use stack in SRAM at TPL_STACK addr - use malloc heap on stack, size is TPL_SYS_MALLOC_F_LEN - TPL jump back to BROM - BROM load SPL to beginning of DRAM - SPL init storage devices - use

[PATCH v3 0/6] rockchip: Update stack and bss addresses on RK3308, RK3328, RK3399, RK356x and RK3588

2024-03-02 Thread Jonas Karlman
Trying to run U-Boot proper close to 1 MiB in size with debug logging something similar to following can be observed: FDT 002fc4e0 gd 002fddf0 FDT overlap resetting ... System reset not supported on this platform ### ERROR ### Please RESET the board ### Fix this by chang

[PULL] u-boot-sh/master-riic

2024-03-02 Thread Marek Vasut
The following changes since commit abd4fb5ac13215733569925a06991e0a182ede14: Merge patch series "Dockerfile: Build coreboot from source" (2024-02-27 16:28:57 -0500) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-sh.git master-riic for you to fetch c

Re: [PATCH v1 2/2] rockchip: rock-pi-4-rk3399: Enable booting from SPI flash

2024-03-02 Thread Christopher Obbard
Hi Jonas, On Sat, 2024-03-02 at 16:28 +0100, Jonas Karlman wrote: > Hi Christopher, > > On 2024-03-02 15:34, Christopher Obbard wrote: > > Some variants of the ROCK Pi 4 series contain an SPI flash chip, which can > > be booted from. This patch enables support in U-Boot for building the > > image

Re: [PATCH v1 2/2] rockchip: rock-pi-4-rk3399: Enable booting from SPI flash

2024-03-02 Thread Jonas Karlman
Hi Christopher, On 2024-03-02 15:34, Christopher Obbard wrote: > Some variants of the ROCK Pi 4 series contain an SPI flash chip, which can > be booted from. This patch enables support in U-Boot for building the > image for the SPI flash, support for booting U-Boot from the SPI flash > chip and su

Re: [PATCH v3] test/py: reset: Add a test for reset command

2024-03-02 Thread Tom Rini
On Tue, Feb 20, 2024 at 01:11:38PM +0530, Love Kumar wrote: > Add a test for reset commands which performs resetting of CPU, It does > COLD reset by default and WARM reset with -w option. > > Signed-off-by: Love Kumar > Reviewed-by: Tom Rini > --- > Changes in v2: > - Set bootmode through boar

Re: [PATCH v1] cmd: md5sum: use hash_command

2024-03-02 Thread Igor Opaniuk
Hi Tom, On Sat, Mar 2, 2024 at 12:31 AM Tom Rini wrote: > On Sun, Feb 11, 2024 at 07:56:16PM +0100, Igor Opaniuk wrote: > > > From: Igor Opaniuk > > > > Drop old implementation and use hash_command() instead, as > > how it's currently done for crc32 and sha1sum cmds. > > > > Test: > > => md5sum

[PATCH v2] cmd: md5sum: use hash_command

2024-03-02 Thread Igor Opaniuk
Drop old implementation and use hash_command() instead, as how it's currently done for crc32 and sha1sum cmds. Test: => md5sum 0x6000 0x200 md5 for 6000 ... 61ff ==> e6bbbe95f5b41996f4a9b9af7bbd4050 Signed-off-by: Igor Opaniuk --- Changes in v2: - Addressed build issues on some plat

[PATCH v1 2/2] rockchip: spl-boot-order: Improve debugging message when device isn't found

2024-03-02 Thread Christopher Obbard
When debugging the SPL boot order, the node ID of a device which hasn't been found is printed but it can be quite hard to relate that to the specific devicetree node. To aid debugging, print the node path as well as the ID. Original debug message: board_boot_order: could not map node @73c to

[PATCH v1 1/2] rockchip: spl-boot-order: Fix spelling succes→success

2024-03-02 Thread Christopher Obbard
Fix a simple spelling mistake in a comment. Signed-off-by: Christopher Obbard --- arch/arm/mach-rockchip/spl-boot-order.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-rockchip/spl-boot-order.c b/arch/arm/mach-rockchip/spl-boot-order.c index 2c39a215c10..e54

[PATCH v1 0/2] Trivial fixes for Rockchip's SPL boot order

2024-03-02 Thread Christopher Obbard
This series contains some trivial fixes. The first patch fixes a spelling mistake in a comment. The second patch adds the full devicetree node path (rather than just the ID) in the debug message when a boot device can't be found. This series may be found at [0]. [0]: https://gitlab.collabora.c

[PATCH v1 2/2] rockchip: rock-pi-4-rk3399: Enable booting from SPI flash

2024-03-02 Thread Christopher Obbard
Some variants of the ROCK Pi 4 series contain an SPI flash chip, which can be booted from. This patch enables support in U-Boot for building the image for the SPI flash, support for booting U-Boot from the SPI flash chip and support in U-Boot for accessing the SPI flash using `sf` commands. Not al

[PATCH v1 0/2] Enable booting from SPI flash on ROCK Pi 4

2024-03-02 Thread Christopher Obbard
This series brings up and enables booting from the SPI flash present on some variants of the ROCK Pi 4 in U-Boot. The first patch syncs the ROCK Pi 4A devicetree from Linux, which contains the SPI flash node. The second patch enables support in U-Boot for the SPI flash chip and booting U-Boot fro

[PATCH v1 1/2] arm: rockchip: sync ROCK Pi 4A DTS from Linux

2024-03-02 Thread Christopher Obbard
To prepare for ROCK Pi 4A SPI flash support, sync the DTS from Linux which includes an SPI flash node. Kernel tag: v6.6-rc1 Kernel commits: - eddf73029770 ("arm64: dts: rockchip: Enable internal SPI flash for ROCK \ Pi 4A/B/C") Signed-off-by: Christopher Obbard --- arch/arm/

Re: [PATCH 1/2] cli: allow users to disable history if unused at all

2024-03-02 Thread Tom Rini
On Sat, Mar 02, 2024 at 12:35:12PM +0800, hanyuan wrote: > Hi Tom, > > Thanks for reviewing! I am not quite sure about the tests which > you refer to. Is it the CI in the gitlab? I think this patch is simple > and it doesn’t occur any errors during my work these days, thus I tested > it manually

[PATCH] Makefile: use shell to calculate map_size

2024-03-02 Thread Leon M. Busch-George
From: "Leon M. Busch-George" The error message "bc: command not found" is easily missed since the build continues. bc is not a part of coreutils or base-devel. POSIX sh can also do the calculation. Signed-off-by: Leon M. Busch-George --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 de

[PATCH] usb: xhci-dwc3: Fix support for dis_enblslpm_quirk

2024-03-02 Thread Jonas Karlman
No device tree in U-Boot or linux use the wrong spelling used in code. Use correct property name as defined in dwc3 bindings. Fixes: 062790f46131 ("usb: xhci-dwc3: Add USB2 PHY configuration") Signed-off-by: Jonas Karlman --- drivers/usb/host/xhci-dwc3.c | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH] usb: dwc3-generic: Fix build errors when USB_DWC3_GADGET is disabled

2024-03-02 Thread Jonas Karlman
Hi Mattijs, On 2024-03-01 16:18, Mattijs Korpershoek wrote: > Hi Jonas, thank you for the patch. > > On lun., févr. 26, 2024 at 13:36, Jonas Karlman wrote: > >> On 2024-02-26 11:18, Marek Vasut wrote: >>> On 2/26/24 10:50 AM, Jonas Karlman wrote: On 2024-02-26 09:22, Marek Vasut wrote: >>>

Re: [PATCH v4] disk: dos: Add all options for EFI System Partitions

2024-03-02 Thread Mark Kettenis
> From: Peter Robinson > Date: Sat, 2 Mar 2024 11:20:31 + > > The EFI spec states that the ESP can be any of FAT12/16/32 but for > compatibility doesn't necssarily require the partition to be the > EFI partition table ID of 0xef. A number of arm devices will not > find their firmware on a FA

[PATCH v4] disk: dos: Add all options for EFI System Partitions

2024-03-02 Thread Peter Robinson
The EFI spec states that the ESP can be any of FAT12/16/32 but for compatibility doesn't necssarily require the partition to be the EFI partition table ID of 0xef. A number of arm devices will not find their firmware on a FAT partition with an ID of 0xef so also allow the original FAT12/16/32 parti

Re: [PATCH v3] disk: dos: Add all options for EFI System Partitions

2024-03-02 Thread Mark Kettenis
> From: Peter Robinson > Date: Sat, 2 Mar 2024 10:54:36 + Hi Peter, > The EFI spec states that the ESP can be any of FAT12/16/32 but for > compatibility doesn't necssarily require the partition to be the > EFI partition table ID of 0xef. A number of arm devices will not > find their firmwar

[PATCH v3] disk: dos: Add all options for EFI System Partitions

2024-03-02 Thread Peter Robinson
The EFI spec states that the ESP can be any of FAT12/16/32 but for compatibility doesn't necssarily require the partition to be the EFI partition table ID of 0xef. A number of arm devices will not find their firmware on a FAT partition with an ID of 0xef so also allow the original FAT12/16/32 parti

Re: [PATCH v2] disk: dos: Add all options for EFI System Partitions

2024-03-02 Thread Peter Robinson
On Sun, 25 Feb 2024 at 14:23, Mark Kettenis wrote: > > > From: Peter Robinson > > Date: Sun, 25 Feb 2024 14:14:55 + > > > > The EFI spec states that the ESP can be any of FAT12/16/32 but for > > compatibility doesn't necssarily require the partition to be the > > EFI partition table ID of 0xe

Re: [PATCH 00/19] ARM: renesas: Rename R-Mobile to Renesas

2024-03-02 Thread Paul Barker
On 27/02/2024 16:05, Marek Vasut wrote: > Rename R-Mobile to Renesas all over the place because the chips are > made by Renesas, while only a subset of them is from the R-Mobile line. > > Marek Vasut (19): > ARM: renesas: Drop remnants of R8A7740 support > ARM: renesas: Drop unused sh_sdhi.h >