Re: [PATCH 08/18] rockchip: pine64: rockpro64: migrate to rockchip_early_misc_init_r

2024-02-03 Thread Dragan Simic
On 2024-02-03 16:18, Dragan Simic wrote: On 2024-02-03 15:18, Jonas Karlman wrote: On 2024-02-03 14:19, Dragan Simic wrote: Please see my comments below. On 2024-01-23 15:49, Quentin Schulz wrote: From: Quentin Schulz Only setup_iodomain() differs from the original misc_init_r from Rockchip

Re: Pull request smbios-2024-04-rc2

2024-02-03 Thread Tom Rini
On Sat, Feb 03, 2024 at 09:57:30AM +0100, Heinrich Schuchardt wrote: > Dear Tom, > > The following changes since commit 050a9b981d6a835133521b599be3ae189ce70f41: > > Merge tag 'u-boot-amlogic-fixes-20240201' of > https://source.denx.de/u-boot/custodians/u-boot-amlogic (2024-02-01 > 09:59:53 -0

[PATCH] net: macb: Add support for fixed link

2024-02-03 Thread belouargamohamed
From: BELOUARGA Mohamed The actual driver does not work when there is no linked PHY. These changes add support for fixed-link feature in the device tree. Signed-off-by: BELOUARGA Mohamed --- drivers/net/macb.c | 189 - 1 file changed, 117 insertions(

[PATCH v8 8/8] dts: OF_HAS_PRIOR_STAGE should depend on !BLOBLIST

2024-02-03 Thread Raymond Mao
When BLOBLIST is enabled, FDT is expected to be from bloblist carried from previous stage, instead of from OF_BOARD, therefore only enable OF_HAS_PRIOR_STAGE when BLOBLIST is disabled. Signed-off-by: Raymond Mao --- Changes in V7 - Initial patch . dts/Kconfig | 1 + 1 file changed, 1 insertion(

[PATCH v8 7/8] bloblist: Load the bloblist from the previous loader

2024-02-03 Thread Raymond Mao
During bloblist initialization, load the bloblist via boot arguments from the previous loader. If a valid bloblist exists in boot arguments, relocate it into the fixed bloblist memory region. If not, fallback to support BLOBLIST_ADDR or BLOBLIST_ALLOC. Signed-off-by: Raymond Mao --- Changes in v4

[PATCH v8 6/8] arm: Get bloblist from boot arguments

2024-02-03 Thread Raymond Mao
Add arch custom function to get bloblist from boot arguments. Check whether boot arguments aligns with the register conventions defined in FW Handoff spec v0.9. Signed-off-by: Raymond Mao --- Changes in v2 - Remove low level code for copying boot arguments. - Refactor board_fdt_blob_setup() and r

[PATCH v8 5/8] arm: armv8: save boot arguments

2024-02-03 Thread Raymond Mao
Save boot arguments x[0-3] into an array for handover of bloblist from previous boot stage. Signed-off-by: Raymond Mao Suggested-by: Ard Biesheuvel --- Changes in v2 - New patch file created for v2. Changes in V5 - Drop the dependence on OF_BOARD. Changes in V7 - Exclude the saved_args when BLOB

[PATCH v8 4/8] arm: armv7: save boot arguments

2024-02-03 Thread Raymond Mao
Save boot arguments r[0-3] into an array for handover of bloblist from previous boot stage. Signed-off-by: Raymond Mao Suggested-by: Ard Biesheuvel --- Changes in v2 - New patch file created for v2. Changes in v3 - Swap value of r0 with r2. Changes in v4 - Fix a bug when saving the boot args. Ch

[PATCH v8 3/8] bloblist: refactor of bloblist_reloc()

2024-02-03 Thread Raymond Mao
The current bloblist pointer and size can be retrieved from global data, so we don't need to pass them from the function arguments. This change also help to remove all external access of gd->bloblist outside of bloblist module. Signed-off-by: Raymond Mao Reviewed-by: Ilias Apalodimas --- Changes

[PATCH v8 2/8] bloblist: check bloblist with specified buffer size

2024-02-03 Thread Raymond Mao
Instead of expecting the bloblist total size to be the same as the pre-allocated buffer size, practically we are more interested in whether the pre-allocated buffer size is bigger than the bloblist total size. Signed-off-by: Raymond Mao Reviewed-by: Ilias Apalodimas --- Changes in v2 - New patch

[PATCH v8 1/8] bloblist: add API to check the register conventions

2024-02-03 Thread Raymond Mao
Add bloblist_check_reg_conv() to check whether the bloblist is compliant to the register conventions defined in Firmware Handoff specification. This API can be used for all Arm platforms. Signed-off-by: Raymond Mao --- Changes in v2 - Refactor of bloblist_check_reg_conv(). Changes in v3 - bloblis

[PATCH v8 0/8] Handoff bloblist from previous boot stage

2024-02-03 Thread Raymond Mao
This patch set adds/adapts a few bloblist APIs and implements Arm arch custom function to retrieve the bloblist (aka. Transfer List) from previous loader via boot arguments when BLOBLIST option is enabled and all boot arguments are compliant to the register conventions defined in the Firmware Hando

Re: [PATCH 08/18] rockchip: pine64: rockpro64: migrate to rockchip_early_misc_init_r

2024-02-03 Thread Dragan Simic
Hello Jonas, On 2024-02-03 15:18, Jonas Karlman wrote: On 2024-02-03 14:19, Dragan Simic wrote: Please see my comments below. On 2024-01-23 15:49, Quentin Schulz wrote: From: Quentin Schulz Only setup_iodomain() differs from the original misc_init_r from Rockchip mach code, so let's use roc

Re: [PATCH 1/3] rockchip: rk35xx: Remove use of eMMC DDR52 mode

2024-02-03 Thread Jonas Karlman
Hi Quentin, On 2024-02-02 12:10, Quentin Schulz wrote: > Hi Jonas, > > On 2/1/24 21:06, Jonas Karlman wrote: >> Hi Quentin, >> >> On 2024-02-01 13:40, Quentin Schulz wrote: >>> Hi Jonas, >>> >>> On 2/1/24 11:51, Jonas Karlman wrote: Hi Quentin, On 2024-02-01 11:18, Quentin Schulz w

Re: [PATCH 08/18] rockchip: pine64: rockpro64: migrate to rockchip_early_misc_init_r

2024-02-03 Thread Jonas Karlman
Hi Dragan, On 2024-02-03 14:19, Dragan Simic wrote: > Hello Quentin, > > Please see my comments below. > > On 2024-01-23 15:49, Quentin Schulz wrote: >> From: Quentin Schulz >> >> Only setup_iodomain() differs from the original misc_init_r from >> Rockchip mach code, so let's use rockchip_early

Re: [PATCH 1/2] riscv: cpu: cv1800b: Add support for cv1800b SoC

2024-02-03 Thread Kongyang Liu
Heinrich Schuchardt 于2024年2月2日周五 19:11写道: > > On 02.02.24 10:37, Kongyang Liu wrote: > > Add Sophgo cv1800b SoC to support RISC-V arch. > > > > Signed-off-by: Kongyang Liu > > > > --- > > > > arch/riscv/Kconfig | 1 + > > arch/riscv/cpu/cv1800b/Kconfig | 12 > > ar

Re: [PATCH] poplar: add myself as co-maintainer

2024-02-03 Thread Yang Xiwen
On 2/3/2024 6:19 PM, Jorge Ramirez-Ortiz, Gmail wrote: On 03/02/24 17:45:42, Yang Xiwen wrote: On 2/3/2024 4:32 PM, Jorge Ramirez-Ortiz, Gmail wrote: On 03/02/24 07:54:22, Shawn Guo wrote: On Sat, Feb 3, 2024 at 5:44 AM Igor Opaniuk wrote: Add myself as co-maintainer for Poplar board, as I'

Re: [PATCH] poplar: add myself as co-maintainer

2024-02-03 Thread Yang Xiwen
On 2/3/2024 5:45 PM, Yang Xiwen wrote: On 2/3/2024 4:32 PM, Jorge Ramirez-Ortiz, Gmail wrote: On 03/02/24 07:54:22, Shawn Guo wrote: On Sat, Feb 3, 2024 at 5:44 AM Igor Opaniuk wrote: Add myself as co-maintainer for Poplar board, as I'm currently working on it (re-testing releases, addressin

Re: [PATCH] poplar: add myself as co-maintainer

2024-02-03 Thread Yang Xiwen
On 2/3/2024 4:32 PM, Jorge Ramirez-Ortiz, Gmail wrote: On 03/02/24 07:54:22, Shawn Guo wrote: On Sat, Feb 3, 2024 at 5:44 AM Igor Opaniuk wrote: Add myself as co-maintainer for Poplar board, as I'm currently working on it (re-testing releases, addressing issues etc). CC: Jorge Ramirez-Ortiz

Re: [PATCH 08/18] rockchip: pine64: rockpro64: migrate to rockchip_early_misc_init_r

2024-02-03 Thread Dragan Simic
Hello Quentin, Please see my comments below. On 2024-01-23 15:49, Quentin Schulz wrote: From: Quentin Schulz Only setup_iodomain() differs from the original misc_init_r from Rockchip mach code, so let's use rockchip_early_misc_init_r instead of reimplementing the whole misc_init_r from Rockch

Re: [PATCH 07/18] rockchip: pine64: pinephone: migrate to rockchip_early_misc_init_r

2024-02-03 Thread Dragan Simic
Hello Quentin, Please see my comments below. On 2024-01-23 15:49, Quentin Schulz wrote: From: Quentin Schulz Compared to the original misc_init_r from Rockchip mach code, setup_iodomain() is added and rockchip_setup_macaddr() is not called. It is assumed adding rockchip_setup_macaddr() back

Re: [PATCH 06/18] rockchip: pine64: pinebook: migrate to rockchip_early_misc_init_r

2024-02-03 Thread Dragan Simic
Hello Quentin and Kever, Please see my comments below. On 2024-02-01 05:02, Dragan Simic wrote: On 2024-02-01 03:48, Kever Yang wrote: On 2024/1/23 22:49, Quentin Schulz wrote: From: Quentin Schulz Compared to the original misc_init_r from Rockchip mach code, setup_iodomain() is added and r

Re: [PATCH 04/18] rockchip: add weak function symbol called at the beginning of misc_init_r

2024-02-03 Thread Dragan Simic
Hello Quentin, This patch looks good to me, avoiding unnecessary code duplication is always welcome. My "Reviewed-by" is included below. However, I've got some more comments, which I'll send separately for the other patches in this series. On 2024-01-23 15:49, Quentin Schulz wrote: From: Qu

[PATCH] rockchip: rk3588-evb: Enable USB support

2024-02-03 Thread Andy Yan
From: Andy Yan Enable USB releated config to support boot from usb. Signed-off-by: Andy Yan --- configs/evb-rk3588_defconfig | 12 1 file changed, 12 insertions(+) diff --git a/configs/evb-rk3588_defconfig b/configs/evb-rk3588_defconfig index 0b7b4f2f627..8a6aa91cb29 100644 --- a

Re: [PATCH v3] common: usb-hub: Reset hub port before scanning

2024-02-03 Thread Dragan Simic
Hello Andre and Shantur, On 2024-02-02 12:28, Andre Przywara wrote: On Fri, 02 Feb 2024 03:35:24 +0100 Dragan Simic wrote: On 2024-02-02 01:12, Andre Przywara wrote: > On Thu, 1 Feb 2024 18:35:28 + Shantur Rathore > wrote: >> On Thu, Feb 1, 2024 at 4:46 PM Andre Przywara >> wrote: >> > O

Re: [PATCH] poplar: add myself as co-maintainer

2024-02-03 Thread Jorge Ramirez-Ortiz, Gmail
On 03/02/24 17:45:42, Yang Xiwen wrote: > On 2/3/2024 4:32 PM, Jorge Ramirez-Ortiz, Gmail wrote: > > On 03/02/24 07:54:22, Shawn Guo wrote: > > > On Sat, Feb 3, 2024 at 5:44 AM Igor Opaniuk > > > wrote: > > > > > > > > Add myself as co-maintainer for Poplar board, as I'm currently > > > > working

Pull request smbios-2024-04-rc2

2024-02-03 Thread Heinrich Schuchardt
Dear Tom, The following changes since commit 050a9b981d6a835133521b599be3ae189ce70f41: Merge tag 'u-boot-amlogic-fixes-20240201' of https://source.denx.de/u-boot/custodians/u-boot-amlogic (2024-02-01 09:59:53 -0500) are available in the Git repository at: https://source.denx.de/u-boot/cust

Re: [PATCH] poplar: add myself as co-maintainer

2024-02-03 Thread Jorge Ramirez-Ortiz, Gmail
On 03/02/24 07:54:22, Shawn Guo wrote: > On Sat, Feb 3, 2024 at 5:44 AM Igor Opaniuk wrote: > > > > Add myself as co-maintainer for Poplar board, as I'm currently > > working on it (re-testing releases, addressing issues etc). > > > > CC: Jorge Ramirez-Ortiz > > CC: Shawn Guo > > Signed-off-by: