Re: [PATCH 00/26] sync am65x device tree with Linux v6.7-rc1

2024-01-01 Thread Jan Kiszka
On 27.12.23 13:39, Nishanth Menon wrote: > On 15:00-20231221, Tom Rini wrote: >> On Thu, Dec 21, 2023 at 11:43:46AM -0600, Bryan Brattlof wrote: >> >>> Hello Everyone! >>> >>> This series gets the am65x booting again along with syncing the device >>> tree files with v6.7-rc1 Linux. >>> >>> The bulk

[PATCH v3] test/py: i2c: Add tests for i2c command

2024-01-01 Thread Love Kumar
Add below test cases for i2c commands: i2c_bus - To show i2c bus info, i2c_dev - To set or show the current bus, i2c_probe - To probe the i2c device, i2c_eeprom - To test i2c eeprom device, i2c_probe_all_buses - To list down all the buses and probes it Signed-off-by: Love Kumar --- Changes in v2:

[PATCH v3] test/py: mii: Add tests for mii command

2024-01-01 Thread Love Kumar
Add below test cases for mii commands: mii_info -To display MII PHY info mii_list - To list MII devices mii_set_device - To set MII device mii_read - To reads register from MII PHY address mii_dump - To display data from MII PHY address Signed-off-by: Love Kumar --- Changes in v2: - Get MII devic

Re: [PATCH] board: rockchip: Add support for FriendlyARM NanoPi R2C Plus

2024-01-01 Thread Kever Yang
Hi Tianling, On 2023/12/23 12:00, Tianling Shen wrote: The NanoPi R2C Plus is a small variant of NanoPi R2C with a on-board eMMC flash (8G) included. The device tree is taken from the kernel v6.5. Signed-off-by: Tianling Shen --- arch/arm/dts/Makefile | 1 + .../d

Re: [PATCH v2] rockchip: rk35xx: expand space for decompressed kernel

2024-01-01 Thread Kever Yang
On 2023/12/27 00:43, Hugh Cole-Baker wrote: An uncompressed 6.7.0-rc1 Linux kernel Image built with the arm64 defconfig is about 40MB. This does not fit in to the space between kernel_comp_addr_r and fdt_addr_r, so when uncompressing an Image.gz to this size, the FDT will be overwritten. Rearra

Re: [PATCH v1] arm: dts: rockchip: rk3288: move to 64 bit reg size

2024-01-01 Thread Kever Yang
On 2023/12/27 20:06, Johan Jonker wrote: To make automatic Rockchip DT syncing possible from Linux to U-boot prepare rk3288.dtsi by moving to 64 bit reg size. Signed-off-by: Johan Jonker Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3288-evb.dtsi | 2 +- arch/ar

Re: [PATCH] rockchip: rk3568: add support of all UART

2024-01-01 Thread Kever Yang
Hi Arseniy, On 2024/1/1 21:43, Arseniy Mescheryakov wrote: Thanks for the answer. I think developers should have the opportunity to configure UART from the u-boot directly (via configuration) without any additional proprietary blobs. The soc driver source code is used for hardware, I think soc v

Re: Please pull u-boot-dm next

2024-01-01 Thread Tom Rini
On Mon, Jan 01, 2024 at 10:31:57AM -0700, Simon Glass wrote: > Hi Tom, > > This is for -next > > https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/19131 > > https://dev.azure.com/simon0972/u-boot/_build/results?buildId=57&view=results > > > The following changes since commit 2b28

Re: [PATCH v3 4/8] dts: Add alternative location for upstream DTB builds

2024-01-01 Thread Tom Rini
On Mon, Jan 01, 2024 at 03:32:41PM -0700, Simon Glass wrote: > Hi Mark, Tom, > > On Sun, Dec 31, 2023 at 5:33 PM Mark Kettenis wrote: > > > > > Date: Sun, 31 Dec 2023 15:39:53 -0500 > > > From: Tom Rini > > > > > > On Sun, Dec 31, 2023 at 07:28:52AM -0700, Simon Glass wrote: > > > > Hi Sumit, >

Re: [PATCH v2 2/2] efi_loader: provide tool to dump SMBIOS table

2024-01-01 Thread Heinrich Schuchardt
On 1/1/24 23:41, Simon Glass wrote: Hi Heinrich, On Mon, Jan 1, 2024 at 11:50 AM Heinrich Schuchardt wrote: An EFI binary dmidump.efi is provided that can be used to check the SMBIOS table for consistency and to dump it as a file. The tool provides the following commands: check Check t

[PATCH v2 1/1] x86: all firmware tables must be paragraph aligned

2024-01-01 Thread Heinrich Schuchardt
On qemu-x86_64_defconfig the following was observed: => efidebug tables 000f0074 eb9d2d31-2d88-11d3-9a16-0090273fc14d SMBIOS table The SMBIOS configuration table does not point to a paragraph-aligned (16 byte aligned) address. The reason is that in write_tables() rom_addr is not

Re: [PATCH 1/1] x86: all firmware tables must be paragraph aligned

2024-01-01 Thread Heinrich Schuchardt
On 1/1/24 23:41, Simon Glass wrote: On Mon, Jan 1, 2024 at 4:52 AM Heinrich Schuchardt wrote: On qemu-x86_64_defconfig the following was observed: => efidebug tables 000f0074 eb9d2d31-2d88-11d3-9a16-0090273fc14d SMBIOS table The SMBIOS configuration table does not point t

Re: [PATCH 1/1] cmd: fdt: check fdt address

2024-01-01 Thread Simon Glass
Hi Heinrich, On Sun, Dec 31, 2023 at 9:31 AM Heinrich Schuchardt wrote: > > On 12/31/23 15:22, Simon Glass wrote: > > Hi Heinrich, > > > > On Wed, Dec 20, 2023 at 5:00 PM Heinrich Schuchardt > > wrote: > >> > >> Trying to read a device-tree from an illegal address leads to a crash. > >> > >> Che

Re: [PATCH 1/1] x86: all firmware tables must be paragraph aligned

2024-01-01 Thread Simon Glass
On Mon, Jan 1, 2024 at 4:52 AM Heinrich Schuchardt wrote: > > On qemu-x86_64_defconfig the following was observed: > > => efidebug tables > 000f0074 eb9d2d31-2d88-11d3-9a16-0090273fc14d SMBIOS table > > The SMBIOS configuration table does not point to a paragraph aligned > addres

Re: [PATCH v5 04/12] smbios: Use SMBIOS 3.0 to support an address above 4GB

2024-01-01 Thread Simon Glass
Hi Heinrich, On Mon, Jan 1, 2024 at 10:34 AM Heinrich Schuchardt wrote: > > On 12/31/23 16:25, Simon Glass wrote: > > When the SMBIOS table is written to an address above 4GB a 32-bit table > > address is not large enough. > > > > Use an SMBIOS3 table in that case. > > > > Note that we cannot use

Re: [PATCH v2 2/2] efi_loader: provide tool to dump SMBIOS table

2024-01-01 Thread Simon Glass
Hi Heinrich, On Mon, Jan 1, 2024 at 11:50 AM Heinrich Schuchardt wrote: > > An EFI binary dmidump.efi is provided that can be used to check the SMBIOS > table for consistency and to dump it as a file. > > The tool provides the following commands: > > check > Check the SMBIOS table for consist

Re: [PATCH v2 1/2] smbios: smbios.h should not import ofnode.h

2024-01-01 Thread Simon Glass
On Mon, Jan 1, 2024 at 11:50 AM Heinrich Schuchardt wrote: > > The smbios.h include does not use any definitions from ofnode.h. > So don't include it. > > As DECLARE_GLOBAL_DATA_PTR is no longer defined via dm/of.h we need to > add it to efi_smbios.c. > > Add now missing includes to smbios-parser.

Re: [PATCH v3 4/8] dts: Add alternative location for upstream DTB builds

2024-01-01 Thread Simon Glass
Hi Mark, Tom, On Sun, Dec 31, 2023 at 5:33 PM Mark Kettenis wrote: > > > Date: Sun, 31 Dec 2023 15:39:53 -0500 > > From: Tom Rini > > > > On Sun, Dec 31, 2023 at 07:28:52AM -0700, Simon Glass wrote: > > > Hi Sumit, > > > > > > On Fri, Dec 29, 2023 at 8:30 AM Sumit Garg wrote: > > > > > > > > On

[PATCH] net: phy: broadcom: Configure LEDs on BCM54210E

2024-01-01 Thread Marek Vasut
Configure LEDs on BCM54210E so they would blink on activity and indicate link speed. Without this the LEDs are always on if cable is plugged in. Signed-off-by: Marek Vasut --- Cc: Joe Hershberger Cc: Rafał Miłecki Cc: Ramon Fried Cc: Rasmus Villemoes --- drivers/net/phy/broadcom.c | 17 +

[PATCH] ARM: imx: Auto-detect PHY on Data Modul i.MX8M Mini/Plus eDM SBC

2024-01-01 Thread Marek Vasut
Implement fdtdec_board_setup() auto-detection of ethernet PHY. This uses properties of the hardware and pull resistor placement. If GPIO1_16 RGMII_MDC is HIGH, then R530 (MX8MM eDM SBC) or R390 (MX8MP eDM SBC) is populated. R530 or R390 is populated only on boards with AR8031 PHY. If GPIO1_16 RGM

[PATCH v2 2/2] efi_loader: provide tool to dump SMBIOS table

2024-01-01 Thread Heinrich Schuchardt
An EFI binary dmidump.efi is provided that can be used to check the SMBIOS table for consistency and to dump it as a file. The tool provides the following commands: check Check the SMBIOS table for consistency. exit Leave the tool. help Show available commands. save Save the SM

[PATCH v2 1/2] smbios: smbios.h should not import ofnode.h

2024-01-01 Thread Heinrich Schuchardt
The smbios.h include does not use any definitions from ofnode.h. So don't include it. As DECLARE_GLOBAL_DATA_PTR is no longer defined via dm/of.h we need to add it to efi_smbios.c. Add now missing includes to smbios-parser.c. Remove a superfluous check comparing the sizes of the SMBIOS 2.1 and S

[PATCH v2 9/2] efi_loader: provide tool to dump SMBIOS table

2024-01-01 Thread Heinrich Schuchardt
An EFI binary dmidump.efi is provided that can be used to check the SMBIOS table for consistency and to dump it as a file. As a prerequisite remove superfluous include from smbios.h. v2: remove dm/ofnode.h from smbios.h fix a wrong variable usage on dmidump.efi Heinrich Schuchard

Re: [PATCH v5 04/12] smbios: Use SMBIOS 3.0 to support an address above 4GB

2024-01-01 Thread Heinrich Schuchardt
On 12/31/23 16:25, Simon Glass wrote: When the SMBIOS table is written to an address above 4GB a 32-bit table address is not large enough. Use an SMBIOS3 table in that case. Note that we cannot use efi_allocate_pages() since this function has nothing to do with EFI. There is no equivalent funct

Please pull u-boot-dm next

2024-01-01 Thread Simon Glass
Hi Tom, This is for -next https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/19131 https://dev.azure.com/simon0972/u-boot/_build/results?buildId=57&view=results The following changes since commit 2b28c3b871cd5d55b19f0a86cef970139f8ab952: Merge patch series "Modernize U-Boot shel

Re: [PATCH v5 01/11] bloblist: Update the tag numbering

2024-01-01 Thread Simon Glass
From: Simon Glass Align bloblist tags with the FW handoff spec v0.9. The most common ones are from 0. TF related ones are from 0x100. All non-standard ones from 0xfff000. Added new defined tags: BLOBLISTT_OPTEE_PAGABLE_PART for TF. BLOBLISTT_TPM_EVLOG and BLOBLISTT_TPM_CRB_BASE for TPM. Signed-

Re: [PATCH v5 02/11] bloblist: Adjust API to align in powers of 2

2024-01-01 Thread Simon Glass
From: Simon Glass The updated bloblist structure stores the alignment as a power-of-two value in its structures. Adjust the API to use this, to avoid needing to calling ilog2(). Update the bloblist alignment from 16 bytes to 8 bytes. Drop a stale comment while we are here. Signed-off-by: Simon G

Re: [PATCH v5 03/11] bloblist: Change the magic value

2024-01-01 Thread Simon Glass
From: Simon Glass This uses a new value with spec v0.9 so change it. Signed-off-by: Simon Glass Co-developed-by: Raymond Mao Signed-off-by: Raymond Mao Reviewed-by: Ilias Apalodimas Reviewed-by: Simon Glass --- Changes in v2 - Update the bloblist magic to align to FW handoff spec v0.9. Chan

Re: [PATCH v5 06/11] bloblist: Checksum the entire bloblist

2024-01-01 Thread Simon Glass
From: Simon Glass Use a sinple 8-bit checksum for bloblist, as specified by the spec version 0.9. Spec v0.9 specifies that the entire bloblist area is checksummed, including unused portions. Update the code to follow this. Signed-off-by: Simon Glass Co-developed-by: Raymond Mao Signed-off-by:

Re: [PATCH v5 04/11] bloblist: Set version to 1

2024-01-01 Thread Simon Glass
From: Simon Glass The new bloblist for v0.9 has version 1 so update this value. Signed-off-by: Simon Glass Co-developed-by: Raymond Mao Signed-off-by: Raymond Mao Reviewed-by: Ilias Apalodimas Reviewed-by: Simon Glass --- include/bloblist.h | 2 +- 1 file changed, 1 insertion(+), 1 deletio

Re: [PATCH v5 05/11] bloblist: Access record hdr_size and tag via a function

2024-01-01 Thread Simon Glass
From: Simon Glass Convert accesses to tag and hdr_size via function for grouping tag and hdr_size together later. Signed-off-by: Simon Glass Co-developed-by: Raymond Mao Signed-off-by: Raymond Mao Reviewed-by: Ilias Apalodimas --- Changes in v3 - Update commit message. common/bloblist.c |

Re: [PATCH v5 07/11] bloblist: Handle alignment with a void entry

2024-01-01 Thread Simon Glass
From: Simon Glass Rather than setting the alignment using the header size, add an entirely new entry to cover the gap left by the alignment. Signed-off-by: Simon Glass Co-developed-by: Raymond Mao Signed-off-by: Raymond Mao Reviewed-by: Simon Glass Reviewed-by: Ilias Apalodimas --- Changes

Re: [PATCH v5 08/11] bloblist: Reduce blob-header size

2024-01-01 Thread Simon Glass
From: Simon Glass The v0.9 spec provides for an 8-byte header for each blob, with fewer fields. Drop spare value from bloblist record header. The blob data start address should be aligned to the alignment specified by the bloblist header. Update the implementation to match this. Signed-off-by: S

Re: [PATCH v5 09/11] bloblist: Adjust the bloblist header

2024-01-01 Thread Simon Glass
From: Simon Glass The v0.9 spec provides for a 24-byte header. Update the implementation to match this. Rename the fields of the bloblist header to align to the spec. Adds an alignment field into the bloblist header. Update the related bloblist APIs and UT testcases. Signed-off-by: Simon Glass

Re: [PATCH v5 10/11] bloblist: Add alignment to bloblist_new()

2024-01-01 Thread Simon Glass
From: Simon Glass Allow the alignment to be specified when creating a bloblist. Signed-off-by: Simon Glass Co-developed-by: Raymond Mao Signed-off-by: Raymond Mao Reviewed-by: Ilias Apalodimas --- Changes in v3 - Keep the flag argument to align to FW handoff spec up to commit 3592349. Change

Re: [PATCH v5 11/11] bloblist: Update documentation and header comment

2024-01-01 Thread Simon Glass
From: Simon Glass Align the documentation with the v0.9 spec. Signed-off-by: Simon Glass Signed-off-by: Raymond Mao Reviewed-by: Ilias Apalodimas --- doc/develop/bloblist.rst | 4 +++- include/bloblist.h | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) Applied to u-boot-dm/next,

Re: [PATCH 1/1] buildman: type cotaining

2024-01-01 Thread Simon Glass
On Fri, 15 Dec 2023 at 02:42, Heinrich Schuchardt wrote: > > %s/cotaining/containing/ > > Signed-off-by: Heinrich Schuchardt > --- > tools/buildman/boards.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied to u-boot-dm/next, thanks!

Re: [PATCH 01/10] x86: coral: Align bootph SPI-flash subnodes with parent

2024-01-01 Thread Simon Glass
The subnode has different tags from the parents, which is not correct. Fix the subnode. Signed-off-by: Simon Glass --- arch/x86/dts/chromebook_coral.dts | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) Applied to u-boot-dm/next, thanks!

Re: [PATCH 1/1] binman: used-before-assignment in ftest.py

2024-01-01 Thread Simon Glass
On Fri, 15 Dec 2023 at 16:26, Heinrich Schuchardt wrote: > > Pytest 7.4.3 complains if a variable is used in a finally clause without > having been initialized before the try clause. > > Signed-off-by: Heinrich Schuchardt > --- > tools/binman/ftest.py | 20 +++- > 1 file changed,

Re: [PATCH 04/10] fdtgrep: Correct references to fdt_find_regions()

2024-01-01 Thread Simon Glass
The function name is actually fdtgrep_find_regions() so update the name in comments accordinging. Signed-off-by: Simon Glass --- tools/fdtgrep.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Applied to u-boot-dm/next, thanks!

Re: [PATCH 05/10] fdtgrep: Tidy up comment for h_include()

2024-01-01 Thread Simon Glass
Copy the comment from fdt_first_region() so that it is clear what value this function returns. Signed-off-by: Simon Glass --- tools/fdtgrep.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) Applied to u-boot-dm/next, thanks!

Re: [PATCH 02/10] fdtgrep: Tidy up a few type warnings and comments

2024-01-01 Thread Simon Glass
Align the code with the upstream version at fdt-tools which had a few tweaks before being applied. Signed-off-by: Simon Glass --- tools/fdtgrep.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) Applied to u-boot-dm/next, thanks!

Re: [PATCH 06/10] fdtgrep: Simplify code to inverting the match

2024-01-01 Thread Simon Glass
The code to invert the match in h_include() is a bit convoluted. Simplify it by using disp->invert only once. Signed-off-by: Simon Glass --- tools/fdtgrep.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) Applied to u-boot-dm/next, thanks!

Re: [PATCH 03/10] fdtgrep: Correct ordering of flags

2024-01-01 Thread Simon Glass
Two of the flags are out of order, so fix this. Also adjust the ordering of one flag in the main switch() Signed-off-by: Simon Glass --- tools/fdtgrep.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) Applied to u-boot-dm/next, thanks!

Re: [PATCH 07/10] fdtgrep: Move property checking into a function

2024-01-01 Thread Simon Glass
The h_include() function includes a piece which checks if a node contains a property being searched for. Move this into its own function to reduce the size of the h_include() function. Signed-off-by: Simon Glass --- tools/fdtgrep.c | 48 +++- 1 file c

Re: [PATCH 08/10] sandbox: Correct SPL condition for building devicetree

2024-01-01 Thread Simon Glass
With sandbox, CONFIG_SANDBOX is y so the current rule ends up building the devicetree for only those SPL builds where it is unwanted. Correct the condition. This allows sandbox_vpl to produce a u-boot-vpl.dtb file. Fixes: e7fb789612e ("sandbox: Remove OF_HOSTFILE") Signed-off-by: Simon Glass --

Re: [PATCH v2 10/10] Makefile: Use the fdtgrep -u flag

2024-01-01 Thread Simon Glass
On Tue, Dec 19, 2023 at 07:21:25AM -0700, Simon Glass wrote: > Use this flag so that the bootph binding is obeyed correctly. > > Add a comment about what is going on. > > Signed-off-by: Simon Glass > Fixes: https://source.denx.de/u-boot/custodians/u-boot-dm/-/issues/12 Reviewed-by: Tom Rini --

Re: [PATCH 09/10] fdtgrep: Allow propagating properties up to supernodes

2024-01-01 Thread Simon Glass
The existing bootph binding is defined such that properties in a subnode are also implied in the supernode also, as in this example: buttons { /* bootph,pre-ram is implied by btn1 */ compatible = "gpio-keys"; btn1 { bootph,pre-ram; gpios = <&gpio_a 3 0>;

Re: [PATCH] rockchip: rk3568: add support of all UART

2024-01-01 Thread Jonas Karlman
Hi Arseniy, On 2024-01-01 14:43, Arseniy Mescheryakov wrote: > Thanks for the answer. > I think developers should have the opportunity to configure UART from > the u-boot directly (via configuration) without any additional > proprietary blobs. Sure and it should already be possible using existing

Re: [PATCH] rockchip: rk3568: add support of all UART

2024-01-01 Thread Arseniy Mescheryakov
Thanks for the answer. I think developers should have the opportunity to configure UART from the u-boot directly (via configuration) without any additional proprietary blobs. There is https://github.com/rockchip-linux/u-boot/blob/next-dev/arch/arm/mach-rockchip/rk3568/rk3568.c , that has same fun

Re: [PATCH v5 08/12] smbios: Drop support for SMBIOS2 tables

2024-01-01 Thread Peter Robinson
On Sun, Dec 31, 2023 at 3:26 PM Simon Glass wrote: > > These tables are a pain since there is no way to handle memory above > 4GB. Use SMBIOS3 always. > > This should hopefully not create problems on x86 devices, since SMBIOS3 > was released seven years ago (2015). > > Signed-off-by: Simon Glass

[PATCH 1/1] efi_loader: provide tool to dump SMBIOS table

2024-01-01 Thread Heinrich Schuchardt
An EFI binary dmidump.efi is provided that can be used to check the SMBIOS table for consistency and to dump it as a file. The tool provides the following commands: check Check the SMBIOS table for consistency. exit Leave the tool. help Show available commands. save Save the SM

[PATCH 1/1] x86: all firmware tables must be paragraph aligned

2024-01-01 Thread Heinrich Schuchardt
On qemu-x86_64_defconfig the following was observed: => efidebug tables 000f0074 eb9d2d31-2d88-11d3-9a16-0090273fc14d SMBIOS table The SMBIOS configuration table does not point to a paragraph aligned address. The reason is that in write_tables() rom_addr is not aligned and copie

Re: [PATCH v5 12/12] efi: Correct smbios-table installation

2024-01-01 Thread Heinrich Schuchardt
On 1/1/24 01:37, Simon Glass wrote: Hi Heinrich, On Sun, Dec 31, 2023 at 9:27 AM Heinrich Schuchardt wrote: On 12/31/23 16:25, Simon Glass wrote: At present this code allocates memory when writing the tables and then unnecessarily adds another memory map when installing it. Adjust the code