[PATCH v3 4/4] configs: nuvoton: npcm8xx: disable CONFIG_SPI_FLASH_USE_4K_SECTORS

2023-10-11 Thread Jim Liu
disable this config to improve flash program time Signed-off-by: Jim Liu Changes for v2: - add commit message Changes for v3: - no change --- configs/arbel_evb_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/arbel_evb_defconfig b/configs/arbel_evb_defconfig index 8c3

[PATCH v3 3/4] board: nuvuton: arbel: fix incorrect ram size

2023-10-11 Thread Jim Liu
fix incorrect ram size of 4GB dram with ECC enabled Signed-off-by: Jim Liu Changes for v2: - add commit message Changes for v3: - no change --- board/nuvoton/arbel_evb/arbel_evb.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/board/nuvoton/arbel_evb

[PATCH v3 2/4] configs: npcm: support more uart baud rate

2023-10-11 Thread Jim Liu
add uart baud rate table to arbel(npcm8xx) and poleg(npcm7xx) Signed-off-by: Jim Liu Changes for v2: - add commit message Changes for v3: - modify CONFIG_SYS_BAUDRATE_TABLE --- include/configs/arbel.h | 5 - include/configs/poleg.h | 2 ++ 2 files changed, 6 insertions(+), 1 deletion

[PATCH v3 1/4] pinctrl: npcm8xx: add name for gpio function

2023-10-11 Thread Jim Liu
gpio function name is needed in the debug log Signed-off-by: Jim Liu Changes for v2: - add commit message Changes for v3: - no change --- drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c b/drivers/pinc

[PATCH v3 0/4] fix npcm bmc error

2023-10-11 Thread Jim Liu
1. add name for gpio pinctrl function 2. add baud rate table 3. fix ecc ram size 4. modify configs Jim Liu (4): pinctrl: npcm8xx: add name for gpio function configs: npcm: support more uart baud rate board: nuvuton: arbel: fix incorrect ram size configs: nuvoton: npcm8xx: disable CONFIG_SP

Re: [PATCH 14/26] net: bootp: Move port numbers to header

2023-10-11 Thread Heinrich Schuchardt
On 10/12/23 03:56, Sean Anderson wrote: These defines are useful when testing bootp. Signed-off-by: Sean Anderson Reviewed-by: Heinrich Schuchardt --- net/bootp.c | 3 --- net/bootp.h | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/net/bootp.c b/net/bootp.c ind

Re: [PATCH 13/26] net: Fix compiling SPL when fastboot is enabled

2023-10-11 Thread Heinrich Schuchardt
On 10/12/23 03:56, Sean Anderson wrote: When fastboot is enabled in U-Boot proper and SPL_NET is enabled, we will try to (unsuccessfully) reference it in SPL. Fix these linker errors by conditioning on SPL_UDP/TCP_FUNCTION_FASTBOOT. Signed-off-by: Sean Anderson --- net/Makefile | 4 ++-- ne

Re: [PATCH 12/26] fs: Compile in sandbox filesystem in SPL if it is enabled

2023-10-11 Thread Heinrich Schuchardt
On 10/12/23 03:56, Sean Anderson wrote: fs.c thinks that the sandbox filesystem is available if SANDBOX is enabled, but it is not in SPL. Compile it in SPL to avoid linker errors. Signed-off-by: Sean Anderson --- fs/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/Makefile b/

[PATCH V2 7/7] riscv: spl: andes: Move the DTB in front of kernel

2023-10-11 Thread Randolph
Originally, u-boot SPL will place the DTB directly after the kernel, but the size of the kernel does not include the BSS section, This means that u-boot SPL places the DTB in the kernel BSS section causing the DTB to be cleared by the kernel BSS initialisation. Moving the DTB in front of the kerne

[PATCH V2 6/7] andes: config: add riscv falcon mode for ae350 platform

2023-10-11 Thread Randolph
Fork from ae350_rv[32/64]_spl_[xip]_defconfig and append CONFIG_SPL_LOAD_FIT_OPENSBI_OS_BOOT=y Signed-off-by: Randolph --- configs/ae350_rv32_falcon_defconfig | 60 configs/ae350_rv32_falcon_xip_defconfig | 61 + configs/ae350_rv64_falcon_defc

[PATCH V2 4/7] Makefile: delete file *.itb when make clean

2023-10-11 Thread Randolph
Delete the output file *.itb Signed-off-by: Randolph --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 9d2e31e494..a7aa8c02a0 100644 --- a/Makefile +++ b/Makefile @@ -2165,7 +2165,7 @@ CLEAN_FILES += include/bmp_logo.h include/bmp_logo_dat

[PATCH V2 5/7] spl: riscv: add os type for next booting stage

2023-10-11 Thread Randolph
If SPL_LOAD_FIT_OPENSBI_OS_BOOT is enabled, the function spl_invoke_opensbi should change the target OS type to IH_OS_LINUX. OpenSBI will load the Linux image as the next boot stage. The os_takes_devicetree function returns a value of true or false depending on whether or not SPL_LOAD_FIT_OPENSBI_O

[PATCH V2 1/7] spl: riscv: opensbi: change the default os_type as varible

2023-10-11 Thread Randolph
In order to introduce the Opensbi OS boot mode, the next stage boot image of OpenSBI should be configurable. Signed-off-by: Randolph Reviewed-by: Simon Glass --- common/spl/spl_opensbi.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/common/spl/

[PATCH V2 3/7] riscv: dts: binman: add condition for opensbi os boot

2023-10-11 Thread Randolph
Add condition for OpenSBI OS boot mode, by default it is not enabled. By default, binman creates the output file u-boot.itb. If SPL_OPENSBI_OS_BOOT is enabled, linux.itb will be created after compilation instead of the default u-boot.itb. Signed-off-by: Randolph --- arch/riscv/dts/binman.dtsi |

[PATCH V2 2/7] riscv: kconfig: introduce SPL_LOAD_FIT_OPENSBI_OS_BOOT symbol

2023-10-11 Thread Randolph
Introduce common Kconfig symbol for riscv architecture. This symbol SPL_LOAD_FIT_OPENSBI_OS_BOOT is like falcon mode on ARM, the Falcon boot is a shortcut boot method for SD/eMMC targets. It skips the loading the RAM version U-Boot. Instead, it will loads the FIT image and boots directly to Linux.

[PATCH V2 0/7] riscv: spl: OpenSBI OS boot mode

2023-10-11 Thread Randolph
Introduce a shortcut boot mode for RISC-V. As we know, in ARM architecture has the Falcon mode to do the shortcut boot to the Linux kernel. (by enabling CONFIG_SPL_OS_BOOT) ARM Falcon mode boot flow would be as follows: u-boot SPL -> Linux kernel But for RISC-V, OpenSBI is required to allows the

Re: [PATCH] efi_loader: use well-known guid for auto-created boot option

2023-10-11 Thread Heinrich Schuchardt
On 10/12/23 07:31, Masahisa Kojima wrote: The boot option automatically created by efibootmgr is identified by the special guid appended in the optional data of boot option. The same mechanism is implemented in the EDK II reference implementation, it uses the different guid from the one currently

Re: [PATCH v4 1/8] binman: ti-secure: Add support for firewalling entities

2023-10-11 Thread Manorit Chawdhry
Hi Simon, On 11:54-20231011, Manorit Chawdhry wrote: > We can now firewall entities while loading them through our secure > entity TIFS, the required information should be present in the > certificate that is being parsed by TIFS. > > The following commit adds the suppor

Re: [PATCH v4 1/8] binman: ti-secure: Add support for firewalling entities

2023-10-11 Thread Manorit Chawdhry
Hi Simon, On 20:41-20231011, Simon Glass wrote: > Hi Manorit, > > On Tue, 10 Oct 2023 at 23:25, Manorit Chawdhry wrote: > > > > We can now firewall entities while loading them through our secure > > entity TIFS, the required information should be present in the &g

[PATCH] riscv: andes: Rearrange Andes PLICSW to single-bit-per-hart strategy

2023-10-11 Thread Randolph
Source hart information is not necessary in IPI, so we could use single-bit-per-hart strategy to rearrange PLICSW mapping. Bit 0 of Interrupt Pending Bits is hardwired to 0. Therefore, we use bit 1 to send IPI to hart 0, bit 2 to hart 1, ..., and so on. Signed-off-by: Randolph --- arch/riscv/li

[PATCH] efi_loader: use well-known guid for auto-created boot option

2023-10-11 Thread Masahisa Kojima
The boot option automatically created by efibootmgr is identified by the special guid appended in the optional data of boot option. The same mechanism is implemented in the EDK II reference implementation, it uses the different guid from the one currently U-Boot uses. The guid indicating auto-creat

Re: [PATCH 01/26] spl: legacy: Fix referencing _image_binary_end

2023-10-11 Thread Sean Anderson
On 10/11/23 23:41, Simon Glass wrote: On Wed, 11 Oct 2023 at 18:56, Sean Anderson wrote: On non-arm architectures, _image_binary_end is defined as a ulong and not a char[]. Dereference it when accessing it, which is correct for both. Is 'dereference' the right word? Yeah... "Take the addr

Re: [PATCH 03/26] spl: fit: Fix entry point for SPL_LOAD_FIT_FULL

2023-10-11 Thread Sean Anderson
On 10/11/23 23:41, Simon Glass wrote: On Wed, 11 Oct 2023 at 18:56, Sean Anderson wrote: The entry point is not always the same as the load address. Use the value of the entrypoint property if it exists and is nonzero (following the example of spl_load_simple_fit). Fixes: 8a9dc16e4d0 ("spl: A

Re: [PATCH 09/26] spl: Allow enabling SPL_OF_REAL and SPL_OF_PLATDATA at the same time

2023-10-11 Thread Sean Anderson
On 10/11/23 23:41, Simon Glass wrote: Hi Sean, On Wed, 11 Oct 2023 at 18:56, Sean Anderson wrote: Sandbox unit tests in U-Boot proper load a test device tree to have some devices to work with. In order to do the same in SPL, we must enable SPL_OF_REAL. However, we already have SPL_OF_PLATDATA

Re: [PATCH 16/26] spl: Don't cache devices when UNIT_TEST is enabled

2023-10-11 Thread Sean Anderson
On 10/11/23 23:41, Simon Glass wrote: Hi Sean, On Wed, 11 Oct 2023 at 18:56, Sean Anderson wrote: Several SPL functions try to avoid performing initialization twice by caching devices. This is fine for regular boot, but does not work with UNIT_TEST, since all devices are torn down after each

Re: [PATCH 25/26] test: spl: Add a test for the NOR load method

2023-10-11 Thread Sean Anderson
On 10/11/23 23:41, Simon Glass wrote: Hi Sean, On Wed, 11 Oct 2023 at 18:57, Sean Anderson wrote: Add a test for the NOR load method. Since NOR is memory-mapped we can substitute a buffer instead. The only major complication is testing LZMA decompression. It's too complex to implement LZMA c

Re: [PATCH 23/26] test: spl: Add a test for the MMC load method

2023-10-11 Thread Sean Anderson
On 10/11/23 23:41, Simon Glass wrote: Hi Sean, On Wed, 11 Oct 2023 at 18:56, Sean Anderson wrote: Add a test for the MMC load method. This shows the general shape of tests to come: The main test function calls do_spl_test_load with an appropriate callback to write the image to the medium. Si

Re: [PATCH 21/26] test: spl: Add functions to create filesystems

2023-10-11 Thread Sean Anderson
On 10/11/23 23:41, Simon Glass wrote: Hi Sean, On Wed, 11 Oct 2023 at 18:56, Sean Anderson wrote: Add some functions for creating fat/ext2 filesystems with a single file and a test for them. Filesystems require block devices, and it is easiest to just use MMC for this. To get an MMC, we must

Re: [PATCH 24/26] test: spl: Add a test for the NET load method

2023-10-11 Thread Sean Anderson
On 10/11/23 23:41, Simon Glass wrote: On Wed, 11 Oct 2023 at 18:56, Sean Anderson wrote: Add a test for loading U-Boot over TFTP. As with other sandbox net routines, we need to initialize our packets manually since things like net_set_ether and net_set_udp_header always use "our" addresses. We

Re: [PATCH 20/26] test: spl: Add functions to create images

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 18:56, Sean Anderson wrote: > > This add some basic functions to create images, and a test for said > functions. This is not intended to be a test of the image parsing > functions, but rather a framework for creating minimal images for testing > load methods. That said, it d

Re: [PATCH] riscv: binman: Fix compilation error

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 08:30, Mayuresh Chitale wrote: > > Some platforms may not have any DDR memory below 4G and for such platforms > the TEXT_BASE and LOAD addresses etc are all 64 bit addresses due to > which the u-boot build fails with below error: > > u-boot/arch/riscv/dts/binman.dtsi:30.14-2

Re: [PATCH v5] bootstd: sata: Add bootstd support for ahci sata

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 13:27, Tony Dinh wrote: > > Add ahci sata bootdev and corresponding hunting function. > > Signed-off-by: Tony Dinh > --- > > Changes in v5: > - In bootmeth_script script_boot(), it's unnecessary to check for ret so > remove it. While we're here, also initialize ret in decla

Re: [PATCH v2 6/6] binman: capsule: Add support for generating EFI empty capsules

2023-10-11 Thread Simon Glass
On Tue, 10 Oct 2023 at 02:12, Sughosh Ganu wrote: > > Add support in binman for generating EFI empty capsules. These > capsules are used in the FWU A/B update feature. Also add test cases > in binman for the corresponding code coverage. > > Signed-off-by: Sughosh Ganu > --- > Changes since V1: >

Re: coreboot 4.11 + U-boot master

2023-10-11 Thread Simon Glass
Hi Jay, On Wed, 11 Oct 2023 at 19:03, Jay Talbott wrote: > > Hi Simon, > > > > So I gave it a whirl to do a build of coreboot (on the 4.11 branch) with the > U-boot payload, specifying U-boot master to get the latest version of U-boot. > > > > Unfortunately, it failed to build the payload: > > >

Re: [PATCH 3/5] smbios: Use SMBIOS 3.0 to support an address above 4GB

2023-10-11 Thread Simon Glass
Hi Heinrich, On Sun, 8 Oct 2023 at 19:48, Heinrich Schuchardt wrote: > > On 10/8/23 23:36, Simon Glass wrote: > > When the SMBIOS table is written to an address above 4GB a 32-bit table > > address is not large enough. > > > > Use an SMBIOS3 table in that case. > > > > Signed-off-by: Simon Glass

Re: [PATCH v6 02/14] firmware: scmi: use a protocol's own channel if assigned

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 03:07, AKASHI Takahiro wrote: > > SCMI specification allows any protocol to have its own channel for > the transport. While the current SCMI driver may assign its channel > from a device tree, the core function, devm_scmi_process_msg(), doesn't > use a protocol's channel, bu

Re: [PATCH 19/26] test: spl: Fix spl_test_load not failing if fname doesn't exist

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 18:56, Sean Anderson wrote: > > Returning a negative value from a unit test doesn't automatically fail the > test. We have to fail an assertion. Modify the test to do so. > > This now causes the test to count as a failure on VPL. This is because the > fname of SPL (and U-Bo

Re: [PATCH v2 5/6] btool: mkeficapsule: Add support for EFI empty capsule generation

2023-10-11 Thread Simon Glass
On Tue, 10 Oct 2023 at 02:12, Sughosh Ganu wrote: > > Add a method to the mkeficapsule bintool to generate empty > capsules. These are capsules needed for the FWU A/B update feature. > > Signed-off-by: Sughosh Ganu > --- > Changes since V1: > * Use a single boolean value to indicate the generatio

Re: [PATCH 23/26] test: spl: Add a test for the MMC load method

2023-10-11 Thread Simon Glass
Hi Sean, On Wed, 11 Oct 2023 at 18:56, Sean Anderson wrote: > > Add a test for the MMC load method. This shows the general shape of tests > to come: The main test function calls do_spl_test_load with an appropriate > callback to write the image to the medium. > > Signed-off-by: Sean Anderson > -

Re: [PATCH 16/26] spl: Don't cache devices when UNIT_TEST is enabled

2023-10-11 Thread Simon Glass
Hi Sean, On Wed, 11 Oct 2023 at 18:56, Sean Anderson wrote: > > Several SPL functions try to avoid performing initialization twice by > caching devices. This is fine for regular boot, but does not work with > UNIT_TEST, since all devices are torn down after each test. Disable caching > so we don'

Re: [PATCH 17/26] spl: Use map_sysmem where appropriate

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 18:56, Sean Anderson wrote: > > All "physical" addresses in SPL must be converted to virtual addresses > before access in order for sandbox to work. Add some calls to map_sysmem in > appropriate places. We do not generally call unmap_sysmem, since we need > the image memory

Re: [PATCH v2 6/9] ufs: Allow mmio registers on the PCI bus

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 06:16, Bin Meng wrote: > > Check if the UFS controller is on the PCI bus, and get its register > base address accordingly. > > Signed-off-by: Bin Meng > --- > > (no changes since v1) > > drivers/ufs/ufs.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) >

Re: [PATCH 02/26] spl: nor: Don't allocate header on stack

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 18:56, Sean Anderson wrote: > > spl_image_info.name contains a reference to legacy_img_hdr. If we allocate > the latter on the stack, it will be clobbered after we return. This was > addressed for NAND back in 06377c5a1fc ("spl: spl_legacy: Fix NAND boot on > OMAP3 BeagleBoa

Re: [PATCH 25/26] test: spl: Add a test for the NOR load method

2023-10-11 Thread Simon Glass
Hi Sean, On Wed, 11 Oct 2023 at 18:57, Sean Anderson wrote: > > Add a test for the NOR load method. Since NOR is memory-mapped we can > substitute a buffer instead. The only major complication is testing LZMA > decompression. It's too complex to implement LZMA compression in a test, > so we just

Re: [PATCH 03/26] spl: fit: Fix entry point for SPL_LOAD_FIT_FULL

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 18:56, Sean Anderson wrote: > > The entry point is not always the same as the load address. Use the value > of the entrypoint property if it exists and is nonzero (following the > example of spl_load_simple_fit). > > Fixes: 8a9dc16e4d0 ("spl: Add full fitImage support") > Si

Re: [PATCH v2 5/9] pci_ids: Add Red Hat vendor and device IDs

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 06:16, Bin Meng wrote: > > Red Hat, Inc. donates a part of its device ID range [1] to QEMU, > to be used for virtual devices. This commit adds several typical > devices that are useful in U-Boot. > > [1] https://www.qemu.org/docs/master/specs/pci-ids.html > > Signed-off-by:

Re: [PATCH 14/26] net: bootp: Move port numbers to header

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 18:56, Sean Anderson wrote: > > These defines are useful when testing bootp. > > Signed-off-by: Sean Anderson > --- > > net/bootp.c | 3 --- > net/bootp.h | 3 +++ > 2 files changed, 3 insertions(+), 3 deletions(-) > Reviewed-by: Simon Glass

Re: [PATCH 18/26] test: spl: Split tests up and use some configs

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 18:56, Sean Anderson wrote: > > In order to make adding new spl unit tests easier, especially when they may > have many dependencies, add some Kconfigs for the existing image test. > Split it into the parts which are generic (such as callbacks) and the > test-specific parts.

Re: [PATCH 00/26] test: spl: Test some load methods

2023-10-11 Thread Simon Glass
Hi Sean, On Wed, 11 Oct 2023 at 18:56, Sean Anderson wrote: > > This series adds some tests for various SPL load methods, with the intent of > helping debug v6 of [1]. With that in mind, notable omissions include NAND and > ROMAPI, which both lack sandbox implementations, and OS_BOOT, which I hav

Re: [PATCH 26/26] test: spl: Add a test for the SPI load method

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 18:57, Sean Anderson wrote: > > Add test for the SPI load method. This one is pretty straightforward. We > can't enable FIT_EXTERNAL with LOAD_FIT_FULL because spl_spi_load_image > doesn't know the total image size and has to guess from fdt_totalsize. This > doesn't include

Re: [PATCH v4 2/8] binman: ftest: Add test for ti-secure firewall node

2023-10-11 Thread Simon Glass
On Tue, 10 Oct 2023 at 23:25, Manorit Chawdhry wrote: > > Add test for TI firewalling node in ti-secure. > > Signed-off-by: Manorit Chawdhry > --- > tools/binman/ftest.py | 22 + > tools/binman/test/319_ti_secure_firewall.dts | 28 > +++

Re: [PATCH v2 4/9] cmd: ufs: Correct the help text

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 06:16, Bin Meng wrote: > > Remove the additional space and use "sub-system" for consistency > with other commands like "scsi" and "usb". > > Signed-off-by: Bin Meng > --- > > (no changes since v1) > > cmd/ufs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Revie

Re: [PATCH v2 9/9] qemu: riscv: Enable UFS support

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 06:16, Bin Meng wrote: > > This enables UFS support for QEMU RISC-V 'virt' machine. > > Signed-off-by: Bin Meng > > --- > > (no changes since v1) > > board/emulation/qemu-riscv/Kconfig | 2 ++ > doc/board/emulation/qemu-riscv.rst | 8 +++- > 2 files changed, 9 insertio

Re: [PATCH v2 7/9] ufs: Add a PCI based UFS controller driver

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 06:16, Bin Meng wrote: > > This adds a simple PCI based UFS controller driver with a QEMU > emulated UFS controller on the PCI bus. > > Requiring QEMU v8.2+. > > Signed-off-by: Bin Meng > > --- > > Changes in v2: > - fix a build warning > > drivers/ufs/Kconfig | 11 +

Re: [PATCH v2 8/9] ufs: Handle UFS 3.1 controllers

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 06:16, Bin Meng wrote: > > Extend the version check to handle UFS 3.1 controllers as well. > Tested on QEMU emulated UFS 3.1 controller. > > Signed-off-by: Bin Meng > --- > > (no changes since v1) > > drivers/ufs/ufs.c | 3 ++- > drivers/ufs/ufs.h | 1 + > 2 files changed,

Re: [PATCH 12/26] fs: Compile in sandbox filesystem in SPL if it is enabled

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 18:56, Sean Anderson wrote: > > fs.c thinks that the sandbox filesystem is available if SANDBOX is enabled, > but it is not in SPL. Compile it in SPL to avoid linker errors. > > Signed-off-by: Sean Anderson > --- > > fs/Makefile | 1 + > 1 file changed, 1 insertion(+) > R

Re: [PATCH v2 3/6] binman: capsule: Remove superfluous [address,size]-cells properties

2023-10-11 Thread Simon Glass
On Tue, 10 Oct 2023 at 02:12, Sughosh Ganu wrote: > > The #address-cells and #size-cells are not needed for running the > capsule generation binman tests. Remove the superfluous properties. > > Signed-off-by: Sughosh Ganu > --- > Changes since V1: > * New patch based on review comment from Simon.

Re: [PATCH v2 4/6] binman: capsule: Use dumped capsule header contents for verification

2023-10-11 Thread Simon Glass
On Tue, 10 Oct 2023 at 02:12, Sughosh Ganu wrote: > > The various fields of a generated capsule are currently verified > through hard-coded offsets. Use the dump-capsule feature for dumping > the capsule header contents and use those for capsule verification. > > Signed-off-by: Sughosh Ganu > ---

Re: [PATCH v2 1/9] ufs: Correct the UFS terminlogy

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 06:16, Bin Meng wrote: > > UFS stands for Universal Flash Storage, not Subsytem. > > Signed-off-by: Bin Meng > --- > > (no changes since v1) > > cmd/Kconfig | 2 +- > drivers/ufs/ufs-uclass.c | 2 +- > drivers/ufs/ufs.c| 2 +- > 3 files changed, 3 inse

Re: [PATCH v2 3/9] cmd: kconfig: Make ufs prompt look similar to other commands

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 06:16, Bin Meng wrote: > > At present the 'ufs' command prompt does not look similar like other > commands. Update it. > > Signed-off-by: Bin Meng > --- > > (no changes since v1) > > cmd/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Simon

Re: [PATCH v2 2/9] ufs: Add a line feed to the end of some dev_xxx() messages

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 06:16, Bin Meng wrote: > > Add a line feed to improve readability of some dev_xxx() messages. > > Signed-off-by: Bin Meng > --- > > (no changes since v1) > > drivers/ufs/ufs.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) Reviewed-by: Simon Glas

Re: [PATCH 24/26] test: spl: Add a test for the NET load method

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 18:56, Sean Anderson wrote: > > Add a test for loading U-Boot over TFTP. As with other sandbox net > routines, we need to initialize our packets manually since things like > net_set_ether and net_set_udp_header always use "our" addresses. We use > BOOTP instead of DHCP, sinc

Re: [PATCH 1/9] ufs: Correct the UFS terminlogy

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 06:05, Bin Meng wrote: > > UFS stands for Universal Flash Storage, not Subsytem. > > Signed-off-by: Bin Meng > --- > > cmd/Kconfig | 2 +- > drivers/ufs/ufs-uclass.c | 2 +- > drivers/ufs/ufs.c| 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-)

Re: [PATCH 01/26] spl: legacy: Fix referencing _image_binary_end

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 18:56, Sean Anderson wrote: > > On non-arm architectures, _image_binary_end is defined as a ulong and not a > char[]. Dereference it when accessing it, which is correct for both. Is 'dereference' the right word? > > Fixes: 1b8a1be1a1f ("spl: spl_legacy: Fix spl_end address

Re: [PATCH 09/26] spl: Allow enabling SPL_OF_REAL and SPL_OF_PLATDATA at the same time

2023-10-11 Thread Simon Glass
Hi Sean, On Wed, 11 Oct 2023 at 18:56, Sean Anderson wrote: > > Sandbox unit tests in U-Boot proper load a test device tree to have some > devices to work with. In order to do the same in SPL, we must enable > SPL_OF_REAL. However, we already have SPL_OF_PLATDATA enabled. When > generating platda

Re: [PATCH] mmc: pci: Drop the superfluous cast

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 04:05, Bin Meng wrote: > > dm_pci_map_bar() return a value of (void *) already, hence no need > to cast it again before assigning to host->ioaddr. > > Signed-off-by: Bin Meng > --- > > drivers/mmc/pci_mmc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Rev

Re: [PATCH 10/26] lib: acpi: Fix linking SPL when ACPIGEN is enabled

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 18:56, Sean Anderson wrote: > > lib/acpi/acpigen.o is only compiled into SPL when SPL_ACPIGEN is enabled. > Update several files which reference these functions accordingly. > > Signed-off-by: Sean Anderson > --- > > drivers/core/root.c | 2 +- > drivers/i2c/Makefile | 2

Re: [PATCH 21/26] test: spl: Add functions to create filesystems

2023-10-11 Thread Simon Glass
Hi Sean, On Wed, 11 Oct 2023 at 18:56, Sean Anderson wrote: > > Add some functions for creating fat/ext2 filesystems with a single file and > a test for them. Filesystems require block devices, and it is easiest to > just use MMC for this. To get an MMC, we must also pull in the test device > tre

Re: [PATCH v3 2/3] dt-bindings: mtd: binman-partition: Add binman compatibles

2023-10-11 Thread Simon Glass
Hi Rob, On Tue, 10 Oct 2023 at 11:06, Rob Herring wrote: > > On Mon, Oct 09, 2023 at 04:02:40PM -0600, Simon Glass wrote: > > Hi Rob, > > > > On Mon, 9 Oct 2023 at 15:18, Rob Herring wrote: > > > > > > > > > On Mon, 09 Oct 2023 14:10:00 -0600, Simon Glass wrote: > > > > Add two compatible for bi

Re: [PATCH 22/26] test: spl: Add a test for spl_blk_load_image

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 18:56, Sean Anderson wrote: > > Add a test for spl_blk_load_image, currently used only by NVMe. Because > there is no sandbox NVMe driver, just use MMC instead. Avoid falling back > to raw images to make failures more obvious. > > Signed-off-by: Sean Anderson > --- > > con

Re: [PATCH 13/26] net: Fix compiling SPL when fastboot is enabled

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 18:56, Sean Anderson wrote: > > When fastboot is enabled in U-Boot proper and SPL_NET is enabled, we will > try to (unsuccessfully) reference it in SPL. Fix these linker errors by > conditioning on SPL_UDP/TCP_FUNCTION_FASTBOOT. > > Signed-off-by: Sean Anderson > --- > > n

Re: [PATCH 11/26] fs: ext4: Fix building ext4 in SPL if write is enabled

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 18:56, Sean Anderson wrote: > > If EXT4_WRITE is enabled, write capabilities will be compiled into SPL, but > not CRC16. Add an option to enable CRC16 to avoid linker errors. > > Signed-off-by: Sean Anderson > --- > > common/spl/Kconfig | 1 + > lib/Kconfig| 6

Re: [PATCH 15/26] net: bootp: Fall back to BOOTP from DHCP when unit testing

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 18:56, Sean Anderson wrote: > > If we sent a DHCP packet and get a BOOTP response from the server, we > shouldn't try to send a DHCPREQUEST packet, since it won't be DHCPACKed. > Transition straight to BIND. This is only enabled for UNIT_TEST to avoid > bloat, since I suspec

Re: [PATCH] net: e1000: Drop e1000_eth_ids[]

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 03:59, Bin Meng wrote: > > e1000_eth_ids holds compatible strings for e1000 devices, but it > is meaningless as e1000 is a PCI device and there is no such > compatible string assigned to e1000 by the DT bindings community. > > Drop it. > > Signed-off-by: Bin Meng > --- > >

Re: [PATCH v4 1/8] binman: ti-secure: Add support for firewalling entities

2023-10-11 Thread Simon Glass
Hi Manorit, On Tue, 10 Oct 2023 at 23:25, Manorit Chawdhry wrote: > > We can now firewall entities while loading them through our secure > entity TIFS, the required information should be present in the > certificate that is being parsed by TIFS. > > The following commit adds the support to enable

Re: [PATCH v2 2/5] configs: npcm: support more uart baud rate

2023-10-11 Thread Jim Liu
Hi Tom Thanks for your review. Google and other customers need to change baud rate so I added this table. I will modify the name to CFG_SYS_BAUDRATE_TABLE. Best regards, Jim On Wed, Oct 11, 2023 at 7:20 AM Tom Rini wrote: > > On Wed, Oct 11, 2023 at 04:45:30PM +0800, Jim Liu wrote: > > add ua

Re: [PATCH 5/4] mkimage: update man page and -h output

2023-10-11 Thread Simon Glass
Hi, On Wed, 11 Oct 2023 at 12:33, Tom Rini wrote: > > On Wed, Oct 11, 2023 at 09:07:11PM +0200, Rasmus Villemoes wrote: > > On 11/10/2023 20.37, Tom Rini wrote: > > > On Thu, Sep 28, 2023 at 10:02:57AM +0200, Rasmus Villemoes wrote: > > > > > >> The man page correctly said that -B was ignored wit

Re: [PATCH] ARM: stm32: Power cycle Buck3 in reset on DHSOM

2023-10-11 Thread Marek Vasut
On 8/16/23 15:28, Marek Vasut wrote: On 8/16/23 15:22, Patrice CHOTARD wrote: On 7/10/23 23:43, Marek Vasut wrote: On 6/17/23 02:36, Marek Vasut wrote: On 6/16/23 15:04, Patrick DELAUNAY wrote: Hi, Hi, [   39.426015] Disabling non-boot CPUs ... [   39.448635] Retrying again to check for

Re: [PATCH 4/4] usb: dwc3-generic: Use combined glue and ctrl node for RK3588

2023-10-11 Thread Kever Yang
On 2023/10/11 06:23, Jonas Karlman wrote: Like Rockchip RK3328 and RK3568, the RK3588 also have single node to represent the glue and ctrl for USB 3.0. Use rk_ops as driver data to select correct ctrl node for RK3588 DWC3. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kev

Re: [PATCH 5/4] mkimage: update man page and -h output

2023-10-11 Thread Sean Anderson
Hi Rasmus, On 10/11/23 15:07, Rasmus Villemoes wrote: On 11/10/2023 20.37, Tom Rini wrote: On Thu, Sep 28, 2023 at 10:02:57AM +0200, Rasmus Villemoes wrote: The man page correctly said that -B was ignored without -E, while the `mkimage -h` output suggested otherwise. Now that -B can actually

Re: [PATCH 2/4] rockchip: rk3588-rock-5b: Enable support for PCIe SATA cards

2023-10-11 Thread Kever Yang
On 2023/10/11 06:23, Jonas Karlman wrote: Enable support for PCIe SATA cards and the on-board SATA controller. This also revert use of CONFIG_PCI_INIT_R in order to speed up boot from eMMC or SD-cards. Standard boot will initialize pci after faster boot media have been enumerated. Signed-off-

Re: [PATCH 1/4] rockchip: rk3588: Sync device tree from linux maintainer tree

2023-10-11 Thread Kever Yang
On 2023/10/11 06:23, Jonas Karlman wrote: Sync rk3588 device tree from linux maintainer tree (v6.7-armsoc/dts64). Adds PCIe nodes to rk3588-evb1-v10 and rk3588-rock-5b boards. Also remove includes from u-boot.dtsi-files that is no longer needed. Linux commits: 42145b7a8235 ("arm64: dts: rockch

[PATCH 26/26] test: spl: Add a test for the SPI load method

2023-10-11 Thread Sean Anderson
Add test for the SPI load method. This one is pretty straightforward. We can't enable FIT_EXTERNAL with LOAD_FIT_FULL because spl_spi_load_image doesn't know the total image size and has to guess from fdt_totalsize. This doesn't include external data, so loading it will fail. Signed-off-by: Sean A

[PATCH 18/26] test: spl: Split tests up and use some configs

2023-10-11 Thread Sean Anderson
In order to make adding new spl unit tests easier, especially when they may have many dependencies, add some Kconfigs for the existing image test. Split it into the parts which are generic (such as callbacks) and the test-specific parts. Signed-off-by: Sean Anderson --- test/Kconfig

[PATCH 16/26] spl: Don't cache devices when UNIT_TEST is enabled

2023-10-11 Thread Sean Anderson
Several SPL functions try to avoid performing initialization twice by caching devices. This is fine for regular boot, but does not work with UNIT_TEST, since all devices are torn down after each test. Disable caching so we don't use stale devices. Signed-off-by: Sean Anderson --- common/spl/spl

[PATCH 20/26] test: spl: Add functions to create images

2023-10-11 Thread Sean Anderson
This add some basic functions to create images, and a test for said functions. This is not intended to be a test of the image parsing functions, but rather a framework for creating minimal images for testing load methods. That said, it does do an OK job at finding bugs in the image parsing directly

[PATCH 21/26] test: spl: Add functions to create filesystems

2023-10-11 Thread Sean Anderson
Add some functions for creating fat/ext2 filesystems with a single file and a test for them. Filesystems require block devices, and it is easiest to just use MMC for this. To get an MMC, we must also pull in the test device tree. Signed-off-by: Sean Anderson --- arch/sandbox/cpu/start.c

Re: [PATCH 00/26] test: spl: Test some load methods

2023-10-11 Thread Sean Anderson
On 10/11/23 21:56, Sean Anderson wrote: This series adds some tests for various SPL load methods, with the intent of helping debug v6 of [1]. With that in mind, notable omissions include NAND and ROMAPI, which both lack sandbox implementations, and OS_BOOT, which I have deferred due to its comple

[PATCH 15/26] net: bootp: Fall back to BOOTP from DHCP when unit testing

2023-10-11 Thread Sean Anderson
If we sent a DHCP packet and get a BOOTP response from the server, we shouldn't try to send a DHCPREQUEST packet, since it won't be DHCPACKed. Transition straight to BIND. This is only enabled for UNIT_TEST to avoid bloat, since I suspect the number of BOOTP servers in the wild is vanishingly small

[PATCH 08/26] Move i.MX8 container image loading support to common/spl

2023-10-11 Thread Sean Anderson
To facilitate testing loading i.MX8 container images, move the parse-container code to common/spl. Signed-off-by: Sean Anderson --- MAINTAINERS| 1 + arch/arm/mach-imx/Kconfig | 13 - arch/arm/mach-imx/Makefile

[PATCH 14/26] net: bootp: Move port numbers to header

2023-10-11 Thread Sean Anderson
These defines are useful when testing bootp. Signed-off-by: Sean Anderson --- net/bootp.c | 3 --- net/bootp.h | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/net/bootp.c b/net/bootp.c index 8b1a4ae2ef8..2053cce88c6 100644 --- a/net/bootp.c +++ b/net/bootp.c @@ -41,9 +41

[PATCH 11/26] fs: ext4: Fix building ext4 in SPL if write is enabled

2023-10-11 Thread Sean Anderson
If EXT4_WRITE is enabled, write capabilities will be compiled into SPL, but not CRC16. Add an option to enable CRC16 to avoid linker errors. Signed-off-by: Sean Anderson --- common/spl/Kconfig | 1 + lib/Kconfig| 6 ++ lib/Makefile | 1 + 3 files changed, 8 insertions(+) diff

[PATCH 24/26] test: spl: Add a test for the NET load method

2023-10-11 Thread Sean Anderson
Add a test for loading U-Boot over TFTP. As with other sandbox net routines, we need to initialize our packets manually since things like net_set_ether and net_set_udp_header always use "our" addresses. We use BOOTP instead of DHCP, since DHCP has a tag/length-based format which is harder to parse.

[PATCH 22/26] test: spl: Add a test for spl_blk_load_image

2023-10-11 Thread Sean Anderson
Add a test for spl_blk_load_image, currently used only by NVMe. Because there is no sandbox NVMe driver, just use MMC instead. Avoid falling back to raw images to make failures more obvious. Signed-off-by: Sean Anderson --- configs/sandbox_noinst_defconfig | 2 ++ test/image/Kconfig

[PATCH 25/26] test: spl: Add a test for the NOR load method

2023-10-11 Thread Sean Anderson
Add a test for the NOR load method. Since NOR is memory-mapped we can substitute a buffer instead. The only major complication is testing LZMA decompression. It's too complex to implement LZMA compression in a test, so we just include some pre-compressed data. Signed-off-by: Sean Anderson ---

[PATCH 19/26] test: spl: Fix spl_test_load not failing if fname doesn't exist

2023-10-11 Thread Sean Anderson
Returning a negative value from a unit test doesn't automatically fail the test. We have to fail an assertion. Modify the test to do so. This now causes the test to count as a failure on VPL. This is because the fname of SPL (and U-Boot) is generated with make_exec in os_jump_to_image. The origin

[PATCH 23/26] test: spl: Add a test for the MMC load method

2023-10-11 Thread Sean Anderson
Add a test for the MMC load method. This shows the general shape of tests to come: The main test function calls do_spl_test_load with an appropriate callback to write the image to the medium. Signed-off-by: Sean Anderson --- configs/sandbox_noinst_defconfig | 2 + include/spl.h

[PATCH 09/26] spl: Allow enabling SPL_OF_REAL and SPL_OF_PLATDATA at the same time

2023-10-11 Thread Sean Anderson
Sandbox unit tests in U-Boot proper load a test device tree to have some devices to work with. In order to do the same in SPL, we must enable SPL_OF_REAL. However, we already have SPL_OF_PLATDATA enabled. When generating platdata from a devicetree, it is expected that we will not need devicetree ac

[PATCH 13/26] net: Fix compiling SPL when fastboot is enabled

2023-10-11 Thread Sean Anderson
When fastboot is enabled in U-Boot proper and SPL_NET is enabled, we will try to (unsuccessfully) reference it in SPL. Fix these linker errors by conditioning on SPL_UDP/TCP_FUNCTION_FASTBOOT. Signed-off-by: Sean Anderson --- net/Makefile | 4 ++-- net/net.c| 4 ++-- 2 files changed, 4 inse

[PATCH 10/26] lib: acpi: Fix linking SPL when ACPIGEN is enabled

2023-10-11 Thread Sean Anderson
lib/acpi/acpigen.o is only compiled into SPL when SPL_ACPIGEN is enabled. Update several files which reference these functions accordingly. Signed-off-by: Sean Anderson --- drivers/core/root.c | 2 +- drivers/i2c/Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/d

  1   2   3   >