[PATCH v3 6/6] sysreset: implement PALMAS sysreset functions

2023-10-02 Thread Svyatoslav Ryhel
PALMAS PMIC family has embedded poweroff function used by some device to initiane device power off. Implement it as sysreset driver. Signed-off-by: Svyatoslav Ryhel --- drivers/power/pmic/palmas.c| 33 +-- drivers/sysreset/Kconfig | 7 drivers/sysreset/Mak

[PATCH v3 5/6] sysreset: implement TPS65910 sysreset functions

2023-10-02 Thread Svyatoslav Ryhel
TPS65910/TPS65911 PMICs have embedded power control functions used by some device to initiane device power off. Implement it as sysreset driver. Signed-off-by: Svyatoslav Ryhel --- drivers/power/pmic/pmic_tps65910_dm.c | 12 +- drivers/sysreset/Kconfig | 8 drivers/sysrese

[PATCH v3 4/6] sysreset: implement TPS80031 sysreset functions

2023-10-02 Thread Svyatoslav Ryhel
TPS80031/TPS80032 PMICs have embedded power control functions used by some device to initiane device power off. Implement it as sysreset driver. Signed-off-by: Svyatoslav Ryhel --- drivers/power/pmic/tps80031.c| 12 +++- drivers/sysreset/Kconfig | 8 ++ drivers/sysre

[PATCH v3 3/6] sysreset: implement MAX77663 sysreset functions

2023-10-02 Thread Svyatoslav Ryhel
MAX77663 PMIC has embedded poweroff function used by some device to initiane device power off. Implement it as sysreset driver. Signed-off-by: Svyatoslav Ryhel --- drivers/power/pmic/max77663.c| 12 ++- drivers/sysreset/Kconfig | 7 drivers/sysreset/Makefile

[PATCH v3 2/6] arm: mach-tegra: enable sysreset driver

2023-10-02 Thread Svyatoslav Ryhel
Signed-off-by: Svyatoslav Ryhel --- arch/arm/mach-tegra/Kconfig | 3 +++ arch/arm/mach-tegra/pmc.c | 9 - 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig index 464bd0798f..453f94bcf2 100644 --- a/arch/arm/mach-tegr

[PATCH v3 0/6] Implement proper sysreset ability for Tegra SoCs and some PMICs

2023-10-02 Thread Svyatoslav Ryhel
This patchset converts do_reset from mach-tegra function to a proper sysreset dm driver with saving all its previous abilities. Additionally implement do_poweroff (since Tegra sysreset can only reset) by making sysreset drivers for the most widely used PMICs on Tegra devices. This includes sysrese

[PATCH v3 1/6] sysreset: tegra: create arch specific sysreset driver

2023-10-02 Thread Svyatoslav Ryhel
Tegra uses built in Power Management Controller (PMC) to perform CPU reset. Code to perform this was located in mach-tegra, so lest create DM driver to handle this. Signed-off-by: Svyatoslav Ryhel --- drivers/sysreset/Kconfig | 6 drivers/sysreset/Makefile | 1 + drivers/

[PATCH v3 11/16] configs: grouper: drop I2C_MUX

2023-10-02 Thread Svyatoslav Ryhel
Signed-off-by: Svyatoslav Ryhel --- configs/grouper_common_defconfig | 2 -- 1 file changed, 2 deletions(-) diff --git a/configs/grouper_common_defconfig b/configs/grouper_common_defconfig index e90cae2bb8..ead0f970d6 100644 --- a/configs/grouper_common_defconfig +++ b/configs/grouper_common_def

[PATCH v3 12/16] ARM: tegra114: enable base voltages setup from board

2023-10-02 Thread Svyatoslav Ryhel
Tegra 4, same as Tegra 3, requires configuration of CPU and CORE voltages in the SPL stage to boot properly. Expose function to be able perform this configuration in the SPL section of the device board. Tested-by: Svyatoslav Ryhel # ASUS TF701T Signed-off-by: Svyatoslav Ryhel --- arch/arm/mach-

[PATCH v3 16/16] board: asus: lg: move config fragments into device boards

2023-10-02 Thread Svyatoslav Ryhel
Move ASUS Transformers, Grouper, P895 and P880 config fragments into their respective device directory in /board/../configs/ Signed-off-by: Svyatoslav Ryhel --- board/asus/grouper/MAINTAINERS | 3 --- .../asus/grouper/configs}/grouper_E1565.config | 0 ...

[PATCH v3 15/16] board: tegra30: remove nvidia_board_late_init calls

2023-10-02 Thread Svyatoslav Ryhel
Remove nvidia_board_late_init calls from board since this setup is performed in board2 of mach-tegra. Call of nvidia_board_late_init from within the board does not provide any additional data. Tested-by: Andreas Westman Dorcsak # ASUS Transformer T30 Tested-by: Svyatoslav Ryhel # LG P895 T30 Sig

[PATCH v3 14/16] ARM: tegra: board2: add generic late init

2023-10-02 Thread Svyatoslav Ryhel
Board specific late init allows vendors to set up different device or board specific env variables (like serial number, platform name). In case this information is missing, u-boot will lack info regards serial or platform. To avoid this prior nvidia_board_late_init internal generic function is cal

[PATCH v3 13/16] ARM: tegra20: tegra30: support EBTUPDATE on non-encrypted devices

2023-10-02 Thread Svyatoslav Ryhel
Re-crypt support was extended to devices without burnt SBK. In case SBK is not set, place from where it is read is filled with zeroes. This patch adds support for ebtupdate function to detect nosbk device and avoid crypto operations for it. Tested-by: Maksim Kurnosenko Signed-off-by: Svyatoslav R

[PATCH v3 10/16] ARM: dts: grouper: complete missing bindings

2023-10-02 Thread Svyatoslav Ryhel
Clean up the tree and prepare for DM PMIC migration. Signed-off-by: Svyatoslav Ryhel --- arch/arm/dts/tegra30-asus-grouper-common.dtsi | 5 +++-- arch/arm/dts/tegra30-asus-nexus7-grouper-E1565.dts | 5 ++--- arch/arm/dts/tegra30-asus-nexus7-grouper-PM269.dts | 11 +-- arch/arm/dts

[PATCH v3 08/16] ARM: dts: endeavoru: complete missing bindings

2023-10-02 Thread Svyatoslav Ryhel
Clean up the tree and prepare for DM PMIC migration. Signed-off-by: Svyatoslav Ryhel --- arch/arm/dts/tegra30-htc-endeavoru.dts | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/arch/arm/dts/tegra30-htc-endeavoru.dts b/arch/arm/dts/tegra30-htc-endeavoru.dts in

[PATCH v3 09/16] ARM: dts: lg-x3: complete missing bindings

2023-10-02 Thread Svyatoslav Ryhel
Clean up the tree and prepare for DM PMIC migration. Signed-off-by: Svyatoslav Ryhel --- arch/arm/dts/tegra30-lg-x3.dtsi | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/arch/arm/dts/tegra30-lg-x3.dtsi b/arch/arm/dts/tegra30-lg-x3.dtsi index 922e39915e..6e52fc5a53

[PATCH v3 07/16] ARM: dts: transformer-t30: complete missing bindings

2023-10-02 Thread Svyatoslav Ryhel
Clean up the tree and prepare for DM PMIC migration. Signed-off-by: Svyatoslav Ryhel --- arch/arm/dts/tegra30-asus-transformer.dtsi | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/arch/arm/dts/tegra30-asus-transformer.dtsi b/arch/arm/dts/tegra30-asus-tr

[PATCH v3 06/16] configs: transformer_t30: convert bootmenu option

2023-10-02 Thread Svyatoslav Ryhel
Convert refresh USB to enter console. Transformers have full size USB and a dock keyboard so access to U-Boot console would be handy. Signed-off-by: Svyatoslav Ryhel --- configs/transformer_t30_defconfig| 2 +- include/configs/transformer-common.h | 7 +-- 2 files changed, 2 insertions(+

[PATCH v3 05/16] board: asus: transformer-t30: remove PMIC GPIOs configuration

2023-10-02 Thread Svyatoslav Ryhel
Default configuration matches values which are set in the board so this configuration is not required. Signed-off-by: Svyatoslav Ryhel --- board/asus/transformer-t30/transformer-t30.c | 25 1 file changed, 25 deletions(-) diff --git a/board/asus/transformer-t30/transformer-

[PATCH v3 04/16] ARM: dts: tf201: configure dock USB phy

2023-10-02 Thread Svyatoslav Ryhel
TF201 unlike other transformers uses non-fused xcvr value for its dock USB port. With out it dock USB and SD reader will not work. Signed-off-by: Svyatoslav Ryhel --- arch/arm/dts/tegra30-asus-tf201.dts| 5 + arch/arm/dts/tegra30-asus-transformer.dtsi | 4 2 files changed, 9 ins

[PATCH v3 02/16] ARM: dts: tf600t: separate from common transformers tree

2023-10-02 Thread Svyatoslav Ryhel
TF600T has significant differences (Tegra DSI and DSI panel, own power supply system) which makes use of common transformer device tree complicated. Signed-off-by: Svyatoslav Ryhel --- arch/arm/dts/tegra30-asus-tf600t.dts | 160 +-- 1 file changed, 148 insertions(+), 12 d

[PATCH v3 03/16] configs: transformer_t30: support booting from USB

2023-10-02 Thread Svyatoslav Ryhel
Change boot logic to primary try to boot from USB in dock, then from microSD and lastly from eMMC. Signed-off-by: Svyatoslav Ryhel --- configs/tf600t.config | 2 +- configs/transformer_t30_defconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configs/tf600t

[PATCH v3 01/16] ARM: dts: p1801-t: separate from common transformers tree

2023-10-02 Thread Svyatoslav Ryhel
P1801-T has significant differences (hdmi panel and backlight, own power supply system) which makes use of common transformer device tree complicated. Signed-off-by: Svyatoslav Ryhel --- arch/arm/dts/tegra30-asus-p1801-t.dts | 205 +- 1 file changed, 198 insertions(+), 7

[PATCH v3 00/16] General tegra and board improvements

2023-10-02 Thread Svyatoslav Ryhel
This patchset follows Transformers, Grouper, LG X3 and Endeavoru bringup and contains changes from v9 of previous patchset and some new improvenets. List of changes: - separated tf600t and p1801-t device trees since they use different video path bindings - enabled booting from usb devices (USB >

[PATCH v3 2/2] mmc: tegra: get default-tap and default-trim from device tree

2023-10-02 Thread Svyatoslav Ryhel
Default-tap and default-trim values are used for eMMC setup mostly on T114+ devices. As for now, those values are hardcoded for T210 and ignored for all other Tegra generations. Fix this by passing tap and trim values from dts. Signed-off-by: Svyatoslav Ryhel --- arch/arm/include/asm/arch-tegra/

[PATCH v3 1/2] ARM: tegra210: set default-tap and default-trim values in sdhci nodes

2023-10-02 Thread Svyatoslav Ryhel
Tegra MMC driver has hardcoded tap and trim values as for now. Set default-tap and default-trim values in sdhci nodes to avoid regressions in case Tegra MMC driver is upated to use dts values. Signed-off-by: Svyatoslav Ryhel --- arch/arm/dts/tegra210.dtsi | 8 1 file changed, 8 insertio

[PATCH v3 0/2] tegra_mmc: get tap and trim from dts

2023-10-02 Thread Svyatoslav Ryhel
Default-tap and default-trim values are used for eMMC setup mostly on T114+ devices. As for now, those values are hardcoded for T210 and ignored for all other Tegra generations. Fix this by passing tap and trim values from dts. --- Changes from v2 - no changes, re-sending Changes from v1 - move t

[PATCH v7 7/8] power: pmic: tps65910: add TPS65911 PMIC support

2023-10-02 Thread Svyatoslav Ryhel
Add support to bind the regulators/child nodes with the pmic. Also adds the pmic i2c based read/write functions to access pmic registers. Signed-off-by: Svyatoslav Ryhel Reviewed-by: Simon Glass --- doc/device-tree-bindings/pmic/tps65911.txt | 78 ++ drivers/power/pmic/pmic_

[PATCH v7 8/8] power: regulator: tps65911: add regulator support

2023-10-02 Thread Svyatoslav Ryhel
The driver provides regulator set/get voltage enable/disable functions for TI TPS5911 PMIC. Signed-off-by: Svyatoslav Ryhel Reviewed-by: Simon Glass --- drivers/power/regulator/Kconfig | 11 + drivers/power/regulator/Makefile | 1 + drivers/power/regulator/tps65911_r

[PATCH v7 6/8] power: regulator: tps80031: add regulator support

2023-10-02 Thread Svyatoslav Ryhel
The driver provides regulator set/get voltage enable/disable functions for TI TPS80031/TPS80032 PMICs. Signed-off-by: Svyatoslav Ryhel Reviewed-by: Simon Glass --- drivers/power/regulator/Kconfig | 8 + drivers/power/regulator/Makefile | 1 + drivers/power/regulator

[PATCH v7 5/8] power: pmic: add the base TPS80031 PMIC support

2023-10-02 Thread Svyatoslav Ryhel
Add support to bind the regulators/child nodes with the pmic. Also adds the pmic i2c based read/write functions to access pmic registers. Signed-off-by: Svyatoslav Ryhel Reviewed-by: Simon Glass --- doc/device-tree-bindings/pmic/tps80031.txt | 76 +++ drivers/power/pmic/Kconfig

[PATCH v7 2/8] power: regulator: palmas: fix ldoln and ldousb detection

2023-10-02 Thread Svyatoslav Ryhel
dev->driver_data will carry the tail of ldo if there is a number and if there is no number it will be an error code, anyway it will not be zero. This results in a wrong ldo regulator detection. To avoid this check for non-numerical ldo first and then manipulate dev->driver_data. Signed-off-by: Sv

[PATCH v7 4/8] power: regulator: max77663: add regulator support

2023-10-02 Thread Svyatoslav Ryhel
The driver provides regulator set/get voltage enable/disable functions for MAXIM MAX77663 PMICs. Signed-off-by: Svyatoslav Ryhel Reviewed-by: Simon Glass --- drivers/power/regulator/Kconfig | 9 + drivers/power/regulator/Makefile | 1 + drivers/power/regulator/max77

[PATCH v7 3/8] power: pmic: add the base MAX77663 PMIC support

2023-10-02 Thread Svyatoslav Ryhel
Add support to bind the regulators/child nodes with the pmic. Also adds the pmic i2c based read/write functions to access pmic registers. Signed-off-by: Svyatoslav Ryhel Reviewed-by: Simon Glass --- doc/device-tree-bindings/pmic/max77663.txt | 84 + drivers/power/pmic/Kconfi

[PATCH v7 1/8] power: pmic: palmas: support TI TPS65913 PMIC

2023-10-02 Thread Svyatoslav Ryhel
Existing PALMAS PMIC driver is fully compatible with TI TPS65913 PMIC found in many Tegra 4 devices, like Tegra Note 7 and ASUS TF701T. TPS65913 shares same structure of regulators like TPS659038 so data can be reused. Tested-by: Svyatoslav Ryhel # NVIDIA Tegratab Signed-off-by: Svyatoslav Ryhel

[PATCH v7 0/8] Add support for PMICs used on Tegra 3 devices

2023-10-02 Thread Svyatoslav Ryhel
Patch set adds basic support for PMICs used in many Tegra 3 devices. All PMIC drivers are based on datasheets provided by vendors. Implemented API include regulator set/get voltage enable/disable and basic PMIC r/w capabilities. Drivers were tested by me on LG P895 (max77663), HTC One X (TPS80032)

[PATCH v3 3/3] video: tegra20: dsi: use regulator_set_enable_if_allowed

2023-10-02 Thread Svyatoslav Ryhel
With the commit 4fcba5d556b4 ("regulator: implement basic reference counter") the return value of regulator_set_enable may be EALREADY or EBUSY for fixed/gpio regulators and may be further expanded on all regulators. Change to use the more relaxed regulator_set_enable_if_allowed to continue if reg

[PATCH v3 2/3] video: simple_panel: use regulator_set_enable_if_allowed

2023-10-02 Thread Svyatoslav Ryhel
With the commit 4fcba5d556b4 ("regulator: implement basic reference counter") the return value of regulator_set_enable may be EALREADY or EBUSY for fixed/gpio regulators and may be further expanded on all regulators. Change to use the more relaxed regulator_set_enable_if_allowed to continue if reg

[PATCH v3 1/3] video: pwm_backlight: use regulator_set_enable_if_allowed

2023-10-02 Thread Svyatoslav Ryhel
With the commit 4fcba5d556b4 ("regulator: implement basic reference counter") the return value of regulator_set_enable may be EALREADY or EBUSY for fixed/gpio regulators and may be further expanded on all regulators. Change to use the more relaxed regulator_set_enable_if_allowed to continue if reg

[PATCH v3 0/3] Video: Keep fixed/gpio regulator counter in balance

2023-10-02 Thread Svyatoslav Ryhel
The commit 4fcba5d556b4 ("regulator: implement basic reference counter") have made it more important to keep fixed/gpio regulators enable/disable state in balance. The regulator_set_enable_if_allowed function is more relaxed and will wrap all cases where the regulator is busy, already active, miss

[PATCH v4 4/4] test: dm: regulator: provide test of auto setup

2023-10-02 Thread Svyatoslav Ryhel
Adjust existing tests to pass with autosetup and so test if changes behave as expected. Signed-off-by: Svyatoslav Ryhel --- test/dm/regulator.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/test/dm/regulator.c b/test/dm/regulator.c index 33115daaf5..fbbbddbf72 1006

[PATCH v4 3/4] power: regulator: Perform regulator setup inside uclass

2023-10-02 Thread Svyatoslav Ryhel
Regulators initial setup was previously dependent on board call. To move from this behaviour next solution is proposed: on post_bind boot-on/always-on properties are checked, all regulators with such props will be probed just after binding which ensures that essential regulators are set, then in th

[PATCH v4 2/4] test: dm: regulator: test counter in set_enable_if_allowed test

2023-10-02 Thread Svyatoslav Ryhel
Emulate use of the regulator by a few consumers with balanced on/off calls. Signed-off-by: Svyatoslav Ryhel --- test/dm/regulator.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/test/dm/regulator.c b/test/dm/regulator.c index 86f4862d9d..33115daaf5 100644 --- a/test/dm/

[PATCH v4 1/4] power: regulator: expand basic reference counter onto all uclass

2023-10-02 Thread Svyatoslav Ryhel
Commit is based on 4fcba5d ("regulator: implement basic reference counter") but expands the idea to all regulators instead of just fixed/gpio regulators. Signed-off-by: Svyatoslav Ryhel Reviewed-by: Simon Glass --- drivers/power/regulator/regulator-uclass.c | 41 ++ drivers/

[PATCH v4 0/4] General regulator and pmic uclass improvements

2023-10-02 Thread Svyatoslav Ryhel
This patchset derives from discussion of TPS65913 bringup and aims to cycle all regulator management inside uclass removing need of any board calls for regulators. My hw setup is Tegra 3 LG Optimus Vu P895 (PMIC is MAX77663) with native spl u-boot build. power: regulator: expand basic reference c

Re: [PATCH v1] i2c: nuvoton: add support fast mode

2023-10-02 Thread Heiko Schocher
Hello Jim, On 26.09.23 11:08, Jim Liu wrote: > Signed-off-by: Jim Liu > --- > drivers/i2c/npcm_i2c.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/drivers/i2c/npcm_i2c.c b/drivers/i2c/npcm_i2c.c > index ea4ef53256..b867b6c8e9 100644 > --- a/drivers/i2c/npcm_i2c.c > +++ b/drivers/

[PATCH] spl: mmc: Resolve emmc not load image after switched hw partition

2023-10-02 Thread Kuan Lim Lee
When selecting MMCSD_MODE_EMMCBOOT as boot_mode, emmc do not load U-boot proper image after switched hardware partition. Signed-off-by: Kuan Lim Lee Reviewed-by: Chee Hong Ang Reviewed-by: Wei Liang Lim --- common/spl/spl_mmc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/common/spl

Re: [PATCH v2 1/2] binman: openssl: x509: ti_secure_rom: Add support for bootcore_opts

2023-10-02 Thread Neha Malcom Francis
Hi Simon On 02/10/23 06:46, Simon Glass wrote: Hi Neha, On Tue, 26 Sept 2023 at 22:08, Neha Malcom Francis wrote: According to the TRMs of K3 platform of devices, the ROM boot image format specifies a "Core Options Field" that provides the capability to set the boot core in lockstep when set

[PATCH 2/2] Revert "arm: mvebu: x240: Use i2c-gpio instead of built in controller"

2023-10-02 Thread Chris Packham
This reverts commit 5c1c6b7306f2b4c0fd50c7cb5d757e245b93606e. The reason for switching to i2c-gpio was due to an issue we were seeing in the Linux kernel where the CPU would lock up on certain adverse I2C bus conditions. We were never able to reproduce the lockup in U-Boot but assumed that was prob

[PATCH 1/2] arm: mvebu: x240: Disable SMBIOS

2023-10-02 Thread Chris Packham
The x240 doesn't make use of EFI or SMBIOS. Recently we started seeing boot failures such as WARNING: SMBIOS table_address overflow 23f60c020 Failed to write SMBIOS table initcall failed at event 10/(unknown) (err=-22) ### ERROR ### Please RESET the board ### The error is because

[PATCH v2 3/3] arm64: versal_net: Disable the lock option for mini ospi and qspi

2023-10-02 Thread Venkatesh Yadav Abbarapu
As mini configs are required only for flashing the images, so disabling the lock config which will save nearly 6KB of memory. Signed-off-by: Venkatesh Yadav Abbarapu --- configs/xilinx_versal_net_mini_ospi_defconfig | 3 ++- configs/xilinx_versal_net_mini_qspi_defconfig | 3 ++- 2 files changed,

[PATCH v2 2/3] arm64: versal: Disable the lock option for mini ospi and qspi

2023-10-02 Thread Venkatesh Yadav Abbarapu
As mini configs are required only for flashing the images, so disabling the lock config which will save nearly 6KB of memory. Signed-off-by: Venkatesh Yadav Abbarapu --- configs/xilinx_versal_mini_ospi_defconfig | 3 ++- configs/xilinx_versal_mini_qspi_defconfig | 3 ++- 2 files changed, 4 inser

[PATCH v2 1/3] mtd: spi-nor: Add spi flash lock config option

2023-10-02 Thread Venkatesh Yadav Abbarapu
Provide an explicit configuration option to disable default "lock" of any flash chip which supports locking. By disabling the lock config will save some amount of memory and also don't expose the lock functionality to the users i.e., via sf protect command. Signed-off-by: Venkatesh Yadav Abbarapu

[PATCH v2 0/3] Add spi flash lock option

2023-10-02 Thread Venkatesh Yadav Abbarapu
Disabling the flash lock option for versal and versal-net mini ospi and qspi defconfigs. Changes in v2: - Updated the commit message. - Added SPI_FLASH_LOCK in cmd/sf.c, so when disabling this option "sf protect" commands wont appear to users. Venkatesh Yadav Abbarapu (3): mtd: spi-nor: Add

[PATCH] board: synquacer: set actual gd->ram_top and gd->ram_size

2023-10-02 Thread Masahisa Kojima
Current gd->ram_size and gd->ram_top reflect only the first DRAM bank even if the SynQuacer Developerbox could have up to three DRAM banks. With the commit 06d514d77c37 ("lmb: consider EFI memory map"), the first DRAM bank indicates <4GB address, so whole >4GB memory is marked as EFI_BOOT_SERVICES_

[PATCH v3 1/1] input: avoid NULL dereference

2023-10-02 Thread Heinrich Schuchardt
Before using the result of env_get("stdin") we must check if it is NULL. Avoid #if. This resolves the -Wunused-but-set-variable issue and we don't need a dummy assignment in the else branch. Anyway this warning is disabled in the Makefile. For sake of readability use an early return after the con

[PATCH 1/1] sandbox: fix spl_board_init

2023-10-02 Thread Heinrich Schuchardt
sandbox_spl_defconfig with CONFIG_SPL_UNIT_TEST=n fails to build. in function `spl_board_init': arch/sandbox/cpu/spl.c:134:(.text.spl_board_init+0x4a): undefined reference to `ut_run_list' Add the missing configuration check. Signed-off-by: Heinrich Schuchardt --- arch/sandbox/cpu/

Re: [PATCH v2 1/1] input: avoid NULL dereference

2023-10-02 Thread Heinrich Schuchardt
On 10/3/23 01:40, Tom Rini wrote: On Tue, Oct 03, 2023 at 01:37:14AM +0200, Rasmus Villemoes wrote: On 03/10/2023 00.46, Tom Rini wrote: On Tue, Oct 03, 2023 at 12:27:25AM +0200, Heinrich Schuchardt wrote: error = stdio_register(dev); -#if !defined(CONFIG_SPL_BUILD) || CONFIG_IS_ENABLED(

Re: [PATCH 3/4] sandbox: add SCMI power domain protocol support for testing

2023-10-02 Thread AKASHI Takahiro
Hi Simon, Thank you for the review. On Sun, Oct 01, 2023 at 07:17:17PM -0600, Simon Glass wrote: > Hi AKASHI, > > On Tue, 26 Sept 2023 at 01:01, AKASHI Takahiro > wrote: > > > > SCMI power domain management protocol is supported on sandbox > > for test purpose. Add fake agent interfaces and ass

Re: [PATCH v2 1/1] input: avoid NULL dereference

2023-10-02 Thread Tom Rini
On Tue, Oct 03, 2023 at 01:37:14AM +0200, Rasmus Villemoes wrote: > On 03/10/2023 00.46, Tom Rini wrote: > > On Tue, Oct 03, 2023 at 12:27:25AM +0200, Heinrich Schuchardt wrote: > >> > >>error = stdio_register(dev); > >> -#if !defined(CONFIG_SPL_BUILD) || CONFIG_IS_ENABLED(ENV_SUPPORT) > >> -

Re: [PATCH v2 1/1] input: avoid NULL dereference

2023-10-02 Thread Rasmus Villemoes
On 03/10/2023 00.46, Tom Rini wrote: > On Tue, Oct 03, 2023 at 12:27:25AM +0200, Heinrich Schuchardt wrote: >> >> error = stdio_register(dev); >> -#if !defined(CONFIG_SPL_BUILD) || CONFIG_IS_ENABLED(ENV_SUPPORT) >> -/* check if this is the standard input device */ >> -if (!error && s

Re: [PATCH v2 1/1] input: avoid NULL dereference

2023-10-02 Thread Simon Glass
Hi Tom, On Mon, 2 Oct 2023 at 16:46, Tom Rini wrote: > > On Tue, Oct 03, 2023 at 12:27:25AM +0200, Heinrich Schuchardt wrote: > > Before using the result of env_get("stdin") we must check if it is NULL. > > > > Avoid #if. This resolves the -Wunused-but-set-variable issue and we don't > > need a d

Re: [PATCH v2 1/1] input: avoid NULL dereference

2023-10-02 Thread Simon Glass
On Mon, 2 Oct 2023 at 16:27, Heinrich Schuchardt wrote: > > Before using the result of env_get("stdin") we must check if it is NULL. > > Avoid #if. This resolves the -Wunused-but-set-variable issue and we don't > need a dummy assignment in the else branch. Anyway this warning is > disabled in the

Re: [PATCH v2 1/1] input: avoid NULL dereference

2023-10-02 Thread Heinrich Schuchardt
On 10/3/23 00:46, Tom Rini wrote: On Tue, Oct 03, 2023 at 12:27:25AM +0200, Heinrich Schuchardt wrote: Before using the result of env_get("stdin") we must check if it is NULL. Avoid #if. This resolves the -Wunused-but-set-variable issue and we don't need a dummy assignment in the else branch. A

Re: [PATCH v4 16/16] doc: board: ti: k3: Add J784S4 EVM and AM69 SK documentation

2023-10-02 Thread Heinrich Schuchardt
On 10/2/23 18:58, Bryan Brattlof wrote: Hi Apurva! Sorry for the late review. Just some updates I noticed when reading over the docs. On October 1, 2023 thus sayeth Apurva Nandan: TI K3 J784S4 and AM69 are new additions to the K3 SoC family. Add documentation about the J784S4 EVM and AM69 SK.

Re: [PATCH v2 1/1] input: avoid NULL dereference

2023-10-02 Thread Tom Rini
On Tue, Oct 03, 2023 at 12:27:25AM +0200, Heinrich Schuchardt wrote: > Before using the result of env_get("stdin") we must check if it is NULL. > > Avoid #if. This resolves the -Wunused-but-set-variable issue and we don't > need a dummy assignment in the else branch. Anyway this warning is > disab

[PATCH v2 1/1] input: avoid NULL dereference

2023-10-02 Thread Heinrich Schuchardt
Before using the result of env_get("stdin") we must check if it is NULL. Avoid #if. This resolves the -Wunused-but-set-variable issue and we don't need a dummy assignment in the else branch. Anyway this warning is disabled in the Makefile. Signed-off-by: Heinrich Schuchardt --- v2: Avoid

Re: [PULL] u-boot-sh/next_pinctrl_sync

2023-10-02 Thread Tom Rini
On Mon, Oct 02, 2023 at 12:47:56PM +0200, Marek Vasut wrote: > The following changes since commit 90c81f407dd4a7747385b10f9b8f732202c45cde: > > Merge tag 'dm-next-23sep23' of > https://source.denx.de/u-boot/custodians/u-boot-dm into next (2023-09-24 > 12:43:00 -0400) > > are available in the

Re: [RFC] mmc: Remove alignment hole for cmdidx in struct mmc_cmd

2023-10-02 Thread Jonas Karlman
On 2023-10-02 20:56, Simon Glass wrote: > On Fri, 29 Sept 2023 at 17:07, Jonas Karlman wrote: >> >> The alignment hole caused by cmdidx in struct mmc_cmd cause strange >> issues together with the peephole2 optimization on Amlogic SoCs. >> Following was observed while working on SPL support for Aml

Re: bootstd: Scanning for USB bootflow will remove existing SCSI bootflow

2023-10-02 Thread Tony Dinh
Hi Simon, On Sun, Oct 1, 2023 at 6:22 PM Simon Glass wrote: > > Hi Tony, > > On Tue, 26 Sept 2023 at 13:40, Tony Dinh wrote: > > > > Hi Simon, > > > > On Tue, Sep 26, 2023 at 4:37 AM Simon Glass wrote: > > > > > > Hi Tony, > > > > > > On Mon, 25 Sept 2023 at 14:02, Tony Dinh wrote: > > > > > >

Re: [PATCH] scripts/Makefile.lib: also consider $(CONFIG_SYS_BOARD)-u-boot.dtsi

2023-10-02 Thread Rasmus Villemoes
On 02/10/2023 20.56, Simon Glass wrote: > Hi Tom, > > On Mon, 2 Oct 2023 at 10:22, Tom Rini wrote: >> >>> I'm really not sure that replacing build rules with a board CONFIG is >>> a good idea. I suppose part of my confusion is why the Makefile is >>> considered a problem? >> >> Because it's dupl

Re: [PATCH] scripts/Makefile.lib: also consider $(CONFIG_SYS_BOARD)-u-boot.dtsi

2023-10-02 Thread Rasmus Villemoes
On 29/09/2023 18.02, Tom Rini wrote: > On Fri, Sep 29, 2023 at 09:15:00AM -0600, Simon Glass wrote: >> Honestly at this point I've forgotten what this is all about. Fair enough, let me try to recap, though even a summary is a bit long. (1) I wanted to do what $subject says, and you seemed to be

Re: [PATCH 1/1] sunxi: dram: Fix incorrect ram size detection for some H6 boards

2023-10-02 Thread Jernej Škrabec
Dne ponedeljek, 02. oktober 2023 ob 14:42:40 CEST je Gunjan Gupta napisal(a): > > > bool mctl_mem_matches(u32 offset) > > > { > > > + dsb(); > > This looks a bit odd, do you have an explanation for that? And are you > > sure that is really needed? > > I understand why we need the DSB after th

Re: [PATCH] input: avoid NULL dereference

2023-10-02 Thread Simon Glass
On Mon, 2 Oct 2023 at 11:26, Heinrich Schuchardt wrote: > > Before using the result of env_get("stdin") we must check if it is NULL. > > Use attribute __maybe unused instead of dummy assignment. > > Signed-off-by: Heinrich Schuchardt > --- > drivers/input/input.c | 21 - > 1

Re: [PATCH] scripts/Makefile.lib: also consider $(CONFIG_SYS_BOARD)-u-boot.dtsi

2023-10-02 Thread Simon Glass
Hi Tom, On Mon, 2 Oct 2023 at 10:22, Tom Rini wrote: > > On Mon, Oct 02, 2023 at 09:39:18AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 2 Oct 2023 at 09:12, Tom Rini wrote: > > > > > > On Mon, Oct 02, 2023 at 08:43:41AM -0600, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Mon,

Re: [PATCH v5 2/6] cmd: Add a sysinfo command

2023-10-02 Thread Simon Glass
On Mon, 2 Oct 2023 at 09:21, Detlev Casanova wrote: > > The command is able to show different information for the running > system: > * Model name > * Board ID > * Revision > > This command can be used by boot shell scripts to select configurations > depending on the specific running system. > > R

Re: [PATCH v5 1/6] sysinfo: Add IDs for board id and revision

2023-10-02 Thread Simon Glass
On Mon, 2 Oct 2023 at 09:21, Detlev Casanova wrote: > > These IDs will be used by the sysinfo command. The new IDs are: > * SYSINFO_ID_BOARD_ID: The board ID as an integer > * SYSINFO_ID_BOARD_REV_MAJOR: The board major revision as int > * SYSINFO_ID_BOARD_REV_MINOR: The board minor revision as

Re: [PATCH] test: Fix SPL tests not being run

2023-10-02 Thread Simon Glass
Hi Sean, On Mon, 2 Oct 2023 at 08:38, Sean Anderson wrote: > > On 10/1/23 15:36, Simon Glass wrote: > > Hi Sean, > > > > On Fri, 29 Sept 2023 at 10:12, Sean Anderson wrote: > >> > >> On 9/29/23 12:06, Sean Anderson wrote: > >> > SPL doesn't have OF_LIVE enabled, so we can only run tests with a f

Re: [PATCH v3 1/4] common: Add generic function for reading serial number

2023-10-02 Thread Simon Glass
Hi Artur, On Mon, 2 Oct 2023 at 06:42, Artur Rojek wrote: > > Provide a generic way for boards to read their serial number from EEPROM > at init. > > If CONFIG_ID_EEPROM is set, the new serial_read_from_eeprom() function > will now be called during the post-relocation part of the board init. > >

Re: [PATCH v5 3/6] sysinfo: Add a test

2023-10-02 Thread Simon Glass
Hi Detlev, On Mon, 2 Oct 2023 at 09:22, Detlev Casanova wrote: > > The test runs one of each subcommand and checks that the output matches > the values in the sandbox sysinfo driver. > > Reviewed-by: Marek Vasut > Signed-off-by: Detlev Casanova > --- > configs/sandbox_defconfig | 1 + > drive

Re: [PATCH v5 4/6] sysinfo: Add documentation

2023-10-02 Thread Simon Glass
Hi Detlev, On Mon, 2 Oct 2023 at 09:22, Detlev Casanova wrote: > > Add documentation for the sysinfo command with examples. > > Reviewed-by: Marek Vasut > Signed-off-by: Detlev Casanova > --- > doc/usage/cmd/sysinfo.rst | 56 +++ > 1 file changed, 56 inserti

Re: [PATCH 1/2] checkpatch: skip fdtdec_* check for tools

2023-10-02 Thread Simon Glass
On Mon, 2 Oct 2023 at 02:01, Lars Feyaerts wrote: > > Have checkpatch.pl skip warnings for use of fdtdec_* functions in > ooling; livetree isn't used there. > > Signed-off-by: Lars Feyaerts > --- > > scripts/checkpatch.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by

Re: [PATCH RESEND v2 1/2] cmd: bind: Try to improve the (un)bind help

2023-10-02 Thread Simon Glass
On Mon, 2 Oct 2023 at 07:46, Miquel Raynal wrote: > > While it may sound totally obvious for the regular U-Boot developer to > get the parameters of the bind/unbind commands from the output of 'dm > tree', it did not felt straightforward to me until I was explicitly > told to look there. And even

Re: [RFC] mmc: Remove alignment hole for cmdidx in struct mmc_cmd

2023-10-02 Thread Simon Glass
On Fri, 29 Sept 2023 at 17:07, Jonas Karlman wrote: > > The alignment hole caused by cmdidx in struct mmc_cmd cause strange > issues together with the peephole2 optimization on Amlogic SoCs. > Following was observed while working on SPL support for Amlogic SoCs. > > sd_get_capabilities() normally

Re: [PATCH 1/1] sunxi: dram: Fix incorrect ram size detection for some H6 boards

2023-10-02 Thread Jernej Škrabec
Dne ponedeljek, 02. oktober 2023 ob 13:26:26 CEST je Andre Przywara napisal(a): > On Sun, 1 Oct 2023 21:43:32 +0530 > Gunjan Gupta wrote: > > (fixing Jernej's email) > > Hi Gunjan, > > thanks for sending a patch! > > > On some H6 boards like Orange Pi 3 LTS, some times U-Boot fails to detec

Re: [PATCH v7 2/2] schemas: Add some common reserved-memory usages

2023-10-02 Thread Simon Glass
Hi Rob, On Tue, 26 Sept 2023 at 13:42, Simon Glass wrote: > > It is common to split firmware into 'Platform Init', which does the > initial hardware setup and a "Payload" which selects the OS to be booted. > Thus an handover interface is required between these two pieces. > > Where UEFI boot-time

[PATCH v2 3/3] dt-bindings: mtd: binman-partitions: Add alignment properties

2023-10-02 Thread Simon Glass
Add three properties for controlling alignment of partitions, aka 'entries' in binman. For now there is no explicit mention of hierarchy, so a 'section' is just the 'fixed-partitions' node. These new properties are inputs to the packaging process, but are also needed if the firmware is repacked,

[PATCH v2 2/3] dt-bindings: mtd: binman-partition: Add binman labels

2023-10-02 Thread Simon Glass
Add two labels for binman entries, as a starting point for the schema. Signed-off-by: Simon Glass --- Changes in v2: - Use plain partition@xxx for the node name .../mtd/partitions/binman-partition.yaml | 48 +++ 1 file changed, 48 insertions(+) create mode 100644 Documen

[PATCH v2 1/3] dt-bindings: mtd: fixed-partitions: Add binman compatible

2023-10-02 Thread Simon Glass
Add a compatible string for binman, so we can extend fixed-partitions in various ways. Signed-off-by: Simon Glass --- Changes in v2: - Drop mention of 'enhanced features' in fixed-partitions.yaml - Mention Binman input and output properties - Use plain partition@xxx for the node name .../bindi

[PATCH v1 8/8] arch: a1: introduce USB initialization functionality

2023-10-02 Thread Alexey Romanov
This is entrypoint for USB stack initialization. Function board_usb_init will be called from cmd/fastboot.c code. Signed-off-by: Alexey Romanov --- arch/arm/mach-meson/board-a1.c | 89 ++ 1 file changed, 89 insertions(+) diff --git a/arch/arm/mach-meson/board-a1.

[PATCH v1 7/8] dwc3: add support for Amlogic A1 family

2023-10-02 Thread Alexey Romanov
Now the driver supports also A1 phy layer. Signed-off-by: Alexey Romanov --- drivers/usb/dwc3/dwc3-meson-g12a.c | 73 ++ 1 file changed, 63 insertions(+), 10 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-meson-g12a.c b/drivers/usb/dwc3/dwc3-meson-g12a.c index 9041

[PATCH v1 5/8] phy: support Amlogic A1 family

2023-10-02 Thread Alexey Romanov
Setting G12A and A1 is similar, so we can use G12A phy driver with little changes. Signed-off-by: Alexey Romanov --- drivers/phy/Kconfig | 2 +- drivers/phy/meson-g12a-usb2.c | 77 --- 2 files changed, 64 insertions(+), 15 deletions(-) diff --git a/dri

[PATCH v1 3/8] phy: get rid of raw hex values

2023-10-02 Thread Alexey Romanov
It is better to use defines instead of write raw hex values in regmap. Signed-off-by: Alexey Romanov --- drivers/phy/meson-g12a-usb2.c | 161 -- 1 file changed, 153 insertions(+), 8 deletions(-) diff --git a/drivers/phy/meson-g12a-usb2.c b/drivers/phy/meson-g12a-

[PATCH v1 6/8] a1: clk: Add missing CLKID_USB_PHY_IN gate

2023-10-02 Thread Alexey Romanov
From: Igor Prusov We use this clock in dwc3 driver. Signed-off-by: Igor Prusov --- drivers/clk/meson/a1.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/clk/meson/a1.c b/drivers/clk/meson/a1.c index 3aec42f33b..1540e1875b 100644 --- a/drivers/clk/meson/a1.c +++ b/drivers/clk/me

[PATCH v1 4/8] phy: move clk enable/disable in init/exit

2023-10-02 Thread Alexey Romanov
It is better to place clk_enable() in phy_meson_g12a_usb2_init() and clk_disable() in phy_meson_g12a_usb2_exit(). For more detailed information, please see comments in the review of a similar driver in the Linux Kernel: https://lore.kernel.org/all/CAFBinCCEhobbyKHuKDWzTYCQWgNT1-e8=7hmhq1mvt6cueo.

[PATCH v1 1/8] dt-bindings: reset: add Meson A1 reset bindings

2023-10-02 Thread Alexey Romanov
Get this from Linux 6.6-rc3. Signed-off-by: Alexey Romanov --- .../reset/amlogic,meson-a1-reset.h| 76 +++ 1 file changed, 76 insertions(+) create mode 100644 include/dt-bindings/reset/amlogic,meson-a1-reset.h diff --git a/include/dt-bindings/reset/amlogic,meson-a1-

[PATCH v1 2/8] reset: add support for Amlogic A1 family

2023-10-02 Thread Alexey Romanov
This patch adds reset support for the Amlogic A1 family. We add the structure meson_reset_drvdata, which in the future will allow this driver to be used for other families by declaring only the correct parameters reg_count and level_offset. Signed-off-by: Alexey Romanov --- drivers/reset/reset-m

[PATCH v1 0/8] Support USB for Meson A1

2023-10-02 Thread Alexey Romanov
Hello! This patchset adds USB stack support for Amlogic A1 SoC's series. Made reset / phy / dwc3 drivers more flexible and added support for A1 board. Alexey Romanov (7): dt-bindings: reset: add Meson A1 reset bindings reset: add support for Amlogic A1 family phy: get rid of raw hex values

[PATCH] input: avoid NULL dereference

2023-10-02 Thread Heinrich Schuchardt
Before using the result of env_get("stdin") we must check if it is NULL. Use attribute __maybe unused instead of dummy assignment. Signed-off-by: Heinrich Schuchardt --- drivers/input/input.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/inpu

Re: [PATCH v4 16/16] doc: board: ti: k3: Add J784S4 EVM and AM69 SK documentation

2023-10-02 Thread Bryan Brattlof
Hi Apurva! Sorry for the late review. Just some updates I noticed when reading over the docs. On October 1, 2023 thus sayeth Apurva Nandan: > TI K3 J784S4 and AM69 are new additions to the K3 SoC family. > Add documentation about the J784S4 EVM and AM69 SK. > > Signed-off-by: Dasnavis Sabiya

  1   2   >