Re: Pull request: u-boot-rockchip-20230728

2023-07-30 Thread Jagan Teki
On Mon, Jul 31, 2023 at 6:53 AM Kever Yang wrote: > > Hi Jagan, > > On 2023/7/28 20:07, Jagan Teki wrote: > > Hi Kever, > > > > On Fri, Jul 28, 2023 at 5:04 PM Kever Yang > > wrote: > >> Hi Tom, > >> > >> Please pull the updates for rockchip platform: > >> - Enable pcie support for rk3568; > >>

Re: [PATCH 2/2] power: regulator: rk8xx: Add 500us delay after LDO regulator is enabled

2023-07-30 Thread Kever Yang
On 2023/7/2 20:41, Jonas Karlman wrote: A quick power cycle of a LDO regulator during dw-mmc signal voltage change has shown that SD-card does not always get recognized. Linux driver use an enable_time of 400us for LDO regulators. Apply a 500us delay when a LDO regulator is enabled to fix poss

Re: [PATCH 1/2] DO NOT MERGE: mmc: dw_mmc: Keep vqmmc-supply enable count in balance

2023-07-30 Thread Kever Yang
On 2023/7/2 20:41, Jonas Karlman wrote: With the series "regulator: implement basic reference counter" [1], keeping regulator enablement in balance become more important. Disable vqmmc-supply before signal voltage is changed to keep regulator enable counter in balance. [1] https://patchwork.o

Re: [PATCH v2 5/5] doc: rockchip: Update SPI flashing instruction

2023-07-30 Thread Kever Yang
On 2023/7/28 19:38, Jonas Karlman wrote: Update documentation on how to write a bootable u-boot-rockchip-spi.bin image into SPI flash. This removes the reference to a hardcoded and now obsolete 0x6 payload offset. Also remove an obsolete reference to pad_cat. Signed-off-by: Jonas Karlman

Re: [PATCH v2 3/5] rockchip: rk3399-pinephone-pro: Fix SPL max size and SPI flash payload offset

2023-07-30 Thread Kever Yang
On 2023/7/28 19:38, Jonas Karlman wrote: TPL max size is limited to 184 KB, SPL is loaded to 0x0 and TF-A is loaded to 0x4, this limit SPL max size to 256 KB. With BootRom only reading first 2 KB per 4 KB page of SPI flash, 880 KB may be needed for TPL+SPL in a worst-case scenario. (184 KB

Re: [PATCH v2 4/5] rockchip: rk3399-roc-pc: Fix SPL max size and SPI flash payload offset

2023-07-30 Thread Kever Yang
On 2023/7/28 19:38, Jonas Karlman wrote: TPL max size is limited to 184 KB, SPL is loaded to 0x0 and TF-A is loaded to 0x4, this limit SPL max size to 256 KB. With BootRom only reading first 2 KB per 4 KB page of SPI flash, 880 KB may be needed for TPL+SPL in a worst-case scenario. (184 KB

Re: [PATCH v2 2/5] rockchip: rk3399-pinebook-pro: Fix SPL max size and SPI flash payload offset

2023-07-30 Thread Kever Yang
On 2023/7/28 19:38, Jonas Karlman wrote: TPL max size is limited to 184 KB, SPL is loaded to 0x0 and TF-A is loaded to 0x4, this limit SPL max size to 256 KB. With BootRom only reading first 2 KB per 4 KB page of SPI flash, 880 KB may be needed for TPL+SPL in a worst-case scenario. (184 KB

Re: [PATCH v2 1/5] rockchip: rk3399-rockpro64: Fix SPL max size and SPI flash payload offset

2023-07-30 Thread Kever Yang
On 2023/7/28 19:38, Jonas Karlman wrote: TPL max size is limited to 184 KB, SPL is loaded to 0x0 and TF-A is loaded to 0x4, this limit SPL max size to 256 KB. With BootRom only reading first 2 KB per 4 KB page of SPI flash, 880 KB may be needed for TPL+SPL in a worst-case scenario. (184 KB

Re: [PATCH 1/1] riscv: qemu: imply CONFIG_DM_RNG

2023-07-30 Thread Heinrich Schuchardt
On 7/31/23 08:04, Leo Liang wrote: On Fri, Jul 28, 2023 at 03:54:15PM +0200, Heinrich Schuchardt wrote: The EFI_RNG_PROTOCOL is needed for Linux' KASLR. QEMU can provide a virtio-rng device to emulate a hardware random number generator which is supported by our virtio_rng driver. Enabling C

Re: [PATCH] rockchip: rv1126: Enable fdtoverlay support

2023-07-30 Thread Kever Yang
On 2023/7/29 21:41, Jagan Teki wrote: Add fdtoverlay_addr_r and enable OF_LIBFDT_OVERLAY for the use of DT overlay in RV1126. Signed-off-by: Jagan Teki Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/mach-rockchip/Kconfig | 1 + include/configs/rv1126_common.h | 1 + 2 files cha

[PATCH v2 6/6] x86: Return mtrr_add_request() to its old purpose

2023-07-30 Thread Bin Meng
From: Simon Glass This function used to be for adding a list of requests to be actioned on relocation. Revert it back to this purpose, to avoid problems with boards which need control of their MTRRs (i.e. those which don't use FSP). The mtrr_set_next_var() function is available when the next fre

[PATCH v2 5/6] video: vesa: Use mtrr_set_next_var() for graphics memory

2023-07-30 Thread Bin Meng
From: Bin Meng At present this uses mtrr_add_request() & mtrr_commit() combination to program the MTRR for graphics memory. This usage has two major issues as below: - mtrr_commit() will re-initialize all MTRR registers from index 0, using the settings previously added by mtrr_add_request() an

Re: [PATCH 1/1] riscv: qemu: imply CONFIG_DM_RNG

2023-07-30 Thread Leo Liang
On Fri, Jul 28, 2023 at 03:54:15PM +0200, Heinrich Schuchardt wrote: > The EFI_RNG_PROTOCOL is needed for Linux' KASLR. > > QEMU can provide a virtio-rng device to emulate a hardware random number > generator which is supported by our virtio_rng driver. > > Enabling CONFIG_DM_RNG will enable CONF

[PATCH v2 4/6] video: ivybridge: Use mtrr_set_next_var() for graphics memory

2023-07-30 Thread Bin Meng
From: Bin Meng At present this uses mtrr_add_request() & mtrr_commit() combination to program the MTRR for graphics memory. This usage has two major issues as below: - mtrr_commit() will re-initialize all MTRR registers from index 0, using the settings previously added by mtrr_add_request() an

[PATCH v2 3/6] video: broadwell: Use mtrr_set_next_var() for graphics memory

2023-07-30 Thread Bin Meng
From: Bin Meng At present this uses mtrr_add_request() & mtrr_commit() combination to program the MTRR for graphics memory. This usage has two major issues as below: - mtrr_commit() will re-initialize all MTRR registers from index 0, using the settings previously added by mtrr_add_request() an

[PATCH v2 2/6] x86: fsp: Use mtrr_set_next_var() for graphics memory

2023-07-30 Thread Bin Meng
From: Bin Meng At present this uses mtrr_add_request() & mtrr_commit() combination to program the MTRR for graphics memory. This usage has two major issues as below: - mtrr_commit() will re-initialize all MTRR registers from index 0, using the settings previously added by mtrr_add_request() an

[PATCH v2 1/6] x86: Change tesing logic of mtrr commit

2023-07-30 Thread Bin Meng
From: Bin Meng On Coral U-Boot SPL programs some MTRRs and FSPv2 in U-Boot proper needs to program MTRRs too. With current testing logic of mtrr commit in init_cache_f_r(), the mtrr commit is skipped which won't work as the queued mtrr requests include setup for DRAM regions. Change the logic to

Re: [PATCH] mtd: nand: pxa3xx: Fix buffer overflow during raw reads

2023-07-30 Thread Chris Packham
On Mon, Jul 31, 2023 at 9:29 AM Pierre Bourdon wrote: > > On Sun, Jul 30, 2023 at 11:21 PM Chris Packham > wrote: > > On Sun, Jul 30, 2023 at 6:08 AM Pierre Bourdon wrote: > > > > > > Chunked raw reads get accumulated to the data buffer, but in some > > > ECC configurations they can end up bein

Re: [PATCH 00/18] video: bochs: Remove the x86 limitation

2023-07-30 Thread Bin Meng
> On Sun, Jul 23, 2023 at 12:40 PM Bin Meng wrote: > > > > The Bochs VGA card emulated by QEMU does not enforce any architecture. > > It was first introduced on x86 and indeed the x86 IO instruction is > > used to access the legacy VGA IO ports, but that does not mean it has > > to be done like th

Re: [PATCH 3/6] net: ti: am65-cpsw-nuss: Add logic to support MDIO reset

2023-07-30 Thread Siddharth Vadapalli
Tom, On 22/07/23 01:06, Tom Rini wrote: > On Sat, Jul 08, 2023 at 04:15:20PM +0530, Siddharth Vadapalli wrote: > >> From: Suman Anna >> >> Enhance the AM65 CPSW NUSS driver to perform a MDIO reset using a GPIO >> line. Logic is also added to perform a pre and post delay around reset >> using the

Re: [PATCH] mtd: nand: pxa3xx: Fix buffer overflow during raw reads

2023-07-30 Thread Chris Packham
On Mon, 31 Jul 2023, 9:29 am Pierre Bourdon, wrote: > On Sun, Jul 30, 2023 at 11:21 PM Chris Packham > wrote: > > On Sun, Jul 30, 2023 at 6:08 AM Pierre Bourdon > wrote: > > > > > > Chunked raw reads get accumulated to the data buffer, but in some > > > ECC configurations they can end up being

[PATCH v2] rockchip: rk3568-rock-3a: Fix pcie2x1 and pcie3x2 pinctrl override

2023-07-30 Thread Jonas Karlman
The pcie pinctrl override added in the commit a76aa6ffa6cd ("rockchip: rk3568-rock-3a: Enable PCIe and NVMe support") is causing a pinmux issue on linux when using a EFI boot flow. The pcie reset-gpios must however be configured with gpio function, or the device will freeze running pci enum and no

Re: [PATCH v2 5/9] bootstd: Correct creating of bootdev sibling

2023-07-30 Thread Bin Meng
Hi Simon, On Mon, Jul 31, 2023 at 10:50 AM Simon Glass wrote: > > Hi Bin, > > On Sun, 30 Jul 2023 at 19:59, Bin Meng wrote: > > > > Hi Simon, > > > > On Mon, Jul 31, 2023 at 1:15 AM Simon Glass wrote: > > > > > > > > > } > > > > > > return 0; > > > -- > > > > Regards, > > Bin >

[PATCH 00/22] x86: Move some boards to text environment

2023-07-30 Thread Simon Glass
This series starts the process of moving x86 boards to a text environment. This includes conversions for about half the boards. The rest (including the more complicated Chromebooks) can come in a later series. Simon Glass (22): doc: Explain how to avoid the distro-boot scripts env: Use incl

[PATCH 22/22] x86: qemu-x86: Convert to text environment

2023-07-30 Thread Simon Glass
Use the common include. Drop everything from the config.h file. Signed-off-by: Simon Glass --- board/emulation/qemu-x86/qemu-x86.env | 6 ++ include/configs/qemu-x86.h| 23 --- 2 files changed, 6 insertions(+), 23 deletions(-) create mode 100644 board/emul

[PATCH 21/22] x86: qemu: Add required linux/sizes.h include

2023-07-30 Thread Simon Glass
These files rely on the config.h file provided this include. Add it explictily so we can move to a text environment. Signed-off-by: Simon Glass --- arch/x86/cpu/qemu/dram.c | 1 + arch/x86/cpu/qemu/e820.c | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/x86/cpu/qemu/dram.c b/arch/x86/

[PATCH 18/22] x86: slimbootloader: Convert to text environment

2023-07-30 Thread Simon Glass
Use the common include along with some additions. Drop everything from the config.h file. Signed-off-by: Simon Glass --- board/intel/slimbootloader/slimbootloader.env | 25 + include/configs/slimbootloader.h | 35 --- 2 files changed, 25 insertions(+),

[PATCH 20/22] x86: efi-x86_payload: Convert to text environment

2023-07-30 Thread Simon Glass
Use the common include. Drop everything from the config.h file. Signed-off-by: Simon Glass --- board/efi/efi-x86_payload/efi-x86_payload.env | 6 ++ include/configs/efi-x86_payload.h | 17 - 2 files changed, 6 insertions(+), 17 deletions(-) create mode 100644

[PATCH 19/22] x86: efi-x86_app: Convert to text environment

2023-07-30 Thread Simon Glass
Use the common include. Drop the unnecessary changes, since missing stdio drivers will be ignored. Drop everything from the config.h file. Signed-off-by: Simon Glass --- board/efi/efi-x86_app/efi-x86_app.env | 6 ++ include/configs/efi-x86_app.h | 11 --- 2 files changed,

[PATCH 17/22] x86: minnowmax: Convert to text environment

2023-07-30 Thread Simon Glass
Use the common include along with some additions. Drop everything from the config.h file. Signed-off-by: Simon Glass --- board/intel/minnowmax/minnowmax.env | 11 +++ include/configs/minnowmax.h | 16 2 files changed, 11 insertions(+), 16 deletions(-) create m

[PATCH 16/22] x86: cougarcanyon2: Convert to text environment

2023-07-30 Thread Simon Glass
Use the common include. The existing environment includes "vga" but that is not valid anymore, so let it use vidconsole Drop everything from the config.h file. Signed-off-by: Simon Glass --- board/intel/cougarcanyon2/cougarcanyon2.env | 6 ++ include/configs/cougarcanyon2.h |

[PATCH 15/22] x86: cherryhill: Convert to text environment

2023-07-30 Thread Simon Glass
Use the common include. Drop everything from the config.h file. Signed-off-by: Simon Glass --- board/intel/cherryhill/cherryhill.env | 9 + include/configs/cherryhill.h | 13 - 2 files changed, 9 insertions(+), 13 deletions(-) create mode 100644 board/intel/cherr

[PATCH 11/22] x86: crownbay: Convert to text environment

2023-07-30 Thread Simon Glass
Use the common include. Drop everything from the config.h file. Signed-off-by: Simon Glass --- board/intel/crownbay/crownbay.env | 6 ++ include/configs/crownbay.h| 17 - 2 files changed, 6 insertions(+), 17 deletions(-) create mode 100644 board/intel/crownbay/cro

[PATCH 14/22] x86: edison: Convert to text environment

2023-07-30 Thread Simon Glass
Don't use the common include since Edison's environment is empty. Signed-off-by: Simon Glass --- board/intel/edison/edison.env | 6 ++ 1 file changed, 6 insertions(+) create mode 100644 board/intel/edison/edison.env diff --git a/board/intel/edison/edison.env b/board/intel/edison/edison.en

[PATCH 13/22] x86: galileo: Convert to text environment

2023-07-30 Thread Simon Glass
Use the common include. Drop everything from the config.h file. Signed-off-by: Simon Glass --- board/intel/galileo/galileo.env | 11 +++ include/configs/galileo.h | 19 --- 2 files changed, 11 insertions(+), 19 deletions(-) create mode 100644 board/intel/galileo/

[PATCH 12/22] x86: bayleybay: Convert to text environment

2023-07-30 Thread Simon Glass
Use the common include. Drop everything from the config.h file. Signed-off-by: Simon Glass --- board/intel/bayleybay/bayleybay.env | 9 + include/configs/bayleybay.h | 17 - 2 files changed, 9 insertions(+), 17 deletions(-) create mode 100644 board/intel/bayle

[PATCH 09/22] x86: Add a common include for environment settings

2023-07-30 Thread Simon Glass
Create a text-file version of x86-common.h which can be used by x86 boards. Signed-off-by: Simon Glass --- include/env/x86.env | 20 1 file changed, 20 insertions(+) create mode 100644 include/env/x86.env diff --git a/include/env/x86.env b/include/env/x86.env new file mod

[PATCH 07/22] x86: Drop inclusion of ibmpc.h

2023-07-30 Thread Simon Glass
This is not needed in this file anymore. Drop it. Signed-off-by: Simon Glass --- include/configs/x86-common.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/configs/x86-common.h b/include/configs/x86-common.h index 608c5ba7b0a6..e05f667d7226 100644 --- a/include/configs/x86-common

[PATCH 10/22] x86: coreboot: Convert to text environment

2023-07-30 Thread Simon Glass
Use the common include and add some options specific to this board. Drop everything from the config.h file. Signed-off-by: Simon Glass --- board/coreboot/coreboot/coreboot.env | 9 + include/configs/coreboot.h | 20 2 files changed, 9 insertions(+), 20 d

[PATCH 08/22] x86: Drop unused distro settings

2023-07-30 Thread Simon Glass
No x86 board uses distro boot, so drop these settings. Signed-off-by: Simon Glass --- include/configs/x86-common.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/include/configs/x86-common.h b/include/configs/x86-common.h index e05f667d7226..8bd0716c08d2 100644 --- a/include/configs/

[PATCH 05/22] x86: i8254: Include required ibmpc.h header

2023-07-30 Thread Simon Glass
This is needed for this file, so include it here explicitly. Signed-off-by: Simon Glass --- arch/x86/lib/i8254.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/lib/i8254.c b/arch/x86/lib/i8254.c index 0f975389103d..a8d1db188ece 100644 --- a/arch/x86/lib/i8254.c +++ b/arch/x86/lib/

[PATCH 04/22] x86: Drop CFG_SYS_STACK_SIZE

2023-07-30 Thread Simon Glass
This is only used in one file and the value is the same for both boards which define it. Use the fixed value of 32KB and drop the CFG. This will allow removal of the config.h files. Signed-off-by: Simon Glass --- arch/x86/lib/physmem.c | 3 ++- include/configs/edison.h | 4 inc

[PATCH 06/22] x86: edison: Drop inclusion of ibmpc.h

2023-07-30 Thread Simon Glass
This should be included by files that need it, not the config.h file. Drop it. Signed-off-by: Simon Glass --- include/configs/edison.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/include/configs/edison.h b/include/configs/edison.h index 558c74d7b469..127c2c4546e0 100644 --- a/incl

[PATCH 02/22] env: Use include/env for text-environment includes

2023-07-30 Thread Simon Glass
The 'environment' word is too long. We mostly use 'env' in U-Boot, so use that as the name of the include directory too. Signed-off-by: Simon Glass --- board/keymile/km83xx/km83xx.env| 4 ++-- board/keymile/kmcent2/kmcent2.env | 2 +- board/keymile

[PATCH 03/22] env: Explain how to use #include files in text environment

2023-07-30 Thread Simon Glass
Provide documentation on how to share common settings among boards. Signed-off-by: Simon Glass --- doc/usage/environment.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/usage/environment.rst b/doc/usage/environment.rst index 91dc07b17bce..c6439dde6689 100644 --- a/doc/usage/en

[PATCH 01/22] doc: Explain how to avoid the distro-boot scripts

2023-07-30 Thread Simon Glass
Now that standard boot is available, mention this in the environment documentation. Signed-off-by: Simon Glass --- doc/usage/environment.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/usage/environment.rst b/doc/usage/environment.rst index 2c44e5da6aa0..91dc07b17bce

Re: [PATCH v2 7/9] x86: coreboot: Add IDE and SATA

2023-07-30 Thread Simon Glass
Hi Bin, On Sun, 30 Jul 2023 at 20:03, Bin Meng wrote: > > Hi Simon, > > On Mon, Jul 31, 2023 at 1:15 AM Simon Glass wrote: > > > > Add these options to permit access to more disk types. > > > > Add some documentation as well. > > > > Signed-off-by: Simon Glass > > --- > > > > (no changes since

Re: [PATCH v2 5/9] bootstd: Correct creating of bootdev sibling

2023-07-30 Thread Simon Glass
Hi Bin, On Sun, 30 Jul 2023 at 19:59, Bin Meng wrote: > > Hi Simon, > > On Mon, Jul 31, 2023 at 1:15 AM Simon Glass wrote: > > > > > } > > > > return 0; > > -- > > Regards, > Bin > > Use the correct function here, since there may be multiple IDE devices > > available. > > > > Si

Re: Strange construct in binman description

2023-07-30 Thread Simon Glass
Hi Tim, On Sun, 30 Jul 2023 at 17:42, Tim Harvey wrote: > > > On Wed, Jul 26, 2023, 5:55 PM Simon Glass wrote: >> >> Hi Tim, >> >> On Mon, 24 Jul 2023 at 08:53, Simon Glass wrote: >> > >> > Hi, >> > >> > On Sun, 23 Jul 2023 at 03:00, Marcel Ziswiler >> > wrote: >> > > >> > > Hi Simon >> > > >>

Re: [PATCH v2 2/9] usb: Return -ENOENT when no devices are found

2023-07-30 Thread Simon Glass
Hi Bin, On Sun, 30 Jul 2023 at 20:05, Bin Meng wrote: > > On Mon, Jul 31, 2023 at 1:15 AM Simon Glass wrote: > > > > When USB finds no devices it currently returns -EPERM which bootstd does > > The code returns -1, not -EPERM Yes, I mean that -1 is -EPERM. Regards, Simon > > > not understand

Re: [PATCH v2 2/9] video: Tidy up Makefile rule for video

2023-07-30 Thread Bin Meng
On Mon, Jul 31, 2023 at 1:16 AM Simon Glass wrote: > > Drop the duplication and add a single rule which can handle SPL as well. > > Signed-off-by: Simon Glass > Reviewed-by: Nikhil M Jain > --- > > Changes in v2: > Use SPL_ instead of SPL_TPL_ > > drivers/Makefile | 4 ++-- > 1 file changed, 2

Re: [PATCH v2 6/9] bootstd: Add some more debugging in the bootdev uclass

2023-07-30 Thread Bin Meng
On Mon, Jul 31, 2023 at 1:15 AM Simon Glass wrote: > > Add some more output to make it easier to see what is going wrong when > a bootdev hunter fails. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > boot/bootdev-uclass.c | 9 - > 1 file changed, 8 insertions(+), 1 del

Re: [PATCH v2 4/9] bootstd: Rename bootdev_setup_sibling_blk()

2023-07-30 Thread Bin Meng
On Mon, Jul 31, 2023 at 1:15 AM Simon Glass wrote: > > This name is a little confusing since it suggests that it sets up the > sibling block device. In fact it sets up a bootdev for it. Rename the > function to make this clearer. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Fix the

Re: [PATCH v2 3/9] lib: Suppress E when writing error-string output

2023-07-30 Thread Bin Meng
On Mon, Jul 31, 2023 at 1:15 AM Simon Glass wrote: > > When CONFIG_ERRNO_STR is not enabled this shows a spurious 'E' from the > format string. Fix this. > > Signed-off-by: Simon Glass > Fixes: 7f331941321 ("lib: Support printing an error string") > --- > > (no changes since v1) > > lib/vsprintf

Re: [PATCH v2 2/9] usb: Return -ENOENT when no devices are found

2023-07-30 Thread Bin Meng
On Mon, Jul 31, 2023 at 1:15 AM Simon Glass wrote: > > When USB finds no devices it currently returns -EPERM which bootstd does The code returns -1, not -EPERM > not understand. This causes other bootdevs of the same priority to be > skipped. > > Fix this by returning the correct error code. > >

Re: [PATCH v2 9/9] x86: coreboot: Enable support for CBFS

2023-07-30 Thread Bin Meng
On Mon, Jul 31, 2023 at 1:15 AM Simon Glass wrote: > > This is normally used with coreboot, so enable support for it in the > coreboot builds. > > Add an example to show how it is used. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > configs/coreboot64_defconfig| 1 + > c

Re: [PATCH v2 7/9] x86: coreboot: Add IDE and SATA

2023-07-30 Thread Bin Meng
Hi Simon, On Mon, Jul 31, 2023 at 1:15 AM Simon Glass wrote: > > Add these options to permit access to more disk types. > > Add some documentation as well. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > configs/coreboot64_defconfig| 1 + > configs/coreboot_defconfig

Re: [PATCH v2 5/9] bootstd: Correct creating of bootdev sibling

2023-07-30 Thread Bin Meng
Hi Simon, On Mon, Jul 31, 2023 at 1:15 AM Simon Glass wrote: > > Use the correct function here, since there may be multiple IDE devices > available. > > Signed-off-by: Simon Glass > Reviewed-by: Mattijs Korpershoek > --- > > (no changes since v1) > > drivers/block/ide.c | 4 ++-- > 1 file chan

Re: R: Pull request: u-boot-rockchip-20230728

2023-07-30 Thread Kever Yang
Hi Pegorer, On 2023/7/28 23:55, Pegorer Massimo wrote: Hi Kever, Da: U-Boot Per conto di Jagan Teki Inviato: venerdì 28 luglio 2023 14:07 A: Kever Yang Cc: tr...@konsulko.com; u-boot@lists.denx.de Oggetto: Re: Pull request: u-boot-rockchip-20230728 Hi Kever, Also the patches [1] that you

Re: Pull request: u-boot-rockchip-20230728

2023-07-30 Thread Kever Yang
Hi Jagan, On 2023/7/28 20:07, Jagan Teki wrote: Hi Kever, On Fri, Jul 28, 2023 at 5:04 PM Kever Yang wrote: Hi Tom, Please pull the updates for rockchip platform: - Enable pcie support for rk3568; - Add boards: rk3399: Radxa ROCK 4SE; rk3328: Orange Pi R1 Plus, Orange Pi R1

Re:Re: [PATCH v3] rockchip: rk3568: Add EmbedFire Lubancat 2 support

2023-07-30 Thread Andy Yan
Hi Jonas: Thanks for you kindly review。 At 2023-07-30 21:22:36, "Jonas Karlman" wrote: >Hi Andy, > >On 2023-07-29 13:58, Andy Yan wrote: >> LubanCat2 is a rk3568 based SBC from EmbedFire. >> >> Specification: >> - Rockchip rk3568 >> - LPDDR4/4X 1/2/4/8 GB >> - TF scard slot >> -

Re: [PATCH v5 4/5] usb: dwc3-generic: Add rk3568 support

2023-07-30 Thread Marek Vasut
On 7/31/23 00:59, Jonas Karlman wrote: RK3568 share glue and ctrl in a single node. Use glue_get_ctrl_dev to return the glue node as the ctrl node. Signed-off-by: Jonas Karlman Reviewed-by: Jagan Teki Reviewed-by: Marek Vasut

Re: Strange construct in binman description

2023-07-30 Thread Tim Harvey
On Wed, Jul 26, 2023, 5:55 PM Simon Glass wrote: > Hi Tim, > > On Mon, 24 Jul 2023 at 08:53, Simon Glass wrote: > > > > Hi, > > > > On Sun, 23 Jul 2023 at 03:00, Marcel Ziswiler > > wrote: > > > > > > Hi Simon > > > > > > On Jul 23, 2023 05:48, Simon Glass wrote: > > > > > > Hi Marcel, > > > >

Re: [PATCH 1/5] x86: fsp: Use mtrr_set_next_var() for graphics memory

2023-07-30 Thread Bin Meng
Hi Simon, On Mon, Jul 31, 2023 at 7:01 AM Bin Meng wrote: > > Hi Simon, > > On Sat, Jul 29, 2023 at 1:11 AM Simon Glass wrote: > > > > Hi Bin, > > > > On Fri, 28 Jul 2023 at 10:44, Bin Meng wrote: > > > > > > Hi Simon, > > > > > > On Sat, Jul 29, 2023 at 12:03 AM Simon Glass wrote: > > > > > >

Re: [PATCH 1/5] x86: fsp: Use mtrr_set_next_var() for graphics memory

2023-07-30 Thread Bin Meng
Hi Simon, On Sat, Jul 29, 2023 at 1:11 AM Simon Glass wrote: > > Hi Bin, > > On Fri, 28 Jul 2023 at 10:44, Bin Meng wrote: > > > > Hi Simon, > > > > On Sat, Jul 29, 2023 at 12:03 AM Simon Glass wrote: > > > > > > Hi Bin, > > > > > > On Fri, 28 Jul 2023 at 03:38, Bin Meng wrote: > > > > > > > >

[PATCH v5 5/5] rockchip: rk3568: Use dwc3-generic driver

2023-07-30 Thread Jonas Karlman
Change RK3568 devices to use the newer dwc3-generic driver instead of the old xhci-dwc3 driver for USB 3.0 support. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v5: - No change v4: - Rebase on u-boot-rockchip/master and include change to nanopi-r5c-rk3568 and nanopi-r5s-rk3568 - Co

[PATCH v5 4/5] usb: dwc3-generic: Add rk3568 support

2023-07-30 Thread Jonas Karlman
RK3568 share glue and ctrl in a single node. Use glue_get_ctrl_dev to return the glue node as the ctrl node. Signed-off-by: Jonas Karlman Reviewed-by: Jagan Teki --- v5: - Drop device_is_compatible check v4: - No change v3: - No change v2: - No change - Collect r-b tag drivers/usb/dwc3/dwc3-ge

[PATCH v5 3/5] usb: dwc3-generic: Relax unsupported dr_mode check

2023-07-30 Thread Jonas Karlman
When dr_mode is peripheral or otg and U-Boot has not been built with DM_USB_GADGET support, booting such device may end up with: dwc3_glue_bind_common: subnode name: usb@fcc0 Error binding driver 'dwc3-generic-wrapper': -6 Some drivers failed to bind initcall sequence effbca08

[PATCH v5 1/5] Revert "arm: dts: rockchip: radxa-cm3-io, rock-3a: enable regulators for usb"

2023-07-30 Thread Jonas Karlman
Remove regulator-boot-on prop from regulators now that the phy core has support for phy-supply after the commit c57e0dcd9384 ("phy: add support for phy-supply"). This reverts commit 7911f409ff20dce5995cc1b703a6e30c94022f6b. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v5: - No chang

[PATCH v5 2/5] usb: dwc3-generic: Return early when there is no child node

2023-07-30 Thread Jonas Karlman
The current error check for device_find_first_child is not working as expected, the documentation for device_find_first_child mention: @devp: Returns first child device, or NULL if none Return: 0 Change to return early when there is no child node to avoid any possible null pointer dereference

[PATCH v5 0/5] rockchip: rk3568: Use dwc3-generic driver

2023-07-30 Thread Jonas Karlman
This series add support for rk3568 in dwc3-generic driver and change to use the dwc3-generic driver for rk3568 devices having usb enabled. After these changes it should be possible to support usb gadget on rk3568 with e.g.: # CONFIG_USB_FUNCTION_FASTBOOT is not set CONFIG_DM_USB_GADGET=y CO

Re: [PATCH v4 4/5] usb: dwc3-generic: Add rk3568 support

2023-07-30 Thread Marek Vasut
On 7/31/23 00:45, Jonas Karlman wrote: On 2023-07-30 20:12, Marek Vasut wrote: On 7/30/23 19:03, Jonas Karlman wrote: On 2023-07-28 16:02, Marek Vasut wrote: On 7/28/23 14:40, Jonas Karlman wrote: RK3568 share glue and ctrl in a single node. Use glue_get_ctrl_dev to return the glue node as th

Re: [PATCH v4 4/5] usb: dwc3-generic: Add rk3568 support

2023-07-30 Thread Jonas Karlman
On 2023-07-30 20:12, Marek Vasut wrote: > On 7/30/23 19:03, Jonas Karlman wrote: >> On 2023-07-28 16:02, Marek Vasut wrote: >>> On 7/28/23 14:40, Jonas Karlman wrote: RK3568 share glue and ctrl in a single node. Use glue_get_ctrl_dev to return the glue node as the ctrl node. Sig

Re: [PATCH v4 4/5] usb: dwc3-generic: Add rk3568 support

2023-07-30 Thread Marek Vasut
On 7/30/23 19:03, Jonas Karlman wrote: On 2023-07-28 16:02, Marek Vasut wrote: On 7/28/23 14:40, Jonas Karlman wrote: RK3568 share glue and ctrl in a single node. Use glue_get_ctrl_dev to return the glue node as the ctrl node. Signed-off-by: Jonas Karlman Reviewed-by: Jagan Teki --- v4: - No

[PATCH 2/2] arch: m68k: Implement relocation

2023-07-30 Thread Marek Vasut
Implement relocation for M68K. Perform all the updates in start.S relocate_code in assemby, since it is a simple matter of traversing the dynsym table and adding relocation offset - MONITOR_BASE to all the items in that table. The necessity to deal with MONITOR_BASE is a specific of M68K, where the

[PATCH 1/2] tools: relocate-rela: Add M68K support

2023-07-30 Thread Marek Vasut
Add M68K ELF32 support into this tool, so it can patch static rela into M68K u-boot-nodtb.bin . This is the first step toward M68K relocation support, and in turn, removal of NEEDS_MANUAL_RELOC from the codebase altogether. Signed-off-by: Marek Vasut --- Cc: Angelo Dureghello Cc: Angelo Durgehel

[PATCH] tools: relocate-rela: Fix BE symtab handling

2023-07-30 Thread Marek Vasut
The symtab contains data in target endianness, convert the data to native endianness before doing any operations and on them, and back to target endianness before updating the bin file. Signed-off-by: Marek Vasut --- Cc: Angelo Dureghello Cc: Angelo Durgehello Cc: Bin Meng Cc: Heinrich Schucha

Re: [PATCHv4 1/5] net/lwip: add lwip-external submodule

2023-07-30 Thread Peter Robinson
On Fri, Jul 28, 2023 at 7:09 PM Tom Rini wrote: > > On Thu, Jul 27, 2023 at 03:34:48PM +0300, Ilias Apalodimas wrote: > > > Tom, Simon > > are you ok with submodules on this one? > > Still punting on that question and waiting for commentary from > distribution people. I would prefer not to have t

Re: [PATCH] mtd: nand: pxa3xx: Fix buffer overflow during raw reads

2023-07-30 Thread Pierre Bourdon
On Sun, Jul 30, 2023 at 11:21 PM Chris Packham wrote: > On Sun, Jul 30, 2023 at 6:08 AM Pierre Bourdon wrote: > > > > Chunked raw reads get accumulated to the data buffer, but in some > > ECC configurations they can end up being larger than the originally > > computed size (write page size + OOB

Re: [PATCH] mtd: nand: pxa3xx: Fix buffer overflow during raw reads

2023-07-30 Thread Michael Nazzareno Trimarchi
Hi Chris On Sun, Jul 30, 2023 at 11:21 PM Chris Packham wrote: > > Hi Pierre, > > On Sun, Jul 30, 2023 at 6:08 AM Pierre Bourdon wrote: > > > > Chunked raw reads get accumulated to the data buffer, but in some > > ECC configurations they can end up being larger than the originally > > computed s

Re: [PATCH] mtd: nand: pxa3xx: Fix buffer overflow during raw reads

2023-07-30 Thread Chris Packham
Hi Pierre, On Sun, Jul 30, 2023 at 6:08 AM Pierre Bourdon wrote: > > Chunked raw reads get accumulated to the data buffer, but in some > ECC configurations they can end up being larger than the originally > computed size (write page size + OOB size). For example: > > 4K page size, ECC strength 8:

Pull request for spl-2023-10-rc2

2023-07-30 Thread Heinrich Schuchardt
Dear Tom, The following changes since commit a36d59ba99a19c777d896d4c70e75975654e2831: Merge tag 'efi-2023-10-rc2' of https://source.denx.de/u-boot/custodians/u-boot-efi (2023-07-28 12:48:00 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-efi.

Re: [PATCH 1/1] efi_loader: fix invocation of efi_prepare_aligned_image

2023-07-30 Thread Ilias Apalodimas
Hi Heinrich On Sun, Jul 30, 2023 at 09:34:53AM +0200, Heinrich Schuchardt wrote: > When passing a pointer to a size_t variable to a function writing an u64 > value to the address a buffer overrun occurs on 32bit systems. > > Fixes: 163a0d7e2cbd ("efi_loader: add PE/COFF image measurement") > Rep

[PATCH] pci: ftpci100: add new driver implementation

2023-07-30 Thread Sergei Antonov
Add a new DM driver supporting FTPCI100 IP used in SoC designs. This implementation is not based on the old non-DM ftpci100 code dropped from U-Boot. Enable the driver in sandbox_defconfig to test compilability. Signed-off-by: Sergei Antonov --- configs/sandbox_defconfig | 1 + drivers/pci/Kc

[PATCH v2 1/1] doc: describe QEMU virtio block device

2023-07-30 Thread Heinrich Schuchardt
Enhance the description of QEMU block devices * Describe how to attach a virtio-blk device. * Sort the command lines for MMC to match the other devices. Signed-off-by: Heinrich Schuchardt --- v2: %s/if=virtio/if=none/ --- doc/board/emulation/blkdev.rst | 14 -- 1 file change

[PATCH 1/1] doc: describe QEMU virtio block device

2023-07-30 Thread Heinrich Schuchardt
Enhance the description of QEMU block devices * Describe how to attach a virtio-blk device. * Sort the command lines for MMC to match the other devices. Signed-off-by: Heinrich Schuchardt --- doc/board/emulation/blkdev.rst | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) d

Re: [PATCH v2 9/9] x86: Update qemu documentation

2023-07-30 Thread Soeren Moch
On 30.07.23 19:16, Simon Glass wrote: Add some hints and observations related to booting distros on QEMU on x86. Signed-off-by: Simon Glass Simon, you cc'd me on this patch (both versions), but I never used u-boot on x86. What do you expect from my side here? Thanks, Soeren --- (no changes

[PATCH 15/16] bootstd: Add a command to read all files for a bootflow

2023-07-30 Thread Simon Glass
Some bootflows (such as EFI and ChromiumOS) delay reading the kernel until it is needed to boot. This saves time when scanning and avoids needing to allocate memory for something that may never be used. To permit reading of these files, add a new 'bootflow read' command. Signed-off-by: Simon Glas

[PATCH 16/16] bootstd: cros: Add ARM support

2023-07-30 Thread Simon Glass
Support booting ChromiumOS on ARM devices using FIT. Add an entry into the boot implementation which does not require a command line. This can be expanded over time as the bootm code is refactored. Signed-off-by: Simon Glass --- boot/Kconfig | 4 ++-- boot/bootm.c | 37

[PATCH 05/16] bootstd: cros: Decode some kernel preamble fields

2023-07-30 Thread Simon Glass
Decode the kernel start and size using the structures provided. This accesses the same data, just in a cleaner way. Add some logging for some of the fields in the kernel preamble. Signed-off-by: Simon Glass --- boot/bootmeth_cros.c | 54 ++-- 1 file chan

[PATCH 14/16] bootstd: Allow display of the x86 setup information

2023-07-30 Thread Simon Glass
Provide an option to dump this information if available. Move the funciion prototype to the common x86 header. Allow the command line to be left out since 'bootflow info' show this itself and it is not in the correct place in memory until the kernel is actually booted. Fix a badly aligned heading

[PATCH 13/16] bootstd: cros: Split up reading info and kernel

2023-07-30 Thread Simon Glass
Use the two new functions to separate reading of the ChromiumOS info from the partition from actually reading the kernel and booting it. Signed-off-by: Simon Glass --- boot/bootmeth_cros.c | 96 +++- 1 file changed, 23 insertions(+), 73 deletions(-) diff

[PATCH 12/16] bootstd: cros: Add a function to read a kernel

2023-07-30 Thread Simon Glass
The code to read the ChromiumOS information from the partition is currently all in one function. Create a new function which reads the kernel, assuming that the metadata has been parsed. For now this function is not used. Future work will plumb it in. Signed-off-by: Simon Glass --- boot/bootm

[PATCH 11/16] bootstd: cros: Add a function to read info from partition

2023-07-30 Thread Simon Glass
The code to read the ChromiumOS information from the partition is currently all in one function. It reads the entire kernel, which is unnecessary unless it is to be booted. Create a new function which reads just the minimum required data from the disk, then obtains what it needs from there. For n

[PATCH 10/16] bootstd: Add private bootmeth data to the bootflow

2023-07-30 Thread Simon Glass
Some bootmeths need to store their own information related to the bootflow, in addition to the generic information in struct bootflow. Add a pointer for this. Signed-off-by: Simon Glass --- boot/bootflow.c| 1 + include/bootflow.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/boot/

[PATCH 09/16] bootstd: cros: Add private info for ChromiumOS

2023-07-30 Thread Simon Glass
Create a new private structure to hold information gleaned from the disk. This will allow separation between reading of the bootflow information and (later) reading the whole kernel. Signed-off-by: Simon Glass --- boot/bootmeth_cros.c | 55 +--- 1 file ch

[PATCH 08/16] bootstd: cros: Add docs for the kernel layout

2023-07-30 Thread Simon Glass
Provide brief documentation about the ChromiumOS kernel layout. Signed-off-by: Simon Glass --- boot/bootmeth_cros.c | 29 + 1 file changed, 29 insertions(+) diff --git a/boot/bootmeth_cros.c b/boot/bootmeth_cros.c index 3b9e75540aa8..a551d43701d8 100644 --- a/boot/b

[PATCH 07/16] bootstd: Move common zimage functions to bootm.h

2023-07-30 Thread Simon Glass
We want to avoid using #ifdefs around header files and in the code. It makes sense to collect the various functions used for loading images into a single header which can be included by all architectures. The best place for this is the arch-neutral bootm.h header, so use that. Move some zimage fun

[PATCH 06/16] bootstd: cros: Simplify setup and cmdline expressions

2023-07-30 Thread Simon Glass
Create a common base from which the other parts are offset and make all of the offsets related to that. This makes the code a little easier to read. Use X86_ prefixes for the two values which are x86-specific. Drop OFFSET_BASE since it is available in a header field. Drop the unnecessary 'start'

[PATCH 03/16] bootstd: cros: Bring in some ChromiumOS structures

2023-07-30 Thread Simon Glass
Add a header file with structures for booting ChromiumOS, taken from the vboot tree. Using these makes it easier to understand the code. Note that the code style has not been updated for U-Boot, with use of uint64_t, __attribute__((packed)) and one comment-style nit. This should make it easier to

  1   2   >