Hi Ayrton,
On 19.07.23 15:38, Ayrton Leyssens wrote:
Hi Stefano
-Original Message-
From: Stefano Babic
Sent: Wednesday, July 19, 2023 11:57 AM
To: Ayrton Leyssens ; u-boot@lists.denx.de
Subject: Re: [PATCH] Add support for SPL MMC load redundant U-Boot
Hi Ayrton,
On 19.07.23 11:38,
On Thu, 20 Jul 2023 at 11:37, Michal Simek wrote:
>
> Hi,
>
> On 7/20/23 07:49, AKASHI Takahiro wrote:
> > Hi,
> >
> > On Wed, Jul 19, 2023 at 08:28:41AM +0200, Michal Simek wrote:
> >>
> >>
> >> On 7/18/23 17:41, Heinrich Schuchardt wrote:
> >>> On 13.07.23 16:35, Michal Simek wrote:
> Empty
> -Original Message-
> From: Svyatoslav Ryhel
> Sent: Thursday, July 20, 2023 12:26 PM
> To: Jaehoon Chung ; 'Simon Glass'
> Cc: u-boot@lists.denx.de
> Subject: RE: [PATCH v1 0/6] Add support for PMICs used on Tegra 3 devices
>
>
>
> 20 липня 2023 р. 06:12:23 GMT+03:00, Jaehoon Chun
On Mon, 2023-07-17 at 11:12 -0400, Tom Rini wrote:
> On Mon, Jul 17, 2023 at 01:39:52PM +0530, mchit...@ventanamicro.com
> wrote:
> > On Wed, 2023-07-12 at 13:12 -0400, Tom Rini wrote:
> > > On Wed, Jul 12, 2023 at 03:27:45PM +0200, Heinrich Schuchardt
> > > wrote:
> > > > On 12.07.23 15:06, mchit.
Hi,
On 7/20/23 07:49, AKASHI Takahiro wrote:
Hi,
On Wed, Jul 19, 2023 at 08:28:41AM +0200, Michal Simek wrote:
On 7/18/23 17:41, Heinrich Schuchardt wrote:
On 13.07.23 16:35, Michal Simek wrote:
Empty capsule are also allowed to be process. Without it updated images
can't change their Imag
Hi Tom,
On 19/07/23 18:48, Tom Rini wrote:
On Wed, Jul 19, 2023 at 06:44:18PM +0530, Nikhil M Jain wrote:
Hi Tom,
On 19/07/23 17:28, Tom Rini wrote:
On Wed, Jul 19, 2023 at 04:44:36PM +0530, Nikhil M Jain wrote:
Hi Tom,
Seems like this series fell through the cracks, so a gentle reminder on
Gesendet: Donnerstag, 20. Juli 2023 um 02:58 Uhr
Von: "Weijie Gao (高惟杰)"
> > On Wed, 2023-07-19 at 14:08 +0200, Frank Wunderlich wrote:
> > noticed some build-warnings from the pinctrl-patch which are not
> > critical, but should be fixed.
> >
> > e.g. this (seems for each call of PINCTRL_PIN_GR
Hi,
On Wed, Jul 19, 2023 at 08:28:41AM +0200, Michal Simek wrote:
>
>
> On 7/18/23 17:41, Heinrich Schuchardt wrote:
> > On 13.07.23 16:35, Michal Simek wrote:
> > > Empty capsule are also allowed to be process. Without it updated images
> > > can't change their Image Acceptance state from no to
20 липня 2023 р. 06:12:23 GMT+03:00, Jaehoon Chung
написав(-ла):
>Hi
>
>> -Original Message-
>> From: Svyatoslav Ryhel
>> Sent: Saturday, July 15, 2023 1:16 AM
>> To: Jaehoon Chung ; Simon Glass ;
>> Svyatoslav Ryhel
>>
>> Cc: u-boot@lists.denx.de
>> Subject: [PATCH v1 0/6] Add supp
Hi
> -Original Message-
> From: Svyatoslav Ryhel
> Sent: Saturday, July 15, 2023 1:16 AM
> To: Jaehoon Chung ; Simon Glass ;
> Svyatoslav Ryhel
>
> Cc: u-boot@lists.denx.de
> Subject: [PATCH v1 0/6] Add support for PMICs used on Tegra 3 devices
>
> Patch set adds basic support for PMIC
There is an Errata with the built-in I2C controller where various I2C
hardware errors cause a complete lockup of the CPU (which eventually
results in an watchdog reset).
Put the I2C MPP pins into GPIO mode and use the i2c-gpio driver instead.
This uses a bit-banged implementation of an I2C control
> -Original Message-
> From: Piyush Malgujar
> Sent: Monday, June 5, 2023 10:58 PM
> To: peng@nxp.com; jh80.ch...@samsung.com; u-boot@lists.denx.de
> Cc: jannadu...@marvell.com; ccha...@marvell.com; Dhananjay Kangude
> ; Piyush
> Malgujar
> Subject: [PATCH 1/3] mmc: sdhci-cadence:
On Wed, Jul 19, 2023 at 07:29:57PM -0600, Simon Glass wrote:
> Hi,
>
> On Wed, 19 Jul 2023 at 18:14, AKASHI Takahiro
> wrote:
> >
> > On Wed, Jul 19, 2023 at 03:15:10PM +0200, Heinrich Schuchardt wrote:
> > > On 19.07.23 15:04, Simon Glass wrote:
> > > > Hi,
> > > >
> > > > On Tue, 18 Jul 2023 at
gpio_request_list_by_name() returns the number of gpios requested.
Notably it swallows the underlying -ENOENT when the "gpios" property
does not exist.
Update the i2c-gpio driver to check for ret == 0 before trying the new
sda-gpios/scl-gpios properties.
Signed-off-by: Chris Packham
---
driver
Hi,
On Wed, 19 Jul 2023 at 18:14, AKASHI Takahiro
wrote:
>
> On Wed, Jul 19, 2023 at 03:15:10PM +0200, Heinrich Schuchardt wrote:
> > On 19.07.23 15:04, Simon Glass wrote:
> > > Hi,
> > >
> > > On Tue, 18 Jul 2023 at 19:54, AKASHI Takahiro
> > > wrote:
> > > >
> > > > Hi Simon,
> > > >
> > > > O
On Wed, 2023-07-19 at 14:08 +0200, Frank Wunderlich wrote:
> Hi
>
> > Gesendet: Mittwoch, 19. Juli 2023 um 11:17 Uhr
> > Von: "Weijie Gao"
> > An: u-boot@lists.denx.de
> > Cc: "GSS_MTK_Uboot_upstream" ,
> "Daniel Golle" , "Frank Wunderlich" <
> li...@fw-web.de>, "Weijie Gao"
> > Betreff: [PATC
Hi Simon,
On Thu, 20 Jul 2023 at 04:11, Simon Glass wrote:
>
> Hi Masahisa,
>
> On Thu, 13 Jul 2023 at 23:47, Masahisa Kojima
> wrote:
> >
> > This introcudes the ramdisk uclass and driver.
> >
> > Signed-off-by: Masahisa Kojima
> > ---
> > Newly introcuded in v2
> >
> > disk/part.c
Hi Simon,
On Wed, Jul 19, 2023 at 07:04:06AM -0600, Simon Glass wrote:
> Hi,
>
> On Tue, 18 Jul 2023 at 19:54, AKASHI Takahiro
> wrote:
> >
> > Hi Simon,
> >
> > On Tue, Jul 18, 2023 at 07:08:45PM -0600, Simon Glass wrote:
> > > Hi AKASHI,
> > >
> > > On Tue, 18 Jul 2023 at 18:22, AKASHI Takahir
Hi Heinrich,
On Thu, 20 Jul 2023 at 00:10, Heinrich Schuchardt wrote:
>
> On 14.07.23 07:44, Masahisa Kojima wrote:
> > This introcudes the ramdisk uclass and driver.
> >
> > Signed-off-by: Masahisa Kojima
> > ---
> > Newly introcuded in v2
> >
> > disk/part.c | 3 +
> >
On Wed, Jul 19, 2023 at 03:15:10PM +0200, Heinrich Schuchardt wrote:
> On 19.07.23 15:04, Simon Glass wrote:
> > Hi,
> >
> > On Tue, 18 Jul 2023 at 19:54, AKASHI Takahiro
> > wrote:
> > >
> > > Hi Simon,
> > >
> > > On Tue, Jul 18, 2023 at 07:08:45PM -0600, Simon Glass wrote:
> > > > Hi AKASHI,
Enable measuring test coverage for buildman so we can see the gaps. It is
currently at 68%.
Signed-off-by: Simon Glass
---
(no changes since v3)
Changes in v3:
- Fix 'bulidman' typo in three patches
Changes in v2:
- Drop patch to move -A logic up a little (since it breaks it)
tools/buildman/
In poking around it seems that many boards don't define a CONFIG_TARGET
Kconfig variable. This is not strictly necessary, but add an option to
buildman so these can be viewed.
Signed-off-by: Simon Glass
---
(no changes since v3)
Changes in v3:
- Add new patch with an option to check maintains a
Change -D to mean --debug for consistency with other tools. This is not a
commonly used option, so the impact should be minimal.
Signed-off-by: Simon Glass
---
(no changes since v3)
Changes in v3:
- Add new patch to use -D for --debug
tools/buildman/buildman.rst | 6 +++---
tools/buildman/cmd
This does not need to be in the class. Move it out to avoid a pylint
warning.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 47 +
1 file changed, 24 insertions(+), 23 deletions(-)
diff --git a/tools/buildman/builderthrea
This is useful for some tools and is easily available for buildman. Add
a new --print-arch option.
Signed-off-by: Simon Glass
---
(no changes since v2)
Changes in v2:
- Add new patch to print the architecture for a board
tools/buildman/cmdline.py | 2 ++
tools/buildman/control.py | 24 ++
Make sure all functions have full argument documentation.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 66 ++---
1 file changed, 36 insertions(+), 30 deletions(-)
diff --git a/tools/buildman/builderthread.py b/tools/buildma
Provide the text of the exception when something goes wrong.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 7 +--
tools/buildman/func_test.py | 6 --
2 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/tools/buildman/builderthread
Move this code into a _config_and_build() function, so reduce the size of
run_commit().
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 97 +
1 file changed, 61 insertions(+), 36 deletions(-)
diff --git a/tools/buildman/bu
Move the creating of the result object into the function which sets it
up, to simplify the code.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/tools/buildman/buildert
Put this in its own function to reduce the size of the run_commit()
function
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 30 +-
1 file changed, 21 insertions(+), 9 deletions(-)
diff --git a/tools/buildman/builderthread.py
Put this in its own function to reduce the size of the run_commit()
function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 34 -
1 file changed, 25 insertions(+), 9 deletions(-)
diff --git a/tools/buildman/builderthread
Put this in its own function to reduce the size of the run_commit()
function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 28 +++-
1 file changed, 19 insertions(+), 9 deletions(-)
diff --git a/tools/buildman/builderthread.py b
Move this logic into its own function to reduce the size of the
run_commt() function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 66 +
1 file changed, 42 insertions(+), 24 deletions(-)
diff --git a/tools/buildman/buil
Split this into its own function so reduce the size of run_commit().
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 40 -
1 file changed, 30 insertions(+), 10 deletions(-)
diff --git a/tools/buildman/builderthread.py b/to
Split this into its own function so reduce the size of run_commit().
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 41 -
1 file changed, 30 insertions(+), 11 deletions(-)
diff --git a/tools/buildman/builderthread.py b/to
This is probably a little more efficient and it allows passing the object
to another function to write data. Convert config_out to use a string I/O
device.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 9 +
1 file changed, 5 insertions(+), 4 del
Move more of the argument-building code into this function. Fix a missing
assignment for out_rel_dir too.
Rename the function since it now builds all the arguments.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 55 -
1 f
Move some of this code into a new funciion, to help reduce the size of the
run_commits() function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 38 -
1 file changed, 23 insertions(+), 15 deletions(-)
diff --git a/tools/
This is already set up earlier in the function, so drop the extra
assignment.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py
index f110137e
Move a few more pieces to this new function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py
index 47ebf4dcdd90..e
This variable has a different meaning in the outer scope. Use a different
name to avoid confusion, or bugs.
Signed-off-by: Simon Glass
---
(no changes since v3)
Changes in v3:
- Fix 'scrop' typo
tools/buildman/builderthread.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --
Convert this file to snake case and update all files which use it.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builder.py | 228
tools/buildman/builderthread.py | 26 ++--
tools/buildman/control.py | 13 +-
tools/buildman/f
Make this a public memory since it is used outside the class.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builder.py | 8
tools/buildman/builderthread.py | 2 +-
tools/buildman/test.py | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
dif
Fix the easy warnings in this file.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 95 ++---
1 file changed, 51 insertions(+), 44 deletions(-)
diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py
ind
Convert this file to snake case and update all files which use it.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builder.py | 8 +++---
tools/buildman/builderthread.py | 50 -
2 files changed, 29 insertions(+), 29 deletions(-)
diff
Convert this file to snake case and update all files which use it.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/bsettings.py | 14 +++---
tools/buildman/control.py | 2 +-
tools/buildman/func_test.py | 12 ++--
tools/buildman/main.py | 2 +-
tool
Split this into two functions to avoid a warning about too many
statements.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/cmdline.py | 44 +--
1 file changed, 33 insertions(+), 11 deletions(-)
diff --git a/tools/buildman/cmdline.py b/t
Use argparse to parse the arguments, since OptionParser is deprecated now.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/cmdline.py | 130 +
tools/buildman/control.py | 141 ++--
tools/buildman/func_test.
This is not needed until the builder is run. Move it there to reduce the
size of the do_buildman() function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/tools/buildman/control.
This function does not need to return. Simplify the code by exiting
immediately.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/tools/buildman/control.py b/tools/buildman/control.py
index
Drop some variables at the end of the do_bulidman() function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/tools/buildman/control.py b/tools/buildman/control.py
index 9f775cb15df4..f30
Move this code into a new function. This removes the pylint warning about
too many branches.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 56 ---
1 file changed, 35 insertions(+), 21 deletions(-)
diff --git a/tools/buildm
Move setting of show_bloat to adjust_options() and adjust how the commits
variable is set. Together these remove the pylint warning about too many
statements.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 13 +
1 file changed, 5 insertions(+), 8 d
Do these all in the constructor, so it is consistent.
Move the stray builder comment into the correct place.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builder.py | 25 ++---
tools/buildman/control.py | 18 +++---
2 files changed, 25 in
Fix the pylint warning by using a variable instead of lots of 'return'
statements.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/tools/buildman/control.py b/tools/buildman/control.py
i
Add a simple functional test for the --boards option. Fix the example in
the docs while we are here. Also improve the docs for Builder.count so it
is clearer what it contains.
Signed-off-by: Simon Glass
---
(no changes since v2)
Changes in v2:
- Use snake case for tests
tools/buildman/builder
Tidu up warnings in this file.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/cmdline.py | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/tools/buildman/cmdline.py b/tools/buildman/cmdline.py
index 503c48d769ff..660a83bc3d0f 100644
--- a
Convert this file to snake case and update all files which use it.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/cmdline.py | 2 +-
tools/buildman/func_test.py | 2 +-
tools/buildman/main.py | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/too
Move this code into a function. This removes the last pylint error in
the control module.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 34 +-
1 file changed, 25 insertions(+), 9 deletions(-)
diff --git a/tools/buildman/contro
Avoid an unnecessary local variable by moving this code to a function.
This fixes the pylint warning about too many local variables.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/tools
Move this into its own function to reduce the size of do_buildman().
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 38 +++---
1 file changed, 27 insertions(+), 11 deletions(-)
diff --git a/tools/buildman/control.py b/tools/bui
Move this code into a separate function to reduce the size of the main
do_buildman() directory.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 45 ---
1 file changed, 33 insertions(+), 12 deletions(-)
diff --git a/tools/bui
Commits are numbered for use in tests. Do this in determine_series() since
it is already dealing with the series.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/tools/buildman/control
Move this code into a separate function to avoid a pylint warning in
determine_series().
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 63 +--
1 file changed, 41 insertions(+), 22 deletions(-)
diff --git a/tools/buildman/c
Create a separate function to adjust options. Also move show_actions() up
as far as we can in the function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 53 ---
1 file changed, 33 insertions(+), 20 deletions(-)
diff --git
Pass in the individual values rather than the whole options object, so we
can see what is needed.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/tools/buildman/control.py
Pass in the individual values rather than the whole options object, so we
can see what is needed.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/tools/buildman/control.py
Collect the two parts of the output-file handling into single place.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/tools/buildman/control.py b/tools/buildman/control.py
index b6
Set up output_dir at the start of the main function, instead of updating
the options.output_dir option.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/buildman/control.py b/tool
Move the code which obtains a Boards object into its own function, to
reduce the size of the main function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 74 +--
1 file changed, 48 insertions(+), 26 deletions(-)
diff --git
Move the code for dealing with toolchains out into its own function, to
reduce the size of the main function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 53 ---
1 file changed, 38 insertions(+), 15 deletions(-)
diff --g
Move this up above where the builder is created, since it no-longer makes
use of the builder.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 88 ---
1 file changed, 45 insertions(+), 43 deletions(-)
diff --git a/tools/build
Move some more series-related code here, to reduce the size of the main
function.
Signed-off-by: Simon Glass
---
(no changes since v2)
Changes in v2:
- Correct operation of -A
tools/buildman/control.py | 82 ---
1 file changed, 42 insertions(+), 40 deletion
This lacks a test at present. Add one.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/func_test.py | 7 +++
1 file changed, 7 insertions(+)
diff --git a/tools/buildman/func_test.py b/tools/buildman/func_test.py
index 85222b9f9bc2..ca579a27c61f 100644
--- a/tools/build
Create a new determine_boards() function to hold the code which selects
which boards to build.
Signed-off-by: Simon Glass
---
(no changes since v3)
Changes in v3:
- Correct test failure when using incorrect variable
tools/buildman/control.py | 59 ---
1 fil
Add some tests for the -x flag.
Signed-off-by: Simon Glass
---
(no changes since v3)
Changes in v3:
- Add new patch to test for excluding things
tools/buildman/func_test.py | 24
1 file changed, 24 insertions(+)
diff --git a/tools/buildman/func_test.py b/tools/buildm
This function only needs the output directory from the builder. This is
passed into the builder, so just pass the same value to show_actions().
The avoids needing a builder to call show_actions().
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 8
1 fi
Reduce the size of the do_buildman() function a little by moving the code
that handles --fetch-arch into a separate function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 49 +--
1 file changed, 31 insertions(+), 18 deleti
Tidy up the easier-to-fix pylint warnings in module 'control'.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 119 +---
tools/buildman/func_test.py | 2 +-
2 files changed, 71 insertions(+), 50 deletions(-)
diff --git a/too
Reduce the size of the do_buildman() function a little by moving the code
that figures out the series into a separate function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 95 +++
1 file changed, 56 insertions(+), 39 dele
This does not need any of the control features. Move it out of main to
reduce the size of the do_buildman() function.
For Python 3.6 the -H feature will not work, but this does not seem to be
a huge problem, as it dates from 2016.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/bui
Convert this file to snake case and update all files which use it.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 31 ++-
tools/buildman/func_test.py | 7 ---
tools/buildman/main.py | 3 +--
tools/buildman/test.py
Allow writing the file to a selected location, since otherwise this is
controlled by the buildman configuration, so cannot be determined by the
caller.
Signed-off-by: Simon Glass
Fixes: https://source.denx.de/u-boot/u-boot/-/issues/17
---
(no changes since v1)
tools/buildman/buildman.rst | 7
Rather than using the -R option to get this report as a side effect, add
a dedicated option for it.
Disable CI for now as there are some missing maintainers, unfortunately.
Signed-off-by: Simon Glass
---
(no changes since v3)
Changes in v3:
- Add new patch with an option to check maintainers
-
Tidy up the various pylint warnings in module 'main'.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/main.py | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/tools/buildman/main.py b/tools/buildman/main.py
index 096f5328a272..
An orphaned board should produce a warning, as should a missing name for
the maintainer (when '-' is provided). Add these cases.
Signed-off-by: Simon Glass
---
Changes in v4:
- Add new patch to correct logic for missing maintainers
tools/buildman/boards.py| 14 +-
tools/buildma
Sort the warnings into alphabetical order, for easier reading. Also make
sure that the buildman test files are ignored.
Signed-off-by: Simon Glass
---
Changes in v4:
- Add new patch to sort the maintainer warnings
tools/buildman/boards.py| 4 ++--
tools/buildman/func_test.py | 5 +++--
2 f
At present we get multiple lines of output when a board has no MAINTAINERS
entry:
WARNING: no status info for 'bananapi-m2-pro'
WARNING: no maintainers for 'bananapi-m2-pro'
Suppress the 'status' one since it is implied by the other.
Signed-off-by: Simon Glass
---
(no changes since v3)
This doesn't work as intended. Instead it scans every defconfig file
in the source tree.
Fix it and add a test.
Signed-off-by: Simon Glass
---
Changes in v4:
- Use search() instead of fullmatch() to allow partial matches
Changes in v3:
- Add new patch to correct operation of MAINTAINERS N:
t
We generally expected exactly one of these. Add a check for it.
Note: This warning is not displayed by default. An option will be added
to enable it.
Signed-off-by: Simon Glass
---
(no changes since v3)
Changes in v3:
- Add new patch to detect boards with no CONFIG_TARGET defined
tools/build
The TARGET_xxx options are special in that they refer to a single target.
Exactly one should be enabled for each target, corresponding to a
defconfig file.
Detect configs which result in two TARGET_xxx options being set. For
example, at present, TARGET_POLEG and TARET_POLEG_EVB are enabled for the
Move the assert to the top of the function and provide an explicit
variables for the target name and base name.
Signed-off-by: Simon Glass
---
(no changes since v3)
Changes in v3:
- Add new patch to refactor target handling in Boards.scan()
tools/buildman/boards.py | 8 +---
1 file change
Other than the top-level MAINTAINERS file, all maintainer entries should
actually reference a target. Add a warning to detect those that do not.
Signed-off-by: Simon Glass
---
Changes in v4:
- Reword the warning message
Changes in v3:
- Add new patch to warn about dangling maintainer entries
Create a new function which has the non-UI parts of ensure_board_list().
Add some tests for everything except the N: tag.
While we are here, fix the confusing usage of fname inside a loops that
also uses fname.
Signed-off-by: Simon Glass
---
(no changes since v3)
Changes in v3:
- Add new patch
Use a function to add to the maintainers database, to avoid duplicating
the same code twice.
Signed-off-by: Simon Glass
---
(no changes since v3)
Changes in v3:
- Add new patch to tidy up common code in parse_file()
tools/buildman/boards.py | 13 -
1 file changed, 8 insertions(+),
Add a test for this code, adjusting the timestamp on various files to
check each use case.
Signed-off-by: Simon Glass
---
(no changes since v3)
Changes in v3:
- Add new patch with a test for Boards.output_is_new()
tools/buildman/func_test.py | 61 +
1 file
Add a test for this code. It requires some defconfig files and a test
Kconfig to work with, so copy these into the temporary directory at the
start.
Signed-off-by: Simon Glass
---
(no changes since v3)
Changes in v3:
- Add new patch with a test for Boards.scan_defconfigs()
tools/buildman/func
Rather than using the global thoughout each function, pass in these
values. This allows tests to use different values when testing the same
functions.
Improve a few comments while we are here.
No functional change is intended.
Signed-off-by: Simon Glass
---
(no changes since v3)
Changes in v3
Test should return a suitable exit code when they fail. Fix this and tidy
up the code a little.
Signed-off-by: Simon Glass
---
(no changes since v3)
Changes in v3:
- Add new patch to exit with the return code consistently
tools/buildman/main.py | 8 +---
1 file changed, 5 insertions(+), 3
Use names consistent with their target names.
Signed-off-by: Simon Glass
---
(no changes since v3)
Changes in v3:
- Add new patch to rename the ARM boards
tools/buildman/func_test.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/buildman/func_test.py b/tools/bu
1 - 100 of 215 matches
Mail list logo
