Re: [PATCH v8 3/4] Boot var automatic management for removable medias

2023-06-06 Thread AKASHI Takahiro
On Wed, Jun 07, 2023 at 09:38:30AM +0300, Ilias Apalodimas wrote: > On Wed, 7 Jun 2023 at 03:41, AKASHI Takahiro > wrote: > > > > On Tue, Jun 06, 2023 at 09:37:20AM -0700, Raymond Mao wrote: > > > Changes for complying to EFI spec §3.5.1.1 > > > 'Removable Media Boot Behavior'. > > > Boot variabl

Re: [PATCH v8 3/4] Boot var automatic management for removable medias

2023-06-06 Thread Ilias Apalodimas
On Wed, 7 Jun 2023 at 03:41, AKASHI Takahiro wrote: > > On Tue, Jun 06, 2023 at 09:37:20AM -0700, Raymond Mao wrote: > > Changes for complying to EFI spec §3.5.1.1 > > 'Removable Media Boot Behavior'. > > Boot variables can be automatically generated during a removable > > media is probed. At the

Re: [gitdm][PATCH 1/1] Convert to Python 3

2023-06-06 Thread Heinrich Schuchardt
This is the result of running 2to3 and manually converting the comparison functions to lambda expressions. Signed-off-by: Heinrich Schuchardt Hello Tom, which is the branch that you use for the gitdm U-Boot stats? Is it master or u-boot? If it is u-boot, please, update gitlab to make u-boot

[gitdm][PATCH 1/1] Convert to Python 3

2023-06-06 Thread Heinrich Schuchardt
This is the result of running 2to3 and manually converting the comparison functions to lambda expressions. Signed-off-by: Heinrich Schuchardt --- ConfigFile.py | 4 +- csvdump.py| 4 +- database.py | 22 +-- gitdm | 27 ++--- gitlog.py | 8 ++-- logparse

[PATCH v9 10/10] test/py: efi_capsule: test for FMP versioning

2023-06-06 Thread Masahisa Kojima
This test covers the FMP versioning for both raw and FIT image, and both signed and non-signed capsule update. Signed-off-by: Masahisa Kojima --- Changes in v9: - fix pyling warnings Changes in v8: - remove excess semicolons Changes in v7: - use newly introduced common functions of efi_capsule

[PATCH v9 09/10] test: efi_capsule: refactor efi_capsule test

2023-06-06 Thread Masahisa Kojima
Current efi capsule python tests have much code duplication. This commit creates the common function in test/py/tests/test_efi_capsule/capsule_common.py, aim to reduce the code size and improve maintainability. Reviewed-by: Simon Glass Signed-off-by: Masahisa Kojima --- Changes in v9: - fix pyli

[PATCH v9 08/10] doc: uefi: add anti-rollback documentation

2023-06-06 Thread Masahisa Kojima
This commit describe the procedure to configure lowest supported version in the device tree for anti-rollback protection. Signed-off-by: Masahisa Kojima --- No update since v7 Changes in v7: - describe the usage Newly created in v6 doc/develop/uefi/uefi.rst | 39 ++

[PATCH v9 07/10] doc: uefi: add firmware versioning documentation

2023-06-06 Thread Masahisa Kojima
This commit describes the procedure to add the firmware version into the capsule file. Signed-off-by: Masahisa Kojima --- No update since v7 Changes in v7: - move documentation into "Creating a capsule file" - cleary describe the --fw-version option Newly created in v6 doc/develop/uefi/uefi.r

[PATCH v9 06/10] mkeficapsule: add FMP Payload Header

2023-06-06 Thread Masahisa Kojima
Current mkeficapsule tool does not provide firmware version management. EDK II reference implementation inserts the FMP Payload Header right before the payload. It coutains the fw_version and lowest supported version. This commit adds a new parameters required to generate the FMP Payload Header fo

[PATCH v9 05/10] efi_loader: check lowest supported version

2023-06-06 Thread Masahisa Kojima
The FMP Payload Header which EDK II capsule generation scripts insert has a firmware version. This commit reads the lowest supported version stored in the device tree, then check if the firmware version in FMP payload header of the ongoing capsule is equal or greater than the lowest supported versi

[PATCH v9 04/10] efi_loader: get lowest supported version from device tree

2023-06-06 Thread Masahisa Kojima
This commit gets the lowest supported version from device tree, then fills the lowest supported version in FMP->GetImageInfo(). Signed-off-by: Masahisa Kojima Reviewed-by: Ilias Apalodimas --- No update since v6 Changed in v6: - fw_version is removed from device tree .../firmware/firmware-ver

[PATCH v9 03/10] efi_loader: versioning support in GetImageInfo

2023-06-06 Thread Masahisa Kojima
Current FMP->GetImageInfo() always return 0 for the firmware version, user can not identify which firmware version is currently running through the EFI interface. This commit reads the "FmpState" EFI variable, then fills the firmware version in FMP->GetImageInfo(). Now FMP->GetImageInfo() and

[PATCH v9 02/10] efi_loader: store firmware version into FmpState variable

2023-06-06 Thread Masahisa Kojima
Firmware version management is not implemented in the current FMP protocol. EDK II reference implementation capsule generation script inserts the FMP Payload Header right before the payload, FMP Payload Header contains the firmware version and lowest supported version. This commit utilizes the FMP

[PATCH v9 01/10] efi_loader: add the number of image entries in efi_capsule_update_info

2023-06-06 Thread Masahisa Kojima
The number of image array entries global variable is required to support EFI capsule update. This information is exposed as a num_image_type_guids variable, but this information should be included in the efi_capsule_update_info structure. This commit adds the num_images member in the efi_capsule_u

[PATCH v9 00/10] FMP versioning support

2023-06-06 Thread Masahisa Kojima
Firmware version management is not implemented in the current FMP implementation. This series aims to add the versioning support in FMP. Currently, there is no way to know the current running firmware version through the EFI interface. FMP->GetImageInfo() returns always 0 for the version number. S

Re: [PATCH 1/3] usb: musb-new: sunxi: do not attempt to access NULL SRAMC

2023-06-06 Thread Sam Edwards
Howdy Andre, On 6/5/23 05:04, Andre Przywara wrote: Ah, that's a good find, but I think it goes a bit deeper: Just to be clear, "SRAMC" stands for "SRAM controller", not "SRAM memory block C" (which other SoCs have, but indeed not the D1/T113s). However we (sort of) have an "SRAM controller", al

Re: [EXTERNAL] [PATCH] common: spl: Warn about overflow of SRAM stack

2023-06-06 Thread Kamlesh Gurudasani
Vignesh Raghavendra writes: > If early stack usage is exactly same as SIZE_LIMIT_PROVIDE_STACK, then > its most likely to have overflowed beyond this limit and corrupted any > regions beyond stack. Warn about this to the user. > > Signed-off-by: Vignesh Raghavendra > --- > > I found this useful

Re: [PATCH v8 10/10] test/py: efi_capsule: test for FMP versioning

2023-06-06 Thread Masahisa Kojima
On Tue, 6 Jun 2023 at 19:00, Heinrich Schuchardt wrote: > > On 6/6/23 11:40, Masahisa Kojima wrote: > > This test covers the FMP versioning for both raw and FIT image, > > and both signed and non-signed capsule update. > > > > Signed-off-by: Masahisa Kojima > > Thanks for fixing some of the pylin

[PATCH] common: spl: Warn about overflow of SRAM stack

2023-06-06 Thread Vignesh Raghavendra
If early stack usage is exactly same as SIZE_LIMIT_PROVIDE_STACK, then its most likely to have overflowed beyond this limit and corrupted any regions beyond stack. Warn about this to the user. Signed-off-by: Vignesh Raghavendra --- I found this useful when debugging slient corruption of code/dat

RE: [PATCH 1/1] am65x_gp_evm: Support for ECC DDR with DMA priming

2023-06-06 Thread Ben Roytburd
Hello, I am inquiring on the status of this patch. Is it still being held for review? Thanks, Ben Roytburd From: Ben Roytburd Sent: Friday, May 26, 2023 3:39 PM To: u-boot@lists.denx.de Cc: tr...@konsulko.com Subject: [PATCH 1/1] am65x_gp_evm: Support for ECC DDR with DMA priming >From e019ed98

Re: [PATCH v4 11/11] configs: starfive: Enable ID EEPROM configuration

2023-06-06 Thread yanhong wang
On 2023/6/5 3:23, Jan Kiszka wrote: > On 25.05.23 11:36, Yanhong Wang wrote: >> Enabled ID_EEPROM and I2C configuration for StarFive VisionFive2 board. >> >> Signed-off-by: Yanhong Wang >> --- >> configs/starfive_visionfive2_defconfig | 19 ++- >> 1 file changed, 18 insertions

Re: [PATCH v8 3/4] Boot var automatic management for removable medias

2023-06-06 Thread AKASHI Takahiro
On Tue, Jun 06, 2023 at 09:37:20AM -0700, Raymond Mao wrote: > Changes for complying to EFI spec §3.5.1.1 > 'Removable Media Boot Behavior'. > Boot variables can be automatically generated during a removable > media is probed. At the same time, unused boot variables will be > detected and removed.

Re: [PATCH 1/2] sunxi: H616: add DRAM type selection

2023-06-06 Thread Andre Przywara
On Sat, 3 Jun 2023 16:55:05 +0300 Mikhail Kalashnikov wrote: Hi Mikhail, > From: iuncuim > > Allwinner H616 SoC supports several types of DRAM memory. To further > integrate other types of memory, we need to add this delimitation. I realised that the patches are missing your Signed-off-by, w

[PATCH 5/5] sunxi: H616: add LPDDR3 DRAM support

2023-06-06 Thread Andre Przywara
From: iuncuim The H616 SoC has support for several types of DRAM: DDR3, LPDDR3, DDR4 and LPDDR4. At the moment, the driver only supports DDR3 memory. Let's extend the driver to support the LPDDR3 memory. All "magic" values obtained from the boot0. --- arch/arm/mach-sunxi/Kconfig

[PATCH 4/5] sunxi: H616: add DRAM type selection

2023-06-06 Thread Andre Przywara
From: iuncuim Allwinner H616 SoC supports several types of DRAM memory. To further integrate other types of memory, we need to add this delimitation. --- arch/arm/mach-sunxi/Kconfig | 10 +- arch/arm/mach-sunxi/dram_timings/Makefile | 3 +-- configs/orangepi_zero2_defconfi

[PATCH 3/5] sunxi: H616: dram: split struct dram_para

2023-06-06 Thread Andre Przywara
Currently there is one DRAM parameter struct for the Allwinner H616 DRAM "driver". It contains many fields that are compile time constants (set by Kconfig variables), though there are also some fields that are probed and changed over the runtime of the DRAM initialisation. Because of this mixture,

[PATCH 2/5] sunxi: H616: dram: const-ify DRAM function parameters

2023-06-06 Thread Andre Przywara
There are quite some functions in the Allwinner H616 DRAM "driver", some of them actually change the parameters in the structure passed to them, but many are actually not. To increase the optimisation potential for the code, mark those functions that just read members of the passed dram_para struct

[PATCH 1/5] sunxi: dram: make MBUS configuration functions static

2023-06-06 Thread Andre Przywara
The usage of the C keyword "inline" seems to be a common misunderstanding: it's a *hint* only, and modern compilers will inline (or not) functions based on their own judgement and provided compiler options. So while marking functions as "inline" does not do much, missing the "static" keyword will f

[PATCH 0/5] sunxi: H616: improve DRAM setup and add LPDDR3 support

2023-06-06 Thread Andre Przywara
Hi, this series picks up on Mikhail's H616 LPDDR3 DRAM support (many thanks again for sending that!), and prepends some patches that help to keep the code size down. This was triggered by Mikhail's patches creating bigger binaries, even though the DRAM type is known at compile time, and the compil

Re: [PATCH 0/8] SUNIV SPI NAND support in SPL

2023-06-06 Thread Sam Edwards
On 6/6/23 00:39, Icenowy Zheng wrote: Well it depends on whether all SoCs differienate between SPI NOR and SPI NAND. Allwinner chips that (have datasheets saying they) support boot from SPI-NAND seem quite few and far between, but I've learned that the answer is "not all": the V3s, at leas

[PATCH] arm: mvebu: Clean up Thecus N2350 board DTS

2023-06-06 Thread Tony Dinh
- Update the Thecus N2350 DTS to conform with latest device-tree binding and styles. - Correct typo in mdio node. Signed-off-by: Tony Dinh --- arch/arm/dts/armada-385-thecus-n2350.dts | 210 +++ 1 file changed, 98 insertions(+), 112 deletions(-) diff --git a/arch/arm/dts/ar

Re: [PATCH v8 1/4] Move bootorder and bootoption apis to lib

2023-06-06 Thread Ilias Apalodimas
On Tue, Jun 06, 2023 at 09:37:18AM -0700, Raymond Mao wrote: > Rename and move bootorder and bootoption apis from cmd to lib > for re-use between eficonfig and bootmgr > Fix 'unexpected indentation' when 'make htmldocs' after functions > are moved > > Signed-off-by: Raymond Mao > --- > Changes in

Re: [PATCH v2 0/9] spi: bcm63xx-hsspi: driver and doc updates

2023-06-06 Thread William Zhang
Hi Jagan, On 06/02/2023 11:56 AM, William Zhang wrote: Hi Jagan, On 06/01/2023 11:01 PM, Jagan Teki wrote: On Wed, May 3, 2023 at 12:29 AM William Zhang wrote: This patch series is the u-boot port from the recently accepted kernel Broadcom HSSPI driver patch series here [1]. It includes the

Re: [PATCH v8 2/4] Fix incorrect return code of boot option update

2023-06-06 Thread Raymond Mao
Hi Heinrich, The reason that we don't add calling to efi_bootmgr_update_media_device_boot_option() under efi_disk_remove() is because efi_disk_remove() is always being called during exiting U-Boot and booting an OS. - it doesn't make sense that the boot options we added is removed there. I added a

Re: [PATCH v8 2/4] Fix incorrect return code of boot option update

2023-06-06 Thread Ilias Apalodimas
Hi Heinrich, On Tue, 6 Jun 2023 at 22:56, Heinrich Schuchardt wrote: > > On 6/6/23 21:43, Raymond Mao wrote: > > Hi Ilias, > > > >>> --- a/lib/efi_loader/efi_bootmgr.c > >>> +++ b/lib/efi_loader/efi_bootmgr.c > >>> @@ -663,11 +663,13 @@ efi_status_t > >>> efi_bootmgr_update_media_device_boot_op

Re: [PATCH v5 4/7] board: asus: transformer: add ASUS Transformer T30 family support

2023-06-06 Thread Svyatoslav Ryhel
6 червня 2023 р. 22:47:23 GMT+03:00, Tom Rini написав(-ла): >On Tue, Jun 06, 2023 at 10:40:53PM +0300, Svyatoslav Ryhel wrote: >> >> >> 6 червня 2023 р. 22:19:44 GMT+03:00, Tom Rini >> написав(-ла): >> >On Tue, Jun 06, 2023 at 10:18:47AM +0300, Svyatoslav Ryhel wrote: >> > >> >> The ASUS Tr

Re: [PATCH v8 2/4] Fix incorrect return code of boot option update

2023-06-06 Thread Heinrich Schuchardt
On 6/6/23 21:43, Raymond Mao wrote: Hi Ilias, --- a/lib/efi_loader/efi_bootmgr.c +++ b/lib/efi_loader/efi_bootmgr.c @@ -663,11 +663,13 @@ efi_status_t efi_bootmgr_update_media_device_boot_option(void) NULL, &count,

Re: [PATCH v5 4/7] board: asus: transformer: add ASUS Transformer T30 family support

2023-06-06 Thread Tom Rini
On Tue, Jun 06, 2023 at 10:40:53PM +0300, Svyatoslav Ryhel wrote: > > > 6 червня 2023 р. 22:19:44 GMT+03:00, Tom Rini > написав(-ла): > >On Tue, Jun 06, 2023 at 10:18:47AM +0300, Svyatoslav Ryhel wrote: > > > >> The ASUS Transformer T30 family are 2-in-1 detachable tablets > >> and AiO develope

Re: [PATCH v8 2/4] Fix incorrect return code of boot option update

2023-06-06 Thread Raymond Mao
Hi Ilias, > > --- a/lib/efi_loader/efi_bootmgr.c > > +++ b/lib/efi_loader/efi_bootmgr.c > > @@ -663,11 +663,13 @@ efi_status_t > > efi_bootmgr_update_media_device_boot_option(void) > >NULL, &count, > >(efi_han

Re: [PATCH v5 4/7] board: asus: transformer: add ASUS Transformer T30 family support

2023-06-06 Thread Svyatoslav Ryhel
6 червня 2023 р. 22:19:44 GMT+03:00, Tom Rini написав(-ла): >On Tue, Jun 06, 2023 at 10:18:47AM +0300, Svyatoslav Ryhel wrote: > >> The ASUS Transformer T30 family are 2-in-1 detachable tablets >> and AiO developed by ASUS that run the Android operating system >> (TF600T runs Windows RT and P18

Re: [PATCH v8 2/4] Fix incorrect return code of boot option update

2023-06-06 Thread Ilias Apalodimas
On Tue, 6 Jun 2023 at 22:23, Ilias Apalodimas wrote: > > Hi Raymond > > On Tue, 6 Jun 2023 at 19:37, Raymond Mao wrote: > > > > Correct the return code for out-of-memory and no boot option found > > > > Signed-off-by: Raymond Mao > > Reviewed-by: Ilias Apalodimas > > --- > > Changes in v7 > > -

Re: [PATCH v8 2/4] Fix incorrect return code of boot option update

2023-06-06 Thread Ilias Apalodimas
Hi Raymond On Tue, 6 Jun 2023 at 19:37, Raymond Mao wrote: > > Correct the return code for out-of-memory and no boot option found > > Signed-off-by: Raymond Mao > Reviewed-by: Ilias Apalodimas > --- > Changes in v7 > - new patch file created > > cmd/bootmenu.c | 2 +- > cmd/efico

Re: [PATCH v5 4/7] board: asus: transformer: add ASUS Transformer T30 family support

2023-06-06 Thread Tom Rini
On Tue, Jun 06, 2023 at 10:18:47AM +0300, Svyatoslav Ryhel wrote: > The ASUS Transformer T30 family are 2-in-1 detachable tablets > and AiO developed by ASUS that run the Android operating system > (TF600T runs Windows RT and P1801-T runs Android and Windows). > The T30 Transformers feature a 10.1

Re: Please pull u-boot-i2c

2023-06-06 Thread Tom Rini
On Mon, Jun 05, 2023 at 09:39:43AM +0200, Heiko Schocher wrote: > Hello Tom, > > please pull rom u-boot-i2c.git master > > The following changes since commit 26659d426548d1c395ef878c3b820e53a6e3b346: > > Merge tag 'efi-2023-07-rc4' of > https://source.denx.de/u-boot/custodians/u-boot-efi (20

Re: Please pull u-boot-ubi

2023-06-06 Thread Tom Rini
On Tue, Jun 06, 2023 at 02:07:53PM +0200, Heiko Schocher wrote: > Hello Tom, > > please pull from u-boot-ubi.git master > > The following changes since commit 26659d426548d1c395ef878c3b820e53a6e3b346: > > Merge tag 'efi-2023-07-rc4' of > https://source.denx.de/u-boot/custodians/u-boot-efi (2

[PATCH v2 7/7] configs: rockchip: Enable USB2PHY for RK3328 boards

2023-06-06 Thread Jagan Teki
Enable USB2PHY for all RK3328 boards. => usb start starting USB... Bus usb@ff5c: USB EHCI 1.00 Bus usb@ff5d: USB OHCI 1.0 Bus usb@ff60: generic_phy_get_bulk : no phys property Register 2000140 NbrPorts 2 Starting the controller USB XHCI 1.10 Bus usb@ff58: USB DWC2 scanning bus usb@

[PATCH v2 6/7] clk: rockchip: rk3328: Handle usb480m phy clock

2023-06-06 Thread Jagan Teki
Handle USB480M clock ID in set_rate() and set_parent() to allow the dt assigned-clocks and assigned-clock-parents work on rk3328.dtsi Cc: Lukasz Majewski Cc: Sean Anderson Signed-off-by: Jagan Teki --- Changes for v2: - add USB480M to set_parent drivers/clk/rockchip/clk_rk3328.c | 2 ++ 1 fil

[PATCH v2 5/7] phy: rockchip-inno-usb2: Add USB2 PHY for RK3328

2023-06-06 Thread Jagan Teki
USB2.0 Host and OTG controllers in RK3328 are using USB2PHY. Add support for it. Signed-off-by: Jagan Teki --- Changes for v2: - add clkout_ctl drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 34 +++ 1 file changed, 34 insertions(+) diff --git a/drivers/phy/rockchip/phy-rockch

[PATCH v2 4/7] configs: Enable DWC3 USB 3.0 on RK3328 boards

2023-06-06 Thread Jagan Teki
Enable USB 3.0 in all RK3328 boards. => usb start starting USB... Bus usb@ff5c: ehci_generic usb@ff5c: Failed to get clocks (ret=-19) Port not available. Bus usb@ff5d: USB OHCI 1.0 Bus usb@ff60: Register 2000140 NbrPorts 2 Starting the controller USB XHCI 1.10 Bus usb@ff58: 1 U

[PATCH v2 3/7] usb: dwc3-generic: Restrict single ctrl node for RK3328

2023-06-06 Thread Jagan Teki
Like Rockchip RK3568, the RK3328 also have single node to represent the glue and ctrl for USB 3.0. So, use the driver data to use single ctrl for RK3328 DWC3. Reviewed-by: Marek Vasut Signed-off-by: Jagan Teki --- Changes for v2: - collect Marek RB drivers/usb/dwc3/dwc3-generic.c | 2 +- 1 fi

[PATCH v2 2/7] configs: Drop unused XHCI_DWC3 for RK3328 boards

2023-06-06 Thread Jagan Teki
Driver support for rk3328 is not supported so drop this unused XHCI_DWC3. Cc: Tianling Shen Cc: David Bauer Cc: Loic Devulder Cc: Chen-Yu Tsai Cc: Banglang Huang Cc: Matwey V. Kornilov Signed-off-by: Jagan Teki --- Changes for v2: - none configs/evb-rk3328_defconfig| 1 - configs/

[PATCH v2 1/7] arm64: dts: rockchip: Drop unused rk3328-xhci node

2023-06-06 Thread Jagan Teki
rk3328-xhci has been added due to the fact that the upstream dwc3 is unsupported. Moreover, the driver for rk3328-xhci is not added to the code tree. By considering these facts and unsupported rk3328-xhci this patch is dropping all related code from DT. However, the DWC3 is fixed now in dwc3-gener

[PATCH v2 0/7] rockchip: Fix RK3328 USB support

2023-06-06 Thread Jagan Teki
This series support fixes for RK3328 USB. Changes for v2: - collect Marek RB - update phy driver clockout_ctl for rk3328 - retest on Xavier patches. Any inputs? Jagan. Jagan Teki (7): arm64: dts: rockchip: Drop unused rk3328-xhci node configs: Drop unused XHCI_DWC3 for RK3328 boards usb:

Re: [PATCH v7 2/2] phy: rockchip-inno-usb2: Implement clock operations for usb2phy clock

2023-06-06 Thread Jagan Teki
On Mon, Jun 5, 2023 at 8:37 PM Xavier Drudis Ferran wrote: > > This clock doesn't seem needed but appears in a phandle list used by > ehci-generic.c to bulk enable it. The phandle list comes from linux, > where it is needed for suspend/resume to work [1]. > > My tests give the same results with or

Re: [PATCH v7 1/2] phy: rockchip-inno-usb2: Add usb2phy clock provider of 480MHz clock

2023-06-06 Thread Jagan Teki
On Mon, Jun 5, 2023 at 8:35 PM Xavier Drudis Ferran wrote: > > arch/arm/dts/rk3399.dtsi has a node > > usb_host0_ehci: usb@fe38 { >compatible = "generic-ehci"; > > with clocks: > >clocks = <&cru HCLK_HOST0>, <&cru HCLK_HOST0_ARB>, > <&u2phy0>; > > The first 2

[PATCH v8 3/4] Boot var automatic management for removable medias

2023-06-06 Thread Raymond Mao
Changes for complying to EFI spec §3.5.1.1 'Removable Media Boot Behavior'. Boot variables can be automatically generated during a removable media is probed. At the same time, unused boot variables will be detected and removed. Please note that currently the function 'efi_disk_remove' is being invo

[PATCH v8 4/4] Load option with short device path for boot vars

2023-06-06 Thread Raymond Mao
The boot variables automatically generated for removable medias should be with short form of device path without device nodes. This is a requirement for the case that a removable media is plugged into a different port but is still able to work with the existing boot variables. Signed-off-by: Raymo

[PATCH v8 1/4] Move bootorder and bootoption apis to lib

2023-06-06 Thread Raymond Mao
Rename and move bootorder and bootoption apis from cmd to lib for re-use between eficonfig and bootmgr Fix 'unexpected indentation' when 'make htmldocs' after functions are moved Signed-off-by: Raymond Mao --- Changes in v3 - Split the patch into moving and renaming functions and individual pat

[PATCH v8 2/4] Fix incorrect return code of boot option update

2023-06-06 Thread Raymond Mao
Correct the return code for out-of-memory and no boot option found Signed-off-by: Raymond Mao Reviewed-by: Ilias Apalodimas --- Changes in v7 - new patch file created cmd/bootmenu.c | 2 +- cmd/eficonfig.c | 2 +- lib/efi_loader/efi_bootmgr.c | 8 ++-- 3 files ch

[PATCH v8 0/4] Boot variables management for removable media

2023-06-06 Thread Raymond Mao
Major changes: 1.Rename and move bootorder and bootoption apis from cmd to lib for re-use between eficonfig and bootmgr 2.Fix incorrect return code of boot option update Correct the return code for out-of-memory and no boot option found 3.Changes for complying to EFI spec §3.5.1.1 'Removable

[PATCH] serial: meson: fix meson_serial_pending() tx logic

2023-06-06 Thread Mattijs Korpershoek
mp; AML_UART_TX_FULL); + if (status & AML_UART_TX_EMPTY) + return false; + + return true; } } --- base-commit: a1fd9cb41fb1fda2283a089f9c97e5eed4d4940a change-id: 20230606-fix-meson-serial-pending-890e11467215 Best regards, -- Mattijs Korpershoek

Re: [PATCH v7 1/4] Move bootorder and bootoption apis to lib

2023-06-06 Thread Heinrich Schuchardt
Am 6. Juni 2023 16:39:47 MESZ schrieb Raymond Mao : >Hi Heinrich, > >> With this patch applied to origin/next I get: >> >> ./lib/efi_loader/efi_bootmgr.c:651:Unexpected indentation. >> >> We have >> doc/api/efi.rst:44: >> .. kernel-doc:: lib/efi_loader/efi_bootmgr.c >> >> So this file goes into

Re: [PATCH v7 3/4] Boot var automatic management for removable medias

2023-06-06 Thread Raymond Mao
Hi Ilias, > The code seems fine, but I think there's some things that need to be > clarified on the commit message for future reference. > Can you add a short text describing *why* you only do that in > efi_disk_probe() and not when the disk is signalled to be removed as well? > IOW mention the fa

Re: [PATCH v7 1/4] Move bootorder and bootoption apis to lib

2023-06-06 Thread Raymond Mao
Hi Heinrich, > With this patch applied to origin/next I get: > > ./lib/efi_loader/efi_bootmgr.c:651:Unexpected indentation. > > We have > doc/api/efi.rst:44: > .. kernel-doc:: lib/efi_loader/efi_bootmgr.c > > So this file goes into documentation. > > Please, provide a follow up patch to fix 'make

Re: [lwip-devel] [RFC PATCH 0/5] LWIP stack integration

2023-06-06 Thread Maxim Uvarov
Greetings, I implemented the tftp client (that was quick due to lwip has example app for tftp), and did some more measurements. I uploaded patches here if somebody want to do his own measurements: https://github.com/muvarov/uboot-lwip measure 1: 976K - total (total means lwip with all 3 commands

Re: [PATCH v12 00/10] introduce Arm FF-A support

2023-06-06 Thread Tom Rini
On Tue, Jun 06, 2023 at 12:56:28PM +0100, Abdellatif El Khlifi wrote: > On Mon, May 22, 2023 at 10:13:20AM +0100, Abdellatif El Khlifi wrote: > > Hi Simon, Tom, > > > Hi Simon, > > > > > Adding support for Arm FF-A v1.0 (Arm Firmware Framework for Armv8-A) [A]. > > > > > > FF-A specifies interf

Re: [PATCH v7 1/4] Move bootorder and bootoption apis to lib

2023-06-06 Thread Ilias Apalodimas
On Wed, May 31, 2023 at 10:45:13AM -0700, Raymond Mao wrote: > Rename and move bootorder and bootoption apis from cmd to lib > for re-use between eficonfig and bootmgr > > Signed-off-by: Raymond Mao > Reviewed-by: Heinrich Schuchardt > --- > Changes in v3 > - Split the patch into moving and renam

Re: [PATCH v7 2/4] Fix incorrect return code of boot option update

2023-06-06 Thread Ilias Apalodimas
On Wed, May 31, 2023 at 10:45:15AM -0700, Raymond Mao wrote: > Correct the return code for out-of-memory and no boot option found > > Signed-off-by: Raymond Mao > --- > Changes in v7 > - new patch file created > > cmd/bootmenu.c | 2 +- > cmd/eficonfig.c | 2 +- > lib/e

[PATCH 1/1] virtio: add driver for virtio_console devices

2023-06-06 Thread Ying-Chun Liu (PaulLiu)
From: "A. Cody Schuffelen" This is an implementation of single-character virtio-console. Part of the patch is based on barebox implementations. Signed-off-by: A. Cody Schuffelen [ Paul: pick from the Android tree. Rebase to the upstream. Small fixes. ] Signed-off-by: Ying-Chun Liu (PaulLiu) Li

[PATCH 0/1] virtio: add driver for virtio_console devices

2023-06-06 Thread Ying-Chun Liu (PaulLiu)
This is an implementation of single-character virtio-console. Part of the patch is based on barebox implementations. To test the patch, we can build qemu_arm64_defconfig target. Enable CONFIG_VIRTIO_CONSOLE. And run qemu-system-aarch64 with -device virtio-serial-pci,id=virtio-serial0 \ -chardev

RE: [EXT] Re: [PATCH v1 3/4] DTS: imx93: modify the BUCK1 voltage range

2023-06-06 Thread Joy Zou
> -Original Message- > From: Marek Vasut > Sent: 2023年6月6日 17:28 > To: Joy Zou ; jh80.ch...@samsung.com; Peng Fan > ; Ye Li ; Jacky Bai ; > feste...@denx.de; sba...@denx.de; heiko.thi...@gmail.com > Cc: u-boot@lists.denx.de; dl-uboot-imx > Subject: Re: [EXT] Re: [PATCH v1 3/4] DTS: imx93

RE: [EXT] Re: [PATCH v1 3/4] DTS: imx93: modify the BUCK1 voltage range

2023-06-06 Thread Joy Zou
> -Original Message- > From: Joy Zou > Sent: 2023年6月5日 18:24 > To: Marek Vasut ; jh80.ch...@samsung.com; Peng Fan > ; Ye Li ; Jacky Bai ; > feste...@denx.de; sba...@denx.de; heiko.thi...@gmail.com > Cc: u-boot@lists.denx.de; dl-uboot-imx > Subject: RE: [EXT] Re: [PATCH v1 3/4] DTS: imx93:

Re: [PATCH v7 3/4] Boot var automatic management for removable medias

2023-06-06 Thread Ilias Apalodimas
On Wed, May 31, 2023 at 10:45:17AM -0700, Raymond Mao wrote: > Changes for complying to EFI spec §3.5.1.1 > 'Removable Media Boot Behavior'. > Boot variables can be automatically generated during a removable > media is probed. At the same time, unused boot variables will be > detected and removed.

Re: [PATCHv2] ubifs: allow loading to above 4GiB

2023-06-06 Thread Heiko Schocher
Hello Ben, On 06.06.23 10:23, Ben Dooks wrote: > The ubifsload command is truncating any address above 4GiB as it casts > this address to an u32, instead of using an unsigned long which most of > the other load commands do. Change this to an unsigned long to allow > loading into high memory for bo

Re: [PATCH v12 00/10] introduce Arm FF-A support

2023-06-06 Thread Abdellatif El Khlifi
On Mon, May 22, 2023 at 10:13:20AM +0100, Abdellatif El Khlifi wrote: Hi Simon, Tom, > Hi Simon, > > > Adding support for Arm FF-A v1.0 (Arm Firmware Framework for Armv8-A) [A]. > > > > FF-A specifies interfaces that enable a pair of software execution > > environments aka partitions to > > co

[PATCH] stdio: Remove stdio_init()

2023-06-06 Thread Masahiro Yamada
This function is not used by anyone. Signed-off-by: Masahiro Yamada --- common/stdio.c | 8 include/stdio_dev.h | 7 --- 2 files changed, 15 deletions(-) diff --git a/common/stdio.c b/common/stdio.c index cbedfdda53..894cbd3fb4 100644 --- a/common/stdio.c +++ b/common/stdio.c

Re: [PATCH 05/30] imx: advantech: correct SCU API usage

2023-06-06 Thread Oliver Graute
Am 02.06.2023 um 08:45 schrieb Peng Fan (OSS) : > > From: Peng Fan > > The return value is int type, not sc_err_t(u8), correct the usage. > > Signed-off-by: Peng Fan Tested-by: Oliver Graute Reviewed-by: Oliver Graute

Re: [PATCH 06/30] imx: congatec/cgtqmx8: correct SCU API usage

2023-06-06 Thread Oliver Graute
> Am 02.06.2023 um 08:45 schrieb Peng Fan (OSS) : > > From: Peng Fan > > The return value is int type, not sc_err_t(u8), correct the usage. > > Signed-off-by: Peng Fan Tested-by: Oliver Graute Reviewed-by: Oliver Graute

Re: [PATCH] ubifs: allow loading to above 4GiB

2023-06-06 Thread Heiko Schocher
Hello Ben, On 06.06.23 12:30, Ben Dooks wrote: > On 05/06/2023 08:45, Heiko Schocher wrote: >> Hello Ben, >> >> On 10.05.23 15:41, Ben Dooks wrote: >>> The ubifsload command is truncating any address above 4GiB as it casts >>> this address to an u32, instead of using an unsigned long which most of

Re: [PATCH] ubifs: allow loading to above 4GiB

2023-06-06 Thread Ben Dooks
On 05/06/2023 08:45, Heiko Schocher wrote: Hello Ben, On 10.05.23 15:41, Ben Dooks wrote: The ubifsload command is truncating any address above 4GiB as it casts this address to an u32, instead of using an unsigned long which most of the other load commands do. Change this to an unsigned long to

Re: [RFC PATCH] mmc: zynq_sdhci: Dependable card detect

2023-06-06 Thread Stefan Herbrechtsmeier
Hi Ashok, Am 06.06.2023 um 10:20 schrieb Soma, Ashok Reddy: Hi Stefan, -Original Message- From: Stefan Herbrechtsmeier Sent: Monday, May 22, 2023 1:26 PM To: Soma, Ashok Reddy ; u- b...@lists.denx.de Cc: Stefan Herbrechtsmeier ; Jaehoon Chung ; Simek, Michal ; Peng Fan ; Potthuri, Sa

Re: [PATCH v8 10/10] test/py: efi_capsule: test for FMP versioning

2023-06-06 Thread Heinrich Schuchardt
On 6/6/23 11:40, Masahisa Kojima wrote: This test covers the FMP versioning for both raw and FIT image, and both signed and non-signed capsule update. Signed-off-by: Masahisa Kojima Thanks for fixing some of the pylint issued. Could you, please, run pylint --enable-all-extensions test/py/te

Re: [EXT] Re: [PATCH v1 3/4] DTS: imx93: modify the BUCK1 voltage range

2023-06-06 Thread Marek Vasut
On 6/6/23 08:09, Joy Zou wrote: -Original Message- From: Joy Zou Sent: 2023年6月5日 18:24 To: Marek Vasut ; jh80.ch...@samsung.com; Peng Fan ; Ye Li ; Jacky Bai ; feste...@denx.de; sba...@denx.de; heiko.thi...@gmail.com Cc: u-boot@lists.denx.de; dl-uboot-imx Subject: RE: [EXT] Re: [PATCH

[PATCH v8 09/10] test: efi_capsule: refactor efi_capsule test

2023-06-06 Thread Masahisa Kojima
Current efi capsule python tests have much code duplication. This commit creates the common function in test/py/tests/test_efi_capsule/capsule_common.py, aim to reduce the code size and improve maintainability. Reviewed-by: Simon Glass Signed-off-by: Masahisa Kojima --- Changes in v8: - add func

[PATCH v8 10/10] test/py: efi_capsule: test for FMP versioning

2023-06-06 Thread Masahisa Kojima
This test covers the FMP versioning for both raw and FIT image, and both signed and non-signed capsule update. Signed-off-by: Masahisa Kojima --- Changes in v8: - remove excess semicolons Changes in v7: - use newly introduced common functions of efi_capsule test test/py/tests/test_efi_capsule/

[PATCH v8 08/10] doc: uefi: add anti-rollback documentation

2023-06-06 Thread Masahisa Kojima
This commit describe the procedure to configure lowest supported version in the device tree for anti-rollback protection. Signed-off-by: Masahisa Kojima --- No update since v7 Changes in v7: - describe the usage Newly created in v6 doc/develop/uefi/uefi.rst | 39 ++

[PATCH v8 06/10] mkeficapsule: add FMP Payload Header

2023-06-06 Thread Masahisa Kojima
Current mkeficapsule tool does not provide firmware version management. EDK II reference implementation inserts the FMP Payload Header right before the payload. It coutains the fw_version and lowest supported version. This commit adds a new parameters required to generate the FMP Payload Header fo

[PATCH v8 07/10] doc: uefi: add firmware versioning documentation

2023-06-06 Thread Masahisa Kojima
This commit describes the procedure to add the firmware version into the capsule file. Signed-off-by: Masahisa Kojima --- No update since v7 Changes in v7: - move documentation into "Creating a capsule file" - cleary describe the --fw-version option Newly created in v6 doc/develop/uefi/uefi.r

[PATCH v8 05/10] efi_loader: check lowest supported version

2023-06-06 Thread Masahisa Kojima
The FMP Payload Header which EDK II capsule generation scripts insert has a firmware version. This commit reads the lowest supported version stored in the device tree, then check if the firmware version in FMP payload header of the ongoing capsule is equal or greater than the lowest supported versi

[PATCH v8 04/10] efi_loader: get lowest supported version from device tree

2023-06-06 Thread Masahisa Kojima
This commit gets the lowest supported version from device tree, then fills the lowest supported version in FMP->GetImageInfo(). Signed-off-by: Masahisa Kojima Reviewed-by: Ilias Apalodimas --- No update since v6 Changed in v6: - fw_version is removed from device tree .../firmware/firmware-ver

[PATCH v8 03/10] efi_loader: versioning support in GetImageInfo

2023-06-06 Thread Masahisa Kojima
Current FMP->GetImageInfo() always return 0 for the firmware version, user can not identify which firmware version is currently running through the EFI interface. This commit reads the "FmpState" EFI variable, then fills the firmware version in FMP->GetImageInfo(). Now FMP->GetImageInfo() and

[PATCH v8 02/10] efi_loader: store firmware version into FmpState variable

2023-06-06 Thread Masahisa Kojima
Firmware version management is not implemented in the current FMP protocol. EDK II reference implementation capsule generation script inserts the FMP Payload Header right before the payload, FMP Payload Header contains the firmware version and lowest supported version. This commit utilizes the FMP

[PATCH v8 01/10] efi_loader: add the number of image entries in efi_capsule_update_info

2023-06-06 Thread Masahisa Kojima
The number of image array entries global variable is required to support EFI capsule update. This information is exposed as a num_image_type_guids variable, but this information should be included in the efi_capsule_update_info structure. This commit adds the num_images member in the efi_capsule_u

[PATCH v8 00/10] FMP versioning support

2023-06-06 Thread Masahisa Kojima
Firmware version management is not implemented in the current FMP implementation. This series aims to add the versioning support in FMP. Currently, there is no way to know the current running firmware version through the EFI interface. FMP->GetImageInfo() returns always 0 for the version number. S

Re: [PATCH v7 09/10] test: efi_capsule: refactor efi_capsule test

2023-06-06 Thread Masahisa Kojima
On Thu, 1 Jun 2023 at 12:28, Simon Glass wrote: > > On Tue, 30 May 2023 at 21:36, Masahisa Kojima > wrote: > > > > Current efi capsule python tests have much code duplication. > > This commit creates the common function > > in test/py/tests/test_efi_capsule/capsule_common.py, > > aim to reduce th

Re: [PATCH v7 10/10] test/py: efi_capsule: test for FMP versioning

2023-06-06 Thread Masahisa Kojima
On Mon, 5 Jun 2023 at 23:04, Schmidt, Malte wrote: > > Hello Masahisa Kojima, > > I noticed some excess semicolons in your Python code. See below. > > Am 31.05.2023 um 05:35 schrieb Masahisa Kojima: > > This test covers the FMP versioning for both raw and FIT image, > > and both signed and non-sig

[PATCHv2] ubifs: allow loading to above 4GiB

2023-06-06 Thread Ben Dooks
The ubifsload command is truncating any address above 4GiB as it casts this address to an u32, instead of using an unsigned long which most of the other load commands do. Change this to an unsigned long to allow loading into high memory for boards which use these areas. Fixes the following error:

RE: [RFC PATCH] mmc: zynq_sdhci: Dependable card detect

2023-06-06 Thread Soma, Ashok Reddy
Hi Stefan, > -Original Message- > From: Stefan Herbrechtsmeier o...@weidmueller.com> > Sent: Monday, May 22, 2023 1:26 PM > To: Soma, Ashok Reddy ; u- > b...@lists.denx.de > Cc: Stefan Herbrechtsmeier ; > Jaehoon Chung ; Simek, Michal > ; Peng Fan ; Potthuri, Sai > Krishna > Subject: Re

Re: [PATCH v7 1/4] Move bootorder and bootoption apis to lib

2023-06-06 Thread Heinrich Schuchardt
On 5/31/23 19:45, Raymond Mao wrote: Rename and move bootorder and bootoption apis from cmd to lib for re-use between eficonfig and bootmgr Signed-off-by: Raymond Mao Reviewed-by: Heinrich Schuchardt --- Changes in v3 - Split the patch into moving and renaming functions and individual patch

Re: [PATCH v4 10/11] configs: starfive: Enable ethernet configuration for StarFive VisionFive2

2023-06-06 Thread yanhong wang
On 2023/6/5 2:53, Jan Kiszka wrote: > On 25.05.23 11:36, Yanhong Wang wrote: >> Enable DWC_ETH_QOS and PHY_MOTORCOMM configuration to support ethernet >> function for StarFive VisionFive 2 board,including versions 1.2A and >> 1.3B. >> >> Signed-off-by: Yanhong Wang >> --- >> configs/starfive_

  1   2   >