Re: [PATCH 2/2] xilinx: zynqmp: Add missing prototype for board_boot_order

2023-02-20 Thread Michal Simek
On 2/21/23 08:03, Ashok Reddy Soma wrote: From: Algapally Santosh Sagar Add missing prototype to fix the sparse warning, warning: no previous prototype for 'board_boot_order' [-Wmissing-prototypes]. Signed-off-by: Algapally Santosh Sagar Signed-off-by: Ashok Reddy Soma --- arch/arm/mac

[PATCH 2/2] xilinx: zynqmp: Add missing prototype for board_boot_order

2023-02-20 Thread Ashok Reddy Soma
From: Algapally Santosh Sagar Add missing prototype to fix the sparse warning, warning: no previous prototype for 'board_boot_order' [-Wmissing-prototypes]. Signed-off-by: Algapally Santosh Sagar Signed-off-by: Ashok Reddy Soma --- arch/arm/mach-zynqmp/include/mach/sys_proto.h | 1 + common/

[PATCH 1/2] xilinx: zynqmp: Add missing prototype for zynqmp_mmio_write

2023-02-20 Thread Ashok Reddy Soma
From: Algapally Santosh Sagar Add missing prototype to fix the sparse warning, warning: no previous prototype for 'zynqmp_mmio_write' [-Wmissing-prototypes]. Signed-off-by: Algapally Santosh Sagar Signed-off-by: Ashok Reddy Soma --- arch/arm/mach-versal-net/include/mach/sys_proto.h | 7 +

[PATCH 0/2] Fix sparse warnings

2023-02-20 Thread Ashok Reddy Soma
Run and fix sparse warnings in below files -arch/arm/mach-zynqmp/include/mach/sys_proto.h -common/spl/spl.c -arch/arm/mach-versal-net/include/mach/sys_proto.h -arch/arm/mach-versal/include/mach/sys_proto.h -drivers/mmc/zynq_sdhci.c -drivers/spi/zynqmp_gqspi.c Algapally Santosh Sagar (2):

[PATCH v5] efi_loader: update SetVariable attribute check

2023-02-20 Thread Masahisa Kojima
UEFI specification v2.10 says that EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS is deprecated and EFI_UNSUPPORTED should be returned in SetVariable variable service. Current implementation returns EFI_INVALID_PARAMETER, let's fix the return value. Together with above change, this commit also updates th

Re: [PATCH v4] efi_loader: update SetVariable attribute check

2023-02-20 Thread Masahisa Kojima
Hi Heinrich, On Mon, 20 Feb 2023 at 22:44, Heinrich Schuchardt wrote: > > On 2/20/23 11:31, Masahisa Kojima wrote: > > UEFI specification v2.10 says that > > EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS is deprecated and > > EFI_UNSUPPORTED should be returned in SetVariable variable service. > > Curre

Re: [PATCH 3/4] mtd/fpga: add fpga directory to mtd (with Cyclone 10)

2023-02-20 Thread Marek Vasut
On 2/21/23 00:47, Ulf Samuelsson wrote: Den 2023-02-20 kl. 23:34, skrev Marek Vasut: On 2/20/23 22:29, Ulf Samuelsson wrote: [...] To sum it up: - The only part of the MTD subsystem that is in use by this driver is the write callback, everything else is unused. That does not make MTD subs

Re: [PATCH v2 9/9] usb: xhci: Fix root hub descriptor

2023-02-20 Thread Marek Vasut
On 2/21/23 00:45, Simon Glass wrote: On Sat, 21 Jan 2023 at 12:28, Mark Kettenis wrote: When a system has multiple XHCI controllers, some of the properties described in the descriptor of the root hub (such as the number of ports) might differ between controllers. Fix this by switching from a

Re: [PATCH 3/4] mtd/fpga: add fpga directory to mtd (with Cyclone 10)

2023-02-20 Thread Ulf Samuelsson
Den 2023-02-20 kl. 23:34, skrev Marek Vasut: On 2/20/23 22:29, Ulf Samuelsson wrote: [...] To sum it up: - The only part of the MTD subsystem that is in use by this driver is the write callback, everything else is unused. That does not make MTD subsystem the right tool. No, the MTD subs

Re: [PATCH 08/13] usb: Quieten a debug message

2023-02-20 Thread Simon Glass
Hi Mark, On Mon, 20 Feb 2023 at 13:01, Mark Kettenis wrote: > > > From: Simon Glass > > Date: Mon, 20 Feb 2023 12:49:22 -0700 > > > > This comes up repeatedly on Intel ADL. Use a debug message instead. > > commit e330c8b83e87 fixed the (likely) root cause for this error > message. Are you still

Re: [PATCH v2 9/9] usb: xhci: Fix root hub descriptor

2023-02-20 Thread Simon Glass
On Sat, 21 Jan 2023 at 12:28, Mark Kettenis wrote: > > When a system has multiple XHCI controllers, some of the > properties described in the descriptor of the root hub (such as > the number of ports) might differ between controllers. Fix this > by switching from a single global hub descriptor to

Re: [PATCH 2/2] board: rock5b-rk3588: add memory gaps into kernel's DTB

2023-02-20 Thread Mark Kettenis
> From: Eugen Hristev > Date: Thu, 16 Feb 2023 15:29:05 +0200 > > RK3588 has two memory gaps when using 16 GiB DRAM size: > [0x3fc00 , 0x3fc50] > and > [0x3fff0 , 0x3] > > If the kernel is agnostic to these gaps, accessing the area causes > a SError panic. > > Hence, add res

Re: [PATCH 3/4] mtd/fpga: add fpga directory to mtd (with Cyclone 10)

2023-02-20 Thread Marek Vasut
On 2/20/23 22:29, Ulf Samuelsson wrote: [...] To sum it up: - The only part of the MTD subsystem that is in use by this driver is the write callback, everything else is unused. That does not make MTD subsystem the right tool. No, the MTD subsystem is compatible with the device tree. That

Re: [PATCH 3/4] mtd/fpga: add fpga directory to mtd (with Cyclone 10)

2023-02-20 Thread Ulf Samuelsson
Den 2023-02-20 kl. 17:17, skrev Marek Vasut: On 2/13/23 10:30, Ulf Samuelsson wrote: Den 2023-02-12 kl. 23:40, skrev Marek Vasut: On 2/12/23 23:07, Ulf Samuelsson wrote: Den 2023-02-12 kl. 21:01, skrev Marek Vasut:  > On 2/12/23 20:52, Ulf Samuelsson wrote:  >>  >>  >> Den 2023-02-12 kl.

[PATCH 2/2] tpm: Implement tpm_auto_start() for TPMv1.2

2023-02-20 Thread Simon Glass
Add an implementation of this, moving the common call to tpm_init() up into the common API implementation. Add a test. Signed-off-by: Simon Glass --- include/tpm-common.h | 2 +- include/tpm-v1.h | 11 +++ lib/tpm-v1.c | 16 lib/tpm-v2.c | 8 -

[PATCH 1/2] tpm: Separate out the TPM tests for v1 and v2

2023-02-20 Thread Simon Glass
Currently there is only one test and it only works on TPM v2. Update it to work on v1.2 as well, using a new function to pick up the required TPM. Update sandbox to include both a v1.2 and v2 TPM so that this works. Split out the existing test into two pieces, one for init and one for the v2-only

Re: [PATCH 08/13] usb: Quieten a debug message

2023-02-20 Thread Mark Kettenis
> From: Simon Glass > Date: Mon, 20 Feb 2023 12:49:22 -0700 > > This comes up repeatedly on Intel ADL. Use a debug message instead. commit e330c8b83e87 fixed the (likely) root cause for this error message. Are you still seeing this message with that commit present? > Signed-off-by: Simon Glass

Re: [PATCH] net: ipv6: IPv6 environment variable cleanup

2023-02-20 Thread Sean Edmond
Sat, Feb 18, 2023 at 10:09:56PM +0200, Ramon Fried wrote: > On Thu, Feb 16, 2023 at 6:39 AM wrote: > > > > From: Sean Edmond > > > > Fix "setenv gatewayip6". > > > > Synchronize IPv6 local variables with environment variables > > in netboot_update_env() > > > > Signed-off-by: Sean Edmond > > ---

[PATCH 12/13] x86: coreboot: Log function names and line numbers

2023-02-20 Thread Simon Glass
Turn these options on to make it easier to debug things. Also enable dhrystone so we can get some measure of performance. Signed-off-by: Simon Glass --- configs/coreboot_defconfig | 4 1 file changed, 4 insertions(+) diff --git a/configs/coreboot_defconfig b/configs/coreboot_defconfig in

[PATCH 05/13] x86: coreboot: Collect the address of the ACPI tables

2023-02-20 Thread Simon Glass
Pick this up from the sysinfo tables and display it with the cbsysinfo command. This allows the 'acpi list' command to work when booting from coreboot. Signed-off-by: Simon Glass --- arch/x86/include/asm/cb_sysinfo.h | 2 ++ arch/x86/include/asm/coreboot_tables.h | 2 ++ arch/x86/lib/cor

[PATCH 07/13] pci: coreboot: Don't read regions when booting

2023-02-20 Thread Simon Glass
When U-Boot is the second-stage bootloader, PCI is already set up. We cannot read the regions from the device tree. There is no point anyway, since PCI devices have already been allocated according to the regions and it is not safe for U-Boot to make any changes. Signed-off-by: Simon Glass ---

[PATCH 10/13] x86: coreboot: Document how to enable the debug UART

2023-02-20 Thread Simon Glass
This is not obvious so add a little note about how it works. Signed-off-by: Simon Glass --- doc/board/coreboot/coreboot.rst | 29 + 1 file changed, 29 insertions(+) diff --git a/doc/board/coreboot/coreboot.rst b/doc/board/coreboot/coreboot.rst index 4a5f101cad2..0fe

[PATCH 13/13] x86: coreboot: Show unimplemented sysinfo tags

2023-02-20 Thread Simon Glass
Sometimes coreboot adds new tags that U-Boot does not know about. These are silently ignored, but it is useful to at least know what we are missing. Add a way to collect this information. For Brya it shows: Unimpl. 38 41 37 34 42 40 These are: LB_TAG_PLATFORM_BLOB_VERSION LB_TAG_ACPI_C

[PATCH 04/13] x86: coreboot: Allow ACPI tables to be recorded

2023-02-20 Thread Simon Glass
At present any ACPI tables created by prior-stage firmware are ignored. It is useful to be able to view these in U-Boot. Add the acpi command for coreboot and use that to allow recording the ACPI-table start. Signed-off-by: Simon Glass --- cmd/Kconfig | 3 +-- cmd/acpi.c

[PATCH 09/13] x86: coreboot: Use a memory-mapped UART

2023-02-20 Thread Simon Glass
This is much more common on modern hardware, so default to using it. Signed-off-by: Simon Glass --- include/configs/coreboot.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/configs/coreboot.h b/include/configs/coreboot.h index f73004386fd..2775f8d76ce 100644 --- a/include/config

[PATCH 11/13] x86: coreboot: Scan PCI after relocation

2023-02-20 Thread Simon Glass
Enable this so that PCI devices can be used correctly without needing to do a manual scan. Signed-off-by: Simon Glass --- configs/coreboot_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/coreboot_defconfig b/configs/coreboot_defconfig index d8c5be66ad7..1c5e7fc717d 100644

[PATCH 06/13] x86: Allow locating UARTs by device ID

2023-02-20 Thread Simon Glass
When coreboot does not pass a UART in its sysinfo struct, there is no easy way to find it out. Add a way to specify known UARTs so we can find them without needing help from coreboot. Since coreboot does not actually init the serial device when serial is disabled, it is not possible to make it add

[PATCH 08/13] usb: Quieten a debug message

2023-02-20 Thread Simon Glass
This comes up repeatedly on Intel ADL. Use a debug message instead. Signed-off-by: Simon Glass --- drivers/usb/host/xhci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index dbeb88afe37..bd7e88b1769 100644 --- a/driver

[PATCH 03/13] input: Only reset the keyboard when running bare metal

2023-02-20 Thread Simon Glass
If U-Boot is not the first-stage bootloader we should not init the keyboard, since it has already been done. Check for this. Signed-off-by: Simon Glass --- drivers/input/i8042.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/input/i8042.c b/drivers/inp

[PATCH 01/13] mtrr: Don't show an invalid CPU number

2023-02-20 Thread Simon Glass
When U-Boot did not do the MP init, we don't get an actual CPU number here. Skip printing it in that case. Signed-off-by: Simon Glass --- cmd/x86/mtrr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cmd/x86/mtrr.c b/cmd/x86/mtrr.c index b213a942fde..95916933e9a 100644 --

[PATCH 02/13] x86: Adjust search range for sysinfo table

2023-02-20 Thread Simon Glass
Avoid searching starting at 0 since this memory may not be available and the table cannot be there anyway. Start at 0x400 instead. Signed-off-by: Simon Glass --- arch/x86/cpu/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/cpu/cpu.c b/arch/x86/cpu/cpu.c index

[PATCH 00/13] x86: Various minor enhancements for coreboot

2023-02-20 Thread Simon Glass
This series includes some patches generated while getting U-Boot to boot more nicely on Brya, an Adler Lake Chromebook. This includes: - show the ACPI tables with 'acpi list' - get the UART to work even if coreboot doesn't enable it - show unimplemented sysinfo tags - fix for keyboard not working

Re: [PATCH 1/6] clk: Handle error pointers in clk_valid()

2023-02-20 Thread Michal Suchánek
On Mon, Feb 20, 2023 at 10:57:17AM -0500, Sean Anderson wrote: > > On 2/20/23 05:46, Michal Suchánek wrote: > > On Sun, Feb 19, 2023 at 11:59:34PM -0600, Samuel Holland wrote: > > > Some clk uclass functions, such as devm_clk_get() and clk_get_parent(), > > > return error pointers. clk_valid() sho

RE: [EXTERNAL] Re: [PATCH] net: ipv6: IPv6 environment variable cleanup

2023-02-20 Thread Sean Edmond
>-Original Message- >From: Ramon Fried >Sent: Saturday, February 18, 2023 12:10 PM >To: seanedm...@linux.microsoft.com >Cc: u-boot@lists.denx.de; joe.hershber...@ni.com; w...@denx.de; Sean >Edmond >Subject: [EXTERNAL] Re: [PATCH] net: ipv6: IPv6 environment variable cleanup > >On Thu, Feb

Re: [PATCH 2/6] clk: Fix error handling in clk_get_rate()

2023-02-20 Thread Sean Anderson
On 2/20/23 12:27, Michal Suchánek wrote: Hello, On Mon, Feb 20, 2023 at 11:08:41AM -0500, Sean Anderson wrote: On 2/20/23 05:37, Michal Suchánek wrote: Hello, On Sun, Feb 19, 2023 at 11:59:35PM -0600, Samuel Holland wrote: log_ret() cannot work with unsigned values, and the assignment to 're

[PATCH v1 1/1] input: button_kbd: make driver complementary to gpio buttons

2023-02-20 Thread Svyatoslav Ryhel
Remove need of dts binding for button keyboard since it reuses gpio-keys binding. Select gpio-keys driver if button keyboard is selected since button keyboard can not operate on its own. Tested-by: Svyatoslav Ryhel # HTC One X T30 Signed-off-by: Svyatoslav Ryhel --- drivers/input/Kconfig |

[PATCH v1 0/1] GPIO buttons keyboard driver update

2023-02-20 Thread Svyatoslav Ryhel
Remove need of dts binding for button keyboard since it reuses gpio-keys binding. Select gpio-keys driver if button keyboard is selected since button keyboard can not operate on its own. Svyatoslav Ryhel (1): input: button_kbd: make driver complementary to gpio buttons drivers/input/Kconfig

Re: [PATCH 2/6] clk: Fix error handling in clk_get_rate()

2023-02-20 Thread Michal Suchánek
Hello, On Mon, Feb 20, 2023 at 11:08:41AM -0500, Sean Anderson wrote: > On 2/20/23 05:37, Michal Suchánek wrote: > > Hello, > > > > On Sun, Feb 19, 2023 at 11:59:35PM -0600, Samuel Holland wrote: > > > log_ret() cannot work with unsigned values, and the assignment to 'ret' > > > incorrectly trunc

Re: [PATCH v3 2/3] kconfig: new macro IF_ENABLED()

2023-02-20 Thread Andre Przywara
On Sun, 19 Feb 2023 12:36:28 +0100 Heinrich Schuchardt wrote: Hi, > We want to move from using #ifdef to using if in our code. A lot of our > code using #ifdef is structured like: > > #ifdef CONFIG_FOO > fun(CONFIG_FOO_OPT); > #endif > > In Kconfig you will find > > config

Re: [PATCH 2/3] remoteproc: Remove unused mem_type platform data

2023-02-20 Thread Tom Rini
On Mon, Feb 20, 2023 at 12:13:02AM -0600, Samuel Holland wrote: > There is only one possible value for this field, it is unused except for > debugging, and the devicetree property is not documented. > > Signed-off-by: Samuel Holland > --- > > cmd/remoteproc.c |

Re: [PATCH] WIP: TPM additions

2023-02-20 Thread Simon Glass
Hi Ilias, On Mon, 20 Feb 2023 at 09:48, Ilias Apalodimas wrote: > > Hi Simon, > > > + * @dev TPM device > > + * Return: TPM2_RC_SUCCESS, on success, or when the TPM returns > > + * TPM_INVALID_POSTINIT; TPM_FAILEDSELFTEST, if the TPM is in failure state > > + */ > > +u32 tpm1_auto_st

Re: [PATCH] WIP: TPM additions

2023-02-20 Thread Ilias Apalodimas
Hi Simon, > + * @dev TPM device > + * Return: TPM2_RC_SUCCESS, on success, or when the TPM returns > + * TPM_INVALID_POSTINIT; TPM_FAILEDSELFTEST, if the TPM is in failure state > + */ > +u32 tpm1_auto_start(struct udevice *dev); > + > #endif /* __TPM_V1_H */ > diff --git a/lib/tpm-v

[PATCH v2] tpm: Allow committing non-volatile data

2023-02-20 Thread Simon Glass
Add an option to tell the TPM to commit non-volatile data immediately it is changed, rather than waiting until later. This is needed in some situations, since if the device reboots it may not write the data. Add definitions for the rest of the Cr50 commands while we are here. Signed-off-by: Simon

Re: [PATCH] MAINTAINERS: assign sandbox drivers to SANDBOX

2023-02-20 Thread Simon Glass
On Sat, 18 Feb 2023 at 02:38, Heinrich Schuchardt wrote: > > Drivers should have a maintainer. > > Signed-off-by: Heinrich Schuchardt > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Simon Glass

Re: [PATCH v3 1/3] disk: accessors for conditional partition fields

2023-02-20 Thread Simon Glass
On Sun, 19 Feb 2023 at 04:36, Heinrich Schuchardt wrote: > > Structure disk_partition contains some fields whose existence depends on > configuration variables. Provide macros that return a value irrespective of > the value of configuration. This allows to replace #ifdefs by simple ifs > in codes

Re: [PATCH] pci: ecm generic: use dev_read_() interface

2023-02-20 Thread Simon Glass
On Sat, 18 Feb 2023 at 05:25, Mayuresh Chitale wrote: > > Use dev_read_() api instead of the fdtdec API to fetch the host > controller's reg property value. This is similar to the other host > controller drivers such as Sifive, Rockchip etc. Without this change, > enabling CONFIG_OF_LIVE breaks th

Re: [PATCH 1/1] doc: remove superfluous warning

2023-02-20 Thread Simon Glass
On Sun, 19 Feb 2023 at 13:33, Heinrich Schuchardt wrote: > > We have been using Sphinx >=3 since 2020. We don't expect issues. > > Signed-off-by: Heinrich Schuchardt > --- > doc/conf.py | 4 > 1 file changed, 4 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH 2/3] remoteproc: Remove unused mem_type platform data

2023-02-20 Thread Simon Glass
On Sun, 19 Feb 2023 at 23:13, Samuel Holland wrote: > > There is only one possible value for this field, it is unused except for > debugging, and the devicetree property is not documented. > > Signed-off-by: Samuel Holland > --- > > cmd/remoteproc.c | 12 +---

Re: [PATCH 6/6] clk: Add a .get_parent operation

2023-02-20 Thread Simon Glass
Hi Samuel, On Sun, 19 Feb 2023 at 23:00, Samuel Holland wrote: > > This allows clk_get_parent() to work with non-CCF clock drivers. > > Signed-off-by: Samuel Holland > --- > > drivers/clk/clk-uclass.c | 18 -- > include/clk-uclass.h | 2 ++ > 2 files changed, 14 insertions(

Re: rk3399 boards broken, only partially converted to standard boot? (was Re: [PATCH 71/71] rockchip: Convert rockpro64-rk3399 to use standard boot)

2023-02-20 Thread Simon Glass
Hi Vagrant, On Sat, 18 Feb 2023 at 19:19, Vagrant Cascadian wrote: > > On 2022-12-07, Simon Glass wrote: > > Drop the use of scripts and rely on standard boot for all operation. > > This patch, applied as 3891c68ef50eda38d78c95ecd03aed030aa6bb53 broke > booting on pinebook-pro-rk3399, which still

Re: [PATCH 3/4] mtd/fpga: add fpga directory to mtd (with Cyclone 10)

2023-02-20 Thread Marek Vasut
On 2/13/23 10:30, Ulf Samuelsson wrote: Den 2023-02-12 kl. 23:40, skrev Marek Vasut: On 2/12/23 23:07, Ulf Samuelsson wrote: Den 2023-02-12 kl. 21:01, skrev Marek Vasut:  > On 2/12/23 20:52, Ulf Samuelsson wrote:  >>  >>  >> Den 2023-02-12 kl. 20:31, skrev Marek Vasut:  >>  > On 2/11/23 11:07

Re: [PATCH 6/6] clk: Add a .get_parent operation

2023-02-20 Thread Sean Anderson
On 2/20/23 00:59, Samuel Holland wrote: This allows clk_get_parent() to work with non-CCF clock drivers. Signed-off-by: Samuel Holland --- drivers/clk/clk-uclass.c | 18 -- include/clk-uclass.h | 2 ++ 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/dri

Re: [PATCH 5/6] clk: Remove an unneeded check from clk_get_parent_rate()

2023-02-20 Thread Sean Anderson
On 2/20/23 00:59, Samuel Holland wrote: There is no need to check the parent clock's ops. The following call to clk_get_rate() does that already. Signed-off-by: Samuel Holland --- drivers/clk/clk-uclass.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/clk/clk-uclass.c b/dri

Re: [PATCH 4/6] clk: Fix rate caching in clk_get_parent_rate()

2023-02-20 Thread Sean Anderson
On 2/20/23 00:59, Samuel Holland wrote: clk_get_rate() can return an error value. Recompute the rate if the cached value is an error value. Fixes: 4aa78300a025 ("dm: clk: Define clk_get_parent_rate() for clk operations") Signed-off-by: Samuel Holland --- drivers/clk/clk-uclass.c | 3 ++- 1

Re: [PATCH 2/6] clk: Fix error handling in clk_get_rate()

2023-02-20 Thread Sean Anderson
On 2/20/23 05:37, Michal Suchánek wrote: Hello, On Sun, Feb 19, 2023 at 11:59:35PM -0600, Samuel Holland wrote: log_ret() cannot work with unsigned values, and the assignment to 'ret' incorrectly truncates the rate from long to int. Fixes: 5c5992cb90cf ("clk: Add debugging for return values")

Re: [PATCH V3] arm64: imx: Add support for imx8mp-beacon-kit

2023-02-20 Thread Tom Rini
On Mon, Feb 20, 2023 at 09:50:58AM -0600, Adam Ford wrote: > Beacon Embedded has an i.MX8M Plus development kit which consists > of a SOM + baseboard. The SOM includes Bluetooth, WiFi, QSPI, eMMC, > and one Ethernet PHY. The baseboard includes audio, HDMI, USB-C Dual > Role port, USB Hub with fiv

Re: [PATCH 1/6] clk: Handle error pointers in clk_valid()

2023-02-20 Thread Sean Anderson
On 2/20/23 05:46, Michal Suchánek wrote: On Sun, Feb 19, 2023 at 11:59:34PM -0600, Samuel Holland wrote: Some clk uclass functions, such as devm_clk_get() and clk_get_parent(), return error pointers. clk_valid() should not consider these pointers to be valid. Fixes: 8a1661f20e6c ("drivers: clk

Re: [PATCH v4 00/10] usb: dwc3: Refactor dwc3-generic and apply to dwc3-uniphier

2023-02-20 Thread Marek Vasut
On 2/20/23 06:50, Kunihiko Hayashi wrote: This series achieves refactoring of dwc3-generic. First, dwc3-generic allows DT controller nodes to be children of glue nodes, but outside of glue nodes. To achieve this goal, define a glue-specific function to get controller node, look up more referenc

Re: [PATCH v4 07/10] clk: uniphier: Add missing USB SS-PHY clocks

2023-02-20 Thread Marek Vasut
On 2/20/23 06:50, Kunihiko Hayashi wrote: The USB SS-PHY needs its own clock, however, some clocks don't have clock gates. Define missing clock entries for the PHY as reference clock. Signed-off-by: Kunihiko Hayashi Since I'm not familiar with this platform, I am adding this only for complet

[PATCH V3] arm64: imx: Add support for imx8mp-beacon-kit

2023-02-20 Thread Adam Ford
Beacon Embedded has an i.MX8M Plus development kit which consists of a SOM + baseboard. The SOM includes Bluetooth, WiFi, QSPI, eMMC, and one Ethernet PHY. The baseboard includes audio, HDMI, USB-C Dual Role port, USB Hub with five ports, a PCIe slot, and a second Ethernet PHY. The device trees a

Re: [PATCH v4 08/10] phy: socionext: Add UniPhier USB3 PHY driver

2023-02-20 Thread Marek Vasut
On 2/20/23 06:50, Kunihiko Hayashi wrote: [...] +static int uniphier_usb3phy_probe(struct udevice *dev) +{ [...] + priv->rst_parent = devm_reset_control_get_optional(dev, "gio"); + if (IS_ERR(priv->rst_parent)) { + printf("Failed to get parent reset\n"); +

Re: Pull request for efi-2023-04-rc3

2023-02-20 Thread Tom Rini
On Sun, Feb 19, 2023 at 11:00:55PM +0100, Heinrich Schuchardt wrote: > Dear Tom, > > The following changes since commit 1198b38ba980efed050c878c083607d997010e03: > > Merge branch '2023-02-17-assorted-fixes' (2023-02-17 14:18:46 -0500) > > are available in the Git repository at: > > https:/

[PATCH v3] Let the EQoS in imx8mp handle fixed-phy too.

2023-02-20 Thread Elmar Psilog
Without that patch it lost track to the node to scan speed and duplex. Patch was created by Marek Vasut, just tested by me. Signed-off-by: Elmar Psilog Reviewed-by: Marek Vasut --- changes v2: fix format issues changes v3: remove {} around single if, add reviewd.. drivers/net/dwc_eth_qos.c

[PATCH] WIP: TPM additions

2023-02-20 Thread Simon Glass
Signed-off-by: Simon Glass --- arch/sandbox/dts/test.dts | 4 ++ include/tpm-v1.h | 11 lib/tpm-v1.c | 11 lib/tpm-v2.c | 8 --- lib/tpm_api.c | 19 +-- test/dm/tpm.c | 105 ++ 6 f

[PATCH] doc: uefi: fix links

2023-02-20 Thread Vincent Stehlé
Fix a couple of links so that they are rendered correctly with sphinx. Signed-off-by: Vincent Stehlé Cc: Heinrich Schuchardt Cc: Ilias Apalodimas --- doc/develop/uefi/fwu_updates.rst | 3 ++- doc/develop/uefi/uefi.rst| 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --gi

[PATCH 2/2] configs:pm9g45_deconfig:Modify to use standard ECC layout

2023-02-20 Thread Ilko Iliev
This patch removes CONFIG_SYS_NAND_DRIVER_ECC_LAYOUT because the board uses standard ECC layout Signed-off-by: Ilko Iliev --- configs/pm9g45_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/configs/pm9g45_defconfig b/configs/pm9g45_defconfig index 9b22d4aa9b..0afdd0abcf 100644 --- a

[PATCH 1/2] configs:pm9g45_defconfig:Fix boot arguments and boot command

2023-02-20 Thread Ilko Iliev
This patch modify boot arguments and boot command to load 512KB DTB and 8MB Linux Kernel Signed-off-by: Ilko Iliev --- configs/pm9g45_defconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configs/pm9g45_defconfig b/configs/pm9g45_defconfig index e7b4d967f2..9b22d4aa

Re: [PATCH v4] efi_loader: update SetVariable attribute check

2023-02-20 Thread Heinrich Schuchardt
On 2/20/23 11:31, Masahisa Kojima wrote: UEFI specification v2.10 says that EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS is deprecated and EFI_UNSUPPORTED should be returned in SetVariable variable service. Current implementation returns EFI_INVALID_PARAMETER, let's fix the return value. Together wit

Compiling U-BOOT PNX8473 help config device

2023-02-20 Thread Cento50Shopping Michele della guardia
Hello nice for meet to this group I need help for study and compiling any U-Boot file binary for inizialize my machine . Pnx8473 arm Online i have found only one link,talk for box "prismcube recovery".this boot charge correct to my CPU but not inizialize USB.the sure the hardware not are the sam

Re: [PATCH v4 4/4] rockchip: mkimage: Update init size limit for RK3328 and RK3568

2023-02-20 Thread Quentin Schulz
Hi Jonas, On 2/19/23 16:06, Jonas Karlman wrote: Latest vendor TPL for RK3328 has grown past the current init size limit of 28KiB and the current init size limit for RK3568 of 76KiB is too big to fit in 64KiB SRAM. Sync init size limit from vendor u-boot for the following SoCs: rk3328: 30KiB

Re: [PATCH 5/5] binman: Make the tooldir configurable

2023-02-20 Thread Quentin Schulz
Hi Simon, On 2/18/23 00:19, Simon Glass wrote: Add a command-line argument for setting the tooldir, so that the default can be overridden. Add this directory to the toolpath automatically. Create the directory if it does not already exist. Put the default in the argument parser instead of the c

Re: [PATCH] binman: Avoid requiring a home directory on startup

2023-02-20 Thread Quentin Schulz
Hi Simon, On 2/18/23 00:49, Simon Glass wrote: Hi Quentin, On Fri, 17 Feb 2023 at 05:21, Quentin Schulz wrote: Hi all, On 2/17/23 03:55, Simon Glass wrote: Hi Tom, On Thu, 16 Feb 2023 at 17:19, Tom Rini wrote: On Thu, Feb 16, 2023 at 05:12:33PM -0700, Simon Glass wrote: Hi Tom, On Tu

Re: [PATCH 5/6] clk: Remove an unneeded check from clk_get_parent_rate()

2023-02-20 Thread Michal Suchánek
On Sun, Feb 19, 2023 at 11:59:38PM -0600, Samuel Holland wrote: > There is no need to check the parent clock's ops. The following call to > clk_get_rate() does that already. > > Signed-off-by: Samuel Holland > --- > > drivers/clk/clk-uclass.c | 5 - > 1 file changed, 5 deletions(-) > > dif

[PATCH v5 1/1] video console: refactoring and optimization

2023-02-20 Thread Dzmitry Sankouski
- move common code to vidconsole_internal.h and console_core.c - unite probe functions - get rid of code duplications in switch across bpp values - extract common pixel fill logic in two functions one per horizontal and vertical filling - rearrange statements in put_xy* methods in unified way - rep

[PATCH v5 0/1] vidconsole: refactoring and support for wider fonts

2023-02-20 Thread Dzmitry Sankouski
Version 5 contain minor changes: - move common functions to console-core.c file - remove static keyword from shared functions In version 4, only first patch sent, because review fixes to this would add large rebase & patch formatting overhead. When it'll receive reviewed tag, I'll resent entire re

Re: [PATCH 1/6] clk: Handle error pointers in clk_valid()

2023-02-20 Thread Michal Suchánek
On Sun, Feb 19, 2023 at 11:59:34PM -0600, Samuel Holland wrote: > Some clk uclass functions, such as devm_clk_get() and clk_get_parent(), > return error pointers. clk_valid() should not consider these pointers > to be valid. > > Fixes: 8a1661f20e6c ("drivers: clk: Handle gracefully NULL pointers")

Re: [PATCH 4/6] clk: Fix rate caching in clk_get_parent_rate()

2023-02-20 Thread Michal Suchánek
On Sun, Feb 19, 2023 at 11:59:37PM -0600, Samuel Holland wrote: > clk_get_rate() can return an error value. Recompute the rate if the > cached value is an error value. > > Fixes: 4aa78300a025 ("dm: clk: Define clk_get_parent_rate() for clk > operations") > Signed-off-by: Samuel Holland > --- >

Re: [PATCH 3/6] clk: Fix error handling in clk_get_parent()

2023-02-20 Thread Michal Suchánek
On Sun, Feb 19, 2023 at 11:59:36PM -0600, Samuel Holland wrote: > Do not return both NULL and error pointers. The function is only > documented as returning error pointers. > > Fixes: 8a1661f20e6c ("drivers: clk: Handle gracefully NULL pointers") > Signed-off-by: Samuel Holland > --- > > driver

Re: [PATCH 2/6] clk: Fix error handling in clk_get_rate()

2023-02-20 Thread Michal Suchánek
Hello, On Sun, Feb 19, 2023 at 11:59:35PM -0600, Samuel Holland wrote: > log_ret() cannot work with unsigned values, and the assignment to 'ret' > incorrectly truncates the rate from long to int. > > Fixes: 5c5992cb90cf ("clk: Add debugging for return values") > Signed-off-by: Samuel Holland > -

Re: [PATCH v4 1/1] video console: refactoring and optimization

2023-02-20 Thread Dzmitry Sankouski
сб, 18 февр. 2023 г. в 02:49, Simon Glass : > > Hi Dzmitry, > > On Fri, 17 Feb 2023 at 08:01, Dzmitry Sankouski wrote: > > > > - move common code to vidconsole_internal.h > > - unite probe functions > > - get rid of code duplications in switch across bpp values > > - extract common pixel fill logi

[PATCH v4] efi_loader: update SetVariable attribute check

2023-02-20 Thread Masahisa Kojima
UEFI specification v2.10 says that EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS is deprecated and EFI_UNSUPPORTED should be returned in SetVariable variable service. Current implementation returns EFI_INVALID_PARAMETER, let's fix the return value. Together with above change, this commit also updates th

Re: [PATCH v3 58/76] Drop ubsha1 tool

2023-02-20 Thread Peter Robinson
On Wed, Feb 1, 2023 at 8:46 PM Simon Glass wrote: > > This seems to have been used by ppc4xx which was removed a while back. > The Kconfig does not exist so it is never built. Drop it. That assumption isn't entirely correct, it was at least built by the tools only/all build process. Peter > Sig

[PATCH v1 09/11] video: tegra20: add DSI controller driver

2023-02-20 Thread Svyatoslav Ryhel
Adds support for both DSI outputs found on Tegra. Only very minimal functionality is implemented, so advanced features like ganged mode won't work. Driver is heavily based on mainline Tegra DSI and re-uses much of its features. Only T30 is supported for now but T20 support can be added if any supp

[PATCH v1 10/11] simple_panel: add support for get_display_timing

2023-02-20 Thread Svyatoslav Ryhel
Some cases may require passing display timings from panel driver. To handle such cases support parsing device tree panel node for timing subnode. Tested-by: Andreas Westman Dorcsak # ASUS TF T30 Tested-by: Robert Eckelmann # ASUS TF101 T20 Tested-by: Svyatoslav Ryhel # Google Nexus 7 2012 Signe

[PATCH v1 11/11] simple_panel: support simple MIPI DSI panels

2023-02-20 Thread Svyatoslav Ryhel
Re-use simple panel driver for MIPI DSI panels which do not require additional DSI commands for setup. Tested-by: Andreas Westman Dorcsak # ASUS TF700T T30 Signed-off-by: Svyatoslav Ryhel --- drivers/video/simple_panel.c | 37 1 file changed, 33 insertions(+

[PATCH v1 08/11] video: tegra-dc: pass DC regmap to internal devices

2023-02-20 Thread Svyatoslav Ryhel
Internal video devices like DSI and HDMI controllers require sending commands into DC register field. To make this available, lets create platform data, which is restricted to pass DC regmap only to pre-defined devices. Tested-by: Andreas Westman Dorcsak # ASUS TF T30 Tested-by: Robert Eckelmann

[PATCH v1 07/11] video: tegra-dc: add panel_set_backlight call

2023-02-20 Thread Svyatoslav Ryhel
Tegra DC driver does not call panel_set_backlight, which can result in absence of backlight on device. Fix this by calling panel_set_backlight with BACKLIGHT_DEFAULT just after panel_enable_backlight. Signed-off-by: Svyatoslav Ryhel --- drivers/video/tegra20/tegra-dc.c | 7 +++ 1 file change

[PATCH v1 06/11] video: tegra-dc: add 180 degree panel rotation

2023-02-20 Thread Svyatoslav Ryhel
Unlike 90 and 270 degree rotation, 180 degree rotation is more common and does not require scaling. Implement it for correct grouper support. Tested-by: Svyatoslav Ryhel # Google Nexus 7 2012 Signed-off-by: Svyatoslav Ryhel --- drivers/video/tegra20/tegra-dc.c | 23 +++ 1 fi

[PATCH v1 04/11] video: tegra-dc: request timings from panel driver first

2023-02-20 Thread Svyatoslav Ryhel
Check if panel driver has display timings and get those. If panel driver does not pass timing, try to find timing under rgb node for backwards compatibility. Tested-by: Andreas Westman Dorcsak # ASUS TF T30 Tested-by: Svyatoslav Ryhel # LG P895 T30 Signed-off-by: Svyatoslav Ryhel --- drivers/v

[PATCH v1 05/11] video: tegra-dc: assign regmap directly

2023-02-20 Thread Svyatoslav Ryhel
Signed-off-by: Svyatoslav Ryhel --- drivers/video/tegra20/tegra-dc.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/video/tegra20/tegra-dc.c b/drivers/video/tegra20/tegra-dc.c index 91298b7b7f..e004ee362f 100644 --- a/drivers/video/tegra20/tegra-d

[PATCH v1 03/11] video: tegra-dc: get clocks from device tree

2023-02-20 Thread Svyatoslav Ryhel
DISP1 clock may use PLLP, PLLC and PLLD as parents. Instead of hardcoding, lets pass clock and its parent from device tree. Default parent is PLLP. Tested-by: Andreas Westman Dorcsak # ASUS TF T30 Tested-by: Robert Eckelmann # ASUS TF101 T20 Tested-by: Svyatoslav Ryhel # HTC One X T30 Signed-of

[PATCH v1 02/11] video: move tegra dc driver into own folder

2023-02-20 Thread Svyatoslav Ryhel
Signed-off-by: Svyatoslav Ryhel --- drivers/video/Kconfig | 11 ++- drivers/video/Makefile| 2 +- drivers/video/tegra20/Kconfig | 8 drivers/video/tegra20/Makefile| 3 +++ drivers/video/{tegra.c =>

[PATCH v1 01/11] tegra: lcd: video: integrate display driver for t30

2023-02-20 Thread Svyatoslav Ryhel
From: Marcel Ziswiler On popular request make the display driver from T20 work on T30 as well. Turned out to be quite straight forward. However a few notes about some things encountered during porting: Of course the T30 device tree was completely missing host1x as well as PWM support but it turns

[PATCH v1 00/11] Tegra DC improvements

2023-02-20 Thread Svyatoslav Ryhel
This patch set is dedicated to improvement of video support on T20 and T30 devices. It contains: - DC driver improvements (T30 support was added into existing T20 DC driver, it was moved into own folder, added support of reading clocks from dts, improved work with panel ops and implemented native

Re: [PATCH 06/13] imx9: Remove ARCH_MISC_INIT

2023-02-20 Thread Peng Fan
On 2/16/2023 11:36 AM, Tom Rini wrote: We don't need an empty function, we can just not enable the hook we don't use. Cc: Peng Fan Signed-off-by: Tom Rini Reviewed-by: Peng Fan --- arch/arm/mach-imx/imx9/soc.c | 5 - configs/imx93_11x11_evk_defconfig | 1 - 2 files changed

Re: [PATCH] efi_loader: efi_allocate_pages: check parameter pages

2023-02-20 Thread Peng Fan
On 2/20/2023 4:08 AM, Heinrich Schuchardt wrote: On 2/16/23 11:53, Peng Fan (OSS) wrote: From: Peng Fan On i.MX8MM-EVK, when doing UEFI Capsule On Disk, we met such issue, It will create Boot option for capsule on disk: Boot: VenHw(E61D73B9-A384-4ACC-AEAB-82E828F3628B)/eMMC(0x2)/eMMC(0

Re: [PATCH v2] arm64: zynqmp: Add an OP-TEE node to the device tree

2023-02-20 Thread Michal Simek
On 2/16/23 14:39, Ilias Apalodimas wrote: Since the zynqmp boards can run upstream OP-TEE, and having the DT node present doesn't cause any side effects add it in case someone tries to load OP-TEE. Signed-off-by: Ilias Apalodimas --- changes since v1: - move the defintion to the .dtsi coveri

[PATCH] arm64: zynqmp: Remove comment about gem spec in kv260

2023-02-20 Thread Michal Simek
The latest SOM specification doesn't enforce certain MIO lines allocated for ethernet or ethernet controller itself. That's why remove comment about it which is likely there from early version of specification. Also removed the same comment from pinctrl node. It is clear that it has to be defined f