RE: [PATCH v2 1/1] i2c:aspeed:support ast2600 i2c new register mode driver

2023-01-29 Thread Ryan Chen
> -Original Message- > From: Simon Glass > Sent: Tuesday, January 24, 2023 2:44 AM > To: Ryan Chen > Cc: Heiko Schocher ; BMC-SW ; > u-boot@lists.denx.de > Subject: Re: [PATCH v2 1/1] i2c:aspeed:support ast2600 i2c new register mode > driver > > Hi Ryan, > > On Fri, 20 Jan 2023 at 17:10

[PATCH v3 1/2] i2c:aspeed:support ast2600 i2c new register mode driver

2023-01-29 Thread Ryan Chen
Add i2c new register mode driver to support AST2600 i2c new register mode. AST2600 i2c controller have legacy and new register mode. The new register mode have global register support 4 base clock for scl clock selection, and new clock divider mode. Signed-off-by: Ryan Chen --- MAINTAINERS

[PATCH v3 2/2] arm: aspeed: dtsi: add reg for i2c

2023-01-29 Thread Ryan Chen
The i2c driver have global register that i2c bus use ofnode_get_parent to get parent register address. Signed-off-by: Ryan Chen --- arch/arm/dts/ast2600.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/dts/ast2600.dtsi b/arch/arm/dts/ast2600.dtsi index 8d91eedc17..beabcf14f8 100

[PATCH v3 0/2] Add ASPEED AST2600 I2C new controller driver

2023-01-29 Thread Ryan Chen
This series add AST2600 i2c new register set driver. The i2c new register set have new clock divider option for more flexiable generation. Changes in v3: -modify uclass_get_device_by_driver to ofnode_get_parent. -Add i2c reg address in dtsi node. -fix up git config name from ryan_chen to Ryan Chen

Re: [PATCH] cmd: return code when tlv_eeprom incorrectly called

2023-01-29 Thread Stefan Roese
On 1/27/23 22:49, Heinrich Schuchardt wrote: A command called with incorrect parameters should set $? to 1 (false). Instead of calling cmd_usage(cmdtp) and then returning 0 just return CMD_RET_FAILURE. Signed-off-by: Heinrich Schuchardt Reviewed-by: Stefan Roese Thanks, Stefan --- cmd/t

Re: [PATCH 3/5] usb: dwc3-generic: Add dependency on SIMPLE_BUS

2023-01-29 Thread Kunihiko Hayashi
Hi Marek, Sorry for late reply. I was stuck in some pitfalls. On 2023/01/25 22:03, Marek Vasut wrote: On 1/25/23 09:40, Kunihiko Hayashi wrote: Hi Marek, Hello Hayashi-san, [...] The idea is that the dwc3-generic.c (or dwc3-uniphier.c , placement does not really matter) binds to "socionex

Re: [RFC PATCH 00/16] arm: Add Rockchip RK3588 support

2023-01-29 Thread Jagan Teki
Hi Kever, On Mon, 30 Jan 2023 at 06:25, Kever Yang wrote: > > Hi Jonas, > > > On 2023/1/29 17:58, Jonas Karlman wrote: > > Hi Kever, > > On 2023-01-29 10:47, Kever Yang wrote: > >> Hi Jonas, Jagan, > >> > >> On 2023/1/26 06:47, Jonas Karlman wrote: > >>> Hi Jagan, > >>> > >>> On 2023-01-25 23:27,

Re: [RFC PATCH 00/16] arm: Add Rockchip RK3588 support

2023-01-29 Thread Kever Yang
Hi Jonas, On 2023/1/29 17:58, Jonas Karlman wrote: Hi Kever, On 2023-01-29 10:47, Kever Yang wrote: Hi Jonas, Jagan, On 2023/1/26 06:47, Jonas Karlman wrote: Hi Jagan, On 2023-01-25 23:27, Jagan Teki wrote: This series support Rockchip RK3588. All the device tree files are synced from linu

Re: [PATCH 1/1] README: remove 'U-Boot Porting Guide' section

2023-01-29 Thread Heinrich Schuchardt
On 1/28/23 23:01, Simon Glass wrote: Hi Heinrich, On Thu, 26 Jan 2023 at 02:17, Heinrich Schuchardt wrote: On 1/26/23 00:49, Simon Glass wrote: Hi Heinrich, On Wed, 25 Jan 2023 at 12:00, Heinrich Schuchardt wrote: This section does not match the standards of our documentation. Signed

[PATCH 1/1] common: remove "impossible condition #876" message

2023-01-29 Thread Heinrich Schuchardt
Function cli_ch_esc() supports only a small subset of the escape sequences used by terminals. Don't nag the user with a message if an unsupported escape sequence is met. Fixes: b08e9d4b6632 ("cli: Move readline character-processing to a state machine") Signed-off-by: Heinrich Schuchardt --- com

Re: [PATCH] arm: mvebu: Add support for Thecus N2350 (Armada 385) board

2023-01-29 Thread Pali Rohár
On Sunday 29 January 2023 14:04:07 Tony Dinh wrote: > Hi Pali, > > On Sun, Jan 29, 2023 at 3:20 AM Pali Rohár wrote: > > > > On Saturday 28 January 2023 18:07:29 Tony Dinh wrote: > > > > > > > +#define BOOT_TARGET_DEVICES(func) \ > > > > > > > + func(SCSI, scsi, 0) \ > > > > > > > + func(

Re: [PATCH] arm: mvebu: Add support for Thecus N2350 (Armada 385) board

2023-01-29 Thread Tony Dinh
Hi Pali, On Sun, Jan 29, 2023 at 3:20 AM Pali Rohár wrote: > > On Saturday 28 January 2023 18:07:29 Tony Dinh wrote: > > > > > > +#define BOOT_TARGET_DEVICES(func) \ > > > > > > + func(SCSI, scsi, 0) \ > > > > > > + func(USB, usb, 0) \ > > > > > > + func(PXE, pxe, na) \ > > > > > > +

Re: [PATCH v2 09/87] Rename ARCH_NPCM7xx

2023-01-29 Thread Rasmus Villemoes
On 29/01/2023 01.57, Simon Glass wrote: > CONFIG options must not use lower-case letter. Why? Rasmus

Re: [PATCH 1/1] cmd: improve coninfo output formatting

2023-01-29 Thread Heinrich Schuchardt
On 1/28/23 23:01, Simon Glass wrote: On Fri, 27 Jan 2023 at 17:12, Heinrich Schuchardt wrote: Device name are typically longer than 8 characters. This leads to ragged output. Only the I and O bit of the device flags are of interest for the user. Writing a hexadecimal number is just confusin

Re: [RESEND PATCH] configs: imx8mn_bsh_smm_s2: remove console from bootargs

2023-01-29 Thread Fabio Estevam
On Sun, Jan 29, 2023 at 1:47 PM Dario Binacchi wrote: > The patch re-added 'console=${console}': > diff --cc include/configs/imx8mn_bsh_smm_s2.h > index d09c2ab01610,84c19824bdca..c6b296281424 > --- a/include/configs/imx8mn_bsh_smm_s2.h > +++ b/include/configs/imx8mn_bsh_smm_s2.h > @@@ -14,11 -14

[PATCH v1 15/16] ARM: tegra30: implement BCT patching

2023-01-29 Thread Svyatoslav Ryhel
From: Ramin Khonsari This function allows updating bootloader from u-boot on production devices without need in host PC. Be aware! It works only with re-crypted BCT. Tested-by: Andreas Westman Dorcsak # ASUS TF T30 Tested-by: Svyatoslav Ryhel # LG P895 T30 Signed-off-by: Ramin Khonsari Signe

[PATCH v1 08/16] ARM: tegra: provide default USB gadget setup

2023-01-29 Thread Svyatoslav Ryhel
From: Maxim Schwalm All Nvidia boards use the same manufacturer, vendor ID and product ID for the gadgets. Make them the defaults to remove some boilerplate from the defconfigs. Inspired by commit e02687bda96c ("sunxi: provide default USB gadget setup") which did the same for Allwinner boards.

[PATCH v1 16/16] ARM: tegra20: implement BCT patching

2023-01-29 Thread Svyatoslav Ryhel
This function allows updating bootloader from u-boot on production devices without need in host PC. Be aware! It works only with re-crypt BCT. Tested-by: Robert Eckelmann # ASUS TF101 T20 Signed-off-by: Ramin Khonsari Signed-off-by: Svyatoslav Ryhel --- arch/arm/mach-tegra/Kconfig |

[PATCH v1 12/16] board: tegra30: switch to updated pre-dm i2c write

2023-01-29 Thread Svyatoslav Ryhel
Configure PMIC voltages for early stages using updated early i2c write. Signed-off-by: Svyatoslav Ryhel --- arch/arm/mach-tegra/tegra30/Kconfig | 8 arch/arm/mach-tegra/tegra30/cpu.c | 36 - board/avionic-design/tec-ng/Makefile| 4 +- board/avioni

[PATCH v1 14/16] ARM: tegra: crypto: extend crypto functional

2023-01-29 Thread Svyatoslav Ryhel
Add support for encryption, decryption and signinig with non-zero key saving backward compatibility. Signed-off-by: Svyatoslav Ryhel --- arch/arm/include/asm/arch-tegra/crypto.h | 47 ++ arch/arm/mach-tegra/crypto.c | 63 +--- arch/arm/mach-tegra/c

[PATCH v1 13/16] ARM: tegra: expose crypto module for all Tegra SoCs

2023-01-29 Thread Svyatoslav Ryhel
Move crypto module from T20 only into common Tegra dir. Signed-off-by: Svyatoslav Ryhel --- arch/arm/mach-tegra/Kconfig| 5 + arch/arm/mach-tegra/Makefile | 1 + arch/arm/mach-tegra/{tegra20 => }/crypto.c | 0 arch/arm/mach-tegra/{tegra20 => }/crypto.h | 0 arch

[PATCH v1 11/16] board: tegra124: switch to updated pre-dm i2c write

2023-01-29 Thread Svyatoslav Ryhel
Configure PMIC for early stages using updated i2c write. Signed-off-by: Svyatoslav Ryhel --- board/nvidia/venice2/as3722_init.c | 65 board/nvidia/venice2/as3722_init.h | 43 - board/toradex/apalis-tk1/as3722_init.c | 85 ++ board/

[PATCH v1 10/16] ARM: tegra: create common pre-dm i2c write

2023-01-29 Thread Svyatoslav Ryhel
This implementation allows pwr i2c writing on early stages when DM was not yet setup. Such writing is needed to configure main voltages of PMIC. Tested-by: Andreas Westman Dorcsak # ASUS TF T30 Tested-by: Robert Eckelmann # ASUS TF101 T20 Tested-by: Svyatoslav Ryhel # LG P895 T30 Signed-off-by

[PATCH v1 09/16] ARM: tegra: add late init support

2023-01-29 Thread Svyatoslav Ryhel
Late init function allows passing values like identifiers and perform device specific configurations of pre-boot stage. Tested-by: Andreas Westman Dorcsak # ASUS TF T30 Tested-by: Svyatoslav Ryhel # LG P895 T30 Signed-off-by: Svyatoslav Ryhel --- arch/arm/include/asm/arch-tegra/sys_proto.h | 6

[PATCH v1 07/16] spi: tegra20_slink: accept any word length

2023-01-29 Thread Svyatoslav Ryhel
Original t20 slink could work with commands only fully divisible by 8. This patch removes such restriction, so commands of any bitlength now can be passed and processed. Tested-by: Andreas Westman Dorcsak # ASUS TF600T T30 Tested-by: Svyatoslav Ryhel # LG P895 T30 Signed-off-by: Svyatoslav Ryhel

[PATCH v1 05/16] ARM: tegra30: add PLLD to pll setup

2023-01-29 Thread Svyatoslav Ryhel
On T30 unlike T20 dsi panels are wider used on devices so PLLD is used as DISP1 parent more often, so lets enable it as well for this cases. Tested-by: Andreas Westman Dorcsak # ASUS TF700T T30 Tested-by: Svyatoslav Ryhel # HTC One X T30 Signed-off-by: Svyatoslav Ryhel --- arch/arm/mach-tegra/

[PATCH v1 06/16] ARM: tegra: Fix Tegra PWM parent clock

2023-01-29 Thread Svyatoslav Ryhel
Default parent clock for the PWM on Tegra is a 32kHz clock and is unable to support the requested PWM period. Fix PWM support on Tegra20, Tegra30, Tegra114, Tegra124 and Tegra210 by updating the parent clock for the PWM to be the PLL_P. This commit is equivalent to Linux kernel commit: https://lo

[PATCH v1 04/16] ARM: tegra: clock: add clock_decode_pair helper

2023-01-29 Thread Svyatoslav Ryhel
Get periph clock id and its parent from device tree. This works by looking up the peripheral's 'clocks' node and reading out the second and fourth cells, which are the peripheral and PLL clock numbers. Signed-off-by: Svyatoslav Ryhel --- arch/arm/include/asm/arch-tegra/clock.h | 13 +

[PATCH v1 02/16] ARM: t20/t30: swap host1x and disp1 clock parents

2023-01-29 Thread Svyatoslav Ryhel
According to mainline clock tables and TRM HOST1X parent is PLLC, while DISP1 usually uses PLLP as parent clock. Tested-by: Andreas Westman Dorcsak # ASUS TF T30 Tested-by: Robert Eckelmann # ASUS TF101 T20 Tested-by: Svyatoslav Ryhel # LG P895 T30 Signed-off-by: Svyatoslav Ryhel --- arch/arm

[PATCH v1 03/16] ARM: tegra: clock: add clk_id_to_pll_id helper

2023-01-29 Thread Svyatoslav Ryhel
This function allows to convert a device tree clock ID to PLL ID. Tested-by: Andreas Westman Dorcsak # ASUS TF T30 Tested-by: Robert Eckelmann # ASUS TF101 T20 Tested-by: Svyatoslav Ryhel # HTC One X Signed-off-by: Svyatoslav Ryhel --- arch/arm/include/asm/arch-tegra/clock.h | 8 ++ arch

[PATCH v1 01/16] tegra30: clock: add EXTPERIPH

2023-01-29 Thread Svyatoslav Ryhel
This mappings were missing for some reason. Tested-by: Svyatoslav Ryhel # LG P895 T30 Signed-off-by: Svyatoslav Ryhel --- arch/arm/include/asm/arch-tegra30/clock-tables.h | 6 +++--- arch/arm/mach-tegra/tegra30/clock.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) d

[PATCH v1 00/16] General Tegra improvements

2023-01-29 Thread Svyatoslav Ryhel
List of changes in patch set: - add missing EXTPERIPH clocks for t30 - swap host1x and disp1 clock parents (as they should be) - add clk_id_to_pll_id and clock_decode_pair helpers to use dts deeper (in tegra clocks often go in pair child - parent) - include PLLD setup in T30 (DISP1 may use i

Re: [RESEND PATCH] configs: imx8mn_bsh_smm_s2: remove console from bootargs

2023-01-29 Thread Dario Binacchi
Hi Fabio, On Sat, Jan 28, 2023 at 6:50 PM Fabio Estevam wrote: > > Hi Dario, > > On Sat, Jan 28, 2023 at 1:09 PM Dario Binacchi > wrote: > > > > The Linux kernel device tree already specifies the device to be used for > > boot console output with a stdout-path property under /chosen. > > > > Fix

[PATCH u-boot 3/3] tools: imagetool: Skip autodetection of gpimage type

2023-01-29 Thread Pali Rohár
gpimage type requires only that two first 32-bit words of data file are non-zero. So basically every random data file can be guessed and verified as gpimage. So completely skip gpimage type from image autodetection code to prevent lot of false positive results. Data file with gpimage type can be st

[PATCH u-boot 1/3] tools: imagetool: Fix error message when verify_header is undefined

2023-01-29 Thread Pali Rohár
Signed-off-by: Pali Rohár --- tools/imagetool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/imagetool.c b/tools/imagetool.c index f14ca2fb979f..688169b3a813 100644 --- a/tools/imagetool.c +++ b/tools/imagetool.c @@ -105,7 +105,7 @@ static int imagetool_verify_print_h

[PATCH u-boot 2/3] tools: imagetool: Show error message when detecting image type failed

2023-01-29 Thread Pali Rohár
Signed-off-by: Pali Rohár --- tools/imagetool.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/imagetool.c b/tools/imagetool.c index 688169b3a813..e1021f44f5ad 100644 --- a/tools/imagetool.c +++ b/tools/imagetool.c @@ -71,6 +71,11 @@ int imagetool_verify_print_header(

[PATCH u-boot 2/2] tools: default_image: Accept images with padding

2023-01-29 Thread Pali Rohár
If image file is stored on flash partition then it contains padding, which is not part of the image itself. Image data size is stored in the image header. So use image size from the header instead of expecting that total image file size is size of the header plus size of the image data. This allows

[PATCH u-boot 1/2] tools: default_image: Verify header size

2023-01-29 Thread Pali Rohár
Before reading image header, verify that image size is at least size of the image header. Signed-off-by: Pali Rohár --- tools/default_image.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/default_image.c b/tools/default_image.c index 4a067e65862e..4aa9a33241cb 100644 --- a/tool

Re: [RFC/PATCH] lib/Kconfig: Enable OF_LIBFDT_OVERLAY by default when FIT is enabled

2023-01-29 Thread Marek Vasut
On 1/29/23 17:30, Laurent Pinchart wrote: FIT image support is commonly used to bundle a kernel image, a device tree, and device tree overlays. Applying overlays requires the OF_LIBFDT_OVERLAY config option to be set, which lots of boards fail to select, most likely because developers never notic

Re: [PATCH] imx: power-domain: enable parent power domain

2023-01-29 Thread Marek Vasut
On 1/29/23 11:47, Patrick Wildt wrote: On Sun, Jan 29, 2023 at 05:00:15AM +0100, Marek Vasut wrote: On 1/29/23 04:28, Patrick Wildt wrote: Am Sun, Jan 29, 2023 at 02:46:36AM +0100 schrieb Marek Vasut: On 1/28/23 23:14, Patrick Wildt wrote: The PCIe power domains are dependant on each other, w

[RFC/PATCH] lib/Kconfig: Enable OF_LIBFDT_OVERLAY by default when FIT is enabled

2023-01-29 Thread Laurent Pinchart
FIT image support is commonly used to bundle a kernel image, a device tree, and device tree overlays. Applying overlays requires the OF_LIBFDT_OVERLAY config option to be set, which lots of boards fail to select, most likely because developers never noticed. This leads to an error when trying to ap

Re: [PATCH] cmd: return code when tlv_eeprom incorrectly called

2023-01-29 Thread Baruch Siach
Hi Heinrich, On Fri, Jan 27 2023, Heinrich Schuchardt wrote: > A command called with incorrect parameters should set $? to 1 (false). > Instead of calling cmd_usage(cmdtp) and then returning 0 just return > CMD_RET_FAILURE. > > Signed-off-by: Heinrich Schuchardt Acked-by: Baruch Siach Thanks,

Re: [PATCH] arm: mvebu: Add support for Thecus N2350 (Armada 385) board

2023-01-29 Thread Pali Rohár
On Saturday 28 January 2023 18:07:29 Tony Dinh wrote: > > > > > +#define BOOT_TARGET_DEVICES(func) \ > > > > > + func(SCSI, scsi, 0) \ > > > > > + func(USB, usb, 0) \ > > > > > + func(PXE, pxe, na) \ > > > > > + func(DHCP, dhcp, na) > > > > > > > > I see that you have also NAND with

Re: [PATCH] imx: power-domain: enable parent power domain

2023-01-29 Thread Patrick Wildt
On Sun, Jan 29, 2023 at 05:00:15AM +0100, Marek Vasut wrote: > On 1/29/23 04:28, Patrick Wildt wrote: > > Am Sun, Jan 29, 2023 at 02:46:36AM +0100 schrieb Marek Vasut: > > > On 1/28/23 23:14, Patrick Wildt wrote: > > > > The PCIe power domains are dependant on each other, which is why > > > > the d

Re: [RFC PATCH 00/16] arm: Add Rockchip RK3588 support

2023-01-29 Thread Jonas Karlman
Hi Kever, On 2023-01-29 10:47, Kever Yang wrote: > Hi Jonas, Jagan, > > On 2023/1/26 06:47, Jonas Karlman wrote: >> Hi Jagan, >> >> On 2023-01-25 23:27, Jagan Teki wrote: >>> This series support Rockchip RK3588. All the device tree files are >>> synced from linux-next with the proper SHA1 mentione

Re: [RFC PATCH 00/16] arm: Add Rockchip RK3588 support

2023-01-29 Thread Kever Yang
Hi Jonas, Jagan, On 2023/1/26 06:47, Jonas Karlman wrote: Hi Jagan, On 2023-01-25 23:27, Jagan Teki wrote: This series support Rockchip RK3588. All the device tree files are synced from linux-next with the proper SHA1 mentioned in the commit messages. Unfortunately, the BL31 from rkbin is not

Re: [RFC PATCH 00/16] arm: Add Rockchip RK3588 support

2023-01-29 Thread Jonas Karlman
On 2023-01-27 14:21, Jagan Teki wrote: > On Fri, 27 Jan 2023 at 05:13, Jonas Karlman wrote: >> >> On 2023-01-26 23:16, Jonas Karlman wrote: >>> Hi Jagan, >>> On 2023-01-26 20:17, Jagan Teki wrote: On Fri, 27 Jan 2023 at 00:33, Jonas Karlman wrote: > > On 2023-01-26 19:26, Jagan Teki