Re: [PATCH v4 3/7] eficonfig: add direct menu entry access mode

2022-10-23 Thread Masahisa Kojima
Hi Heinrich, On Mon, 24 Oct 2022 at 14:40, Heinrich Schuchardt wrote: > > On 10/24/22 06:48, Masahisa Kojima wrote: > > This commit adds the direct menu entry access mode. > > User can select the menu entry by '&' key followed by > > the menu title name. > > > > User input is read in UTF-16, then

Re: [PATCH] arm: armada: dts: Add clock to armada-ap80x uart1

2022-10-23 Thread Stefan Roese
On 20.10.22 23:21, Hamish Martin wrote: The uart1 node was missing the 'clock-frequency' property. This meant the driver for this device would fail at probe. The clock for uart1 is fed from the same source as uart0 and is a fixed 200MHz clock. This is confirmed via documentation for the CN9130 So

Re: [PATCH v2 4/4] watchdog: ulp_wdog: add driver model for ulp watchdog driver

2022-10-23 Thread Stefan Roese
On 21.10.22 10:41, Alice Guo (OSS) wrote: From: Alice Guo Enable driver model for ulp watchdog timer. When CONFIG_WDT=y and the status of device node is "okay", initr_watchdog will be called and finally calls ulp_wdt_probe() and ulp_wdt_start(). Signed-off-by: Alice Guo Reviewed-by: Ye Li

Re: [PATCH v2 3/4] watchdog: ulp_wdog: enable watchdog interrupt on imx93

2022-10-23 Thread Stefan Roese
On 21.10.22 10:41, Alice Guo (OSS) wrote: From: Alice Guo The reset source of the external PMIC on i.MX93 is WDOG_ANY PAD and the source of WDOG_ANY PAD is interrupt. Therefore, using PMIC to reset needs to enable the watchdog interrupt. Signed-off-by: Alice Guo Reviewed-by: Stefan Roese

Re: [PATCH v4 3/7] eficonfig: add direct menu entry access mode

2022-10-23 Thread Heinrich Schuchardt
On 10/24/22 06:48, Masahisa Kojima wrote: This commit adds the direct menu entry access mode. User can select the menu entry by '&' key followed by the menu title name. User input is read in UTF-16, then UTF-16 string is converted into UTF-8 internally because string comparison relies on strncas

Re: [PATCH v2 2/4] watchdog: ulp_wdog: Update watchdog driver for imx93

2022-10-23 Thread Stefan Roese
On 21.10.22 10:41, Alice Guo (OSS) wrote: From: Alice Guo The WDOG clocks are sourced from the fixed 32KHz (lpo_clk).When the timeout period exceeds 2 seconds, the value written to the TOVAL register is larger than 16-bit can represent. Enabling watchdog prescaler to solve this problem. Signed

Re: [PATCH v2 1/4] ulp_wdog: Update ulp wdog driver for 32bits command

2022-10-23 Thread Stefan Roese
On 21.10.22 10:41, Alice Guo (OSS) wrote: From: Ye Li To use 32bits refresh and unlock command as default, check the CMD32EN bit to select the corresponding commands. Signed-off-by: Ye Li Signed-off-by: Alice Guo Reviewed-by: Peng Fan Reviewed-by: Stefan Roese Thanks, Stefan --- Chan

[PATCH v4 7/7] test/py: eficonfig: use direct menu entry access mode

2022-10-23 Thread Masahisa Kojima
To select the menu entry, use direct access mode instead of UP/DOWN key operation. Signed-off-by: Masahisa Kojima --- Newly added in v4 .../py/tests/test_eficonfig/test_eficonfig.py | 177 +++--- 1 file changed, 70 insertions(+), 107 deletions(-) diff --git a/test/py/tests/test_efi

[PATCH v4 4/7] eficonfig: add direct menu entry access in change boot order

2022-10-23 Thread Masahisa Kojima
This commit adds the direct menu entry access in change boot order menu. To call eficonfig_handle_direct_accessor() from change boot order menu, refactoring is required to use 'eficonfig_entry' structure in change boot order menu processing. Signed-off-by: Masahisa Kojima --- Newly added in v4

[PATCH v4 6/7] eficonfig: add "Show/Delete Signature Database" menu entry

2022-10-23 Thread Masahisa Kojima
This commit adds the menu-driven interface to show and delete the signature database. EFI Signature Lists can contain the multiple signature entries, this menu can delete the indivisual entry. If the PK is enrolled and UEFI Secure Boot is in User Mode or Deployed Mode, user can not delete the ex

[PATCH v4 5/7] eficonfig: add UEFI Secure Boot Key enrollment interface

2022-10-23 Thread Masahisa Kojima
This commit adds the menu-driven UEFI Secure Boot Key enrollment interface. User can enroll the PK, KEK, db and dbx by selecting EFI Signature Lists file. After the PK is enrolled, UEFI Secure Boot is enabled and EFI Signature Lists file must be signed by KEK or PK. Signed-off-by: Masahisa Kojima

[PATCH v4 3/7] eficonfig: add direct menu entry access mode

2022-10-23 Thread Masahisa Kojima
This commit adds the direct menu entry access mode. User can select the menu entry by '&' key followed by the menu title name. User input is read in UTF-16, then UTF-16 string is converted into UTF-8 internally because string comparison relies on strncasecmp(). There is no equivalent string compar

[PATCH v4 2/7] eficonfig: expose append entry function

2022-10-23 Thread Masahisa Kojima
This commit exposes the eficonfig menu entry append function. Signed-off-by: Masahisa Kojima --- No change since v2 newly created in v2 cmd/eficonfig.c | 32 +--- include/efi_config.h | 5 + 2 files changed, 22 insertions(+), 15 deletions(-) diff --git a/

[PATCH v4 1/7] eficonfig: refactor eficonfig_select_file_handler()

2022-10-23 Thread Masahisa Kojima
eficonfig_select_file_handler() is commonly used to select the file. eficonfig_display_select_file_option() intends to add the additional menu mainly to clear the selected file information. eficonfig_display_select_file_option() is not necessary for the file selection process, so it should be outsi

[PATCH v4 0/7] eficonfig: add UEFI Secure Boot key maintenance interface

2022-10-23 Thread Masahisa Kojima
This series adds the UEFI Secure Boot key maintenance interface to the eficonfig command. User can enroll and delete the PK, KEK, db and dbx. Source code can be cloned with: $ git clone https://git.linaro.org/people/masahisa.kojima/u-boot.git -b kojima/eficonfig_sbkey_v4 I'm aware of Simon's ref

Re: [PATCH v3 3/8] imxrt1050: synchronise device tree with linux

2022-10-23 Thread Jesse Taube
On 10/23/22 18:13, Marcel Ziswiler wrote: Hi Giulio On Sun, 2022-10-23 at 01:47 +0200, Giulio Benetti wrote: Hi Marcel, Il 22/10/2022 23:42, Marcel Ziswiler ha scritto: From: Marcel Ziswiler Synchronise device tree with linux v6.0-rc1. Signed-off-by: Marcel Ziswiler --- Changes in v3

Re: [PATCH v2 3/8] imxrt1050: synchronise device tree with linux

2022-10-23 Thread Jesse Taube
On 10/22/22 08:57, Marcel Ziswiler wrote: Hi Jesse Sorry, I kinda missed your reply and imx maintainership was quiet for quite some time. I am now preparing a v3 taking your feedback into account. Thanks! On Sun, 2022-08-28 at 02:50 -0400, Jesse Taube wrote: On 8/26/22 14:31, Marcel Zisw

Re: Wolfgang Denk

2022-10-23 Thread Simon Glass
Hi Stefano, On Fri, 21 Oct 2022 at 09:11, Stefano Babic wrote: > > Dear U-Boot community, > > it is my very sad duty to inform you that Wolfgang Denk, the father of > U-Boot, passed away last week. We have lost a great developer and a very > good friend. > > I met Wolfgang the first time quite 25

Re: Wolfgang Denk

2022-10-23 Thread Bin Meng
On Fri, Oct 21, 2022 at 11:11 PM Stefano Babic wrote: > > Dear U-Boot community, > > it is my very sad duty to inform you that Wolfgang Denk, the father of > U-Boot, passed away last week. We have lost a great developer and a very > good friend. > > I met Wolfgang the first time quite 25 years ago

Re: [PATCH v3 0/6] eficonfig: add UEFI Secure Boot key maintenance interface

2022-10-23 Thread Masahisa Kojima
Hi Heinrich, On Sun, 23 Oct 2022 at 17:07, Heinrich Schuchardt wrote: > > On 10/23/22 08:13, Masahisa Kojima wrote: > > Hi Heinrich, > > > > > > On Sat, 22 Oct 2022 at 17:31, Heinrich Schuchardt > > wrote: > >> > >> On 10/14/22 08:56, Masahisa Kojima wrote: > > > > >> Python tests with this se

Re: [PATCH v3 3/6] eficonfig: add UEFI Secure Boot Key enrollment interface

2022-10-23 Thread Masahisa Kojima
On Sun, 23 Oct 2022 at 18:50, Heinrich Schuchardt wrote: > > On 10/23/22 10:17, Heinrich Schuchardt wrote: > > On 10/14/22 08:56, Masahisa Kojima wrote: > >> This commit adds the menu-driven UEFI Secure Boot Key > >> enrollment interface. User can enroll the PK, KEK, db > >> and dbx by selecting E

Re: [PATCH v3 3/8] imxrt1050: synchronise device tree with linux

2022-10-23 Thread Giulio Benetti
Hi Marcel, > Il giorno 24 ott 2022, alle ore 00:13, Marcel Ziswiler > ha scritto: > > Hi Giulio > >> On Sun, 2022-10-23 at 01:47 +0200, Giulio Benetti wrote: >> Hi Marcel, >> >> Il 22/10/2022 23:42, Marcel Ziswiler ha scritto: >>> From: Marcel Ziswiler >>> >>> Synchronise device tree with

Re: [PATCH v3 2/8] imxrt1020: fix lpuart issue in common u-boot device tree

2022-10-23 Thread Giulio Benetti
Hi Marcel, > Il giorno 24 ott 2022, alle ore 00:01, Marcel Ziswiler > ha scritto: > > Hi Giulio > >> On Sun, 2022-10-23 at 01:32 +0200, Giulio Benetti wrote: >> Hi Marcel, >> >> thanks for contributing, > > You are very welcome. > >> Il 22/10/2022 23:42, Marcel Ziswiler ha scritto: >>> Fro

Re: [PATCH v3 3/8] imxrt1050: synchronise device tree with linux

2022-10-23 Thread Marcel Ziswiler
Hi Giulio On Sun, 2022-10-23 at 01:47 +0200, Giulio Benetti wrote: > Hi Marcel, > > Il 22/10/2022 23:42, Marcel Ziswiler ha scritto: > > From: Marcel Ziswiler > > > > Synchronise device tree with linux v6.0-rc1. > > > > Signed-off-by: Marcel Ziswiler > > > > --- > > > > Changes in v3: > > -

Re: [PATCH v3 2/8] imxrt1020: fix lpuart issue in common u-boot device tree

2022-10-23 Thread Marcel Ziswiler
Hi Giulio On Sun, 2022-10-23 at 01:32 +0200, Giulio Benetti wrote: > Hi Marcel, > > thanks for contributing, You are very welcome. > Il 22/10/2022 23:42, Marcel Ziswiler ha scritto: > > From: Marcel Ziswiler > > > > Fix lpuart issue in common U-Boot device tree. > > There's no need to repeat

Re: [PATCH] sandbox: Correctly define BITS_PER_LONG

2022-10-23 Thread Michal Suchánek
On Sun, Oct 23, 2022 at 09:56:29AM +0200, Heinrich Schuchardt wrote: > On 10/23/22 09:50, Michal Suchánek wrote: > > On Sat, Oct 22, 2022 at 11:52:29PM +0200, Heinrich Schuchardt wrote: > > > > > > > > > Am 22. Oktober 2022 23:22:01 MESZ schrieb Michal Suchanek > > > : > > > > SANDBOX_BITS_PER_L

Re: [PATCH] cmd: eeprom: don't truncate target address at 32-bit

2022-10-23 Thread Ramon Fried
On Sun, Oct 23, 2022 at 12:28 PM Baruch Siach wrote: > > On 64-bit platforms where int is 32-bit wide, the eeprom command > parse_numeric_param() routine truncates the memory address parameter to > the lower 32-bit. Make parse_numeric_param() return long to allow > read/write of addresses beyond t

Re: [PATCH v3 3/6] eficonfig: add UEFI Secure Boot Key enrollment interface

2022-10-23 Thread Heinrich Schuchardt
On 10/23/22 10:17, Heinrich Schuchardt wrote: On 10/14/22 08:56, Masahisa Kojima wrote: This commit adds the menu-driven UEFI Secure Boot Key enrollment interface. User can enroll the PK, KEK, db and dbx by selecting EFI Signature Lists file. After the PK is enrolled, UEFI Secure Boot is enabled

[PATCH] cmd: eeprom: don't truncate target address at 32-bit

2022-10-23 Thread Baruch Siach
On 64-bit platforms where int is 32-bit wide, the eeprom command parse_numeric_param() routine truncates the memory address parameter to the lower 32-bit. Make parse_numeric_param() return long to allow read/write of addresses beyond the lower 4GB. Signed-off-by: Baruch Siach --- cmd/eeprom.c |

Re: [PATCH v3 3/6] eficonfig: add UEFI Secure Boot Key enrollment interface

2022-10-23 Thread Heinrich Schuchardt
On 10/14/22 08:56, Masahisa Kojima wrote: This commit adds the menu-driven UEFI Secure Boot Key enrollment interface. User can enroll the PK, KEK, db and dbx by selecting EFI Signature Lists file. After the PK is enrolled, UEFI Secure Boot is enabled and EFI Signature Lists file must be signed by

Re: [PATCH v3 0/6] eficonfig: add UEFI Secure Boot key maintenance interface

2022-10-23 Thread Heinrich Schuchardt
On 10/23/22 08:13, Masahisa Kojima wrote: Hi Heinrich, On Sat, 22 Oct 2022 at 17:31, Heinrich Schuchardt wrote: On 10/14/22 08:56, Masahisa Kojima wrote: Python tests with this series fail. See https://source.denx.de/u-boot/custodians/u-boot-efi/-/jobs/518130 Failing item is test_cap

[PATCH v2 1/1] efi_loader: discover if no efi_system_partition is set

2022-10-23 Thread Heinrich Schuchardt
Variable efi_system_partition holds the efi_system_partition. Currently it is initialized as: { .uclass_id = 0 = UCLASS_ROOT, .denum = 0, .part = 0, } This indicates that host 0:0 is the efi_system_partition and we see output like: => bootefi hello ** Bad device

Re: [PATCH] sandbox: Correctly define BITS_PER_LONG

2022-10-23 Thread Heinrich Schuchardt
On 10/23/22 09:50, Michal Suchánek wrote: On Sat, Oct 22, 2022 at 11:52:29PM +0200, Heinrich Schuchardt wrote: Am 22. Oktober 2022 23:22:01 MESZ schrieb Michal Suchanek : SANDBOX_BITS_PER_LONG is the number of bits in long on the sandbox platform. Please, explain in the commit message what

Re: [PATCH] sandbox: Correctly define BITS_PER_LONG

2022-10-23 Thread Michal Suchánek
On Sat, Oct 22, 2022 at 11:52:29PM +0200, Heinrich Schuchardt wrote: > > > Am 22. Oktober 2022 23:22:01 MESZ schrieb Michal Suchanek : > >SANDBOX_BITS_PER_LONG is the number of bits in long on the sandbox > >platform. > > Please, explain in the commit message what this patch is good for. For se