[PATCH] efi_loader: remove efi_delete_handle on loadfile2

Loadfile2 code is installing two protocols on it's own handle and uses efi_delete_handle() to clean it up on failure(s). However commit 05c4c9e21ae6 ("efi_loader: define internal implementations of install/uninstallmultiple") prepares the ground for us to clean up efi_elete_handle() used in favor

Re: [PATCH v2] tests: Build correct sandbox configuration on 32bit

On 10/15/22 21:46, Simon Glass wrote: Hi Heinrich, On Sat, 15 Oct 2022 at 13:29, Heinrich Schuchardt wrote: Am 15. Oktober 2022 21:24:36 MESZ schrieb Simon Glass : Hi Heinrich, On Sat, 15 Oct 2022 at 13:05, Heinrich Schuchardt wrote: On 10/15/22 20:39, Simon Glass wrote: Hi Heinrich,

Re: [PATCH v2] tests: Build correct sandbox configuration on 32bit

Hi Heinrich, On Sat, 15 Oct 2022 at 13:29, Heinrich Schuchardt wrote: > > > > Am 15. Oktober 2022 21:24:36 MESZ schrieb Simon Glass : > >Hi Heinrich, > > > >On Sat, 15 Oct 2022 at 13:05, Heinrich Schuchardt wrote: > >> > >> On 10/15/22 20:39, Simon Glass wrote: > >> > Hi Heinrich, > >> > > >> >

Re: [PATCH v2] tests: Build correct sandbox configuration on 32bit

Am 15. Oktober 2022 21:17:12 MESZ schrieb "Michal Suchánek" : >On Sat, Oct 15, 2022 at 09:05:53PM +0200, Heinrich Schuchardt wrote: >> On 10/15/22 20:39, Simon Glass wrote: >> > Hi Heinrich, >> > >> > On Sat, 15 Oct 2022 at 12:31, Heinrich Schuchardt >> > wrote: >> > > >> > > On 10/15/22 19:

Re: [PATCH 1/1] efi_loader: avoid EFI_CALL() when draining console

On Sat, Oct 15, 2022 at 12:43:39PM +0200, Heinrich Schuchardt wrote: > Use internal function. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_loader/efi_console.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/lib/efi_loader/efi_console.c b/lib/efi_loader/efi

Re: [PATCH v2] tests: Build correct sandbox configuration on 32bit

Am 15. Oktober 2022 21:24:36 MESZ schrieb Simon Glass : >Hi Heinrich, > >On Sat, 15 Oct 2022 at 13:05, Heinrich Schuchardt wrote: >> >> On 10/15/22 20:39, Simon Glass wrote: >> > Hi Heinrich, >> > >> > On Sat, 15 Oct 2022 at 12:31, Heinrich Schuchardt >> > wrote: >> >> >> >> On 10/15/22 19:53

Re: [PATCH v2] tests: Build correct sandbox configuration on 32bit

Hi Heinrich, On Sat, 15 Oct 2022 at 13:05, Heinrich Schuchardt wrote: > > On 10/15/22 20:39, Simon Glass wrote: > > Hi Heinrich, > > > > On Sat, 15 Oct 2022 at 12:31, Heinrich Schuchardt > > wrote: > >> > >> On 10/15/22 19:53, Simon Glass wrote: > >>> Hi Michal, > >>> > >>> On Fri, 14 Oct 2022

Re: [PATCH v2] tests: Build correct sandbox configuration on 32bit

On Sat, Oct 15, 2022 at 09:05:53PM +0200, Heinrich Schuchardt wrote: > On 10/15/22 20:39, Simon Glass wrote: > > Hi Heinrich, > > > > On Sat, 15 Oct 2022 at 12:31, Heinrich Schuchardt > > wrote: > > > > > > On 10/15/22 19:53, Simon Glass wrote: > > > > Hi Michal, > > > > > > > > On Fri, 14 Oct

Re: [PATCH] cmd: simplify efidebug

On Sat, Oct 15, 2022 at 01:22:28PM +0200, Heinrich Schuchardt wrote: > * don't use EFI_CALL() for variable services > * don't use runtime pointer to access exported function > > Signed-off-by: Heinrich Schuchardt > --- > cmd/efidebug.c | 47 +-- > 1 fi

Re: [PATCH 1/1] efi_loader: avoid EFI_CALL() for clearing screen

On Sat, Oct 15, 2022 at 12:15:47PM +0200, Heinrich Schuchardt wrote: > Carve out function efi_clear_screen. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_loader/efi_console.c | 26 +- > 1 file changed, 17 insertions(+), 9 deletions(-) > > diff --git a/lib/efi_lo

Re: [PATCH v2] tests: Build correct sandbox configuration on 32bit

On 10/15/22 20:39, Simon Glass wrote: Hi Heinrich, On Sat, 15 Oct 2022 at 12:31, Heinrich Schuchardt wrote: On 10/15/22 19:53, Simon Glass wrote: Hi Michal, On Fri, 14 Oct 2022 at 14:53, Michal Suchanek wrote: Currently sandbox configuration defautls to 64bit and there is no automation f

Re: [PATCH] dm: regmap: Disable range checks in SPL

Hi, On Sat, 15 Oct 2022 at 08:39, Simon Glass wrote: > > A recent change to regmap breaks building of phycore-rk3288 for me. The > difference is only a few bytes. Somehow CI seems to pass, even though it > fails when I run docker locally. But it prevents me from sending any more > pull requests.

Re: [PATCH v2] tests: Build correct sandbox configuration on 32bit

Hi Heinrich, On Sat, 15 Oct 2022 at 12:31, Heinrich Schuchardt wrote: > > On 10/15/22 19:53, Simon Glass wrote: > > Hi Michal, > > > > On Fri, 14 Oct 2022 at 14:53, Michal Suchanek wrote: > >> > >> Currently sandbox configuration defautls to 64bit and there is no > >> automation for building 32b

Re: [PATCH v2] tests: Build correct sandbox configuration on 32bit

On 10/15/22 19:53, Simon Glass wrote: Hi Michal, On Fri, 14 Oct 2022 at 14:53, Michal Suchanek wrote: Currently sandbox configuration defautls to 64bit and there is no automation for building 32bit sandbox on 32bit hosts. Use _LP64 macro as heuristic for detecting 64bit targets. Signed-off-

Re: [PATCH v2] tests: Build correct sandbox configuration on 32bit

Hi Michal, On Fri, 14 Oct 2022 at 14:53, Michal Suchanek wrote: > > Currently sandbox configuration defautls to 64bit and there is no > automation for building 32bit sandbox on 32bit hosts. > > Use _LP64 macro as heuristic for detecting 64bit targets. > > Signed-off-by: Michal Suchanek > --- > >

Re: [PATCH 1/2] dm: core: Fix iteration over driver_info records

Hi Paul, On Sat, 15 Oct 2022 at 03:19, Paul Barker wrote: > > We should only perform additional iteration steps when needed to > initialize the parent of a device. Other binding errors (such as a > missing driver) should not lead to additional iteration steps. > > Unnecessary iteration steps can

Re: [PATCH 2/2] configs: am335x_evm: Disable SPL_OF_CONTROL

Hi Paul, On Sat, 15 Oct 2022 at 03:19, Paul Barker wrote: > > When CONFIG_SPL_OF_CONFIG is enabled on the BeagleBone Black and the > SanCloud BBE, initialization of the I2C bus in ti_i2c_eeprom_get() > fails. This prevents us from determining the board variant in > enable_board_pin_mux(). As pinm

Re: [PATCH v2] test: Fix typo in test name

On Sat, 15 Oct 2022 at 03:30, Michal Suchanek wrote: > > For other sandbox tests the printed test name corresponds to the > configuration except for this one. > > Signed-off-by: Michal Suchanek > Reviewed-by: Simon Glass > --- > > Changes in v2: > Also fix nearby comment typo > > --- > test/run

Re: Status of debug UART on am335x SoC

Hi Paul, On Sat, 15 Oct 2022 at 06:11, Paul Barker wrote: > > Hi folks, > > While looking into SPI boot failures on our am335x based boards I needed > to enable the debug UART to understand where u-boot was getting stuck. > I first enabled the following config options: > > * CONFIG_DEBUG_UART=y >

[PATCH] dm: regmap: Disable range checks in SPL

A recent change to regmap breaks building of phycore-rk3288 for me. The difference is only a few bytes. Somehow CI seems to pass, even though it fails when I run docker locally. But it prevents me from sending any more pull requests. In any case this board is clearly near the limit. We could rever

Re: [u-boot][PATCH 04/14] mtd: rawnand: omap_gpmc: Optimize NAND reads

Hi Michael, On 15/10/2022 10:24, Michael Nazzareno Trimarchi wrote: > Hi > > On Tue, Oct 11, 2022 at 1:50 PM Roger Quadros wrote: >> >> Rename omap_nand_read() to omap_nand_read_buf() to reflect >> actual behaviour. >> >> Use FIFO read address instead of raw read address for reads. >> >> The GPM

Re: [PATCH 0/6] broken CVE fix (b85d130ea0ca)

Hi Rasmus, On Fri, Oct 14, 2022 at 2:44 PM Rasmus Villemoes wrote: > > tl;dr: b85d130ea0ca didn't fix the CVE(s), but did break tftp of > certain file sizes - which is somewhat lucky, since that's how I > noticed in the first place. > > What I at first hoped would be a one-liner trivial fix turne

Status of debug UART on am335x SoC

Hi folks, While looking into SPI boot failures on our am335x based boards I needed to enable the debug UART to understand where u-boot was getting stuck. I first enabled the following config options: * CONFIG_DEBUG_UART=y * CONFIG_DEBUG_UART_BASE=0x44e09000 * CONFIG_DEBUG_UART_CLOCK=4800 * CO

Re: [PATCH 1/1] sandbox: make sandbox system reset configurable

Hello, On Sat, Oct 15, 2022 at 10:39:19AM +0200, Heinrich Schuchardt wrote: > To test the watchdog system reset we need to disable the default sandbox > system reset. > > The following settings provide the reset command via watchdog on the > sandbox: > > CONFIG_WDT_GPIO=n > CONFIG_WDT_SA

[PATCH] cmd: simplify efidebug

* don't use EFI_CALL() for variable services * don't use runtime pointer to access exported function Signed-off-by: Heinrich Schuchardt --- cmd/efidebug.c | 47 +-- 1 file changed, 21 insertions(+), 26 deletions(-) diff --git a/cmd/efidebug.c b/cmd/ef

[PATCH 1/1] efi_loader: avoid EFI_CALL() when draining console

Use internal function. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_console.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/efi_loader/efi_console.c b/lib/efi_loader/efi_console.c index 6d4784e140..ab83f8bf82 100644 --- a/lib/efi_loader/efi_console.c +++

[PATCH 1/1] efi_loader: avoid EFI_CALL() for clearing screen

Carve out function efi_clear_screen. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_console.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/lib/efi_loader/efi_console.c b/lib/efi_loader/efi_console.c index 3354b217a9..6d4784e140 100644

[PATCH v2] test: Fix typo in test name

For other sandbox tests the printed test name corresponds to the configuration except for this one. Signed-off-by: Michal Suchanek Reviewed-by: Simon Glass --- Changes in v2: Also fix nearby comment typo --- test/run | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test

[PATCH 2/2] configs: am335x_evm: Disable SPL_OF_CONTROL

When CONFIG_SPL_OF_CONFIG is enabled on the BeagleBone Black and the SanCloud BBE, initialization of the I2C bus in ti_i2c_eeprom_get() fails. This prevents us from determining the board variant in enable_board_pin_mux(). As pinmux settings are not correctly configured this leads to boot failure.

[PATCH 1/2] dm: core: Fix iteration over driver_info records

We should only perform additional iteration steps when needed to initialize the parent of a device. Other binding errors (such as a missing driver) should not lead to additional iteration steps. Unnecessary iteration steps can cause issues when memory is tightly constrained (such as in the TPL/SPL

[PATCH 0/2] Fixes for SPI boot on SanCloud BBE Lite

These two commits fix SPI boot on the SanCloud BBE Lite and are likely also required for SPI boot on other am335x boards. Paul Barker (2): dm: core: Fix iteration over driver_info records configs: am335x_evm: Disable SPL_OF_CONTROL configs/am335x_boneblack_vboot_defconfig | 1 - configs/am3

[PATCH 1/1] sandbox: make sandbox system reset configurable

To test the watchdog system reset we need to disable the default sandbox system reset. The following settings provide the reset command via watchdog on the sandbox: CONFIG_WDT_GPIO=n CONFIG_WDT_SANDBOX=y CONFIG_SYSRESET_SANDBOX=n CONFIG_SYSRESET_WATCHDOG=y CONFIG_SYSRESET_WATC

Re: [u-boot][PATCH 04/14] mtd: rawnand: omap_gpmc: Optimize NAND reads

Hi On Tue, Oct 11, 2022 at 1:50 PM Roger Quadros wrote: > > Rename omap_nand_read() to omap_nand_read_buf() to reflect > actual behaviour. > > Use FIFO read address instead of raw read address for reads. > > The GPMC automatically converts 32-bit/16-bit reads to NAND > device specific reads (8/16

Re: [PATCH v2] tests: Build correct sandbox configuration on 32bit

On Sat, Oct 15, 2022 at 06:54:02AM +0200, Heinrich Schuchardt wrote: > On 10/14/22 22:52, Michal Suchanek wrote: > > Currently sandbox configuration defautls to 64bit and there is no > > automation for building 32bit sandbox on 32bit hosts. > > > > Use _LP64 macro as heuristic for detecting 64bit