Re: [PATCH] efi_loader: Let networking support depend on NETDEVICES

2022-10-14 Thread Heinrich Schuchardt
On 10/14/22 18:10, Jan Kiszka wrote: From: Jan Kiszka CONFIG_NET does not imply that there are actually network devices available, only CONFIG_NETDEVICES does. Changing to this dependenc CONFIG_NETDEVICES=y does not imply that any network driver is selected it is just a tighter prerequisite th

Re: [u-boot][PATCH 03/14] mtd: rawnand: omap_gpmc: Fix build warning on 64-bit platforms

2022-10-14 Thread Michael Nazzareno Trimarchi
On Tue, Oct 11, 2022 at 1:50 PM Roger Quadros wrote: > > Pointer size cannot be assumed to be 32-bit, so use > use uintptr_t instead of uint32_t. > > Fixes the below build warning on 64-bit builds. > > drivers/mtd/nand/raw/omap_gpmc.c:439:10: warning: cast from pointer to > integer of different s

Re: [PATCH] tests: Build correct sandbox configuration on 32bit

2022-10-14 Thread Heinrich Schuchardt
On 10/14/22 17:56, Simon Glass wrote: Hi Michal, On Thu, 13 Oct 2022 at 14:29, Michal Suchanek wrote: Currently sandbox configuration defautls to 64bit and there is no automation for building 32bit sandbox on 32bit hosts. cpp does not know about target specification, code needs to be compile

Re: [PATCH] tests: Build correct sandbox configuration on 32bit

2022-10-14 Thread Heinrich Schuchardt
On 10/14/22 10:43, Michal Suchánek wrote: On Fri, Oct 14, 2022 at 05:05:26AM +0200, Heinrich Schuchardt wrote: On 10/13/22 22:28, Michal Suchanek wrote: Currently sandbox configuration defautls to 64bit and there is no automation for building 32bit sandbox on 32bit hosts. cpp does not know abo

Re: [PATCH v2] tests: Build correct sandbox configuration on 32bit

2022-10-14 Thread Heinrich Schuchardt
On 10/14/22 22:52, Michal Suchanek wrote: Currently sandbox configuration defautls to 64bit and there is no automation for building 32bit sandbox on 32bit hosts. Use _LP64 macro as heuristic for detecting 64bit targets. Signed-off-by: Michal Suchanek Please, explain why you think a Kconfig l

Re: [PATCH v3 6/6] test: add test for eficonfig secure boot key management

2022-10-14 Thread Heinrich Schuchardt
On 10/15/22 03:10, Simon Glass wrote: Hi Ilias, On Fri, 14 Oct 2022 at 09:59, Ilias Apalodimas wrote: Hi Simon, On Fri, 14 Oct 2022 at 18:56, Simon Glass wrote: Hi, On Fri, 14 Oct 2022 at 00:58, Masahisa Kojima wrote: Provide a unit test for the eficonfig secure boot key management me

Re: [PATCH 2/3] clk: stm32mp13: introduce STM32MP13 RCC driver

2022-10-14 Thread Gabriel FERNANDEZ
Hi Sean Thank's for reviewing ! Best Regards Gabriel On 10/12/22 19:05, Sean Anderson wrote: On 10/12/22 08:33, Gabriel Fernandez wrote: Introduce STM32MP13 RCC driver using Common Clock Framework. Signed-off-by: Gabriel Fernandez ---   drivers/clk/stm32/Kconfig  |   15 +   drive

Re: [PATCH] dm: tpl: Add fdt address translation support in TPL

2022-10-14 Thread Simon Glass
On Fri, 14 Oct 2022 at 12:05, William Zhang wrote: > > This is needed in the platforms that use "ranges" node property for > address translation in their dts for TPL. > > Signed-off-by: William Zhang > > --- > > drivers/core/Kconfig | 14 ++ > 1 file changed, 14 insertions(+) > Revi

Re: [PATCH v3 6/6] test: add test for eficonfig secure boot key management

2022-10-14 Thread Simon Glass
Hi Ilias, On Fri, 14 Oct 2022 at 09:59, Ilias Apalodimas wrote: > > Hi Simon, > > On Fri, 14 Oct 2022 at 18:56, Simon Glass wrote: > > > > Hi, > > > > On Fri, 14 Oct 2022 at 00:58, Masahisa Kojima > > wrote: > > > > > > Provide a unit test for the eficonfig secure boot key > > > management menu

Re: [PATCH V2] dt-bindings: nvmem: u-boot,env: add Broadcom's variant binding

2022-10-14 Thread Rob Herring
On Fri, 30 Sep 2022 18:36:31 +0200, Rafał Miłecki wrote: > From: Rafał Miłecki > > Broadcom uses U-Boot for a lot of their bcmbca familiy chipsets. U-Boot > stores its configuration in an environment data block. > > Such blocks are usually stored on flash as a separated partition at > hardcoded

[PATCH v2] tests: Build correct sandbox configuration on 32bit

2022-10-14 Thread Michal Suchanek
Currently sandbox configuration defautls to 64bit and there is no automation for building 32bit sandbox on 32bit hosts. Use _LP64 macro as heuristic for detecting 64bit targets. Signed-off-by: Michal Suchanek --- Changes in v2: simplify and move detection to kconfig --- arch/sandbox/Kconfig

Re: [EXT] [REGRESSION]: v2022.07: SHA256 hash is broken on imx8m series with CAAM enabled

2022-10-14 Thread Fabio Estevam
Hi Andrey, On Fri, Oct 14, 2022 at 3:53 PM ZHIZHIKIN Andrey wrote: > `imx8mp.dtsi` however was not sync'd in, so the JR0 disabling is left out. :( > This does explain why the SHA calculation are not operable for that SoC. Marcel has submitted the dts sync patch: https://lists.denx.de/pipermail/

RE: [EXT] [REGRESSION]: v2022.07: SHA256 hash is broken on imx8m series with CAAM enabled

2022-10-14 Thread ZHIZHIKIN Andrey
Hello all, > -Original Message- > From: U-Boot On Behalf Of Rasmus Villemoes > Sent: Friday, October 14, 2022 7:50 PM > To: Peng Fan ; ZHIZHIKIN Andrey geosystems.com>; Gaurav Jain > Cc: u-boot@lists.denx.de; feste...@denx.de; sba...@denx.de; Michael Walle > ; Tommaso Merciai ; > Michae

[PATCH] dm: tpl: Add fdt address translation support in TPL

2022-10-14 Thread William Zhang
This is needed in the platforms that use "ranges" node property for address translation in their dts for TPL. Signed-off-by: William Zhang --- drivers/core/Kconfig | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/core/Kconfig b/drivers/core/Kconfig index c9bf5de4332b

Re: commit 787f04bb6a - imx: add USB2_BOOT type

2022-10-14 Thread Rasmus Villemoes
On 14/10/2022 02.55, Peng Fan wrote: > Hi Rasmus > > On 10/7/2022 4:08 PM, Rasmus Villemoes wrote: >> Hi Peng >> >> It seems that commit 787f04bb6a (imx: add USB2_BOOT type) broke our >> board logic which relies on whether get_boot_device() returns USB_BOOT >> or not. Instrumenting get_boot_device

Re: [EXT] [REGRESSION]: v2022.07: SHA256 hash is broken on imx8m series with CAAM enabled

2022-10-14 Thread Rasmus Villemoes
On 14/10/2022 03.00, Peng Fan wrote: > >>> Right now I am not sure what could cause the issue. >>> As per our previous discussions, JR0 can not be used in uboot, so you >>> need to >>> mark it as disabled until kernel device tree is not sync. >> >> Actually, I've given this a try by setting `statu

[PATCH 6/6] net: tftp: sanitize tftp block size, especially for TX

2022-10-14 Thread Rasmus Villemoes
U-Boot does not support IP fragmentation on TX (and unless CONFIG_IP_DEFRAG is set, neither on RX). So the blocks we send must fit in a single ethernet packet. Currently, if tftpblocksize is set to something like 5000 and I tftpput a large enough file, U-Boot crashes because we overflow net_tx_pac

[PATCH 5/6] net: tftp: use IS_ENABLED(CONFIG_NET_TFTP_VARS) instead of #if

2022-10-14 Thread Rasmus Villemoes
Nothing inside this block depends on NET_TFTP_VARS to be set to parse correctly. Switch to C if() in preparation for adding code before this (to avoid a declaration-after-statement warning). Signed-off-by: Rasmus Villemoes --- net/tftp.c | 56 +++--

[PATCH 4/6] net: fix ip_len in reassembled IP datagram

2022-10-14 Thread Rasmus Villemoes
For some reason, the ip_len field in a reassembled IP datagram is set to just the size of the payload, but it should be set to the value it would have had if the datagram had never been fragmented in the first place, i.e. size of payload plus size of IP header. That latter value is currently retur

[PATCH 3/6] net: (actually/better) deal with CVE-2022-{30790,30552}

2022-10-14 Thread Rasmus Villemoes
I hit a strange problem with v2022.10: Sometimes my tftp transfer would seemingly just hang. It only happened for some files. Moreover, changing tftpblocksize from 65464 to 65460 or 65000 made it work again for all the files I tried. So I started suspecting it had something to do with the file size

[PATCH 1/6] net: improve check for no IP options

2022-10-14 Thread Rasmus Villemoes
There's no reason we should accept an IP packet with a malformed IHL field. So ensure that it is exactly 5, not just <= 5. Signed-off-by: Rasmus Villemoes --- net/net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/net.c b/net/net.c index 81905f6315..536731245b 100644 -

[PATCH 2/6] net: compare received length to sizeof(ip_hdr), not sizeof(ip_udp_hdr)

2022-10-14 Thread Rasmus Villemoes
While the code mostly/only handles UDP packets, it's possible for the last fragment of a fragmented UDP packet to be smaller than 28 bytes; it can be as small as 21 bytes (an IP header plus one byte of payload). So until we've performed the defragmentation step and thus know whether we're now holdi

[PATCH 0/6] broken CVE fix (b85d130ea0ca)

2022-10-14 Thread Rasmus Villemoes
tl;dr: b85d130ea0ca didn't fix the CVE(s), but did break tftp of certain file sizes - which is somewhat lucky, since that's how I noticed in the first place. What I at first hoped would be a one-liner trivial fix turned out to be much more complicated and led me down a rabbit hole of related fixes

Re: U-Boot CONFIG_DM_SERIAL migration deadline

2022-10-14 Thread Tom Rini
On Fri, Oct 14, 2022 at 07:06:21PM +0200, Michael Nazzareno Trimarchi wrote: > Hi Tom > > On Fri, Oct 14, 2022 at 7:01 PM Tom Rini wrote: > > > > On Fri, Oct 14, 2022 at 06:58:50PM +0200, Michael Nazzareno Trimarchi wrote: > > > Hi > > > > > > On Fri, Oct 14, 2022 at 5:18 PM Tom Rini wrote: > >

Re: U-Boot CONFIG_DM_SERIAL migration deadline

2022-10-14 Thread Michael Nazzareno Trimarchi
Hi Tom On Fri, Oct 14, 2022 at 7:01 PM Tom Rini wrote: > > On Fri, Oct 14, 2022 at 06:58:50PM +0200, Michael Nazzareno Trimarchi wrote: > > Hi > > > > On Fri, Oct 14, 2022 at 5:18 PM Tom Rini wrote: > > > > > > Hey all, > > > > > > I'm sending this email out to the main and custodian lists, and

Re: U-Boot CONFIG_DM_SERIAL migration deadline

2022-10-14 Thread Tom Rini
On Fri, Oct 14, 2022 at 06:58:50PM +0200, Michael Nazzareno Trimarchi wrote: > Hi > > On Fri, Oct 14, 2022 at 5:18 PM Tom Rini wrote: > > > > Hey all, > > > > I'm sending this email out to the main and custodian lists, and bcc'ing > > all of the listed maintainers for platforms that have a proble

Re: U-Boot CONFIG_DM_SERIAL migration deadline

2022-10-14 Thread Michael Nazzareno Trimarchi
Hi On Fri, Oct 14, 2022 at 5:18 PM Tom Rini wrote: > > Hey all, > > I'm sending this email out to the main and custodian lists, and bcc'ing > all of the listed maintainers for platforms that have a problem here. > The migration deadline for switching from CONFIG_SERIAL to > CONFIG_DM_SERIAL is th

Re: [PATCH] Nokia RX-51: Fix compilation with non-zero CONFIG_SYS_TEXT_BASE

2022-10-14 Thread Tom Rini
On Sun, Oct 09, 2022 at 09:37:13PM +0200, Pali Rohár wrote: > For some unknown reason GNU assembler version 2.31.1 (arm-linux-gnueabi-as > from Debian Buster) cannot compile following code from located in file > board/nokia/rx51/lowlevel_init.S: > > kernoffs: > .word KERNEL_OFFSET - (. - C

Re: [PATCH 2/2] buildman: Add --allow-missing-binaries flag to build with BINMAN_ALLOW_MISSING=1

2022-10-14 Thread Tom Rini
On Fri, Oct 14, 2022 at 09:56:40AM -0600, Simon Glass wrote: > Hi Tom, > > On Wed, 12 Oct 2022 at 08:52, Tom Rini wrote: > > > > On Wed, Oct 12, 2022 at 06:59:35AM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Tue, 11 Oct 2022 at 10:22, Tom Rini wrote: > > > > > > > > On Mon, Oct 10, 20

imx patches pending

2022-10-14 Thread Tim Harvey
Stefano, With the merge window for v2023.01 closing in about a week (10/24), can you please look at the pending patches for imx? I'm afraid you may have some merge conflicts due to dt updates and we likely need time to respond to any issues you may have. Best Regards, Tim

[PATCH] efi_loader: Let networking support depend on NETDEVICES

2022-10-14 Thread Jan Kiszka
From: Jan Kiszka CONFIG_NET does not imply that there are actually network devices available, only CONFIG_NETDEVICES does. Changing to this dependency obsoletes the check in Kconfig because NETDEVICES means DM_ETH. Suggested-by: Tom Rini Signed-off-by: Jan Kiszka --- lib/efi_loader/Kconfig

Re: [PATCH v5 09/10] arm_ffa: introduce FF-A MM communication

2022-10-14 Thread Ilias Apalodimas
Hi Simon, [...] > > > > > > > * always begin with efi_mm_communicate_header. > > > > */ > > > > -struct __packed efi_mm_communicate_header { > > > > +struct efi_mm_communicate_header { > > > > efi_guid_t header_guid; > > > > size_t message_len; > > > > u8 data[]; > > >

Re: [PATCH] Kconfig: distro: Use imply instead of select for CMD_FAT

2022-10-14 Thread Tom Rini
On Fri, Oct 14, 2022 at 09:55:47AM -0600, Simon Glass wrote: > Hi Tom, > > On Wed, 12 Oct 2022 at 08:21, Tom Rini wrote: > > > > On Wed, Oct 12, 2022 at 07:04:24AM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Wed, 12 Oct 2022 at 06:50, Tom Rini wrote: > > > > > > > > On Fri, Sep 02, 20

Re: [PATCH v2 01/39] RFC: efi: Drop code that doesn't work with driver model

2022-10-14 Thread Tom Rini
On Fri, Oct 14, 2022 at 05:47:55PM +0200, Jan Kiszka wrote: > On 14.10.22 17:39, Tom Rini wrote: > > On Fri, Oct 14, 2022 at 09:36:46AM -0600, Simon Glass wrote: > >> Hi Jan, > >> > >> On Fri, 14 Oct 2022 at 09:35, Jan Kiszka wrote: > >>> > >>> On 14.10.22 17:33, Simon Glass wrote: > Hi Tom,

Re: [PATCH v3 6/6] test: add test for eficonfig secure boot key management

2022-10-14 Thread Ilias Apalodimas
Hi Simon, On Fri, 14 Oct 2022 at 18:56, Simon Glass wrote: > > Hi, > > On Fri, 14 Oct 2022 at 00:58, Masahisa Kojima > wrote: > > > > Provide a unit test for the eficonfig secure boot key > > management menu. > > > > Signed-off-by: Masahisa Kojima > > --- > > No change since v2 > > > > newly cr

Re: [PATCH v2 29/45] image: Correct strncpy() warning with image_set_name()

2022-10-14 Thread Simon Glass
Hi Heinrich, On Thu, 13 Oct 2022 at 10:23, Heinrich Schuchardt wrote: > > On 10/13/22 14:29, Simon Glass wrote: > > gcc 12 seems to warn on strncpy() as a matter of course. Rewrite the code > > a different way to do the same thing, to avoid the warning. > > > > Signed-off-by: Simon Glass > > ---

Re: [PATCH 2/2] buildman: Add --allow-missing-binaries flag to build with BINMAN_ALLOW_MISSING=1

2022-10-14 Thread Simon Glass
Hi Tom, On Wed, 12 Oct 2022 at 08:52, Tom Rini wrote: > > On Wed, Oct 12, 2022 at 06:59:35AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 11 Oct 2022 at 10:22, Tom Rini wrote: > > > > > > On Mon, Oct 10, 2022 at 05:48:55PM -0600, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Mon

Re: [PATCH 1/3] treewide: Use NULL for script image name

2022-10-14 Thread Simon Glass
On Thu, 13 Oct 2022 at 12:28, Sean Anderson wrote: > > Two callers of image_source_script specify an image name. However, both > use the deprecated @ syntax, indicating that they have not been updated > in a while. If CONFIG_FIT_SIGNATURE is enabled, we will reject such > names outright. Back in c

Re: [PATCH] test: Fix typo in test name

2022-10-14 Thread Simon Glass
On Thu, 13 Oct 2022 at 15:22, Michal Suchanek wrote: > > For other sandbox tests the printed test name corresponds to the > configuration except for this one. > > Signed-off-by: Michal Suchanek > --- > > test/run | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Simon Glass

Re: [PATCH] libfdt: Fix invalid version warning

2022-10-14 Thread Simon Glass
On Thu, 13 Oct 2022 at 14:40, Michal Suchanek wrote: > > python does not like the u-boot- prefix in the version, drop it. > > /usr/lib/python3.10/site-packages/setuptools/dist.py:544: UserWarning: > The version specified ('u-boot-2022.10') is an invalid version, this may > not work as expected wit

Re: [PATCH v2 2/6] socfpga: chameleonv3: Move environment to a text file

2022-10-14 Thread Simon Glass
On Fri, 14 Oct 2022 at 03:49, Paweł Anikiel wrote: > > Move the environment to an easily editable text file in the boot > partition > > Signed-off-by: Paweł Anikiel > --- > board/google/chameleonv3/environment.txt | 13 + > include/configs/socfpga_chameleonv3.h| 9 - > 2

Requiring SPL_DM for new boards?

2022-10-14 Thread Simon Glass
Hi, What do people think about requiring SPL_DM for new boards? Would that cause any problems? There is not much use of of-platdata (compiling the DT into C to save space) - is that because it doesn't work for people? I am particularly keen to drop the old block interface from SPL. It seems to m

Re: [PATCH v2 14/45] test: Support tests which can only be run manually

2022-10-14 Thread Simon Glass
Hi Heinrich, On Thu, 13 Oct 2022 at 10:19, Heinrich Schuchardt wrote: > > On 10/13/22 14:28, Simon Glass wrote: > > At present we normally write tests either in Python or in C. But most > > Python tests end up doing a lot of checks which would be better done in C. > > Checks done in C are orders

Re: [PATCH 4/5] binman: Use an exit code when blobs are missing

2022-10-14 Thread Simon Glass
Hi Tom, On Wed, 12 Oct 2022 at 08:29, Tom Rini wrote: > > On Wed, Oct 12, 2022 at 06:59:21AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 11 Oct 2022 at 15:05, Tom Rini wrote: > > > > > > On Mon, Oct 10, 2022 at 04:25:36PM -0600, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Mon

Re: [PATCH 2/2] input: Remove legacy KEYBOARD option

2022-10-14 Thread Simon Glass
On Fri, 14 Oct 2022 at 05:50, Tom Rini wrote: > > There are no platforms that have not migrated to using DM_KEYBOARD, > remove the legacy option. > > Cc: Simon Glass > Signed-off-by: Tom Rini > --- > Makefile | 1 - > board/kosagi/novena/novena.c | 61 --

Re: [PATCH v2 6/6] chameleonv3: Convert CONFIG_SPL_MAX_SIZE to Kconfig

2022-10-14 Thread Simon Glass
On Fri, 14 Oct 2022 at 03:49, Paweł Anikiel wrote: > > This file was missed during the conversion process. Add the symbol to > defconfig. > > Signed-off-by: Paweł Anikiel > --- > configs/socfpga_chameleonv3_defconfig | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Simon Glass

Re: [PATCH 1/2] core: Enable DM by default

2022-10-14 Thread Simon Glass
Hi Tom, On Fri, 14 Oct 2022 at 05:50, Tom Rini wrote: > > There are no longer any platforms which do not enable DM, move this to a > def_bool y and remove the check in the Makefile. > > Cc: Simon Glass > Signed-off-by: Tom Rini > --- > Makefile | 8 > drivers/core/Kconfig

Re: [PATCH] libfdt: Fix build with python 3.10

2022-10-14 Thread Simon Glass
On Thu, 13 Oct 2022 at 14:43, Michal Suchanek wrote: > > Python 3.10 requires defining PY_SSIZE_T_CLEAN. This will be fixed in > swig 4.10 but it is not clear when it will be released. There was a > warning since python 3.8. > > Link: https://github.com/swig/swig/pull/2277 > > Signed-off-by: Micha

Re: Question about uboot initialisation

2022-10-14 Thread Simon Glass
Hi Momo, On Thu, 13 Oct 2022 at 13:35, momo aubin wrote: > > Hi Simon, > > > On 12 Sep 2022, at 10:59 PM, momo aubin wrote: > > > >  > > > > Sent from my iPhone > > > >> On 12 Sep 2022, at 8:31 PM, Simon Glass wrote: > >> > >> Hi Aubin, > >> > On Mon, 12 Sept 2022 at 09:13, momo aubin w

Re: [PATCH 3/3] cmd: source: Support specifying config name

2022-10-14 Thread Simon Glass
Hi Sean, On Thu, 13 Oct 2022 at 12:28, Sean Anderson wrote: > > As discussed previously [1,2], the source command is not safe to use with > verified boot unless there is a key with required = "images" (which has its > own problems). This is because if such a key is absent, signatures are > verifi

Re: [PATCH 2/3] cmd: source: Clean up a few lines

2022-10-14 Thread Simon Glass
On Thu, 13 Oct 2022 at 12:28, Sean Anderson wrote: > > This simplifies a few lines and corrects an error message. > > Signed-off-by: Sean Anderson > --- > > cmd/source.c | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) > Reviewed-by: Simon Glass

Re: [PATCH v3 6/6] test: add test for eficonfig secure boot key management

2022-10-14 Thread Simon Glass
Hi, On Fri, 14 Oct 2022 at 00:58, Masahisa Kojima wrote: > > Provide a unit test for the eficonfig secure boot key > management menu. > > Signed-off-by: Masahisa Kojima > --- > No change since v2 > > newly created in v2 > > test/py/tests/test_eficonfig/conftest.py | 84 +++- > test/py/tes

Re: [PATCH v13 09/15] FWU: Add boot time checks as highlighted by the FWU specification

2022-10-14 Thread Simon Glass
Hi Sughosh, On Thu, 6 Oct 2022 at 03:07, Sughosh Ganu wrote: > > The FWU Multi Bank Update specification requires the Update Agent to > carry out certain checks at the time of platform boot. The Update > Agent is the component which is responsible for updating the firmware > components and mainta

Re: [PATCH] cmd: clk: probe the clock before dump them

2022-10-14 Thread Simon Glass
Hi Patrick, On Fri, 14 Oct 2022 at 03:34, Patrick Delaunay wrote: > > The clock UCLASS need to be probed to allow availability of the > private data (struct clk *), get in show_clks() with dev_get_clk_ptr() > before use them. > > Without this patch the clock dump can cause crash because all the >

Re: [PATCH v2 5/6] arm: dts: chameleonv3: Add 270-2 variant

2022-10-14 Thread Simon Glass
On Fri, 14 Oct 2022 at 03:49, Paweł Anikiel wrote: > > Add devicetree for chameleonv3 with the 270-2I2-D11E variant of the > Mercury+ AA1 module > > Signed-off-by: Paweł Anikiel > --- > arch/arm/dts/Makefile| 1 + > .../socfpga_arria10_chameleonv3_270_2-u-boot.dt

Re: [PATCH] tests: Build correct sandbox configuration on 32bit

2022-10-14 Thread Simon Glass
Hi Michal, On Thu, 13 Oct 2022 at 14:29, Michal Suchanek wrote: > > Currently sandbox configuration defautls to 64bit and there is no > automation for building 32bit sandbox on 32bit hosts. > > cpp does not know about target specification, code needs to be compiled > to determine integer width. >

Re: [PATCH v2 1/6] socfpga: chameleonv3: Enable ext4 in SPL

2022-10-14 Thread Simon Glass
On Fri, 14 Oct 2022 at 03:49, Paweł Anikiel wrote: > > Allow SPL to boot from an ext4 filesystem. > > Signed-off-by: Paweł Anikiel > --- > configs/socfpga_chameleonv3_defconfig | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Simon Glass

Re: [PATCH v2 4/6] arm: dts: chameleonv3: Rename chameleonv3.dts to .dtsi

2022-10-14 Thread Simon Glass
On Fri, 14 Oct 2022 at 03:49, Paweł Anikiel wrote: > > This file is included by the different chameleonv3 variants. Change the > name to .dtsi. > > Signed-off-by: Paweł Anikiel > --- > ...arria10_chameleonv3.dts => socfpga_arria10_chameleonv3.dtsi} | 0 > arch/arm/dts/socfpga_arria10_chameleonv3

Re: [PATCH v2 3/6] arm: dts: chameleonv3: Override chameleonv3 bitstream names

2022-10-14 Thread Simon Glass
On Fri, 14 Oct 2022 at 03:49, Paweł Anikiel wrote: > > Set the bitstream name per Chameleon variant. This allows the same > boot filesystem with all bitstream variants to be used on different > boards. > > Signed-off-by: Paweł Anikiel > --- > arch/arm/dts/socfpga_arria10_chameleonv3_270_3-u-boot

Re: [PATCH v5 09/10] arm_ffa: introduce FF-A MM communication

2022-10-14 Thread Simon Glass
Hi, On Fri, 14 Oct 2022 at 04:38, Abdellatif El Khlifi wrote: > > On Thu, Sep 29, 2022 at 12:32:42PM +0300, Ilias Apalodimas wrote: > > Hi Abdellatif, > > > > > --- a/arch/arm/cpu/armv8/cache.S > > > +++ b/arch/arm/cpu/armv8/cache.S > > > @@ -3,6 +3,9 @@ > > > * (C) Copyright 2013 > > > * Dav

Re: [RESEND PATCH 1/2] splash: support raw image from MMC

2022-10-14 Thread Simon Glass
Hi Julien, On Thu, 13 Oct 2022 at 10:08, Julien Masson wrote: > > Hi Simon, > > On Thu 13 Oct 2022 at 17:51, Simon Glass wrote: > > > HI Julien, > > > > On Wed, 12 Oct 2022 at 05:38, Julien Masson wrote: > >> > >> The user has now the choice to specify the splash location in the MMC > >> as a r

Re: [PATCH v2 1/2] image: Fix string truncation warning

2022-10-14 Thread Simon Glass
Hi, On Thu, 13 Oct 2022 at 07:50, Michal Suchánek wrote: > > On Thu, Oct 13, 2022 at 10:16:56AM +0200, Michal Suchanek wrote: > > In file included from ../tools/imagetool.h:24, > > from ../tools/default_image.c:16: > > In function ‘image_set_name’, > > inlined from ‘image_set

Re: [RESEND PATCH 2/2] splash: get devpart from environment variable

2022-10-14 Thread Simon Glass
Hi Julien, On Thu, 13 Oct 2022 at 09:51, Julien Masson wrote: > > Hi Simon, > > Thanks for the review. > > On Thu 13 Oct 2022 at 17:44, Simon Glass wrote: > > > Hi Julien, > > > > On Wed, 12 Oct 2022 at 05:38, Julien Masson wrote: > >> > >> By default several types of splash locations are supp

Re: [PATCH] blk: fix a couple of trivial documentation typos

2022-10-14 Thread Simon Glass
Hi Mattijs, On Thu, 13 Oct 2022 at 06:57, Mattijs Korpershoek wrote: > > In some cases, the param variable is wrong, and in other cases we have > undocumented arguments. > > Fix the docs. > > Signed-off-by: Mattijs Korpershoek > --- > --- > include/blk.h | 10 ++ > 1 file changed, 6 ins

Re: [PATCH] Kconfig: distro: Use imply instead of select for CMD_FAT

2022-10-14 Thread Simon Glass
Hi Tom, On Wed, 12 Oct 2022 at 08:21, Tom Rini wrote: > > On Wed, Oct 12, 2022 at 07:04:24AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Wed, 12 Oct 2022 at 06:50, Tom Rini wrote: > > > > > > On Fri, Sep 02, 2022 at 11:28:49AM +0800, Jit Loon Lim wrote: > > > > > > > From: Tien Fong Chee >

Re: [PATCH v2 01/39] RFC: efi: Drop code that doesn't work with driver model

2022-10-14 Thread Jan Kiszka
On 14.10.22 17:39, Tom Rini wrote: > On Fri, Oct 14, 2022 at 09:36:46AM -0600, Simon Glass wrote: >> Hi Jan, >> >> On Fri, 14 Oct 2022 at 09:35, Jan Kiszka wrote: >>> >>> On 14.10.22 17:33, Simon Glass wrote: Hi Tom, On Fri, 14 Oct 2022 at 07:13, Tom Rini wrote: > > On Fri,

Re: [PATCH v2 01/39] RFC: efi: Drop code that doesn't work with driver model

2022-10-14 Thread Tom Rini
On Fri, Oct 14, 2022 at 09:36:46AM -0600, Simon Glass wrote: > Hi Jan, > > On Fri, 14 Oct 2022 at 09:35, Jan Kiszka wrote: > > > > On 14.10.22 17:33, Simon Glass wrote: > > > Hi Tom, > > > > > > On Fri, 14 Oct 2022 at 07:13, Tom Rini wrote: > > >> > > >> On Fri, Oct 14, 2022 at 01:51:54PM +0200,

Re: [PATCH v2 01/39] RFC: efi: Drop code that doesn't work with driver model

2022-10-14 Thread Tom Rini
On Fri, Oct 14, 2022 at 05:35:43PM +0200, Jan Kiszka wrote: > On 14.10.22 17:34, Tom Rini wrote: > > On Fri, Oct 14, 2022 at 05:27:39PM +0200, Jan Kiszka wrote: > >> On 14.10.22 17:20, Tom Rini wrote: > >>> On Fri, Oct 14, 2022 at 05:10:55PM +0200, Heinrich Schuchardt wrote: > On 10/14/22 13:5

Re: [PATCH v2 01/39] RFC: efi: Drop code that doesn't work with driver model

2022-10-14 Thread Simon Glass
Hi Jan, On Fri, 14 Oct 2022 at 09:35, Jan Kiszka wrote: > > On 14.10.22 17:33, Simon Glass wrote: > > Hi Tom, > > > > On Fri, 14 Oct 2022 at 07:13, Tom Rini wrote: > >> > >> On Fri, Oct 14, 2022 at 01:51:54PM +0200, Jan Kiszka wrote: > >>> On 21.10.21 01:34, Heinrich Schuchardt wrote: > On

Re: [PATCH v2 01/39] RFC: efi: Drop code that doesn't work with driver model

2022-10-14 Thread Jan Kiszka
On 14.10.22 17:34, Tom Rini wrote: > On Fri, Oct 14, 2022 at 05:27:39PM +0200, Jan Kiszka wrote: >> On 14.10.22 17:20, Tom Rini wrote: >>> On Fri, Oct 14, 2022 at 05:10:55PM +0200, Heinrich Schuchardt wrote: On 10/14/22 13:51, Jan Kiszka wrote: > On 21.10.21 01:34, Heinrich Schuchardt wrot

Re: [PATCH v2 01/39] RFC: efi: Drop code that doesn't work with driver model

2022-10-14 Thread Jan Kiszka
On 14.10.22 17:33, Simon Glass wrote: > Hi Tom, > > On Fri, 14 Oct 2022 at 07:13, Tom Rini wrote: >> >> On Fri, Oct 14, 2022 at 01:51:54PM +0200, Jan Kiszka wrote: >>> On 21.10.21 01:34, Heinrich Schuchardt wrote: On 9/25/21 2:30 AM, Simon Glass wrote: > This code should never have been

Re: [PATCH v2 01/39] RFC: efi: Drop code that doesn't work with driver model

2022-10-14 Thread Tom Rini
On Fri, Oct 14, 2022 at 05:27:39PM +0200, Jan Kiszka wrote: > On 14.10.22 17:20, Tom Rini wrote: > > On Fri, Oct 14, 2022 at 05:10:55PM +0200, Heinrich Schuchardt wrote: > >> On 10/14/22 13:51, Jan Kiszka wrote: > >>> On 21.10.21 01:34, Heinrich Schuchardt wrote: > On 9/25/21 2:30 AM, Simon Gl

Re: [PATCH v2 01/39] RFC: efi: Drop code that doesn't work with driver model

2022-10-14 Thread Simon Glass
Hi Tom, On Fri, 14 Oct 2022 at 07:13, Tom Rini wrote: > > On Fri, Oct 14, 2022 at 01:51:54PM +0200, Jan Kiszka wrote: > > On 21.10.21 01:34, Heinrich Schuchardt wrote: > > > On 9/25/21 2:30 AM, Simon Glass wrote: > > >> This code should never have been added as it builds a new feature on top > >

Re: [PATCH v2 01/39] RFC: efi: Drop code that doesn't work with driver model

2022-10-14 Thread Jan Kiszka
On 14.10.22 17:20, Tom Rini wrote: > On Fri, Oct 14, 2022 at 05:10:55PM +0200, Heinrich Schuchardt wrote: >> On 10/14/22 13:51, Jan Kiszka wrote: >>> On 21.10.21 01:34, Heinrich Schuchardt wrote: On 9/25/21 2:30 AM, Simon Glass wrote: > This code should never have been added as it builds a

Re: [PATCH v2 01/39] RFC: efi: Drop code that doesn't work with driver model

2022-10-14 Thread Jan Kiszka
On 14.10.22 17:10, Heinrich Schuchardt wrote: > On 10/14/22 13:51, Jan Kiszka wrote: >> On 21.10.21 01:34, Heinrich Schuchardt wrote: >>> On 9/25/21 2:30 AM, Simon Glass wrote: This code should never have been added as it builds a new feature on top of legacy code. This has already b

Re: [PATCH v2 01/39] RFC: efi: Drop code that doesn't work with driver model

2022-10-14 Thread Tom Rini
On Fri, Oct 14, 2022 at 05:10:55PM +0200, Heinrich Schuchardt wrote: > On 10/14/22 13:51, Jan Kiszka wrote: > > On 21.10.21 01:34, Heinrich Schuchardt wrote: > > > On 9/25/21 2:30 AM, Simon Glass wrote: > > > > This code should never have been added as it builds a new feature on top > > > > of lega

U-Boot CONFIG_DM_SERIAL migration deadline

2022-10-14 Thread Tom Rini
Hey all, I'm sending this email out to the main and custodian lists, and bcc'ing all of the listed maintainers for platforms that have a problem here. The migration deadline for switching from CONFIG_SERIAL to CONFIG_DM_SERIAL is the v2023.04 release. Now, per how I've behaved in the past, I'm not

Re: [PATCH v2 01/39] RFC: efi: Drop code that doesn't work with driver model

2022-10-14 Thread Heinrich Schuchardt
On 10/14/22 13:51, Jan Kiszka wrote: On 21.10.21 01:34, Heinrich Schuchardt wrote: On 9/25/21 2:30 AM, Simon Glass wrote: This code should never have been added as it builds a new feature on top of legacy code. This has already been improved with the dependency on BLK. Add a dependency on DM_E

Re: U-Boot CONFIG_TIMER migration deadline

2022-10-14 Thread Tom Rini
On Fri, Oct 14, 2022 at 03:46:45PM +0200, Marek Vasut wrote: > On 10/14/22 15:25, Tom Rini wrote: > > Hey all, > > > > I'm sending this email out to the main and custodian lists, and bcc'ing > > all of the listed maintainers for platforms that have a problem here. > > The migration deadline for sw

Re: U-Boot CONFIG_TIMER migration deadline

2022-10-14 Thread Marek Vasut
On 10/14/22 15:25, Tom Rini wrote: Hey all, I'm sending this email out to the main and custodian lists, and bcc'ing all of the listed maintainers for platforms that have a problem here. The migration deadline for switching from CONFIG_SYS_TIMER_RATE or CONFIG_SYS_TIMER_COUNTER and to using CONFI

Re: U-Boot CONFIG_TIMER migration deadline

2022-10-14 Thread Tom Rini
On Fri, Oct 14, 2022 at 02:32:41PM +0100, Peter Robinson wrote: > Hey Tom, > > > I'm sending this email out to the main and custodian lists, and bcc'ing > > all of the listed maintainers for platforms that have a problem here. > > The migration deadline for switching from CONFIG_SYS_TIMER_RATE or

U-Boot CONFIG_DM_I2C migration deadline

2022-10-14 Thread Tom Rini
Hey all, I'm sending this email out to the main and custodian lists, and bcc'ing all of the listed maintainers for platforms that have a problem here. The migration deadline for switching from CONFIG_SYS_I2C_LEGACY to CONFIG_DM_I2C was the v2022.04 release. Now, per how I've behaved in the past, I

Re: U-Boot CONFIG_TIMER migration deadline

2022-10-14 Thread Peter Robinson
Hey Tom, > I'm sending this email out to the main and custodian lists, and bcc'ing > all of the listed maintainers for platforms that have a problem here. > The migration deadline for switching from CONFIG_SYS_TIMER_RATE or > CONFIG_SYS_TIMER_COUNTER and to using CONFIG_TIMER is the v2023.01 > rel

U-Boot CONFIG_TIMER migration deadline

2022-10-14 Thread Tom Rini
Hey all, I'm sending this email out to the main and custodian lists, and bcc'ing all of the listed maintainers for platforms that have a problem here. The migration deadline for switching from CONFIG_SYS_TIMER_RATE or CONFIG_SYS_TIMER_COUNTER and to using CONFIG_TIMER is the v2023.01 release. Now,

Re: [PATCH v2 01/39] RFC: efi: Drop code that doesn't work with driver model

2022-10-14 Thread Tom Rini
On Fri, Oct 14, 2022 at 01:51:54PM +0200, Jan Kiszka wrote: > On 21.10.21 01:34, Heinrich Schuchardt wrote: > > On 9/25/21 2:30 AM, Simon Glass wrote: > >> This code should never have been added as it builds a new feature on top > >> of legacy code. This has already been improved with the dependenc

Re: [PATCH] sandbox: Eliminate CONFIG_HOST_32/64BIT

2022-10-14 Thread Heinrich Schuchardt
On 10/14/22 13:42, Michal Suchánek wrote: On Fri, Oct 14, 2022 at 01:33:33PM +0200, Heinrich Schuchardt wrote: On 10/14/22 10:33, Michal Suchánek wrote: Hello, On Fri, Oct 14, 2022 at 08:40:52AM +0200, Heinrich Schuchardt wrote: From: Heinrich Schuchardt Building sandbox_defconfig on 32bit

Re: [PATCH v2 01/39] RFC: efi: Drop code that doesn't work with driver model

2022-10-14 Thread Jan Kiszka
On 21.10.21 01:34, Heinrich Schuchardt wrote: > On 9/25/21 2:30 AM, Simon Glass wrote: >> This code should never have been added as it builds a new feature on top >> of legacy code. This has already been improved with the dependency on >> BLK. >> >> Add a dependency on DM_ETH also, to avoid needing

[PATCH 2/2] input: Remove legacy KEYBOARD option

2022-10-14 Thread Tom Rini
There are no platforms that have not migrated to using DM_KEYBOARD, remove the legacy option. Cc: Simon Glass Signed-off-by: Tom Rini --- Makefile | 1 - board/kosagi/novena/novena.c | 61 -- common/stdio.c

[PATCH 1/2] core: Enable DM by default

2022-10-14 Thread Tom Rini
There are no longer any platforms which do not enable DM, move this to a def_bool y and remove the check in the Makefile. Cc: Simon Glass Signed-off-by: Tom Rini --- Makefile | 8 drivers/core/Kconfig | 2 +- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/Mak

Re: [PATCH] sandbox: Eliminate CONFIG_HOST_32/64BIT

2022-10-14 Thread Michal Suchánek
On Fri, Oct 14, 2022 at 01:33:33PM +0200, Heinrich Schuchardt wrote: > On 10/14/22 10:33, Michal Suchánek wrote: > > Hello, > > > > On Fri, Oct 14, 2022 at 08:40:52AM +0200, Heinrich Schuchardt wrote: > > > From: Heinrich Schuchardt > > > > > > Building sandbox_defconfig on 32bit systems require

Re: [PATCH] sandbox: Eliminate CONFIG_HOST_32/64BIT

2022-10-14 Thread Heinrich Schuchardt
On 10/14/22 10:33, Michal Suchánek wrote: Hello, On Fri, Oct 14, 2022 at 08:40:52AM +0200, Heinrich Schuchardt wrote: From: Heinrich Schuchardt Building sandbox_defconfig on 32bit systems requires manual configuration. we should void this. The compiler provides symbol __LP64__. This is enoug

[PATCH] riscv: andes_plic.c: use modified IPI scheme

2022-10-14 Thread Yu Chien Peter Lin
The IPI scheme in OpenSBI has been updated to support 8-core AE350 platform, the plicsw configuration needs to be modified accordingly. Signed-off-by: Yu Chien Peter Lin --- arch/riscv/lib/andes_plic.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/riscv/lib/an

Re: ext4load failed in the uboot

2022-10-14 Thread Kali
Hi guys: Do you have some patchs to protect this global vars? kali From: Kali Date: 2022-10-14 11:35 To: u-boot; wd Subject: ext4load failed in the uboot Hi guys: I'm kali. We used this uboot(PDX-License-Identifier:GPL-2.0+) on the rtl11619b soc. We find sometimes ext4load failed

ext4load failed in the uboot

2022-10-14 Thread Kali
Hi guys: I'm kali. We used this uboot(PDX-License-Identifier:GPL-2.0+) on the rtl11619b soc. We find sometimes ext4load failed. cmd is "ext4load mmc 0:4 0x140 emmc.uImage". I guss global vars cause this problem. Maybe,global vars are modified by other app. for example: stati

Re: [PATCH v6 00/10] introduce Arm FF-A support

2022-10-14 Thread Abdellatif El Khlifi
On Thu, Oct 13, 2022 at 03:07:39PM +0300, Ilias Apalodimas wrote: > Hi Abdellatif, > > On Thu, Oct 13, 2022 at 11:38:47AM +0100, Abdellatif El Khlifi wrote: > > Adding support for Arm FF-A v1.0 (Arm Firmware Framework for Armv8-A) [6]. > > > > FF-A describes interfaces (ABIs) that standardize com

Re: [PATCH v5 04/10] arm_ffa: introduce Arm FF-A low-level driver

2022-10-14 Thread Abdellatif El Khlifi
On Mon, Oct 03, 2022 at 11:22:33AM -0400, Tom Rini wrote: > On Mon, Oct 03, 2022 at 10:49:23AM +0200, Jens Wiklander wrote: > > On Mon, Sep 26, 2022 at 03:08:21PM +0100, Abdellatif El Khlifi wrote: > [snip] > > > diff --git a/doc/README.ffa.drv b/doc/README.ffa.drv > > > new file mode 100644 > > >

Re: [PATCH v5 09/10] arm_ffa: introduce FF-A MM communication

2022-10-14 Thread Abdellatif El Khlifi
On Thu, Sep 29, 2022 at 12:32:42PM +0300, Ilias Apalodimas wrote: > Hi Abdellatif, > > > --- a/arch/arm/cpu/armv8/cache.S > > +++ b/arch/arm/cpu/armv8/cache.S > > @@ -3,6 +3,9 @@ > > * (C) Copyright 2013 > > * David Feng > > * > > + * (C) Copyright 2022 ARM Limited > > + * Abdellatif El Kh

Re: [PATCH v5 04/10] arm_ffa: introduce Arm FF-A low-level driver

2022-10-14 Thread Abdellatif El Khlifi
On Mon, Oct 03, 2022 at 10:49:23AM +0200, Jens Wiklander wrote: > On Mon, Sep 26, 2022 at 03:08:21PM +0100, Abdellatif El Khlifi wrote: > > Add the driver implementing Arm Firmware Framework for Armv8-A v1.0 > > > > The Firmware Framework for Arm A-profile processors (FF-A v1.0) [1] > > describes

Re: [PATCH v5 02/10] arm64: smccc: clear the Xn registers after SMC calls

2022-10-14 Thread Abdellatif El Khlifi
On Fri, Sep 30, 2022 at 11:48:04AM +0200, Jens Wiklander wrote: > On Mon, Sep 26, 2022 at 03:08:19PM +0100, Abdellatif El Khlifi wrote: > > set to zero the x0-x17 registers > > > > As per the SMCCC v1.2 spec, unused result and scratch registers > > can leak information after an SMC call. We can mi

[PATCH v2 6/6] chameleonv3: Convert CONFIG_SPL_MAX_SIZE to Kconfig

2022-10-14 Thread Paweł Anikiel
This file was missed during the conversion process. Add the symbol to defconfig. Signed-off-by: Paweł Anikiel --- configs/socfpga_chameleonv3_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/socfpga_chameleonv3_defconfig b/configs/socfpga_chameleonv3_defconfig index e628ee8

  1   2   >