Re: [PATCH 2/7] mtd/nand: try to erase bad blocks only if scrub flag is provided

2022-10-05 Thread Michael Nazzareno Trimarchi
Hi On Thu, Oct 6, 2022 at 5:15 AM wrote: > > From: Mikhail Kshevetskiy > > 'mtd erase' command should not erase bad blocks. To force bad block erasing > there is 'mtd erase.dontskipbad' command (this command sets 'scrub' flag > to true in the erase_info structure). Unfortunately nand layer ignor

Re: [RFC PATCH 0/2] Clean up protocol installation API

2022-10-05 Thread Ilias Apalodimas
Hi Akashi-san, On Thu, 6 Oct 2022 at 04:35, AKASHI Takahiro wrote: > > Hi Ilias, > > On Wed, Oct 05, 2022 at 06:26:00PM +0300, Ilias Apalodimas wrote: > > This RFC is trying to clean up the usage of the internal functions used > > to manage the protocol and handle lifetimes. Currently we arbitra

Re: [PATCH 2/3] efi_selftest: rename event_notify

2022-10-05 Thread Ilias Apalodimas
On Thu, Oct 06, 2022 at 07:49:32AM +0200, Heinrich Schuchardt wrote: > A function event_notify() exists. We should not use the same name for and > EFI event. Rename events in unit tests. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_selftest/efi_selftest_events.c| 18 +++ >

Re: [PATCH v4 2/6] efi: Add string conversion helper

2022-10-05 Thread Ilias Apalodimas
Thanks Paul! On Wed, Oct 05, 2022 at 01:18:35PM +0100, Paul Barker wrote: > Signed-off-by: Paul Barker > --- > include/efi_loader.h| 3 ++- > lib/efi_loader/efi_string.c | 24 > 2 files changed, 26 insertions(+), 1 deletion(-) > > diff --git a/include/efi_loade

[PATCH 2/3] efi_selftest: rename event_notify

2022-10-05 Thread Heinrich Schuchardt
A function event_notify() exists. We should not use the same name for and EFI event. Rename events in unit tests. Signed-off-by: Heinrich Schuchardt --- lib/efi_selftest/efi_selftest_events.c| 18 +++ .../efi_selftest_exitbootservices.c | 6 +-- lib/efi_selftest/efi_selfte

[PATCH 3/3] efi_driver: move event registration to driver

2022-10-05 Thread Heinrich Schuchardt
Move the registration of events for the addition and removal of block devices to the block device driver. Here we can add a reference to the EFI Driver Binding protocol as context. Signed-off-by: Heinrich Schuchardt --- include/efi_loader.h | 7 +-- lib/efi_driver/efi_block_dev

[PATCH 1/3] efi_driver: add init function to EFI block driver

2022-10-05 Thread Heinrich Schuchardt
For handling added and removed block devices we need to register events which has to be done when the driver is installed. This patch only creates an empty init function that will be filled with code later on. The function needs to be called before any EFI block devices are used. Move the efi_driv

[PATCH 0/3] efi_driver: move event registration to driver

2022-10-05 Thread Heinrich Schuchardt
For correct handling of protocols by the EFI block driver we need to open protocols BY_DRIVER or BY_CHILD_CONTROLLER. By moving the event registration for block devices to the block device driver we can add the EFI Driver Binding protocol interface as context to the events. Later patches will use t

Re: [PATCH v5 3/3] board: qemu-riscv: enable semihosting

2022-10-05 Thread Kautuk Consul
Hi Leo, I took a look at the raw log. It seems that the test-case is outputting too many characters onto the u-boot prompt due to which the log size has gotten exceeded. Can you somehow increase the log size and then try ? Thanks. On Wed, Oct 5, 2022 at 11:47 AM Leo Liang wrote: > > Hi Kautuk,

[PATCH 1/1] cmd: simplify do_efi_boot_add()

2022-10-05 Thread Heinrich Schuchardt
Use efi_convert_string() to convert a UTF-8 to a UTF-16 string. Signed-off-by: Heinrich Schuchardt --- cmd/efidebug.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/cmd/efidebug.c b/cmd/efidebug.c index 76a6b4d8eb..4b49f30d93 100644 --- a/cmd/efidebug.c +++ b/cmd/efideb

[PATCH 1/1] cmd: simplify do_env_set_efi()

2022-10-05 Thread Heinrich Schuchardt
Use efi_convert_string() to convert a UTF-8 to a UTF-16 string. Signed-off-by: Heinrich Schuchardt --- cmd/nvedit_efi.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/cmd/nvedit_efi.c b/cmd/nvedit_efi.c index 770877c527..0411b66559 100644 --- a/cmd/nvedit_efi.c +++ b/cm

Re: [U-Boot PATCH v4 5/6] arm: dts: am335x-sancloud-bbe-lite: UEFI SPI export

2022-10-05 Thread Heinrich Schuchardt
On 10/5/22 14:18, Paul Barker wrote: Add properties to the Authenta SPI flash device node to enable access by a UEFI application using a fixed GUID. Also specify that this device is JEDEC compatible so that it is correctly initialized when running `sf probe`. Signed-off-by: Paul Barker --- ar

Re: [PATCH v4 2/6] efi: Add string conversion helper

2022-10-05 Thread Heinrich Schuchardt
On 10/5/22 14:18, Paul Barker wrote: Signed-off-by: Paul Barker --- include/efi_loader.h| 3 ++- lib/efi_loader/efi_string.c | 24 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/include/efi_loader.h b/include/efi_loader.h index 545ba06d9466..

Re: [PATCH v4 1/6] spi: Implement spi_set_speed

2022-10-05 Thread Heinrich Schuchardt
On 10/5/22 14:18, Paul Barker wrote: This function is already defined in spi.h but no implementation of it currently exists in the tree. The implementation is based on the static function spi_set_speed_mode(). The function prototype is modified so that an success or error condition can be returne

Re: [RFC PATCH 1/2] efi_loader: define internal implementations of install/uninstallmultiple

2022-10-05 Thread Heinrich Schuchardt
On 10/5/22 17:26, Ilias Apalodimas wrote: A following patch is cleaning up the core EFI code trying to remove sequences of efi_create_handle, efi_add_protocol. Although this works fine there's a problem with the latter since it is usually combined with efi_delete_handle() which blindly removes a

Re: [RFC PATCH 2/2] cmd: replace efi_create_handle/add_protocol with InstallMultipleProtocol

2022-10-05 Thread Heinrich Schuchardt
On 10/6/22 03:53, AKASHI Takahiro wrote: On Wed, Oct 05, 2022 at 06:26:02PM +0300, Ilias Apalodimas wrote: In general handles should only be deleted if the last remaining protocol is removed. Instead of explicitly calling efi_create_handle -> efi_add_protocol -> efi_delete_handle which blindly

Re: [RFC PATCH 2/2] cmd: replace efi_create_handle/add_protocol with InstallMultipleProtocol

2022-10-05 Thread AKASHI Takahiro
On Wed, Oct 05, 2022 at 06:26:02PM +0300, Ilias Apalodimas wrote: > In general handles should only be deleted if the last remaining protocol > is removed. Instead of explicitly calling > efi_create_handle -> efi_add_protocol -> efi_delete_handle which blindly > removes all protocols from a handle

Re: [RFC PATCH 1/2] efi_loader: define internal implementations of install/uninstallmultiple

2022-10-05 Thread AKASHI Takahiro
Hi Ilias, On Wed, Oct 05, 2022 at 06:26:01PM +0300, Ilias Apalodimas wrote: > A following patch is cleaning up the core EFI code trying to remove > sequences of efi_create_handle, efi_add_protocol. > > Although this works fine there's a problem with the latter since it is > usually combined with

Re: [RFC PATCH 0/2] Clean up protocol installation API

2022-10-05 Thread AKASHI Takahiro
Hi Ilias, On Wed, Oct 05, 2022 at 06:26:00PM +0300, Ilias Apalodimas wrote: > This RFC is trying to clean up the usage of the internal functions used > to manage the protocol and handle lifetimes. Currently we arbitrarily > use either InstallProtocol, InstallMultipleProtocol and a combination of

Re: [PATCH 0/3] arm: smh: Fix and improve semihosting traps

2022-10-05 Thread Sean Anderson
On 10/5/22 12:38, Andre Przywara wrote: While playing around with QEMU's semihosting implementation, I stared at our semihosting trap code, and found some issues, that this mini-series fixes. Please have a look! Cheers, Andre Andre Przywara (3): arm: smh: specify Thumb trap instruction

Re: [PATCH v5 7/8] net: add MV88E61xx DSA driver

2022-10-05 Thread Tim Harvey
On Tue, Oct 4, 2022 at 4:48 PM Vladimir Oltean wrote: > > Please also rewrite "61xx" from the commit message into "6xxx". > > On Tue, Oct 04, 2022 at 09:49:17AM -0700, Tim Harvey wrote: > > Add a DSA driver for the MV88E61xx compatible GbE Ethernet switches. > > > > Cc: Marek BehĂșn > > Cc: Vladi

[PATCH] phy: ti: j721e-wiz: add j784s4-wiz-10g module support

2022-10-05 Thread Matt Ranostay
Add support for j784s4-wiz-10g device which has two core reference clocks (e.g core_ref_clk, core_ref1_clk) which requires an additional mux selection option. Signed-off-by: Matt Ranostay --- drivers/phy/ti/phy-j721e-wiz.c | 75 -- 1 file changed, 72 insertions(+)

Re: [PATCH v5 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-05 Thread Tim Harvey
On Tue, Oct 4, 2022 at 4:58 PM Vladimir Oltean wrote: > > On Tue, Oct 04, 2022 at 09:49:18AM -0700, Tim Harvey wrote: > > Add MV88E61XX DSA support: > > - update dt: U-Boot dsa driver requires different device-tree syntax > >than the linux driver in order to link the dsa ports to the mdio bus

[U-Boot] Spansion QSPI S70FL01GS Support

2022-10-05 Thread Lorenzo Adani
Hi, I'm using a QSPI S70FL01GS (128MB) connected to a CycloneV. In the Qsys I set two chipselect pins for accessing QSPI, then I recompiled the whole project and the U-Boot. When I issue the command 'sf probe' U-Boot returns: SF: Detected s25fl512s with page size 256 Bytes, erase size 256 KiB

[PATCH 2/3] arm: smh: Make semihosting trap calls more robust

2022-10-05 Thread Andre Przywara
Commit f4b540e25c5c("arm: smh: Fix uninitialized parameters with newer GCCs") added a memory clobber to the semihosting inline assembly trap calls, to avoid too eager GCC optimisation: when passing a pointer, newer compilers couldn't be bothered to actually fill in the structure that it pointed to,

[PATCH 3/3] arm: smh: Allow semihosting trap calls to be inlined

2022-10-05 Thread Andre Przywara
Currently our semihosting trap function is somewhat fragile: we rely on the current compiler behaviour to assign the second inline assembly argument to the next free register (r1/x1), which happens to be the "addr" argument to the smh_trap() function (per the calling convention). I guess this is al

[PATCH 1/3] arm: smh: specify Thumb trap instruction

2022-10-05 Thread Andre Przywara
The ARM semihosting interface uses different trap instructions for different architectures and instruction sets. So far we were using AArch64 and ARMv7-M, and had an untested v7-A entry. The latter does not work when building for Thumb, as can be verified by using qemu_arm_defconfig, then enabling

[PATCH 0/3] arm: smh: Fix and improve semihosting traps

2022-10-05 Thread Andre Przywara
While playing around with QEMU's semihosting implementation, I stared at our semihosting trap code, and found some issues, that this mini-series fixes. Please have a look! Cheers, Andre Andre Przywara (3): arm: smh: specify Thumb trap instruction arm: smh: Make semihosting trap calls more ro

Re: [PATCH V2 10/13] iot2050: Add script for signing artifacts

2022-10-05 Thread Jan Kiszka
On 05.10.22 18:04, Jan Kiszka wrote: > On 05.10.22 17:58, Simon Glass wrote: >> Hi Jan, >> >> On Wed, 5 Oct 2022 at 02:36, Jan Kiszka wrote: >>> >>> From: Jan Kiszka >>> >>> There are many ways to get a signed firmware for the IOT2050 devices, >>> namely for the parts under user-control. This scr

Re: [PATCH V2 10/13] iot2050: Add script for signing artifacts

2022-10-05 Thread Jan Kiszka
On 05.10.22 17:58, Simon Glass wrote: > Hi Jan, > > On Wed, 5 Oct 2022 at 02:36, Jan Kiszka wrote: >> >> From: Jan Kiszka >> >> There are many ways to get a signed firmware for the IOT2050 devices, >> namely for the parts under user-control. This script documents one way >> of doing it, given a

Re: [PATCH V2 10/13] iot2050: Add script for signing artifacts

2022-10-05 Thread Simon Glass
Hi Jan, On Wed, 5 Oct 2022 at 02:36, Jan Kiszka wrote: > > From: Jan Kiszka > > There are many ways to get a signed firmware for the IOT2050 devices, > namely for the parts under user-control. This script documents one way > of doing it, given a signing key. Augment the board documentation with

[RFC PATCH 2/2] cmd: replace efi_create_handle/add_protocol with InstallMultipleProtocol

2022-10-05 Thread Ilias Apalodimas
In general handles should only be deleted if the last remaining protocol is removed. Instead of explicitly calling efi_create_handle -> efi_add_protocol -> efi_delete_handle which blindly removes all protocols from a handle before removing it, use InstallMultiple/UninstallMultiple which adheres t

[RFC PATCH 1/2] efi_loader: define internal implementations of install/uninstallmultiple

2022-10-05 Thread Ilias Apalodimas
A following patch is cleaning up the core EFI code trying to remove sequences of efi_create_handle, efi_add_protocol. Although this works fine there's a problem with the latter since it is usually combined with efi_delete_handle() which blindly removes all protocols on a handle and deletes the han

[RFC PATCH 0/2] Clean up protocol installation API

2022-10-05 Thread Ilias Apalodimas
This RFC is trying to clean up the usage of the internal functions used to manage the protocol and handle lifetimes. Currently we arbitrarily use either InstallProtocol, InstallMultipleProtocol and a combination of efi_add_protocol, efi_create_handle, efi_delete_handle(). The latter is the most p

Re: [PATCH v4] imx: support i.MX8QM DMSSE20 a1 board

2022-10-05 Thread oliver.gra...@kococonnector.com
On 13/07/22, Marcel Ziswiler wrote: > Hi Oliver > > On Tue, 2022-07-12 at 12:14 +0200, Oliver Graute wrote: > > Add i.MX8QM DMSSE20 a1 board support > > > > U-Boot 2022.07-00033-g2a5cf8e9e7 (Jul 12 2022 - 11:29:05 +0200) > > > > Model: Advantech iMX8QM DMSSE20 > > Board: DMS-SE20A1 8GB > > Build

Re: [PATCH v1 0/4] phy: Add generic_{setup,shutdown}_phy() helpers

2022-10-05 Thread Marek Vasut
On 10/4/22 08:43, Patrice CHOTARD wrote: Hi Marek On 9/7/22 01:03, Marek Vasut wrote: On 9/6/22 08:15, Patrice Chotard wrote: In drivers ehci-generic.c and ohci-generic.c, specific phy helpers has been added and shared 95% of common code. Factorize this code in generic_{setup,shutdown}_phy()

[PATCH v4 3/6] efi_loader: Add SPI I/O protocol support

2022-10-05 Thread Paul Barker
This addition allows UEFI applications running under u-boot to access peripherals on SPI busses. It is based on the UEFI Platform Initialization (PI) Specification, Version 1.7 Errata A (April 2020). Only the core functionality required to discover SPI peripherals and communicate with them is curre

[PATCH v4 5/6] arm: dts: am335x-sancloud-bbe-lite: UEFI SPI export

2022-10-05 Thread Paul Barker
Add properties to the Authenta SPI flash device node to enable access by a UEFI application using a fixed GUID. Also specify that this device is JEDEC compatible so that it is correctly initialized when running `sf probe`. Signed-off-by: Paul Barker --- arch/arm/dts/am335x-sancloud-bbe-lite.dts

[PATCH v4 6/6] am335x_evm_defconfig: Enable Micron SPI flash support

2022-10-05 Thread Paul Barker
Signed-off-by: Paul Barker --- configs/am335x_evm_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/am335x_evm_defconfig b/configs/am335x_evm_defconfig index f0fbe475b394..f73123e0b71d 100644 --- a/configs/am335x_evm_defconfig +++ b/configs/am335x_evm_defconfig @@ -92,6 +92,7

[PATCH v4 4/6] efi_selftest: Add tests for SPI protocol support

2022-10-05 Thread Paul Barker
These tests ensure that the new UEFI SPI I/O protocol support works as expected. They are intended to execute on the sandbox target. Signed-off-by: Paul Barker --- MAINTAINERS | 1 + arch/sandbox/dts/test.dts| 13 + lib/efi_selftest/Makefil

[PATCH v4 0/6] Support UEFI SPI I/O protocol

2022-10-05 Thread Paul Barker
These patches add support for the UEFI SPI I/O protocol defined in the UEFI Platform Initialization (PI) Specification, Version 1.7 Errata A (April 2020). This allows a UEFI application to interact with devices on the SPI bus. This support is initially intended to be used to communicate with SPI d

[PATCH v4 2/6] efi: Add string conversion helper

2022-10-05 Thread Paul Barker
Signed-off-by: Paul Barker --- include/efi_loader.h| 3 ++- lib/efi_loader/efi_string.c | 24 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/include/efi_loader.h b/include/efi_loader.h index 545ba06d9466..4dbbb2d3a06c 100644 --- a/include/efi_load

[PATCH v4 1/6] spi: Implement spi_set_speed

2022-10-05 Thread Paul Barker
This function is already defined in spi.h but no implementation of it currently exists in the tree. The implementation is based on the static function spi_set_speed_mode(). The function prototype is modified so that an success or error condition can be returned to the caller. Signed-off-by: Paul B

[PATCH v3 6/7] fpga: spartan3: Use logging feature instead of FPGA_DEBUG

2022-10-05 Thread Alexander Dahl
Instead of using DEBUG or LOG_DEBUG the driver still had its own definition for debug output. Signed-off-by: Alexander Dahl --- drivers/fpga/spartan3.c | 80 +++-- 1 file changed, 37 insertions(+), 43 deletions(-) diff --git a/drivers/fpga/spartan3.c b/driver

[PATCH v3 3/7] fpga: Add missing Kconfig symbols for old FPGA drivers

2022-10-05 Thread Alexander Dahl
Those drivers could not be built anymore without those options present. Signed-off-by: Alexander Dahl --- drivers/fpga/Kconfig | 12 1 file changed, 12 insertions(+) diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig index e2fd16e6d2..813d6a836d 100644 --- a/drivers/fpga/Kcon

[PATCH v3 7/7] fpga: virtex2: Use logging feature instead of FPGA_DEBUG

2022-10-05 Thread Alexander Dahl
Instead of using DEBUG or LOG_DEBUG the driver still had its own definition for debug output. Signed-off-by: Alexander Dahl --- drivers/fpga/virtex2.c | 69 ++ 1 file changed, 30 insertions(+), 39 deletions(-) diff --git a/drivers/fpga/virtex2.c b/drivers

[PATCH v3 5/7] fpga: spartan2: Use logging feature instead of FPGA_DEBUG

2022-10-05 Thread Alexander Dahl
Instead of using DEBUG or LOG_DEBUG the driver still had its own definition for debug output. Signed-off-by: Alexander Dahl --- drivers/fpga/spartan2.c | 80 +++-- 1 file changed, 37 insertions(+), 43 deletions(-) diff --git a/drivers/fpga/spartan2.c b/driver

[PATCH v3 2/7] fpga: cyclon2: Use logging feature instead of FPGA_DEBUG

2022-10-05 Thread Alexander Dahl
Instead of using DEBUG or LOG_DEBUG the driver still had its own definition for debug output. Signed-off-by: Alexander Dahl --- drivers/fpga/cyclon2.c | 38 -- 1 file changed, 16 insertions(+), 22 deletions(-) diff --git a/drivers/fpga/cyclon2.c b/drivers/fpg

[PATCH v3 4/7] fpga: ACEX1K: Use logging feature instead of FPGA_DEBUG

2022-10-05 Thread Alexander Dahl
Instead of using DEBUG or LOG_DEBUG the driver still had its own definition for debug output. Signed-off-by: Alexander Dahl --- drivers/fpga/ACEX1K.c | 37 - 1 file changed, 16 insertions(+), 21 deletions(-) diff --git a/drivers/fpga/ACEX1K.c b/drivers/fpga/A

[PATCH v3 1/7] fpga: altera: Use logging feature instead of FPGA_DEBUG

2022-10-05 Thread Alexander Dahl
Instead of using DEBUG or LOG_DEBUG the driver still had its own definition for debug output. Signed-off-by: Alexander Dahl --- drivers/fpga/altera.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/fpga/altera.c b/drivers/fpga/altera.c index 10c0475d25..6a

[PATCH v3 0/8] Use logging feature instead of FPGA_DEBUG

2022-10-05 Thread Alexander Dahl
macros, so there's room for future improvements. Changelog: v2 -> v3: - Patch introducing FPGA uclass was completely reworked, sent independently from this series, and applied already, thus removed - Because requiring that new FPGA uclass changes, rebased on Michal's microblaze bra

[PATCH v2] xilinx: zynqmp: Load pmufw configuration before checking access

2022-10-05 Thread Michal Simek
Before this patch you could see in the log: U-Boot SPL 2022.10-rc5 (Sep 29 2022 - 15:29:27 +0200) PMUFW: v1.1 Loading new PMUFW cfg obj (32 bytes) PMUFW: No permission to change config object Loading new PMUFW cfg obj (2032 bytes) where it is visible that permission is check before sending PMUFW

Re: [PATCH 1/1] cmd: simplify command efidebug

2022-10-05 Thread Ilias Apalodimas
Akashi-san [...] > > > > > "\n" > > > > > #endif > > > > > - "efidebug devices\n" > > > > > - " - show UEFI devices\n" > > > > > "efidebug drivers\n" > > > > > " - show UEFI drivers\n" > > > > > "efidebug dh\n" > > > > > -- > > > > > 2.37.2 > > > >

Re: [PATCH] xilinx: zynqmp: Load pmufw configuration before checking access

2022-10-05 Thread Michal Simek
út 4. 10. 2022 v 13:54 odesílatel Michal Simek napsal: > > pá 30. 9. 2022 v 9:36 odesílatel Michal Simek napsal: > > > > Before this patch you could see in the log: > > U-Boot SPL 2022.10-rc5 (Sep 29 2022 - 15:29:27 +0200) > > PMUFW: v1.1 > > Loading new PMUFW cfg obj (32 bytes) > > PMUFW: No p

[PATCH] lib: fix buggy strcmp and strncmp

2022-10-05 Thread Rasmus Villemoes
There are two problems with both strcmp and strncmp: (1) The C standard is clear that the contents should be compared as "unsigned char": The sign of a nonzero value returned by the comparison functions memcmp, strcmp, and strncmp is determined by the sign of the difference between the valu

Re: [PATCH 1/1] efi_driver: carve out function to create block device

2022-10-05 Thread Ilias Apalodimas
Hi Heinrich, On Tue, Oct 04, 2022 at 04:29:25PM +0200, Heinrich Schuchardt wrote: > * Carve out function efi_bl_create_block_device() from efi_bl_bind(). > * Add a check for U-Boot devices to efi_bl_bind(). What the code does is obvious here, can we slightly change the commit message and explai

Re: [PATCH 1/1] cmd: simplify command efidebug

2022-10-05 Thread AKASHI Takahiro
On Wed, Oct 05, 2022 at 10:23:26AM +0300, Ilias Apalodimas wrote: > On Wed, Oct 05, 2022 at 08:27:37AM +0200, Heinrich Schuchardt wrote: > > On 10/5/22 02:23, AKASHI Takahiro wrote: > > > Heinrich, > > > > > > On Tue, Oct 04, 2022 at 03:40:32PM +0200, Heinrich Schuchardt wrote: > > > > Currently w

[PATCH V2 13/13] board: siemens: iot2050: use the named gpio to control the user-button

2022-10-05 Thread Jan Kiszka
From: chao zeng User-button is controlled by the mcu domain gpio number 25. But main0 main1 mcu domain all have gpio number 25. To identify where the gpio is from, Using gpio controll base as the prefix to indicate the gpio resource. Signed-off-by: chao zeng --- board/siemens/iot2050/board.c

[PATCH V2 12/13] doc: iot2050: Add a note about the watchdog firmware

2022-10-05 Thread Jan Kiszka
From: Jan Kiszka This is enabled by default, thus should be described as well. Signed-off-by: Jan Kiszka --- doc/board/siemens/iot2050.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/board/siemens/iot2050.rst b/doc/board/siemens/iot2050.rst index cb49a0e36bf..efe94a448a9 100644

[PATCH V2 11/13] arm: dts: iot2050: Optionally embed OTP programming data into image

2022-10-05 Thread Jan Kiszka
From: Jan Kiszka Use external blob otpcmd.bin to replace the 0xff filled OTP programming command block to create a firmware image that provisions the OTP on first boot. This otpcmd.bin is generated from the customer keys using steps described in the meta-iot2050 integration layer for the device.

[PATCH V2 10/13] iot2050: Add script for signing artifacts

2022-10-05 Thread Jan Kiszka
From: Jan Kiszka There are many ways to get a signed firmware for the IOT2050 devices, namely for the parts under user-control. This script documents one way of doing it, given a signing key. Augment the board documentation with the required procedure around it. Signed-off-by: Jan Kiszka --- d

[PATCH V2 08/13] iot2050: Add CONFIG_ENV_FLAGS_LIST_STATIC

2022-10-05 Thread Jan Kiszka
From: Jan Kiszka Will be needed when CONFIG_ENV_WRITEABLE_LIST is enabled. The listed variables shall remain writable, for informational purposes - they have to be considered untrusted because the persistent U-Boot env is not protected. Signed-off-by: Jan Kiszka --- include/configs/iot2050.h |

[PATCH V2 09/13] arm: dts: iot2050: Allow verifying U-Boot proper by SPL

2022-10-05 Thread Jan Kiszka
From: Jan Kiszka Add hashes and configuration signature stubs to prepare verified boot of main U-Boot by SPL. Signed-off-by: Jan Kiszka --- arch/arm/dts/k3-am65-iot2050-boot-image.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/dts/k3-am65-iot2050-boot-image

[PATCH V2 04/13] board: siemens: iot2050: Split the build for PG1 and PG2

2022-10-05 Thread Jan Kiszka
From: Su Baocheng Due to different signature keys, the PG1 and the PG2 boards can no longer use the same FSBL (tiboot3). This makes it impossible anyway to maintaine a single flash.bin for both variants, so we can also split the build. A new target is added to indicates the build is for PG1 vs.

[PATCH V2 06/13] iot2050: Update firmware layout

2022-10-05 Thread Jan Kiszka
From: Jan Kiszka The latest version of the binary-only firmware parts come in a combined form of FSBL and sysfw containers. This implies some layout changes to the generated firmware image but also makes handling of artifacts much simpler (4 files less). The env locations will not change, just th

[PATCH V2 07/13] iot2050: Add watchdog start to bootcmd

2022-10-05 Thread Jan Kiszka
From: Jan Kiszka Allows run-time control over watchdog auto-start and the timeout via setting the environment variable watchdog_timeout_ms. A value of zero means "do not start". Use CONFIG_WATCHDOG_TIMEOUT_MSECS as initial value and this to zero by default. Users can then enable the watchdog once

[PATCH V2 03/13] tools: Add script for converting public key into device tree include

2022-10-05 Thread Jan Kiszka
From: Jan Kiszka Allows to create a public key device tree dtsi for inclusion into U-Boot SPL and proper during first build already. This can be achieved via CONFIG_DEVICE_TREE_INCLUDES. Signed-off-by: Jan Kiszka --- tools/key2dtsi.py | 64 +++ 1 fil

[PATCH V2 02/13] env: Couple networking-related variable flags to CONFIG_NET

2022-10-05 Thread Jan Kiszka
From: Jan Kiszka Boards may set networking variables programmatically, thus may have CONFIG_NET on but CONFIG_CMD_NET off. The IOT2050 is an example. CC: Joe Hershberger Signed-off-by: Jan Kiszka --- env/flags.c | 10 +- include/env_flags.h | 4 ++-- 2 files changed, 7 insert

[PATCH V2 01/13] env: Complete generic support for writable list

2022-10-05 Thread Jan Kiszka
From: Jan Kiszka This completes what 890feecaab72 started by selecting ENV_APPEND and ENV_IS_NOWHERE and by moving this driver to top if the list. This ensures that load operations pick up both the default env and the permitted parts of the next-prio location. When writing though, we must use the

[PATCH V2 05/13] arm: dts: iot2050: Use the auto generator nodes for fdt

2022-10-05 Thread Jan Kiszka
From: Su Baocheng Refactor according to the entry `fit: Entry containing a FIT` of document tools/binman/README.entries. As the generator uses the device tree name for the config description, board_fit_config_name_match requires a small adjustment as well. Signed-off-by: Su Baocheng [Jan: re-a

[PATCH V2 00/13] IOT2050-related enhancements

2022-10-05 Thread Jan Kiszka
(Almost) flushing our upstream queue for the IOT2050 device, this mostly brings board-specific changes such as: - updated build process and firmware layout for PG1 vs. PG2 devices - more watchdog preparations - preparations for verified boot on IOT2050 Advanced devices There are also some gene

Re: [RFC 1/1] efi_loader: fix open protocol information for block device

2022-10-05 Thread Heinrich Schuchardt
On 10/4/22 21:31, Heinrich Schuchardt wrote: If OpenProtocol() is called without an agent handle, no open protocol information is generated. With the patch we actually see the link between partition an its block device when printing the open protocol information: 1b2452f0 (host0)

Re: [PATCH 1/1] cmd: simplify command efidebug

2022-10-05 Thread Ilias Apalodimas
On Wed, Oct 05, 2022 at 08:27:37AM +0200, Heinrich Schuchardt wrote: > On 10/5/22 02:23, AKASHI Takahiro wrote: > > Heinrich, > > > > On Tue, Oct 04, 2022 at 03:40:32PM +0200, Heinrich Schuchardt wrote: > > > Currently we have subcommands 'efidebug dh' which shows protocols per > > > handle and 'e

Re: [RFC 1/1] cmd: add command to dump EFI block devices

2022-10-05 Thread Ilias Apalodimas
Thanks Heinrich On Tue, Oct 04, 2022 at 07:01:46PM +0200, Heinrich Schuchardt wrote: > On 10/4/22 18:30, Simon Glass wrote: > > Hi Heinrich, > > > > On Tue, 4 Oct 2022 at 06:34, Heinrich Schuchardt > > wrote: > > > > > > Provide a command to dump > > > > > > * all block devices > > > * the pro

Re: [PATCH 1/1] doc: documentation of EFI driver binding protocol

2022-10-05 Thread Ilias Apalodimas
Hi Heinrich, On Tue, Oct 04, 2022 at 06:30:34PM +0200, Heinrich Schuchardt wrote: > * Convert code comments in include/efi_driver.h to Sphinx style. > * Add include/efi_driver.h to the HTML documentation. > > Signed-off-by: Heinrich Schuchardt > --- > doc/api/efi.rst | 6 ++ > includ

Re: [PATCH 1/1] test: fix some pylint errors in test_efi_secboot

2022-10-05 Thread Ilias Apalodimas
On Sat, Oct 01, 2022 at 08:57:09PM +0200, Heinrich Schuchardt wrote: > * Remove unused import > * Provide module docstring > > Signed-off-by: Heinrich Schuchardt > --- > test/py/tests/test_efi_secboot/conftest.py | 12 +++- > 1 file changed, 3 insertions(+), 9 deletions(-) > > diff --gi