Re: [PATCH] net: marvell: mvgbe: Set PHY page 0 before phy_connect

2022-04-22 Thread Tony Dinh
Hi Stefan, Please see my various comments below. And my thoughts at the end. On Thu, Apr 21, 2022 at 11:15 PM Stefan Roese wrote: > > Hi Tony, > > On 4/21/22 23:21, Tony Dinh wrote: > > > > >> What really puzzles me is, why the page address is set to a non-zero > >> value at all at this early b

Re: [PATCH 1/3] dm: core: Add DM_FLAG_PROBE_AFTER_BIND flag

2022-04-22 Thread Marek Vasut
On 4/23/22 02:16, Sean Anderson wrote: On 4/22/22 7:07 PM, Marek Vasut wrote: On 4/23/22 00:45, Sean Anderson wrote: On 4/22/22 9:52 AM, Marek Vasut wrote: On 4/22/22 15:49, Sean Anderson wrote: On 4/22/22 9:15 AM, Marek Vasut wrote: Introduce DM_FLAG_PROBE_AFTER_BIND flag, which can be set b

Re: [PATCH 1/3] dm: core: Add DM_FLAG_PROBE_AFTER_BIND flag

2022-04-22 Thread Sean Anderson
On 4/22/22 7:07 PM, Marek Vasut wrote: On 4/23/22 00:45, Sean Anderson wrote: On 4/22/22 9:52 AM, Marek Vasut wrote: On 4/22/22 15:49, Sean Anderson wrote: On 4/22/22 9:15 AM, Marek Vasut wrote: Introduce DM_FLAG_PROBE_AFTER_BIND flag, which can be set by driver or uclass in .bind(), to indic

Re: [PATCH 1/3] dm: core: Add DM_FLAG_PROBE_AFTER_BIND flag

2022-04-22 Thread Marek Vasut
On 4/23/22 00:45, Sean Anderson wrote: On 4/22/22 9:52 AM, Marek Vasut wrote: On 4/22/22 15:49, Sean Anderson wrote: On 4/22/22 9:15 AM, Marek Vasut wrote: Introduce DM_FLAG_PROBE_AFTER_BIND flag, which can be set by driver or uclass in .bind(), to indicate such driver instance should be probe

Re: [PATCH v2 1/6] clk: meson: add minimal driver for axg-ao clocks

2022-04-22 Thread Sean Anderson
On 4/22/22 1:29 AM, Vyacheslav Bocharov wrote: Add minimal driver AO clocks on meson AXG family. Only ADC related clocks are supported. Signed-off-by: Vyacheslav Bocharov --- drivers/clk/meson/Makefile | 1 + drivers/clk/meson/axg-ao.c | 89 ++ 2 files c

Re: [PATCH 1/3] dm: core: Add DM_FLAG_PROBE_AFTER_BIND flag

2022-04-22 Thread Sean Anderson
On 4/22/22 9:52 AM, Marek Vasut wrote: On 4/22/22 15:49, Sean Anderson wrote: On 4/22/22 9:15 AM, Marek Vasut wrote: Introduce DM_FLAG_PROBE_AFTER_BIND flag, which can be set by driver or uclass in .bind(), to indicate such driver instance should be probe()d once binding of all devices is compl

[RFC PATCH] arm: mach-imx: cmd_nandbcb fix bad block handling

2022-04-22 Thread Michael Trimarchi
The badblock should be skipped properly in reading and writing. Fix the logic NOTE. This is a rfc. Working on imx8mn and found the bad block handling in nand is quite broken. Seems that bootrom does not handle it so I switch on spl nand bad block and found there other bugs. I have fixed most of th

[PATCH v2] misc: Fix always compiling MISC even for SPL/TPL

2022-04-22 Thread Sean Anderson
We should only build support for misc if the appropriate SPL/TPL symbol is defined. To ease the transition, make SPL/TPL_MISC default to MISC. This is necessary because many drivers don't specify their dependencies properly. These defaults can be removed once all drivers depend on the appropriate c

Re: [PATCH] misc: Fix always compiling MISC even for SPL/TPL

2022-04-22 Thread Sean Anderson
Hi Tom, On 4/22/22 3:56 PM, Tom Rini wrote: > On Tue, Apr 19, 2022 at 03:12:45PM -0400, Sean Anderson wrote: > >> We should only build support for misc if the appropriate SPL/TPL symbol >> is defined. >> >> Fixes: aaba703fd0 ("spl: misc: Allow misc drivers in SPL and TPL") >> Signed-off-by: Sean

Re: [PATCH] misc: Fix always compiling MISC even for SPL/TPL

2022-04-22 Thread Tom Rini
On Tue, Apr 19, 2022 at 03:12:45PM -0400, Sean Anderson wrote: > We should only build support for misc if the appropriate SPL/TPL symbol > is defined. > > Fixes: aaba703fd0 ("spl: misc: Allow misc drivers in SPL and TPL") > Signed-off-by: Sean Anderson > --- > > drivers/misc/Makefile | 2 +- >

Re: [PATCH] usb: dwc3: add a SPL_USB_DWC3_GENERIC option for the dwc3 driver

2022-04-22 Thread Sean Anderson
Hi Angus, On 4/22/22 1:47 PM, Angus Ainslie wrote: > Suppress warnings when building the SPL without USB_DWC3_GENERIC > > Signed-off-by: Angus Ainslie > --- > drivers/usb/dwc3/Kconfig | 7 +++ > drivers/usb/dwc3/Makefile | 2 +- > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff -

[PATCH] serial: smh: Check return value of strndup

2022-04-22 Thread Sean Anderson
strndup can fail. Check for it. Fixes: 4855b39be ("serial: smh: Implement puts for DM") Signed-off-by: Sean Anderson --- drivers/serial/serial_semihosting.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/serial/serial_semihosting.c b/drivers/serial/serial_semihosting.c index 43

[PATCH v2 3/3] arch: layerscape: Add SFP binding

2022-04-22 Thread Sean Anderson
This adds an SFP binding for the processors it is present on. I have only tested this for the LS1046A. Signed-off-by: Sean Anderson --- (no changes since v1) arch/arm/dts/fsl-ls1012a.dtsi | 7 +++ arch/arm/dts/fsl-ls1043a.dtsi | 7 +++ arch/arm/dts/fsl-ls1046a.dtsi | 7 +++ arch/ar

[PATCH v2 2/3] ARM: dts: ls1021a: update the clockgen node

2022-04-22 Thread Sean Anderson
QorIQ platforms now use different clock bindings. Although we don't use the device tree for clocks on this platform, it is helpful to sync it because then the bindings will more closely match Linux. Additionally, it allows for using more clock fractions (such as platform/4). This corresponds to Li

[PATCH v2 1/3] arm: layerscape: Add sfp driver

2022-04-22 Thread Sean Anderson
This adds a driver for the Security Fuse Processor (SFP) present on LS1012A, LS1021A, LS1043A, and LS1046A processors. It holds the Super-Root Key (SRK), One-Time-Programmable Master Key (OTPMK), and other "security" related fuses. Similar devices (sharing the same name) are present on other proces

[PATCH v2 0/3] arm: layerscape: Add sfp driver

2022-04-22 Thread Sean Anderson
This adds a driver for the Security Fuse Processor (SFP). It only supports Trust Architecture (TA) 2.1 SFPs, but it should be fairly trivial to add support for TA 3.1 SFPs. See [1] for Linux bindings/driver support. [1] https://lore.kernel.org/linux-arm-kernel/20220422145147.2210587-1-sean.ander.

[PATCH v2 9/9] spl: spi: Consolidate spi_load_image_os into spl_spi_load_image

2022-04-22 Thread Sean Anderson
spi_load_image_os performs almost the same steps as the non-falcon-boot path of spl_spi_load_image. The load address is different, and it also loads a device tree, but that's it. Refactor the boot process so that they can both use the same load function. Signed-off-by: Sean Anderson --- Changes

[PATCH v2 6/9] spl: Convert nor to spl_load

2022-04-22 Thread Sean Anderson
This converts the nor load method to use spl_load. As a result it also adds support for LOAD_FIT_FULL. Signed-off-by: Sean Anderson Reviewed-by: Stefan Roese --- (no changes since v1) common/spl/spl_nor.c | 35 ++- 1 file changed, 6 insertions(+), 29 deletions(

[PATCH v2 7/9] spl: Convert semihosting to spl_load

2022-04-22 Thread Sean Anderson
This converts the semihosting load method to use spl_load. As a result, it also adds support for LOAD_FIT_FULL and IMX images. Signed-off-by: Sean Anderson --- Changes in v2: - New common/spl/spl_semihosting.c | 39 +++- 1 file changed, 16 insertions(+), 23 dele

[PATCH v2 8/9] spl: Convert spi to spl_load

2022-04-22 Thread Sean Anderson
This converts the spi load method to use spl_load. As a consequence, it also adds support for LOAD_FIT_FULL. Signed-off-by: Sean Anderson Reviewed-by: Stefan Roese --- (no changes since v1) common/spl/spl_spi.c | 48 +++- 1 file changed, 7 insertions(+)

[PATCH v2 5/9] spl: Convert net to spl_load

2022-04-22 Thread Sean Anderson
This converts the net load method to use spl_load. As a result, it also adds support for LOAD_FIT_FULL and IMX images. Signed-off-by: Sean Anderson Reviewed-by: Stefan Roese --- (no changes since v1) common/spl/spl_net.c | 24 +--- 1 file changed, 5 insertions(+), 19 delet

[PATCH v2 4/9] spl: Convert mmc to spl_load

2022-04-22 Thread Sean Anderson
This converts the mmc loader to spl_load. Legacy images are handled by spl_load (via spl_parse_image_header), so mmc_load_legacy can be omitted. Signed-off-by: Sean Anderson Reviewed-by: Stefan Roese --- (no changes since v1) common/spl/spl_mmc.c | 73 -

[PATCH v2 3/9] spl: Convert fat to spl_load

2022-04-22 Thread Sean Anderson
This converts the fat loader to use spl_load. Signed-off-by: Sean Anderson Reviewed-by: Stefan Roese --- (no changes since v1) common/spl/spl_fat.c | 36 ++-- 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/common/spl/spl_fat.c b/common/spl/spl_f

[PATCH v2 2/9] spl: Convert ext to use spl_load

2022-04-22 Thread Sean Anderson
This converts the ext load method to use spl_load. As a consequence, it also adds support for FIT and IMX images. Signed-off-by: Sean Anderson Reviewed-by: Stefan Roese --- (no changes since v1) common/spl/spl_ext.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(

[PATCH v2 1/9] spl: Add generic spl_load function

2022-04-22 Thread Sean Anderson
Implementers of SPL_LOAD_IMAGE_METHOD have to correctly determine what type of image is being loaded and then call the appropriate image load function correctly. This is tricky, because some image load functions expect the whole image to already be loaded (CONFIG_SPL_LOAD_FIT_FULL), some will load

[PATCH v2 0/9] spl: Use common function for loading/parsing images

2022-04-22 Thread Sean Anderson
This series adds support for loading all image types (Legacy, FIT (with and without LOAD_FIT_FULL), and i.MX) to the MMC, SPI, NOR, NET, FAT, and EXT load methods. It does this by introducing a helper function which handles the minutiae of invoking the proper parsing function, and reading the rest

Re: [PATCH v3] board: purism: add the Purism Librem5 phone

2022-04-22 Thread Angus Ainslie
On 2022-04-22 02:15, Stefano Babic wrote: Hi Angus, On 20.04.22 20:13, Angus Ainslie wrote: Initial commit of Librem5 u-boot and SPL [snip] After merging a patch on dwc3, build reports some warnings (functions defined and not used). Could you fix them ? This patch should silence the w

[PATCH] usb: dwc3: add a SPL_USB_DWC3_GENERIC option for the dwc3 driver

2022-04-22 Thread Angus Ainslie
Suppress warnings when building the SPL without USB_DWC3_GENERIC Signed-off-by: Angus Ainslie --- drivers/usb/dwc3/Kconfig | 7 +++ drivers/usb/dwc3/Makefile | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig index 62aa6

[PATCH v2 6/6] net: fm: Add support for FIT firmware

2022-04-22 Thread Sean Anderson
Fman microcode is executable code (AFAICT) loaded into a coprocessor. As such, if verified boot is enabled, it must be verified like other executable code. However, this is not currently done. This commit adds verified boot functionality by encapsulating the microcode in a FIT, which can then be s

[PATCH v2 5/6] net: Convert fit verification to use fit_get_data_*

2022-04-22 Thread Sean Anderson
Several ethernet drivers load firmware from FIT images. Convert them to use the fit_get_data helpers. Signed-off-by: Sean Anderson --- Changes in v2: - New drivers/net/fsl-mc/mc.c| 30 +++--- drivers/net/pfe_eth/pfe_firmware.c | 40 +- 2

[PATCH v2 2/6] image: fit: Add some helpers for getting data

2022-04-22 Thread Sean Anderson
Several different firmware users have repetitive code to extract the firmware data from a FIT. Add some helper functions to reduce the amount of repetition. fit_conf_get_prop_node (eventually) calls fdt_check_node_offset_, so we can avoid an explicit if. In general, this version avoids printing on

[PATCH v2 4/6] cmd: fpga: Convert to use fit_get_data_node

2022-04-22 Thread Sean Anderson
This converts the FIT loading process of the fpga command to use fit_get_data_node. Signed-off-by: Sean Anderson --- Changes in v2: - New cmd/fpga.c | 24 ++-- 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/cmd/fpga.c b/cmd/fpga.c index 3fdd0b35e8..1102a84d7

[PATCH v2 3/6] ARMv8/sec_firmware: Convert to use fit_get_data_conf_prop

2022-04-22 Thread Sean Anderson
This reduces sec_firmware_get_data to a single call to fit_get_data_conf_prop. I think sec_firmware_check_copy_loadable could also be converted, but it does not map as straightforwardly, so I have left it for a future cleanup. Signed-off-by: Sean Anderson --- Changes in v2: - New arch/arm/cpu/

[PATCH v2 1/6] ARMv8/sec_firmware: Remove SEC_FIRMWARE_FIT_CNF_NAME

2022-04-22 Thread Sean Anderson
The config to use for FIT images can be better specified by enabling CONFIG_MULTI_DTB_FIT and implementing board_fit_config_name_match. Signed-off-by: Sean Anderson --- (no changes since v1) arch/arm/cpu/armv8/sec_firmware.c | 17 - 1 file changed, 4 insertions(+), 13 deletions

[PATCH v2 0/6] net: fm: Verify Fman microcode

2022-04-22 Thread Sean Anderson
Surprisingly, Fman microcode does not seem to be verified. This series aims to rectify this by introducing an optional FIT wrapper. This wrapper is made mandatory if FIT_SIGNATURE is enabled. NXP boards do not use this config, so the microcode will remain unverified for them. This is OK, since we d

[RESEND PATCH v2 2/3] net: fm: Add firmware name parameter

2022-04-22 Thread Sean Anderson
In order to read the firmware from the filesystem, we need a file name. Read the firmware name from the device tree, using the firmware-name property. This property is commonly used in Linux to determine the correct name to use (and can be seen in several device trees in U-Boot). Signed-off-by: Se

[RESEND PATCH v2 3/3] net: fm: Support loading firmware from a filesystem

2022-04-22 Thread Sean Anderson
This adds a new method to load Fman firmware from a filesystem. This allows users to use regular files instead of hard-coded offsets for the firmware. Signed-off-by: Sean Anderson --- (no changes since v1) drivers/net/fm/fm.c | 25 - drivers/qe/Kconfig | 4 2 fil

[RESEND PATCH v2 1/3] misc: fs_loader: Add function to get the chosen loader

2022-04-22 Thread Sean Anderson
The fs_loader device is used to pull in settings via the chosen node. However, there was no library function for this, so arria10 was doing it explicitly. This function subsumes that, and uses ofnode_get_chosen_node instead of navigating the device tree directly. Because fs_loader pulls its config

[RESEND PATCH v2 0/3] net: fm: Add support for loading firmware from filesystem

2022-04-22 Thread Sean Anderson
This adds support for loading Fman firmware from a filesystem using the firmware loader subsystem. It was originally part of [1], but has been split off because it is conceptually separate. [1] https://lore.kernel.org/u-boot/20220324182306.2037094-1-sean.ander...@seco.com/ Changes in v2: - Split

[PATCH 1/2] mx6slevk: Remove duplicated "mmc dev" command

2022-04-22 Thread Fabio Estevam
From: Fabio Estevam The "mmc dev ${mmcdev}" command is done twice. Remove one ocurrence to avoid the duplication. Signed-off-by: Fabio Estevam --- configs/mx6slevk_defconfig| 2 +- configs/mx6slevk_spinor_defconfig | 2 +- configs/mx6slevk_spl_defconfig| 2 +- 3 files changed, 3 i

[PATCH 2/2] mx6sllevk: Remove duplicated "mmc dev" command

2022-04-22 Thread Fabio Estevam
From: Fabio Estevam The "mmc dev ${mmcdev}" command is done twice. Remove one ocurrence to avoid the duplication. Signed-off-by: Fabio Estevam --- configs/mx6sllevk_defconfig| 2 +- configs/mx6sllevk_plugin_defconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] MAINTAINERS: Add Alper as a binman maintainer

2022-04-22 Thread Tom Rini
On Fri, Apr 22, 2022 at 06:25:47PM +0300, Alper Nebi Yasak wrote: > I ended up learning most of binman internals while trying to add a few > features to it, and I recently started reviewing binman series that > would not affect me personally. I'll keep working on it and try to do > more reviews. >

Re: [PATCH] cpu: 83xx: Add missing dependency on CPU_MPC83XX

2022-04-22 Thread Tom Rini
On Fri, Apr 22, 2022 at 03:32:21PM +0200, Michal Simek wrote: > It looks quite weird that for non PPC platforms cpu driver for MPC83xx can > be selected. That's why define proper dependency. > > Signed-off-by: Michal Simek Long term, we need the "or compile testing only" option like Linux has,

Re: Please pull u-boot-pmic master

2022-04-22 Thread Tom Rini
On Fri, Apr 22, 2022 at 11:22:24PM +0900, Jaehoon Chung wrote: > Dear Tom, > > Please pull u-boot-pmic master into u-boot master branch. > If there is a problem, let me know, plz > > Best Regards, > Jaehoon Chung > > CI: https://source.denx.de/u-boot/custodians/u-boot-pmic/-/pipelines/11829 >

Re: [PULL] u-boot-usb/master

2022-04-22 Thread Tom Rini
On Fri, Apr 22, 2022 at 03:27:47PM +0200, Marek Vasut wrote: > The following changes since commit ea5583b90f9c162af6f2025718dc50ffbb6e4552: > > Merge branch '2022-04-21-further-cleanups' (2022-04-21 19:55:38 -0400) > > are available in the Git repository at: > > git://source.denx.de/u-boot-

[PATCH] patman: Fix defaults not propegating to subparsers

2022-04-22 Thread Sean Anderson
On python 3.8.10, subparsers are not updated with defaults. I suspect this is related to [1]. Fix this by explicitly updating subparsers with settings. [1] https://github.com/python/cpython/issues/89398 Fixes: 3145b63513 ("patman: Update defaults in subparsers") Signed-off-by: Sean Anderson ---

[PATCH 1/3] disk: part_efi: add support to repair gpt table

2022-04-22 Thread Philippe Reynes
If a gpt table is corrupted (after a power cut for example), then the gpt table should repaired. The function gpt_repair_headers check if at least one gpt table is valid, and then only write the corrupted gpt table. Signed-off-by: Philippe Reynes --- disk/part_efi.c | 86

[PATCH 2/3] cmd: gpt: add subcommand repair

2022-04-22 Thread Philippe Reynes
Adds a sub-command repair to the command gpt that allow to repair a corrupted gpt table. If the both gpt table (primary and backup) are valid, then the command does nothing. Signed-off-by: Philippe Reynes --- cmd/gpt.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff

[PATCH 3/3] test: py: tests: test_gpt.py: add a simple test for the command gpt repair

2022-04-22 Thread Philippe Reynes
Adds a simple test for the command gpt repair. Signed-off-by: Philippe Reynes --- test/py/tests/test_gpt.py | 10 ++ 1 file changed, 10 insertions(+) diff --git a/test/py/tests/test_gpt.py b/test/py/tests/test_gpt.py index 229d7eb2c2..f707d9f253 100644 --- a/test/py/tests/test_gpt.py ++

[PATCH 0/3] gpt: add support to repair gpt

2022-04-22 Thread Philippe Reynes
This serie adds a sub-command repair to command gpt to repair a gpt. It only writes the gpt that is corrupted, and not both gpt. So a powercut in the middle of the sub-command repair should not corrupt the last valid gpt. Philippe Reynes (3): disk: part_efi: add support to repair gpt table cmd

[PATCH] MAINTAINERS: Add Alper as a binman maintainer

2022-04-22 Thread Alper Nebi Yasak
I ended up learning most of binman internals while trying to add a few features to it, and I recently started reviewing binman series that would not affect me personally. I'll keep working on it and try to do more reviews. Add myself as a maintainer for binman. Signed-off-by: Alper Nebi Yasak --

Re: Please pull u-boot-watchdog/master

2022-04-22 Thread Tom Rini
On Fri, Apr 22, 2022 at 11:53:14AM +0200, Stefan Roese wrote: > Hi Tom, > > please pull the following watchdog related patches: > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: Pull request: u-boot-imx u-boot-imx-20220422

2022-04-22 Thread Tom Rini
48:59 -0400) > > > > are available in the Git repository at: > > > > https://gitlab.denx.de/u-boot/custodians/u-boot-imx.git > tags/u-boot-imx-20220422 > > > > for you to fetch changes up to d173b107be94eb474e1ae75a8addbf5f2fecfd56: > > > >

Re: [PATCH] clk: stm32mp1: Add missing newline

2022-04-22 Thread Patrice CHOTARD
Hi Marek On 4/22/22 12:40, Marek Vasut wrote: > Add missing newline to this debug message, no functional change. > > Signed-off-by: Marek Vasut > Cc: Patrick Delaunay > Cc: Patrice Chotard > --- > drivers/clk/clk_stm32mp1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --g

Linking archive to hello_world in standalone

2022-04-22 Thread Lists Nick Betteridge
Hi! Apologies for this beginner question! I'm trying to reference an archive from the hello_world example in standalone. The archive contains one object file - mystart_up.c: int printf(const char* fmt, ...); int my_hello_world(int argc, char *const argv[]) {     printf ("Hello World\n");

Re: RFC: Updating i.MX8M CPU thermal trip-point at runtime

2022-04-22 Thread Andrejs Cainikovs
On 14/04/2022 17:04, Tim Harvey wrote: On Thu, Apr 14, 2022 at 3:58 AM Peng Fan (OSS) wrote: On 2022/4/14 16:37, Frieder Schrempf wrote: Hi Andrejs, +Cc: Jacky Bai Am 13.04.22 um 14:24 schrieb Andrejs Cainikovs: [Sie erhalten nicht oft E-Mail von "andrejs.cainik...@toradex.com". Weitere

Re: [PATCH] led: gpio: Use NOP uclass driver for top-level node

2022-04-22 Thread Patrice CHOTARD
Hi Marek On 4/22/22 15:34, Marek Vasut wrote: > The top level DT node of gpio-leds is not a LED itself, bind NOP uclass > driver to it, and bind different LED uclass driver to its subnodes which > represent the actual LEDs. This simplifies the probe() implementation > and fixes the bogus top-level

Re: [PATCH] led: Drop led_default_state()

2022-04-22 Thread Patrice CHOTARD
Hi Marek On 4/22/22 15:41, Marek Vasut wrote: > This function is empty, drop it. > > Signed-off-by: Marek Vasut > Cc: Patrice Chotard > Cc: Patrick Delaunay > Cc: Sean Anderson > Cc: Simon Glass > Cc: Steven Lawrance > --- > board/aristainetos/aristainetos.c | 1 - > board/bosch/

Please pull u-boot-pmic master

2022-04-22 Thread Jaehoon Chung
Dear Tom, Please pull u-boot-pmic master into u-boot master branch. If there is a problem, let me know, plz Best Regards, Jaehoon Chung CI: https://source.denx.de/u-boot/custodians/u-boot-pmic/-/pipelines/11829 The following changes since commit ea5583b90f9c162af6f2025718dc50ffbb6e4552: Merg

Re: [PATCH 10/10] microblaze: cache: use fdt cache size info if available

2022-04-22 Thread Michal Simek
On 4/11/22 18:26, Ovidiu Panait wrote: If CONFIG_CPU_MICROBLAZE is enabled, the cache size and cache line size are retrieved from the fdt by the microblaze cpu driver. Adjust cache flush code to use those values if available. If a cache flush is requested very early in the boot (for example t

Re: [PATCH 09/10] cpu: microblaze: add driver for CPU

2022-04-22 Thread Michal Simek
On 4/11/22 18:26, Ovidiu Panait wrote: Add a basic CPU driver that retrieves information about the microblaze CPU core. At this time, only data related to instruction/data caches is extracted from fdt. Signed-off-by: Ovidiu Panait --- arch/microblaze/include/asm/cache.h | 5 +

Re: [PATCH] led: Configure LED default-state on boot

2022-04-22 Thread Marek Vasut
On 4/22/22 15:46, Patrice CHOTARD wrote: Hi, [...] If so, we need to figure out why. With this patch, the board is booting fine The "led patch" is changing the order of probing of some early drivers (led, clock, gpio, pinctrl) . to be continued ... ;-) Larger change is coming, yo

Re: [PATCH 1/3] dm: core: Add DM_FLAG_PROBE_AFTER_BIND flag

2022-04-22 Thread Marek Vasut
On 4/22/22 15:49, Sean Anderson wrote: On 4/22/22 9:15 AM, Marek Vasut wrote: Introduce DM_FLAG_PROBE_AFTER_BIND flag, which can be set by driver or uclass in .bind(), to indicate such driver instance should be probe()d once binding of all devices is complete. This is useful in case the driver

Re: [PATCH 1/3] dm: core: Add DM_FLAG_PROBE_AFTER_BIND flag

2022-04-22 Thread Sean Anderson
On 4/22/22 9:15 AM, Marek Vasut wrote: Introduce DM_FLAG_PROBE_AFTER_BIND flag, which can be set by driver or uclass in .bind(), to indicate such driver instance should be probe()d once binding of all devices is complete. This is useful in case the driver determines that hardware initialization

Re: [PATCH] led: Configure LED default-state on boot

2022-04-22 Thread Patrice CHOTARD
Hi Marek On 4/22/22 15:14, Marek Vasut wrote: > On 4/22/22 14:35, Patrice CHOTARD wrote: >> Hi Marek >> >> On 4/22/22 13:41, Marek Vasut wrote: >>> On 4/22/22 11:02, Marek Vasut wrote: On 4/22/22 09:09, Patrice CHOTARD wrote: > Hi Sean > > On 4/22/22 02:06, Sean Anderson wrote: >>

Re: [PATCH 3/3] led: gpio: Check device compatible string to determine the top level node

2022-04-22 Thread Patrice CHOTARD
Hi Marek On 4/22/22 15:15, Marek Vasut wrote: > Since 2d1deaf88ed ("led: gpio: Drop duplicate OF "label" property parsing"), > all LED nodes have some sort of label. Use > device_is_compatible(..."leds-gpio") > to determine whether this is a top-level node, since it is only the top > level node w

Re: [PATCH 2/3] led: Mark device instance with DM_FLAG_PROBE_AFTER_BIND

2022-04-22 Thread Patrice CHOTARD
Hi Marek On 4/22/22 15:15, Marek Vasut wrote: > Calling device_probe() from uclass .post_bind() callback has all kinds > of odd side-effects, e.g. device instances not being available just yet. > Make use of the DM_FLAG_PROBE_AFTER_BIND instead, mark device instances > which need to be probe()d in

Re: [PATCH 1/3] dm: core: Add DM_FLAG_PROBE_AFTER_BIND flag

2022-04-22 Thread Patrice CHOTARD
Hi Marek On 4/22/22 15:15, Marek Vasut wrote: > Introduce DM_FLAG_PROBE_AFTER_BIND flag, which can be set by driver or > uclass in .bind(), to indicate such driver instance should be probe()d > once binding of all devices is complete. > > This is useful in case the driver determines that hardware

[PATCH] led: Drop led_default_state()

2022-04-22 Thread Marek Vasut
This function is empty, drop it. Signed-off-by: Marek Vasut Cc: Patrice Chotard Cc: Patrick Delaunay Cc: Sean Anderson Cc: Simon Glass Cc: Steven Lawrance --- board/aristainetos/aristainetos.c | 1 - board/bosch/guardian/board.c| 3 --- board/dhelectronics/dh_stm32

[PATCH] led: gpio: Use NOP uclass driver for top-level node

2022-04-22 Thread Marek Vasut
The top level DT node of gpio-leds is not a LED itself, bind NOP uclass driver to it, and bind different LED uclass driver to its subnodes which represent the actual LEDs. This simplifies the probe() implementation and fixes the bogus top-level not-an-LED in 'led list' command output: ``` => led l

[PATCH] cpu: 83xx: Add missing dependency on CPU_MPC83XX

2022-04-22 Thread Michal Simek
It looks quite weird that for non PPC platforms cpu driver for MPC83xx can be selected. That's why define proper dependency. Signed-off-by: Michal Simek --- drivers/cpu/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpu/Kconfig b/drivers/cpu/Kconfig index 3d

[PULL] u-boot-usb/master

2022-04-22 Thread Marek Vasut
The following changes since commit ea5583b90f9c162af6f2025718dc50ffbb6e4552: Merge branch '2022-04-21-further-cleanups' (2022-04-21 19:55:38 -0400) are available in the Git repository at: git://source.denx.de/u-boot-usb.git master for you to fetch changes up to 6674d2d9fe563258fdc89b25eb46

Re: [PATCH v2 1/6] clk: meson: add minimal driver for axg-ao clocks

2022-04-22 Thread Neil Armstrong
On 22/04/2022 07:29, Vyacheslav Bocharov wrote: Add minimal driver AO clocks on meson AXG family. Only ADC related clocks are supported. Signed-off-by: Vyacheslav Bocharov --- drivers/clk/meson/Makefile | 1 + drivers/clk/meson/axg-ao.c | 89 ++ 2 files

Re: [PATCH v2 6/6] board: amlogic: jethub j100: enable saradc in config

2022-04-22 Thread Neil Armstrong
On 22/04/2022 07:29, Vyacheslav Bocharov wrote: Enable ADC in board config file Signed-off-by: Vyacheslav Bocharov --- configs/jethub_j100_defconfig | 5 + 1 file changed, 5 insertions(+) diff --git a/configs/jethub_j100_defconfig b/configs/jethub_j100_defconfig index 1c6db9f6a0..a30940

Re: [PATCH v2 5/6] board: amlogic: jethub j100: enable saradc in dts

2022-04-22 Thread Neil Armstrong
On 22/04/2022 07:29, Vyacheslav Bocharov wrote: Prepare to use ADC channel 1 to check the hardware revision of the board. Signed-off-by: Vyacheslav Bocharov --- arch/arm/dts/meson-axg-jethome-jethub-j100.dts | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/dts/meson-axg-jeth

Re: [PATCH v2 4/6] adc: meson-saradc: add AXG variant

2022-04-22 Thread Neil Armstrong
On 22/04/2022 07:29, Vyacheslav Bocharov wrote: Add support for the SARADC variant found on the AXG SoCs family. Signed-off-by: Vyacheslav Bocharov --- drivers/adc/meson-saradc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/adc/meson-saradc.c b/drivers/adc/meson-saradc.c ind

Re: [PATCH v2 3/6] clk: meson: update driver for g12a-ao clocks

2022-04-22 Thread Neil Armstrong
On 22/04/2022 07:29, Vyacheslav Bocharov wrote: Move clk->id check to .request function Signed-off-by: Vyacheslav Bocharov --- drivers/clk/meson/g12a-ao.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/clk/meson/g12a-ao.c b/drivers/clk/meson/g12a-ao.

Re: [PATCH v2 2/6] clk: meson: fix driver name for g12a-ao clocks

2022-04-22 Thread Neil Armstrong
On 22/04/2022 07:29, Vyacheslav Bocharov wrote: Update the clk-g12a-ao driver from "axg" to "g12a" Signed-off-by: Vyacheslav Bocharov --- drivers/clk/meson/g12a-ao.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/meson/g12a-ao.c b/drivers/clk/meson/g12a-ao.c

Re: [PATCH 07/10] microblaze: cache: introduce flush_cache_all()

2022-04-22 Thread Michal Simek
On 4/11/22 18:26, Ovidiu Panait wrote: All flush_cache() calls in microblaze code are supposed to flush the entire instruction and data caches, so introduce flush_cache_all() helper to handle this. Also, provide implementations for flush_dcache_all() and invalidate_icache_all() so that icache

[PATCH 3/3] led: gpio: Check device compatible string to determine the top level node

2022-04-22 Thread Marek Vasut
Since 2d1deaf88ed ("led: gpio: Drop duplicate OF "label" property parsing"), all LED nodes have some sort of label. Use device_is_compatible(..."leds-gpio") to determine whether this is a top-level node, since it is only the top level node which is compatible with "leds-gpio", the GPIO LEDs subnode

[PATCH 2/3] led: Mark device instance with DM_FLAG_PROBE_AFTER_BIND

2022-04-22 Thread Marek Vasut
Calling device_probe() from uclass .post_bind() callback has all kinds of odd side-effects, e.g. device instances not being available just yet. Make use of the DM_FLAG_PROBE_AFTER_BIND instead, mark device instances which need to be probe()d in order to configure the LED default state with this fla

[PATCH 1/3] dm: core: Add DM_FLAG_PROBE_AFTER_BIND flag

2022-04-22 Thread Marek Vasut
Introduce DM_FLAG_PROBE_AFTER_BIND flag, which can be set by driver or uclass in .bind(), to indicate such driver instance should be probe()d once binding of all devices is complete. This is useful in case the driver determines that hardware initialization is mandatory on boot, and such initializa

Re: [PATCH] led: Configure LED default-state on boot

2022-04-22 Thread Marek Vasut
On 4/22/22 14:35, Patrice CHOTARD wrote: Hi Marek On 4/22/22 13:41, Marek Vasut wrote: On 4/22/22 11:02, Marek Vasut wrote: On 4/22/22 09:09, Patrice CHOTARD wrote: Hi Sean On 4/22/22 02:06, Sean Anderson wrote: On 4/21/22 11:26 AM, Patrice CHOTARD wrote: On 4/21/22 17:18, Marek Vasut wr

Re: [PATCH 08/10] microblaze: cache: introduce flush_dcache_range()

2022-04-22 Thread Michal Simek
On 4/11/22 18:26, Ovidiu Panait wrote: Align microblaze with the other architectures and provide an implementation for flush_dcache_range(). Also, remove the microblaze exception in drivers/core/device.c. Signed-off-by: Ovidiu Panait --- arch/microblaze/cpu/cache.c | 8 drivers/

Re: [PATCH] mmc: fsl_esdhc_spl: pre-PBL: implement redundancy support

2022-04-22 Thread Jaehoon Chung
On 4/22/22 21:39, Pali Rohár wrote: > On Friday 22 April 2022 21:32:54 Jaehoon Chung wrote: >> On 4/5/22 01:33, Pali Rohár wrote: >>> QorIQ pre-PBL BootROM scans first 24 SD card sectors (each with fixed 512 >>> bytes length) for boot signature. Implement same redundancy behavior in >>> fsl_esdhc

Re: [PATCH 06/10] microblaze: cache: migrate XILINX_DCACHE_BYTE_SIZE to Kconfig

2022-04-22 Thread Michal Simek
On 4/11/22 18:26, Ovidiu Panait wrote: Migrate XILINX_DCACHE_BYTE_SIZE to Kconfig and rename it to XILINX_MICROBLAZE0_DEFAULT_CACHE_SIZE. Use it as the default size for both instruction/data caches and get rid of the hardcoded value in icache_disable(). Microblaze can have different icache a

Re: [PATCH 05/10] microblaze: cache: split flush_cache() function

2022-04-22 Thread Michal Simek
On 4/11/22 18:26, Ovidiu Panait wrote: Factor out icache/dcache components from flush_cache() function. Call the newly added __flush_icache()/__flush_dcache() functions inside icache_disable() and dcache_disable(), respectively. There is no need to flush both caches when disabling a particular

Re: [PATCH 04/10] microblaze: cache: improve icache Kconfig options

2022-04-22 Thread Michal Simek
On 4/11/22 18:26, Ovidiu Panait wrote: Replace CONFIG_ICACHE with a Kconfig option more limited in scope - XILINX_MICROBLAZE0_USE_WIC. It should be enabled if the processor supports the "wic" (Write to Instruction Cache) instruction. It will be used to guard "wic" invocations in microblaze cac

Re: [PATCH 03/10] microblaze: cache: improve dcache Kconfig options

2022-04-22 Thread Michal Simek
On 4/11/22 18:26, Ovidiu Panait wrote: Replace CONFIG_DCACHE with a Kconfig option more limited in scope - XILINX_MICROBLAZE0_USE_WDC. It should be enabled if the processor supports the "wdc" (Write to Data Cache) instruction. It will be used to guard "wdc" invocations in microblaze cache code

Re: [PATCH] mmc: fsl_esdhc_spl: pre-PBL: implement redundancy support

2022-04-22 Thread Pali Rohár
On Friday 22 April 2022 21:32:54 Jaehoon Chung wrote: > On 4/5/22 01:33, Pali Rohár wrote: > > QorIQ pre-PBL BootROM scans first 24 SD card sectors (each with fixed 512 > > bytes length) for boot signature. Implement same redundancy behavior in > > fsl_esdhc_spl driver to allow loading proper U-Boo

Re: [PATCH] led: Configure LED default-state on boot

2022-04-22 Thread Patrice CHOTARD
Hi Marek On 4/22/22 13:41, Marek Vasut wrote: > On 4/22/22 11:02, Marek Vasut wrote: >> On 4/22/22 09:09, Patrice CHOTARD wrote: >>> Hi Sean >>> >>> On 4/22/22 02:06, Sean Anderson wrote: On 4/21/22 11:26 AM, Patrice CHOTARD wrote: > > > On 4/21/22 17:18, Marek Vasut wrote: >>

Re: [PATCH] mmc: fsl_esdhc_spl: pre-PBL: implement redundancy support

2022-04-22 Thread Jaehoon Chung
On 4/5/22 01:33, Pali Rohár wrote: > QorIQ pre-PBL BootROM scans first 24 SD card sectors (each with fixed 512 > bytes length) for boot signature. Implement same redundancy behavior in > fsl_esdhc_spl driver to allow loading proper U-Boot when boot sector is not > the first one. > > Signed-off-

Re: [PATCH u-boot-marvell 2/8] arm: mvebu: turris_omnia: Provide env_sf_get_env_addr() function

2022-04-22 Thread Marek Behún
On Fri, 22 Apr 2022 13:49:43 +0200 Pali Rohár wrote: > On Wednesday 02 March 2022 13:37:25 Marek Behún wrote: > > On Wed, 2 Mar 2022 12:47:52 +0100 > > Pali Rohár wrote: > > > > > BootROM maps SPI Flash to fixed address 0xD400 and this mapping is > > > active also when BootROM is executi

Re: [PATCH u-boot-marvell 8/8] arm: mvebu: turris_omnia: Add support for USB3.0 mode in WWAN MiniPCIe slot

2022-04-22 Thread Marek Behún
On Fri, 22 Apr 2022 13:47:33 +0200 Pali Rohár wrote: > On Wednesday 02 March 2022 13:46:07 Marek Behún wrote: > > On Wed, 2 Mar 2022 12:47:58 +0100 > > Pali Rohár wrote: > > > > > PCIe Mini CEM 2.1 spec added support for USB3.0 mode on MiniPCIe cards. > > > USB3.0 and PCIe share same pins an

Re: [PATCH] cmd: part: add explicit dependency on PARTITIONS

2022-04-22 Thread Tom Rini
On Fri, Apr 22, 2022 at 10:44:30AM +0900, AKASHI Takahiro wrote: > This is a follow-up patch for my "disk: don't compile in partition > support for spl/tpl if not really necessary". > > "part" command is useful only if, at least, one of partition table types > is selected. So it should have a dep

Re: [PATCH] nds32: Remove the architecture

2022-04-22 Thread Tom Rini
On Fri, Apr 22, 2022 at 04:45:28PM +0800, Rick Chen wrote: > Hi, Tom, > > > From: Tom Rini > > Sent: Wednesday, April 20, 2022 2:43 AM > > To: u-boot@lists.denx.de; Rick Jian-Zhi Chen(陳建志) > > Subject: Re: [PATCH] nds32: Remove the architecture > > > > On Wed, Apr 06, 2022 at 09:21:25AM -0400, T

Re: [PATCH 3/3] mmc: fsl_esdhc_spl: Call mmc_init() before booting from SD card

2022-04-22 Thread Jaehoon Chung
On 4/3/22 07:17, Pali Rohár wrote: > If env is stored on SD card then U-Boot SPL automatically calls mmc_init() > before it is going to load proper U-Boot from SD card. > > If env is not stored on SD card then U-Boot SPL fails to read proper U-Boot > from SD card due to missing mmc_init() call.

Re: [PATCH 2/3] mmc: fsl_esdhc_spl: pre-PBL: fix determining U-Boot size

2022-04-22 Thread Jaehoon Chung
On 4/3/22 07:17, Pali Rohár wrote: > In pre-PBL header is stored size of code which BootROM copies from SD card > to L2/SRAM. This size has upper limit of L2 cache size. In most cases this > is size of U-Boot SPL or size of L2 cache. > > Therefore this size in pre-PBL header cannot be used for

Re: [PATCH 1/3] mmc: fsl_esdhc_spl: pre-PBL: check for BOOT signature instead of MBR/DBR

2022-04-22 Thread Jaehoon Chung
On 4/3/22 07:16, Pali Rohár wrote: > Pre-PBL BootROMs (MPC8536E, MPC8569E, P2020, P1011, P1012, P1013, P1020, > P1021, P1022) require custom BOOT signature on sector 0 and MBR/DBR > signature is not required at all. > > So add check for BOOT signature and remove check for MBR/DBR. > > This all

Re: [PATCH 06/25] s5p_goni, smdkc100: Move some environment settings out of CONFIG

2022-04-22 Thread Jaehoon Chung
On 3/31/22 07:07, Tom Rini wrote: > A number of CONFIG options are used on these platforms as part of the > default environment. Set some of these more directly and in other > cases, just reference them directly. > > Cc: Jaehoon Chung > Cc: Minkyu Kang > Signed-off-by: Tom Rini Reviewed-by

  1   2   >