hi Simon,
On Sun, 6 Mar 2022 at 08:37, Simon Glass wrote:
>
> Hi Sughosh,
>
> On Fri, 4 Mar 2022 at 06:44, Sughosh Ganu wrote:
> >
> > hi Simon,
> >
> > On Fri, 4 Mar 2022 at 08:07, Simon Glass wrote:
> > >
> > > Hi Sughosh,
> > >
> > > On Thu, 3 Mar 2022 at 05:11, Sughosh Ganu wrote:
> > > >
This is not used anymore. Drop it.
Signed-off-by: Simon Glass
---
(no changes since v2)
Changes in v2:
- Drop patches previously applied
- Add various suggestions from Alper Nebi Yasak
- Add patches to refactor binman's FIT support
Makefile | 3 -
arch/arm/mach
Some boards need to load an ELF file using the 'loadables' property, but
the file has segments at different memory addresses. This means that it
cannot be supplied as a flat binary.
Allow generating a separate node in the FIT for each segment in the ELF,
with a different load address for each.
Al
Add the required binman images to replace the Makefile rules which are
currently used. This includes subsuming:
- tpl/u-boot-tpl-rockchip.bin if TPL is enabled
- idbloader.img if either or both of SPL and TPL are enabled
- u-boot.itb if SPL_FIT is enabled
- u-boot-rockchip.bin if SPL i
Instead of the bash script, use binman to generate the FIT for arm64.
For 32-bit boards, use binman for all images, dropping the intermediate
files.
With this change, only Zynq is now using SPL_FIT_GENERATOR so update the
Kconfig rule accordingly.
Clean up the Makefile to the extent possible. Un
Include the rockchip-u-boot.dtsi file with 64-bit boards and enable binman
so that these boards can also use it, rather than using special Makefile
rules and scripts.
This does not change the Makefile nor remove any scripts, but sets it up
so that this is possible.
Signed-off-by: Simon Glass
Rev
This boards uses SPL_FIT so does not need to support loading a raw image.
Drop it to avoid binman trying to insert a symbol which has no value.
Signed-off-by: Simon Glass
---
(no changes since v1)
configs/evb-rk3288_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/evb-rk32
The current implementation sets up the FIT entries but then deletes the
'generator' ones so they don't appear in the final image.
This is a bit clumsy. We cannot build the image more than once, since the
generator entries are lost during the first build. Binman requires that
calling BuildSectionDa
Add a new function to handling reporting errors within a particular
subnode of the FIT description. This can be used to make the format of
these errors consistent.
Signed-off-by: Simon Glass
Reviewed-by: Alper Nebi Yasak
---
Changes in v3:
- Drop the base_node argument and use self._node instea
It doesn't make sense to use 'subnode' as a function parameter since it
is just a 'node' so far as the function is concerned. Update two functions
to use 'node' instead.
Signed-off-by: Simon Glass
Reviewed-by: Alper Nebi Yasak
---
(no changes since v1)
tools/binman/etype/fit.py | 16 -
Some warnings have crept in, so fix those that are easy to fix.
Signed-off-by: Simon Glass
Reviewed-by: Alper Nebi Yasak
---
(no changes since v1)
tools/binman/etype/fit.py | 50 +++
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/tools/binm
This should not be done in the constructor. Move it.
Signed-off-by: Simon Glass
Suggested-by: Alper Nebi Yasak
---
(no changes since v1)
tools/binman/etype/fit.py | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/tools/binman/etype/fit.py b/tools/binman/etype/fit.
Unfortunately mkimage gets upset with zero-sized files. Update the
ObtainContents() method to support specifying the size, if a fake blob is
created.
Signed-off-by: Simon Glass
Reviewed-by: Alper Nebi Yasak
---
(no changes since v2)
Changes in v2:
- Add a patch to allow mkimage to use a non-ze
At present the entries are read twice, once by the entry_Section class
and once by the FIT implementation. This is harmless but can be confusing
when debugging. Fix it.
Signed-off-by: Simon Glass
Reviewed-by: Alper Nebi Yasak
---
(no changes since v1)
tools/binman/etype/fit.py | 1 -
1 file c
On x86 devices having even a small amount of data can cause an overlap
between regions. For example, bayleybay complains when the intel-vga
region overlaps with u-boot-ucode:
ImagePosOffset Size Name
0080 main-section
ff80 0080 intel-descriptor
At present fake blobs are created but internally an empty blob is used.
Change it to use the contents of the faked file. Also return whether the
blob was faked, in case the caller needs to know that.
Add a TODO to put fake blobs in their own directory.
Signed-off-by: Simon Glass
Reviewed-by: Alp
At present the fit implementation creates the output tree while
scanning the FIT description. Then it updates the tree later when the
data is known.
This works, but is a bit confusing, since it requires mixing the scanning
code with the generation code, with a fix-up step at the end.
It is actual
This shadows the patman.tools library so rename it to avoid a pylint
warning.
Signed-off-by: Simon Glass
Reviewed-by: Alper Nebi Yasak
---
(no changes since v1)
tools/binman/entry.py| 4 ++--
tools/binman/etype/fit.py| 6 +++---
tools/binman/etype/gbb.py| 4 ++--
t
The word 'expand' is used for entries which generate subentries. It is
also used for entries that can have an '_expanded' version which is used
to break out its contents.
Rather than talking about expanding an entry's size, use the term
'extending'. It is slightly more precise and avoids the above
Leave the 'expand' term for use by entry types which have an expanded
version of themselves. Rename this method to indicate that it generates
subentries.
Signed-off-by: Simon Glass
Reviewed-by: Alper Nebi Yasak
---
(no changes since v2)
Changes in v2:
- Add patch to rename ExpandEntries to gen
Rename this function to make it clear that it only reads loadable
segments. Also update the error for missing module to better match the
message emitted by Python.
Signed-off-by: Simon Glass
Reviewed-by: Alper Nebi Yasak
Suggested-by: Alper Nebi Yasak
---
(no changes since v2)
Changes in v2:
Fix the help which should refer to TPL, not SPL.
Signed-off-by: Simon Glass
Reviewed-by: Alper Nebi Yasak
Suggested-by: Alper Nebi Yasak
---
(no changes since v2)
Changes in v2:
- Add new patch to correct Kconfig help for TPL_BINMAN_SYMBOLS
common/spl/Kconfig | 6 +++---
1 file changed, 3 i
Refactor this to avoid a loop. Also add a test for an empty string.
Signed-off-by: Simon Glass
Suggested-by: Alper Nebi Yasak
Reviewed-by: Alper Nebi Yasak
---
Changes in v3:
- Add tests for an empty string/stringlist too
Changes in v2:
- Add new patch to tidy up implementation of AddStringLi
Update the return value of this function, fix the 'create' typo and
update the documentation for clarity.
Signed-off-by: Simon Glass
Reviewed-by: Alper Nebi Yasak
Suggested-by: Alper Nebi Yasak
---
(no changes since v2)
Changes in v2:
- Add new patch to tweak collect_contents_to_file() and do
Simplify the code by using the available function.
Signed-off-by: Simon Glass
Reviewed-by: Alper Nebi Yasak
---
Changes in v3:
- Drop unnecessary variable
Changes in v2:
- Add new patch to use re.fullmatch() to avoid extra check
tools/moveconfig.py | 3 +--
1 file changed, 1 insertion(+), 2
This is not necessary if simpler code is used. Use the split function and
drop the unnecessary []
Signed-off-by: Simon Glass
Reviewed-by: Alper Nebi Yasak
Suggested-by: Alper Nebi Yasak
---
(no changes since v2)
Changes in v2:
- Add new patch to remove remove_defconfig()
tools/moveconfig.py
At present it is not possible to have arguments which include spaces.
Update the function to only split the args if the property is a single
string. This is a bit inconsistent, but might still be useful.
Signed-off-by: Simon Glass
Reviewed-by: Alper Nebi Yasak
Suggested-by: Alper Nebi Yasak
---
At present rockchip 64-bit boards make use of a FIT-generator script
written in Python. The script supports splitting an ELF file into several
'loadable' nodes in the FIT. Binman does not current support this feature.
This series adds binman support for ELF splitting. This works by adding a
new 'f
Hi Heinrich,
On Wed, 19 Jan 2022 at 04:45, Heinrich Schuchardt wrote:
>
> On 1/19/22 02:43, Simon Glass wrote:
> > Add a bootmeth driver which handles EFI boot, using EFI_LOADER.
> >
> > In effect, this provides the same functionality as the 'bootefi' command
> > and shares the same code. But the
Hi Alper,
On Thu, 3 Mar 2022 at 14:16, Alper Nebi Yasak wrote:
>
> On 24/02/2022 02:00, Simon Glass wrote:
> > At present the entries are read twice, once by the entry_Section class
> > and once by the FIT implementation. This is harmless but can be confusing
> > when debugging. Fix it.
> >
> > S
Hi Alper,
On Thu, 3 Mar 2022 at 14:16, Alper Nebi Yasak wrote:
>
> On 24/02/2022 02:00, Simon Glass wrote:
> > At present fake blobs are created but internally an empty blob is used.
> > Change it to use the contents of the faked file. Also return whether the
> > blob was faked, in case the calle
Hi Alper,
On Thu, 3 Mar 2022 at 14:16, Alper Nebi Yasak wrote:
>
> On 24/02/2022 02:00, Simon Glass wrote:
> > Unfortunately mkimage gets upset with zero-sized files. Update the
> > ObtainContents() method to support specifying the size, if a fake blob is
> > created.
> >
> > Signed-off-by: Simon
Hi Peter, Alper,
On Thu, 3 Mar 2022 at 15:34, Peter Geis wrote:
>
> On Thu, Mar 3, 2022 at 4:17 PM Alper Nebi Yasak
> wrote:
> >
> > On 03/03/2022 01:16, Peter Geis wrote:
> > > On Wed, Feb 23, 2022 at 6:04 PM Simon Glass wrote:
> > >> diff --git a/arch/arm/dts/rockchip-u-boot.dtsi
> > >> b/ar
Hi Michael,
On Thu, 20 Jan 2022 at 11:16, Simon Glass wrote:
>
> Hi Michael,
>
> On Thu, 20 Jan 2022 at 01:38, Michael Walle wrote:
> >
> > Hi,
> >
> > Am 2022-01-19 15:56, schrieb Simon Glass:
> > > On Wed, 19 Jan 2022 at 01:09, Michael Walle wrote:
> > >>
> > >>
> > >> > The bootflow feature
Hi Heinrich,
On Wed, 19 Jan 2022 at 04:47, Heinrich Schuchardt wrote:
>
> On 1/19/22 02:43, Simon Glass wrote:
> > Add a bootmeth driver which handles EFI boot manager, using EFI_LOADER.
> >
> > In effect, this provides the same functionality as the 'bootefi bootmgr'
> > command and shares the sa
Hi Heinrich,
On Wed, 19 Jan 2022 at 04:21, Heinrich Schuchardt wrote:
>
> On 1/19/22 02:42, Simon Glass wrote:
> > A few string tests were added to the print module by mistake. Move them.
> >
> > Signed-off-by: Simon Glass
> > ---
> >
> > (no changes since v1)
> >
> > test/print_ut.c | 40
Hi Takahiro,
On Wed, 19 Jan 2022 at 20:16, AKASHI Takahiro
wrote:
>
> On Wed, Jan 19, 2022 at 12:27:09PM +0100, Heinrich Schuchardt wrote:
> > On 1/19/22 02:42, Simon Glass wrote:
> > > At present it is not possible to find out which part of the string is the
> > > number part and which is before
Hi Peter,
On Fri, 4 Mar 2022 at 12:56, Peter Geis wrote:
>
> mkimage has the ability to process two files at the same time.
> This is necessary for rk356x support as both TPL and SPL need to be
> hashed individually in the resulting header.
> It also eases support for rkspi as mkimage handles eve
Hi Alper,
On Thu, 3 Mar 2022 at 14:17, Alper Nebi Yasak wrote:
>
> On 24/02/2022 02:00, Simon Glass wrote:
> > Some boards need to load an ELF file using the 'loadables' property, but
> > the file has segments at different memory addresses. This means that it
> > cannot be supplied as a flat bina
Hi Alper,
On Thu, 3 Mar 2022 at 14:17, Alper Nebi Yasak wrote:
>
> On 24/02/2022 02:00, Simon Glass wrote:
> > The current implementation sets up the FIT entries but then deletes the
> > 'generator' ones so they don't appear in the final image.
>
> They still show up in the fdtmap if I add one to
Hi Alper,
On Thu, 3 Mar 2022 at 14:16, Alper Nebi Yasak wrote:
>
> On 24/02/2022 02:00, Simon Glass wrote:
> > Add a new function to handling reporting errors within a particular
> > subnode of the FIT description. This can be used to make the format of
> > these errors consistent.
> >
> > Signed
Hi Alper,
On Thu, 3 Mar 2022 at 14:16, Alper Nebi Yasak wrote:
>
> On 24/02/2022 02:00, Simon Glass wrote:
> > On x86 devices having even a small amount of data can cause an overlap
> > between regions. For example, bayleybay complains when the intel-vga
> > region overlaps with u-boot-ucode:
> >
Hi Alper,
On Thu, 3 Mar 2022 at 14:16, Alper Nebi Yasak wrote:
>
> On 24/02/2022 02:00, Simon Glass wrote:
> > At present the fit implementation creates the output tree while
> > scanning the FIT description. Then it updates the tree later when the
> > data is known.
> >
> > This works, but is a
Hi Alper,
On Thu, 3 Mar 2022 at 14:14, Alper Nebi Yasak wrote:
>
> On 24/02/2022 01:59, Simon Glass wrote:
> > On Tue, 15 Feb 2022 at 04:53, Alper Nebi Yasak
> > wrote:
> >> On 08/02/2022 21:50, Simon Glass wrote:
> >>> +fit,load
> >>> +Generates a `load = <...>` property with the l
Hi Alper,
On Thu, 3 Mar 2022 at 14:14, Alper Nebi Yasak wrote:
>
> On 24/02/2022 01:58, Simon Glass wrote:
> > On Tue, 15 Feb 2022 at 04:53, Alper Nebi Yasak
> > wrote:
> >> On 08/02/2022 21:49, Simon Glass wrote:
> >>> diff --git a/tools/dtoc/fdt.py b/tools/dtoc/fdt.py
> >>> index 32a7aa9829..
Hi Alper,
On Thu, 3 Mar 2022 at 14:14, Alper Nebi Yasak wrote:
>
> On 24/02/2022 01:58, Simon Glass wrote:
> > Hi Alper,
> >
> > On Tue, 15 Feb 2022 at 04:52, Alper Nebi Yasak
> > wrote:
> >>
> >> On 08/02/2022 21:49, Simon Glass wrote:
> >>> These symbols are incorrect, meaning that binman can
On Mon, 21 Feb 2022 at 14:17, Mark Kettenis wrote:
>
> The stdout-path property in the device tree does not necessarily
> point at a serial device. On machines such as the Apple M1 laptops
> where the serial port isn't easy to access and users expect to see
> console output on the integrated displ
Hi Sughosh,
On Fri, 4 Mar 2022 at 06:44, Sughosh Ganu wrote:
>
> hi Simon,
>
> On Fri, 4 Mar 2022 at 08:07, Simon Glass wrote:
> >
> > Hi Sughosh,
> >
> > On Thu, 3 Mar 2022 at 05:11, Sughosh Ganu wrote:
> > >
> > > hi Simon,
> > >
> > > On Thu, 3 Mar 2022 at 09:18, Simon Glass wrote:
> > > >
Hi Tom,
please pull the master branch from u-boot-sunxi, containing some fixes
for 2022.04, for the newly merged F1C100 SoC:
-
- Fix ARMv5/F1C100 FEL booting
- Fix F1C100 reset
- Introduce proper F1C100 boot method detection
- Enable SPI booting for F1C100
-
On Sat, 5 Mar 2022 00:06:01 +0800
Icenowy Zheng wrote:
Hi Icenowy,
> Currently CONFIG_UART0_PORT_F will forbid the build of sunxi-mmc driver,
> which leads calls to it in board/sunxi/board.c a undefined reference.
>
> Guard that code in #ifndef to fix build.
That's indeed a problem.
> Signed
So I've updated to the latest tool and that's why there's so many new
defects found in old code.
- Forwarded message from scan-ad...@coverity.com -
Date: Sat, 05 Mar 2022 17:28:09 + (UTC)
From: scan-ad...@coverity.com
To: tom.r...@gmail.com
Subject: New Defects reported by Coverity Sc
On Tue, Mar 01, 2022 at 04:12:34PM +0100, Yann Droneaud wrote:
> Since OpenSSL 1.1.0, EVP_MD_CTX_create() is EVP_MD_CTX_new()
> EVP_MD_CTX_destroy() is EVP_MD_CTX_free()
> EVP_MD_CTX_init() is EVP_MD_CTX_reset()
>
> As there's no need to reset a newly cre
On Tue, Mar 01, 2022 at 12:43:32PM +0100, Michal Simek wrote:
> Based on looking at top contributors it was seen that top statistics from
> top contributors don't include all contributions from different email
> addresses. That's why I checked all top contributors are checked it.
>
> git shortlog
On Tue, Mar 01, 2022 at 08:53:56AM +0100, Heinrich Schuchardt wrote:
> If parameter -F is given but FIT support is missing, a NULL pointer might
> dereferenced (Coverity CID 350249).
>
> If incorrect parameters are given, provide a message and show usage.
>
> Signed-off-by: Heinrich Schuchardt
On Fri, Feb 25, 2022 at 02:48:54PM +0100, Sébastien Szymanski wrote:
> Fixed misspelled 'disable' in help text.
>
> Signed-off-by: Sébastien Szymanski
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
On Wed, Feb 16, 2022 at 09:06:49AM +0100, Jan Kiszka wrote:
> From: Jan Kiszka
>
> Recent unrelated fixes (9876ae7db6da) revealed that we were missing bits
> from 2af181b53e28 in the IOT2050 dt. Add them, but only for main U-Boot.
> SPL loads from QSPI only, thus cannot use DMA.
>
> Signed-off-
On Wed, Feb 16, 2022 at 11:27:24AM +0530, Aswath Govindraju wrote:
> Enable config for setting mmc speed mode from U-Boot command line.
>
> Signed-off-by: Aswath Govindraju
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
On Tue, Feb 15, 2022 at 07:47:55AM +0100, Christian Gmeiner wrote:
> We only want to call do_board_detect() if CONFIG_TI_I2C_BOARD_DETECT
> is set. Same as done for am64.
>
> This makes it possible to add a custom am65 based board design to
> U-Boot that does not use this board detection mechanis
On Thu, Feb 10, 2022 at 11:13:36PM +0100, Romain Naour wrote:
> Currently, any u-boot bootloader for ti armv7 platforms using
> DEFAULT_FIT_TI_ARGS to boot with a fitimage (boot_fit = 1)
> doesn't boot when built with Yocto Poky (openembedded-core).
>
> ## Loading kernel from FIT Image at 9
On Sat, Mar 05, 2022 at 09:06:36PM +0800, Huang Jianan wrote:
>
>
> 在 2022/3/4 3:15, Tom Rini 写道:
> > On Thu, Mar 03, 2022 at 10:51:18PM +0800, Huang Jianan wrote:
> >
> > > Hi Tom,
> > >
> > > Would you mind taking some time to check if this version meets
> > > the requirements ？So we could ha
get_osc_clk_speed and get_sys_clkin_sel are only used in
one file. Make them static.
Tested on OMAP3530, DM3730, AM3517.
Signed-off-by: Adam Ford
diff --git a/arch/arm/mach-omap2/omap3/clock.c
b/arch/arm/mach-omap2/omap3/clock.c
index 71f73492c6..13685e0567 100644
--- a/arch/arm/mach-omap2/om
在 2022/3/4 3:15, Tom Rini 写道:
On Thu, Mar 03, 2022 at 10:51:18PM +0800, Huang Jianan wrote:
Hi Tom,
Would you mind taking some time to check if this version meets
the requirements ？So we could have a chance to be merged
into the next version ?
I have triggered a CI via Github PR based on t
On 3/5/22 02:03, AKASHI Takahiro wrote:
Heinrich,
On Sat, Mar 05, 2022 at 12:51:00AM +0100, Heinrich Schuchardt wrote:
The block IO protocol may be installed on any handle. We should make
no assumption about the structure the handle points to.
efi_disk_is_system_part() makes an illegal wide
63 matches
Mail list logo
