RE: [PATCH] test/py: tpm2: Skip tpm pytest based on env variable

2021-08-02 Thread T Karthik Reddy
Hi, Any update on this patch? Thanks T Karthik > -Original Message- > From: Ashok Reddy Soma > Sent: Friday, July 23, 2021 5:48 PM > To: u-boot@lists.denx.de > Cc: miquel.ray...@bootlin.com; git ; T Karthik Reddy > ; Ashok Reddy Soma > Subject: [PATCH] test/py: tpm2: Skip tpm py

Re: [PATCH v3 07/10] watchdog: wdt-uclass.c: handle all DM watchdogs in watchdog_reset()

2021-08-02 Thread Rasmus Villemoes
On 02/08/2021 21.20, Simon Glass wrote: > Hi Rasmus, > >> But let me one last time repeat why I think the post_probe approach is >> the cleanest and a natural fit for DM: post_probe is (AIUI) a place >> where a uclass can do some action it wants done for every device >> belonging to that uclass. W

Re: [PATCH v4 02/10] watchdog: wdt-uclass.c: introduce struct wdt_priv

2021-08-02 Thread Stefan Roese
On 02.08.21 17:00, Rasmus Villemoes wrote: As preparation for having the wdt-uclass provided watchdog_reset() function handle all DM watchdog devices, and not just the first such, introduce a uclass-owned struct to hold the reset_period and next_reset, so these become per-device instead of being

Re: [PATCH v4 07/10] watchdog: wdt-uclass.c: handle all DM watchdogs in watchdog_reset()

2021-08-02 Thread Stefan Roese
On 02.08.21 17:00, Rasmus Villemoes wrote: A board can have and make use of more than one watchdog device, say one built into the SOC and an external gpio-petted one. Having wdt-uclass only handle the first is both a little arbitrary and unexpected. So change initr_watchdog() so we visit (probe)

Re: [PATCH v2 2/2] mtd: spi-nor: Mask out fast read if not requested in DT

2021-08-02 Thread Jagan Teki
On Fri, Jul 30, 2021 at 12:50 PM Bin Meng wrote: > > The DT bindings of "jedec,spi-nor" [1] defines "m25p,fast-read" property > to indicate that "fast read" opcode can be used to read data from the > chip instead of the usual "read" opcode. > > If this property is not present in DT, mask out fast

Re: [PATCH v2 1/2] mtd: spi-nor: Respect flash's hwcaps in spi_nor_adjust_hwcaps()

2021-08-02 Thread Jagan Teki
On Fri, Jul 30, 2021 at 12:50 PM Bin Meng wrote: > > The smart spi_nor_adjust_hwcaps() does not respect the SPI flash's > hwcaps, and only looks to the controller on what can be supported. > > The flash's hwcaps needs to be AND'ed before checking. > > Fixes: 71025f013ccb ("mtd: spi-nor-core: Rewor

Re: [PATCH] spi: spi-mem-nodm: Fix read data size issue

2021-08-02 Thread Jagan Teki
On Wed, Jul 28, 2021 at 6:20 PM Bin Meng wrote: > > When slave drivers don't set the max_read_size, the spi-mem should > directly use data.nbytes and not limit to any size. But current > logic will limit to the max_write_size. > > This commit mirrors the same changes in the dm version done in > co

Re: [PATCH] Avoid adding the same dataflash for the second time

2021-08-02 Thread Jagan Teki
On Fri, Jun 18, 2021 at 8:26 PM Jakub Frackowiak wrote: > > The spi_dataflash_probe function should return after jedec_probe > if it finds any serial flash. > This functions adds the same SPI device two times without this > path. > Serial output when reading environment: > > Loading Environment fr

RE: [PATCH] armv7: Add Position Independent Execution support

2021-08-02 Thread ChiaWei Wang
Hi Peng, > -Original Message- > From: Peng Fan (OSS) > Sent: Tuesday, August 3, 2021 2:02 PM > > > On 2021/8/3 5:30, Tom Rini wrote: > > On Mon, Aug 02, 2021 at 06:44:57PM +0800, Chia-Wei Wang wrote: > >> A U-Boot image could be loaded and executed at a different location > >> than it w

Re: [PATCH v1] mtd: spi-nor-ids: Add support for XMC XM25QH64C

2021-08-02 Thread Jagan Teki
On Thu, Jun 17, 2021 at 9:57 PM Reto Schneider wrote: > > From: Reto Schneider > > This chip has been (briefly) tested on the MediaTek MT7688 based GARDENA > smart gateway. > > Datasheet: http://xmcwh.com/Uploads/2020-12-17/XM25QH64C_Ver1.1.pdf > Signed-off-by: Reto Schneider > Applied to u-boo

Re: [PATCH] armv7: Add Position Independent Execution support

2021-08-02 Thread Peng Fan (OSS)
On 2021/8/3 5:30, Tom Rini wrote: On Mon, Aug 02, 2021 at 06:44:57PM +0800, Chia-Wei Wang wrote: A U-Boot image could be loaded and executed at a different location than it was linked at. For example, Aspeed takes a stable release version of U-Boot image as the golden one for recovery purpos

Re: [PATCH v2 0/3] efi: Minimal revert to rodata change\

2021-08-02 Thread Ilias Apalodimas
On Mon, Aug 02, 2021 at 01:22:18PM -0600, Simon Glass wrote: > Hi Heinrich, > > On Mon, 2 Aug 2021 at 11:35, Heinrich Schuchardt wrote: > > > > > > > > On 8/2/21 4:44 PM, Simon Glass wrote: > > > The changes to move from devicetree to rodata take things in the wrong > > > direction for various re

Re: [PATCH v2 0/3] efi: Minimal revert to rodata change

2021-08-02 Thread Ilias Apalodimas
On Mon, Aug 02, 2021 at 02:02:56PM -0600, Simon Glass wrote: > Hi Ilias, > > On Mon, 2 Aug 2021 at 09:37, Ilias Apalodimas > wrote: > > > > Hi Simon, > > > > On Mon, Aug 02, 2021 at 08:44:28AM -0600, Simon Glass wrote: > > > The changes to move from devicetree to rodata take things in the wrong >

Re: [PATCH v2 2/3] Revert "mkeficapsule: Remove dtb related options"

2021-08-02 Thread KASHI Takahiro
Simon, On Mon, Aug 02, 2021 at 08:44:30AM -0600, Simon Glass wrote: > This reverts commit f86caab058ff062ce72b24cd1ab9ec1253cc1352. Whether we choose a devicetree approach or not, we don't have to revert this patch because we can do the same thing with standard commands (i.e. fdtoverlay). See my

[PATCH v5 5/7] mmc: zynq_sdhci: Move setting tapdelay code to driver

2021-08-02 Thread Ashok Reddy Soma
Move tapdelay function calls to zynq_sdhci.c and make them static inline. zynqmp_tap_delay.h has function prototypes for the functions defined in tap_delays.c, which will not be needed anymore. Remove tap_delays.c and zynqmp_tap_delay.h files. Signed-off-by: Ashok Reddy Soma --- (no changes sin

[PATCH v5 0/7] Arasan sdhci driver updates

2021-08-02 Thread Ashok Reddy Soma
This patch series updates/fixes below things: - Handle errors from tapdelay functions and return to set_delay() - Add ZynqMP firmware related enums which are used in sdhci driver - Replace mmio_write() with firmware call xilinx_pm_request() - Move tapdelay setting code from tap_delays.c to driv

[PATCH v5 6/7] mmc: zynq_sdhci: Wait till sd card detect state is stable

2021-08-02 Thread Ashok Reddy Soma
From: T Karthik Reddy As per SD spec when SD host controller is reset, it takes 1000msec to detect the card state. In case, if we enable the sd bus voltage & card detect state is not stable, then host controller will disable the sd bus voltage. In case of warm/subsystem reboot, due to unstable c

[PATCH v5 2/7] mmc: sdhci: Change prototype of set_delay to return errors

2021-08-02 Thread Ashok Reddy Soma
set_delay() has return type as void. If there are any errors while setting tapdelay's it won't be able to return them. Change the prototype of set_delay() in sdhci_ops structure and return the errors from wherever it is called. Signed-off-by: Ashok Reddy Soma Reviewed-by: Jaehoon Chung --- (no

[PATCH v5 3/7] zynqmp_firmware: Add zynqmp firmware related enums

2021-08-02 Thread Ashok Reddy Soma
From: T Karthik Reddy Add enums for pm node id's, pm ioctl id's, tapdelay types, dll reset types Signed-off-by: T Karthik Reddy Signed-off-by: Ashok Reddy Soma --- (no changes since v4) Changes in v4: - Rebase to latest u-boot-microblaze custodian 'next' branch - Initialized all enum pm_io

[PATCH v5 7/7] mmc: zynq_sdhci: Use set_control_reg from sdhci.c

2021-08-02 Thread Ashok Reddy Soma
Since set_control_reg is available in sdhci.c, use it and remove arasan_sdhci_set_control_reg(). Signed-off-by: Ashok Reddy Soma Reviewed-by: Jaehoon Chung --- (no changes since v1) drivers/mmc/zynq_sdhci.c | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) diff --gi

[PATCH v5 1/7] mmc: zynq_sdhci: Return errors from arasan_sdhci_set_tapdelay

2021-08-02 Thread Ashok Reddy Soma
Change return type of arasan_sdhci_set_tapdelay() to int, to facilitate returning errors. Get return values from input and output set clock phase functions inside arasan_sdhci_set_tapdelay() and return those errors. Signed-off-by: T Karthik Reddy Signed-off-by: Ashok Reddy Soma Reviewed-by: Jaeh

[PATCH v5 4/7] mmc: zynq_sdhci: Add xilinx_pm_request() method to set tapdelays

2021-08-02 Thread Ashok Reddy Soma
Currently xilinx sdhci driver is using zynqmp_mmio_write() to set tapdelay values and DLL resets. Continue to use this for SPL and mini U-Boot where U-Boot will be executed at EL3 level. Use firmware call xilinx_pm_request() using appropriate arguments to set input/output tapdelays and also for DL

Re: [PATCH v4 6/7] mmc: zynq_sdhci: Wait till sd card detect state is stable

2021-08-02 Thread Jaehoon Chung
On 8/3/21 1:57 PM, Ashok Reddy Soma wrote: > HI Jaehoon, > >> -Original Message- >> From: Jaehoon Chung >> Sent: Tuesday, August 3, 2021 3:45 AM >> To: Ashok Reddy Soma ; u-boot@lists.denx.de >> Cc: peng@nxp.com; faiz_ab...@ti.com; s...@chromium.org; >> mich...@walle.cc; git ; mon...@

RE: [PATCH v4 6/7] mmc: zynq_sdhci: Wait till sd card detect state is stable

2021-08-02 Thread Ashok Reddy Soma
HI Jaehoon, > -Original Message- > From: Jaehoon Chung > Sent: Tuesday, August 3, 2021 3:45 AM > To: Ashok Reddy Soma ; u-boot@lists.denx.de > Cc: peng@nxp.com; faiz_ab...@ti.com; s...@chromium.org; > mich...@walle.cc; git ; mon...@monstr.eu; > somaashokre...@gmail.com; T Karthik Redd

[PATCH v2 6/6] riscv: lib: modify the indent

2021-08-02 Thread Zong Li
We usually use a space in function declaration, rather than a tab. Signed-off-by: Zong Li --- arch/riscv/include/asm/cache.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/riscv/include/asm/cache.h b/arch/riscv/include/asm/cache.h index 6ebb2b4329..b700ff5021 100644 ---

[PATCH v2 5/6] riscv: lib: move platform-related libraries to sperate folder

2021-08-02 Thread Zong Li
Put the platform-related implementation into their own folder respectively. Just leave the common library in the top of lib folder. Signed-off-by: Zong Li --- arch/riscv/Kconfig | 7 +++ arch/riscv/lib/Makefile | 9 - arch/riscv/lib/andest

[PATCH v2 4/6] riscv: sifive: use common cache_init instead of duplicated implementation

2021-08-02 Thread Zong Li
We already extracted the duplicated implementation to common code, so change to use that and drop the original implementation. Signed-off-by: Zong Li --- arch/riscv/cpu/fu540/Kconfig | 1 + arch/riscv/cpu/fu540/Makefile | 1 - arch/riscv/cpu/fu540/cache.c

[PATCH v2 3/6] riscv: lib: introduce cache_init interface

2021-08-02 Thread Zong Li
Add an interface for cache initialization. Each platform can overwrite this weak function by their own implementation, such as sifive_cache in this patch. Signed-off-by: Zong Li --- arch/riscv/Kconfig | 5 + arch/riscv/include/asm/cache.h | 1 + arch/riscv/lib/Makefile|

[PATCH v2 2/6] board: sifive: use ccache driver instead of helper function

2021-08-02 Thread Zong Li
Invokes the generic cache_enable interface to execute the relative implementation in SiFive ccache driver. Signed-off-by: Zong Li --- arch/riscv/cpu/fu540/Kconfig | 1 + arch/riscv/cpu/fu540/cache.c | 54 ++- arch/riscv/cpu/fu740/Kconfig

[PATCH v2 1/6] cache: add sifive composable cache driver

2021-08-02 Thread Zong Li
This driver is currently responsible for enabling all ccache ways. Composable cache could be configure as RAM or cache, we will use it as RAM at the beginning to put the u-boot SPL there. In u-boot proper phrase, we will use the composable cache as cache, and try to enable the cache ways. Signed-o

[PATCH v2 0/6] Support SiFive Composable cache driver

2021-08-02 Thread Zong Li
This patch set contains the SiFive composable cache support, and indroduce an interface to do cache initialization, each platform can overwrite it by their own implementation. Changed in v2: - Refine the ccache driver by Sean's suggestions - Introduce a common interface for cache initialization

Pull request: u-boot-samsung master

2021-08-02 Thread Minkyu Kang
Dear Tom, The following changes since commit b70b9b07463db2f6937c7ea6d7fb5122feb7ba1b: Prepare v2021.10-rc1 (2021-07-26 20:57:18 -0400) are available in the git repository at: g...@source.denx.de:u-boot/custodians/u-boot-samsung.git master for you to fetch changes up to 18f3afa4be879a9f591

[PATCH v2 1/2] arm: Fix option dependency with Kconfig language

2021-08-02 Thread Chia-Wei Wang
Use Kconfig 'depends on' instead of #if macro to express the option depdencies. Signed-off-by: Chia-Wei Wang --- arch/arm/Kconfig | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 2b7b625705..c142eaa5c1 100644 --- a/arch/arm/Kc

[PATCH v2 2/2] armv7: Add Position Independent Execution support

2021-08-02 Thread Chia-Wei Wang
A U-Boot image could be loaded and executed at a different location than it was linked at. For example, Aspeed takes a stable release version of U-Boot image as the golden one for recovery purposes. When the primary storage such as flash is corrupted, the golden image would be loaded to any SRAM/D

[PATCH v2 0/2] armv7: Add Position Independent Execution support

2021-08-02 Thread Chia-Wei Wang
Add PIE support for ARMv7 platform. v2: - Fix Kconfig option dependices using Kconfig language Chia-Wei Wang (2): arm: Fix option dependency with Kconfig language armv7: Add Position Independent Execution support arch/arm/Kconfig | 9 arch/arm/cpu/armv7/start.S | 43 +++

Re: [PATCH] riscv: cpu: fu740: Fix typo of date

2021-08-02 Thread Rick Chen
> From: U-Boot On Behalf Of Zong Li > Sent: Monday, August 02, 2021 3:34 PM > To: u-boot@lists.denx.de > Cc: Zong Li > Subject: [PATCH] riscv: cpu: fu740: Fix typo of date > > Fixed the typo of date of copyright declaration. > > Signed-off-by: Zong Li > --- > arch/riscv/cpu/fu740/spl.c | 2 +- >

Re: Broken CONFIG_SPL_SATA_SUPPORT=y

2021-08-02 Thread Tom Rini
On Tue, Aug 03, 2021 at 01:33:53AM +0200, Pali Rohár wrote: > On Monday 02 August 2021 18:46:48 Tom Rini wrote: > > On Tue, Aug 03, 2021 at 12:38:19AM +0200, Pali Rohár wrote: > > > On Monday 02 August 2021 18:11:20 Tom Rini wrote: > > > > On Mon, Aug 02, 2021 at 11:56:58PM +0200, Pali Rohár wrote:

RE: [PATCH] armv7: Add Position Independent Execution support

2021-08-02 Thread ChiaWei Wang
Hi Tom, > From: Tom Rini > Sent: Tuesday, August 3, 2021 5:31 AM > On Mon, Aug 02, 2021 at 06:44:57PM +0800, Chia-Wei Wang wrote: > > A U-Boot image could be loaded and executed at a different location > > than it was linked at. > > > > For example, Aspeed takes a stable release version of U-Boot

Re: [PATCH] Revert "efi_capsule: Move signature from DTB to .rodata"

2021-08-02 Thread KASHI Takahiro
On Mon, Aug 02, 2021 at 08:44:41AM -0600, Simon Glass wrote: > Hi, > > On Mon, 2 Aug 2021 at 01:15, KASHI Takahiro > wrote: > > > > On Sun, Aug 01, 2021 at 08:47:15PM -0600, Simon Glass wrote: > > > Hi Ilias, > > > > > > On Sun, 1 Aug 2021 at 20:28, Ilias Apalodimas > > > wrote: > > > > > > > >

Please pull u-boot-x86

2021-08-02 Thread Bin Meng
Hi Tom, This PR includes the following x86 changes for v2021.10: - Fixed broken ICH SPI driver in software sequencer mode - Added "m25p,fast-read" to SPI flash node for x86 boards - Drop ROM_NEEDS_BLOBS and BUILD_ROM for x86 ROM builds - Define a default TSC timer frequency for all x86 boards - x

Re: Broken CONFIG_SPL_SATA_SUPPORT=y

2021-08-02 Thread Pali Rohár
On Monday 02 August 2021 18:46:48 Tom Rini wrote: > On Tue, Aug 03, 2021 at 12:38:19AM +0200, Pali Rohár wrote: > > On Monday 02 August 2021 18:11:20 Tom Rini wrote: > > > On Mon, Aug 02, 2021 at 11:56:58PM +0200, Pali Rohár wrote: > > > > On Monday 02 August 2021 17:43:22 Tom Rini wrote: > > > > >

Re: [PATCH 09/11] x86: quark: MRC: Remove U_BOOT_DATE and U_BOOT_TIME from debug log

2021-08-02 Thread Bin Meng
On Mon, Aug 2, 2021 at 9:19 PM Pali Rohár wrote: > > U_BOOT_DATE and U_BOOT_TIME are updated on every run of make command. > Therefore mrc.c file is recompiled every time when running make which means > that whole U-Boot binary is recompiled on every run of make command. > > Simplify it and do not

Re: [PATCH 2/2] arm: mach-snapdrgon: misc: Simplify msm_generate_mac_addr()

2021-08-02 Thread Ramon Fried
On Mon, Aug 2, 2021 at 5:52 PM Stephan Gerhold wrote: > > The logic in msm_generate_mac_addr() was originally taken from the LK > bootloader where the serial number is a string and must be parsed first. > However, in U-Boot msm_board_serial() returns an u32 and > msm_generate_mac_addr() has quite

Re: [PATCH 1/2] arm: mach-snapdragon: misc: Initialize eMMC if necessary

2021-08-02 Thread Ramon Fried
On Mon, Aug 2, 2021 at 5:52 PM Stephan Gerhold wrote: > > At the moment U-Boot produces an empty MAC address (02:00:00:00:00:00) > if the eMMC is not used by anything in U-Boot (e.g. with > CONFIG_ENV_IS_NOWHERE=y instead of having the environment on eMMC). > This happens because then there is not

Re: Broken CONFIG_SPL_SATA_SUPPORT=y

2021-08-02 Thread Tom Rini
On Tue, Aug 03, 2021 at 12:38:19AM +0200, Pali Rohár wrote: > On Monday 02 August 2021 18:11:20 Tom Rini wrote: > > On Mon, Aug 02, 2021 at 11:56:58PM +0200, Pali Rohár wrote: > > > On Monday 02 August 2021 17:43:22 Tom Rini wrote: > > > > On Mon, Aug 02, 2021 at 03:30:20PM -0600, Simon Glass wrote

Re: Broken CONFIG_SPL_SATA_SUPPORT=y

2021-08-02 Thread Pali Rohár
On Monday 02 August 2021 18:11:20 Tom Rini wrote: > On Mon, Aug 02, 2021 at 11:56:58PM +0200, Pali Rohár wrote: > > On Monday 02 August 2021 17:43:22 Tom Rini wrote: > > > On Mon, Aug 02, 2021 at 03:30:20PM -0600, Simon Glass wrote: > > > > Hi Pali, > > > > > > > > On Mon, 2 Aug 2021 at 15:26, Pal

Re: [PATCH v4 6/7] mmc: zynq_sdhci: Wait till sd card detect state is stable

2021-08-02 Thread Jaehoon Chung
Hi Ashok, On 8/2/21 7:16 PM, Ashok Reddy Soma wrote: > From: T Karthik Reddy > > As per SD spec when SD host controller is reset, it takes 1000msec > to detect the card state. In case, if we enable the sd bus voltage & > card detect state is not stable, then host controller will disable > the sd

Re: [EXTERNAL] Re: New Arch For Mkimage

2021-08-02 Thread Tom Rini
On Mon, Aug 02, 2021 at 06:06:37PM -0400, Randy Yates wrote: > Hey Tom, > > I did that. Did you want me to issue a pull request? I'm not sure of the > proper process. The general answer is that you'll want to submit a series of patches, likely with git send-email, so that nothing gets mangled, t

Re: Broken CONFIG_SPL_SATA_SUPPORT=y

2021-08-02 Thread Tom Rini
On Mon, Aug 02, 2021 at 11:56:58PM +0200, Pali Rohár wrote: > On Monday 02 August 2021 17:43:22 Tom Rini wrote: > > On Mon, Aug 02, 2021 at 03:30:20PM -0600, Simon Glass wrote: > > > Hi Pali, > > > > > > On Mon, 2 Aug 2021 at 15:26, Pali Rohár wrote:> > > > > On Monday 02 August 2021 15:23:22 Sim

Re: [EXTERNAL] Re: New Arch For Mkimage

2021-08-02 Thread Randy Yates
Hey Tom, I did that. Did you want me to issue a pull request? I'm not sure of the proper process. --Randy On 8/2/21 6:01 PM, Tom Rini wrote: ATTENTION: This Email originated outside SCC. Use caution before clicking on any links or attachments. On Mon, Jul 26, 2021 at 02:08:09PM -0400, Rand

Re: New Arch For Mkimage

2021-08-02 Thread Tom Rini
On Mon, Jul 26, 2021 at 02:08:09PM -0400, Randy Yates wrote: > I am attempting to use mkimage to build a uImage for a new architecture: > csky. This architecture is already in the mainline kernel. > > It appears the only thing to do is to added a new enumeration after > IH_ARCH_RISCV in u-boot/in

Re: Broken CONFIG_SPL_SATA_SUPPORT=y

2021-08-02 Thread Tom Rini
On Mon, Aug 02, 2021 at 11:41:29PM +0200, Pali Rohár wrote: > On Monday 02 August 2021 15:30:20 Simon Glass wrote: > > Hi Pali, > > > > On Mon, 2 Aug 2021 at 15:26, Pali Rohár wrote:> > > > On Monday 02 August 2021 15:23:22 Simon Glass wrote: > > > > () Hi Pali, > > > > > > > > On Mon, 2 Aug 2021

Re: Broken CONFIG_SPL_SATA_SUPPORT=y

2021-08-02 Thread Pali Rohár
On Monday 02 August 2021 17:43:22 Tom Rini wrote: > On Mon, Aug 02, 2021 at 03:30:20PM -0600, Simon Glass wrote: > > Hi Pali, > > > > On Mon, 2 Aug 2021 at 15:26, Pali Rohár wrote:> > > > On Monday 02 August 2021 15:23:22 Simon Glass wrote: > > > > () Hi Pali, > > > > > > > > On Mon, 2 Aug 2021 a

Re: Broken CONFIG_SPL_SATA_SUPPORT=y

2021-08-02 Thread Tom Rini
On Mon, Aug 02, 2021 at 03:30:20PM -0600, Simon Glass wrote: > Hi Pali, > > On Mon, 2 Aug 2021 at 15:26, Pali Rohár wrote:> > > On Monday 02 August 2021 15:23:22 Simon Glass wrote: > > > () Hi Pali, > > > > > > On Mon, 2 Aug 2021 at 15:18, Pali Rohár wrote: > > > > > > > > On Monday 02 August 20

Re: Broken CONFIG_SPL_SATA_SUPPORT=y

2021-08-02 Thread Pali Rohár
On Monday 02 August 2021 15:30:20 Simon Glass wrote: > Hi Pali, > > On Mon, 2 Aug 2021 at 15:26, Pali Rohár wrote:> > > On Monday 02 August 2021 15:23:22 Simon Glass wrote: > > > () Hi Pali, > > > > > > On Mon, 2 Aug 2021 at 15:18, Pali Rohár wrote: > > > > > > > > On Monday 02 August 2021 15:14

Re: Broken CONFIG_SPL_SATA_SUPPORT=y

2021-08-02 Thread Tom Rini
On Mon, Aug 02, 2021 at 11:25:54PM +0200, Pali Rohár wrote: > On Monday 02 August 2021 15:23:22 Simon Glass wrote: > > () Hi Pali, > > > > On Mon, 2 Aug 2021 at 15:18, Pali Rohár wrote: > > > > > > On Monday 02 August 2021 15:14:30 Simon Glass wrote: > > > > Hi Pali, > > > > > > > > On Mon, 2 Aug

Re: [PATCH] Revert "spi: spi-uclass: Add support to manually relocate spi memory ops"

2021-08-02 Thread Tom Rini
On Sat, Jul 24, 2021 at 02:46:27PM -0500, Dennis Gilmore wrote: > On Sat, Jul 24, 2021 at 11:03 AM Tom Rini wrote: > > > > On Fri, Jul 23, 2021 at 10:49:39PM -0500, Dennis Gilmore wrote: > > > On Fri, Jul 23, 2021 at 10:25 PM Tom Rini wrote: > > > > > > > > On Fri, Jul 23, 2021 at 09:46:44PM -050

Re: [PATCH 11/11] Remove including timestamp.h in version.h

2021-08-02 Thread Tom Rini
On Mon, Aug 02, 2021 at 09:42:23PM +0200, Pali Rohár wrote: > On Monday 02 August 2021 13:21:58 Simon Glass wrote: > > Hi Pali, > > > > On Mon, 2 Aug 2021 at 07:20, Pali Rohár wrote: > > > > > > Header file version.h does not use anything from timestamp.h. Including of > > > timestamp.h has side

Re: [PATCH v2 1/5] checkpatch: Support wide strings

2021-08-02 Thread Tom Rini
On Mon, Aug 02, 2021 at 01:20:21PM -0600, Simon Glass wrote: > Hi Tom, > > On Sat, 31 Jul 2021 at 21:28, Tom Rini wrote: > > > > On Sun, Jul 18, 2021 at 02:14:22PM -0600, Simon Glass wrote: > > > > > From: Joe Perches > > > > > > Allow prefixing typical strings with L for wide strings and u for

Re: [PATCH] armv7: Add Position Independent Execution support

2021-08-02 Thread Tom Rini
On Mon, Aug 02, 2021 at 06:44:57PM +0800, Chia-Wei Wang wrote: > A U-Boot image could be loaded and executed at a different > location than it was linked at. > > For example, Aspeed takes a stable release version of U-Boot image > as the golden one for recovery purposes. When the primary storage >

Re: Broken CONFIG_SPL_SATA_SUPPORT=y

2021-08-02 Thread Simon Glass
Hi Pali, On Mon, 2 Aug 2021 at 15:26, Pali Rohár wrote:> > On Monday 02 August 2021 15:23:22 Simon Glass wrote: > > () Hi Pali, > > > > On Mon, 2 Aug 2021 at 15:18, Pali Rohár wrote: > > > > > > On Monday 02 August 2021 15:14:30 Simon Glass wrote: > > > > Hi Pali, > > > > > > > > On Mon, 2 Aug 2

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-02 Thread Tom Rini
On Thu, Jul 29, 2021 at 09:22:02AM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > This reverts commit 2359fa7a87848626bcbd3399e92c657595880cd7. > > While the goal is valid and there is surely unused memory in that area, > we also have a lot of crucial things still located at the top-of-memory

Re: Broken CONFIG_SPL_SATA_SUPPORT=y

2021-08-02 Thread Pali Rohár
On Monday 02 August 2021 15:23:22 Simon Glass wrote: > () Hi Pali, > > On Mon, 2 Aug 2021 at 15:18, Pali Rohár wrote: > > > > On Monday 02 August 2021 15:14:30 Simon Glass wrote: > > > Hi Pali, > > > > > > On Mon, 2 Aug 2021 at 15:09, Pali Rohár wrote: > > > > > > > > On Monday 02 August 2021 16

Re: Broken CONFIG_SPL_SATA_SUPPORT=y

2021-08-02 Thread Simon Glass
() Hi Pali, On Mon, 2 Aug 2021 at 15:18, Pali Rohár wrote: > > On Monday 02 August 2021 15:14:30 Simon Glass wrote: > > Hi Pali, > > > > On Mon, 2 Aug 2021 at 15:09, Pali Rohár wrote: > > > > > > On Monday 02 August 2021 16:55:34 Tom Rini wrote: > > > > On Sun, Aug 01, 2021 at 02:25:16PM +0200,

Re: Broken CONFIG_SPL_SATA_SUPPORT=y

2021-08-02 Thread Pali Rohár
On Monday 02 August 2021 15:14:30 Simon Glass wrote: > Hi Pali, > > On Mon, 2 Aug 2021 at 15:09, Pali Rohár wrote: > > > > On Monday 02 August 2021 16:55:34 Tom Rini wrote: > > > On Sun, Aug 01, 2021 at 02:25:16PM +0200, Pali Rohár wrote: > > > > > > > Hello! > > > > > > > > Option CONFIG_SPL_SAT

Re: Broken CONFIG_SPL_SATA_SUPPORT=y

2021-08-02 Thread Simon Glass
Hi Pali, On Mon, 2 Aug 2021 at 15:09, Pali Rohár wrote: > > On Monday 02 August 2021 16:55:34 Tom Rini wrote: > > On Sun, Aug 01, 2021 at 02:25:16PM +0200, Pali Rohár wrote: > > > > > Hello! > > > > > > Option CONFIG_SPL_SATA_SUPPORT=y is currently broken in u-boot master > > > branch. If I try t

Re: Broken CONFIG_SPL_SATA_SUPPORT=y

2021-08-02 Thread Pali Rohár
On Monday 02 August 2021 16:55:34 Tom Rini wrote: > On Sun, Aug 01, 2021 at 02:25:16PM +0200, Pali Rohár wrote: > > > Hello! > > > > Option CONFIG_SPL_SATA_SUPPORT=y is currently broken in u-boot master > > branch. If I try to enable it for A38x platform I'm getting following > > compiler error:

Re: Broken CONFIG_SPL_SATA_SUPPORT=y

2021-08-02 Thread Tom Rini
On Sun, Aug 01, 2021 at 02:25:16PM +0200, Pali Rohár wrote: > Hello! > > Option CONFIG_SPL_SATA_SUPPORT=y is currently broken in u-boot master > branch. If I try to enable it for A38x platform I'm getting following > compiler error: > > LD spl/u-boot-spl > arm-linux-gnueabihf-ld.bfd:

Re: Broken CONFIG_SPL_SATA_SUPPORT=y

2021-08-02 Thread Pali Rohár
On Monday 02 August 2021 13:21:51 Simon Glass wrote: > Hi Pali, > > On Sun, 1 Aug 2021 at 06:25, Pali Rohár wrote: > > > > Hello! > > > > Option CONFIG_SPL_SATA_SUPPORT=y is currently broken in u-boot master > > branch. If I try to enable it for A38x platform I'm getting following > > compiler er

[PATCH 1/1] doc: add pkg-config to the build dependencies

2021-08-02 Thread Heinrich Schuchardt
tools/Makefile uses pkg-config. Signed-off-by: Heinrich Schuchardt --- doc/build/gcc.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/build/gcc.rst b/doc/build/gcc.rst index e03e0b9460..0cdc307d57 100644 --- a/doc/build/gcc.rst +++ b/doc/build/gcc.rst @@ -26,8 +26,

Re: [PATCH 03/11] efi_loader: Use directly version_string variable

2021-08-02 Thread Heinrich Schuchardt
+cc Ilias On 8/2/21 3:18 PM, Pali Rohár wrote: Macro U_BOOT_VERSION_STRING is already stored in variable version_string. So use directly this variable instead of storing U_BOOT_VERSION_STRING into temporary variable. Signed-off-by: Pali Rohár --- lib/efi_loader/efi_tcg2.c | 5 ++--- 1 file

Re: [PATCH v2 0/3] efi: Minimal revert to rodata change

2021-08-02 Thread Simon Glass
Hi Ilias, On Mon, 2 Aug 2021 at 09:37, Ilias Apalodimas wrote: > > Hi Simon, > > On Mon, Aug 02, 2021 at 08:44:28AM -0600, Simon Glass wrote: > > The changes to move from devicetree to rodata take things in the wrong > > direction for various reasons: > > > > As I said on the previous thread, I t

Re: [PATCH 11/11] Remove including timestamp.h in version.h

2021-08-02 Thread Pali Rohár
On Monday 02 August 2021 13:21:58 Simon Glass wrote: > Hi Pali, > > On Mon, 2 Aug 2021 at 07:20, Pali Rohár wrote: > > > > Header file version.h does not use anything from timestamp.h. Including of > > timestamp.h has side effect which cause recompiling object file at every > > make run because t

Re: [PATCH 1/3] dtoc: Rename is_wider_than() to reduce confusion

2021-08-02 Thread Walter Lozano
Hi Simon, On 8/1/21 11:50 PM, Simon Glass wrote: Hi Walter, On Sun, 1 Aug 2021 at 20:45, Walter Lozano wrote: Hi Simon, Thanks for checking this bug, I'm glad that you were able to come with fix quickly. I have some questions, I hope that you find some time to help me understand. On 7/28/21

Re: [PATCH v2 0/3] efi: Minimal revert to rodata change

2021-08-02 Thread Simon Glass
Hi Heinrich, On Mon, 2 Aug 2021 at 11:35, Heinrich Schuchardt wrote: > > > > On 8/2/21 4:44 PM, Simon Glass wrote: > > The changes to move from devicetree to rodata take things in the wrong > > direction for various reasons: > > > > - devicetree is where config should be stored > > We are not tal

Re: [PATCH v4 07/10] watchdog: wdt-uclass.c: handle all DM watchdogs in watchdog_reset()

2021-08-02 Thread Simon Glass
Hi Rasmus, On Mon, 2 Aug 2021 at 09:00, Rasmus Villemoes wrote: > > A board can have and make use of more than one watchdog device, say > one built into the SOC and an external gpio-petted one. Having > wdt-uclass only handle the first is both a little arbitrary and > unexpected. > > So change in

Re: [PATCH 09/11] x86: quark: MRC: Remove U_BOOT_DATE and U_BOOT_TIME from debug log

2021-08-02 Thread Simon Glass
On Mon, 2 Aug 2021 at 07:19, Pali Rohár wrote: > > U_BOOT_DATE and U_BOOT_TIME are updated on every run of make command. > Therefore mrc.c file is recompiled every time when running make which means > that whole U-Boot binary is recompiled on every run of make command. > > Simplify it and do not r

Re: [PATCH 11/11] Remove including timestamp.h in version.h

2021-08-02 Thread Simon Glass
Hi Pali, On Mon, 2 Aug 2021 at 07:20, Pali Rohár wrote: > > Header file version.h does not use anything from timestamp.h. Including of > timestamp.h has side effect which cause recompiling object file at every > make run because timestamp.h changes at every run. > > So remove timestamp.h from ver

Re: Broken CONFIG_SPL_SATA_SUPPORT=y

2021-08-02 Thread Simon Glass
Hi Pali, On Sun, 1 Aug 2021 at 06:25, Pali Rohár wrote: > > Hello! > > Option CONFIG_SPL_SATA_SUPPORT=y is currently broken in u-boot master > branch. If I try to enable it for A38x platform I'm getting following > compiler error: > > LD spl/u-boot-spl > arm-linux-gnueabihf-ld.bfd: dri

Re: [PATCH] mkimage: clarify error message for empty input files

2021-08-02 Thread Simon Glass
On Sun, 1 Aug 2021 at 16:23, Thomas Hebb wrote: > > Currently, an empty imput file causes `mmap()` to fail, and you get an > error like "mkimage: Can't read file.img: Invalid argument", which is > extremely unintuitive and hard to diagnose if you don't know what to > look for. Add an explicit chec

Re: [PATCH v2 1/5] checkpatch: Support wide strings

2021-08-02 Thread Simon Glass
Hi Tom, On Sat, 31 Jul 2021 at 21:28, Tom Rini wrote: > > On Sun, Jul 18, 2021 at 02:14:22PM -0600, Simon Glass wrote: > > > From: Joe Perches > > > > Allow prefixing typical strings with L for wide strings and u for > > unicode strings. > > > > Signed-off-by: Joe Perches > > Signed-off-by: Sim

Re: U-boot

2021-08-02 Thread Simon Glass
Hi Rasmus, On Mon, 2 Aug 2021 at 03:37, Rasmus Villemoes wrote: > > On 02/08/2021 11.25, Roman Kopytin wrote: > > Thanks a lot! > > Yes, looks like using of the 'fdtput' is not very safety for me. > > As I understood I need to use "fdt_add_pubkey" tool with CMD (example): > > ./ fdt_add_pubkey -

Re: [PATCH v3 07/10] watchdog: wdt-uclass.c: handle all DM watchdogs in watchdog_reset()

2021-08-02 Thread Simon Glass
Hi Rasmus, On Mon, 2 Aug 2021 at 03:18, Rasmus Villemoes wrote: > > On 31/07/2021 12.06, Stefan Roese wrote: > > Hi Rasmus, > > > > On 15.07.21 10:15, Stefan Roese wrote: > >> Hi Rasmus, > >> > >> On 05.07.21 17:30, Simon Glass wrote: > >>> Hi Rasmus, > >>> > >>> On Fri, 2 Jul 2021 at 06:45, Rasm

Re: [PATCH v2 6/9] sandbox: add config for efi capsule authentication test

2021-08-02 Thread Simon Glass
Hi Takahiro, On Sun, 1 Aug 2021 at 16:57, AKASHI Takahiro wrote: > > Simon, > > On Sun, Aug 01, 2021 at 01:00:20PM -0600, Simon Glass wrote: > > Hi Takahiro, > > > > On Sat, 31 Jul 2021 at 22:29, AKASHI Takahiro > > wrote: > > > > > > Simon, > > > > > > On Sat, Jul 31, 2021 at 10:59:32AM -0600,

Re: [PATCH v3 0/7] vpl: Introduce a verifying program loader

2021-08-02 Thread Tom Rini
On Wed, Jul 28, 2021 at 12:37:55PM -0600, Simon Glass wrote: > Hi Tom, > > > On Wed, 28 Jul 2021 at 11:37, Tom Rini wrote: > > > > On Wed, Jul 28, 2021 at 09:33:56AM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Wed, 28 Jul 2021 at 08:35, Tom Rini wrote: > > > > > > > > On Tue, Jul 27,

Re: [PATCH] dtoc: Correct the intarray-widening test case

2021-08-02 Thread Walter Lozano
Hi Simon, On 8/2/21 10:37 AM, Simon Glass wrote: This case was intended to check that widening an int array with an int does nothing. Fix it. Reported-by: Walter Lozano Signed-off-by: Simon Glass --- tools/dtoc/test_fdt.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2 11/14] lib: Allow using 0x when a decimal value is requested

2021-08-02 Thread Tom Rini
On Sat, Jul 24, 2021 at 09:03:38AM -0600, Simon Glass wrote: > U-Boot mostly uses hex for value input, largely because addresses are much > easier to understand in hex. > > But in some cases a decimal value is requested, such as where the value is > small or hex does not make sense in the context

Re: [PATCH v2 10/14] doc: Add a note about number representation

2021-08-02 Thread Tom Rini
On Sat, Jul 24, 2021 at 09:03:37AM -0600, Simon Glass wrote: > Mention the default base of U-Boot in the command-line section. Add > examples for decimal and octal. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 09/14] doc: Convert command-line info to rST

2021-08-02 Thread Tom Rini
On Sat, Jul 24, 2021 at 09:03:36AM -0600, Simon Glass wrote: > Take this part of the README and put it into rST format. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 08/14] lib: Move common digit-parsing code into a function

2021-08-02 Thread Tom Rini
On Sat, Jul 24, 2021 at 09:03:35AM -0600, Simon Glass wrote: > The code to convert a character into a digit is repeated twice in this > file. Factor it out into a separate function. This also makes the code a > little easier to read. > > Signed-off-by: Simon Glass Applied to u-boot/master, than

Re: [PATCH v2 07/14] lib: Add octal tests for simple_strtoul/l()

2021-08-02 Thread Tom Rini
On Sat, Jul 24, 2021 at 09:03:34AM -0600, Simon Glass wrote: > This function support decoding octal but no tests are included yet. > Add some. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 06/14] lib: Add tests for simple_strtoull()

2021-08-02 Thread Tom Rini
On Sat, Jul 24, 2021 at 09:03:33AM -0600, Simon Glass wrote: > Add some tests that check the behaviour of this function. These are the > same as for simple_strtoul() but with a few longer values. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Descripti

Re: [PATCH v2 05/14] lib: Drop unnecessary check for hex digit

2021-08-02 Thread Tom Rini
On Sat, Jul 24, 2021 at 09:03:32AM -0600, Simon Glass wrote: > If we see 0x then we can assume this is the start of a hex value. It > does not seem necessary to check for a hex digit after that since it will > happen when parsing the value anyway. > > Drop this check to simplify the code and redu

Re: [PATCH v2 04/14] lib: Comment the base parameter with simple_strtoul/l()

2021-08-02 Thread Tom Rini
On Sat, Jul 24, 2021 at 09:03:31AM -0600, Simon Glass wrote: > This parameter is not documented properly since it does not cover the > meaning when the base is 0. Update this in both functions. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description

Re: [PATCH v2 03/14] global: Convert simple_strtoul() with decimal to dectoul()

2021-08-02 Thread Tom Rini
On Sat, Jul 24, 2021 at 09:03:30AM -0600, Simon Glass wrote: > It is a pain to have to specify the value 10 in each call. Add a new > dectoul() function and update the code to use it. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP sign

Re: [PATCH v2 02/14] global: Convert simple_strtoul() with hex to hextoul()

2021-08-02 Thread Tom Rini
On Sat, Jul 24, 2021 at 09:03:29AM -0600, Simon Glass wrote: > It is a pain to have to specify the value 16 in each call. Add a new > hextoul() function and update the code to use it. > > Add a proper comment to simple_strtoul() while we are here. > > Signed-off-by: Simon Glass Applied to u-bo

Re: [PATCH v2 01/14] hash: Ensure verification hex pairs are terminated

2021-08-02 Thread Tom Rini
On Sat, Jul 24, 2021 at 09:03:28AM -0600, Simon Glass wrote: > This function seems to assume that the chr[] variable contains zeros at > the start, which is not always true. Use strlcpy() to be safe. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Descr

Re: [PATCH v2 0/3] efi: Minimal revert to rodata change

2021-08-02 Thread Heinrich Schuchardt
On 8/2/21 4:44 PM, Simon Glass wrote: The changes to move from devicetree to rodata take things in the wrong direction for various reasons: - devicetree is where config should be stored We are not talking about configuration here but about bundling a file. - it provides no memory producti

Re: [PATCH v3 3/4] sf: doc: Add documentation for the 'sf' command

2021-08-02 Thread Pratyush Yadav
Hi Simon, On 01/08/21 03:12PM, Simon Glass wrote: > This command is fairly complicated so documentation is useful. > Unfortunately I an not sure how the MTD side of things works and cannot > find information about that. > > Signed-off-by: Simon Glass > --- > > (no changes since v2) > > Changes

Re: [PATCH v3 2/4] sf: Tidy up code to avoid #ifdef

2021-08-02 Thread Pratyush Yadav
On 01/08/21 03:12PM, Simon Glass wrote: > Update this code to use IS_ENABLED() instead. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > cmd/sf.c | 32 ++-- > 1 file changed, 14 insertions(+), 18 deletions(-) > > diff --git a/cmd/sf.c b/cmd/sf.c >

  1   2   3   >