Re: [ANN] U-Boot v2021.07 released

2021-07-05 Thread Trevor Woerner
On Mon, Jul 5, 2021 at 11:13 AM Tom Rini wrote: > It is release day and here is the v2021.07 release. > > The merge window is once again open and I plan to tag -rc1 on Monday, > July 26th, bi-weekly -rcs thereafter and final release on October 4th, > 2021. > > I am merging the next branch to mast

RE: [PATCH] test/py: tpm2: Skip tpm pytest based on env variable

2021-07-05 Thread T Karthik Reddy
Hi, Any update on this patch? Thanks T Karthik > -Original Message- > From: T Karthik Reddy > Sent: Tuesday, June 22, 2021 11:19 AM > To: u-boot@lists.denx.de > Cc: git-dev ; T Karthik Reddy > Subject: [PATCH] test/py: tpm2: Skip tpm pytest based on env variable > > Tpm test ca

Re: [PATCH] net: dwc_eth_qos: cosmetic: remove unused define EQOS_DESCRIPTOR_ALIGN

2021-07-05 Thread Ramon Fried
On Mon, Jul 5, 2021 at 8:50 PM Patrick DELAUNAY wrote: > > Hi Ramon, > > On 3/31/21 4:43 PM, Ramon Fried wrote: > > On Tue, Mar 30, 2021 at 5:12 PM Marek Vasut wrote: > >> On 3/30/21 2:34 PM, Patrick Delaunay wrote: > >>> Remove the define EQOS_DESCRIPTOR_ALIGN unused since the > >>> commit 6f1e6

Re: [PATCH] arm: mach-snapdragon: pinctrl: Place pin_name in .data section

2021-07-05 Thread Ramon Fried
On Mon, Jul 5, 2021 at 3:19 PM Stephan Gerhold wrote: > > According to arch/arm/lib/crt0_64.S, the BSS section is "UNAVAILABLE" > and uninitialized before relocation. Also, it overlaps with the > appended DTB before relocation, so writing data into a variable > in the BSS section might corrupt the

[PATCH v2] MAINTAINERS, git-mailrc: socfpga: Change co-maintainer to Tien Fong Chee

2021-07-05 Thread Ley Foon Tan
I'm no longer work in Intel, change Intel SoCFPGA co-maintainer to Tien Fong Chee. Signed-off-by: Ley Foon Tan --- v2: Fixed typo "Maintainted" to "Maintained". --- MAINTAINERS| 4 ++-- doc/git-mailrc | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAIN

Re: [PATCH 20/22] sandbox: mmc: Support fixed MMC devices

2021-07-05 Thread Jaehoon Chung
On 7/6/21 7:32 AM, Simon Glass wrote: > Add support for reading devicetree flags for MMC devices. With this we > can distinguish between fixed and removable drives. Note that this > information is only available when the device is probed, not when it is > bound, since it is read in the of_to_plat()

Re: [PATCH 2/3] phy: Add driver for ST-Ericsson AB8500 USB PHY

2021-07-05 Thread Jaehoon Chung
Hi Stephan, On 7/6/21 1:28 AM, Stephan Gerhold wrote: > The AB8500 PMIC contains an USB PHY that needs to be set up in > device or host mode to make USB work properly. Add a simple driver > for the generic PHY uclass that allows enabling it. > > The if (CONFIG_IS_ENABLED(USB_MUSB_HOST)) might be

Re: [PATCH 1/3] power: pmic: Add driver for ST-Ericsson AB8500 via PRCMU

2021-07-05 Thread Jaehoon Chung
On 7/6/21 1:28 AM, Stephan Gerhold wrote: > All devices based on ST-Ericsson Ux500 use a PMIC similar to AB8500 > (Analog Baseband). There is AB8500, AB8505, AB9540 and AB8540 > although in practice only AB8500 and AB8505 are relevant since the > platforms with AB9540 and AB8540 were cancelled and

Re: [PATCH] env: efi: fix a wrong address dereference

2021-07-05 Thread Tom Rini
On Sat, Jul 03, 2021 at 10:25:22AM -0400, Tom Rini wrote: > From: AKASHI Takahiro > > Probably, a pointer to a variable in an inner block should not > be exposed to an outer block. > > Fixes: c70f44817d46 ("efi_loader: simplify 'printenv -e'") > Signed-off-by: AKASHI Takahiro > [trini: Don't m

Re: [PATCH v3 3/3] test/py: rewrite sqfsls command test suite

2021-07-05 Thread Tom Rini
On Wed, Jun 30, 2021 at 07:45:05PM -0300, Joao Marcos Costa wrote: > Add more details to test cases by comparing each expected line with the > command's output. Add new test cases: > - sqfsls at an empty directory > - sqfsls at a sub-directory > > Signed-off-by: Joao Marcos Costa Applied to u-b

Re: [PATCH v3 2/3] test/py: rewrite sqfsload command test suite

2021-07-05 Thread Tom Rini
On Wed, Jun 30, 2021 at 07:45:04PM -0300, Joao Marcos Costa wrote: > The previous strategy to know if a file was correctly loaded was to > check for how many bytes were read and compare it against the file's > original size. Since this is not a good solution, replace it by > comparing the checksum

Re: [PATCH v3 1/3] test/py: rewrite common tools for SquashFS tests

2021-07-05 Thread Tom Rini
On Wed, Jun 30, 2021 at 07:45:03PM -0300, Joao Marcos Costa wrote: > Remove the previous OOP approach, which was confusing and incomplete. > Add more test cases by making SquashFS images with various options, > concerning file fragmentation and its compression. Add comments to > properly document

Re: [PATCH v3 3/3] Azure: Add loop devices and CAP_SYS_ADMIN for sandbox test.py tests

2021-07-05 Thread Tom Rini
On Mon, Jun 21, 2021 at 09:51:56PM +0300, Alper Nebi Yasak wrote: > The filesystem test setup needs to prepare disk images for its tests, > with either guestmount or loop mounts. The former requires access to the > host fuse device (added in a previous patch), the latter requires access > to host

Re: [PATCH v3 2/3] Azure: Add fuse device for test.py tests

2021-07-05 Thread Tom Rini
On Mon, Jun 21, 2021 at 09:51:55PM +0300, Alper Nebi Yasak wrote: > The EFI secure boot and capsule test setups need to prepare disk images > for their tests using virt-make-fs, which requires access to the host > fuse device. This is not exposed to the docker container by default and > has to be

Re: [PATCH v3 1/3] tools: docker: Install a readable kernel for libguestfs-tools

2021-07-05 Thread Tom Rini
On Mon, Jun 21, 2021 at 09:51:54PM +0300, Alper Nebi Yasak wrote: > The filesystem and EFI (capsule and secure boot) test setups try to use > guestmount and virt-make-fs respectively to prepare disk images to run > tests on. However, these libguestfs tools need a kernel image and fail > with the f

Re: [PATCH] Docker/CI: Update to "focal" and latest build

2021-07-05 Thread Tom Rini
On Thu, Jun 10, 2021 at 10:57:36AM -0400, Tom Rini wrote: > Move us up to being based on Ubuntu 20.04 "focal" and the latest tag > from Ubuntu for this release. For this, we make sure that "python" is > now python3 but still include python2.7 for the rx51 qemu build as that > is very old and does

Re: [PATCH 2/2] test/py: Wait for guestmount worker to exit after running guestunmount

2021-07-05 Thread Tom Rini
On Fri, Jun 04, 2021 at 10:04:46PM +0300, Alper Nebi Yasak wrote: > Some filesystem tests are failing when their image is prepared with > guestmount, but succeeding if loop mounts are used instead. The reason > seems to be a race condition the guestmount(1) manual page explains: > > When gues

Re: [PATCH 1/2] test/py: Use loop mounts if guestmount fails in filesystem tests

2021-07-05 Thread Tom Rini
On Fri, Jun 04, 2021 at 10:04:45PM +0300, Alper Nebi Yasak wrote: > If guestmount isn't available on the system, filesystem test setup falls > back to using loop mounts to prepare its disk images. If guestmount is > available but fails to work, the tests are immediately skipped. Instead > of givin

[PATCH] cmd: ums: Enable by default for sunxi

2021-07-05 Thread Andre Przywara
The ums command (presenting a U-Boot block device as a USB mass storage device) is very useful for accessing eMMC devices via USB-OTG. At the moment we enable USB fastboot by default for Allwinner devices, so it makes sense to do the same with USB mass storage, which is actually more versatile and

[PATCH 3/3] sunxi: OrangePi Zero 2: Enable SPI booting

2021-07-05 Thread Andre Przywara
The OrangePi Zero 2 board comes with 2MB of SPI flash, from which the BROM is supposed to be able to boot from. Enable the SPL code responsible for finding and loading U-Boot proper and friends, so that u-boot-sunxi-with-spl.bin can be written into the flash. Signed-off-by: Andre Przywara --- c

[PATCH 2/3] sunxi: SPL SPI: Add SPI boot support for the Allwinner H616 SoC

2021-07-05 Thread Andre Przywara
The H616 SoC uses the same SPI IP as the H6, also shares the same clocks and reset bits. The only real difference is a slight change in the pin assignment: the H6 uses PC5, the H616 PC4 instead. This makes for a small change in our spi0_pinmux_setup() routine. Apart from that, just extend the H6 #

[PATCH 1/3] sunxi: SPL SPI: Allow larger SPL

2021-07-05 Thread Andre Przywara
The more recent Allwinner SoCs BootROMs can actually load SPL images larger than 32KB. We use this on the H616 to fit the extra code needed for the PMIC into the image, and have provisions in board.c to respect that larger SPL size when booting from MMC. However the sunxi SPL SPI loader has a hard

[PATCH 0/3] sunxi: H616: SPI boot support

2021-07-05 Thread Andre Przywara
The Allwinner H616 supports booting from SPI NOR flash, for which we use our SPL specific SPI driver. Since this uses hardcoded values for clocks, resets and pins, we need to extend it to cover the H616 SoC as well. Patch 1/3 extends the logic that determines the offset of the U-Boot payload, from

[PATCH 22/22] log: Allow padding of the function name

2021-07-05 Thread Simon Glass
At present when function names are logged, the output is a little hard to read since every function is a different length. Add a way to pad the names so that the log messages line up vertically. This doesn't work if the function name is very long, but it makes a big difference in most cases. Use 2

[PATCH 21/22] blk: Support iteration

2021-07-05 Thread Simon Glass
It is useful to be able to iterate over block devices. Typically there are fixed and removable devices. For security reasons it is sometimes useful to ignore removable devices since they are under user control. Add iterators which support selecting the block-device type. Signed-off-by: Simon Glas

[PATCH 19/22] spl: Provide more information on boot failure

2021-07-05 Thread Simon Glass
If SPL fails to boot, try to provide an error code to indicate what is wrong. For example, if a uclass is missing, this can return -EPFNOSUPPORT (-96) which provides useful information. Add a helper for accessing the image-loader name so we can drop the use of #ifdefs in this code. Put this featu

[PATCH 20/22] sandbox: mmc: Support fixed MMC devices

2021-07-05 Thread Simon Glass
Add support for reading devicetree flags for MMC devices. With this we can distinguish between fixed and removable drives. Note that this information is only available when the device is probed, not when it is bound, since it is read in the of_to_plat() method. This could be changed if needed later

[PATCH 18/22] image: Allow @ in node names when not using signatures

2021-07-05 Thread Simon Glass
If signature verification is not in use we don't need to worry about the risk of using @ in node names. Update fit_image_verify() to allow it if the function is not enabled. Signed-off-by: Simon Glass --- common/image-fit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/com

[PATCH 15/22] bloblist: Support resizing a blob

2021-07-05 Thread Simon Glass
Sometimes a blob needs to expand, e.g. because it needs to hold more log data. Add support for this. Note that the bloblist must have sufficient spare space for this to work. Signed-off-by: Simon Glass --- common/bloblist.c | 71 - include/bloblist.h | 13 +++ test/bloblist.c

[PATCH 16/22] bloblist: Tidy up a few API comments

2021-07-05 Thread Simon Glass
Some comments for struct bloblist_hdr are a bit ambiguous. Update them to clarify the meaning more precisely. Also document bloblist_get_stats() properly. Signed-off-by: Simon Glass --- include/bloblist.h | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/include/blo

[PATCH 17/22] bloblist: Correct condition in bloblist_addrec()

2021-07-05 Thread Simon Glass
It is possible to add a blob that ends at the end of the bloblist, but at present this is not supported. Fix it and add a regression test for this case. Signed-off-by: Simon Glass --- common/bloblist.c | 2 +- test/bloblist.c | 23 +++ 2 files changed, 24 insertions(+), 1

[PATCH 12/22] cros_ec: Drop cros_ec_entering_mode()

2021-07-05 Thread Simon Glass
This function is not needed anymore. Drop it. Signed-off-by: Simon Glass --- drivers/misc/cros_ec.c | 11 --- drivers/misc/cros_ec_sandbox.c | 3 --- include/cros_ec.h | 9 - 3 files changed, 23 deletions(-) diff --git a/drivers/misc/cros_ec.c b/drivers/m

[PATCH 13/22] cros_ec: Support the full-size vboot context

2021-07-05 Thread Simon Glass
The v2 format is 64-bytes in size. Support this and drop v1 since it is not used anymore. Signed-off-by: Simon Glass --- drivers/misc/cros_ec_sandbox.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/misc/cros_ec_sandbox.c b/drivers/misc/cros_ec_sandbox.c ind

[PATCH 10/22] sandbox: Adjust the bloblist default address

2021-07-05 Thread Simon Glass
Move this down to provide more space for the bloblist. Signed-off-by: Simon Glass --- common/Kconfig | 2 +- doc/arch/sandbox.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common/Kconfig b/common/Kconfig index 2a7f08af1dc..21407b547da 100644 --- a/common/Kconf

[PATCH 14/22] cros_ec: Use standard calls for recovery-request checking

2021-07-05 Thread Simon Glass
Rather than calling directly into the sandbox SDL code, we can use the normal U-Boot console handling for this feature. Update the code, to make it more generic. Signed-off-by: Simon Glass --- drivers/misc/cros_ec_sandbox.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(

[PATCH 09/22] sandbox: Use hinting with the display

2021-07-05 Thread Simon Glass
SDL provides a hinting feature which provides a higher-quality image with the double-display option (-K). Enable it. Signed-off-by: Simon Glass --- arch/sandbox/cpu/sdl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/sandbox/cpu/sdl.c b/arch/sandbox/cpu/sdl.c index e2649494818..be

[PATCH 11/22] cros_ec: Allow reading the battery-charge state

2021-07-05 Thread Simon Glass
Add a function to read this information from the EC. It is useful for determining whether the battery has enough charge to boot. Signed-off-by: Simon Glass --- drivers/misc/cros_ec.c | 17 + include/cros_ec.h | 8 2 files changed, 25 insertions(+) diff --git a/dr

[PATCH 07/22] sandbox: Support executables for more phases

2021-07-05 Thread Simon Glass
The SPL header has a function for obtaining the phase in capital letters, e.g. 'SPL'. Add one for lower-case also, as used by sandbox. Use this to generalise the sandbox logic for determining the filename of the next sandbox executable. This can provide support for VPL. Signed-off-by: Simon Glass

[PATCH 08/22] sandbox: Add work-around for SDL2 display

2021-07-05 Thread Simon Glass
At present the display does not show on some machines, e.g. Ubunutu 20.04 but the reason is unknown. Add a work-around until this can be determined. Also include more error checking just in case. Signed-off-by: Simon Glass --- arch/sandbox/cpu/sdl.c | 23 ++- 1 file changed

[PATCH 05/22] test: Avoid a build error with SPL

2021-07-05 Thread Simon Glass
At present this fails to build chromeos_sandbox due to a rebase error in dm_test_pre_run(). Fix it. Signed-off-by: Simon Glass --- test/test-main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test-main.c b/test/test-main.c index 7afe8741cf9..3cdf6849c57 100644 --- a

[PATCH 02/22] dm: Support lzma in the flashmap

2021-07-05 Thread Simon Glass
Allow lzma compression as well as lz4. Signed-off-by: Simon Glass --- drivers/core/of_extra.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/core/of_extra.c b/drivers/core/of_extra.c index 7702beff97b..632a1c2210e 100644 --- a/drivers/core/of_extra.c +++ b/drivers/core/of_extra.c

[PATCH 06/22] Makefile: Avoid rebuilding .dtb files each time

2021-07-05 Thread Simon Glass
Drop the FORCE from the rule that builds .dtb files and let the normal dependency checking do its work. This should work correctly, at least for .dts files that don't use /include/. Signed-off-by: Simon Glass --- scripts/Makefile.lib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[PATCH 03/22] test: Allow CONFIG_SPL_LOAD_FIT to be disabled

2021-07-05 Thread Simon Glass
At present if this is not enabled on a sandbox build, the build fails. Add a condition to avoid this. Signed-off-by: Simon Glass --- test/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/Makefile b/test/Makefile index a26e915e050..117839e5847 100644 --- a/test/Makefile +++ b/

[PATCH 04/22] test: Add DM_DMA to be disabled

2021-07-05 Thread Simon Glass
At present if DM_DMA is disabled on a sandbox build, the build fails. Make the test conditional. Signed-off-by: Simon Glass --- test/dm/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/dm/core.c b/test/dm/core.c index 2210345dd14..0492698997c 100644 --- a/test/dm/core.c +++ b/t

[PATCH 01/22] dm: core: Add logging for DM_SEQ_ALIAS

2021-07-05 Thread Simon Glass
It is sometimes helpful to see which sequence is assigned to a device. Add debugging info for that. Signed-off-by: Simon Glass --- drivers/core/device.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/core/device.c b/drivers/core/device.c index 9f1400768de..29668f

Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL

2021-07-05 Thread Tom Rini
On Mon, Jul 05, 2021 at 03:02:24PM -0600, Simon Glass wrote: > Hi Tom, > > On Mon, 5 Jul 2021 at 12:51, Tom Rini wrote: > > > > On Mon, Jul 05, 2021 at 07:58:18PM +0200, Wolfgang Denk wrote: > > > Dear Sean, > > > > > > In message you wrote: > > > > > > > > > Is your intent to create a fork of t

Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL

2021-07-05 Thread Simon Glass
Hi Tom, On Mon, 5 Jul 2021 at 12:51, Tom Rini wrote: > > On Mon, Jul 05, 2021 at 07:58:18PM +0200, Wolfgang Denk wrote: > > Dear Sean, > > > > In message you wrote: > > > > > > > Is your intent to create a fork of this in U-Boot? > > > > > > Yes. I believe some of the major additions I have made

Re: [RFC PATCH 02/28] cli: Add LIL shell

2021-07-05 Thread Sean Anderson
On 7/5/21 3:53 PM, Tom Rini wrote: On Mon, Jul 05, 2021 at 03:47:47PM -0400, Sean Anderson wrote: On 7/5/21 3:10 PM, Tom Rini wrote: On Sat, Jul 03, 2021 at 09:33:30PM +0200, Wolfgang Denk wrote: Dear Sean, In message <8bbdb7a1-5085-a3b7-614f-12ae9aee8...@gmail.com> you wrote: For a partia

Re: [RFC PATCH 02/28] cli: Add LIL shell

2021-07-05 Thread Tom Rini
On Mon, Jul 05, 2021 at 03:47:47PM -0400, Sean Anderson wrote: > On 7/5/21 3:10 PM, Tom Rini wrote: > > On Sat, Jul 03, 2021 at 09:33:30PM +0200, Wolfgang Denk wrote: > > > Dear Sean, > > > > > > In message <8bbdb7a1-5085-a3b7-614f-12ae9aee8...@gmail.com> you wrote: > > > > > > > > > For a partia

Re: [RFC PATCH 02/28] cli: Add LIL shell

2021-07-05 Thread Sean Anderson
On 7/5/21 3:10 PM, Tom Rini wrote: On Sat, Jul 03, 2021 at 09:33:30PM +0200, Wolfgang Denk wrote: Dear Sean, In message <8bbdb7a1-5085-a3b7-614f-12ae9aee8...@gmail.com> you wrote: For a partial list, see [1] https://github.com/Forty-Bot/lil/commits/master Whoops, looks like I completely m

Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL

2021-07-05 Thread Sean Anderson
On 7/5/21 1:58 PM, Wolfgang Denk wrote: Dear Sean, In message you wrote: Is your intent to create a fork of this in U-Boot? Yes. I believe some of the major additions I have made (especially "[RFC PATCH 21/28] cli: lil: Add a distinct parsing step") would not be accepted by upstream. Ouc

Re: [RFC PATCH 02/28] cli: Add LIL shell

2021-07-05 Thread Tom Rini
On Sat, Jul 03, 2021 at 09:33:30PM +0200, Wolfgang Denk wrote: > Dear Sean, > > In message <8bbdb7a1-5085-a3b7-614f-12ae9aee8...@gmail.com> you wrote: > > > > > For a partial list, see > > > > > > [1] https://github.com/Forty-Bot/lil/commits/master > > > > Whoops, looks like I completely misread

Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL

2021-07-05 Thread Tom Rini
On Mon, Jul 05, 2021 at 07:58:18PM +0200, Wolfgang Denk wrote: > Dear Sean, > > In message you wrote: > > > > > Is your intent to create a fork of this in U-Boot? > > > > Yes. I believe some of the major additions I have made (especially "[RFC > > PATCH 21/28] cli: lil: Add a distinct parsing st

Re: [PATCH 8/8] dtoc: Update documentation to cover warnings in more detail

2021-07-05 Thread Walter Lozano
Hi Simon, On 7/4/21 3:19 PM, Simon Glass wrote: When things go wrong it can be confusing to figure out what to change. Add a few more details to the documentation. Fix a 'make htmldocs' warning while we are here. Signed-off-by: Simon Glass --- doc/develop/driver-model/of-plat.rst | 53

Re: [PATCH 7/8] dtoc: Detect drivers which do not parse correctly

2021-07-05 Thread Walter Lozano
On 7/4/21 3:19 PM, Simon Glass wrote: At present if a driver is missing a uclass or compatible stirng, this Most probably it should be "string" is silently ignored. This makes sense in most cases, particularly for the compatible string, since it is not required except when the driver is used

Re: [PATCH 4/8] dtoc: Correct the re_compat regular expression

2021-07-05 Thread Walter Lozano
Hi Simon, On 7/4/21 3:19 PM, Simon Glass wrote: This expects a . before the field name (.e.g '.compatible = ...) but presently accepts anything at all. Fix it. Signed-off-by: Simon Glass --- tools/dtoc/src_scan.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Wal

Re: [PATCH 3/8] dtoc: Allow multiple warnings for a driver

2021-07-05 Thread Walter Lozano
Hi Simon, On 7/4/21 3:19 PM, Simon Glass wrote: At present we show when a driver is missing but this is not always that useful. There are various reasons way a driver may appear to be missing, Did you mean "why" instead of "way"? such as a parse error in the source code or a missing field in

Re: [PATCH 2/8] dtoc: Convert to use ArgumentParser

2021-07-05 Thread Walter Lozano
Hi Simon, On 7/4/21 3:19 PM, Simon Glass wrote: Use this parser instead of OptionParser, which is deprecated. Signed-off-by: Simon Glass --- tools/dtoc/main.py | 51 -- 1 file changed, 27 insertions(+), 24 deletions(-) Reviewed-by: Walter Lozan

Re: [PATCH 1/8] dtoc: Avoid using subscripts on match objects

2021-07-05 Thread Walter Lozano
Hi Simon, On 7/4/21 3:19 PM, Simon Glass wrote: These are not supported before Python 3.6 so avoid them. Signed-off-by: Simon Glass --- tools/dtoc/src_scan.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Walter Lozano Thanks! Walter diff --git a/tools/dtoc/src_s

Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL

2021-07-05 Thread Wolfgang Denk
Dear Sean, In message you wrote: > > > Is your intent to create a fork of this in U-Boot? > > Yes. I believe some of the major additions I have made (especially "[RFC > PATCH 21/28] cli: lil: Add a distinct parsing step") would not be > accepted by upstream. Ouch... > > Could we not update thi

Re: [ANN] U-Boot v2021.07 released

2021-07-05 Thread Tom Rini
On Mon, Jul 05, 2021 at 11:13:17AM -0400, Tom Rini wrote: > Hey all, > > It is release day and here is the v2021.07 release. With this release > we are now at the second of our 2 years past a number of DM migration > deadlines. Once again, this will be the last release for a number of > boards

Re: [PATCH] net: dwc_eth_qos: cosmetic: remove unused define EQOS_DESCRIPTOR_ALIGN

2021-07-05 Thread Patrick DELAUNAY
Hi Ramon, On 3/31/21 4:43 PM, Ramon Fried wrote: On Tue, Mar 30, 2021 at 5:12 PM Marek Vasut wrote: On 3/30/21 2:34 PM, Patrick Delaunay wrote: Remove the define EQOS_DESCRIPTOR_ALIGN unused since the commit 6f1e668d964e ("net: dwc_eth_qos: Pad descriptors to cacheline size") Signed-off-by:

Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup

2021-07-05 Thread Wolfgang Denk
Dear Sean, In message <5a967151-94f0-6037-2d02-0114c43b8...@gmail.com> you wrote: > > AIUI hush has diverged significantly from what U-Boot has. This would > not be an "update" moreso than a complete port in the style of the > current series. Agreed. However, as you write this it sounds like a b

[PATCH 1/1] sandbox: don't set SA_NODEFER in signal handler

2021-07-05 Thread Heinrich Schuchardt
The sandbox can handle signals. Due to a damaged global data pointer additional exceptions in the signal handler may occur leading to an endless loop. In this case leave the handling of the secondary exception to the operating system. Signed-off-by: Heinrich Schuchardt --- arch/sandbox/cpu/os.c

Re: [PATCH] smbios: Try CONFIG_SYS_ options before using "Unknow" as a value

2021-07-05 Thread Ilias Apalodimas
Simon, Bin, As Heinrich points out some of the CONFIG_SYS_* values are not representing the devices properly. Maybe it's a better idea to only check the .dts? If the values are missing we can pop a runtime warning and keep using 'Unknown'. On Mon, Jul 05, 2021 at 09:29:57AM -0600, Simon Glass wr

Re: [PATCH] sandbox: Support signal handling only when requested

2021-07-05 Thread Heinrich Schuchardt
On 7/4/21 10:15 PM, Simon Glass wrote: Hi Heinrich, On Sun, 6 Jun 2021 at 15:35, Heinrich Schuchardt wrote: Am 6. Juni 2021 20:07:31 MESZ schrieb Sean Anderson : On 6/6/21 1:57 PM, Heinrich Schuchardt wrote: On 6/6/21 7:52 PM, Sean Anderson wrote: On 6/6/21 1:28 PM, Heinrich Schuchardt wro

Re: [PATCH 1/1] tpm2: Add a TPMv2 MMIO TIS driver

2021-07-05 Thread Ilias Apalodimas
> > > [...] > > > These definitions match Linux' tpm_tis_core.h. > > > > > > Should they be moved to an include of the same name in U-Boot? > > > > I got a tpm_tis.h in this series, so I might as well move those there > > > > > > > > > [...] > > > > > I would prefer if you would add these functio

Re: [RFC] Start using guestfish for U-Boot fs tests

2021-07-05 Thread Alper Nebi Yasak
On 05/07/2021 00:14, Tom Rini wrote: > On Sat, Jul 03, 2021 at 05:38:07PM -0400, Tom Rini wrote: >> On Sat, Jul 03, 2021 at 05:27:44PM +0300, Alper Nebi Yasak wrote: >>> >>> >>> On 02/07/2021 23:24, Tom Rini wrote: On Fri, Jul 02, 2021 at 11:03:52PM +0300, Alper Nebi Yasak wrote: > On 02/0

[PATCH 2/3] phy: Add driver for ST-Ericsson AB8500 USB PHY

2021-07-05 Thread Stephan Gerhold
The AB8500 PMIC contains an USB PHY that needs to be set up in device or host mode to make USB work properly. Add a simple driver for the generic PHY uclass that allows enabling it. The if (CONFIG_IS_ENABLED(USB_MUSB_HOST)) might be a bit strange. The USB PHY must be configured in either host or d

[PATCH 3/3] usb: musb-new: Add glue driver for ST-Ericsson Ux500

2021-07-05 Thread Stephan Gerhold
The ST-Ericsson DB8500 SoC contains a MUSB OTG controller which supports both host and gadget mode. For some reason there is nothing special about it - add a simple glue driver for Ux500 that literally just sets up MUSB together with a generic PHY. There are no SoC-specific registers etc needed to

[PATCH 1/3] power: pmic: Add driver for ST-Ericsson AB8500 via PRCMU

2021-07-05 Thread Stephan Gerhold
All devices based on ST-Ericsson Ux500 use a PMIC similar to AB8500 (Analog Baseband). There is AB8500, AB8505, AB9540 and AB8540 although in practice only AB8500 and AB8505 are relevant since the platforms with AB9540 and AB8540 were cancelled and never used in production. In general, the AB8500

[PATCH 0/3] Add support for USB on ST-Ericsson Ux500

2021-07-05 Thread Stephan Gerhold
This patch series adds support for USB on ST-Ericsson Ux500 by: - Adding a driver to talk to the AB8500 PMIC - Adding a driver to enable the USB PHY - Adding a simple Ux500 glue driver for the musb-new driver This was tested on the u8500 "stemmy" board that is already present in U-Boot. St

Re: [PATCH 1/1] smbios: convert function descriptions to Sphinx style

2021-07-05 Thread Simon Glass
On Thu, 10 Jun 2021 at 04:15, Heinrich Schuchardt wrote: > > Use 'Return:' instead of '@return:'. > > Signed-off-by: Heinrich Schuchardt > --- > lib/smbios.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH] smbios: Fix calculating BIOS Release Date

2021-07-05 Thread Simon Glass
On Thu, 22 Apr 2021 at 10:10, Pali Rohár wrote: > > BIOS Release Date must be in format mm/dd/ and must be release date. > U-Boot currently sets BIOS Release Date from U_BOOT_DMI_DATE macro which is > generated from current build timestamp. > > Fix this issue by setting U_BOOT_DMI_DATE macro t

Re: [PATCH 1/1] smbios: error handling for invalid addresses

2021-07-05 Thread Simon Glass
Hi Heinrich, On Sat, 15 May 2021 at 10:08, Heinrich Schuchardt wrote: > > SMBIOS tables only support 32bit addresses. If we don't have memory here > handle the error gracefully: > > * on x86_64 fail to start U-Boot > * during UEFI booting ignore the missing table > > Signed-off-by: Heinrich Schuc

Re: [PATCH v2 1/1] bootcount: add a new driver with syscon as backend

2021-07-05 Thread Simon Glass
On Thu, 10 Jun 2021 at 06:41, Nandor Han wrote: > > The driver will use a syscon regmap as backend and supports both > 16 and 32 size value. The value will be stored in the CPU's endianness. > > Signed-off-by: Nandor Han > --- > > Notes: > Description > --- > Add a new driver

Re: [PATCH] fit: Load DTO into temporary buffer and ignore load address

2021-07-05 Thread Simon Glass
On Sat, 26 Jun 2021 at 13:23, Marek Vasut wrote: > > On 6/26/21 8:31 PM, Simon Glass wrote: > > Hi, > > > > On Thu, 10 Jun 2021 at 20:10, Marek Vasut wrote: > >> > >> The current fitImage DTO implementation expects each fitImage image > >> subnode containing DTO to have 'load' property, pointing

Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL

2021-07-05 Thread Sean Anderson
On 7/5/21 11:29 AM, Simon Glass wrote: Hi Sean, On Thu, 1 Jul 2021 at 00:16, Sean Anderson wrote: Several functions have different names than they do in TCL. To make things easier for those familiar with TCL, rename them to their TCL equivalents. At the moment, this is only done for functions

[PATCH 8/9] sandbox: tpm: Support storing device state in tpm2

2021-07-05 Thread Simon Glass
At present the tpm2 emulator does not support storing the device state. Add this so we can handle the normal vboot flow through the sandbox executables (VPL->SPL etc.) with the TPM contents staying in place. Note: sandbox has not yet been converted to use livetree for the state information, since

[PATCH 7/9] sandbox: tpm: Support nvdata in TPM2

2021-07-05 Thread Simon Glass
Add support for this feature in the TPM2 emulator, to support Chromium OS vboot. Signed-off-by: Simon Glass --- drivers/tpm/tpm2_tis_sandbox.c | 68 ++ include/tpm-v2.h | 2 + 2 files changed, 70 insertions(+) diff --git a/drivers/tpm/tpm2_tis_san

[PATCH 9/9] sandbox: tpm: Support extending a PCR multiple times

2021-07-05 Thread Simon Glass
It is fairly easy to handle this case and it makes the emulator more useful, since PCRs are commonly extended several times. Add support for this, using U-Boot's sha256 support. Signed-off-by: Simon Glass --- drivers/tpm/tpm2_tis_sandbox.c | 19 --- 1 file changed, 12 insertion

[PATCH 6/9] sandbox: tpm: Track whether the state is valid

2021-07-05 Thread Simon Glass
Add checking as to whether the current TPM state is valid, so we can implement reading/writing the state. Signed-off-by: Simon Glass --- drivers/tpm/tpm2_tis_sandbox.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/tpm/tpm2_tis_sandbox.c b/drivers/tpm/tpm

[PATCH 4/9] sandbox: tpm: Correct handling of get-capability

2021-07-05 Thread Simon Glass
This function current handles the kernel case incorrectly. Fix it, and use the shorter TPM_HDR_LEN while we are here. Signed-off-by: Simon Glass --- drivers/tpm/tpm_tis_sandbox.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/tpm/tpm_tis_sandbox.c b/

[PATCH 5/9] sandbox: tpm: Finish comments for struct sandbox_tpm2

2021-07-05 Thread Simon Glass
Tidy up the missing comments for this struct. Signed-off-by: Simon Glass --- drivers/tpm/tpm2_tis_sandbox.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/tpm/tpm2_tis_sandbox.c b/drivers/tpm/tpm2_tis_sandbox.c index 24c804a5645..5e0bd304699 10

[PATCH 2/9] sandbox: tpm: Tidy up reading and writing of device state

2021-07-05 Thread Simon Glass
At present this code assumes that the TPM data has been read but this may not be the case. Refactor the code to use a separate pointer so we know the current state of the data. Add error checking for the data size. Signed-off-by: Simon Glass --- drivers/tpm/tpm_tis_sandbox.c | 35 +

[PATCH 3/9] sandbox: tpm: Support the define-space command

2021-07-05 Thread Simon Glass
Add support for this command, moving away from the previous approach of hard-coding the initial data in the driver, now that the kernel-space data has to be set up by the higher-level vboot code. Signed-off-by: Simon Glass --- drivers/tpm/sandbox_common.c | 11 +++ drivers/tpm/sandbox_

[PATCH 1/9] sandbox: tpm: Split out common nvdata code

2021-07-05 Thread Simon Glass
We want to support nvdata in TPM2 as well. To avoid code duplicating the associated code, move it into a common file. Drop the special-case logic for the kernel space. This can be handled by the higher-level code now, i.e. in vboot itself. Signed-off-by: Simon Glass --- drivers/tpm/Makefile

[PATCH 0/9] tpm: Enhance sandbox tpm2 emulation

2021-07-05 Thread Simon Glass
At present the TPM2 emulator lacks the ability to load and save the state. This means it cannot be used for verify-boot flow that includes multiple phases (e.g. VPL and SPL). It also lacks support for non-volatile data storage. This series adds these features to the TPM2 emulator, with some code f

Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup

2021-07-05 Thread Sean Anderson
On 7/5/21 11:29 AM, Simon Glass wrote: Hi, On Mon, 5 Jul 2021 at 08:42, Sean Anderson wrote: On 7/5/21 1:07 AM, Steve Bennett wrote: On 4 Jul 2021, at 5:26 am, Wolfgang Denk wrote: Dear Sean, In message you wrote: Well, since Hush was never updated, I don't believe LIL will be either.

Re: [PATCH 1/1] tpm2: Add a TPMv2 MMIO TIS driver

2021-07-05 Thread Simon Glass
Hi Ilias, On Fri, 2 Jul 2021 at 14:29, Ilias Apalodimas wrote: > > On Fri, Jul 02, 2021 at 07:54:13PM +0200, Heinrich Schuchardt wrote: > > On 7/2/21 2:52 PM, Ilias Apalodimas wrote: > > > Add a TPMv2 TIS MMIO compatible driver. > > > This useful for a couple of reasons. First of all we can supp

Re: [PATCH v3 07/10] watchdog: wdt-uclass.c: handle all DM watchdogs in watchdog_reset()

2021-07-05 Thread Simon Glass
Hi Rasmus, On Fri, 2 Jul 2021 at 06:45, Rasmus Villemoes wrote: > > A board can have and make use of more than one watchdog device, say > one built into the SOC and an external gpio-petted one. Having > wdt-uclass only handle the first is both a little arbitrary and > unexpected. > > So change in

Re: [PATCH] sysinfo: rcar3: Add Renesas R-Car Gen3 sysinfo driver

2021-07-05 Thread Simon Glass
Hi Marek, On Sun, 4 Jul 2021 at 13:35, Marek Vasut wrote: > > The Renesas R-Car Gen3 development kits contain board ID EEPROM. > This driver parses out the board ID and revision out of that > EEPROM and exports it e.g. for the board-info print on boot. > > Signed-off-by: Marek Vasut > Cc: Sean A

Re: [RFC PATCH 02/28] cli: Add LIL shell

2021-07-05 Thread Simon Glass
Hi, On Sat, 3 Jul 2021 at 13:33, Wolfgang Denk wrote: > > Dear Sean, > > In message <8bbdb7a1-5085-a3b7-614f-12ae9aee8...@gmail.com> you wrote: > > > > > For a partial list, see > > > > > > [1] https://github.com/Forty-Bot/lil/commits/master > > > > Whoops, looks like I completely misread what yo

Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL

2021-07-05 Thread Simon Glass
Hi Sean, On Thu, 1 Jul 2021 at 00:16, Sean Anderson wrote: > > Several functions have different names than they do in TCL. To make things > easier for those familiar with TCL, rename them to their TCL equivalents. > At the moment, this is only done for functions not used by LIL_FULL. Some > funct

Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup

2021-07-05 Thread Simon Glass
Hi, On Mon, 5 Jul 2021 at 08:42, Sean Anderson wrote: > > On 7/5/21 1:07 AM, Steve Bennett wrote: > > On 4 Jul 2021, at 5:26 am, Wolfgang Denk wrote: > >> > >> Dear Sean, > >> > >> In message you wrote: > >>> > >>> Well, since Hush was never updated, I don't believe LIL will be either. > >> > >

Re: [PATCH v3 3/3] test/py: rewrite sqfsls command test suite

2021-07-05 Thread Simon Glass
On Wed, 30 Jun 2021 at 16:45, Joao Marcos Costa wrote: > > Add more details to test cases by comparing each expected line with the > command's output. Add new test cases: > - sqfsls at an empty directory > - sqfsls at a sub-directory > > Signed-off-by: Joao Marcos Costa > --- > .../test_fs/test_

Re: [PATCH 3/3] test: cmd: setexpr: add tests for format string operations

2021-07-05 Thread Simon Glass
On Mon, 28 Jun 2021 at 09:18, Roland Gaudig wrote: > > From: Roland Gaudig > > Series-version 2 missing : > > Signed-off-by: Roland Gaudig > --- > > test/cmd/setexpr.c | 33 + > 1 file changed, 33 insertions(+) Reviewed-by: Simon Glass (please resend as v3 t

Re: [PATCH 2/3] doc: usage: add description for setexpr command

2021-07-05 Thread Simon Glass
On Mon, 28 Jun 2021 at 09:18, Roland Gaudig wrote: > > From: Roland Gaudig > > Add usage for the setexpr command. It has been added to describe > mainly the new setexpr format string operation. > > Signed-off-by: Roland Gaudig > --- > > MAINTAINERS | 6 ++ > doc/usage/index.rst |

Re: [PATCH v3 2/3] test/py: rewrite sqfsload command test suite

2021-07-05 Thread Simon Glass
On Wed, 30 Jun 2021 at 16:45, Joao Marcos Costa wrote: > > The previous strategy to know if a file was correctly loaded was to > check for how many bytes were read and compare it against the file's > original size. Since this is not a good solution, replace it by > comparing the checksum of the lo

Re: [RFC PATCH 01/28] Add Zlib License

2021-07-05 Thread Simon Glass
On Thu, 1 Jul 2021 at 00:16, Sean Anderson wrote: > > This adds the Zlib License which is compatible with GPLv2 as long as its > terms are met. Files originally licensed as Zlib should use the "GPL-2.0+ > AND Zlib" SPDX identifier. > > Signed-off-by: Sean Anderson > --- > > Licenses/README |

  1   2   >