Re: [PATCH 0/6] octeontx cleanup and fixes

2021-03-25 Thread Stefan Roese
Hi Tim, On 26.03.21 01:07, Tim Harvey wrote: This series provides the following for octeontx: - cleanup to the octeontx common header file by moving CONFIG_SUPPORT_RAW_INITRD to defconfig files, - adds generic distro config support - add missing SBSA watchdog to config - fix an issue found wi

Re: [PATCH 6/6] net: octeontx: smi: fix mii probe

2021-03-25 Thread Stefan Roese
On 26.03.21 01:07, Tim Harvey wrote: The fdt node offset is apparently not set properly when probed causing no MDIO busses to be found. Fix this by obtaining the offset. Signed-off-by: Tim Harvey Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/net/octeontx/smi.c | 2 ++ 1 file cha

Re: [PATCH 5/6] drivers: ata: ahci: update max id if it is more than available ports

2021-03-25 Thread Stefan Roese
On 26.03.21 01:07, Tim Harvey wrote: From: Suneel Garapati After check for maximum between max id and available ports, also check if available port count is less than max id and update. In the case of the CN8030 OcteonTX SoC max_id needs to be reduced to the number of ports found otherwise the

Re: [PATCH 4/6] drivers: net: octeontx: fix QSGMII

2021-03-25 Thread Stefan Roese
On 26.03.21 01:07, Tim Harvey wrote: Revert a change that occured between the Marvell SDK-10.1.1.0 and SDK-10.3.1.1 which broke QSMII phy support. Signed-off-by: Tim Harvey Thanks. Suneel, do you have a comment on this? Is this revert the "best way" to handle this? Thanks, Stefan --- dr

Re: [PATCH 3/6] arm: octeontx: enable WDT_SBSA

2021-03-25 Thread Stefan Roese
On 26.03.21 01:07, Tim Harvey wrote: The OcteonTX uses ARM's SBSA Watchdog device Signed-off-by: Tim Harvey Reviewed-by: Stefan Roese Thanks, Stefan --- configs/octeontx_81xx_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/octeontx_81xx_defconfig b/configs/octeont

Re: [PATCH 2/6] arm: octeontx: support generic distro config

2021-03-25 Thread Stefan Roese
On 26.03.21 01:07, Tim Harvey wrote: Support Generic Distro Default config Signed-off-by: Tim Harvey Reviewed-by: Stefan Roese Thanks, Stefan --- include/configs/octeontx_common.h | 31 ++- 1 file changed, 26 insertions(+), 5 deletions(-) diff --git a/inclu

Re: [PATCH 1/6] arm: octeontx: move CONFIG_SUPPORT_RAW_INITRD to configs

2021-03-25 Thread Stefan Roese
On 26.03.21 01:07, Tim Harvey wrote: Move CONFIG_SUPPORT_RAW_INITRD out of the octeontx_common header and into the defconfig files. Signed-off-by: Tim Harvey Reviewed-by: Stefan Roese Thanks, Stefan --- configs/octeontx_81xx_defconfig | 1 + configs/octeontx_83xx_defconfig | 1 +

Re: [PATCH] usb: eth: add print of device name on usb_ether registration

2021-03-25 Thread Stefan Roese
On 25.03.21 17:56, Tim Harvey wrote: When a USB Ethernet device is detected and registered there is no way to know the device-name in order to use it with the ethact env variable. Add a print to display the device name that is registered. Nice. I've also stumbled upon this problem a few times

Re: [PATCH 8/8] configs: sheevaplug: enable driver-model based MMC

2021-03-25 Thread Stefan Roese
On 25.03.21 14:48, Harm Berntsen wrote: Signed-off-by: Harm Berntsen CC: Prafulla Wadaskar CC: Stefan Roese CC: Tom Rini Nitpicking: It is recommended to also add a small commit text, even when the patch is trivial and the subject includes all infos. If you send v2 of this series (which see

Re: [PATCH v3 1/6] libfdt: Tidy up pylibfdt build rule

2021-03-25 Thread Simon Glass
On Fri, 26 Mar 2021 at 17:02, Simon Glass wrote: > > At present the build rule for pylibfdt depends on _libfdt.so but modern > Python versions add a different suffix to the output file, resulting in > something like _libfdt.cpython-38-x86_64-linux-gnu.so > > The result is that pylibfdt is rebuilt

Re: [PATCH v2] dm: test: Always include command.h for print_ut

2021-03-25 Thread Simon Glass
On Fri, 26 Mar 2021 at 15:02, Sean Anderson wrote: > > We need this header for U_BOOT_CMD, which is always present even without > EFI. > > Fixes: 82c468a049 ("dm: test: Update Makefile conditions") > > Signed-off-by: Sean Anderson > --- > > Changes in v2: > - Remove ifdef > > test/print_ut.c | 2

Re: [PATCH 2/2] Rename CONFIG_DM_RESET to CONFIG_RESET

2021-03-25 Thread Simon Glass
Hi Stefan, On Fri, 26 Mar 2021 at 18:44, Stefan Roese wrote: > > On 26.03.21 04:13, Simon Glass wrote: > > This config was misnamed at birth since there has never been a > > CONFIG_RESET option used before driver model. Rename it so that it is > > clear that driver model is the only option here.

Please pull u-boot-dm/next into -next

2021-03-25 Thread Simon Glass
Hi Tom, Well here we are again...let's see how this one fares. This is for the -next branch. https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/6933 The following changes since commit 874dcedee92a828b03c8d3146dccfaa8b709618b: Merge branch '2021-03-20-mediatek-updates' into next

Re: [PATCH 7/8] mmc: mvebu: convert to driver model

2021-03-25 Thread Stefan Roese
On 25.03.21 14:48, Harm Berntsen wrote: This is a straightforward conversion of the old, non-dm driver. It was done in-place as the deadline for non-dm MMC has passed. Previous commits ensured that no board depends on the old, non-dm variant. Tested on a Kirkwood based board with eMMC. Signed-of

Re: [PATCH 4/8] ARM: kirkwood: remove non-dm MMC driver init

2021-03-25 Thread Stefan Roese
On 25.03.21 14:47, Harm Berntsen wrote: No board uses this driver any more: remove it. Signed-off-by: Harm Berntsen CC: Gerald Kerma CC: Stefan Roese CC: Pantelis Antoniou Reviewed-by: Stefan Roese Thanks, Stefan ---  arch/arm/mach-kirkwood/cpu.c | 7 ---  1 file changed, 7 delet

Re: [PATCH 3/8] configs: sheevaplug: remove non-dm MMC driver

2021-03-25 Thread Stefan Roese
On 25.03.21 14:47, Harm Berntsen wrote: This will be replaced with the driver model version Signed-off-by: Harm Berntsen CC: Prafulla Wadaskar CC: Stefan Roese CC: Tom Rini Reviewed-by: Stefan Roese Thanks, Stefan ---  include/configs/sheevaplug.h | 8  1 file changed, 8 del

Re: [PATCH 2/8] configs: openrd: remove non-dm MMC driver

2021-03-25 Thread Stefan Roese
On 25.03.21 14:47, Harm Berntsen wrote: Unfortunately this board has no DM support at all. We are also way past the deadline for driver model support for various devices on this board. Signed-off-by: Harm Berntsen CC: Stefan Roese CC: Tom Rini Reviewed-by: Stefan Roese Thanks, Stefan --

Re: [PATCH 1/8] configs: remove unused CONFIG_SYS_MMC_BASE defs

2021-03-25 Thread Stefan Roese
On 25.03.21 14:47, Harm Berntsen wrote: These boards use an MMC driver that does not use this definition Signed-off-by: Harm Berntsen CC: Stefan Roese CC: Dirk Eibach CC: Mario Six CC: Dennis Gilmore Reviewed-by: Stefan Roese Thanks, Stefan ---  include/configs/clearfog.h    | 5

[PATCH v3 1/6] libfdt: Tidy up pylibfdt build rule

2021-03-25 Thread Simon Glass
At present the build rule for pylibfdt depends on _libfdt.so but modern Python versions add a different suffix to the output file, resulting in something like _libfdt.cpython-38-x86_64-linux-gnu.so The result is that pylibfdt is rebuilt every time. Rename the file the standard name so that the ru

[PATCH 2/2] Rename CONFIG_DM_RESET to CONFIG_RESET

2021-03-25 Thread Simon Glass
This config was misnamed at birth since there has never been a CONFIG_RESET option used before driver model. Rename it so that it is clear that driver model is the only option here. Signed-off-by: Simon Glass --- arch/arm/Kconfig | 10 +++ arch/arm/mach-aspeed/Kconf

Re: [PATCH v2 5/6] Makefile: Use a variable for generated of-platdata headers

2021-03-25 Thread Simon Glass
There are actually two generated files but only one is currently mentioned in the Makefile as a dependency. Put them both in a Makefile variable and use that instead, to avoid inconsistency. Signed-off-by: Simon Glass --- Changes in v2: - Add a comment to the endif scripts/Makefile.spl | 11 ++

Re: [PATCH v2 1/6] libfdt: Tidy up pylibfdt build rule

2021-03-25 Thread Simon Glass
At present the build rule for pylibfdt depends on _libfdt.so but modern Python versions add a different suffix to the output file, resulting in something like _libfdt.cpython-38-x86_64-linux-gnu.so The result is that pylibfdt is rebuilt every time. Rename the file the standard name so that the ru

Re: [PATCH v2 2/6] Makefile: Avoid running dtoc every time

2021-03-25 Thread Simon Glass
Since the dst_dir rule always runs, it causes a rebuild of the of-platdata files even if not needed. Create the directory inside the rule instead. Signed-off-by: Simon Glass --- (no changes since v1) scripts/Makefile.spl | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) Appl

Re: [PATCH v2 4/6] dtoc: Only generate the required files

2021-03-25 Thread Simon Glass
At present all possible files are generated, even if some of them just have a header and an empty body. It is better to generate only the files that are needed, so that the two types of build (based on the setting of OF_PLATDATA_INST) can be mutually exclusive. This is intended to fix a strange pr

Re: [PATCH v2 3/6] Makefile: Depend only on required of-platdata files

2021-03-25 Thread Simon Glass
When OF_PLATDATA_INST is enabled, we need dt-uclass.c and dt-device.c for the build to work. When OF_PLATDATA_INST is not enabled, we only need dt-plat.c Update the Makefile rules to indicate this. At present all files are generated and compiled regardless of which are actually needed. Signed-of

Re: [PATCH v2 6/6] Makefile: Remove old of-platdata files before regenerating

2021-03-25 Thread Simon Glass
Which files we generate depends on the setting of OF_PLATDATA_INST in the build. This might change between builds, but the build directory may be reused. Leaving old files around is confusing and switching the OF_PLATDATA_INST setting does not necessarily regenerate the files, e.g. if the devicetr

[PATCH v2 6/6] Convert CONFIG_MISC_INIT_F to Kconfig

2021-03-25 Thread Simon Glass
This converts the following to Kconfig: CONFIG_MISC_INIT_F Signed-off-by: Simon Glass Reviewed-by: Stefan Roese --- (no changes since v1) common/Kconfig | 6 ++ configs/MPC8349ITXGP_defconfig | 1 + configs/MPC8349ITX_LOWBOOT_defconfig | 1 + configs/MPC8349

[PATCH v2 5/6] moveconfig: Handle binary files cleanly

2021-03-25 Thread Simon Glass
Some files are not actually source code and thus can produce unicode errors. Report this and continue. Signed-off-by: Simon Glass --- (no changes since v1) tools/moveconfig.py | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/tools/moveconfig.py b/tools/move

[PATCH v2 4/6] log: Fix up debug_cond() when LOG is enabled

2021-03-25 Thread Simon Glass
At present debug() statements can cause debuf output to appear when LOG is enabled but DEBUG is not. This is not intended and it seems that the condition is wrong. Fix it. Signed-off-by: Simon Glass --- (no changes since v1) include/log.h | 11 +++ 1 file changed, 7 insertions(+), 4 d

[PATCH v2 3/6] dtoc: Improve handling of reg properties

2021-03-25 Thread Simon Glass
This existing code assumes that a reg property is larger than one cell, but this is not always the case. Fix this assumption. Also if a node's parent is missing the #address-cells and #size-cells properties we use 2 as a default for each. But this should not happen in practice. More likely the pro

[PATCH v2 2/6] dtoc: Adjust detection of 64-bit properties

2021-03-25 Thread Simon Glass
At present an empty size is considered to be a 64-bit value. This does not seem useful and wastes space. Limit the 64-bit detection to where one or both of the addr/size is two cells or more. Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to adjust detection of 64-bit properties

[PATCH v2 1/6] dtoc: Show driver warnings once at the end

2021-03-25 Thread Simon Glass
At present warnings are shown as soon as they are discovered in the source scannner. But the function that detects them may be called multiple times. Collect all the warnings and show them at the end. Signed-off-by: Simon Glass --- (no changes since v1) tools/dtoc/dtb_platdata.py | 6 --

[PATCH v2 0/6] misc: Various misc patches

2021-03-25 Thread Simon Glass
This series includes some minor tools updates and conversion of CONFIG_MISC_INIT_F to Kconfig. Changes in v2: - Add new patch to adjust detection of 64-bit properties - Drop the reg_val temporary var - Add two new tests Simon Glass (6): dtoc: Show driver warnings once at the end dtoc: Adjust

[PATCH 1/2] freescale: ls1021atwr: Drop use of CONFIG_RESET

2021-03-25 Thread Simon Glass
It is not recommended to use CONFIG_xxx defines for things which are not Kconfig options. Rename this. Signed-off-by: Simon Glass --- board/freescale/ls1021atwr/ls1021atwr.c | 8 scripts/config_whitelist.txt| 1 - 2 files changed, 4 insertions(+), 5 deletions(-) diff --git

[PATCH v2] dm: test: Always include command.h for print_ut

2021-03-25 Thread Sean Anderson
We need this header for U_BOOT_CMD, which is always present even without EFI. Fixes: 82c468a049 ("dm: test: Update Makefile conditions") Signed-off-by: Sean Anderson --- Changes in v2: - Remove ifdef test/print_ut.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/test/print_ut.c b/test/p

Re: [PATCH 2/3] test: Allow tests to run on any board

2021-03-25 Thread Sean Anderson
On 3/24/21 5:44 PM, Simon Glass wrote: Due to a recent change, tests are limited to running on sandbox only. Correct this so that any architecture can run them. Signed-off-by: Simon Glass Reported-by: Sean Anderson Fixes: c79705ea938 ("test: Move dm_test_init() into test-main.c") --- includ

Re: [PATCH v4 2/2] test: unit test for longjmp

2021-03-25 Thread Leo Liang
On Thu, Mar 25, 2021 at 03:31:50PM +0800, Heinrich Schuchardt wrote: > Provide a unit test for the longjmp() library function > > Signed-off-by: Heinrich Schuchardt > > v4: > use volatile for variable changed between setjmp and longjmp > v3: > check variable on stack > v2: >

[PATCH] buildman: Add an encoding to the out-env file

2021-03-25 Thread Simon Glass
The environment may contain some unicode characters. At least that is what seemed to happen on one commit: Building current source for 1 boards (0 threads, 64 jobs per thread) 000 /1 -1 (starting) Traceback (most recent call last): File ".../tools/buildman/buildman", line

Re: [RFC PATCH v2 1/2] arch: riscv: cpu: Add callback to init each core

2021-03-25 Thread Sean Anderson
On 3/25/21 9:22 PM, Leo Liang wrote: Hi Green, On Tue, Mar 23, 2021 at 01:35:38AM -0700, Green Wan wrote: Add a callback riscv_hart_early_init() to ./arch/riscv/cpu/start.S to allow different riscv hart perform setup code for each hart as early as possible. Since all the harts enter the calback

Re: [RFC PATCH v2 1/2] arch: riscv: cpu: Add callback to init each core

2021-03-25 Thread Leo Liang
Hi Green, On Tue, Mar 23, 2021 at 01:35:38AM -0700, Green Wan wrote: > Add a callback riscv_hart_early_init() to ./arch/riscv/cpu/start.S to > allow different riscv hart perform setup code for each hart as early > as possible. Since all the harts enter the calback, they must be able > to run the s

Re: [PATCH v3] dm: i2c: Add a migration method for I2C

2021-03-25 Thread Simon Glass
Hi Tom, On Fri, 26 Mar 2021 at 13:14, Tom Rini wrote: > > On Thu, Mar 25, 2021 at 06:45:35PM -0400, Tom Rini wrote: > > On Fri, Mar 26, 2021 at 08:41:42AM +1300, Simon Glass wrote: > > > Hi Tom, > > > > > > On Fri, 26 Mar 2021 at 08:30, Tom Rini wrote: > > > > > > > > On Fri, Mar 26, 2021 at 08:

Re: [PATCH v3] dm: i2c: Add a migration method for I2C

2021-03-25 Thread Tom Rini
On Thu, Mar 25, 2021 at 06:45:35PM -0400, Tom Rini wrote: > On Fri, Mar 26, 2021 at 08:41:42AM +1300, Simon Glass wrote: > > Hi Tom, > > > > On Fri, 26 Mar 2021 at 08:30, Tom Rini wrote: > > > > > > On Fri, Mar 26, 2021 at 08:11:30AM +1300, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Fr

[PATCH 6/6] net: octeontx: smi: fix mii probe

2021-03-25 Thread Tim Harvey
The fdt node offset is apparently not set properly when probed causing no MDIO busses to be found. Fix this by obtaining the offset. Signed-off-by: Tim Harvey --- drivers/net/octeontx/smi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/octeontx/smi.c b/drivers/net/octeontx/sm

[PATCH 5/6] drivers: ata: ahci: update max id if it is more than available ports

2021-03-25 Thread Tim Harvey
From: Suneel Garapati After check for maximum between max id and available ports, also check if available port count is less than max id and update. In the case of the CN8030 OcteonTX SoC max_id needs to be reduced to the number of ports found otherwise the following occurs on a scan: GW6404-B>

[PATCH 4/6] drivers: net: octeontx: fix QSGMII

2021-03-25 Thread Tim Harvey
Revert a change that occured between the Marvell SDK-10.1.1.0 and SDK-10.3.1.1 which broke QSMII phy support. Signed-off-by: Tim Harvey --- drivers/net/octeontx/bgx.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/net/octeontx/bgx.c b/drivers/ne

[PATCH 2/6] arm: octeontx: support generic distro config

2021-03-25 Thread Tim Harvey
Support Generic Distro Default config Signed-off-by: Tim Harvey --- include/configs/octeontx_common.h | 31 ++- 1 file changed, 26 insertions(+), 5 deletions(-) diff --git a/include/configs/octeontx_common.h b/include/configs/octeontx_common.h index 55d329f55e..434e

[PATCH 3/6] arm: octeontx: enable WDT_SBSA

2021-03-25 Thread Tim Harvey
The OcteonTX uses ARM's SBSA Watchdog device Signed-off-by: Tim Harvey --- configs/octeontx_81xx_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/octeontx_81xx_defconfig b/configs/octeontx_81xx_defconfig index 9881c1089b..bcf03db406 100644 --- a/configs/octeontx_81xx_defconf

[PATCH 1/6] arm: octeontx: move CONFIG_SUPPORT_RAW_INITRD to configs

2021-03-25 Thread Tim Harvey
Move CONFIG_SUPPORT_RAW_INITRD out of the octeontx_common header and into the defconfig files. Signed-off-by: Tim Harvey --- configs/octeontx_81xx_defconfig | 1 + configs/octeontx_83xx_defconfig | 1 + include/configs/octeontx_common.h | 2 -- 3 files changed, 2 insertions(+), 2 deletions(-

[PATCH 0/6] octeontx cleanup and fixes

2021-03-25 Thread Tim Harvey
This series provides the following for octeontx: - cleanup to the octeontx common header file by moving CONFIG_SUPPORT_RAW_INITRD to defconfig files, - adds generic distro config support - add missing SBSA watchdog to config - fix an issue found with QML connected to a QSGMII PHY - fix an issue

Re: [PATCH 6/8] configs: remove obsolete CONFIG_MVEBU_MMC

2021-03-25 Thread Simon Glass
On Fri, 26 Mar 2021 at 02:48, Harm Berntsen wrote: > > All usages of this have been removed > > Signed-off-by: Harm Berntsen > CC: Simon Glass > --- > > scripts/config_whitelist.txt | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Simon Glass

Re: [PATCH 5/8] configs: remove obsolete CONFIG_SYS_MMC_BASE

2021-03-25 Thread Simon Glass
On Fri, 26 Mar 2021 at 02:47, Harm Berntsen wrote: > > All usages of this have been removed > > Signed-off-by: Harm Berntsen > CC: Simon Glass > --- > > scripts/config_whitelist.txt | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Simon Glass

Re: [PATCH 7/8] mmc: mvebu: convert to driver model

2021-03-25 Thread Simon Glass
On Fri, 26 Mar 2021 at 02:48, Harm Berntsen wrote: > > This is a straightforward conversion of the old, non-dm driver. It was > done in-place as the deadline for non-dm MMC has passed. Previous > commits ensured that no board depends on the old, non-dm variant. > Tested > on a Kirkwood based board

Re: [PATCH v2 2/2] mmc: mmc-uclass: Use dev_seq() to read aliases node's index

2021-03-25 Thread Jaehoon Chung
On 3/25/21 4:18 PM, Aswath Govindraju wrote: > Use dev_seq() to read aliases node's index and pass it as device number > for creating bulk device. > > Suggested-by: Grygorii Strashko > Signed-off-by: Aswath Govindraju Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > drivers/mm

Re: [PATCH 7/8] mmc: mvebu: convert to driver model

2021-03-25 Thread Jaehoon Chung
Dear Harm, On 3/25/21 10:48 PM, Harm Berntsen wrote: > This is a straightforward conversion of the old, non-dm driver. It was > done in-place as the deadline for non-dm MMC has passed. Previous > commits ensured that no board depends on the old, non-dm variant. > Tested > on a Kirkwood based board

Re: [PATCH v3 1/2] power: regulator: add driver for ANATOP regulator

2021-03-25 Thread Jaehoon Chung
On 3/26/21 5:32 AM, Sean Anderson wrote: > > > On 3/25/21 2:44 PM, Ying-Chun Liu wrote: >> From: "Ying-Chun Liu (PaulLiu)" >> >> Anatop is an integrated regulator inside i.MX6 SoC. >> There are 3 digital regulators which controls PU, CORE (ARM), and SOC. >> And 3 analog regulators which controls

Re: [PATCH v3] dm: i2c: Add a migration method for I2C

2021-03-25 Thread Tom Rini
On Fri, Mar 26, 2021 at 08:41:42AM +1300, Simon Glass wrote: > Hi Tom, > > On Fri, 26 Mar 2021 at 08:30, Tom Rini wrote: > > > > On Fri, Mar 26, 2021 at 08:11:30AM +1300, Simon Glass wrote: > > > Hi Tom, > > > > > > On Fri, 26 Mar 2021 at 08:05, Tom Rini wrote: > > > > > > > > On Fri, Mar 26, 20

Re: [PATCH] usb: eth: add print of device name on usb_ether registration

2021-03-25 Thread Tim Harvey
On Thu, Mar 25, 2021 at 10:40 AM Marek Vasut wrote: > > On 3/25/21 6:38 PM, Tim Harvey wrote: > > On Thu, Mar 25, 2021 at 10:06 AM Marek Vasut wrote: > >> > >> On 3/25/21 5:56 PM, Tim Harvey wrote: > >>> When a USB Ethernet device is detected and registered there is no > >>> way to know the devic

Re: [PATCH 3/3] snow: Enable unit tests

2021-03-25 Thread Jaehoon Chung
On 3/25/21 6:44 AM, Simon Glass wrote: > It is useful to have a board with unit tests enabled, to check that this > does not break. > > Let's choose snow, since it is not under active development and it is > glorious. > > Signed-off-by: Simon Glass Reviewed-by: Jaehoon Chung Best Regards, Jae

Re: [PATCH 1/3] samsung: exynos: Convert SROMC interface to a driver

2021-03-25 Thread Jaehoon Chung
On 3/25/21 6:44 AM, Simon Glass wrote: > Add a bus driver for this and use it to configure the bus parameters for > the Ethernet interface. Drop the old pre-driver-model code. > > Switch over to use driver model for Ethernet. > > Signed-off-by: Simon Glass Reviewed-by: Jaehoon Chung Best Rega

Pull request for efi-next

2021-03-25 Thread Heinrich Schuchardt
Dear Tom, a lot of patches in this pull-request are already in origin/master. The rest is summarized in the tag description. Gitlab CI showed no issues: https://source.denx.de/u-boot/custodians/u-boot-efi/-/pipelines/6913 Please, merge into the *next* branch: The following changes since commit

Re: [PATCH v3 2/2] doc: device-tree-bindings: regulator: anatop regulator

2021-03-25 Thread Sean Anderson
On 3/25/21 2:44 PM, Ying-Chun Liu wrote: From: "Ying-Chun Liu (PaulLiu)" Document the bindings for fsl,anatop-regulator Signed-off-by: Ying-Chun Liu (PaulLiu) Cc: Fabio Estevam Cc: Jaehoon Chung Cc: Peng Fan Cc: Sean Anderson --- .../regulator/fsl,anatop-regulator.txt| 45 +++

Re: [PATCH v3 1/2] power: regulator: add driver for ANATOP regulator

2021-03-25 Thread Sean Anderson
On 3/25/21 2:44 PM, Ying-Chun Liu wrote: > From: "Ying-Chun Liu (PaulLiu)" > > Anatop is an integrated regulator inside i.MX6 SoC. > There are 3 digital regulators which controls PU, CORE (ARM), and SOC. > And 3 analog regulators which controls 1P1, 2P5, 3P0 (USB). > This patch adds the Anatop

Re: [PATCH] efi_loader: Clean up file size calculations

2021-03-25 Thread Heinrich Schuchardt
On 3/25/21 8:55 PM, Ilias Apalodimas wrote: We recently added a common function for calculating file size, instead of copy pasting the code around. Switch one of the occurences over to the common function Signed-off-by: Ilias Apalodimas Reviewed-by: Heinrich Schuchardt

[PATCH] efi_loader: Clean up file size calculations

2021-03-25 Thread Ilias Apalodimas
We recently added a common function for calculating file size, instead of copy pasting the code around. Switch one of the occurences over to the common function Signed-off-by: Ilias Apalodimas --- lib/efi_loader/efi_boottime.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions

Re: [PATCH v3] dm: i2c: Add a migration method for I2C

2021-03-25 Thread Simon Glass
Hi Tom, On Fri, 26 Mar 2021 at 08:30, Tom Rini wrote: > > On Fri, Mar 26, 2021 at 08:11:30AM +1300, Simon Glass wrote: > > Hi Tom, > > > > On Fri, 26 Mar 2021 at 08:05, Tom Rini wrote: > > > > > > On Fri, Mar 26, 2021 at 06:48:26AM +1300, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Fri

Re: Bug tracking

2021-03-25 Thread Pratyush Yadav
On 25/03/21 11:14AM, Simon Glass wrote: > Hi, > > What do people think of setting up a bug tracker on gitlab.com or > github.com? They both allow anyone to register and thus file bugs. You would need people to maintain the bugs that are reported in the tracker. Asking for clear, reproducible inf

Re: [PATCH v3] dm: i2c: Add a migration method for I2C

2021-03-25 Thread Tom Rini
On Fri, Mar 26, 2021 at 08:11:30AM +1300, Simon Glass wrote: > Hi Tom, > > On Fri, 26 Mar 2021 at 08:05, Tom Rini wrote: > > > > On Fri, Mar 26, 2021 at 06:48:26AM +1300, Simon Glass wrote: > > > Hi Tom, > > > > > > On Fri, 26 Mar 2021 at 04:59, Tom Rini wrote: > > > > > > > > On Thu, Mar 25, 20

Re: [PATCH v3] dm: i2c: Add a migration method for I2C

2021-03-25 Thread Simon Glass
Hi Tom, On Fri, 26 Mar 2021 at 08:05, Tom Rini wrote: > > On Fri, Mar 26, 2021 at 06:48:26AM +1300, Simon Glass wrote: > > Hi Tom, > > > > On Fri, 26 Mar 2021 at 04:59, Tom Rini wrote: > > > > > > On Thu, Mar 25, 2021 at 01:39:28PM +1300, Simon Glass wrote: > > > > > > > This probably should hav

Re: [PATCH v3] dm: i2c: Add a migration method for I2C

2021-03-25 Thread Tom Rini
On Fri, Mar 26, 2021 at 06:48:26AM +1300, Simon Glass wrote: > Hi Tom, > > On Fri, 26 Mar 2021 at 04:59, Tom Rini wrote: > > > > On Thu, Mar 25, 2021 at 01:39:28PM +1300, Simon Glass wrote: > > > > > This probably should have been done a while back since it is a core > > > system. Add a migration

[PATCH v3 2/2] doc: device-tree-bindings: regulator: anatop regulator

2021-03-25 Thread Ying-Chun Liu
From: "Ying-Chun Liu (PaulLiu)" Document the bindings for fsl,anatop-regulator Signed-off-by: Ying-Chun Liu (PaulLiu) Cc: Fabio Estevam Cc: Jaehoon Chung Cc: Peng Fan Cc: Sean Anderson --- .../regulator/fsl,anatop-regulator.txt| 45 +++ 1 file changed, 45 insertions

[PATCH v3 1/2] power: regulator: add driver for ANATOP regulator

2021-03-25 Thread Ying-Chun Liu
From: "Ying-Chun Liu (PaulLiu)" Anatop is an integrated regulator inside i.MX6 SoC. There are 3 digital regulators which controls PU, CORE (ARM), and SOC. And 3 analog regulators which controls 1P1, 2P5, 3P0 (USB). This patch adds the Anatop regulator driver. Signed-off-by: Ying-Chun Liu (PaulLi

[PATCH v3 0/2] power: regulator: add driver for ANATOP regulator

2021-03-25 Thread Ying-Chun Liu
From: "Ying-Chun Liu (PaulLiu)" Anatop is an integrated regulator inside i.MX6 SoC. There are 3 digital regulators which controls PU, CORE (ARM), and SOC. And 3 analog regulators which controls 1P1, 2P5, 3P0 (USB). This patch adds the Anatop regulator driver. Ying-Chun Liu (PaulLiu) (2): power

Re: [PATCH v3] dm: i2c: Add a migration method for I2C

2021-03-25 Thread Simon Glass
Hi Tom, On Fri, 26 Mar 2021 at 04:59, Tom Rini wrote: > > On Thu, Mar 25, 2021 at 01:39:28PM +1300, Simon Glass wrote: > > > This probably should have been done a while back since it is a core > > system. Add a migration deadline of later this year, to catch the > > stragglers. > > > > Signed-off

Re: [PATCH V2] spi: Update speed/mode on change

2021-03-25 Thread Marek Vasut
On 2/26/21 3:21 PM, Marek Vasut wrote: The spi_get_bus_and_cs() may be called on the same bus and chipselect with different frequency or mode. This is valid usecase, but the code fails to notify the controller of such a configuration change. Call spi_set_speed_mode() in case bus frequency or bus

Re: [PATCH] usb: eth: add print of device name on usb_ether registration

2021-03-25 Thread Marek Vasut
On 3/25/21 6:38 PM, Tim Harvey wrote: On Thu, Mar 25, 2021 at 10:06 AM Marek Vasut wrote: On 3/25/21 5:56 PM, Tim Harvey wrote: When a USB Ethernet device is detected and registered there is no way to know the device-name in order to use it with the ethact env variable. Add a print to displa

Re: [PATCH] usb: eth: add print of device name on usb_ether registration

2021-03-25 Thread Tim Harvey
On Thu, Mar 25, 2021 at 10:06 AM Marek Vasut wrote: > > On 3/25/21 5:56 PM, Tim Harvey wrote: > > When a USB Ethernet device is detected and registered there is no > > way to know the device-name in order to use it with the ethact > > env variable. > > > > Add a print to display the device name th

Re: [PATCH] usb: eth: add print of device name on usb_ether registration

2021-03-25 Thread Marek Vasut
On 3/25/21 5:56 PM, Tim Harvey wrote: When a USB Ethernet device is detected and registered there is no way to know the device-name in order to use it with the ethact env variable. Add a print to display the device name that is registered. Example using an AX88x72A USB Ethernet device: GW6404-

[PATCH] usb: eth: add print of device name on usb_ether registration

2021-03-25 Thread Tim Harvey
When a USB Ethernet device is detected and registered there is no way to know the device-name in order to use it with the ethact env variable. Add a print to display the device name that is registered. Example using an AX88x72A USB Ethernet device: GW6404-B> usb start starting USB... Bus xhci_pc

Re: [PATCH] dfu: dfu_sf: avoid double free of SPI device

2021-03-25 Thread Lukasz Majewski
On Wed, 24 Mar 2021 18:21:37 +0100 Heinrich Schuchardt wrote: > On 19.03.21 00:55, Heinrich Schuchardt wrote: > > Multiple DFU entities may share the same SPI device. We must make > > sure that the SPI device is only freed once. > > > > When using the driver model it is not necessary to free the

Re: [PATCH v3] dm: i2c: Add a migration method for I2C

2021-03-25 Thread Tom Rini
On Thu, Mar 25, 2021 at 01:39:28PM +1300, Simon Glass wrote: > This probably should have been done a while back since it is a core > system. Add a migration deadline of later this year, to catch the > stragglers. > > Signed-off-by: Simon Glass What boards trigger this warning when done on top o

Re: [PATCH 4/4] ram: stm32: fix strsep failed on read only memory

2021-03-25 Thread Patrice CHOTARD
Hi Dillon On 3/11/21 7:44 AM, dillon.min...@gmail.com wrote: > From: dillon min > > strsep will change data from original memory address, > in case the memory is in non-sdram/sram place, will > run into a bug(hang at SDRAM: ) > > just add a temporary array to store bank_name[] to fix this > bug

Re: [PATCH 3/4] board: Add rt-thread art-pi board support

2021-03-25 Thread Patrice CHOTARD
Hi Dillon some remarks below On 3/11/21 7:43 AM, dillon.min...@gmail.com wrote: > From: dillon min > > This patch adds support for rt-thread art-pi board. > > for more information about art-pi, please goto: > https://art-pi.gitee.io/website/ > Signed-off-by: dillon min > --- > arch/arm/mach-

Re: [PATCH 2/4] ARM: dts: stm32: Add RT-Thread art-pi board support

2021-03-25 Thread Patrice CHOTARD
Some remarks below On 3/11/21 7:43 AM, dillon.min...@gmail.com wrote: > From: dillon min > > All these files are add for support rt-thread art-pi board > > the detail board information can be found at: > https://art-pi.gitee.io/website/ > > board resources: > - stm32h750xbh6 128k flash, 1024k

[PATCH RFT v2 4/4] pci: add Amlogic Meson Designware PCIe controller

2021-03-25 Thread Neil Armstrong
Add support for the DW PCIe controller found in the Amlogic Meson AXG and G12 (G12A, G12B, SM1) SoCs. This uses the common DW PCIe helpers introducted previously. Signed-off-by: Neil Armstrong --- drivers/pci/Kconfig | 8 + drivers/pci/Makefile| 1 + drivers/pci/pcie_dw_meson

[PATCH RFT v2 3/4] pci: pcie_dw_rockchip: migrate to common Designware PCIe functions

2021-03-25 Thread Neil Armstrong
Migrate the dw_rockchip driver to use the common DW PCIe helpers. Signed-off-by: Neil Armstrong --- drivers/pci/Kconfig| 2 +- drivers/pci/pcie_dw_rockchip.c | 472 ++--- 2 files changed, 30 insertions(+), 444 deletions(-) diff --git a/drivers/pci/Kconf

[PATCH RFT v2 2/4] pci: pcie_dw_ti: migrate to common Designware PCIe functions

2021-03-25 Thread Neil Armstrong
Migrate the dw_ti driver to use the common DW PCIe helpers. Signed-off-by: Neil Armstrong --- drivers/pci/Kconfig | 2 +- drivers/pci/pcie_dw_ti.c | 444 --- 2 files changed, 38 insertions(+), 408 deletions(-) diff --git a/drivers/pci/Kconfig b/drivers

[PATCH RFT v2 1/4] pci: add common Designware PCIe functions

2021-03-25 Thread Neil Armstrong
With the introduction of pcie_dw_rockchip, and need to support the DW PCIe in the Amlogic AXG & G12 SoCs, most of the DW PCIe helpers would be duplicated. This introduce a "common" DW PCIe helpers file with common code merged from the dw_ti and dw_rockchip drivers and adapted to fit with the upco

[PATCH RFT v2 0/4] pci: add common Designware PCIe functions and support Amlogic Meson PCIe controller

2021-03-25 Thread Neil Armstrong
With the introduction of pcie_dw_rockchip, and need to support the DW PCIe in the Amlogic AXG & G12 SoCs, most of the DW PCIe helpers would be duplicated. This introduce a "common" DW PCIe helpers file with common code merged from the dw_ti and dw_rockchip drivers and adapted to fit with the upco

Re: [PATCH 1/4] ARM: dts: stm32: split sdram pin & timing parameter into specific board dts

2021-03-25 Thread Patrice CHOTARD
Hi Dillon On 3/11/21 7:43 AM, dillon.min...@gmail.com wrote: > From: dillon min > > As different boards has their own sdram hw connection, mount different > sdram modules, so move sdram timing parameter and pin configuration > to their board device tree. > > Signed-off-by: dillon min > --- >

Re: [PATCH 0/4] Add rt-thread art-pi board support

2021-03-25 Thread Patrice CHOTARD
Hi Dillon One general remark, i saw that you have submitted a similar serie on kernel side to add rt_thread art-pi board support. On this kernel series, you split the DT pinctrl files by introducing stm32h7-pinctrl.dtsi file. Can you apply the same device tree files split between kernel and u-bo

Re: SAMA5D3 Xplained: SPL broken after panic added to /lib/time.c:94

2021-03-25 Thread Claudiu.Beznea
On 23.03.2021 18:54, Manuel Luís Reis wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hi again, > >> There are timers on the board. How come it used to work, before the >> commit that breaks it ? >> >> I understand that nobody registers a

Re: [PATCH RFT 1/4] pci: add common Designware PCIe functions

2021-03-25 Thread Neil Armstrong
Hi, On 25/03/2021 11:37, Green Wan wrote: > Hi Neil, > > I gave it a try today. I think the patch is good and I would like to > add some comments quickly before I finish the rest of the tests. See > my comments below. Thanks, Thanks for testing ! > > On Mon, Mar 22, 2021 at 5:41 PM Bin Meng w

Re: [PATCH v2 1/2] power: regulator: add driver for ANATOP regulator

2021-03-25 Thread Sean Anderson
On 3/23/21 10:01 PM, Ying-Chun Liu (PaulLiu) wrote: Hi Sean, Thanks for the review. I fix almost of the issues. Will upload the v3 soon. Still have some questions. Sean Anderson 於 2021/3/23 下午11:06 寫道: if (anatop_reg->supply) {     ret = regulator_set_value(anatop_reg->supply

Re: [PATCH 00/11] imx: ventana: convert Gateworks Ventana to dm

2021-03-25 Thread Tim Harvey
On Mon, Mar 1, 2021 at 2:33 PM Tim Harvey wrote: > > This is the first series converting the IMX6 basd Gateworks Ventana > boards to driver-model. > > This series resolves some issues with NAND SPL (non DM SPL) in order > to read the FIT image. Additionally it covers conversions to DM_USB, > DM_MM

[PATCH 8/8] configs: sheevaplug: enable driver-model based MMC

2021-03-25 Thread Harm Berntsen
Signed-off-by: Harm Berntsen CC: Prafulla Wadaskar CC: Stefan Roese CC: Tom Rini ---  configs/sheevaplug_defconfig | 2 ++  1 file changed, 2 insertions(+) diff --git a/configs/sheevaplug_defconfig b/configs/sheevaplug_defconfig index 34da356b8e..65d8dff7ff 100644 --- a/configs/sheevaplug_defc

[PATCH 7/8] mmc: mvebu: convert to driver model

2021-03-25 Thread Harm Berntsen
This is a straightforward conversion of the old, non-dm driver. It was done in-place as the deadline for non-dm MMC has passed. Previous commits ensured that no board depends on the old, non-dm variant. Tested on a Kirkwood based board with eMMC. Signed-off-by: Harm Berntsen Tested-by: Harm Bernt

[PATCH 2/8] configs: openrd: remove non-dm MMC driver

2021-03-25 Thread Harm Berntsen
Unfortunately this board has no DM support at all. We are also way past the deadline for driver model support for various devices on this board. Signed-off-by: Harm Berntsen CC: Stefan Roese CC: Tom Rini ---  include/configs/openrd.h | 5 -  1 file changed, 5 deletions(-) diff --git a/incl

[PATCH 6/8] configs: remove obsolete CONFIG_MVEBU_MMC

2021-03-25 Thread Harm Berntsen
All usages of this have been removed Signed-off-by: Harm Berntsen CC: Simon Glass ---  scripts/config_whitelist.txt | 1 -  1 file changed, 1 deletion(-) diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt index 1e27373e5b..2fdee6be65 100644 --- a/scripts/config_whitelist.t

[PATCH 5/8] configs: remove obsolete CONFIG_SYS_MMC_BASE

2021-03-25 Thread Harm Berntsen
All usages of this have been removed Signed-off-by: Harm Berntsen CC: Simon Glass ---  scripts/config_whitelist.txt | 1 -  1 file changed, 1 deletion(-) diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt index 85857a746c..1e27373e5b 100644 --- a/scripts/config_whitelist.t

[PATCH 4/8] ARM: kirkwood: remove non-dm MMC driver init

2021-03-25 Thread Harm Berntsen
No board uses this driver any more: remove it. Signed-off-by: Harm Berntsen CC: Gerald Kerma CC: Stefan Roese CC: Pantelis Antoniou ---  arch/arm/mach-kirkwood/cpu.c | 7 ---  1 file changed, 7 deletions(-) diff --git a/arch/arm/mach-kirkwood/cpu.c b/arch/arm/mach-kirkwood/cpu.c index 9c8

  1   2   >