Re: [PATCH v4 0/3] binman: Further updates for FIT support

2020-09-13 Thread Michal Simek
On 12. 09. 20 22:43, Samuel Holland wrote: > On 9/7/20 3:44 AM, Michal Simek wrote: >> Hi Simon, >> >> On 06. 09. 20 18:39, Simon Glass wrote: >>> This series adds support for help messages when binary blobs are missing, >>> as well as selecting the default FIT configuration. >>> >>> It includes

[PATCH v2 5/5] configs: Add spiboot support for am335x

2020-09-13 Thread Faiz Abbas
am335x internal SRAM is too small to support the addition of SPI bootmode to the default defconfig. Add a separate spiboot_defconfig Signed-off-by: Faiz Abbas --- board/ti/am335x/MAINTAINERS | 1 + configs/am335x_evm_spiboot_defconfig | 93 2 files changed,

[PATCH v2 1/5] arm: dts: am335x-icev2: Add spi node

2020-09-13 Thread Faiz Abbas
Add spi and spi nor flash nodes for am335x-icev2. Signed-off-by: Faiz Abbas --- arch/arm/dts/am335x-icev2.dts | 50 +++ 1 file changed, 50 insertions(+) diff --git a/arch/arm/dts/am335x-icev2.dts b/arch/arm/dts/am335x-icev2.dts index 37484cb6f5..2a1b3a53e9 100644

[PATCH v2 4/5] spi: omap3_spi: Read platform data in ofdata_to_platdata()

2020-09-13 Thread Faiz Abbas
Add an ofdata_to_platdata() callback to access dts in U-boot and access all platform data in it. This prepares the driver for supporting both device tree as well as static platform data structures in SPL. Signed-off-by: Faiz Abbas --- drivers/spi/omap3_spi.c | 37 ++--

[PATCH v2 0/5] Add spi boot support to am335x-icev2

2020-09-13 Thread Faiz Abbas
The following patches add spi boot support to TI's am335x-icev2 platform v2: 1. Changed order of patches to avoid breaking build 2. Changed SPI_OFFSET to SPI0_OFFSET and moved the define arch/arm/mach-omap2/am335x/board.c 3. Updated MAINTAINERS list with the new defconfig. Faiz Abbas (5): a

[PATCH v2 3/5] arm: mach-omap2: am33xx: Add device structure for spi

2020-09-13 Thread Faiz Abbas
Add platform data and a device structure for the spi device present on am335x-icev2. This requires moving all omap3_spi platform data structures and symbols to an omap3_spi.h so that the board file can access them. Signed-off-by: Faiz Abbas --- arch/arm/mach-omap2/am33xx/board.c | 18 +++ dr

[PATCH v2 2/5] spi: spi-uclass: Block dm_scan_fdt_dev with OF_CONTROL to prevent build failures

2020-09-13 Thread Faiz Abbas
There are devices which don't use OF_CONTROL or OF_PLATDATA but instead rely on statically defined platdata. Block dm_scan_fdt_dev() with both configs to avoid build failures under this condition. Signed-off-by: Faiz Abbas Reviewed-by: Jagan Teki --- drivers/spi/spi-uclass.c | 2 +- 1 file chan

Re: [PATCH] riscv: Only enable OF_BOARD_FIXUP for S-Mode

2020-09-13 Thread Bin Meng
On Sat, Sep 12, 2020 at 2:25 AM Sean Anderson wrote: > > On 9/11/20 10:43 AM, Bin Meng wrote: > > On Fri, Sep 11, 2020 at 6:20 PM Sean Anderson wrote: > >> > >> On 9/11/20 3:29 AM, Bin Meng wrote: > >>> Hi Sean, > >>> > >>> On Sat, Sep 5, 2020 at 9:22 PM Sean Anderson wrote: > > It is

Re: [PATCH 3/7] riscv: Use NULL as a sentinel value for smp_call_function

2020-09-13 Thread Bin Meng
Hi Leo, On Mon, Sep 14, 2020 at 2:10 PM Leo Liang wrote: > > Hi, Bin > On Mon, Sep 14, 2020 at 10:07:57AM +0800, Bin Meng wrote: > > Hi Leo, > > > > On Mon, Sep 14, 2020 at 9:58 AM Leo Liang wrote: > > > > > > On Fri, Sep 11, 2020 at 04:04:13PM +0800, Bin Meng wrote: > > > > On Tue, Sep 8, 2020

Re: [PATCH 7/7] riscv: Add some comments to start.S

2020-09-13 Thread Bin Meng
On Tue, Sep 8, 2020 at 2:17 AM Sean Anderson wrote: > > This adds comments regarding the ordering and purpose of certain > instructions as I understand them. > > Signed-off-by: Sean Anderson > --- > > arch/riscv/cpu/start.S | 19 +-- > 1 file changed, 17 insertions(+), 2 deletion

Re: [PATCH 6/7] riscv: Ensure gp is NULL or points to valid data

2020-09-13 Thread Bin Meng
On Tue, Sep 8, 2020 at 2:17 AM Sean Anderson wrote: > > This allows code to use a construct like `if (gd & gd->...) { ... }` when > accessing the global data pointer. Without this change, it was possible for > a very early trap to cause _exit_trap to read arbitrary memory. This could > cause a sec

Re: [PATCH 3/7] riscv: Use NULL as a sentinel value for smp_call_function

2020-09-13 Thread Rick Chen
Hi Sean > On 9/9/20 5:01 AM, Rick Chen wrote: > > Hi Sean > > > >> Hi Sean > >> > >>> Some IPIs may already be pending when U-Boot is started. This could be a > >>> problem if a secondary hart tries to handle an IPI before the boot hart > >>> has > >>> initialized the IPI device. > >>> > >>> This

Re: [PATCH 1/7] Revert "riscv: Clear pending interrupts before enabling IPIs"

2020-09-13 Thread Rick Chen
HI Sean > On 9/11/20 10:45 AM, Bin Meng wrote: > > On Fri, Sep 11, 2020 at 6:22 PM Sean Anderson wrote: > >> > >> On 9/11/20 3:38 AM, Bin Meng wrote: > >>> Hi Sean, > >>> > >>> On Tue, Sep 8, 2020 at 2:17 AM Sean Anderson wrote: > > Clearing MIP doesn't do anything. Whoops. The followi

[PATCH v2 2/4] xhci.c: Add polling support for USB keyboards

2020-09-13 Thread Jason Wessel
The xhci driver was causing intermittent 5 second delays from the USB keyboard polling hook. Executing something like a "sleep 1" for example would sleep for 5 seconds, unless an event occurred on the USB bus to shorten the delay. Modeled after the code in the DWC2 driver, a nonblock state was ad

[PATCH v2 3/4] xhci-ring.c: Add poll pending state to properly abort transactions

2020-09-13 Thread Jason Wessel
Both xhci_ctrl_tx() and xhci_bulk_tx() can be called synchronously by other drivers such as the usb storage or network, while the keyboard driver exclusively uses the polling mode. The reason the abort needs to happen is for the case when a keyboard poll was issue but there was no response packet.

[PATCH 0/4][v2] xhci fixes for rpi4

2020-09-13 Thread Jason Wessel
This is the second iteration of the xhci patch set for making USB keyboards usable on the rpi4 board. Patch 1 is new to deal with the USB device not responding immediately after a port reset. Patch 3 is refactored after the review from Bin Meng. --

[PATCH v2 1/4] xhci.c: Add retry in xhci_address_device()

2020-09-13 Thread Jason Wessel
After a port reset some usb keyboard devices do not respond immediately, and instead the controller reports COMP_TX_ERR. Adding a retry after the first TX error is returned resolves the issue. Without the patch u-boot prints: Starting the controller USB XHCI 1.00 scanning bus xhci_pci f

[PATCH v2 4/4] xhci-ring.c: Fix crash when issuing "usb reset"

2020-09-13 Thread Jason Wessel
When TRB_TRANSFER is set for a call to xhci_wait_for_event, it can return null, which causes u-boot to crash. This is an intermittent problem found during "usb reset" testing. If the null return occurs it means there was a timeout, and the abort_td() should return immediately vs crashing u-boot f

Re: [PATCH 4/7] riscv: Clear pending IPIs on initialization

2020-09-13 Thread Bin Meng
On Tue, Sep 8, 2020 at 2:17 AM Sean Anderson wrote: > > Even though we no longer call smp_function if an IPI was not sent by > U-Boot, we still need to clear any IPIs which were pending from the > execution environment. Otherwise, secondary harts will busy-wait in > secondary_hart_loop, instead of

Re: [PATCH 3/7] riscv: Use NULL as a sentinel value for smp_call_function

2020-09-13 Thread Bin Meng
Hi Leo, On Mon, Sep 14, 2020 at 9:58 AM Leo Liang wrote: > > On Fri, Sep 11, 2020 at 04:04:13PM +0800, Bin Meng wrote: > > On Tue, Sep 8, 2020 at 2:17 AM Sean Anderson wrote: > > > > > > Some IPIs may already be pending when U-Boot is started. This could be a > > > problem if a secondary hart tr

Re: [PATCH] Add support for Davicom DM96xx based USB 10/100 ethernet devices

2020-09-13 Thread Tom Rini
On Sat, Sep 12, 2020 at 10:46:37PM +0800, hyyoxhk wrote: > Ported from Linux driver - drivers/net/usb9601.c > > Signed-off-by: hyyoxhk > --- > drivers/usb/eth/Kconfig | 8 > drivers/usb/eth/Makefile | 1 + > 2 files changed, 9 insertions(+) You forgot to add the driver file. -- Tom

RE: SPL FIT configuration signature verification

2020-09-13 Thread Reuben Dowle
Yes, it is possible to do this. The SPL will check its own DTB to check which signatures are required. When the FIT that the SPL will load is created with mkimage, you also pass the SPL's dtb file, which will be patched to include the required signatures. I am not sure if the config system has

Re: [PATCH 0/3] log: Fix segfault in sandbox when LOG_LEVEL_DEFAULT >= LOGL_DEBUG

2020-09-13 Thread Sean Anderson
On 9/12/20 5:45 PM, Sean Anderson wrote: > Since the syslog feature has been introduced, sandbox no longer boots when > LOG_LEVEL_DEFAULT prints cdebug messages. This is because it tries to call > net_init before initf_dm. > > > Sean Anderson (3): > dev: Disambiguate errors in uclass_find > n

[PATCH] pci: layerscape: Fixup PCIe EP mode DT nodes for LX2160A rev2

2020-09-13 Thread Zhiqiang Hou
From: Hou Zhiqiang LX2160A rev2 uses different PCIe controller, so EP mode DT nodes also need to be fixed up. Signed-off-by: Hou Zhiqiang --- drivers/pci/pcie_layerscape_fixup_common.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/pci/pcie_layerscape_fixup

Re: [PATCH 4/4] log: Disable the syslog driver by default

2020-09-13 Thread Simon Glass
Hi Heinrich, On Sun, 13 Sep 2020 at 00:47, Heinrich Schuchardt wrote: > > Am 13. September 2020 03:24:02 MESZ schrieb Simon Glass : > >Hi Heinrich, > > > >On Sat, 12 Sep 2020 at 14:34, Heinrich Schuchardt > >wrote: > >> > >> Am 12. September 2020 22:24:24 MESZ schrieb Simon Glass > >: > >> >Hi H

RE: [EXT] Re: [PATCH] defconfig: espressobin: enable NET_RANDOM_ETHADDR

2020-09-13 Thread Kostya Porotchkin
Hello, > -Original Message- > From: Dennis Gilmore > Sent: Friday, September 11, 2020 20:16 > To: Tom Rini > Cc: Andre Heider ; Marek Behún > ; Pali Rohár ; Stefan Roese > ; Kostya Porotchkin ; U-Boot Mailing > List > Subject: [EXT] Re: [PATCH] defconfig: espressobin: enable > NET_RANDO