Re: [PATCH v3 0/7] x86: Improve support for chain-loading U-Boot

2020-03-28 Thread Simon Glass
Hi Bin, On Sat, 7 Mar 2020 at 16:22, Simon Glass wrote: > > This little series adds a few checks into the code to allow better > operation when booting a build from a previous-state loader such as > coreboot. > > At present we have a 'coreboot' target but this runs very different code > from the

Re: [PATCH] common/board_f: Make reserve_mmu generic

2020-03-28 Thread Simon Glass
Hi, On Sat, 28 Mar 2020 at 12:25, Ovidiu Panait wrote: > > Introduce arch_reserve_mmu to allow for architecture-specific reserve_mmu > routines. > > For ARM, move the reserve_mmu definition from common/board_f.c to > arch/arm/lib/cache.c. Can you please do that bit in an initial patch before thi

Re: [RFC PATCH v2] arch: x86: apl: Read FSP-M configuration from device-tree

2020-03-28 Thread Simon Glass
Hi Bernhard, On Fri, 27 Mar 2020 at 06:30, Bernhard Messerklinger wrote: > > Move FSP-M configuration to the device-tree like it's already done for > other SoCs (Baytaril). > > Signed-off-by: Bernhard Messerklinger > > --- > With this patch I moved the fsp-m configuration to the device-tree bas

Re: [PATCH v3] arm: add acpi support for the arm

2020-03-28 Thread Simon Glass
+U-Boot Mailing List Hi Steven, On Thu, 19 Mar 2020 at 21:08, Steven Hao wrote: > > Hi Simon: > > Most acpi table have no difference between x86 and arm. > For example, RSDP,XSDT,DSDT,SSDT,SPCR,FADT,MADT,GTDT,MCFG is same. > But FACS,IORT table may be different. > > I have a idea that the same a

Re: [PATCH v1] x86: acpi: Refactor XSDT handling in acpi_add_table()

2020-03-28 Thread Simon Glass
Hi Andy, On Thu, 5 Mar 2020 at 05:17, Andy Shevchenko wrote: > > On Tue, Mar 03, 2020 at 07:47:56PM -0700, Simon Glass wrote: > > On Tue, 3 Mar 2020 at 02:23, Andy Shevchenko > > wrote: > > > On Tue, Mar 3, 2020 at 1:36 AM Simon Glass wrote: > > > > On Mon, 2 Mar 2020 at 13:47, Andy Shevchenko

Re: [PATCH] fdtdec: use full path in fdtdec_get_alias_seq comparison

2020-03-28 Thread Simon Glass
Hi Vladimir, On Sat, 28 Mar 2020 at 15:12, Vladimir Oltean wrote: > > On Sat, 28 Mar 2020 at 23:00, Simon Glass wrote: > > > > Hi Vladimir, > > > > On Sat, 28 Mar 2020 at 14:25, Vladimir Oltean wrote: > > > > > > Hi Simon, > > > > > > On Sat, 28 Mar 2020 at 22:06, Simon Glass wrote: > > > > >

Re: [PATCH] fdtdec: use full path in fdtdec_get_alias_seq comparison

2020-03-28 Thread Vladimir Oltean
On Sat, 28 Mar 2020 at 23:00, Simon Glass wrote: > > Hi Vladimir, > > On Sat, 28 Mar 2020 at 14:25, Vladimir Oltean wrote: > > > > Hi Simon, > > > > On Sat, 28 Mar 2020 at 22:06, Simon Glass wrote: > > > > > > Hi Vladimir, > > > > > > On Fri, 27 Mar 2020 at 11:29, Vladimir Oltean wrote: > > > >

Re: [U-Boot] [PATCH] rockchip: rk3399: Add Pinebook Pro laptop support

2020-03-28 Thread Peter Robinson
Now that the device-tree is in linux-next (should land in linux 5.7), > anyone have a chance to take a stab at a v2 of this patch series? I did > a quick-and-dirty attempt, and the TPL/SPL layers worked, but failed to > load the main u-boot/atf binaries (mmc issues, I think). Yes, I got to that c

Re: [PATCH] fdtdec: use full path in fdtdec_get_alias_seq comparison

2020-03-28 Thread Simon Glass
Hi Vladimir, On Sat, 28 Mar 2020 at 14:25, Vladimir Oltean wrote: > > Hi Simon, > > On Sat, 28 Mar 2020 at 22:06, Simon Glass wrote: > > > > Hi Vladimir, > > > > On Fri, 27 Mar 2020 at 11:29, Vladimir Oltean wrote: > > > > > > From: Vladimir Oltean > > > > > > Currently fdtdec_get_alias_seq()

Re: [PATCH] x86: spi: Only use the fast SPI peripheral when support

2020-03-28 Thread Simon Glass
Hi Bin, On Thu, 26 Mar 2020 at 10:38, Bin Meng wrote: > > Hi Simon, > > On Fri, Mar 27, 2020 at 12:20 AM Simon Glass wrote: > > > > HI Bin, > > > > On Wed, 25 Mar 2020 at 01:25, Bin Meng wrote: > > > > > > Hi Simon, > > > > > > On Tue, Mar 24, 2020 at 9:45 PM Simon Glass wrote: > > > > > > > >

Re: [U-Boot] [PATCH] rockchip: rk3399: Add Pinebook Pro laptop support

2020-03-28 Thread Vagrant Cascadian
On 2019-12-18, Vagrant Cascadian wrote: > On 2019-11-14, Peter Robinson wrote: >> Add initial support for Pinebook Pro laptop. Now that the device-tree is in linux-next (should land in linux 5.7), anyone have a chance to take a stab at a v2 of this patch series? I did a quick-and-dirty attempt, an

Re: [PATCH] fdtdec: use full path in fdtdec_get_alias_seq comparison

2020-03-28 Thread Vladimir Oltean
Hi Simon, On Sat, 28 Mar 2020 at 22:06, Simon Glass wrote: > > Hi Vladimir, > > On Fri, 27 Mar 2020 at 11:29, Vladimir Oltean wrote: > > > > From: Vladimir Oltean > > > > Currently fdtdec_get_alias_seq() calls fdt_get_name() which returns only > > the name of the leaf node. So it needs to also

Re: [PATCH v2 2/2] rockchip: video: Convert to use APIs which support live DT

2020-03-28 Thread Simon Glass
Hi Kever, On Thu, 26 Mar 2020 at 07:37, Kever Yang wrote: > > Use ofnode_ or dev_ APIs instead of fdt_ and fdtdec_ APIs so that the > driver can support live DT. > > Signed-off-by: Kever Yang > --- > > Changes in v2: > - use dev_read_s32() instead of dev_read_s32_default(); > > drivers/video/ro

Re: [RFC PATCH 1/1] Makefile: Expand legacy (non-DM) driver warnings

2020-03-28 Thread Simon Glass
Hi Niel, On Wed, 25 Mar 2020 at 07:47, Niel Fourie wrote: > > Expand warnings printed by Makefile after compile when legacy > drivers are in use. These include: > > - CONFIG_HAVE_BLOCK_DEVICE without CONFIG_BLK > - CONFIG_BOOTCOUNT_LIMIT without CONFIG_DM_BOOTCOUNT > - CONFIG_MTD without CONFIG_D

Re: [PATCH v2 1/2] rockchip: video: Use ofnode_decode_display_timing() to parse timing

2020-03-28 Thread Simon Glass
On Thu, 26 Mar 2020 at 07:37, Kever Yang wrote: > > Use ofnode_decode_display_timing() instead of > fdtdec_decode_display_timing() to parse display timing, so that we can > support live DT. > > Signed-off-by: Kever Yang > --- > > Changes in v2: None > > drivers/video/rockchip/rk_lvds.c | 3 +-- >

Re: [PATCH] fdtdec: use full path in fdtdec_get_alias_seq comparison

2020-03-28 Thread Simon Glass
Hi Vladimir, On Fri, 27 Mar 2020 at 11:29, Vladimir Oltean wrote: > > From: Vladimir Oltean > > Currently fdtdec_get_alias_seq() calls fdt_get_name() which returns only > the name of the leaf node. So it needs to also trim the path of the > alias to the leaf name only, leading to imperfect match

Re: [PATCH] x86: spi: Only use the fast SPI peripheral when support

2020-03-28 Thread Simon Glass
Hi Bin, On Thu, 26 Mar 2020 at 10:38, Bin Meng wrote: > > Hi Simon, > > On Fri, Mar 27, 2020 at 12:20 AM Simon Glass wrote: > > > > HI Bin, > > > > On Wed, 25 Mar 2020 at 01:25, Bin Meng wrote: > > > > > > Hi Simon, > > > > > > On Tue, Mar 24, 2020 at 9:45 PM Simon Glass wrote: > > > > > > >

Re: [PATCH v3 00/21] dm: add support of new binding in gpio and pincontrol

2020-03-28 Thread Simon Glass
Hi Tom and Patrick, On Fri, 27 Mar 2020 at 13:44, Simon Glass wrote: > > Hi Tom, > > On Fri, 27 Mar 2020 at 13:21, Tom Rini wrote: > > > > On Mon, Jan 13, 2020 at 11:34:54AM +0100, Patrick Delaunay wrote: > > > > > Hi, > > > > > > it is the V3 of "dm: add support of new binding in gpio and pinco

Re: [PATCH v3 7/8] libfdt: Make fdtdec_get_child_count() available for HOST

2020-03-28 Thread Simon Glass
Hi Kever, On Thu, 26 Mar 2020 at 04:09, Kever Yang wrote: > > The tool need to use fdtdec_get_child_count(), make it available for > HOST_CC. > > Signed-off-by: Kever Yang > --- > > Changes in v3: None > Changes in v2: None > > include/fdt_support.h | 1 + > lib/fdtdec.c | 11

[PATCH 1/2] dm: core: Add logging on unbind failure

2020-03-28 Thread Simon Glass
This failure path is tricky to debug since it continues after failure and there are a lot of error paths. Add logging to help. Signed-off-by: Simon Glass --- drivers/core/device-remove.c | 20 drivers/core/uclass.c| 4 ++-- 2 files changed, 14 insertions(+), 10 del

[PATCH 2/2] dm: core: Add a way to skip powering down power domains

2020-03-28 Thread Simon Glass
When removing a device the power domains it uses are generally powered off. But when we are trying to unbind all devices (e.g. for running tests) we don't want to probe a device in the 'remove' path. Add a new flag to skip this power-down step. Signed-off-by: Simon Glass --- drivers/core/devic

[PATCH] common/board_f: Make reserve_mmu generic

2020-03-28 Thread Ovidiu Panait
Introduce arch_reserve_mmu to allow for architecture-specific reserve_mmu routines. For ARM, move the reserve_mmu definition from common/board_f.c to arch/arm/lib/cache.c. Define arm_reserve_mmu and make it a weak define to allow machines to override it (in mach-versal/cpu.c and mach-zynqmp/cpu.c)

Re: [PATCH v3 1/2] sunxi: fix support board-specific CONFIG_PREBOOT

2020-03-28 Thread Jagan Teki
On Sat, Mar 28, 2020 at 9:38 PM André Przywara wrote: > > On 28/03/2020 14:32, Jagan Teki wrote: > > On Tue, Mar 3, 2020 at 8:37 PM Jonas Smedegaard wrote: > >> > >> commit 37304aaf60bf ("Convert CONFIG_USE_PREBOOT and CONFIG_PREBOOT to > >> Kconfig") intended to support CONFIG_PREBOOT, but > >>

Re: [PATCH v3 1/2] sunxi: fix support board-specific CONFIG_PREBOOT

2020-03-28 Thread André Przywara
On 28/03/2020 14:32, Jagan Teki wrote: > On Tue, Mar 3, 2020 at 8:37 PM Jonas Smedegaard wrote: >> >> commit 37304aaf60bf ("Convert CONFIG_USE_PREBOOT and CONFIG_PREBOOT to >> Kconfig") intended to support CONFIG_PREBOOT, but >> include/configs/sunxi-common.h hardcodes preboot as part of internall

[PATCH v2 2/2] rsa: sig: fix config signature check for fit with padding

2020-03-28 Thread Philippe Reynes
The signature check on config node is broken on fit with padding. To compute the signature for config node, U-Boot compute the signature on all properties of requested node for this config, except for the property "data". But, when padding is used for binary in a fit, there isn't a property "data"

[PATCH v2 0/2] test/py: vboot: fix signature check on config node

2020-03-28 Thread Philippe Reynes
The signature check of config node is broken when used on fit with padding. We didn't see it before because this case is not covered by vboot test. When check the signature for a config nde, u-boot uses all the properties of the node referenced in the config node, except the property data. When pa

[PATCH v2 1/2] test/py: vboot: add a test to check fit signature on fit with padding

2020-03-28 Thread Philippe Reynes
The pytest vboot does all his tests on fit without padding. We add the same tests on fit with padding. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- test/py/tests/test_vboot.py | 42 -- 1 file changed, 28 insertions(+), 14 deletions(-) Chan

Re: [PATCH v3 1/2] sunxi: fix support board-specific CONFIG_PREBOOT

2020-03-28 Thread Jonas Smedegaard
Quoting Jagan Teki (2020-03-28 15:32:46) > On Tue, Mar 3, 2020 at 8:37 PM Jonas Smedegaard wrote: > > > > commit 37304aaf60bf ("Convert CONFIG_USE_PREBOOT and CONFIG_PREBOOT to > > Kconfig") intended to support CONFIG_PREBOOT, but > > include/configs/sunxi-common.h hardcodes preboot as part of int

Re: [PATCH v3 1/2] sunxi: fix support board-specific CONFIG_PREBOOT

2020-03-28 Thread Jagan Teki
On Tue, Mar 3, 2020 at 8:37 PM Jonas Smedegaard wrote: > > commit 37304aaf60bf ("Convert CONFIG_USE_PREBOOT and CONFIG_PREBOOT to > Kconfig") intended to support CONFIG_PREBOOT, but > include/configs/sunxi-common.h hardcodes preboot as part of internally > defined CONSOLE_STDIN_SETTINGS, silently

[PATCH v2 3/5] azure/gitlab/travis: Add qemu-riscv32 testing

2020-03-28 Thread Bin Meng
This adds the qemu-riscv32_defconfig test configuration. Signed-off-by: Bin Meng --- Changes in v2: - Update travis to add qemu-riscv32 testing .azure-pipelines.yml | 5 + .gitlab-ci.yml | 9 + .travis.yml | 7 +++ 3 files changed, 21 insertions(+) diff --git a

[PATCH v2 4/5] test/py: Update u_boot_utils.find_ram_base to bypass the low 2MiB memory

2020-03-28 Thread Bin Meng
On some RISC-V targets the low memory is protected that prevents S-mode U-Boot from access. Signed-off-by: Bin Meng --- Changes in v2: None test/py/u_boot_utils.py | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/test/py/u_boot_utils.py b/test/py/u_boot_utils.py index

[PATCH v2 2/5] travis: Build GRUB image for RISC-V 32-bit and 64-bit

2020-03-28 Thread Bin Meng
This adds the GRUB image build for RISC-V 32-bit and 64-bit. Signed-off-by: Bin Meng --- Changes in v2: - new patch: "travis: Build GRUB image for RISC-V 32-bit and 64-bit" .travis.yml | 47 +++ 1 file changed, 47 insertions(+) diff --git a/.travis

[PATCH v2 0/5] azure/gitlab/travis: Add more RISC-V boards testing

2020-03-28 Thread Bin Meng
At presetn only qemu-riscv64 is tested in our CI pipeline. This adds qemu-riscv32 and qemu-riscv{32,64}_spl testing. For Azure/Gitlab, this depends on a new Docker image below: http://patchwork.ozlabs.org/project/uboot/list/?series=166924 The following results are based on the new Docker image.

[PATCH v2 5/5] azure/gitlab/travis: Add RISC-V SPL testing

2020-03-28 Thread Bin Meng
This adds QEMU RISC-V 32/64 SPL testing. Unlike QEMU RISC-V 32/64, we test SPL running in M-mode and U-Boot proper running in S-mode, with a 4-core SMP configuration. Signed-off-by: Bin Meng --- Changes in v2: - Update travis to add RISC-V SPL testing .azure-pipelines.yml | 16 +++

[PATCH v2 1/5] travis: Replace pre-built ARM/ARM64 GRUB images with the one built from source

2020-03-28 Thread Bin Meng
As of today travis uses the pre-built GRUB ARM/ARM64 images from opensuse. But azure/gitlab are using images built from GRUB 2.04 source. This updates travis to build GRUB ARM/ARM64 UEFI targets from source, to keep in sync with azure/gitlab. Signed-off-by: Bin Meng --- Changes in v2: - new pat

Re: [PATCH 1/1] vexpress_ca9x4: Enable use of correct DTB file and restore EFI loader.

2020-03-28 Thread Heinrich Schuchardt
On 3/28/20 10:36 AM, Heinrich Schuchardt wrote: On 3/27/20 8:18 AM, Kristian Amlie wrote: On 27/03/2020 06:44, Heinrich Schuchardt wrote: On 3/27/20 2:39 AM, Tom Rini wrote: On Tue, Feb 25, 2020 at 06:22:16PM +0100, Kristian Amlie wrote: EFI was disabled in f95b8a4b5f64f because of the missi

[PATCH 1/1] test/py: UEFI helloworld requires OF_CONTROL

2020-03-28 Thread Heinrich Schuchardt
With CONFIG_OF_CONTROL environment variable $fdtcontroladdr is not defined and test_efi_helloworld_net() fails. Signed-off-by: Heinrich Schuchardt --- @Tom This fixes the problem with vexpress_ca9x4 on Gitlab. --- test/py/tests/test_efi_loader.py | 5 +++-- 1 file changed, 3 insertions(+), 2 del

[RFC PATCH v2 08/13] video: add nexell video driver (soc: mlc, mipi)

2020-03-28 Thread Stefan Bosch
Low level functions for MLC (Multi Layer Control) and MIPI (Mobile Industry Processor Interface). Signed-off-by: Stefan Bosch --- Changes in v2: None drivers/video/nexell/soc/s5pxx18_soc_mipi.c | 580 + drivers/video/nexell/soc/s5pxx18_soc_mipi.h | 291 + drivers/video/nexell/soc

[RFC PATCH v2 10/13] video: add nexell video driver (soc: dpc, makefile)

2020-03-28 Thread Stefan Bosch
Low level functions for DPC (Display Controller) and Makefile for all nexell video low level functions. Signed-off-by: Stefan Bosch --- Changes in v2: None drivers/video/nexell/soc/Makefile | 11 + drivers/video/nexell/soc/s5pxx18_soc_dpc.c | 1569 drive

[RFC PATCH v2 13/13] arm: add (default) config for nanopi2 board

2020-03-28 Thread Stefan Bosch
Changes in relation to FriendlyARM's U-Boot nanopi2-v2016.01: - Configuration changed, mainly several "CONFIG_..." moved from s5p4418_nanopi2.h to s5p4418_nanopi2_defconfig and USB related configs removed because USB is not supported yet. - s5p4418_nanopi2.h: "CONFIG_" removed from several s5p4

[RFC PATCH v2 12/13] arm: add support for SoC s5p4418 (cpu) / nanopi2 board

2020-03-28 Thread Stefan Bosch
Changes in relation to FriendlyARM's U-Boot nanopi2-v2016.01: - SPL not supported yet --> no spl-dir in arch/arm/cpu/armv7/s5p4418/. Appropriate line in Makefile removed. - cpu.c: '#include ' added. - arch/arm/cpu/armv7/s5p4418/u-boot.lds removed, is not required anylonger. - "obj-$(CONFIG_ARCH

[RFC PATCH v2 09/13] video: add nexell video driver (soc: lvds, hdmi)

2020-03-28 Thread Stefan Bosch
Low level functions for LVDS and HDMI display interfaces. Signed-off-by: Stefan Bosch --- Changes in v2: None drivers/video/nexell/soc/s5pxx18_soc_hdmi.c | 50 +++ drivers/video/nexell/soc/s5pxx18_soc_hdmi.h | 488 drivers/video/nexell/soc/s5pxx18_soc_lvds.c | 278

[RFC PATCH v2 11/13] video: add nexell video driver (display/video driver)

2020-03-28 Thread Stefan Bosch
Changes in relation to FriendlyARM's U-Boot nanopi2-v2016.01: - nexell_display.c: Changed to DM, CONFIG_FB_ADDR can not be used anymore because framebuffer is allocated by video_reserve() in video-uclass.c. Therefore code changed appropriately. Signed-off-by: Stefan Bosch --- Changes in v2:

[RFC PATCH v2 06/13] pwm: add driver for nexell

2020-03-28 Thread Stefan Bosch
Changes in relation to FriendlyARM's U-Boot nanopi2-v2016.01: - Since drivers/pwm/pwm-nexell.c is an adapted version of s5p-common/pwm.c an appropriately changed version of s5p-common/pwm.c is used instead. Therefore arch/arm/mach-s5pc1xx/include/mach/pwm.h copied to arch/arm/mach-nexell/incl

[RFC PATCH v2 02/13] arm: add mach-nexell (all files except header files)

2020-03-28 Thread Stefan Bosch
Changes in relation to FriendlyARM's U-Boot nanopi2-v2016.01: - SPL not supported yet --> no spl-directory in arch/arm/mach-nexell. Appropriate line in Makefile removed. - clock.c: 'section(".data")' added to declaration of clk_periphs[] and core_hz. - Kconfig: Changes to have a structure like

[RFC PATCH v2 05/13] mmc: add nexell driver

2020-03-28 Thread Stefan Bosch
Changes in relation to FriendlyARM's U-Boot nanopi2-v2016.01: - mmc: nexell_dw_mmc.c changed to nexell_dw_mmc_dm.c (switched to DM). Signed-off-by: Stefan Bosch --- Changes in v2: - commit "i2c: mmc: add nexell driver (gpio, i2c, mmc, pwm)" splitted into separate commits for gpio, i2c, mmc, pw

[RFC PATCH v2 07/13] video: add nexell video driver (soc: displaytop)

2020-03-28 Thread Stefan Bosch
Low level functions for DisplayTop (Display Topology). Signed-off-by: Stefan Bosch --- Changes in v2: None drivers/video/nexell/soc/s5pxx18_soc_disptop.c | 185 ++ drivers/video/nexell/soc/s5pxx18_soc_disptop.h | 385 + drivers/video/nexell/soc/s5pxx18_soc_d

[RFC PATCH v2 01/13] arm: add mach-nexell (header files)

2020-03-28 Thread Stefan Bosch
Changes in relation to FriendlyARM's U-Boot nanopi2-v2016.01: - DM_VIDEO support (display_dev.h). - boot0.h added, handles NSIH --> tools/nexell obsolete. - gpio.h: Include-path to errno.h changed. Signed-off-by: Stefan Bosch --- Changes in v2: - cosmetic: additional GPL license text removed, SP

[RFC PATCH v2 04/13] i2c: add nexell driver

2020-03-28 Thread Stefan Bosch
Changes in relation to FriendlyARM's U-Boot nanopi2-v2016.01: - i2c/nx_i2c.c: Some adaptions mainly because of changes in "struct udevice". - several Bugfixes in nx_i2c.c. - the driver has been for s5p6818 only. Code extended appropriately in order s5p4418 is also working. - "probe_chip" added.

[RFC PATCH v2 00/13] arm: add support for SoC S5P4418

2020-03-28 Thread Stefan Bosch
This patch adds support for SAMSUNG's/NEXELL's ARM Cortex-A9 based S5P4418 SoC, especially FriendlyARM's NanoPi2 and NanoPC-T2 boards. It is based on the following FriendlyARM's U-Boot version: https://github.com/friendlyarm/u-boot/tree/nanopi2-v2016.01. Main changes in relation to nanopi2-v2016

[RFC PATCH v2 03/13] gpio: add nexell driver

2020-03-28 Thread Stefan Bosch
Signed-off-by: Stefan Bosch --- Changes in v2: - commit "i2c: mmc: add nexell driver (gpio, i2c, mmc, pwm)" splitted into separate commits for gpio, i2c, mmc, pwm. - cosmetic: line "obj-$(CONFIG_NX_GPIO) += nx_gpio.o" in drivers/gpio/Makefile moved up. drivers/gpio/Kconfig | 9 ++ drive

Re: [PATCH 1/1] vexpress_ca9x4: Enable use of correct DTB file and restore EFI loader.

2020-03-28 Thread Heinrich Schuchardt
On 3/27/20 8:18 AM, Kristian Amlie wrote: On 27/03/2020 06:44, Heinrich Schuchardt wrote: On 3/27/20 2:39 AM, Tom Rini wrote: On Tue, Feb 25, 2020 at 06:22:16PM +0100, Kristian Amlie wrote: EFI was disabled in f95b8a4b5f64f because of the missing DTB file, and indeed, the DTB file is required