Re: [U-Boot] [PATCH u-boot-marvell v2.1 15/15] i2c: mvtwsi: fix reading status register after interrupt

2019-05-01 Thread Stefan Roese
On 01.05.19 23:09, Marek Behún wrote: The twsi_wait function reads the control register for interrupt flag, and if interrupt flag is present, it immediately reads status register. On our device this sometimes causes bad value being read from status register, as if the value was not yet updated.

Re: [U-Boot] [PATCH] i2c: mxc: Hide kconfig based control in DM_I2C mode

2019-05-01 Thread Anatolij Gustschin
Hi Heiko, On Thu, 2 May 2019 07:39:06 +0200 Heiko Schocher h...@denx.de wrote: ... > > @Anatolij: Is this code needed anymore, as board is moved to DM ? ... > dm_i2c_probe should initialize the i2c bus completly, also we need > not longer the: > > #ifdef CONFIG_DM_I2C > > and remove the else pa

Re: [U-Boot] [PATCH u-boot-marvell v2 14/15] arm: mvebu: turris_omnia: add RESET button handling

2019-05-01 Thread Stefan Roese
On 30.04.19 03:48, Marek Behún wrote: There is a Factory RESET button on the back side of the Turris Omnia router. When user presses this button before powering the device up and keeps it pressed, the microcontroller prevents the main CPU from booting and counts how long the RESET button is being

Re: [U-Boot] [PATCH u-boot-marvell v2 13/15] arm: mvebu: turris_omnia: fix regdomain env var setting

2019-05-01 Thread Stefan Roese
On 30.04.19 03:48, Marek Behún wrote: The regdomain environment variable is set according to value read from EEPROM. This has to be done in board_late_init, after the environment variables are read from SPI. Select CONFIG_BOARD_LATE_INIT in Kconfig for the Turris Omnia target. Signed-off-by: Mar

Re: [U-Boot] [PATCH u-boot-marvell v2 12/15] arm: mvebu: turris_*: remove watchdog include

2019-05-01 Thread Stefan Roese
On 30.04.19 03:48, Marek Behún wrote: Since board watchdog is now unified and not handled in board files, remove the unnecessary includes. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.den

Re: [U-Boot] [PATCH u-boot-marvell v2 10/15] arm: mvebu: turris_omnia: refactor more code

2019-05-01 Thread Stefan Roese
On 30.04.19 03:48, Marek Behún wrote: Refactor RAM size reading from EEPROM in preparation for next patch. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listi

Re: [U-Boot] [PATCH u-boot-marvell v2 11/15] arm: mvebu: turris_omnia: print board info as Turris Mox

2019-05-01 Thread Stefan Roese
On 30.04.19 03:48, Marek Behún wrote: Unify the way how Omnia and Mox print board information (RAM size and serial number). Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de https://li

Re: [U-Boot] [PATCH u-boot-marvell v2 09/15] arm: mvebu: turris_omnia: move ATSHA204A from defconfig to Kconfig

2019-05-01 Thread Stefan Roese
On 30.04.19 03:48, Marek Behún wrote: This driver is required for Turris Omnia to read ethernet addresses. Move the dependency from turris_omnia_defconfig to Kconfig. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan ___ U-Boot m

Re: [U-Boot] [PATCH u-boot-marvell v2 08/15] arm: mvebu: turris_omnia: fix checkpatch warnings

2019-05-01 Thread Stefan Roese
On 30.04.19 03:48, Marek Behún wrote: Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH u-boot-marvell v2 07/15] arm: mvebu: turris_omnia: refactor I2C accessing code

2019-05-01 Thread Stefan Roese
On 30.04.19 03:48, Marek Behún wrote: Refactor code which accesses the microcontroller and EEPROM via I2C. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listi

Re: [U-Boot] [PATCH u-boot-marvell v2 06/15] arm: mvebu: turris_omnia: add SCSI as boot target

2019-05-01 Thread Stefan Roese
On 30.04.19 03:48, Marek Behún wrote: If SCSI is enabled, U-Boot should try to boot also from SCSI device on Turris Omnia. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de https://lis

Re: [U-Boot] [PATCH u-boot-marvell v2 05/15] arm: mvebu: turris_omnia: move I2C dependencies to Kconfig

2019-05-01 Thread Stefan Roese
On 30.04.19 03:48, Marek Behún wrote: The I2C dependencies are defined in include/configs/turris_omnia.h, because Turris Omnia won't boot correctly without I2C support. Move these dependencies to Kconfig, so that they are selected if Turris Omnia is selected as target. Signed-off-by: Marek Behú

Re: [U-Boot] [PATCH u-boot-marvell v2 03/15] arm: mvebu: turris_omnia: use AHCI and SATA driver model

2019-05-01 Thread Stefan Roese
On 30.04.19 03:48, Marek Behún wrote: Enable AHCI, SCSI and SATA for compliance with the driver model migration. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de

Re: [U-Boot] [PATCH u-boot-marvell v2 04/15] arm: mvebu: turris_omnia: remove legacy macros from board header

2019-05-01 Thread Stefan Roese
On 30.04.19 03:48, Marek Behún wrote: These are not needed if MMC and SCSI DM drivers are used. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH u-boot-marvell v2 02/15] arm: mvebu: turris_omnia: add XHCI to defconfig

2019-05-01 Thread Stefan Roese
On 30.04.19 03:48, Marek Behún wrote: Add XHCI_HOST and XHCI_MVEBU to defconfig, so that user's can by default boot from USB on Turris Omnia. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.

Re: [U-Boot] [PATCH u-boot-marvell v2 01/15] arm: mvebu: turris_omnia: remove redundant code

2019-05-01 Thread Stefan Roese
On 30.04.19 03:48, Marek Behún wrote: The i2c slave disabling is done by mvtwsi driver and is not needed here. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/l

Re: [U-Boot] [PATCH v4 0/5] net: ethernet: ti: Introduce am654 gigabit eth switch subsystem driver

2019-05-01 Thread Keerthy
On 30/04/19 11:57 AM, Keerthy wrote: On 30/04/19 11:54 AM, Keerthy wrote: Add new driver for the TI AM65x SoC Gigabit Ethernet Switch subsystem (CPSW NUSS). It has two ports and provides Ethernet packet communication for the device and can be configured as an Ethernet switch. CPSW NUSS fea

Re: [U-Boot] [PATCH] i2c: mxc: Hide kconfig based control in DM_I2C mode

2019-05-01 Thread Heiko Schocher
Hello Trent, Am 30.04.2019 um 19:21 schrieb Trent Piepho: On Tue, 2019-04-30 at 09:20 +0200, Heiko Schocher wrote: Am 12.04.2019 um 21:19 schrieb Trent Piepho: These options only apply when not using DM_I2C. When using device trees, the dt will enable and control the speeds of the I2C control

Re: [U-Boot] [PATCH v2 10/19] spi: mpc8xxx: Simplify logic a bit

2019-05-01 Thread Mario Six
Hi Jagan and Jocke, I'm back from vacation, so here's my answer: On Mon, Apr 29, 2019 at 12:41 PM Jagan Teki wrote: > > + Mario > > On Mon, Apr 29, 2019 at 2:48 PM Joakim Tjernlund > wrote: > > > > On Mon, 2019-04-29 at 01:58 +0530, Jagan Teki wrote: > > > > > > From: Mario Six > > > > > > We

Re: [U-Boot] [PATCH u-boot-marvell v2.1 15/15] i2c: mvtwsi: fix reading status register after interrupt

2019-05-01 Thread Heiko Schocher
Hello Marek, Am 01.05.2019 um 23:09 schrieb Marek Behún: The twsi_wait function reads the control register for interrupt flag, and if interrupt flag is present, it immediately reads status register. On our device this sometimes causes bad value being read from status register, as if the value w

Re: [U-Boot] [PATCH 2/2] i2c: mxc_i2c: Fix read and read->write xfers in DM mode

2019-05-01 Thread Heiko Schocher
Hello Trent, Am 30.04.2019 um 18:04 schrieb Trent Piepho: On Tue, 2019-04-30 at 06:34 +0200, Heiko Schocher wrote: Hello Trent, Am 16.04.2019 um 00:02 schrieb Trent Piepho: This is an old driver that supports both device mapped and non-mapped mode, and covers a wide range of hardware. It's h

Re: [U-Boot] [PATCH v3 1/3] ddr: altera: Compile ALTERA SDRAM in SPL only

2019-05-01 Thread Ley Foon Tan
On Tue, Apr 30, 2019 at 5:45 PM Marek Vasut wrote: > > On 4/30/19 11:19 AM, Ley Foon Tan wrote: > > Compile ALTERA_SDRAM driver in SPL only. > > Rename ALTERA_SDRAM to SPL_ALTERA_SDRAM. > > > > Signed-off-by: Ley Foon Tan > > --- > > Makefile | 2 +- > > arch/arm

Re: [U-Boot] Booting imx_4.14.98_2.0.0_ga on i.MX8QM MEK Board

2019-05-01 Thread Peng Fan
Hi Marcel, > Subject: Booting imx_4.14.98_2.0.0_ga on i.MX8QM MEK Board > > Hi Peng, Stefano and Fabio > > We are currently trying to boot the Linux kernel from NXP's downstream Linux > BSP 4.14.98_2.0.0_ga with mainline U-Boot. However, that currently seems > to crash as follows: > > ... > [

Re: [U-Boot] [PATCH v2] arm: socfpga: Move Stratix 10 SDRAM driver to DM

2019-05-01 Thread Ley Foon Tan
On Tue, Apr 30, 2019 at 5:56 PM Marek Vasut wrote: > > On 4/30/19 9:40 AM, Ley Foon Tan wrote: > [...] > > +static int altera_sdram_probe(struct udevice *dev) > > +{ > > + int ret; > > + struct reset_ctl_bulk resets; > > + > > + ret = reset_get_bulk(dev, &resets

Re: [U-Boot] [PATCH v3 2/3] arm: dts: Stratix10: Add SDRAM node

2019-05-01 Thread Ley Foon Tan
On Tue, Apr 30, 2019 at 5:45 PM Marek Vasut wrote: > > On 4/30/19 11:20 AM, Ley Foon Tan wrote: > > Add SDRAM device tree node to support SDRAM DM driver. > > DT is a hardware description, so you're adding the node to describe the > hardware that's present, not to enable software feature. Okay, wi

[U-Boot] [PATCH 3/3] Set time and umask on fit-dtb.blob to ensure reproducibile builds.

2019-05-01 Thread Vagrant Cascadian
When building compressed (lzop, gzip) fit-dtb.blob images, the compression tool may embed the time or umask in the image. Work around this by manually setting the time of the source file using SOURCE_DATE_EPOCH and a hard-coded 0600 umask. With gzip, this could be accomplished by using -n/--no-na

[U-Boot] [PATCH 2/3] Clean fit-dtb.blob* to also catch compressed blobs.

2019-05-01 Thread Vagrant Cascadian
Signed-off-by: Vagrant Cascadian --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index d6a6ef19ab..68f2327bea 100644 --- a/Makefile +++ b/Makefile @@ -1779,7 +1779,7 @@ CLEAN_DIRS += $(MODVERDIR) \ $(filter-out include

[U-Boot] [PATCH 1/3] Add fit-dtb.blob* to .gitignore to also exclude compressed blobs.

2019-05-01 Thread Vagrant Cascadian
Signed-off-by: Vagrant Cascadian --- .gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index c2afcfbca2..d8b7b77844 100644 --- a/.gitignore +++ b/.gitignore @@ -35,7 +35,7 @@ # # Top-level generic files # -fit-dtb.blob +fit-dtb.blob* /MLO*

[U-Boot] [PATCH 0/3] Tidy up support for compressed fit-dtb.blob.

2019-05-01 Thread Vagrant Cascadian
Support for compressed fit-dtb.blob was added in: commit 95f4bbd581cf lib: fdt: Allow LZO and GZIP DT compression in U-Boot This introduces reproducibility issues as the timestamp and umask may be embedded in the output when using gzip, lzop or possibly other compression tools if added later

Re: [U-Boot] [PATCH] test/py: don't use mmc_rd config for other mmc tests

2019-05-01 Thread Stephen Warren
On 4/30/19 10:27 AM, Marek Vasut wrote: On 4/30/19 5:29 PM, Stephen Warren wrote: On 4/16/19 4:04 PM, Stephen Warren wrote: From: Stephen Warren Fix test_mmc_dev(), test_mmc_rescan(), test_mmc_info() not to use the same configuration data that test_mmc_rd() does. Doing so causes the following

[U-Boot] [PATCH] net: ravb: Avoid unsupported internal delay mode for R-Car E3/D3

2019-05-01 Thread Marek Vasut
According to the R-Car Gen3 Hardware Manual Rev 1.50 of Nov 30, 2018, the TX clock internal delay mode isn't supported on R-Car E3 (r8a77990) or D3 (r8a77995). Avoid setting the APSR:TDM bit on these SoCs. Moreover, only set APSR:TDM when the DT explicitly specifies RGMII ID or TXID mode instead o

[U-Boot] [PATCH] ARM: rmobile: Add recovery SPL for R-Car Gen3

2019-05-01 Thread Marek Vasut
Build an SPL which can be started via SCIF download mode on R-Car Gen3 and allows loading and executing U-Boot uImage with the next stage code. This is also useful for starting e.g. ATF BL2, which inits the hardware and returns to the U-Boot SPL, which can then load e.g. U-Boot proper. The H3, M3-

Re: [U-Boot] [PATCH 4/4] lib: uuid: Improve randomness of uuid values on RANDOM_UUID=y

2019-05-01 Thread Eugeniu Rosca
Hi Tom, On Wed, May 01, 2019 at 03:51:49PM -0400, Tom Rini wrote: [..] > > Agreed, this patch sounds like it addresses a number of problems today > that are real problems (I await someone filing a CVE now for our PRNG > problem) A new CVE has been submitted via https://cveform.mitre.org/. Will k

[U-Boot] [PATCH u-boot-marvell v2.1 15/15] i2c: mvtwsi: fix reading status register after interrupt

2019-05-01 Thread Marek Behún
The twsi_wait function reads the control register for interrupt flag, and if interrupt flag is present, it immediately reads status register. On our device this sometimes causes bad value being read from status register, as if the value was not yet updated. My theory is that the controller does a

Re: [U-Boot] [v3 PATCH] RISCV: image: Add booti support.

2019-05-01 Thread Tom Rini
On Wed, May 01, 2019 at 01:07:31PM -0700, Atish Patra wrote: > This patch adds booti support for RISC-V Linux kernel. The existing > bootm method will also continue to work as it is. > > It depends on the following kernel patch which adds the header to the > flat Image. Gzip compressed Image (Ima

[U-Boot] [v3 PATCH] RISCV: image: Add booti support.

2019-05-01 Thread Atish Patra
This patch adds booti support for RISC-V Linux kernel. The existing bootm method will also continue to work as it is. It depends on the following kernel patch which adds the header to the flat Image. Gzip compressed Image (Image.gz) support is not enabled with this patch. https://patchwork.kernel

Re: [U-Boot] [PATCH 4/4] lib: uuid: Improve randomness of uuid values on RANDOM_UUID=y

2019-05-01 Thread Tom Rini
On Wed, May 01, 2019 at 09:08:31PM +0200, Eugeniu Rosca wrote: > Hi Heinrich, > > Thank you for reviewing this series. > > On Tue, Apr 30, 2019 at 09:07:09PM +0200, Heinrich Schuchardt wrote: > [..] > > This patch may ameliorate the situation for GUIDs a bit. But I dislike: > > In general, we ca

Re: [U-Boot] [PATCH 4/4] lib: uuid: Improve randomness of uuid values on RANDOM_UUID=y

2019-05-01 Thread Eugeniu Rosca
Hi Heinrich, Thank you for reviewing this series. On Tue, Apr 30, 2019 at 09:07:09PM +0200, Heinrich Schuchardt wrote: [..] > This patch may ameliorate the situation for GUIDs a bit. But I dislike: In general, we can find reasons to dislike anything, since there is room for improvement in virtua

Re: [U-Boot] [PATCH v2 28/50] x86: sysreset: Separate out the EFI code

2019-05-01 Thread Heinrich Schuchardt
On 5/1/19 3:42 PM, Bin Meng wrote: +Heinrich, On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: The EFI implementation of reset sits inside the driver and is called directly from outside the driver, breaking the normal driver-model conventions. Worse, it passed NULL as the device pointer, h

[U-Boot] WaRP7 nok on master

2019-05-01 Thread Pierre-Jean Texier
Hi Fabio, Stefano, Just FYI, I just tested the U-Boot master branch (with u-boot-imx merges). And I have some problems when the WaRP7 boot-up. In fact, no output... However, on u-boot-imx, everything works well (tags/u-boot-imx-20190426). After some manipulation with git bisect, it appears that

Re: [U-Boot] [PATCH v2 2/2] RISCV: image: Parse Image.gz support in booti.

2019-05-01 Thread Atish Patra
On 5/1/19 3:34 AM, Marek Vasut wrote: On 5/1/19 12:06 AM, Atish Patra wrote: On 4/30/19 2:42 PM, Marek Vasut wrote: On 4/30/19 10:38 PM, Atish Patra wrote: On 4/30/19 12:11 PM, Marek Vasut wrote: On 4/30/19 8:13 PM, Atish Patra wrote: On 4/30/19 2:52 AM, Marek Vasut wrote: On 4/30/19 3:27 A

[U-Boot] [PATCH 1/1] efi_selftest: test exit_data

2019-05-01 Thread Heinrich Schuchardt
Amend the unit test 'start image exit' to transfer a string as exit data. Signed-off-by: Heinrich Schuchardt --- include/efi_selftest.h | 2 +- lib/efi_selftest/efi_selftest_miniapp_exit.c| 17 - lib/efi_selftest/efi_selftest_startimage_exit.c | 15 +

Re: [U-Boot] [PATCH v2 00/50] x86: Add support for booting from TPL

2019-05-01 Thread Bin Meng
Hi Simon, On Fri, Apr 26, 2019 at 11:59 AM Simon Glass wrote: > > At present SPL is used on 64-bit platforms, to allow SPL to be built as > a 32-bit program and U-Boot proper to be built as 64-bit. > > However it is useful to be able to use SPL on any x86 platform, where > U-Boot needs to be upda

Re: [U-Boot] [PATCH v2 49/50] x86: Add a way to jump from TPL to SPL

2019-05-01 Thread Bin Meng
Hi Simon, On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > When TPL finishes it needs to jump to SPL with the stack set up correctly. > Add a function to handle this. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Add a new patch allowing jumping from TPL to SPL > > arch/x86

Re: [U-Boot] [PATCH v2 48/50] x86: broadwell: Update PCH to work in TPL

2019-05-01 Thread Bin Meng
On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > The early init should only happen once. Update the probe method to > deal with TPL, SPL and U-Boot proper. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Add a new patch to update PCH to work in TPL > > arch/x86/cpu/broadwell/p

Re: [U-Boot] [PATCH v2 47/50] x86: Update the memory map a little

2019-05-01 Thread Bin Meng
Hi Simon, On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > The memory map currently omits the environment and the MRC region. Add > these in for completeness. > I think the commit tile should be updated to add the "samus" tag. > Signed-off-by: Simon Glass > --- > > Changes in v2: None >

Re: [U-Boot] [PATCH v2 46/50] x86: Enable the RTC on all boards

2019-05-01 Thread Bin Meng
Hi Simon, On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > With the move to Kconfig this option should be set in Kconfig, not in the > config header file. Move it. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Add new patch to enable the RTC in Kconfig > > arch/Kconfig

Re: [U-Boot] [PATCH v2 45/50] Revert "pci: Scale MAX_PCI_REGIONS based on CONFIG_NR_DRAM_BANKS"

2019-05-01 Thread Bin Meng
+Thierry On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > This reverts commit aec4298ccb337106fd0115b91d846a022fdf301d. > > Unfortunately this has a dramatic impact on the pre-relocation memory > used on x86 platforms (increasing it by 2KB) since it increases the > overhead for each PCI de

Re: [U-Boot] [PATCH v2 41/50] x86: Update device tree for TPL

2019-05-01 Thread Bin Meng
Hi Simon, On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > Add TPL binaries to the device x86 binman desciption. When enabled, TPL > will start first, doing the 16-bit init, then jump to SPL and finally > U-Boot proper. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > arc

Re: [U-Boot] [PATCH v2 39/50] x86: samus: Update device tree for SPL

2019-05-01 Thread Bin Meng
Hi Simon, On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > Add tags to allow required nodes to be present in SPL / TPL. Also enable > the sysreset driver. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v2: None > > arch/x86/dts/chromebook_samus.dts | 38

Re: [U-Boot] [PATCH v3] Convert CONFIG_SUPPORT_EMMC_BOOT to Kconfig

2019-05-01 Thread Alex Kiernan
On Wed, May 1, 2019 at 3:49 PM Tom Rini wrote: > > On Wed, May 01, 2019 at 07:58:27AM +, Alex Kiernan wrote: > > This converts the following to Kconfig: > >CONFIG_SUPPORT_EMMC_BOOT > > > > As requested by Michal Simek , these boards > > have no eMMC so CONFIG_SUPPORT_EMMC_BOOT has not been

Re: [U-Boot] [PATCH v2 37/50] x86: sysreset: Implement the get_last() method

2019-05-01 Thread Bin Meng
On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > Add a default implementation of this method which always indicates that > the last reset was a power-on reset. This is the most likely type of reset > and without a PCH-specific driver we cannot determine any other type. > > Signed-off-by: Si

Re: [U-Boot] [PATCH v2 34/50] x86: Don't set up MTRRs in SPL

2019-05-01 Thread Bin Meng
On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > The MTRRs are normally set up in U-Boot proper, so avoid setting them up > in SPL as well. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v2: None > > arch/x86/lib/init_helpers.c | 5 - > 1 file changed, 4

Re: [U-Boot] [PATCH v2 36/50] x86: Support PCI VGA ROM when TPL is used

2019-05-01 Thread Bin Meng
On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > When TPL is in use, U-Boot proper should support initing the VGA ROM even > though the 32-bit init portion is in SPL. Update the condition to handle > this. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v2: Non

Re: [U-Boot] [PATCH v2 35/50] x86: Don't generate a bootstage report in SPL

2019-05-01 Thread Bin Meng
On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > This report is normally generated by U-Boot proper. Correct the condition > here so that it respects the Kconfig options for bootstage. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v2: None > > arch/x86/lib/b

Re: [U-Boot] [PATCH v2 31/50] x86: broadwell: Implement PCH_REQ_PMBASE_INFO

2019-05-01 Thread Bin Meng
On Wed, May 1, 2019 at 10:50 PM Bin Meng wrote: > > On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > > > Implement this ioctl() to support power off. > > > > Signed-off-by: Simon Glass > > --- > > > > Changes in v2: > > - Add new patch to implement PCH_REQ_PMBASE_INFO on broadwell > > > >

Re: [U-Boot] [PATCH v2 33/50] x86: Support TPL in Intel common code

2019-05-01 Thread Bin Meng
On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > Update the Makefie rules to ensure that the correct files are built when > TPL is being used. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v2: None > > arch/x86/cpu/intel_common/Makefile | 9 ++--- > 1 fi

Re: [U-Boot] [PATCH v2 30/50] x86: ivybridge: Implement PCH_REQ_PMBASE_INFO

2019-05-01 Thread Bin Meng
On Wed, May 1, 2019 at 9:42 PM Bin Meng wrote: > > On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > > > Implement this ioctl() to support power off. > > > > Signed-off-by: Simon Glass > > --- > > > > Changes in v2: > > - Add new patch to implement PCH_REQ_PMBASE_INFO on ivybridge > > > >

Re: [U-Boot] [PATCH v2 29/50] x86: pch: Add an ioctl to read power-management info

2019-05-01 Thread Bin Meng
On Wed, May 1, 2019 at 9:42 PM Bin Meng wrote: > > On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > > > Add a new ioctl() request to read information about the power-management > > system. This can be used to power off the device. > > > > Signed-off-by: Simon Glass > > --- > > > > Changes

Re: [U-Boot] [PATCH v2 27/50] x86: mrccache: Add more debugging

2019-05-01 Thread Bin Meng
On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > When the MRC cache fails to save it is useful to have some debugging info > to indicate what when wrong. Add some more debug() calls. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v2: None > > arch/x86/lib/mrc

Re: [U-Boot] [PATCH v2 26/50] x86: Add a simple TPL implementation

2019-05-01 Thread Bin Meng
On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > Add the required CPU code so that TPL builds correctly. Also update the > SPL code to deal with being booted from TPL. > > Reviewed-by: Bin Meng > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > arch/x86/include/asm/spl.h

Re: [U-Boot] [PATCH v2 23/50] x86: broadwell: Select refcode and CPU code for SPL

2019-05-01 Thread Bin Meng
On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > Allow broadwell to build for SPL and include the reference code. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v2: None > > arch/x86/cpu/broadwell/Makefile | 7 --- > 1 file changed, 4 insertions(+), 3 del

Re: [U-Boot] [PATCH v2 25/50] x86: Support saving MRC data from SPL

2019-05-01 Thread Bin Meng
On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > When SPL is used to set up the memory controller we want to save the MRC > data in SPL to avoid needing to pass it up to U-Boot proper to save. Add a > function to handle that. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- >

Re: [U-Boot] [PATCH v2 24/50] x86: Add common Intel code for SPL

2019-05-01 Thread Bin Meng
On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > Add an implementation of arch_cpu_init_f() so that the x86 SPL code builds > and identifies the CPU. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v2: None > > arch/x86/cpu/intel_common/Makefile | 6 +++

Re: [U-Boot] [PATCH v2 22/50] x86: broadwell: Allow booting from SPL

2019-05-01 Thread Bin Meng
On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > At present broadwell only supports booting straight into U-Boot proper. > Add a separate init file to boot from SPL into U-Boot proper, and select > it when SPL is in use. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Cha

Re: [U-Boot] [PATCH v2 21/50] x86: Allow 16-bit init to be in TPL

2019-05-01 Thread Bin Meng
On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > At present we support having 16-bit init be in SPL or U-Boot proper, but > not TPL. Add support for this so that TPL can boot. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v2: None > > Makefile

Re: [U-Boot] [PATCH v2 19/50] x86: broadwell: Split CPU init

2019-05-01 Thread Bin Meng
On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > Split the CPU init into two parts - the 'full' init which happens in the > first U-Boot phase, and the rest of the init that happens on subsequent > stages. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v2: Non

Re: [U-Boot] [PATCH v2 17/50] x86: broadwell: Allow SDRAM init from SPL

2019-05-01 Thread Bin Meng
On Wed, May 1, 2019 at 9:03 PM Bin Meng wrote: > > On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > > > At present, for broadwell, SDRAM is always set up in U-Boot proper since > > the 64-bit mode (which uses SDRAM init in SPL) is not supported. > > > > Update the code to allow SDRAM init

Re: [U-Boot] [PATCH v2 18/50] x86: Move init of debug UART to cpu.c

2019-05-01 Thread Bin Meng
On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > At present the debug UART is set up in sdram.c which is not the best place > since it has nothing in particular to do with SDRAM. Since we want to > support initing this in SPL too, move it to a common file. > > Signed-off-by: Simon Glass >

Re: [U-Boot] [PATCH v2 20/50] x86: Add support for starting from SPL/TPL

2019-05-01 Thread Bin Meng
On Wed, May 1, 2019 at 9:03 PM Bin Meng wrote: > > On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > > > When a previous phase of U-Boot has run we need to adjust the init of > > subsequent states to avoid messing up the CPU state. > > > > Add a new version of the start logic for SPL, when

Re: [U-Boot] [PATCH v2 16/50] x86: broadwell: Improve SDRAM debugging output

2019-05-01 Thread Bin Meng
On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > Add debugging during SDRAM init so that problems are easier to > diagnose. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v2: None > > arch/x86/cpu/broadwell/sdram.c | 32 > 1 f

Re: [U-Boot] [PATCH v2 14/50] x86: Support booting with TPL

2019-05-01 Thread Bin Meng
On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > Some boards want to use TPL as the first phase of U-Boot. This allows > selection of A or B SPL phases, thus allowing the memory init to be > upgraded in the field. > > Add a new Kconfig option for this. > > Signed-off-by: Simon Glass > Revi

Re: [U-Boot] [PATCH v2 15/50] x86: Add a handoff header file

2019-05-01 Thread Bin Meng
On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > Add an arch-specific handoff header so that we can use the HANDOFF feature > on x86 devices. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v2: None > > arch/x86/include/asm/handoff.h | 15 +++ > 1

Re: [U-Boot] [PATCH v2 12/50] x86: Update a stale comment about ifdtool

2019-05-01 Thread Bin Meng
On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > We use binman to build the x86 image now. Update a comment which still > refers to ifdtool. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v2: > - Update the comment in fsp_cap.S too > > arch/x86/cpu/intel_comm

Re: [U-Boot] [PATCH v2 13/50] x86: Support SPL and TPL

2019-05-01 Thread Bin Meng
On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > At present only chromebook_link64 supports SPL. It is useful to eb able to > support both TPL and SPL to implement verified boot on x86. > > Enable the options for both along with some suitable default options > needed to boot through these p

Re: [U-Boot] [PATCH v2 11/50] x86: dts: Add device-tree labels for rtc and reset

2019-05-01 Thread Bin Meng
On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > Add labels for these nodes so that board DT files can reference them. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v2: None > > arch/x86/dts/reset.dtsi | 2 +- > arch/x86/dts/rtc.dtsi | 2 +- > 2 files chan

Re: [U-Boot] [PATCH v2 09/50] x86: mp_init: Use proper error numbers

2019-05-01 Thread Bin Meng
On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > At present many of the functions in this file return -1 as an error > number. which is -EPERM. Update the code to use real error numbers. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v2: None > > arch/x86/cpu

Re: [U-Boot] [PATCH v2 06/50] spl: Allow sandbox to build a device-tree file

2019-05-01 Thread Bin Meng
On Wed, May 1, 2019 at 8:13 PM Bin Meng wrote: > > On Fri, Apr 26, 2019 at 11:59 AM Simon Glass wrote: > > > > At present only OF_SEPARATE is considered valid for building a device-tree > > file in SPL. However sandbox uses OF_HOSTFILE instead. Update the logic to > > handle this and make it easi

Re: [U-Boot] [PATCH v2 08/50] x86: start64: Fix copyright message

2019-05-01 Thread Bin Meng
On Fri, Apr 26, 2019 at 11:59 AM Simon Glass wrote: > > There is a typo in this header. Fix it. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v2: None > > arch/x86/cpu/start64.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > applied to u-boot-x86, thank

Re: [U-Boot] [PATCH v2 07/50] binman: Allow sections to have an offset

2019-05-01 Thread Bin Meng
On Wed, May 1, 2019 at 8:13 PM Bin Meng wrote: > > On Fri, Apr 26, 2019 at 11:59 AM Simon Glass wrote: > > > > At present sections are always placed automatically. Even if an 'offset' > > property is provided it is ignored. Update the logic to support an offset > > for sections. > > > > Signed-of

Re: [U-Boot] [PATCH v2 10/50] x86: Add a way to reinit the cpu

2019-05-01 Thread Bin Meng
On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > We cannot init the CPU fully both than once during a boot. Add a new > function which can be called to figure out the CPU identity, but which > does not change anything. For x86_64, this is empty for now. > > Signed-off-by: Simon Glass > Rev

Re: [U-Boot] [PATCH v2 04/50] dm: core: Fix translate condition in ofnode_get_addr_size()

2019-05-01 Thread Bin Meng
On Fri, Apr 26, 2019 at 11:59 AM Simon Glass wrote: > > Update the condition to translate only if this is enabled for SPL. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v2: None > > drivers/core/ofnode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > ap

Re: [U-Boot] [PATCH v2 03/50] binman: Add a missing comment in Entry_vblock

2019-05-01 Thread Bin Meng
On Fri, Apr 26, 2019 at 11:59 AM Simon Glass wrote: > > An important property is missing. Update the entry comment to include > this. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v2: None > > tools/binman/etype/vblock.py | 1 + > 1 file changed, 1 insertion(+) >

Re: [U-Boot] [PATCH v2 02/50] binman: Don't show image-skip message by default

2019-05-01 Thread Bin Meng
On Wed, May 1, 2019 at 7:59 PM Bin Meng wrote: > > On Fri, Apr 26, 2019 at 11:59 AM Simon Glass wrote: > > > > This message is not very important since it is simply indicating that the > > user's instructions are being followed. Only show it when the verbosity > > level is above the default. > >

Re: [U-Boot] [PATCH v2 01/50] binman: Don't generate an error in 'text' entry constructor

2019-05-01 Thread Bin Meng
On Fri, Apr 26, 2019 at 11:59 AM Simon Glass wrote: > > It is not good practice to raise an exception in a constructor. In this > case the 'text' entry may not actually be used, if -i is used to filter > out the images that get built. > > Move the exception to where the data is actually used. > >

Re: [U-Boot] EFIBootGuard for CIP and SecureBoot

2019-05-01 Thread Peter Jones
On Sat, Apr 27, 2019 at 09:56:08AM +0200, Alexander Graf wrote: > > >>> UEFI gets a bad rap at being complicated, but I think the U-Boot work > >>> has shown that implementing the core UEFI ABI doesn't require much code > >>> and isn't the complicated mess they everyone fears it to be. > >> Depend

Re: [U-Boot] [PATCH v2 32/50] x86: sysreset: Implement power-off if available

2019-05-01 Thread Bin Meng
Hi Simon, On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > On modern x86 devices we can power the system off using the power- > management features of the PCH. Add an implementation for this. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Add new patch to implement power-off

Re: [U-Boot] [PATCH v3] Convert CONFIG_SUPPORT_EMMC_BOOT to Kconfig

2019-05-01 Thread Tom Rini
On Wed, May 01, 2019 at 07:58:27AM +, Alex Kiernan wrote: > This converts the following to Kconfig: >CONFIG_SUPPORT_EMMC_BOOT > > As requested by Michal Simek , these boards > have no eMMC so CONFIG_SUPPORT_EMMC_BOOT has not been migrated: > > xilinx_zynqmp_zc1275_revB > xilinx_zynqmp

Re: [U-Boot] [PATCH v2 31/50] x86: broadwell: Implement PCH_REQ_PMBASE_INFO

2019-05-01 Thread Bin Meng
On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > Implement this ioctl() to support power off. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Add new patch to implement PCH_REQ_PMBASE_INFO on broadwell > > arch/x86/cpu/broadwell/pch.c | 25 + > 1 file c

Re: [U-Boot] [PATCH 3/6] clk: imx8qm: fix usdhc2 clocks

2019-05-01 Thread Max Krummenacher
Reviewed-by: Max Krummenacher On Tue, 2019-04-30 at 12:06 +0200, Marcel Ziswiler wrote: > Trying to bring up uSDHC2 the following error message was observed: > > MMC: imx8_clk_set_rate(Invalid clk ID #60) > imx8_clk_set_rate(Invalid clk ID #60) > usdhc@5b03 - probe failed: -22 > > This co

[U-Boot] [PATCH] tools/Makefile: fix HOSTCFLAGS with CROSS_BUILD_TOOLS

2019-05-01 Thread Fabrice Fontaine
When CROSS_BUILD_TOOLS is set, set HOSTCFLAGS to CFLAGS otherwise CC will be used with HOSTCFLAGS which seems wrong Signed-off-by: Fabrice Fontaine --- tools/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/Makefile b/tools/Makefile index 12a3027e23..eadeba417d 100644 --- a/too

[U-Boot] [PATCH v3] Convert CONFIG_SUPPORT_EMMC_BOOT to Kconfig

2019-05-01 Thread Alex Kiernan
This converts the following to Kconfig: CONFIG_SUPPORT_EMMC_BOOT As requested by Michal Simek , these boards have no eMMC so CONFIG_SUPPORT_EMMC_BOOT has not been migrated: xilinx_zynqmp_zc1275_revB xilinx_zynqmp_zc1751_xm018_dc4 xilinx_zynqmp_zc1751_xm019_dc5 xilinx_zynqmp_zcu100_revC

Re: [U-Boot] [PATCH] core: ofnode: Fix ASAN-reported stack-buffer-overflow in of_get_address

2019-05-01 Thread Stephen Finucane
On Tue, 2019-04-30 at 14:28 +0200, Eugeniu Rosca wrote: > Hi Jeremy, > > Would you kindly feedback if it's possible to include commit > https://github.com/getpatchwork/patchwork/commit/67faf96ab96d932 > into U-Boot's patchwork to avoid occasional glitches in the > description of U-Boot commits? T

Re: [U-Boot] [PATCH 5/6] imx8: fuse: fix fuse driver

2019-05-01 Thread Max Krummenacher
Reviewed-by: Max Krummenacher On Tue, 2019-04-30 at 12:06 +0200, Marcel Ziswiler wrote: > This fixes the i.MX 8 fuse driver to actually build for i.MX 8QM as > well. > > Signed-off-by: Marcel Ziswiler > > --- > > drivers/misc/imx8/fuse.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --g

Re: [U-Boot] [PATCH 2/6] arm: dts: imx8qm: add support for i2c0, i2c1, i2c2, i2c3 and i2c4

2019-05-01 Thread Max Krummenacher
Reviewed-by: Max Krummenacher On Tue, 2019-04-30 at 12:06 +0200, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > Add support for i2c0, i2c1, i2c2, i2c3 and i2c4. > > Signed-off-by: Marcel Ziswiler > > --- > > arch/arm/dts/fsl-imx8qm.dtsi | 75 > 1 fi

Re: [U-Boot] [PATCH 4/6] imx8qm: fix cpu frequency reporting

2019-05-01 Thread Max Krummenacher
See review comment below. With the issue resolved: Reviewed-by: Max Krummenacher On Tue, 2019-04-30 at 12:06 +0200, Marcel Ziswiler wrote: > CPU frequency reporting failed with the following error message being > printed: > > sc_pm_get_clock_rate: resource:507 clk:2: res:3 > Could not read CPU

Re: [U-Boot] [PATCH 6/6] board: toradex: add apalis imx8qm 4gb wb it v1.0b module support

2019-05-01 Thread Max Krummenacher
See review comments below. (Marked with 'Review Max:') With the issue resolved: Reviewed-by: Max Krummenacher On Tue, 2019-04-30 at 12:06 +0200, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > This commit adds initial support for the Toradex Apalis iMX8QM 4GB WB IT > V1.0B module. Unlike th

Re: [U-Boot] [PATCH 1/6] arm: dts: imx8qm: add lpuart1, lpuart2, lpuart3, lpuart4

2019-05-01 Thread Max Krummenacher
Reviewed-by: Max Krummenacher On Tue, 2019-04-30 at 12:06 +0200, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > Add support for lpuart1, lpuart2, lpuart3 and lpuart4. > > Signed-off-by: Marcel Ziswiler > > --- > > arch/arm/dts/fsl-imx8qm.dtsi | 80 >

Re: [U-Boot] [PATCH v2 29/50] x86: pch: Add an ioctl to read power-management info

2019-05-01 Thread Bin Meng
On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > Add a new ioctl() request to read information about the power-management > system. This can be used to power off the device. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Add new patch to add an ioctl to read power-management i

Re: [U-Boot] [PATCH v2 30/50] x86: ivybridge: Implement PCH_REQ_PMBASE_INFO

2019-05-01 Thread Bin Meng
On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > Implement this ioctl() to support power off. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Add new patch to implement PCH_REQ_PMBASE_INFO on ivybridge > > arch/x86/cpu/ivybridge/bd82x6x.c | 15 +++ > 1 file changed

  1   2   >