Re: [U-Boot] [PATCH] xyz-modem: Fix timeout loop waiting with WATCHDOG

2017-09-16 Thread Lokesh Vutla
Simon, On 9/16/2017 9:43 PM, Simon Glass wrote: > Hi, > > On 16 September 2017 at 07:43, Tom Rini wrote: >> On Sat, Sep 16, 2017 at 05:14:31PM +0530, Lokesh Vutla wrote: >>> Commit 2c77c0d6524eb ("xyz-modem: Change getc timeout loop waiting") >>> fixes the loop delay when using a hw watchdog. Bu

Re: [U-Boot] [PATCH] test/py: gpt: make use of infra-structure

2017-09-16 Thread Alison Chaiken
I suggest that while we're cleaning this test up, that we add something like this to each of the tests: diff --git a/test/py/tests/test_gpt.py b/test/py/tests/test_gpt.py index e2bbd08e6d..485d092371 100644 --- a/test/py/tests/test_gpt.py +++ b/test/py/tests/test_gpt.py @@ -67,6 +67,8 @@ def state

Re: [U-Boot] [PATCH] cmd/gpt.c: Fix warning over memset args in allocate_disk_part

2017-09-16 Thread Alison Chaiken
On Fri, Sep 15, 2017 at 5:02 AM, Tom Rini wrote: > With clang-3.8 we see: > cmd/gpt.c:196:31: warning: 'memset' call operates on objects > of type 'struct disk_part' while the size is based on a different > type > 'struct disk_part *' [-Wsizeof-pointer-memaccess] > memset(newp

Re: [U-Boot] Please pull u-boot-fdt

2017-09-16 Thread Tom Rini
On Fri, Sep 15, 2017 at 01:31:29PM -0600, Simon Glass wrote: > Hi Tom, > > Here are the overlay and dtoc series. > > > The following changes since commit 5541543f686b43210fb92181003ff7175d4ab036: > > configs: at91: Remove CONFIG_SYS_EXTRA_OPTIONS assignment > (2017-09-14 16:02:48 -0400) > >

[U-Boot] [PATCH 05/13] Drop the log buffer

2017-09-16 Thread Simon Glass
This does not appear to be used by any boards. Before introducing a new log system, remove this old one. Signed-off-by: Simon Glass --- cmd/Makefile | 1 - cmd/log.c | 313 -- common/board_f.c |

[U-Boot] [PATCH 00/13] log: Add a new logging feature

2017-09-16 Thread Simon Glass
U-Boot currently has fairly rudimentary logging features. A basic printf() provides console output and debug() provides debug output which is activated if DEBUG is defined in the file containing the debug() statements. It would be useful to have a few more features: - control of debug output at r

[U-Boot] [PATCH 11/13] log: sandbox: Enable logging

2017-09-16 Thread Simon Glass
Enable all logging features on sandbox so that the tests can be run. Signed-off-by: Simon Glass --- configs/sandbox_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig index 88ae98d312..0496ad49c8 100644 --- a/configs/sandbox_de

[U-Boot] [PATCH 10/13] log: Plumb logging into the init sequence

2017-09-16 Thread Simon Glass
Set up logging both before and after relocation. Signed-off-by: Simon Glass --- common/board_f.c | 5 - common/board_r.c | 2 ++ common/log.c | 1 + include/asm-generic/global_data.h | 1 + 4 files changed, 8 insertions(+), 1 deletion(-

[U-Boot] [PATCH 12/13] log: test: Add a pytest for logging

2017-09-16 Thread Simon Glass
Add a test which tries out various filters and options to make sure that logging works as expected. Signed-off-by: Simon Glass --- test/py/tests/test_log.py | 106 ++ 1 file changed, 106 insertions(+) create mode 100644 test/py/tests/test_log.py dif

[U-Boot] [PATCH 08/13] log: Add a 'log level' command

2017-09-16 Thread Simon Glass
Add a command for adjusting the log level. Signed-off-by: Simon Glass --- cmd/Kconfig | 7 +++ cmd/Makefile | 1 + cmd/log.c| 55 +++ 3 files changed, 63 insertions(+) create mode 100644 cmd/log.c diff --git a/cmd/Kconfig b/cmd/Kc

[U-Boot] [PATCH 07/13] log: Add a console driver

2017-09-16 Thread Simon Glass
It is useful to display log messages on the console. Add a simple driver to handle this. Signed-off-by: Simon Glass --- common/Kconfig | 20 common/Makefile | 1 + common/log_console.c | 23 +++ 3 files changed, 44 insertions(+) create mode

[U-Boot] [PATCH 13/13] log: Add documentation

2017-09-16 Thread Simon Glass
Add documentation for the log system. Signed-off-by: Simon Glass --- doc/README.log | 220 + 1 file changed, 220 insertions(+) create mode 100644 doc/README.log diff --git a/doc/README.log b/doc/README.log new file mode 100644 index

[U-Boot] [PATCH 09/13] log: Add a test command

2017-09-16 Thread Simon Glass
Add a command which exercises the logging system. Signed-off-by: Simon Glass --- cmd/Kconfig | 3 +- cmd/log.c | 6 ++ common/Kconfig | 10 +++ include/log.h | 3 + test/Makefile | 1 + test/log/Makefile | 7 ++ test/log/log_test.c | 204 +

[U-Boot] [PATCH 06/13] log: Add an implemention of logging

2017-09-16 Thread Simon Glass
Add the logging header file and implementation with some configuration options to control it. Signed-off-by: Simon Glass --- MAINTAINERS | 9 ++ common/Kconfig| 56 + common/Makefile | 1 + common/log.c

[U-Boot] [PATCH 04/13] mtdparts: Correct use of debug()

2017-09-16 Thread Simon Glass
The debug() macro now evaluates its expression so does not need #ifdef protection. In fact the current code causes a warning with the new log implementation. Adjust the code to fix this. Signed-off-by: Simon Glass --- cmd/mtdparts.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/cmd/mtdp

[U-Boot] [PATCH 02/13] Revert "sandbox: Drop special case console code for sandbox"

2017-09-16 Thread Simon Glass
While sandbox works OK without the special-case code, it does result in console output being stored in the pre-console buffer while sandbox starts up. If there is a crash or a problem then there is no indication of what is going on. For ease of debugging it seems better to revert this change also.

[U-Boot] [PATCH 03/13] Move debug and logging support to a separate header

2017-09-16 Thread Simon Glass
Before adding new features, move these definitions to a separate header to avoid further cluttering common.h. Signed-off-by: Simon Glass --- include/common.h | 64 + include/log.h| 79 2 fil

[U-Boot] [PATCH 01/13] Revert "sandbox: remove os_putc() and os_puts()"

2017-09-16 Thread Simon Glass
While sandbox works OK without the special-case code, it does result in console output being stored in the pre-console buffer while sandbox starts up. If there is a crash or a problem then there is no indication of what is going on. For ease of debugging it seems better to revert this change. Thi

Re: [U-Boot] [U-Boot, v3, 3/9] fat/fs: convert to directory iterators

2017-09-16 Thread Rob Clark
On Sat, Sep 16, 2017 at 4:32 PM, Adam Ford wrote: > On Fri, Sep 15, 2017 at 9:32 PM, Tom Rini wrote: >> >> On Sat, Sep 09, 2017 at 01:15:54PM -0400, Rob Clark wrote: >> >> > And drop a whole lot of ugly code! >> > >> > Signed-off-by: Rob Clark >> > Reviewed-by: Łukasz Majewski >> > Reviewed-by:

Re: [U-Boot] [U-Boot, v3, 3/9] fat/fs: convert to directory iterators

2017-09-16 Thread Adam Ford
On Fri, Sep 15, 2017 at 9:32 PM, Tom Rini wrote: > > On Sat, Sep 09, 2017 at 01:15:54PM -0400, Rob Clark wrote: > > > And drop a whole lot of ugly code! > > > > Signed-off-by: Rob Clark > > Reviewed-by: Łukasz Majewski > > Reviewed-by: Simon Glass > > Applied to u-boot/master, thanks! > Accord

[U-Boot] Adding new net command

2017-09-16 Thread Duncan Hare
I'm attempting to add a "wget" command. It  mostly there by I cannot find out how to set the  #define CONFIG_CMD_WGET 1 into u-boot cfg by handand got a terse message to use a Kconfig file. Which Konfig file should I used for defining the absence/presence of this new command? For development

Re: [U-Boot] [PATCH 00/22] mmc: Add support for HS200 and UHS modes

2017-09-16 Thread Marek Vasut
On 09/15/2017 03:20 PM, Jean-Jacques Hiblot wrote: > Hi Jaehoon, > > What is the status on this one? I'd like to know that too. Plus all the other outstanding SD/MMC patches which block other stuff and already missed at least one MW ... > Do you still have issues with some platforms? > > Jean-J

Re: [U-Boot] [PATCH] xyz-modem: Fix timeout loop waiting with WATCHDOG

2017-09-16 Thread Simon Glass
Hi, On 16 September 2017 at 07:43, Tom Rini wrote: > On Sat, Sep 16, 2017 at 05:14:31PM +0530, Lokesh Vutla wrote: >> Commit 2c77c0d6524eb ("xyz-modem: Change getc timeout loop waiting") >> fixes the loop delay when using a hw watchdog. But assuming that Watchdog >> kicking is taken care of by ge

Re: [U-Boot] [PATCH] xyz-modem: Fix timeout loop waiting with WATCHDOG

2017-09-16 Thread Tom Rini
On Sat, Sep 16, 2017 at 05:14:31PM +0530, Lokesh Vutla wrote: > Commit 2c77c0d6524eb ("xyz-modem: Change getc timeout loop waiting") > fixes the loop delay when using a hw watchdog. But assuming that Watchdog > kicking is taken care of by getc(). This is not true in case of DM_SERIAL. > So, kick th

[U-Boot] [PATCH] efi_loader: fix TEST_PROTOCOL case in OpenProtocol()

2017-09-16 Thread Rob Clark
In the TEST_PROTOCOL case, protocol_interface might be NULL, and at any rate should not be touched. So skip efi_protocol_open() in this case. Fixes: "efi_loader: open_info in OpenProtocol" Signed-off-by: Rob Clark --- lib/efi_loader/efi_boottime.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[U-Boot] [PATCH] xyz-modem: Fix timeout loop waiting with WATCHDOG

2017-09-16 Thread Lokesh Vutla
Commit 2c77c0d6524eb ("xyz-modem: Change getc timeout loop waiting") fixes the loop delay when using a hw watchdog. But assuming that Watchdog kicking is taken care of by getc(). This is not true in case of DM_SERIAL. So, kick the watchdog before loop waiting, instead of relying on other functions.

[U-Boot] Please pull u-boot-x86

2017-09-16 Thread Bin Meng
Hi Tom, The following changes since commit 079c92b0a77b9a9bf237a9430ed16cf81d43ce5d: ARM: davinci: Remove CONFIG_SOC_DA830 (2017-09-15 12:35:48 -0400) are available in the git repository at: git://git.denx.de/u-boot-x86.git for you to fetch changes up to 8a1c44271c55961fb70fb6177f9c02fdb05