[U-Boot] [PATCH] configs: keystone2: Standardise U-boot prompt

Standardise U-Boot prompt on all keystone2 platforms instead of platform specific prompt. Signed-off-by: Lokesh Vutla --- configs/k2e_evm_defconfig | 1 - configs/k2e_hs_evm_defconfig | 1 - configs/k2hk_evm_defconfig| 1 - configs/k2hk_hs_evm_defconfig | 1 - configs/k2l_evm_defconfig

[U-Boot] [PATCH] board: dra71: Fix selection of OPPs

As per the DM[1] Dated June 2016–Revised February 2017, Table 5-3, DRA71 supports the following OPPs for various voltage domains: VDD_MPU:OPP_NOM VDD_CORE: OPP_NOM VDD_GPU:OPP_NOM VDD_DSPEVE: OPP_NOM, OPP_HIGH VDD_IVA:OPP_NOM, OPP_HIGH This patch add support for

Re: [U-Boot] Please pull u-boot-video/master

On Fri, Apr 14, 2017 at 09:00:16PM +0200, Anatolij Gustschin wrote: > Hi Tom, > > The following changes since commit 40a808f173008729a0c631ab84693b6a2b0dcfc9: > > ARCv2: SLC: Make sure busy bit is set properly on SLC flushing (2017-04-11 > 17:54:31 +0300) > > are available in the git reposit

Re: [U-Boot] [PATCH v7 2/3] mmc: meson: add MMC driver for Meson GX (S905)

On 04/15/2017 11:51 PM, Andreas Färber wrote: > Am 15.04.2017 um 23:16 schrieb Andreas Färber: >> Am 15.04.2017 um 23:04 schrieb Alexander Graf: Am 15.04.2017 um 22:34 schrieb Andreas Färber : > Am 15.04.2017 um 20:27 schrieb Alexander Graf: >> On 15.04.17 20:18, Heiner Kallweit wrote:

Re: [U-Boot] [PATCH v3 19/19] sunxi: update Pine64 README

Hi Andre, Thanks for your awesome work on getting things in shape! Am 01.04.2017 um 00:31 schrieb Andre Przywara: > +Quick Start / Overview > +== > +- Build the ARM Trusted Firmware binary (see "ARM Trusted firmware (ATF)" > below) > +- Build U-Boot (see "SPL/U-Boot" below) >

Re: [U-Boot] [PATCH v2 1/2] power: regulator: pwm: support pwm polarity setting

Hi Kever, On 11 April 2017 at 02:35, Kever Yang wrote: > The latest kernel PWM drivers enable the polarity settings. When system > run from U-Boot to kerenl, if there are differences in polarity set or > duty cycle, the PMW will re-init: > close -> set polarity and duty cycle -> enable the PWM.

[U-Boot] [PATCH v2 14/14] u-boot.elf: build it for every arch

ARM64 isn't the only arch that needs it, since BMIPS CFE supports loading .elf images instead of raw binaries. Signed-off-by: Álvaro Fernández Rojas --- v2: Introduce changes suggested by Daniel Schwierzeck: - Avoid using a linker script. - Reuse aarch64 u-boot.elf generation for other archs

[U-Boot] [PATCH v2 06/14] ram: add RAM driver for Broadcom MIPS SoCs

Signed-off-by: Álvaro Fernández Rojas --- v2: Introduce changes suggested by Daniel Schwierzeck: - Split BMIPS support patches. drivers/ram/Makefile| 2 + drivers/ram/bmips_ram.c | 126 2 files changed, 128 insertions(+) create mode 100

[U-Boot] [PATCH v2 09/14] MIPS: add BMIPS Huawei HG556a board

Signed-off-by: Álvaro Fernández Rojas --- v2: Introduce changes suggested by Daniel Schwierzeck: - Split BMIPS support patches. - Remove DEBUG_UART from defconfig. arch/mips/dts/Makefile | 1 + arch/mips/dts/huawei,hg556a.dts | 31 +++ arch/mips/mac

[U-Boot] [PATCH v2 04/14] serial: add serial driver for BCM6345

It is based on linux/drivers/tty/serial/bcm63xx_uart.c Signed-off-by: Álvaro Fernández Rojas --- v2: Introduce changes suggested by Daniel Schwierzeck: - Remove unneeded defines. - Fix incorrect multi-line comment. drivers/serial/Kconfig | 14 +++ drivers/serial/Makefile

[U-Boot] [PATCH v2 13/14] MIPS: add BMIPS Comtrend VR-3032u board

Signed-off-by: Álvaro Fernández Rojas --- v2: Introduce changes suggested by Daniel Schwierzeck: - Split BMIPS support patches. - Remove DEBUG_UART from defconfig. arch/mips/dts/Makefile | 1 + arch/mips/dts/comtrend,vr-3032u.dts| 27 ++ arch/mips/ma

[U-Boot] [PATCH v2 12/14] MIPS: add support for Broadcom MIPS BCM63268 SoC family

Signed-off-by: Álvaro Fernández Rojas --- v2: Introduce changes suggested by Daniel Schwierzeck: - Split BMIPS support patches. - Add PERF_BASE to cpus. arch/mips/dts/brcm,bcm63268.dtsi | 88 arch/mips/mach-bmips/Kconfig | 12 ++ include/conf

[U-Boot] [PATCH v2 11/14] MIPS: add BMIPS Comtrend AR-5387un board

Signed-off-by: Álvaro Fernández Rojas --- v2: Introduce changes suggested by Daniel Schwierzeck: - Split BMIPS support patches. - Remove DEBUG_UART from defconfig. arch/mips/dts/Makefile | 1 + arch/mips/dts/comtrend,ar-5387un.dts| 27 + arch/mips/m

[U-Boot] [PATCH v2 05/14] cpu: add CPU driver for Broadcom MIPS SoCs

Signed-off-by: Álvaro Fernández Rojas --- v2: Introduce changes suggested by Daniel Schwierzeck: - Split BMIPS support patches. - Get register base from DT. drivers/cpu/Makefile| 2 + drivers/cpu/bmips_cpu.c | 271 2 files changed, 273

[U-Boot] [PATCH v2 10/14] MIPS: add support for Broadcom MIPS BCM6328 SoC family

Signed-off-by: Álvaro Fernández Rojas --- v2: Introduce changes suggested by Daniel Schwierzeck: - Split BMIPS support patches. - Add PERF_BASE to cpus. arch/mips/dts/brcm,bcm6328.dtsi | 88 + arch/mips/mach-bmips/Kconfig| 12 ++ include/confi

[U-Boot] [PATCH v2 07/14] MIPS: add initial infrastructure for Broadcom MIPS SoCs

CFE checks CPU Thread in a different way (using register $22): mfc0t1, C0_BCM_CONFIG, 3 # $22 li t2, CP0_CMT_TPID # (1 << 31) and t1, t2 bnezt1, 2f # if we are running on thread 1, skip init nop Signed-off-by: Álvaro Fernández Rojas --- v2: Introduce changes suggested by Daniel

[U-Boot] [PATCH v2 03/14] MIPS: allow using generic sysreset drivers

Avoid duplicating do_reset definition if SYSRESET is enabled for MIPS Signed-off-by: Álvaro Fernández Rojas --- v2: no changes arch/mips/cpu/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/mips/cpu/cpu.c b/arch/mips/cpu/cpu.c index 1b919ed..55e6498 100644 --- a/arch/mips/cpu/c

[U-Boot] [PATCH v2 02/14] sysreset: add syscon-reboot driver

Add a new sysreset driver based on linux/drivers/power/reset/syscon-reboot.c, which provides a generic driver for platforms that only require writing a mask to a regmap offset. Signed-off-by: Álvaro Fernández Rojas --- v2: no changes drivers/sysreset/Kconfig | 8 + drivers/sysre

[U-Boot] [PATCH v2 08/14] MIPS: add support for Broadcom MIPS BCM6358 SoC family

Signed-off-by: Álvaro Fernández Rojas --- v2: Introduce changes suggested by Daniel Schwierzeck: - Split BMIPS support patches. - Add PERF_BASE to cpus. - Merge with "fix ioremap for BCM6358" patch. - Add a custom ioremap.h instead of modifying the generic one. arch/mips/dts/brcm,bcm635

[U-Boot] [PATCH v2 01/14] cmd: cpu: fix NULL cpu feature prints

Commit 740d5d3 added two new features but only one feature name, which results in NULL prints when device_id feature is selected. Before: HG556a # cpu detail -1: cpu@0 BCM6358A1 ID = 0, freq = 300 MHz: L1 cache, MMU, NULL Device ID 0x2a010

[U-Boot] [PATCH v2 00/14] Add support for Broadcom MIPS SoCs

This adds support for some of the xDSL Broadcom MIPS SoCs: - BCM6358 - BCM6328 - BCM63268 However, support for other SoCs could be added in the future: - Other BCM63xx - BCM33xx - BCM71xx v2: Introduce changes suggested by Daniel Schwierzeck Álvaro Fernández Rojas (14): cmd: cpu: fix NULL

Re: [U-Boot] [PATCH v7 2/3] mmc: meson: add MMC driver for Meson GX (S905)

Am 15.04.2017 um 23:16 schrieb Andreas Färber: > Am 15.04.2017 um 23:04 schrieb Alexander Graf: >>> Am 15.04.2017 um 22:34 schrieb Andreas Färber : Am 15.04.2017 um 20:27 schrieb Alexander Graf: > On 15.04.17 20:18, Heiner Kallweit wrote: >> Am 15.04.2017 um 17:05 schrieb Andreas Färbe

Re: [U-Boot] [PATCH v7 2/3] mmc: meson: add MMC driver for Meson GX (S905)

Am 15.04.2017 um 23:04 schrieb Alexander Graf: >> Am 15.04.2017 um 22:34 schrieb Andreas Färber : >>> Am 15.04.2017 um 20:27 schrieb Alexander Graf: On 15.04.17 20:18, Heiner Kallweit wrote: > Am 15.04.2017 um 17:05 schrieb Andreas Färber: > But for the Vega S95 Telos I needed to disab

Re: [U-Boot] [PATCH v7 2/3] mmc: meson: add MMC driver for Meson GX (S905)

Am 15.04.2017 um 22:52 schrieb Heinrich Schuchardt: > On 04/15/2017 10:34 PM, Andreas Färber wrote: >> U-Boot 2017.05-rc1-00318-g082535f-dirty (Apr 15 2017 - 22:29:17 +0200) >> vega-s95 >> >> DRAM: 2 GiB >> MMC: mmc@7: 0, mmc@72000: 1, mmc@74000: 2 >> Using default environment >> >> In:s

Re: [U-Boot] [PATCH v7 2/3] mmc: meson: add MMC driver for Meson GX (S905)

> Am 15.04.2017 um 22:34 schrieb Andreas Färber : > >> Am 15.04.2017 um 20:27 schrieb Alexander Graf: >>> On 15.04.17 20:18, Heiner Kallweit wrote: Am 15.04.2017 um 17:05 schrieb Andreas Färber: But for the Vega S95 Telos I needed to disable the first of three MMC nodes (SDIO) - o

Re: [U-Boot] [PATCH v7 2/3] mmc: meson: add MMC driver for Meson GX (S905)

On 04/15/2017 10:34 PM, Andreas Färber wrote: > Am 15.04.2017 um 20:27 schrieb Alexander Graf: >> On 15.04.17 20:18, Heiner Kallweit wrote: >>> Am 15.04.2017 um 17:05 schrieb Andreas Färber: But for the Vega S95 Telos I needed to disable the first of three MMC nodes (SDIO) - otherwise U-B

Re: [U-Boot] [PATCH v7 2/3] mmc: meson: add MMC driver for Meson GX (S905)

Am 15.04.2017 um 20:27 schrieb Alexander Graf: > On 15.04.17 20:18, Heiner Kallweit wrote: >> Am 15.04.2017 um 17:05 schrieb Andreas Färber: >>> But for the Vega S95 Telos I needed to disable the first of three MMC >>> nodes (SDIO) - otherwise U-Boot would happily iterate over them for >>> distro b

Re: [U-Boot] [PATCH v7 2/3] mmc: meson: add MMC driver for Meson GX (S905)

On 15.04.17 21:13, Heinrich Schuchardt wrote: On 04/15/2017 08:27 PM, Alexander Graf wrote: On 15.04.17 20:18, Heiner Kallweit wrote: Am 15.04.2017 um 17:05 schrieb Andreas Färber: Am 14.04.2017 um 08:22 schrieb Jaehoon Chung: On 04/13/2017 03:30 AM, Heiner Kallweit wrote: From: Carlo Ca

[U-Boot] [PATCH v3 1/1] meson: gxbb: enable MMC as boot target

To enable automatic booting from SD card or eMMC the MMC devices 0, 1, and 2 are added to the BOOT_TARGET_DEVICES. Booting from SD card, eMMC, and DHCP are tried in sequence. A missing or failing device is gracefully handled. Cc: Andreas Färber Signed-off-by: Heinrich Schuchardt --- v3: Adjus

Re: [U-Boot] [PATCH 8/8] mips: bmips: add support for raw .elf images

Hi, El 15/04/2017 a las 21:14, Álvaro Fernández Rojas escribió: > Hi, > > El 15/04/2017 a las 20:54, Daniel Schwierzeck escribió: >> >> >> Am 15.04.2017 um 20:10 schrieb Álvaro Fernández Rojas: >>> Hi, >>> >>> El 15/04/2017 a las 19:19, Álvaro Fernández Rojas escribió: El 14/04/201

Re: [U-Boot] [PATCH 7/8] mips: bmips: fix ioremap for BCM6358

Hi, El 15/04/2017 a las 20:48, Daniel Schwierzeck escribió: > > > Am 15.04.2017 um 20:08 schrieb Álvaro Fernández Rojas: >> Hi again, >> >> El 15/04/2017 a las 19:18, Álvaro Fernández Rojas escribió: >>> Hi Daniel, >>> >>> El 14/04/2017 a las 20:26, Daniel Schwierzeck escribió: Am

Re: [U-Boot] [PATCH v2 1/1] odroid-c2: enable MMC as boot target

Am 14.04.2017 um 16:35 schrieb Andreas Färber: > Am 14.04.2017 um 16:33 schrieb Heinrich Schuchardt: >> To enable automatic booting from SD card or eMMC the MMC devices 0 and 1 >> are added to the BOOT_TARGET_DEVICES. >> >> Booting from SD card, eMMC, and DHCP are tried in sequence. >> A missing or

Re: [U-Boot] [PATCH 8/8] mips: bmips: add support for raw .elf images

Hi, El 15/04/2017 a las 20:54, Daniel Schwierzeck escribió: > > > Am 15.04.2017 um 20:10 schrieb Álvaro Fernández Rojas: >> Hi, >> >> El 15/04/2017 a las 19:19, Álvaro Fernández Rojas escribió: >>> >>> >>> El 14/04/2017 a las 21:05, Daniel Schwierzeck escribió: Am 13.04.2017 um 17

Re: [U-Boot] [PATCH v7 2/3] mmc: meson: add MMC driver for Meson GX (S905)

On 04/15/2017 08:27 PM, Alexander Graf wrote: > > > On 15.04.17 20:18, Heiner Kallweit wrote: >> Am 15.04.2017 um 17:05 schrieb Andreas Färber: >>> Am 14.04.2017 um 08:22 schrieb Jaehoon Chung: On 04/13/2017 03:30 AM, Heiner Kallweit wrote: > From: Carlo Caione > This driver impleme

[U-Boot] [PATCH v2] rockchip: Print a message when returning to the bootrom

At present if the return to bootrom fails (e.g. because you are not using the Rockchip's bootrom's pointer table in MMC) then the board prints SPL message and hangs. Print a message first if we can, to help in understanding what happened when it hangs. Signed-off-by: Simon Glass Tested-by: Heiko

[U-Boot] Please pull u-boot-rockchip

Hi Tom. Here are the rest of the rockchip changes. I have not been able to include the MIPI driver as it still needs work. Depending on timing that might come later but more likely it will go to -next. The following changes since commit fbeb33752999e7317113199ef89873d6b6916814: buildman: Tran

Re: [U-Boot] [PATCH 8/8] mips: bmips: add support for raw .elf images

Am 15.04.2017 um 20:10 schrieb Álvaro Fernández Rojas: > Hi, > > El 15/04/2017 a las 19:19, Álvaro Fernández Rojas escribió: >> >> >> El 14/04/2017 a las 21:05, Daniel Schwierzeck escribió: >>> >>> >>> Am 13.04.2017 um 17:52 schrieb Álvaro Fernández Rojas: CFE supports loading .elf images i

Re: [U-Boot] [PATCH 1/2] arm: dts: odroid-c2: assign mmc device number 0 to eMMC slot

Am 14.04.2017 um 17:52 schrieb Heiner Kallweit: > Am 14.04.2017 um 15:39 schrieb Andreas Färber: >> Am 14.04.2017 um 10:24 schrieb Heiner Kallweit: >>> In most cases Odroid C2 is used with a eMMC card. So far the eMMC slot >>> was assigned dev number 1 (0 is the SD slot). So on uboot prompt >> >> U

Re: [U-Boot] [PATCH 7/8] mips: bmips: fix ioremap for BCM6358

Am 15.04.2017 um 20:08 schrieb Álvaro Fernández Rojas: > Hi again, > > El 15/04/2017 a las 19:18, Álvaro Fernández Rojas escribió: >> Hi Daniel, >> >> El 14/04/2017 a las 20:26, Daniel Schwierzeck escribió: >>> >>> >>> Am 13.04.2017 um 17:52 schrieb Álvaro Fernández Rojas: BCM6358 has its i

Re: [U-Boot] [PATCH] x86: zImage: avoid potential NULL dereference

On Sat, Apr 15, 2017 at 06:30:21PM +0200, Heinrich Schuchardt wrote: > On 04/15/2017 06:12 PM, Tom Rini wrote: > > On Sat, Apr 15, 2017 at 03:58:55PM +0200, Heinrich Schuchardt wrote: > > > >> If bootargs is not assigned getenv("bootargs") will > >> return NULL. > >> Some part of the code is check

Re: [U-Boot] [PATCH v7 2/3] mmc: meson: add MMC driver for Meson GX (S905)

On 15.04.17 20:18, Heiner Kallweit wrote: Am 15.04.2017 um 17:05 schrieb Andreas Färber: Am 14.04.2017 um 08:22 schrieb Jaehoon Chung: On 04/13/2017 03:30 AM, Heiner Kallweit wrote: From: Carlo Caione This driver implements MMC support on Meson GX (S905) based systems. It's based on Carlo C

Re: [U-Boot] [PATCH v7 2/3] mmc: meson: add MMC driver for Meson GX (S905)

Am 15.04.2017 um 17:05 schrieb Andreas Färber: > Am 14.04.2017 um 08:22 schrieb Jaehoon Chung: >> On 04/13/2017 03:30 AM, Heiner Kallweit wrote: >>> From: Carlo Caione >>> This driver implements MMC support on Meson GX (S905) based systems. >>> It's based on Carlo Caione's work, changes: >>> - BLK

Re: [U-Boot] [PATCH 8/8] mips: bmips: add support for raw .elf images

Hi, El 15/04/2017 a las 19:19, Álvaro Fernández Rojas escribió: > > > El 14/04/2017 a las 21:05, Daniel Schwierzeck escribió: >> >> >> Am 13.04.2017 um 17:52 schrieb Álvaro Fernández Rojas: >>> CFE supports loading .elf images instead of raw binaries. >>> >>> Signed-off-by: Álvaro Fernández Roja

Re: [U-Boot] [PATCH 7/8] mips: bmips: fix ioremap for BCM6358

Hi again, El 15/04/2017 a las 19:18, Álvaro Fernández Rojas escribió: > Hi Daniel, > > El 14/04/2017 a las 20:26, Daniel Schwierzeck escribió: >> >> >> Am 13.04.2017 um 17:52 schrieb Álvaro Fernández Rojas: >>> BCM6358 has its internal registers mapped to 0xfffe, which is changed to >>> 0x1ff

Re: [U-Boot] [PATCH v2 2/3] rockchip: dts: Add mipi dsi support for rk3399

On 14 April 2017 at 10:10, Eric Gao wrote: > Add dts config for mipi display, include vop, mipi controller, panel, > backlight.And Enable rk808 for lcd_3v3 in another patch. Please outdent here. > > Signed-off-by: Eric Gao > --- > > arch/arm/dts/rk3399-evb.dts | 84 > +

Re: [U-Boot] [PATCH v2 1/3] rockchip: video: Add mipi dsi driver for rk3399

Hi Eric, On 14 April 2017 at 10:10, Eric Gao wrote: > Add mipi dsi driver for rk chip. To enable this you need to enable DM, > DM_VIDEO > DM_ROCKCHIP_VIDEO, DISPLAY_MIPI in menuconfig. And enable rk808 and it's i2c. > > Signed-off-by: Eric Gao > > --- > > arch/arm/include/asm/arch-rockchip/cru

Re: [U-Boot] [PATCH 5/8] mips: add support for Broadcom MIPS

Hi Daniel, El 14/04/2017 a las 21:23, Daniel Schwierzeck escribió: > > > Am 13.04.2017 um 17:52 schrieb Álvaro Fernández Rojas: >> This target supports some of the xDSL Broadcom MIPS SoCs for now. >> However, support for other SoCs could be added in the future. >> >> Signed-off-by: Álvaro Fernán

Re: [U-Boot] [PATCH 8/8] mips: bmips: add support for raw .elf images

El 14/04/2017 a las 21:05, Daniel Schwierzeck escribió: > > > Am 13.04.2017 um 17:52 schrieb Álvaro Fernández Rojas: >> CFE supports loading .elf images instead of raw binaries. >> >> Signed-off-by: Álvaro Fernández Rojas >> --- >> Makefile | 22 ++ >>

Re: [U-Boot] [PATCH 7/8] mips: bmips: fix ioremap for BCM6358

Hi Daniel, El 14/04/2017 a las 20:26, Daniel Schwierzeck escribió: > > > Am 13.04.2017 um 17:52 schrieb Álvaro Fernández Rojas: >> BCM6358 has its internal registers mapped to 0xfffe, which is changed to >> 0x1ffe when ioremap is called. >> >> Signed-off-by: Álvaro Fernández Rojas >> --

Re: [U-Boot] [PATCH 4/8] serial: add serial driver for BCM6345

Hi Daniel, El 14/04/2017 a las 20:19, Daniel Schwierzeck escribió: > > > Am 13.04.2017 um 17:52 schrieb Álvaro Fernández Rojas: >> It is based on linux/drivers/tty/serial/bcm63xx_uart.c >> >> Signed-off-by: Álvaro Fernández Rojas >> --- >> drivers/serial/Kconfig | 14 ++ >> drivers/s

Re: [U-Boot] [PATCH 1/8] cmd: cpu: fix NULL cpu feature prints

Hi Daniel, El 14/04/2017 a las 19:43, Daniel Schwierzeck escribió: > +cc Simon > > Am 13.04.2017 um 17:52 schrieb Álvaro Fernández Rojas: >> Commit 740d5d3 added two new features but only one feature name, >> which results in NULL prints when device_id feature is selected. >> Fix this by not prin

Re: [U-Boot] [PATCH 03/11] drivers: phy: add generic PHY framework

Hi Jean-Jacques, On 14 April 2017 at 05:08, Jean-Jacques Hiblot wrote: > The PHY framework provides a set of APIs to control a PHY. This API is > derived from the linux version of the generic PHY framework. > Currently the API supports init(), deinit(), power_on, power_off() and > reset(). The fr

Re: [U-Boot] [PATCH 04/11] dm: test: Add tests for the generic PHY uclass

Hi Jean-Jacques, On 14 April 2017 at 05:08, Jean-Jacques Hiblot wrote: > Those tests check: > - the ability for a phy-user to get a phy device a reference in the > device-tree > - the ability to perform operations on the phy (init,deinit,on,off) > - the behavior of the uclass when optional oper

Re: [U-Boot] [PATCH] drivers/crypto/fsl: remove redundant logical contraint

On 04/15/2017 07:38 AM, Heinrich Schuchardt wrote: 'A || (!A && B)' is equivalent to 'A || B'. Let's reduce the complexity of the statement in start_jr0(). The problem was indicated by cppcheck. Signed-off-by: Heinrich Schuchardt --- drivers/crypto/fsl/jr.c | 3 +-- 1 file changed, 1 insertio

[U-Boot] Please pull u-boot-dm

Hi Tom, This includes the DM LED support, some more Atmel patches and as much of the SCSI changes as I can apply so far. I have not applied the generic phy changes yet as I still have some nits. The following changes since commit fbeb33752999e7317113199ef89873d6b6916814: buildman: Translate m

Re: [U-Boot] [PATCH] ddr: fsl: incorrect logical constraint in populate_memctl_options

On 04/15/2017 06:24 AM, Heinrich Schuchardt wrote: (pdimm[0].data_width >= 32) || (pdimm[0].data_width <= 40) is always true. We should use && here. The problem was indicated by cppcheck. Signed-off-by: Heinrich Schuchardt --- drivers/ddr/fsl/options.c | 2 +- 1 file changed, 1 insertion(+),

Re: [U-Boot] [PATCH v3] rockchip: rk3399: spl: add UART0 support for SPL

On 5 April 2017 at 21:44, Simon Glass wrote: > Hi Philipp, > > On 1 April 2017 at 04:59, Philipp Tomsich > wrote: >> The RK3399-Q7 ("Puma") SoM exposes UART0 as the Qseven UART (i.e. the >> serial line available via standardised pins on the edge connector and >> available on a RS232 connector). >

Re: [U-Boot] [PATCH] x86: zImage: avoid potential NULL dereference

On 04/15/2017 06:12 PM, Tom Rini wrote: > On Sat, Apr 15, 2017 at 03:58:55PM +0200, Heinrich Schuchardt wrote: > >> If bootargs is not assigned getenv("bootargs") will >> return NULL. >> Some part of the code is checking for this condition. >> Other parts dereference a possible NULL pointer. >> >>

Re: [U-Boot] [PATCH v5 1/6] board: sama5d3xek: Update to support DM/DT

On 13 April 2017 at 18:51, Wenyou Yang wrote: > Update the configuration files to support the device tree and > driver model, so do SPL. The device clock and pins configuration > are handled by the clock and the pinctrl drivers respectively. > > Signed-off-by: Wenyou Yang > --- > > Changes in v5:

Re: [U-Boot] [PATCH] x86: zImage: avoid potential NULL dereference

On Sat, Apr 15, 2017 at 03:58:55PM +0200, Heinrich Schuchardt wrote: > If bootargs is not assigned getenv("bootargs") will > return NULL. > Some part of the code is checking for this condition. > Other parts dereference a possible NULL pointer. > > The problem was indicated by cppcheck. > > Sign

Re: [U-Boot] [PATCH v2 8/9] led: Mark existing driver as legacy

On 12 April 2017 at 02:53, Ziping Chen wrote: > > > 2017-04-11 1:34 GMT+08:00 Simon Glass : >> >> The existing 'led' command does not support driver model. Rename it to >> indicate that it is legacy code. >> >> Signed-off-by: Simon Glass >> --- >> >> Changes in v2: None >> >> cmd/Makefile |

Re: [U-Boot] [PATCH v2 1/1] tools/env: avoid memory leak in fw_setenv

On Sat, Apr 15, 2017 at 01:05:40PM +0200, Heinrich Schuchardt wrote: > If realloc fails we should release the old buffer. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Tom Rini -- Tom signature.asc Description: Digital signature ___ U-Boot

Re: [U-Boot] [PATCH] arm: omap-common: add missing va_end()

On Sat, Apr 15, 2017 at 12:29:20PM +0200, Heinrich Schuchardt wrote: > Each call of va_start must be matched by a call of va_end. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Tom Rini -- Tom signature.asc Description: Digital signature ___

Re: [U-Boot] [PATCH] ddr: fsl: incorrect logical constraint in populate_memctl_options

On Sat, Apr 15, 2017 at 03:23:49PM +0200, Heinrich Schuchardt wrote: > (pdimm[0].data_width >= 32) || (pdimm[0].data_width <= 40) > is always true. > > We should use && here. > > The problem was indicated by cppcheck. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Tom Rini -- Tom si

Re: [U-Boot] [PATCH v5 5/6] board: sama5d3_xplained: Clean up code

On 13 April 2017 at 18:51, Wenyou Yang wrote: > Due to the introduction of the pinctrl and clk driver, and using > device tree files, remove the unneeded hardcoded pin configuration > and clock enabling code from the board file. > > Signed-off-by: Wenyou Yang > --- > > Changes in v5: None > Chang

Re: [U-Boot] [PATCH v5 6/6] board: sama5d3_xplained: Enable early debug UART

On 13 April 2017 at 18:51, Wenyou Yang wrote: > Enable the early debug UART to debug problems when an ICE or other > debug mechanism is not available. > > Signed-off-by: Wenyou Yang > --- > > Changes in v5: > - Rebase on the master branch (22e10be45) of u-boot-dm git tree. > - Update the cover-

Re: [U-Boot] [PATCH v5 2/6] board: sama5d3xek: Clean up code

On 13 April 2017 at 18:51, Wenyou Yang wrote: > Due to the introduction of the pinctrl and clk driver, and using > device tree files, remove the unneeded hardcoded pin configuration > and clock enabling code from the board file. > > Signed-off-by: Wenyou Yang > --- > > Changes in v5: None > Chang

Re: [U-Boot] [PATCH] cmd: ubi: remove unnecessary logical constraint

On Sat, Apr 15, 2017 at 04:25:25PM +0200, Heinrich Schuchardt wrote: > A size_t variable can never be negative. > > The problem was indicated by cppcheck. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Tom Rini -- Tom signature.asc Description: Digital signature _

Re: [U-Boot] [PATCH 1/1] fsl/sata: correctly identify failed malloc

On Sat, Apr 15, 2017 at 03:31:53PM +0200, Heinrich Schuchardt wrote: > After allocating sata->cmd_hdr_tbl_offset we have to check > this variable and not variable sata. > > The problem was indicated by cppcheck. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Tom Rini -- Tom signature

Re: [U-Boot] [PATCH] FPGA: drivers/fpga/ivm_core.c: incorrect printf

On Sat, Apr 15, 2017 at 03:15:40PM +0200, Heinrich Schuchardt wrote: > The number of arguments for printf does not match the > format string. > > The problem was indicated by cppcheck. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Tom Rini -- Tom signature.asc Description: Digital s

Re: [U-Boot] [PATCH v5 3/6] board: sama5d3xek: Enable early debug UART

On 13 April 2017 at 18:51, Wenyou Yang wrote: > Enable the early debug UART to debug problems when an ICE or other > debug mechanism is not available. > > Signed-off-by: Wenyou Yang > --- > > Changes in v5: None > Changes in v4: None > Changes in v3: None > Changes in v2: None > > board/atmel/sa

Re: [U-Boot] [PATCH 1/1] usbtty: avoid potential NULL pointer dereference

On Sat, Apr 15, 2017 at 03:05:46PM +0200, Heinrich Schuchardt wrote: > If current_urb is NULL it should not be dereferenced. > > The problem was indicated by cppcheck. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Tom Rini -- Tom signature.asc Description: Digital signature

Re: [U-Boot] [PATCH v2 9/9] dm: led: Add a new 'led' command

On 12 April 2017 at 02:53, Ziping Chen wrote: > > > 2017-04-11 1:34 GMT+08:00 Simon Glass : >> >> When driver model is used for LEDs, provide a command to allow LED access. >> >> Signed-off-by: Simon Glass >> --- >> >> Changes in v2: None >> >> cmd/Kconfig | 9 >> cmd/Makefile | 1 + >>

Re: [U-Boot] [PATCH v5 4/6] board: sama5d3_xplained: Update to support DM/DT

On 13 April 2017 at 18:51, Wenyou Yang wrote: > Update the configuration files to support the device tree and driver > model, so do SPL. The device clock and pins configuration are handled > by the clock and the pinctrl drivers respectively. > > Signed-off-by: Wenyou Yang > --- > > Changes in v5:

Re: [U-Boot] [PATCH v2 4/9] dm: led: Adjust the LED uclass

On 12 April 2017 at 02:52, Ziping Chen wrote: > > > 2017-04-11 1:34 GMT+08:00 Simon Glass : >> >> At present this is very simple, supporting only on and off. We want to >> also support toggling and blinking. As a first step, change the name of >> the main method and use an enum to indicate the sta

Re: [U-Boot] [PATCH v2 08/10] scsi: move the partition initialization out of the scsi detection

On 9 April 2017 at 13:27, Simon Glass wrote: > On 7 April 2017 at 05:42, Jean-Jacques Hiblot wrote: >> We might want to get information about the scsi device without initializing >> the partition. >> >> Signed-off-by: Jean-Jacques Hiblot >> --- >> common/scsi.c | 3 ++- >> 1 file changed, 2 in

Re: [U-Boot] [PATCH 1/1] yaffs2: remove redundant condition

On Sat, Apr 15, 2017 at 01:28:13PM +0200, Heinrich Schuchardt wrote: > If !parent, the changed line is not reached. > So there is no need to check the value again. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Tom Rini -- Tom signature.asc Description: Digital signature _

Re: [U-Boot] [PATCH v2 2/9] dm: led: Add a missing blank line in the Kconfig file

On 12 April 2017 at 02:51, Ziping Chen wrote: > > > 2017-04-11 1:34 GMT+08:00 Simon Glass : >> >> There should be a blank line between each option. Add one before LED_GPIO. >> >> Signed-off-by: Simon Glass >> --- >> >> Changes in v2: >> - Add new patch with blank line in the Kconfig file >> >> d

Re: [U-Boot] [PATCH v2 3/9] dm: led: Rename struct led_uclass_plat

On 12 April 2017 at 02:51, Ziping Chen wrote: > > > 2017-04-11 1:34 GMT+08:00 Simon Glass : >> >> These structures are normally named with 'uc' instead of 'uclass'. Change >> this one for consistency. >> >> Signed-off-by: Simon Glass >> --- >> >> Changes in v2: None >> >> drivers/led/led-uclass.

Re: [U-Boot] [PATCH v2 7/9] dm: led: Add support for blinking LEDs

On 12 April 2017 at 02:52, Ziping Chen wrote: > > > 2017-04-11 1:34 GMT+08:00 Simon Glass : >> >> Allow LEDs to be blinked if the driver supports it. Enable this for >> sandbox so that the tests run. >> >> Signed-off-by: Simon Glass >> --- >> >> Changes in v2: >> - Control this feature via a new

Re: [U-Boot] [PATCH v2 1/9] sandbox: Add some test LEDs

On 12 April 2017 at 02:51, Ziping Chen wrote: > > > 2017-04-11 1:34 GMT+08:00 Simon Glass : >> >> Add some LEDs to the standard sandbox device tree. >> >> Signed-off-by: Simon Glass >> --- >> >> Changes in v2: None >> >> arch/sandbox/dts/sandbox.dts | 14 ++ >> cmd/{led.c => legacy_l

Re: [U-Boot] [PATCH v2 01/10] arm: omap: sata: move enable sata clocks to enable_basic_clocks()

On 7 April 2017 at 05:42, Jean-Jacques Hiblot wrote: > From: Mugunthan V N > > All the clocks which has to be enabled has to be done in > enable_basic_clocks(), so moving enable sata clock to common > clocks enable function. > > Signed-off-by: Mugunthan V N > Signed-off-by: Jean-Jacques Hiblot

Re: [U-Boot] [PATCH v2 09/10] dm: scsi: fix divide-by-0 error in scsi_scan()

On 9 April 2017 at 13:27, Simon Glass wrote: > Hi, > > On 7 April 2017 at 05:42, Jean-Jacques Hiblot wrote: >> With DM_SCSI enabled, blk_create_devicef() is called with blkz = 0, leading >> to a divide-by-0 exception. >> scsi_detect_dev() can be used to get the required parameters (block size >>

Re: [U-Boot] [PATCH v2 5/9] dm: led: Add support for getting the state of an LED

On 12 April 2017 at 02:52, Ziping Chen wrote: > > > 2017-04-11 1:34 GMT+08:00 Simon Glass : >> >> It is useful to be able to read the LED as well as write it. Add this to >> the uclass and update the GPIO driver. >> >> Signed-off-by: Simon Glass >> --- >> >> Changes in v2: None >> >> drivers/led

Re: [U-Boot] [PATCH v2 6/9] dm: led: Support toggling LEDs

On 12 April 2017 at 02:52, Ziping Chen wrote: > > > 2017-04-11 1:34 GMT+08:00 Simon Glass : >> >> Add support for toggling an LED into the uclass interface. This can be >> efficiently implemented by the driver. >> >> Signed-off-by: Simon Glass >> --- >> >> Changes in v2: >> - Drop the explicit as

Re: [U-Boot] [PATCH v2 02/10] arm: omap: sata: compile out board-level sata code when CONFIG_DM_SCSI is defined

On 8 April 2017 at 19:13, Tom Rini wrote: > On Fri, Apr 07, 2017 at 01:42:01PM +0200, Jean-Jacques Hiblot wrote: > >> When CONFIG_DM_SCSI is defined, the SATA initialization will be implemented >> in the scsi-uclass driver. >> >> Signed-off-by: Jean-Jacques Hiblot > > Reviewed-by: Tom Rini > > -

Re: [U-Boot] [PATCH v2 07/10] scsi: make the LUN a parameter of scsi_detect_dev()

On 9 April 2017 at 13:27, Simon Glass wrote: > On 7 April 2017 at 05:42, Jean-Jacques Hiblot wrote: >> This is a cosmetic change. target and LUN have kind of the same role in >> this function. One of them was passed as a parameter and the other was >> embedded in a structure. For consistency, pas

Re: [U-Boot] [PATCH v4 12/19] fdt: Add compatible strings for Arria 10

Hi, On 5 April 2017 at 03:32, Ley Foon Tan wrote: > Add compatible strings for Intel Arria 10 SoCFPGA device. > > Signed-off-by: Tien Fong Chee > Signed-off-by: Ley Foon Tan > --- > include/fdtdec.h | 8 > lib/fdtdec.c | 8 > 2 files changed, 16 insertions(+) > > diff --g

Re: [U-Boot] [PATCH 1/3] buildman: Allow 'gnueabihf' toolchains for ARM

On 14 April 2017 at 17:47, Tom Rini wrote: > Many toolchains for ARM use the 'gnueabihf' suffix rather than just > 'gnueabi', so allow these to be used, but with a lower priority than > 'gnueabi' ones. > > Cc: Simon Glass > Signed-off-by: Tom Rini > --- > tools/buildman/toolchain.py | 5 +++-- >

Re: [U-Boot] [PATCH v7 2/3] mmc: meson: add MMC driver for Meson GX (S905)

Am 14.04.2017 um 08:22 schrieb Jaehoon Chung: > On 04/13/2017 03:30 AM, Heiner Kallweit wrote: >> From: Carlo Caione >> This driver implements MMC support on Meson GX (S905) based systems. >> It's based on Carlo Caione's work, changes: >> - BLK support added >> - general refactoring >> >> Signed-o

[U-Boot] [PATCH] drivers/crypto/fsl: remove redundant logical contraint

'A || (!A && B)' is equivalent to 'A || B'. Let's reduce the complexity of the statement in start_jr0(). The problem was indicated by cppcheck. Signed-off-by: Heinrich Schuchardt --- drivers/crypto/fsl/jr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/fsl

[U-Boot] [PATCH] cmd: ubi: remove unnecessary logical constraint

A size_t variable can never be negative. The problem was indicated by cppcheck. Signed-off-by: Heinrich Schuchardt --- cmd/ubi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/ubi.c b/cmd/ubi.c index efc43ffde9..222be5a357 100644 --- a/cmd/ubi.c +++ b/cmd/ubi.c @@ -308,

[U-Boot] [RFC 1/1] omap3: incorrect logical check in do_emif4_init

((readl(&emif4_base->sdram_iodft_tlgc) & (1<<10)) == 0x01) is always false. This does not match the comment /*Wait till that bit clears*/ The problem was indicated by cppcheck. I do not have the hardware to test if the code change below leads to a correct system behavior. Signed-off-by: Heinrich

[U-Boot] [PATCH] x86: zImage: avoid potential NULL dereference

If bootargs is not assigned getenv("bootargs") will return NULL. Some part of the code is checking for this condition. Other parts dereference a possible NULL pointer. The problem was indicated by cppcheck. Signed-off-by: Heinrich Schuchardt --- arch/x86/lib/zimage.c | 9 + 1 file chang

[U-Boot] [PATCH 1/1] fsl/sata: correctly identify failed malloc

After allocating sata->cmd_hdr_tbl_offset we have to check this variable and not variable sata. The problem was indicated by cppcheck. Signed-off-by: Heinrich Schuchardt --- drivers/block/fsl_sata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/fsl_sata.c b/d

[U-Boot] [PATCH] ddr: fsl: incorrect logical constraint in populate_memctl_options

(pdimm[0].data_width >= 32) || (pdimm[0].data_width <= 40) is always true. We should use && here. The problem was indicated by cppcheck. Signed-off-by: Heinrich Schuchardt --- drivers/ddr/fsl/options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ddr/fsl/options.

[U-Boot] [PATCH] FPGA: drivers/fpga/ivm_core.c: incorrect printf

The number of arguments for printf does not match the format string. The problem was indicated by cppcheck. Signed-off-by: Heinrich Schuchardt --- drivers/fpga/ivm_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/fpga/ivm_core.c b/drivers/fpga/ivm_core.c index

[U-Boot] [PATCH 1/1] usbtty: avoid potential NULL pointer dereference

If current_urb is NULL it should not be dereferenced. The problem was indicated by cppcheck. Signed-off-by: Heinrich Schuchardt --- drivers/serial/usbtty.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/serial/usbtty.c b/drivers/serial/usbtty.c index 2

Re: [U-Boot] [PATCH 1/7] omap_hsmmc: update struct hsmmc to accommodate omap3 from DT

Hi, On 4/15/2017 4:03 AM, Adam Ford wrote: > On Wed, Apr 12, 2017 at 11:24 PM, Vignesh R wrote: >> >> >> On Wednesday 12 April 2017 06:08 PM, Adam Ford wrote: >>> This patch fixes and issue where DM_MMC adds a 0x100 byte offset to the >>> base register. This is necessary for AM33xx, OMAP4+ and n

[U-Boot] [RFC 1/1] usb: musb: avoid out of bound access in udc_setup_ep

For id = 15 an out of bound access occurs in udc_setup_ep(). Increase the size of epinfo[] from 30 to 32 to encompass ids 0..15. The problem was highlighted by cppcheck. Signed-off-by: Heinrich Schuchardt --- I have no hardware for testing the patch. Please, review thoroughly. --- drivers/usb/m

  1   2   >