Re: [U-Boot] [PATCH] pci: gate print info of reading vender id with CONFIG_DM_PCI

2016-01-27 Thread Qianyu Gong
Hi, > -Original Message- > From: Bin Meng [mailto:bmeng...@gmail.com] > Sent: Thursday, January 28, 2016 3:30 PM > To: Qianyu Gong > Cc: U-Boot Mailing List > Subject: Re: [U-Boot] [PATCH] pci: gate print info of reading vender id with > CONFIG_DM_PCI > > On Thu, Jan 28, 2016 at 3:15 PM

Re: [U-Boot] [PATCH] pci: gate print info of reading vender id with CONFIG_DM_PCI

2016-01-27 Thread Bin Meng
On Thu, Jan 28, 2016 at 3:15 PM, Gong Qianyu wrote: > From: Mingkai Hu > > Referring to 'commit ff3e077bd23c ("dm: pci: Add a uclass for PCI")'. > > For legacy PCIe driver, it needs loop to read the vender_id from > devie 0 to devie 255 to check if there is device available. > Reading non-existen

[U-Boot] [PATCH] pci: gate print info of reading vender id with CONFIG_DM_PCI

2016-01-27 Thread Gong Qianyu
From: Mingkai Hu Referring to 'commit ff3e077bd23c ("dm: pci: Add a uclass for PCI")'. For legacy PCIe driver, it needs loop to read the vender_id from devie 0 to devie 255 to check if there is device available. Reading non-existen device will trigger the "Cannot read bus configuration: -1" info

[U-Boot] Please pull u-boot-x86

2016-01-27 Thread Bin Meng
Hi Tom, The following changes since commit b20c38a973a51bf3f663bd298c63ad1b8e0de445: arm: mvebu: Add support for the Armada XP theadorable board (2016-01-27 07:45:43 +0100) are available in the git repository at: git://git.denx.de/u-boot-x86.git master for you to fetch changes up to 81aaa3

[U-Boot] [PATCH 4/9] test/py: check for bad patterns everywhere we wait

2016-01-27 Thread Stephen Warren
From: Stephen Warren Currently, bad patterns are only honored when executing a shell command. Other cases, such as the initial boot-up of U-Boot or when interacting with command output rather than gathering all output prior to the shell prompt, do not currently look for bad patterns in console ou

[U-Boot] [PATCH 9/9] test/py: run C-based unit tests

2016-01-27 Thread Stephen Warren
From: Stephen Warren Add tests that execute the existing C-based unit test commands. These simply run the command and validate the overall result. For now, fine-grained details are not mapped into separate pytest test results in the current implementation. However, the detail is available in the

[U-Boot] [PATCH 6/9] test/py: correctly log xfail/xpass tests

2016-01-27 Thread Stephen Warren
From: Stephen Warren Tests can complete in passed, skipped, xpass, xfailed, or failed, states. Currently the U-Boot log generation code doesn't handle the xfailed or xpass states since they aren't used. Add support for the remaining states. Without this, tests that xfail end up being reported as

[U-Boot] [PATCH 8/9] test/py: run sandbox in source directory

2016-01-27 Thread Stephen Warren
From: Stephen Warren Some unit tests expect the cwd of the sandbox process to be the root of the source tree. Ensure that requirement is met. Signed-off-by: Stephen Warren --- test/py/u_boot_console_sandbox.py | 2 +- test/py/u_boot_spawn.py | 8 ++-- 2 files changed, 7 insertion

[U-Boot] [PATCH 5/9] test/py: detect another "bad pattern" in console output

2016-01-27 Thread Stephen Warren
From: Stephen Warren Many error situations in U-Boot print the message: ### ERROR ### Please RESET the board ### Add this to the list of bad patterns the test system detects. One practical advantage of this change is to detect the case where sandbox is told to use a particular DTB file, and

[U-Boot] [PATCH 7/9] test/py: pass test DTB to sandbox

2016-01-27 Thread Stephen Warren
From: Stephen Warren This is required for at least "ut dm" to operate correctly. Signed-off-by: Stephen Warren --- test/py/u_boot_console_sandbox.py | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/test/py/u_boot_console_sandbox.py b/test/py/u_boot_console_sandbox.py

[U-Boot] [PATCH 1/9] test/dm: clear unit test failure count each run

2016-01-27 Thread Stephen Warren
From: Stephen Warren The ut command prints a test failure count each time it is executed. This is stored in a global variable which is never reset. Consequently, the printed failure count accumulates across runs. Fix this by clearing the counter each time "ut" is invoked. Signed-off-by: Stephen

[U-Boot] [PATCH 2/9] test/py: fix spawn.expect multiple match handling

2016-01-27 Thread Stephen Warren
From: Stephen Warren Multiple patterns may be passed to spawn.expect(). The pattern which matches at the earliest position should be designated as the match. This aspect works correctly. When multiple patterns match at the same position, priority should be given the the earliest entry in the list

[U-Boot] [PATCH 3/9] test.py: calculate bad patterns on change only

2016-01-27 Thread Stephen Warren
From: Stephen Warren A future patch will use the bad_patterns array in multiple places. Rather than duplicating the code to calculate it, or even sharing it in a function and simply calling it redundantly when nothing has changed, only re-calculate the list when some change is made to it. This re

Re: [U-Boot] Include patchwork patch ID in commit message?

2016-01-27 Thread Heiko Schocher
Hello Bin, Am 28.01.2016 um 02:49 schrieb Bin Meng: On Thu, Jan 28, 2016 at 9:30 AM, Tom Rini wrote: On Wed, Jan 27, 2016 at 06:05:01PM -0600, Joe Hershberger wrote: On Wed, Jan 27, 2016 at 5:45 PM, Tom Rini wrote: On Wed, Jan 27, 2016 at 05:15:17PM -0600, Joe Hershberger wrote: On Wed, Ja

Re: [U-Boot] Include patchwork patch ID in commit message?

2016-01-27 Thread Heiko Schocher
Hello Tom, Am 28.01.2016 um 00:45 schrieb Tom Rini: On Wed, Jan 27, 2016 at 05:15:17PM -0600, Joe Hershberger wrote: On Wed, Jan 27, 2016 at 4:22 PM, Tom Rini wrote: On Wed, Jan 27, 2016 at 03:08:09PM -0600, Joe Hershberger wrote: Hi Tom, I'm playing with the idea of including the patchwork

Re: [U-Boot] [PATCH] board: ls2085aqds: Update kernel_size env variable

2016-01-27 Thread Prabhakar Kushwaha
> -Original Message- > From: york sun > Sent: Wednesday, January 27, 2016 11:09 PM > To: Prabhakar Kushwaha ; u- > b...@lists.denx.de > Cc: Scott Wood > Subject: Re: [PATCH] board: ls2085aqds: Update kernel_size env variable > > On 01/14/2016 08:53 PM, Prabhakar Kushwaha wrote: > > > >>

Re: [U-Boot] patman dies cryptially when a (valid) e-mail address contains parentheses (or is UTF-8)

2016-01-27 Thread Albert ARIBAUD
Hello Simon, On Wed, 27 Jan 2016 15:53:45 -0700, Simon Glass wrote: > Hi Albert, > > On 27 January 2016 at 01:22, Albert ARIBAUD wrote: > > Hello Simon, > > > > I just noticed this while adding a Series-cc to my work address which > > has parentheses: running patman (without -n) will result in

Re: [U-Boot] Include patchwork patch ID in commit message?

2016-01-27 Thread Heiko Schocher
Hello Joe, Am 27.01.2016 um 22:08 schrieb Joe Hershberger: Hi Tom, I'm playing with the idea of including the patchwork patch ID in the commit message of each commit that I apply to provide better cross-reference ability. * Access to comments on patches * Clarity on exactly which version of a

Re: [U-Boot] [PATCH] x86: Correct spi node alias

2016-01-27 Thread Bin Meng
On Thu, Jan 28, 2016 at 6:53 AM, Simon Glass wrote: > On 27 January 2016 at 01:56, Bin Meng wrote: >> With recent changes spi node was moved to a place as a subnode under >> pch, so update the alias to refer to its correct place as well. >> >> Signed-off-by: Bin Meng >> --- >> >> arch/x86/dts/b

Re: [U-Boot] [PATCH] siemens,at91: enable features for smartweb

2016-01-27 Thread Heiko Schocher
Hello Samuel, Am 27.01.2016 um 15:56 schrieb Samuel Egli: From: Matthias Michel New features for smartweb: * switch to hush command parser * change autoboot stop to * allow to write ethaddr Signed-off-by: Matthias Michel Reviewed-by: Samuel Egli Cc: Roger Meier Cc: Heiko Schocher --- c

Re: [U-Boot] [PATCH 0/7] fdt: Replace u-boot-dtb.bin with u-boot.bin

2016-01-27 Thread Simon Glass
Hi Hans, On 25 January 2016 at 13:30, Simon Glass wrote: > > At present u-boot.bin holds the plain U-Boot binary without the device tree. > This is somewhat annoying since you need either u-boot.bin or u-boot-dtb.bin > depending on whether device tree is used. > > This series adjusts the build su

Re: [U-Boot] Include patchwork patch ID in commit message?

2016-01-27 Thread Bin Meng
On Thu, Jan 28, 2016 at 9:30 AM, Tom Rini wrote: > On Wed, Jan 27, 2016 at 06:05:01PM -0600, Joe Hershberger wrote: >> On Wed, Jan 27, 2016 at 5:45 PM, Tom Rini wrote: >> > On Wed, Jan 27, 2016 at 05:15:17PM -0600, Joe Hershberger wrote: >> >> On Wed, Jan 27, 2016 at 4:22 PM, Tom Rini wrote: >>

Re: [U-Boot] Include patchwork patch ID in commit message?

2016-01-27 Thread Tom Rini
On Wed, Jan 27, 2016 at 06:05:01PM -0600, Joe Hershberger wrote: > On Wed, Jan 27, 2016 at 5:45 PM, Tom Rini wrote: > > On Wed, Jan 27, 2016 at 05:15:17PM -0600, Joe Hershberger wrote: > >> On Wed, Jan 27, 2016 at 4:22 PM, Tom Rini wrote: > >> > On Wed, Jan 27, 2016 at 03:08:09PM -0600, Joe Hersh

Re: [U-Boot] [PATCH 2/2] net: phy: micrel: fix divisor value for KSZ9031 phy skew

2016-01-27 Thread Måns Rullgård
writes: > From: Dinh Nguyen > > The picoseconds to register value divisor(ps_to_regval) should be 60 and not > 200. Linux has KSZ9031_PS_TO_REG defined to be 60 as well. 60 is the correct > divisor because the 4-bit skew values are defined from 0x(-420ps) to > 0x(480ps), increments of 60

Re: [U-Boot] Include patchwork patch ID in commit message?

2016-01-27 Thread Joe Hershberger
On Wed, Jan 27, 2016 at 5:45 PM, Tom Rini wrote: > On Wed, Jan 27, 2016 at 05:15:17PM -0600, Joe Hershberger wrote: >> On Wed, Jan 27, 2016 at 4:22 PM, Tom Rini wrote: >> > On Wed, Jan 27, 2016 at 03:08:09PM -0600, Joe Hershberger wrote: >> >> Hi Tom, >> >> >> >> I'm playing with the idea of incl

[U-Boot] [PATCH 1/3] mips: ath79: Fix compiler warning on const assignment

2016-01-27 Thread Marek Vasut
The assignment const T var; var = value; is illegal, since var is constant. Drop the const to fix the compiler warning. Signed-off-by: Marek Vasut Cc: Daniel Schwierzeck Cc: Wills Wang --- arch/mips/mach-ath79/reset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/mip

[U-Boot] [PATCH 2/3] mips: ath79: Drop SYS_MIPS_CACHE_INIT_RAM_LOAD

2016-01-27 Thread Marek Vasut
Drop SYS_MIPS_CACHE_INIT_RAM_LOAD from the Kconfig, since this option is bogus. The DRAM is not active when this option comes into play, so any attempt to restore valid cache state from invalid DRAM must fail. Disable this option to prevent such failure and potential undefined behavior. Signed-off

[U-Boot] [PATCH 3/3] mips: ath79: Move SYS_SOC and SYS_VENDOR to board Kconfig

2016-01-27 Thread Marek Vasut
In order to support boards with ath79 from different vendors and thus located under /board/$VENDOR/ , we need to define SYS_VENDOR and SYS_SOC in the board-level Kconfig. Move these two variables into board-level Kconfig for both ap121 and ap143 boards. Signed-off-by: Marek Vasut Cc: Daniel Schwi

Re: [U-Boot] Include patchwork patch ID in commit message?

2016-01-27 Thread Tom Rini
On Wed, Jan 27, 2016 at 05:15:17PM -0600, Joe Hershberger wrote: > On Wed, Jan 27, 2016 at 4:22 PM, Tom Rini wrote: > > On Wed, Jan 27, 2016 at 03:08:09PM -0600, Joe Hershberger wrote: > >> Hi Tom, > >> > >> I'm playing with the idea of including the patchwork patch ID in the > >> commit message o

Re: [U-Boot] [PATCH 2/2] net: phy: micrel: fix divisor value for KSZ9031 phy skew

2016-01-27 Thread Marek Vasut
On Wednesday, January 27, 2016 at 11:53:29 PM, Joe Hershberger wrote: > Hi Marek, > > On Wed, Jan 27, 2016 at 4:07 PM, Marek Vasut wrote: > > On Wednesday, January 27, 2016 at 10:46:00 PM, > > dingu...@opensource.altera.com > > > > wrote: > >> From: Dinh Nguyen > >> > >> The picoseconds to reg

Re: [U-Boot] [PATCH] fastboot: update error and warning messages

2016-01-27 Thread Marek Vasut
On Thursday, January 28, 2016 at 12:02:41 AM, Steve Rae wrote: > Fix the formatting in error messages, and demote one error message > to a warning, as it is only informational. > > Signed-off-by: Steve Rae I'd leave this to Lukasz, if he doesn't respond, ping me in a week or so. Best regards, M

Re: [U-Boot] Include patchwork patch ID in commit message?

2016-01-27 Thread Joe Hershberger
On Wed, Jan 27, 2016 at 4:22 PM, Tom Rini wrote: > On Wed, Jan 27, 2016 at 03:08:09PM -0600, Joe Hershberger wrote: >> Hi Tom, >> >> I'm playing with the idea of including the patchwork patch ID in the >> commit message of each commit that I apply to provide better >> cross-reference ability. >> >

[U-Boot] [PATCH] fastboot: update error and warning messages

2016-01-27 Thread Steve Rae
Fix the formatting in error messages, and demote one error message to a warning, as it is only informational. Signed-off-by: Steve Rae --- drivers/usb/gadget/f_fastboot.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/gadget/f_fastboot.c b/drivers/usb

Re: [U-Boot] [PATCH] serial: serial_stm32: move clock config from driver to board

2016-01-27 Thread Vikas MANOCHA
Hi Simon, > -Original Message- > From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass > Sent: Wednesday, January 27, 2016 2:54 PM > To: Vikas MANOCHA > Cc: Albert ARIBAUD; Kamil Lulko; U-Boot Mailing List; Peter Griffin; Antonio > Borneo; re...@wp.pl; kunhuahuang > Subje

Re: [U-Boot] [PATCH 2/2] net: phy: micrel: fix divisor value for KSZ9031 phy skew

2016-01-27 Thread Joe Hershberger
On Wed, Jan 27, 2016 at 3:46 PM, wrote: > From: Dinh Nguyen > > The picoseconds to register value divisor(ps_to_regval) should be 60 and not > 200. Linux has KSZ9031_PS_TO_REG defined to be 60 as well. 60 is the correct > divisor because the 4-bit skew values are defined from 0x(-420ps) to >

Re: [U-Boot] [PATCH 1/2] net: phy: micrel: add documentation for Micrel KSZ90x1 binding

2016-01-27 Thread Joe Hershberger
On Wed, Jan 27, 2016 at 3:45 PM, wrote: > From: Dinh Nguyen > > Add the DTS documentation for the Micrel KSZ90x1 binding. > > The original document was from: > [commit 4b405efbe12de28b26289282b431323d73992381 from the Linux kernel] > > This takes the original document and adds a clarification on

[U-Boot] SPL loading U-Boot from a FIT

2016-01-27 Thread Simon Glass
Hi, (moving to a new thread) Tom mentioned: >We _really_ need some way to support more than one board per binary >before we can move everything to DM only. We discussed this on IRC but since that doesn't exist as far as the mailing list is concerned... The current plan is: - Adjust build syst

Re: [U-Boot] patman dies cryptially when a (valid) e-mail address contains parentheses (or is UTF-8)

2016-01-27 Thread Simon Glass
Hi Albert, On 27 January 2016 at 01:22, Albert ARIBAUD wrote: > Hello Simon, > > I just noticed this while adding a Series-cc to my work address which > has parentheses: running patman (without -n) will result in > > sh: 1: Syntax error: "(" unexpected > > Which initially left me wonderin

Re: [U-Boot] [PATCH 2/2] hush: Add rudimentary support for PS1 and PS2

2016-01-27 Thread Simon Glass
On 26 January 2016 at 20:47, Marek Vasut wrote: > Add trivial support for changing the U-Boot command prompt string > by setting PS1 and PS2 environment variables. Only static variables > are supported. > > Signed-off-by: Marek Vasut > --- > README| 8 > common/cli_hush.c |

Re: [U-Boot] [PATCH] x86: Correct spi node alias

2016-01-27 Thread Simon Glass
On 27 January 2016 at 01:56, Bin Meng wrote: > With recent changes spi node was moved to a place as a subnode under > pch, so update the alias to refer to its correct place as well. > > Signed-off-by: Bin Meng > --- > > arch/x86/dts/bayleybay.dts | 4 ++-- > arch/x86/dts/broadwell_som-6

Re: [U-Boot] [PATCH] serial: serial_stm32: move clock config from driver to board

2016-01-27 Thread Simon Glass
On 26 January 2016 at 19:12, Vikas Manocha wrote: > This patch removes the uart clock enable from serial driver & move it in the > board code. > > Signed-off-by: Vikas Manocha > --- > arch/arm/include/asm/arch-stm32f4/stm32_defs.h | 15 > arch/arm/include/asm/arch-stm32f4/stm32_peri

Re: [U-Boot] [PATCH v3 1/6] dm: implement a DMA uclass

2016-01-27 Thread Simon Glass
Hi Mugunthan, On 27 January 2016 at 04:57, Mugunthan V N wrote: > Implement a DMA uclass so that the devices like ethernet, spi, > mmc etc can offload the data transfers from/to the device and > memory. > > Signed-off-by: Mugunthan V N > --- > drivers/dma/Kconfig | 15 + > drivers/

Re: [U-Boot] [PATCH 2/2] net: phy: micrel: fix divisor value for KSZ9031 phy skew

2016-01-27 Thread Joe Hershberger
Hi Marek, On Wed, Jan 27, 2016 at 4:07 PM, Marek Vasut wrote: > On Wednesday, January 27, 2016 at 10:46:00 PM, dingu...@opensource.altera.com > wrote: >> From: Dinh Nguyen >> >> The picoseconds to register value divisor(ps_to_regval) should be 60 and >> not 200. Linux has KSZ9031_PS_TO_REG defin

Re: [U-Boot] [PATCH 1/2] hush: Pull out U-Boot prompt display and read functionality

2016-01-27 Thread Simon Glass
On 26 January 2016 at 20:47, Marek Vasut wrote: > Pull the code which displays U-Boot prompt and reads the command line > into a separate function. No functional change. > > Signed-off-by: Marek Vasut > --- > common/cli_hush.c | 21 - > 1 file changed, 16 insertions(+), 5 del

[U-Boot] [PATCH] implement Fastboot via USB OTG on bcm28155_ap boards

2016-01-27 Thread Steve Rae
Don't understand how it happened, but this change got applied twice! Therefore, removing the duplicated items. Signed-off-by: Steve Rae --- include/configs/bcm28155_ap.h | 20 1 file changed, 20 deletions(-) diff --git a/include/configs/bcm28155_ap.h b/include/configs/bcm2

Re: [U-Boot] Include patchwork patch ID in commit message?

2016-01-27 Thread Tom Rini
On Wed, Jan 27, 2016 at 03:08:09PM -0600, Joe Hershberger wrote: > Hi Tom, > > I'm playing with the idea of including the patchwork patch ID in the > commit message of each commit that I apply to provide better > cross-reference ability. > > * Access to comments on patches > * Clarity on exactly

[U-Boot] [PATCH] [RFC] net: Add ag7xxx driver for Atheros MIPS

2016-01-27 Thread Marek Vasut
Add ethernet driver for the AR71xx and AR9xxx Atheros MIPS machines. Signed-off-by: Marek Vasut Cc: Daniel Schwierzeck Cc: Joe Hershberger Cc: Wills Wang --- arch/mips/dts/ap121.dts| 8 + arch/mips/dts/ar933x.dtsi | 16 + arch/mips/mach-ath79/cpu.c | 47 +++ configs/ap121_defconfig

Re: [U-Boot] [PATCH 2/2] net: phy: micrel: fix divisor value for KSZ9031 phy skew

2016-01-27 Thread Marek Vasut
On Wednesday, January 27, 2016 at 10:46:00 PM, dingu...@opensource.altera.com wrote: > From: Dinh Nguyen > > The picoseconds to register value divisor(ps_to_regval) should be 60 and > not 200. Linux has KSZ9031_PS_TO_REG defined to be 60 as well. 60 is the > correct divisor because the 4-bit ske

Re: [U-Boot] [PATCH][RE-SUBMIT] usb: gadget: dwc2_udc_otg: modified the check condition for max packet size of ep_in in high speed

2016-01-27 Thread Marek Vasut
On Wednesday, January 27, 2016 at 09:39:40 PM, Steve Rae wrote: > From: Frank Wang > > In current high speed fastboot, fs_ep_in.wMaxPacketSize is configured 64 > bytes as default, as a result, it failed to match the size at > initialization stage in usb controller. > Actually, hardware can suppor

[U-Boot] [PATCH 2/2] net: phy: micrel: fix divisor value for KSZ9031 phy skew

2016-01-27 Thread dinguyen
From: Dinh Nguyen The picoseconds to register value divisor(ps_to_regval) should be 60 and not 200. Linux has KSZ9031_PS_TO_REG defined to be 60 as well. 60 is the correct divisor because the 4-bit skew values are defined from 0x(-420ps) to 0x(480ps), increments of 60. For example, a DTS

[U-Boot] [PATCH 1/2] net: phy: micrel: add documentation for Micrel KSZ90x1 binding

2016-01-27 Thread dinguyen
From: Dinh Nguyen Add the DTS documentation for the Micrel KSZ90x1 binding. The original document was from: [commit 4b405efbe12de28b26289282b431323d73992381 from the Linux kernel] This takes the original document and adds a clarification on how the skew values are represented in the code. Refe

Re: [U-Boot] [PATCH v2 0/7] net: add support for phy speed limitation

2016-01-27 Thread Alexey Brodkin
Hi Joe, On Wed, 2016-01-27 at 12:48 -0600, Joe Hershberger wrote: > On Wed, Jan 27, 2016 at 10:23 AM, Alexey Brodkin > wrote: > > Hi Joe, > > > > On Tue, 2016-01-19 at 07:02 +, Alexey Brodkin wrote: > > > Hi Joe, > > > > > > On Wed, 2016-01-13 at 16:59 +0300, Alexey Brodkin wrote: > > > > I

[U-Boot] Include patchwork patch ID in commit message?

2016-01-27 Thread Joe Hershberger
Hi Tom, I'm playing with the idea of including the patchwork patch ID in the commit message of each commit that I apply to provide better cross-reference ability. * Access to comments on patches * Clarity on exactly which version of a patch was applied * No need to search by patch subject Here i

[U-Boot] [PATCH][RE-SUBMIT] usb: gadget: dwc2_udc_otg: modified the check condition for max packet size of ep_in in high speed

2016-01-27 Thread Steve Rae
From: Frank Wang In current high speed fastboot, fs_ep_in.wMaxPacketSize is configured 64 bytes as default, as a result, it failed to match the size at initialization stage in usb controller. Actually, hardware can support less than or equal to 512 bytes in high speed mode, so I changed the cond

Re: [U-Boot] [PATCH v2 2/2] net: phy: Add PHY driver for mv88e61xx switches

2016-01-27 Thread Joe Hershberger
On Wed, Jan 27, 2016 at 11:28 AM, Albert ARIBAUD wrote: > Hello Kevin, > > On Wed, 27 Jan 2016 16:29:42 +, Kevin Smith > wrote: >> Hi Joe, > >> On 01/26/2016 06:11 PM, Joe Hershberger wrote: > >> >> + /* Replace the bus with the fake device */ >> > Fake how? This is a confusing comment

Re: [U-Boot] [PATCH] net : null check after pointer dereference

2016-01-27 Thread Joe Hershberger
On Tue, Jan 26, 2016 at 1:26 AM, Vishwas Srivastava wrote: > Author: Vishwas Srivastava > Date: Tue Jan 26 12:46:42 2016 +0530 Please fix the subject of this patch. No space in the "net :". > > null check after pointer dereference All of your commit logs should not have spaces in them (a

Re: [U-Boot] [PATCH]: net: Wrong Initialization in davinci-emac driver

2016-01-27 Thread Joe Hershberger
On Mon, Jan 25, 2016 at 11:00 AM, Vishwas Srivastava wrote: > Author: Vishwas Srivastava > Date: Mon Jan 25 21:28:17 2016 +0530 Please fix the patch subject. No Leading colon. > > Wrong Initialization in davinci emac driver > > emac module of the davinci platform supports only 8 tx an

[U-Boot] question about "drivers/usb/gadget/f_fastboot.c"

2016-01-27 Thread Steve Rae
Please explain the following logic in "drivers/usb/gadget/f_fastboot.c": 422) static unsigned int rx_bytes_expected(unsigned int maxpacket) 423) { 424) int rx_remain = download_size - download_bytes; 425) int rem = 0; 426) if (rx_remain < 0) 427) return 0; 428) if

Re: [U-Boot] [PATCH]: net: Wrong Initialization in davinci-emac driver

2016-01-27 Thread Joe Hershberger
On Mon, Jan 25, 2016 at 11:00 AM, Vishwas Srivastava wrote: > Author: Vishwas Srivastava > Date: Mon Jan 25 21:28:17 2016 +0530 > > Wrong Initialization in davinci emac driver > > emac module of the davinci platform supports only 8 tx and > 8 rx channels (total 16). emac driver for

Re: [U-Boot] [PATCH] net : null check after pointer dereference

2016-01-27 Thread Joe Hershberger
On Tue, Jan 26, 2016 at 1:26 AM, Vishwas Srivastava wrote: > Author: Vishwas Srivastava > Date: Tue Jan 26 12:46:42 2016 +0530 > > null check after pointer dereference > > NULL check is made after the pointer dereference is davinci- > emac driver. This patch fixes this issue. > >

Re: [U-Boot] [PATCH v2 0/7] net: add support for phy speed limitation

2016-01-27 Thread Joe Hershberger
On Wed, Jan 27, 2016 at 10:23 AM, Alexey Brodkin wrote: > Hi Joe, > > On Tue, 2016-01-19 at 07:02 +, Alexey Brodkin wrote: >> Hi Joe, >> >> On Wed, 2016-01-13 at 16:59 +0300, Alexey Brodkin wrote: >> > In some cases Ethernet PHY and network itself might support speeds >> > which are not suppor

Re: [U-Boot] [Patch V5 1/3] armv8/ls1043aqds: add DSPI support

2016-01-27 Thread york sun
On 01/24/2016 11:25 PM, Gong Qianyu wrote: > From: Gong Qianyu > > Enable three DSPI flash memories on board. > > Commands: > => sf probe 1:0 > SF: Detected N25Q128A with page size 256 Bytes, > erase size 64 KiB, total 16 MiB > => sf probe 1:1 > SF: Detected SST25WF

Re: [U-Boot] [Patch V5 2/3] armv8/ls1043aqds: add QSPI support in SD boot

2016-01-27 Thread york sun
On 01/24/2016 11:25 PM, Gong Qianyu wrote: > From: Gong Qianyu > > QSPI and IFC are pin-multiplexed on LS1043A. So we use > ls1043aqds_sdcard_ifc_defconfig to support IFC in SD boot and > ls1043aqds_sdcard_qspi_defconfig to support QSPI in SD boot. > > Signed-off-by: Gong Qianyu > --- > V4-V5:

Re: [U-Boot] [Patch V7 4/4] dm: env_sf: fix saveenv() to use driver model

2016-01-27 Thread york sun
On 01/25/2016 11:15 PM, Gong Qianyu wrote: > From: Gong Qianyu > > It might be missed when converting spi_flash_probe() in cmd_sf.c. > > This patch refers to commit fbb099183e3a ("dm: Convert > spi_flash_probe() and 'sf probe' to use driver model"). > > Signed-off-by: Gong Qianyu > --- > V6-V7

[U-Boot] Please pull u-boot-fsl-qoriq.git master

2016-01-27 Thread york sun
Tom, The following changes since commit 12f229ea8f6c8e20f8fd07906eafc853c4c354a9: Merge git://git.denx.de/u-boot-fdt (2016-01-22 17:01:22 -0500) are available in the git repository at: git://git.denx.de/u-boot-fsl-qoriq.git master for you to fetch changes up to b0f20caf6570fbc4d19c41dcedf

Re: [U-Boot] [PATCH] board: ls2085aqds: Update kernel_size env variable

2016-01-27 Thread york sun
On 01/14/2016 08:53 PM, Prabhakar Kushwaha wrote: > >> -Original Message- >> From: york sun [mailto:york@nxp.com] >> Sent: Thursday, January 14, 2016 11:37 PM >> To: Prabhakar Kushwaha ; u-boot@lists.denx.de >> Cc: Scott Wood >> Subject: Re: [PATCH] board: ls2085aqds: Update kernel_si

Re: [U-Boot] [PATCH v2 2/2] net: phy: Add PHY driver for mv88e61xx switches

2016-01-27 Thread Albert ARIBAUD
Hello Kevin, On Wed, 27 Jan 2016 16:29:42 +, Kevin Smith wrote: > Hi Joe, > On 01/26/2016 06:11 PM, Joe Hershberger wrote: > >> + /* Replace the bus with the fake device */ > > Fake how? This is a confusing comment to me as written. > The genphy functions assume that they can write to

Re: [U-Boot] [PATCH 7/7] driver: net: fsl-mc: Remove portal id hard-coding

2016-01-27 Thread york sun
On 12/24/2015 02:03 AM, Prabhakar Kushwaha wrote: > Management Complex firmware 9.0 has fixed the issue of dprc_destroy_container > i.e. the used portal is not return to the free pool. Which was resulting in > error ethernet driver want to use this portal via either DPL or dynamically > in Linux. >

Re: [U-Boot] [Patch V5 3/3] armv8/ls1043aqds: add QSPI boot support

2016-01-27 Thread york sun
On 01/24/2016 11:25 PM, Gong Qianyu wrote: > Enable the U-Boot Driver Model(DM) to use the Freescale QSPI driver. > > Signed-off-by: Gong Qianyu > --- > V5: > - Print FGPA info later for QSPI boot. > V3-V4: > - No change. > V2: > - Fix blank line issues. > > arch/arm/include/asm/arch-fsl-lay

Re: [U-Boot] [Patch V7 3/4] spi: fsl_qspi: Fix qspi_op_rdsr memcpy issue

2016-01-27 Thread york sun
On 01/25/2016 11:15 PM, Gong Qianyu wrote: > From: Gong Qianyu > > In current driver, we always copy 4 bytes to the dest memory. > Actually the dest memory may be shorter than 4 bytes. > Add an argument to indicate the dest memory length. > Avoid writing memory outside of the bounds. > > Signed-

Re: [U-Boot] [Patch V7 2/4] spi: fsl_qspi: Fix qspi_op_rdid memcpy issue

2016-01-27 Thread york sun
On 01/25/2016 11:15 PM, Gong Qianyu wrote: > From: Gong Qianyu > > In current driver everytime we memcpy 4 bytes to the dest memory > regardless of the remaining length. > This patch adds checking the remaining length before memcpy. > If the length is shorter than 4 bytes, memcpy the actual lengt

Re: [U-Boot] [Patch V7 1/4] spi: fsl_qspi: fix compile warning for 64-bit platform

2016-01-27 Thread york sun
On 01/25/2016 11:15 PM, Gong Qianyu wrote: > From: Gong Qianyu > > This patch fixes the following compile warning: > drivers/spi/fsl_qspi.c: In function 'fsl_qspi_probe': > drivers/spi/fsl_qspi.c:937:15: > warning: cast to pointer from integer of different size >

Re: [U-Boot] [v3] mmc: fsl_esdhc: set Abort command type for CMD12

2016-01-27 Thread york sun
On 01/21/2016 01:41 AM, Yangbo Lu wrote: > According to SD spec, CMD12, CMD52 for writing I/O abort in CCCR need > to be set an Abort command type when they are sent. So, we remove all > chip-specific #ifdefs and make it available for all platforms. > > Signed-off-by: Yangbo Lu > --- > Changes fo

Re: [U-Boot] [PATCH v4 3/3] armv8/ls1043aqds: Add lpuart support

2016-01-27 Thread york sun
On 01/21/2016 01:23 AM, Wenbin Song wrote: > Add lpuart support using the driver model. > > Signed-off-by: Wenbin Song > --- > Changes in v4: > - No change > --- > arch/arm/dts/Makefile | 1 + > arch/arm/dts/fsl-ls1043a-qds-lpuart.dts | 16 ++ > arch/arm/dts/fsl-ls1043

Re: [U-Boot] [PATCH v4 2/3] armv8/ls1043aqds: Spilt off board device tree

2016-01-27 Thread york sun
On 01/21/2016 01:23 AM, Wenbin Song wrote: > Move new /chosen node out of the board device tree. > > Signed-off-by: Wenbin Song > --- > Changes in v4: > - No change > --- > arch/arm/dts/Makefile| 2 +- > arch/arm/dts/fsl-ls1043a-qds-duart.dts

Re: [U-Boot] [PATCH v4 1/3] armv8/ls1043aqds: Select lpuart pins of various muxes

2016-01-27 Thread york sun
On 01/21/2016 01:23 AM, Wenbin Song wrote: > From: Shaohui Xie > > Set Board Configuration Register to select the lpuart pins of various > muxes. > > Signed-off-by: Shaohui Xie > Signed-off-by: Mingkai Hu > --- > Changes in v4: > - remove the blank line and ending period > - modify the suffix

Re: [U-Boot] [PATCH] mmc: fsl_esdhc: increase data transaction timeout to 500ms

2016-01-27 Thread york sun
On 12/29/2015 10:27 PM, Yangbo Lu wrote: > The MMC spec says "It is strongly recommended for hosts to implement > more than 500ms timeout value even if the card indicates the 250ms > maximum busy length." Even the previous value of 300ms is known to > be insufficient for some cards. So, increase t

Re: [U-Boot] [PATCH 6/7] driver: net: ldpaa: Add debug info of printing DPMAC stats

2016-01-27 Thread york sun
On 12/24/2015 02:03 AM, Prabhakar Kushwaha wrote: > Add debug information prints to provide DPMAC statistics > - Number of bytes received > - Number of received and discard frames > - Number of bytes transferred > - Number of frames transferred > etc. > > Signed-off-by: Prabhakar Kushwaha >

Re: [U-Boot] [PATCH 5/7] driver: net: ldpaa: Increase num of buffers for a pool

2016-01-27 Thread york sun
On 12/24/2015 02:03 AM, Prabhakar Kushwaha wrote: > Management Complex FW 9.0 set the hardware depletion to be 20 buffers > in order to support multiple pools in DPNI. This requires driver to fill > the pool with at least 21 to be able to receive frames. > > So, Increase number of buffers for a po

Re: [U-Boot] [PATCH] drivers: net: fsl_mc: Compare pointer value qbman_swp_mc_start

2016-01-27 Thread york sun
On 12/22/2015 03:19 AM, Pratiyush Srivastava wrote: > Current code compares the return pointer of function qbman_cena_write_start > with NULL. Instead the value of the return pointer should be compared. > Signed-off-by: Pratiyush Mohan Srivastava > --- > drivers/net/fsl-mc/dpio/qbman_portal.c | 4

Re: [U-Boot] [PATCH 4/7] driver: net: ldpaa: Report back only error frames for tx

2016-01-27 Thread york sun
On 12/24/2015 02:03 AM, Prabhakar Kushwaha wrote: > Management Complex FW 9.0 puts a new requirement to provide Tx confirmation > and error queue configuration by calling dpni_set_tx_conf API. > > Configure report of only error frames for a tx frame. > > Signed-off-by: Prabhakar Kushwaha > --- >

Re: [U-Boot] [PATCH 3/7] driver: net: fsl-mc: Prepare extended cfg for DPNI create

2016-01-27 Thread york sun
On 12/24/2015 02:03 AM, Prabhakar Kushwaha wrote: > Management Complex FW 9.0 puts a new requirement to prepare extended > parameters which should be provided as input in dpni_create. extended > parameters includes traffic class and IP reassembly configurations. > > So prepare extended parameters

Re: [U-Boot] [PATCH 1/7] driver: net: fsl-mc: Add version check for MC objects

2016-01-27 Thread york sun
On 12/24/2015 02:02 AM, Prabhakar Kushwaha wrote: > Check and compare version of management complex's object with the version > supported by Freescale ldpaa2 ethernet driver. > > Signed-off-by: Prabhakar Kushwaha > --- > drivers/net/fsl-mc/mc.c | 51 >

Re: [U-Boot] [PATCH 2/7] driver: net: fsl-mc: flib changes for MC FW 9.0.0

2016-01-27 Thread york sun
On 12/24/2015 02:03 AM, Prabhakar Kushwaha wrote: > MC firmware version 9.0.0 contains > - Support of new APIs > - Update in existing APIs > - Change in Major and minor version of DPAA2 objects > > This patch contains modifications in FLIB files to support new MC firmware > version. > > Signed

Re: [U-Boot] [PATCH v3 7/7] SECURE_BOOT: change error handler for esbc_validate

2016-01-27 Thread york sun
On 01/22/2016 03:10 AM, Aneesh Bansal wrote: > In case of error while executing esbc_validate command, SNVS > transition and issue of reset is required only for secure-boot. > If boot mode is non-secure, this is not required. > > Similarly, esbc_halt command which puts the core in Spin Loop > is a

Re: [U-Boot] [PATCH v3 6/7] enable chain of trust for PowerPC platforms

2016-01-27 Thread york sun
On 01/22/2016 03:10 AM, Aneesh Bansal wrote: > Chain of Trust is enabled for PowerPC platforms for Secure Boot. > CONFIG_BOARD_LATE_INIT is defined. > In board_late_init(), fsl_setenv_chain_of_trust() is called which > will perform the following: > - If boot mode is non-secure, return (No Change) >

Re: [U-Boot] [PATCH v3 5/7] enable chain of trust for ARM platforms

2016-01-27 Thread york sun
On 01/22/2016 03:10 AM, Aneesh Bansal wrote: > Chain of Trust is enabled for ARM platforms (LS1021 and LS1043). > In board_late_init(), fsl_setenv_chain_of_trust() is called which > will perform the following: > - If boot mode is non-secure, return (No Change) > - If boot mode is secure, set the fo

Re: [U-Boot] [PATCH v3 4/7] create function to determine boot mode

2016-01-27 Thread york sun
On 01/22/2016 03:10 AM, Aneesh Bansal wrote: > A function is created to detrmine if the boot mode is secure > or non-secure for differnt SoC's. > > Signed-off-by: Aneesh Bansal > --- > Changes in v3: > None > > Changes in v2: > Corrected the macro for SB_EN bit in RCW. > > .../include/asm/arch

Re: [U-Boot] [PATCH v3 3/7] SECURE_BOOT: split the secure boot functionality in two parts

2016-01-27 Thread york sun
On 01/22/2016 03:10 AM, Aneesh Bansal wrote: > There are two phases in Secure Boot > 1. ISBC: In BootROM, validate the BootLoader (U-Boot). > 2. ESBC: In U-Boot, continuing the Chain of Trust by > validating and booting LINUX. > > For ESBC phase, there is no difference in SoC's based on A

Re: [U-Boot] [PATCH v3 2/7] include/configs: move definition of CONFIG_CMD_BLOB

2016-01-27 Thread york sun
On 01/22/2016 03:10 AM, Aneesh Bansal wrote: > CONFIG_CMD_BLOB must be defined in case of Secure Boot. > It was earlier defined in all config files. The definition > has been moved to a common file which is included by all configs. > > Signed-off-by: Aneesh Bansal > --- > Changes in v3: > None >

Re: [U-Boot] [PATCH v3 1/7] include/configs: make secure boot header file include uniform

2016-01-27 Thread york sun
On 01/22/2016 03:10 AM, Aneesh Bansal wrote: > The file fsl_secure_boot.h must be included in config file > for Secure Boot. This is not required to be protected by any > macro. > CONFIG_FSL_CAAM must be defined and CONFIG_CMD_HASH should be > turned on. > The above was missing in some config files

Re: [U-Boot] [PATCH 2/4] SECURE BOOT: separate functions for reading keys

2016-01-27 Thread york sun
On 12/08/2015 12:45 AM, Aneesh Bansal wrote: > Separate functions are created for reading and checking the > sanity of Public keys: > - read_validate_single_key > - read_validate_ie_tbl > - read_validate_srk_table > > Signed-off-by: Saksham Jain > Signed-off-by: Aneesh Bansal > --- > board/free

Re: [U-Boot] [PATCH 1/4] SECURE BOOT: change prototype of fsl_secboot_validate function

2016-01-27 Thread york sun
On 12/08/2015 12:45 AM, Aneesh Bansal wrote: > The prototype and defination of function fsl_secboot_validate > has been changed to support calling this function from another > function within u-boot. > Only two aruments needed: > 1) header address - Mandatory > 2) SHA256 string - optional > > Sign

Re: [U-Boot] [PATCH 4/4] SECURE BOOT: support for validation of dynamic image

2016-01-27 Thread york sun
On 12/08/2015 12:45 AM, Aneesh Bansal wrote: > Some images to be validated are relocated to a dynamic > address at run time. So, these addresses cannot be known > befor hand while signing the images and creating the header > offline. > So, support is required to pass the image address to the > vali

Re: [U-Boot] [PATCH] armv8: ls2080a: Increase MC's DDR size to 512 MB

2016-01-27 Thread york sun
On 12/22/2015 03:19 AM, Pratiyush Srivastava wrote: > Freescale's management complex (MC) uses System DDR for internal usage. > Increase used System DDR size from 256MB to 512 MB. > > Signed-off-by: Pratiyush Mohan Srivastava > --- > include/configs/ls2080a_common.h | 2 +- > 1 file changed, 1

Re: [U-Boot] [PATCH] armv8: ls2040a: Add support of LS2040A SoC

2016-01-27 Thread york sun
On 12/22/2015 03:18 AM, Pratiyush Srivastava wrote: > Freescale's LS2040A is a another personality of LS2080A SoC > without AIOP support consisting of 4 armv8 cores. > > Signed-off-by: Pratiyush Mohan Srivastava > --- > arch/arm/include/asm/arch-fsl-layerscape/cpu.h | 1 + > arch/arm/include/asm

Re: [U-Boot] [PATCH] armv8: Enable all 8 DPMAC ports in LS2080A Personality

2016-01-27 Thread york sun
On 12/22/2015 03:17 AM, Pratiyush Srivastava wrote: > LS2080A has support for 8 DPMAC ports out of which > only 5 ports can be used at a time. > Enabling all 8 DPMAC ports of LS2080A personality. > > Signed-off-by: Pratiyush Mohan Srivastava > --- > arch/arm/cpu/armv8/fsl-layerscape/ls2080a_serd

Re: [U-Boot] [PATCH 3/4] SECURE BOOT: separate function created for signature

2016-01-27 Thread york sun
On 12/08/2015 12:45 AM, Aneesh Bansal wrote: > The code for image hash calculation, hash calculation from > RSA signature and comparison of hashes has been mobed to a > separate function. > > Signed-off-by: Saksham Jain > Signed-off-by: Aneesh Bansal > --- > board/freescale/common/fsl_validate.

Re: [U-Boot] [PATCH] drivers/ddr/fsl: fsl_ddr_sdram_size remove unused controllers

2016-01-27 Thread york sun
On 01/14/2016 10:28 AM, Ed Swarthout wrote: > Following commit 61bd2f75, exclude unused DDR controller from > calculating RAM size for SPL boot. > > Signed-off-by: Ed Swarthout > --- > > Applies to v2016.01. > Tested on ls2080aqds. > > drivers/ddr/fsl/main.c | 1 + > 1 file changed, 1 insertio

Re: [U-Boot] [PATCH][v2] armv8: fsl-layerscape: fixes lsch2 serdes registers define

2016-01-27 Thread york sun
On 12/14/2015 02:13 AM, shh@gmail.com wrote: > From: Shaohui Xie > > Fixes lsch2 SerDes registers define according to LS1043A RM Rev D. > > Signed-off-by: Shaohui Xie > --- > changes in v2: > 1. fixes indent. > > .../include/asm/arch-fsl-layerscape/immap_lsch2.h | 67 > +++--

  1   2   3   >