Re: [U-Boot] [PATCH 3/3] x86: quark: Implement PIRQ routing

Hi Simon, On Tue, Apr 28, 2015 at 10:05 PM, Simon Glass wrote: > Hi Bin, > > On 27 April 2015 at 00:16, Bin Meng wrote: >> Intel Quark SoC has the same interrupt routing mechanism as the >> Queensbay platform, only the difference is that PCI devices' >> INTA/B/C/D are harcoded and cannot be chan

Re: [U-Boot] mx6cuboxi: PHY/FEC detection

On 04/05/2015 05:24, Fabio Estevam wrote: > On Sat, May 2, 2015 at 11:12 AM, Fabio Estevam wrote: >> Hi Stefano and Vagrant, >> >> On Sat, May 2, 2015 at 5:54 AM, Stefano Babic wrote: >> >>> Good work ! I apply V2, then. Can you also send to a ML the two >>> additional patches from your previou

Re: [U-Boot] [PATCH 1/2] mx6cuboxi: Fix Ethernet PHY detection problem

Hi Fabio, On 05/04/2015 06:30 AM, Fabio Estevam wrote: From: Fabio Estevam mx6cuboxi sometimes fails to recognize the Ethernet PHY: Net: Phy 0 not found The explanation comes from a patch from Rabeeh: "The LED_ACT pin on the carrier-one boards had a pull down that forces the phy address t

[U-Boot] [PATCH 1/2] mx6cuboxi: Fix Ethernet PHY detection problem

From: Fabio Estevam mx6cuboxi sometimes fails to recognize the Ethernet PHY: Net: Phy 0 not found The explanation comes from a patch from Rabeeh: "The LED_ACT pin on the carrier-one boards had a pull down that forces the phy address to 0x0; where on CuBox-i and the production HummingBoard th

[U-Boot] [PATCH 2/2] mx6cuboxi: Pull down PAD_ENET_RXD0/RXD1

From: Fabio Estevam Configure PAD_ENET_RXD0/RXD1 pads as pull down because these pads are directly connected to the Atheros 8035/8030 although they should be functional only in the RMII mode - 8030. Signed-off-by: Rabeeh Khoury Signed-off-by: Fabio Estevam --- board/solidrun/mx6cuboxi/mx6cubo

Re: [U-Boot] mx6cuboxi: PHY/FEC detection

On Sat, May 2, 2015 at 11:12 AM, Fabio Estevam wrote: > Hi Stefano and Vagrant, > > On Sat, May 2, 2015 at 5:54 AM, Stefano Babic wrote: > >> Good work ! I apply V2, then. Can you also send to a ML the two >> additional patches from your previous e-mail ? They are not tracked >> properly by patch

Re: [U-Boot] Intel Galileo on u-boot

Hi Fei, On Sun, May 3, 2015 at 9:41 AM, WANG FEI wrote: > Meng Bin, I'm downloading the u-boot-2015.04 source code and build with > "make galileo_defconfig" and "make all" after "export BUILD_ROM=y", but I > got an error as below, > > IFDTOOL u-boot.rom > Output file is too small. (1048576 < -214

[U-Boot] Add spi nand support in u-boot

Hi All, I’d like to add spi nand support in u-boot. But I don’t know where should the spi nand drivers put in and how to define the architecture. I find that currently spi_flash in u-boot means spi nor flash. Should I create a struct spi_nand_flash or make spi_flash compatible? Thanks Peter Pan

[U-Boot] [PATCH v3 02/26] kconfig: Move REGEX to Kconfig

Having this as a Kconfig allows it to be a dependent feature. Signed-off-by: Joe Hershberger Reviewed-by: Simon Glass Acked-by: Stefan Roese --- Changes in v3: None Changes in v2: None configs/acadia_defconfig | 1 + configs/bamboo_defconfig | 1 + configs/bubinga_defconf

[U-Boot] [PATCH v3 00/26] Improve env var handling for net stack

This includes moving CONFIG_REGEX to Kconfig and adding support for regex to the env_attr lists (when CONFIG_REGEX is enabled). This allows ethaddrs to all be checked for access and format by default. Also use callbacks to keep network stack variables up to date instead of polling them on each cal

[U-Boot] [PATCH v3 1/2] stv0991: fdt: add stv0991 device tree

This patch adds device tree for the ST Micro stv0991 board & enables device tree control. Progressively device tree support for the drivers being used will also be added. Signed-off-by: Vikas Manocha --- Changes in v3: - CONFIG_OF_EMBED replaced with CONFIG_OF_SEPARATE Changes in v2: - added co

[U-Boot] [PATCH v3 2/2] stv0991: use fdt for serial port platform data

This patch ignores the serial port static platform data at compilation time in case of device tree control. Signed-off-by: Vikas Manocha Reviewed-by: Simon Glass --- Changes in v3: None Changes in v2: - added commit message. board/st/stv0991/stv0991.c |2 ++ 1 file changed, 2 insertions(

[U-Boot] [PATCH v3 0/2] stv0991: Add flat device tree support

This patchset adds device tree support for stv0991 soc. Changes in v3: - CONFIG_OF_EMBED replaced with CONFIG_OF_SEPARATE Changes in v2: - added commit messages for both patches. Vikas Manocha (2): stv0991: fdt: add stv0991 device tree stv0991: use fdt for serial port platform data arch/ar

Re: [U-Boot] [PATCH v2 1/2] stv0991: fdt: add stv0991 device tree

Thanks Simon, On 05/02/2015 07:26 AM, Simon Glass wrote: > Hi Vikas, > > On 1 May 2015 at 18:07, Vikas Manocha wrote: >> This patch adds device tree for the ST Micro stv0991 board & enables >> device tree control. Progressively device tree support for the drivers >> being used will also be added.

Re: [U-Boot] [PATCH] dm: core: Fix regression caused by c1d6f91

Hi Simon and Tom, On Fri, May 1, 2015 at 9:23 AM, Simon Glass wrote: > Hi Tom, > > On 1 May 2015 at 07:38, Tom Rini wrote: >> >> On Thu, Apr 30, 2015 at 07:54:21PM -0600, Simon Glass wrote: <--snip--> >> > Now that the tests are running again, I'll resume checking driver >> > model things befo

[U-Boot] [PATCH v3 15/26] test: Add a common unit test command

Add a command that all other unit tests should be a sub-command of. Also include a command that will run all tests. Signed-off-by: Joe Hershberger --- Changes in v3: -New for version 3 Changes in v2: None include/test/suites.h | 11 + test/Makefile | 1 + test/cmd_ut.c

[U-Boot] [PATCH v3 21/26] test: env: Add test framework for env

Add a new "env" subcommand to the ut command. This will run unit tests on the env code. This should be targetable to any device that supports the env features needed for the tests. Signed-off-by: Joe Hershberger Reviewed-by: Simon Glass --- Changes in v3: -Moved test from env subcommand to ut

Re: [U-Boot] [PATCH v2 16/19] test: env: Add test for verifying env attrs

Hi Simon, On Thu, Apr 30, 2015 at 10:46 PM, Simon Glass wrote: > Hi Joe, > > On 28 April 2015 at 23:51, Joe Hershberger wrote: >> Add a test of the env_attr_lookup() function. >> >> Signed-off-by: Joe Hershberger >> --- >> >> Changes in v2: >> -New for version 2 >> >> test/env/Makefile | 1 +

[U-Boot] [PATCH v3 14/26] test: Generalize the unit test framework

Separate the ability to define tests and assert status of test functions from the dm tests so they can be used more consistenly throughout all tests. Signed-off-by: Joe Hershberger Reviewed-by: Simon Glass --- Changes in v3: None Changes in v2: -New for version 2 include/dm/test.h | 3

[U-Boot] [PATCH v3 07/26] env: Add regex support to env_attrs

Allow the features that use env_attrs to specify regexs for the name Signed-off-by: Joe Hershberger Reviewed-by: Simon Glass --- Changes in v3: None Changes in v2: -Added description to README README | 8 + common/env_attr.c | 85 +

[U-Boot] [PATCH v3 08/26] env: Distinguish finer between source of env change

We already could tell the difference in the callback between an import and "other" which we called interactive. Now add further distinction between interactive (i.e. running env set / env edit / env ask / etc. from the U-Boot command line) and programmatic (i.e. when u-boot source calls any variant

[U-Boot] [PATCH v3 16/26] test: Move the unit tests to their own menu

Make all unit tests selectable as a menu of test suites instead of just sitting in the top-level menu individually. Signed-off-by: Joe Hershberger --- Changes in v3: -New for version 3 Changes in v2: None test/Kconfig| 7 +-- test/dm/Kconfig | 3 +-- 2 files changed, 6 insertions(+),

[U-Boot] [PATCH v3 26/26] sandbox: Enable env unit tests

Enable the new env unit tests on sandbox. Signed-off-by: Joe Hershberger Reviewed-by: Simon Glass --- Changes in v3: None Changes in v2: -New for version 2 configs/sandbox_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig index

[U-Boot] [PATCH v3 25/26] sandbox: Cleanup order and extra defines in defconfig

The defconfigs should not be edited directly. They should be generated by editing the .config (through menuconfig or whatever) and then run make savedefconfig to have the Kconfig system generate a clean defconfig I did this for sandbox here with no actual changes. Signed-off-by: Joe Hershberger

[U-Boot] [PATCH v3 06/26] env: Allow env_attr_walk to pass a priv * to callback

In some cases it can be helpful to have context in the callback about the calling situation. This is needed for following patches. Signed-off-by: Joe Hershberger Reviewed-by: Simon Glass --- Changes in v3: None Changes in v2: None common/cmd_nvedit.c | 10 ++ common/env_attr.c |

[U-Boot] [PATCH v3 04/26] env: Fix return values in env_attr_lookup()

This function returned numbers for error codes. Change them to error codes. Signed-off-by: Joe Hershberger Reviewed-by: Simon Glass --- Changes in v3: None Changes in v2: None common/env_attr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/common/env_attr.c b/commo

[U-Boot] [PATCH v3 22/26] test: env: Add test for verifying env attrs

Add a test of the env_attr_lookup() function. Signed-off-by: Joe Hershberger Reviewed-by: Simon Glass --- Changes in v3: None Changes in v2: -New for version 2 test/env/Makefile | 1 + test/env/attr.c | 62 +++ 2 files changed, 63 inserti

[U-Boot] [PATCH v3 20/26] test: dm: Recover the driver model tree after tests

Put the driver model for the system back into a good state after completing the DM testing. Signed-off-by: Joe Hershberger --- Changes in v3: -New for version 3 Changes in v2: None test/dm/test-main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/test/dm/test-main.c b/test/dm/test-

[U-Boot] [PATCH v3 12/26] net: Remove duplicate bootfile syncing functionality

The bootfile env var is already kept up to date by the callback in net.c so there is no need to poll it too. Signed-off-by: Joe Hershberger --- Changes in v3: -New for version 3 Changes in v2: None net/eth.c | 12 1 file changed, 12 deletions(-) diff --git a/net/eth.c b/net/eth.

[U-Boot] [PATCH v3 10/26] net: Use env callbacks for net variables

Instead of checking for changes to the env each time we enter the net_loop, use the env callbacks to update the values of the variables. Don't update the variables when the source was programmatic, since the variables were the source of the new value. Signed-off-by: Joe Hershberger Reviewed-by: S

[U-Boot] [PATCH v3 13/26] net: Handle ethaddr changes as an env callback

When the ethaddr is changed in the env, update the device pdata at the same time (only if it is probed for the DM case; only if registered for the non-DM case). Again this gets us closer to completely non-polled env needed to simplify the net_loop. This requires that the NET feature select the REG

[U-Boot] [PATCH v3 19/26] test: Return values from the asserts compatible with cmds

The asserts are sometimes called from the context of the test command itself so make sure that a return that happens as a result of a failure is compatible with that command return. When called within a test, the return value is ignored. Signed-off-by: Joe Hershberger Reviewed-by: Simon Glass --

[U-Boot] [PATCH v3 11/26] net: Add default flags for common net env vars

Check that the common network stack's env vars conform to the proper format for IP addresses. Signed-off-by: Joe Hershberger Reviewed-by: Simon Glass --- Changes in v3: None Changes in v2: None include/env_flags.h | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git

[U-Boot] [PATCH v3 18/26] test: dm: eth: Handle failed test env cleanup

Make sure that the env gets cleaned up after a test fails so that other tests aren't affected. Signed-off-by: Joe Hershberger --- Changes in v3: -New for version 3 Changes in v2: None test/dm/eth.c | 79 +-- 1 file changed, 55 insertions

[U-Boot] [PATCH v3 09/26] net: Apply default format rules to all ethaddr

Use a regular expression to apply the default formatting flags for all ethaddr env vars. Signed-off-by: Joe Hershberger Reviewed-by: Simon Glass --- Changes in v3: None Changes in v2: -Added comments about the use of .flags in the dm eth test include/env_flags.h | 11 --- test/dm/eth.

[U-Boot] [PATCH v3 24/26] test: dm: Move the dm tests over to the ut command

Unify the command for running unit tests further by moving the "dm test" command over to "ut dm". Signed-off-by: Joe Hershberger --- Changes in v3: -New for version 3 Changes in v2: None arch/sandbox/Kconfig | 5 - include/dm/test.h | 11 --- include/test/suites.h | 1 + te

[U-Boot] [PATCH v3 01/26] sandbox: Enable some ENV commands

Enable some additional ENV commands in sandbox to aid in build testing and run testing. Signed-off-by: Joe Hershberger Reviewed-by: Simon Glass --- Changes in v3: None Changes in v2: None include/configs/sandbox.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/configs/sandbo

[U-Boot] [PATCH v3 03/26] sandbox: Enable regex support

Enable regex support on sandbox. Signed-off-by: Joe Hershberger Reviewed-by: Simon Glass --- Changes in v3: None Changes in v2: None configs/sandbox_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig index 5de7fbe..340f5eb 10064

[U-Boot] [PATCH v3 23/26] test: env: Add a test of the new regex behavior for attrs

The behavior of the env attrs depends on CONFIG_REGEX. Add an additional test if that variable is set. Signed-off-by: Joe Hershberger Reviewed-by: Simon Glass --- Changes in v3: None Changes in v2: -New for version 2 test/env/attr.c | 27 +++ 1 file changed, 27 inserti

[U-Boot] [PATCH v3 17/26] test: dm: Don't bail on all tests if one test fails

There's not much point in having a failure count if we always give up on the first failure. Also stop clearing the entire state between tests. Make sure that any failures are still passed out to the command line. Signed-off-by: Joe Hershberger Reviewed-by: Simon Glass --- Changes in v3: None C

[U-Boot] [PATCH v3 05/26] env: Simplify the reverse_strstr() interface

The logic to find the whole matching name was split needlessly between the reverse_strstr function and its caller. Fully contain it to make the interface for calling it more consistent. Signed-off-by: Joe Hershberger --- Changes in v3: None Changes in v2: -Fix bisectability issue -Fix corner ca

Re: [U-Boot] [PATCH] u-boot: adjust config_cmd_default.h not to raise ton of warnings

On Sun 2015-05-03 10:40:40, Stephen Warren wrote: > On 05/03/2015 04:01 AM, Pavel Machek wrote: > > On Fri 2015-05-01 09:24:02, Stephen Warren wrote: > >> On 05/01/2015 03:14 AM, Pavel Machek wrote: > >>> > >>> If there's duplicty between config system and config_cmd_default, a > >>> ton of warning

Re: [U-Boot] switching to single .config configuration issues

Hi Yehuda, On 30 April 2015 at 01:21, Yehuda Yitschak wrote: > Hey Masahiro > >> -Original Message- >> From: Masahiro Yamada [mailto:yamada.masah...@socionext.com] >> Sent: Thursday, April 30, 2015 4:46 >> To: Yehuda Yitschak >> Cc: Simon Glass; Hanna Hawa; u-boot@lists.denx.de >> Subject

Re: [U-Boot] [PATCH 00/20] dm: rtc: Add driver model support for real-time clocks

Hi Albert, On 29 April 2015 at 01:09, Albert ARIBAUD wrote: > Bonjour Simon, > > Le Tue, 28 Apr 2015 20:43:47 -0600, Simon Glass a > écrit : > >> Thanks for the various reviews on this series. If there is nothing >> else, I will pull this in soon. > > Seems ok, apart from a few 'implicit declara

Re: [U-Boot] [PATCH v2 3/9] dm: usb: Use usb_get_bus in dm ehci code

Hi Hans, On 3 May 2015 at 11:15, Hans de Goede wrote: > Hi, > > > On 05/03/2015 06:59 PM, Simon Glass wrote: >> >> Hi Hans, >> >> On 1 May 2015 at 04:04, Hans de Goede wrote: >>> >>> Use usb_get_bus in dm ehci code rather then re-implementing it. >>> >>> Signed-off-by: Hans de Goede >>> --- >>>

Re: [U-Boot] [RESEND PATCH v3 00/13] Add Marvell Armada A38x 88F6820 SoC support

Hi Stefan, On 3 May 2015 at 03:16, Stefan Roese wrote: > Hi Simon, > > On 02.05.2015 22:59, Simon Glass wrote: >> >> On 24 April 2015 at 22:29, Stefan Roese wrote: >>> >>> >>> This patch series adds support for the Marvell Armada A38x SoC's. >>> Specifically >>> the 88F6820 / 88F6828. >>> >>> Ba

Re: [U-Boot] [PATCH v2 3/9] dm: usb: Use usb_get_bus in dm ehci code

Hi, On 05/03/2015 06:59 PM, Simon Glass wrote: Hi Hans, On 1 May 2015 at 04:04, Hans de Goede wrote: Use usb_get_bus in dm ehci code rather then re-implementing it. Signed-off-by: Hans de Goede --- drivers/usb/host/ehci-hcd.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-)

Re: [U-Boot] [PATCH v2 3/9] dm: usb: Use usb_get_bus in dm ehci code

Hi Hans, On 1 May 2015 at 04:04, Hans de Goede wrote: > Use usb_get_bus in dm ehci code rather then re-implementing it. > > Signed-off-by: Hans de Goede > --- > drivers/usb/host/ehci-hcd.c | 9 + > 1 file changed, 1 insertion(+), 8 deletions(-) > Acked-by: Simon Glass > diff --git a/

Re: [U-Boot] [PATCH v2 2/9] dm: usb: Make usb_get_bus easier to use for callers

On 1 May 2015 at 04:04, Hans de Goede wrote: > Make usb_get_bus easier to use for callers, by directly returning the bus > rather then returning it via a pass-by-ref argument. > > This also removes the error checking from the single current caller, as > we alreayd have an assert() for bus not bein

Re: [U-Boot] [PATCH v2 4/9] dm: usb: Fix finding of first upstream usb-2 hub in the ehci dm code

On 1 May 2015 at 04:04, Hans de Goede wrote: > The ehci driver model code for finding the first upstream usb-2 hub before > this commit has a number of issues: > > 1) "if (!ttdev->speed != USB_SPEED_HIGH)" does not work because the '!' >takes presedence over the '!=' this should simply be >

Re: [U-Boot] [PATCH v2 3/9] dm: usb: Use usb_get_bus in dm ehci code

Hi Simon, On 1 May 2015 at 04:04, Hans de Goede wrote: > Use usb_get_bus in dm ehci code rather then re-implementing it. > > Signed-off-by: Hans de Goede > --- > drivers/usb/host/ehci-hcd.c | 9 + > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/usb/host/ehci-h

Re: [U-Boot] [PATCH] u-boot: adjust config_cmd_default.h not to raise ton of warnings

On 05/03/2015 04:01 AM, Pavel Machek wrote: > On Fri 2015-05-01 09:24:02, Stephen Warren wrote: >> On 05/01/2015 03:14 AM, Pavel Machek wrote: >>> >>> If there's duplicty between config system and config_cmd_default, a >>> ton of warnings is raised, because one uses plain defines, and other >>> def

Re: [U-Boot] [PATCH 1/1] mmc: bcm2835_sdhci: Use calloc to allocate bcm2835_sdhci_host

Any feedback on this? Best regards, Alexander On Friday 17 April 2015, 17:33:17 wrote Alexander Stein: > We need to clear the allocated memory explicitly as the included > struct sdhci_host has function pointers. Those are compared to NULL to > test if this (optional) feature is supported. Leavin

Re: [U-Boot] [PATCH] u-boot: adjust config_cmd_default.h not to raise ton of warnings

On Fri 2015-05-01 09:24:02, Stephen Warren wrote: > On 05/01/2015 03:14 AM, Pavel Machek wrote: > > > >If there's duplicty between config system and config_cmd_default, a > >ton of warnings is raised, because one uses plain defines, and other > >defines it to 1. Adjust config_cmd_default.h not to p

Re: [U-Boot] [RESEND PATCH v3 00/13] Add Marvell Armada A38x 88F6820 SoC support

Hi Simon, On 02.05.2015 22:59, Simon Glass wrote: On 24 April 2015 at 22:29, Stefan Roese wrote: This patch series adds support for the Marvell Armada A38x SoC's. Specifically the 88F6820 / 88F6828. Basic support for the DB-88F6820-GP evaluation board is added. Supporting the following inter