Re: [U-Boot] [PATCH v2 6/8] dm: serial: use Driver Model for UniPhier serial driver

2014-10-23 Thread Simon Glass
On 23 October 2014 07:26, Masahiro Yamada wrote: > This commit converts UniPhier on-chip serial driver to driver model. > > Since UniPhier SoCs do not have Device Tree support, some board files > should be added under arch/arm/cpu/armv7/uniphier/ph1-*/ directories. > (Device Tree support for UniPh

Re: [U-Boot] [PATCH v2 8/8] serial: remove uniphier_serial_initialize() call

2014-10-23 Thread Simon Glass
On 23 October 2014 07:26, Masahiro Yamada wrote: > The UniPhier serial driver has been converted to driver model. > Let's remove uniphier_serial_initialize() call from the old > serial driver framework. > > Signed-off-by: Masahiro Yamada > Acked-by: Simon Glass > --- > > Changes in v2: None > >

Re: [U-Boot] [PATCH v2 7/8] serial: uniphier: move CONFIG_UNIPHIER_SERIAL to Kconfig

2014-10-23 Thread Simon Glass
On 23 October 2014 07:26, Masahiro Yamada wrote: > Signed-off-by: Masahiro Yamada > Acked-by: Simon Glass > --- > > Changes in v2: None > > configs/ph1_ld4_defconfig | 1 + > configs/ph1_pro4_defconfig | 1 + > configs/ph1_sld8_defconfig | 1 + > drivers/serial/Kconfig | 6 ++ > includ

Re: [U-Boot] [PATCH v2 5/8] dm: add entries to Kconfig

2014-10-23 Thread Simon Glass
On 23 October 2014 07:26, Masahiro Yamada wrote: > Create entries of CONFIG_DM, CONFIG_DM_SERIAL, CONFIG_DM_GPIO > and CONFIG_DM_SPI. > > Signed-off-by: Masahiro Yamada > Acked-by: Simon Glass > --- > > Changes in v2: > - Add CONFIG_DM_SPI > > drivers/core/Kconfig | 6 ++ > drivers/gpio

Re: [U-Boot] [PATCH v2] dm: move platform data headers to include/dm/platform_data

2014-10-23 Thread Simon Glass
On 23 October 2014 21:41, Masahiro Yamada wrote: > The platform_data definitions are generally referenced from both > drivers and board files. That is why header files defining > platform_data sturectures are placed in "include" directory, > but our top level "include" directory is already too cl

Re: [U-Boot] [PATCH v2 4/8] dm: serial: consolidate common code more

2014-10-23 Thread Simon Glass
On 23 October 2014 12:46, Simon Glass wrote: > On 23 October 2014 07:26, Masahiro Yamada wrote: >> Commit b8893327e9d2 (dm: serial: Put common code into separate functions) >> consolidated getc() and putc(). This commit does more puts() and tsts(). >> >> Also rename locally used functions to _se

Re: [U-Boot] [PATCH v2 1/8] serial: add static directive to local functions

2014-10-23 Thread Simon Glass
On 23 October 2014 07:26, Masahiro Yamada wrote: > The functions _serial_putc, _serial_putc_raw, _serial_puts, > _serial_getc, _serial_tstc, _serial_setbrg are defined and used > locally in each of serial_ns16550.c and serial_s3c24x0.c. > > Add static directive to them and remove declarations from

Re: [U-Boot] [PATCH v2 3/8] dm: serial: remove unnecessary casting

2014-10-23 Thread Simon Glass
On 23 October 2014 13:19, Masahiro YAMADA wrote: > Hi Simon, > > > 2014-10-24 4:03 GMT+09:00 Simon Glass : >> Hi, >> >> On 23 October 2014 12:45, Simon Glass wrote: >>> Hi Masahiro, >>> >>> On 23 October 2014 07:26, Masahiro Yamada wrote: The type (void *) can be directly passed to a functi

Re: [U-Boot] [PATCH 17/23] test: dm: Add additional GPIO tests

2014-10-23 Thread Simon Glass
On 4 October 2014 11:29, Simon Glass wrote: > Add tests for gpio_requestf() and for memory leaks. > > Signed-off-by: Simon Glass > --- > > doc/driver-model/README.txt | 5 - > test/dm/gpio.c | 38 ++ > 2 files changed, 42 insertions(+), 1 del

Re: [U-Boot] [PATCH 8/8] dm: x86: Convert coreboot serial to use driver model

2014-10-23 Thread Simon Glass
On 10 October 2014 07:49, Simon Glass wrote: > This makes use of the existing device tree node to use driver model > for the serial console. > > Signed-off-by: Simon Glass > --- > > arch/x86/dts/coreboot.dtsi | 4 ++-- > arch/x86/include/asm/ibmpc.h | 10 -- > drivers/serial/M

Re: [U-Boot] [PATCH v2 2/8] dm: serial: fix console putc

2014-10-23 Thread Simon Glass
On 23 October 2014 12:43, Simon Glass wrote: > On 23 October 2014 07:26, Masahiro Yamada wrote: >> Commit b8893327e9d2 (dm: serial: Put common code into separate functions) >> consolidated getc() correctly, but introduced another bug to putc(); >> serial_stub_putc() passes sdev->priv to serial_pu

Re: [U-Boot] [PATCH 7/8] dm: x86: dts: Add additional info to the serial port node

2014-10-23 Thread Simon Glass
On 10 October 2014 07:49, Simon Glass wrote: > Add more information so that U-Boot can find the address of the serial port. > Also fix the reg-shift value. > > Signed-off-by: Simon Glass > --- > > arch/x86/dts/coreboot.dtsi | 5 +++-- > arch/x86/dts/link.dts | 18 +- > 2 fi

Re: [U-Boot] [PATCH 5/8] dm: x86: Add a gpio header for coreboot

2014-10-23 Thread Simon Glass
On 10 October 2014 07:49, Simon Glass wrote: > This code doesn't follow the normal approach of having its arch-specific > definitions in an arch-specific directory. Add a new arch-specific file > and make use of it. > > Signed-off-by: Simon Glass > --- > > arch/x86/include/asm/arch-coreboot/gpio

Re: [U-Boot] [PATCH 6/8] dm: x86: Convert Intel ICH6 GPIO driver to use driver model

2014-10-23 Thread Simon Glass
On 10 October 2014 07:49, Simon Glass wrote: > Convert over this driver, using device tree to pass in the required > information. The peripheral is still probed, just the number of GPIO banks > and their offsets is in the device tree (previously this was a table in > the driver). > > Signed-off-by

Re: [U-Boot] [PATCH 4/8] dm: x86: Support pre-reloc malloc()

2014-10-23 Thread Simon Glass
On 10 October 2014 07:49, Simon Glass wrote: > Add support for this by reserving a block of memory below global_data. > > Signed-off-by: Simon Glass > --- > > arch/x86/cpu/start.S | 7 +++ > 1 file changed, 7 insertions(+) Applied to u-boot-dm/master

Re: [U-Boot] [PATCH 3/8] dm: x86: Zero global data before board_init_f()

2014-10-23 Thread Simon Glass
On 10 October 2014 07:49, Simon Glass wrote: > To permit information to be passed from the early U-Boot code to > board_init_f() we cannot zero the global_data in board_init_f(). Instead > zero it in the start-up code. > > Signed-off-by: Simon Glass > --- > > arch/x86/cpu/start.S | 6 ++ > 1

Re: [U-Boot] [PATCH 2/8] dm: x86: Remove ebp assembler warning in zimage.c

2014-10-23 Thread Simon Glass
On 10 October 2014 07:49, Simon Glass wrote: > This code generates warnings with recent gcc versions. We really don't need > the clobber specification, so just drop it. > > Signed-off-by: Simon Glass > --- > > arch/x86/lib/zimage.c | 1 - > 1 file changed, 1 deletion(-) Applied to u-boot-dm/mas

Re: [U-Boot] [PATCH 1/8] dm: serial: ns16550: Add a cast to the I/O operations

2014-10-23 Thread Simon Glass
On 10 October 2014 07:49, Simon Glass wrote: > This generates a warning when driver model is enabled, so fix it by adding > a cast. > > Signed-off-by: Simon Glass > --- > > drivers/serial/ns16550.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied to u-boot-dm/master _

Re: [U-Boot] [PATCH 21/23] dm: gpio: exynos: Drop request()/free() in the driver

2014-10-23 Thread Simon Glass
On 4 October 2014 11:29, Simon Glass wrote: > Now that the uclass supports gpio_request/free() there is no need for the > driver to implement it too. Drop this unnecessary code. > > Signed-off-by: Simon Glass > --- > > drivers/gpio/s5p_gpio.c | 101 >

Re: [U-Boot] [PATCH 19/23] dm: gpio: omap3: Drop request()/free() in the driver

2014-10-23 Thread Simon Glass
On 4 October 2014 11:29, Simon Glass wrote: > Now that the uclass supports gpio_request/free() there is no need for the > driver to implement it too. Drop this unnecessary code. > > Signed-off-by: Simon Glass > --- > > drivers/gpio/omap_gpio.c | 116 > +--

Re: [U-Boot] [PATCH 18/23] dm: gpio: tegra: Drop request()/free() in the driver

2014-10-23 Thread Simon Glass
On 4 October 2014 11:29, Simon Glass wrote: > Now that the uclass supports gpio_request/free() there is no need for the > driver to implement it too. Drop this unnecessary code. > > Signed-off-by: Simon Glass > --- > > drivers/gpio/tegra_gpio.c | 110 > --

Re: [U-Boot] [PATCH 23/23] dm: gpio: Remove unused get_state() uclass method

2014-10-23 Thread Simon Glass
On 4 October 2014 11:29, Simon Glass wrote: > This is no longer used so drop it. > > Signed-off-by: Simon Glass > --- > > include/asm-generic/gpio.h | 2 -- > 1 file changed, 2 deletions(-) Applied to u-boot-dm/master ___ U-Boot mailing list U-Boot@li

Re: [U-Boot] [PATCH 20/23] dm: gpio: rpi_b: Drop request()/free() in the driver

2014-10-23 Thread Simon Glass
On 4 October 2014 11:29, Simon Glass wrote: > Now that the uclass supports gpio_request/free() there is no need for the > driver to implement it too. Drop this unnecessary code. > > Signed-off-by: Simon Glass > --- > > drivers/gpio/bcm2835_gpio.c | 89 > -

Re: [U-Boot] [PATCH 22/23] dm: gpio: imx: Drop request()/free() in the driver

2014-10-23 Thread Simon Glass
On 4 October 2014 11:29, Simon Glass wrote: > Now that the uclass supports gpio_request/free() there is no need for the > driver to implement it too. Drop this unnecessary code. > > Signed-off-by: Simon Glass > --- > > drivers/gpio/mxc_gpio.c | 116 >

Re: [U-Boot] [PATCH 15/23] dm: gpio: Add gpio_requestf() helper for printf() strings

2014-10-23 Thread Simon Glass
On 4 October 2014 11:29, Simon Glass wrote: > Add a helper which permits a printf()-style format string for the requester > string. > > Signed-off-by: Simon Glass > --- > > doc/driver-model/README.txt | 3 ++- > drivers/gpio/gpio-uclass.c | 21 + > include/asm-generic/gpio.

Re: [U-Boot] [PATCH 12/23] dm: gpio: sandbox: Implement the remove() method

2014-10-23 Thread Simon Glass
On 4 October 2014 11:29, Simon Glass wrote: > This method frees memory so we must make sure to implement it. > > Signed-off-by: Simon Glass > --- > > drivers/gpio/sandbox.c | 8 > 1 file changed, 8 insertions(+) > Applied to u-boot-dm/master

Re: [U-Boot] [PATCH 14/23] test: dm: Update GPIO tests for new gpio_request() method

2014-10-23 Thread Simon Glass
On 4 October 2014 11:29, Simon Glass wrote: > Now that gpio_request() is handled by the uclass, updates the tests > accordingly. > > Signed-off-by: Simon Glass > --- > > doc/driver-model/README.txt | 25 +++-- > test/dm/gpio.c | 55 > +++-

Re: [U-Boot] [PATCH 16/23] test: dm: Support memory leak checking as a core feature

2014-10-23 Thread Simon Glass
On 4 October 2014 11:29, Simon Glass wrote: > Check the state of the malloc() heap before each test is run, so that tests > can verify that all is well at the end. Provide helper functions to mark > the heap and to check that it returns to its initial state. > > Signed-off-by: Simon Glass > --- >

Re: [U-Boot] [PATCH 13/23] dm: gpio: sandbox: Drop request()/free() in the driver

2014-10-23 Thread Simon Glass
On 4 October 2014 11:29, Simon Glass wrote: > Now that the uclass supports gpio_request/free() there is no need for the > driver to implement it too. Drop this unnecessary code. > > Signed-off-by: Simon Glass > --- > > drivers/gpio/sandbox.c | 82 > --

Re: [U-Boot] [PATCH 11/23] dm: gpio: sandbox: Implement the get_function() method

2014-10-23 Thread Simon Glass
On 4 October 2014 11:29, Simon Glass wrote: > Implement this method so that the 'gpio' command can do its job correctly. > For sandbox we only support input and output states for a gpio. > > Signed-off-by: Simon Glass > --- > > drivers/gpio/sandbox.c | 9 - > 1 file changed, 8 insertions

Re: [U-Boot] [PATCH 10/23] dm: Move the function for getting GPIO status into the uclass

2014-10-23 Thread Simon Glass
On 4 October 2014 11:29, Simon Glass wrote: > This function can be more easily tested if it is in the uclass. > > Signed-off-by: Simon Glass > --- > > common/cmd_gpio.c | 57 > +- > drivers/gpio/gpio-uclass.c | 39

Re: [U-Boot] [PATCH v2 13/15] dm: am335x: Remove serial options from CONFIG_SYS_EXTRA_OPTIONS

2014-10-23 Thread Simon Glass
On 22 October 2014 21:37, Simon Glass wrote: > With these options in place it is not possible to change the serial port > using 'make menuconfig' or similar. It seems to result in duplicate > defines. > > For example: > > In file included from include/linux/kconfig.h:4:0, > from :

Re: [U-Boot] [PATCH 08/23] dm: gpio: Implement GPIO reservation in the uclass

2014-10-23 Thread Simon Glass
On 4 October 2014 11:29, Simon Glass wrote: > We have several GPIO drivers now and all are doing similar things to record > which GPIOs are reserved. > > Move this logic into the uclass to make the drivers similar. > > We retain the request()/free() methods since currently one driver does use > th

Re: [U-Boot] [PATCH 09/23] dm: gpio: Add gpio_get_function() and friends

2014-10-23 Thread Simon Glass
On 4 October 2014 11:29, Simon Glass wrote: > Add helpers to the uclass to allow finding out the pin function. > > Signed-off-by: Simon Glass > --- > > drivers/gpio/gpio-uclass.c | 47 > ++ > include/asm-generic/gpio.h | 34 +++

Re: [U-Boot] [PATCH v2 14/15] dm: am33xx: Move to driver model for GPIO and serial

2014-10-23 Thread Simon Glass
On 22 October 2014 21:37, Simon Glass wrote: > Adjust the configuration for the am33xx boards, including beaglebone black > to use driver model. > > This can be extended to other OMAP boards once platform data is provided > for them. > > Signed-off-by: Simon Glass > Acked-by: Tom Rini > --- > >

Re: [U-Boot] [PATCH v2 12/15] dm: omap: serial: Add driver model support

2014-10-23 Thread Simon Glass
On 22 October 2014 21:37, Simon Glass wrote: > Add driver model support to this driver, while retaining support for the > legacy system. Driver model serial support is enabled with CONFIG_DM_SERIAL > as usual. > > Signed-off-by: Simon Glass > Reviewed-by: Tom Rini > --- > > Changes in v2: > - Us

Re: [U-Boot] [PATCH v2 15/15] dm: omap3: Move to driver model for GPIO and serial

2014-10-23 Thread Simon Glass
On 23 October 2014 14:48, Tom Rini wrote: > On Wed, Oct 22, 2014 at 09:37:15PM -0600, Simon Glass wrote: > >> Adjust the configuration for the am33xx boards, including beagleboard, >> to use driver model. >> >> Signed-off-by: Simon Glass > > Acked-by: Tom Rini Applied to u-boot-dm/master __

Re: [U-Boot] [PATCH v2 11/15] dm: am33xx: Provide platform data for serial

2014-10-23 Thread Simon Glass
On 22 October 2014 21:37, Simon Glass wrote: > Provide suitable platform data for am33xx boards, so that these boards can > use driver model for serial. > > Signed-off-by: Simon Glass > Reviewed-by: Tom Rini > --- > > Changes in v2: None > > arch/arm/cpu/armv7/am33xx/board.c | 33 ++

Re: [U-Boot] [PATCH v2 10/15] dm: am33xx: Provide platform data for GPIOs

2014-10-23 Thread Simon Glass
On 22 October 2014 21:37, Simon Glass wrote: > Provide suitable platform data for am33xx boards, so that these boards can > use driver model for GPIO access. > > Signed-off-by: Simon Glass > Reviewed-by: Tom Rini > --- > > Changes in v2: None > > arch/arm/cpu/armv7/am33xx/board.c | 28 +

Re: [U-Boot] [PATCH v2 09/15] dm: omap: gpio: Support driver model

2014-10-23 Thread Simon Glass
On 22 October 2014 21:37, Simon Glass wrote: > Add driver model support to this driver, while retaining support for the > legacy system. Driver model GPIO support is enabled with CONFIG_DM_GPIO > as usual. > > Since gpio_is_valid() no longer exists, we can use the -EINVAL error > returned from gpi

Re: [U-Boot] [PATCH v2 08/15] dm: omap: gpio: Put _get_gpio_value() logic into its own function

2014-10-23 Thread Simon Glass
On 22 October 2014 21:37, Simon Glass wrote: > Add a separate internal helper function to get a GPIO value, so that we > will be able to call it with the driver model version and avoid code > duplication. > > Also move gpio_get_bank() and check_gpio() down below the helper functions > as these won

Re: [U-Boot] [PATCH v2 07/15] dm: dts: omap: Select correct console for beaglebone

2014-10-23 Thread Simon Glass
On 22 October 2014 21:37, Simon Glass wrote: > Select serial0 as the console. > > Signed-off-by: Simon Glass > Acked-by: Tom Rini > --- > > Changes in v2: None > > arch/arm/dts/am335x-bone-common.dtsi | 4 > 1 file changed, 4 insertions(+) > Applied to u-boot-dm/master ___

Re: [U-Boot] [PATCH v2 06/15] dm: serial: Support CONFIG_CONS_INDEX if available

2014-10-23 Thread Simon Glass
On 22 October 2014 21:37, Simon Glass wrote: > Try to use this option to select the correct uart for the console. This > mimics the behaviour of drivers/serial.c. > > Signed-off-by: Simon Glass > Reviewed-by: Tom Rini > --- > > Changes in v2: > - Fix "is available" typo > > drivers/serial/seria

Re: [U-Boot] [PATCH v2 05/15] dm: ns16550: Correct the probe logic for platform data

2014-10-23 Thread Simon Glass
On 22 October 2014 21:37, Simon Glass wrote: > The probe logic sets up the pointer to the platform data in the device > tree decode method. It should be done in the probe() method, and anyway > the device tree decode method can't be used when CONFIG_OF_CONTROL is > not enabled. > > Fix these two p

Re: [U-Boot] [PATCH v2 04/15] dm: ns16550: Use an address instead of a pointer for the uart base

2014-10-23 Thread Simon Glass
On 22 October 2014 21:37, Simon Glass wrote: > It is inconvenient to have to use casts when specifying platform data. Also > it is not strictly correct, since we should use map_sysmem() to convert an > address to a pointer. > > Adjust the platform data to use an address. > > Signed-off-by: Simon G

Re: [U-Boot] [PATCH v2 02/15] dm: serial: Reset the watchdog while waiting in getc()

2014-10-23 Thread Simon Glass
On 22 October 2014 21:37, Simon Glass wrote: > We have moved the busy-wait loop out of drivers and into the uclass. This > means that we must reset the watchdog when busy-waiting. > > Note: some drivers may still have a busy-wait even with driver model, as > a transition mechanism. Driver model wi

Re: [U-Boot] [PATCH v2 03/15] dm: serial: ns16550: Correct logic for checking for character

2014-10-23 Thread Simon Glass
On 22 October 2014 21:37, Simon Glass wrote: > There is a bug in the logic which checks for an available character. This > can cause invalid characters to be received - this was noticed on > beaglebone. Fix it. > > Signed-off-by: Simon Glass > Reviewed-by: Tom Rini > --- > > Changes in v2: None

Re: [U-Boot] [PATCH v2 01/15] dm: gpio: Support numbered GPIOs

2014-10-23 Thread Simon Glass
On 22 October 2014 21:37, Simon Glass wrote: > At present banks must be named and it is not possible to refer to GPIOs by > number in driver model. Some boards use numbering - e.g. OMAP. It is fairly > easy to support by detecting the absense of a bank name (which starts with > a letter). > > Add

[U-Boot] [PATCH v2] dm: move platform data headers to include/dm/platform_data

2014-10-23 Thread Masahiro Yamada
The platform_data definitions are generally referenced from both drivers and board files. That is why header files defining platform_data sturectures are placed in "include" directory, but our top level "include" directory is already too cluttered. Let's collect platform_data definitions under th

Re: [U-Boot] [PATCH 07/10] x86: link: Tidy up the command lines options

2014-10-23 Thread Simon Glass
On 10 October 2014 07:30, Simon Glass wrote: > We may as well use hush. The auto-complete option was incorrect so this was > not enabled. Also expand the command line size a little and go back to the > default prompt since "boot>" doesn't seem any more useful. > > Signed-off-by: Simon Glass > ---

Re: [U-Boot] [PATCH 10/10] net: Display the size when tftpboot finishes

2014-10-23 Thread Simon Glass
On 10 October 2014 07:30, Simon Glass wrote: > If we know the file size, display it after loading the file. > > Signed-off-by: Simon Glass > --- > > net/tftp.c | 2 ++ > 1 file changed, 2 insertions(+) Applied to u-boot-x86/master. ___ U-Boot mailing

Re: [U-Boot] [PATCH 08/10] x86: config: link: Display the board model on the screen

2014-10-23 Thread Simon Glass
On 10 October 2014 07:30, Simon Glass wrote: > To get a display in U-Boot on link you must either build a coreboot that > always sets it up, or use Esc-Refresh-Power to reset the machine. > > When we do have a display, it is nice to display the model at the top, so > enable this option. > > Signed

Re: [U-Boot] [PATCH 09/10] x86: Enable FIT, ELF on coreboot

2014-10-23 Thread Simon Glass
On 10 October 2014 07:30, Simon Glass wrote: > Enable FIT support and the bootelf command. Also change the default load > address to somewhere other than the normal load address of the kernel, > to allow for decompression without overwriting the original file. > > Signed-off-by: Simon Glass > ---

Re: [U-Boot] [PATCH 05/10] x86: cros_ec: Enable cros_ec for link

2014-10-23 Thread Simon Glass
On 10 October 2014 07:30, Simon Glass wrote: > Add defines to enable the Chrome OS EC interface and set it up on init. > > Signed-off-by: Simon Glass > --- > > board/chromebook-x86/coreboot/Makefile | 2 +- > board/chromebook-x86/coreboot/coreboot.c | 16 > include/configs/co

Re: [U-Boot] [PATCH 06/10] doc: Remove note about auto-complete not working with hush

2014-10-23 Thread Simon Glass
On 10 October 2014 07:30, Simon Glass wrote: > It does seem to work (tested on link), so update the docs. > > Signed-off-by: Simon Glass > --- > > README | 4 > 1 file changed, 4 deletions(-) Applied to u-boot-x86/master. ___ U-Boot mailing list

Re: [U-Boot] [PATCH 03/10] x86: dts: Add device tree compatible string for Intel IPC

2014-10-23 Thread Simon Glass
On 10 October 2014 07:30, Simon Glass wrote: > Add this to the table so that it can be recognised. > > Signed-off-by: Simon Glass > --- > > include/fdtdec.h | 1 + > lib/fdtdec.c | 1 + > 2 files changed, 2 insertions(+) > Applied to u-boot-x86/master. __

Re: [U-Boot] [PATCH 02/10] x86: Add device tree information for Chrome OS EC

2014-10-23 Thread Simon Glass
On 10 October 2014 07:30, Simon Glass wrote: > Add the required node describing how to find the EC on link. > > Signed-off-by: Simon Glass > --- > > arch/x86/dts/link.dts | 18 ++ > 1 file changed, 18 insertions(+) Applied to u-boot-x86/master. __

Re: [U-Boot] [PATCH 04/10] x86: cros_ec: Update LPC driver for new cros_ec header

2014-10-23 Thread Simon Glass
On 10 October 2014 07:30, Simon Glass wrote: > There was a minor rename of one of the defines, so update the driver. > > Signed-off-by: Simon Glass > --- > > drivers/misc/cros_ec_lpc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied to u-boot-x86/master.

Re: [U-Boot] [PATCH 01/10] x86: config: Enable dhcp on link

2014-10-23 Thread Simon Glass
On 10 October 2014 07:30, Simon Glass wrote: > The dhcp option is required to get bootp to work on the Chromebook Pixel, > so enable it. > > Signed-off-by: Simon Glass Applied to u-boot-x86/master. ___ U-Boot mailing list U-Boot@lists.denx.de http://li

[U-Boot] [PATCH v2 09/11] fdt: Change fdt_pack_reg() to static and fix types

2014-10-23 Thread Simon Glass
This function is only called within this file so make it static. Also fix its argument types to be consistent with its caller. Signed-off-by: Simon Glass Acked-by: Anatolij Gustschin --- Changes in v2: None common/fdt_support.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -

Re: [U-Boot] [PATCH 07/14] dm: dts: omap: Select correct console for beaglebone

2014-10-23 Thread Simon Glass
Hi Tom, On 23 October 2014 14:45, Tom Rini wrote: > On Wed, Oct 22, 2014 at 09:19:08PM -0600, Simon Glass wrote: >> Hi Tom, >> >> On 22 October 2014 09:59, Tom Rini wrote: >> > On Mon, Sep 22, 2014 at 09:48:47AM -0600, Simon Glass wrote: >> > >> >> Select serial0 as the console. >> >> >> >> Sign

Re: [U-Boot] [PATCH v2 13/13] dm: Update documentation to include CONFIG_DM... options

2014-10-23 Thread Simon Glass
Hi Masahiro, On 23 October 2014 14:17, Masahiro YAMADA wrote: > Hi Simon, > > > 2014-10-24 4:16 GMT+09:00 Simon Glass : >> Add documentation for the various driver model options that are now >> available. >> >> Signed-off-by: Simon Glass >> --- >> >> Changes in v2: >> - Rebase to master >> >> R

Re: [U-Boot] [PATCH 0/10] Provide inttypes.h to avoid 32/64 bit problems with printf()

2014-10-23 Thread Simon Glass
+Jeroen Hi, On 15 October 2014 04:38, Simon Glass wrote: > In quite a few situations we have to print a 64-bit value. Unfortunately > the type used for 64-bit can vary depending on the machine. For 64-bit > machines it might be 'long' and for 32-bit machines it might be > 'long long'. > > As a r

[U-Boot] [PATCH v2 04/11] fdt: Add device tree memory bindings

2014-10-23 Thread Simon Glass
From: Michael Pratt Support a default memory bank, specified in reg, as well as board-specific memory banks in subtree board-id nodes. This allows memory information to be provided in the device tree, rather than hard-coded in, which will make it simpler to handle similar devices with different

[U-Boot] [PATCH v2 08/11] fdt: Add ft_system_setup() function for system device tree additions

2014-10-23 Thread Simon Glass
Add an additional function for adding information to the device tree before booting. This permits additions which are not board-specific. Signed-off-by: Simon Glass Acked-by: Anatolij Gustschin --- Changes in v2: - Report FDT error from ft_system_setup() - Fix ft_board_setup error in README R

[U-Boot] [PATCH v2 07/11] fdt: Tidy up error handling in image_setup_libfdt()

2014-10-23 Thread Simon Glass
The message about needing to reset should be printed no matter what error is printed. Also, an error should always be printed. Signed-off-by: Simon Glass Acked-by: Anatolij Gustschin --- Changes in v2: None common/image-fdt.c| 30 -- include/fdt_support.h | 1

[U-Boot] [PATCH v2 11/11] fdt: Try to use fdt_address_cells()/fdt_size_cells()

2014-10-23 Thread Simon Glass
Use these new functions where possible. They default to a value of 2 so we cannot use them in some places where we need a default value of 1. Signed-off-by: Simon Glass --- Changes in v2: None board/freescale/mpc8641hpcn/mpc8641hpcn.c | 7 +++--- common/fdt_support.c | 41

[U-Boot] [PATCH v2 03/11] fdt: Export the fdt_find_or_add_subnode() function

2014-10-23 Thread Simon Glass
This function is useful for ensuring that a node exists. Export it so it can be used more widely. Signed-off-by: Simon Glass --- Changes in v2: - Leave function documentation hidden in the C file common/fdt_support.c | 6 +++--- include/fdt_support.h | 2 ++ 2 files changed, 5 insertions(+),

[U-Boot] [PATCH v2 10/11] fdt: Add a function to decode a named memory region

2014-10-23 Thread Simon Glass
Permit decoding of a named memory region from the device tree. This allows easy run-time configuration of the address of on-chip SRAM, SDRAM, etc. Signed-off-by: Simon Glass --- Changes in v2: None include/fdtdec.h | 28 ++ lib/fdtdec.c | 61

[U-Boot] [PATCH v2 02/11] fdt: Report failure of ft_board_setup()

2014-10-23 Thread Simon Glass
Since this function can fail, print a message when it does. Signed-off-by: Simon Glass --- Changes in v2: - Improve error message on failure common/cmd_fdt.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/common/cmd_fdt.c b/common/cmd_fdt.c index 5640ded..6f7ea

[U-Boot] [PATCH v2 06/11] fdt: Enhance flashmap function to deal with region properties

2014-10-23 Thread Simon Glass
Flash regions can optionally be compressed or hashed. Add the ability to read this information from the flashmap. Signed-off-by: Simon Glass Acked-by: Anatolij Gustschin --- Changes in v2: None include/fdtdec.h | 16 lib/fdtdec.c | 8 2 files changed, 24 inserti

[U-Boot] [PATCH v2 05/11] fdt: Use the correct return types for fdtdec_decode_region()

2014-10-23 Thread Simon Glass
Use the correct FDT data types for this function. Also add more debugging. Acked-by: Anatolij Gustschin Signed-off-by: Simon Glass --- Changes in v2: None include/fdtdec.h | 10 +- lib/fdtdec.c | 19 --- 2 files changed, 17 insertions(+), 12 deletions(-) diff --gi

Re: [U-Boot] [PATCH 01/11] fdt: Allow ft_board_setup() to report failure

2014-10-23 Thread Simon Glass
Hi, On 20 October 2014 19:51, Simon Glass wrote: > Hi Anatolij, > > On 17 October 2014 14:19, Anatolij Gustschin wrote: >> Hi Simon, >> >> some comments on return values and error reporting below: >> >> On Wed, 15 Oct 2014 02:05:31 -0600 >> Simon Glass wrote: >> ... >>> diff --git a/board/amcc/

[U-Boot] [PATCH v2 01/11] fdt: Allow ft_board_setup() to report failure

2014-10-23 Thread Simon Glass
This function can fail if the device tree runs out of space. Rather than silently booting with an incomplete device tree, allow the failure to be detected. Unfortunately this involves changing a lot of places in the code. I have not changed behvaiour to return an error where one is not currently r

Re: [U-Boot] [PATCH v3] board: wandboard: add usb storage

2014-10-23 Thread Fabio Estevam
On Thu, Oct 23, 2014 at 7:17 PM, Jeroen Hofstee wrote: >> Please add Stefano on Cc next time. > > > I would have normally, but get_maintainer instructed me > not to do so. Shouldn't it be adjusted then to include the > responsible custodian as well if that is what we want? Yes, I think it should

Re: [U-Boot] [PATCH v3] board: wandboard: add usb storage

2014-10-23 Thread Jeroen Hofstee
Hello Fabio, On 23-10-14 23:04, Fabio Estevam wrote: On Thu, Oct 23, 2014 at 7:02 PM, Jeroen Hofstee wrote: Cc: Fabio Estevam Signed-off-by: Jeroen Hofstee Acked-by: Fabio Estevam Please add Stefano on Cc next time. I would have normally, but get_maintainer instructed me not to do so. S

Re: [U-Boot] [PATCH v3] board: wandboard: add usb storage

2014-10-23 Thread Fabio Estevam
On Thu, Oct 23, 2014 at 7:02 PM, Jeroen Hofstee wrote: > Cc: Fabio Estevam > Signed-off-by: Jeroen Hofstee Acked-by: Fabio Estevam Please add Stefano on Cc next time. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo

[U-Boot] [PATCH v3] board: wandboard: add usb storage

2014-10-23 Thread Jeroen Hofstee
Cc: Fabio Estevam Signed-off-by: Jeroen Hofstee --- version 3: - don't blindly copy get_mainter output - don't forget the subject-prefix version 2: - remove the duplicated CONFIG_CMD_FAT --- include/configs/wandboard.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/conf

Re: [U-Boot] [PATCH] board: wandboard: add usb storage

2014-10-23 Thread Jeroen Hofstee
Hello Fabio, On 23-10-14 22:49, Fabio Estevam wrote: Hi Jeroen, On Thu, Oct 23, 2014 at 6:47 PM, Jeroen Hofstee wrote: Fabio Estevam (maintainer:WANDBOARD BOARD) Patch looks good, but this commit log doesn't. yes, I see, subject of the reposted patch is not correct as well. Lets try it a

Re: [U-Boot] [PATCH] board: wandboard: add usb storage

2014-10-23 Thread Fabio Estevam
Hi Jeroen, On Thu, Oct 23, 2014 at 6:47 PM, Jeroen Hofstee wrote: > Fabio Estevam (maintainer:WANDBOARD BOARD) Patch looks good, but this commit log doesn't. > Signed-off-by: Jeroen Hofstee ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.

[U-Boot] [PATCH] board: wandboard: add usb storage

2014-10-23 Thread Jeroen Hofstee
Fabio Estevam (maintainer:WANDBOARD BOARD) Signed-off-by: Jeroen Hofstee --- version 2: remove the duplicated CONFIG_CMD_FAT --- include/configs/wandboard.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/configs/wandboard.h b/include/configs/wandboard.h index 37e3429..1a9c

Re: [U-Boot] [PATCH v2 15/15] dm: omap3: Move to driver model for GPIO and serial

2014-10-23 Thread Tom Rini
On Wed, Oct 22, 2014 at 09:37:15PM -0600, Simon Glass wrote: > Adjust the configuration for the am33xx boards, including beagleboard, > to use driver model. > > Signed-off-by: Simon Glass Acked-by: Tom Rini -- Tom signature.asc Description: Digital signature ___

Re: [U-Boot] [PATCH 07/14] dm: dts: omap: Select correct console for beaglebone

2014-10-23 Thread Tom Rini
On Wed, Oct 22, 2014 at 09:19:08PM -0600, Simon Glass wrote: > Hi Tom, > > On 22 October 2014 09:59, Tom Rini wrote: > > On Mon, Sep 22, 2014 at 09:48:47AM -0600, Simon Glass wrote: > > > >> Select serial0 as the console. > >> > >> Signed-off-by: Simon Glass > >> --- > >> > >> arch/arm/dts/am33

[U-Boot] [PATCH] board: wandboard: add usb storage

2014-10-23 Thread Jeroen Hofstee
Fabio Estevam (maintainer:WANDBOARD BOARD) Signed-off-by: Jeroen Hofstee --- include/configs/wandboard.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/configs/wandboard.h b/include/configs/wandboard.h index 37e3429..070ce92 100644 --- a/include/configs/wandboard.h +++ b

Re: [U-Boot] [PATCH] kbuild: clear VENDOR variable to fix build error on tcsh

2014-10-23 Thread Tom Rini
On Tue, Oct 21, 2014 at 01:18:32PM +0900, Masahiro Yamada wrote: > Since the environment "VENDOR" is set in tcsh, it must be cleared in our > makefile. Otherwise, boards without CONFIG_SYS_VENDOR fail to build: > > > make CROSS_COMPILE=arm-linux-gnueabi- wandboard_quad_defconfig all > [ sn

Re: [U-Boot] Please pull u-boot-tegra/master into ARM/master

2014-10-23 Thread Tom Rini
On Wed, Oct 22, 2014 at 09:59:22AM -0700, Tom Warren wrote: > MAKEALL -s tegra is error/warning-free. > > The following changes since commit 3d420cbd355a5f09e4f113eb10579a264a8ef138: > > Merge branch 'u-boot-socfpga/topic/arm/socfpga-20141010' into > 'u-boot-arm/master' (2014-10-11 01:20:55 +0

Re: [U-Boot] [PATCH v2 13/13] dm: Update documentation to include CONFIG_DM... options

2014-10-23 Thread Masahiro YAMADA
Hi Simon, 2014-10-24 4:16 GMT+09:00 Simon Glass : > Add documentation for the various driver model options that are now > available. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Rebase to master > > README | 119 >

Re: [U-Boot] [PATCH] musb: fix warning in include/linux/usb/musb.h

2014-10-23 Thread Marek Vasut
On Thursday, October 23, 2014 at 01:25:25 PM, Igor Grinberg wrote: > Fix the following build warning by including linux/compat.h: > include/linux/usb/musb.h:110: warning: 'struct device' declared inside > parameter list > include/linux/usb/musb.h:110: warning: its scope is only this definition > or

Re: [U-Boot] [PATCH 1/7] dm: at91: Correct text base for snapper9260

2014-10-23 Thread Simon Glass
Hi Andreas, On 22 October 2014 23:21, Andreas Bießmann wrote: > Hi, > > On 23.10.14 07:12, Simon Glass wrote: >> Hi, >> >> On Oct 22, 2014 11:10 PM, "Andreas Bießmann" >> mailto:andreas.de...@googlemail.com>> wrote: >>> >>> It also seems the maintainer of snapper9260 is not reachable. Simon, do >

Re: [U-Boot] [PATCH 0/7] dm: Introduce driver model for Atmel at91

2014-10-23 Thread Andreas Bießmann
Hi Simon, On 23.10.14 06:09, Simon Glass wrote: > Hi, > > On 6 October 2014 12:14, Simon Glass wrote: >> This series adds driver model support for serial and GPIO for the Atmel AT91 >> series. The at91sam9260-based Snapper 9260 is converted over as an example. >> >> For both drivers the old beha

Re: [U-Boot] [PATCH 7/7] dm: at91: Convert snapper9260 to use driver model

2014-10-23 Thread Andreas Bießmann
On 06.10.14 20:14, Simon Glass wrote: > Convert this at91sam9260-based board to use driver model. This should serve > as an example for other similar boards. Serial and GPIO are supported so > far. > > Signed-off-by: Simon Glass Acked-by: Andreas Bießmann > --- > > board/bluewater/snapper926

Re: [U-Boot] [PATCH 6/7] dm: at91: Add driver model support for the serial driver

2014-10-23 Thread Andreas Bießmann
Hi Simon, On 06.10.14 20:14, Simon Glass wrote: > Add driver model support while retaining the existing legacy code. This > allows the driver to support boards that have converted to driver model > as well as those that have not. > > Signed-off-by: Simon Glass > --- > > arch/arm/include/asm/ar

Re: [U-Boot] [PATCH 5/7] dm: at91: Refactor serial driver slightly for driver model

2014-10-23 Thread Andreas Bießmann
On 06.10.14 20:14, Simon Glass wrote: > Before adding driver model support, split out a few of the functions so > that they can be used by the driver model code. > > Signed-off-by: Simon Glass Acked-by: Andreas Bießmann > --- > > drivers/serial/atmel_usart.c | 32 +++-

[U-Boot] [PATCH v2 13/13] dm: Update documentation to include CONFIG_DM... options

2014-10-23 Thread Simon Glass
Add documentation for the various driver model options that are now available. Signed-off-by: Simon Glass --- Changes in v2: - Rebase to master README | 119 doc/driver-model/README.txt | 44 2 files changed, 1

[U-Boot] [PATCH v2 12/13] dm: tegra: Enable driver model in SPL and adjust the GPIO driver

2014-10-23 Thread Simon Glass
Use the full driver model GPIO and serial drivers in SPL now that these are supported. Since device tree is not available they will use platform data. Remove the special SPL GPIO function as it is no longer needed. This is all in one commit to maintain bisectability. Signed-off-by: Simon Glass

Re: [U-Boot] [PATCH 0/23] dm: Introduce driver model for sunxi

2014-10-23 Thread Simon Glass
Hi, On 9 October 2014 21:44, Simon Glass wrote: > HI Hans, > > On 9 October 2014 02:13, Hans de Goede wrote: >> Hi, >> >> On 10/09/2014 09:59 AM, Ian Campbell wrote: >>> On Wed, 2014-10-08 at 13:27 -0600, Simon Glass wrote: >>> Any more comments on this series please? I have a few nits so c

Re: [U-Boot] [PATCH 0/14] dm: omap: Provide access to driver model for am335x, and move boards

2014-10-23 Thread Simon Glass
Hi Tom, On 20 October 2014 09:13, Tom Rini wrote: > On Tue, Oct 14, 2014 at 09:26:51AM +0200, Simon Glass wrote: >> Hi, >> >> On 22 September 2014 17:48, Simon Glass wrote: >> > This series adjusts the serial and GPIO drivers, used by Beaglebone for >> > example, to work with driver model. Since

Re: [U-Boot] [PATCH v2 3/8] dm: serial: remove unnecessary casting

2014-10-23 Thread Masahiro YAMADA
Hi Simon, 2014-10-24 4:03 GMT+09:00 Simon Glass : > Hi, > > On 23 October 2014 12:45, Simon Glass wrote: >> Hi Masahiro, >> >> On 23 October 2014 07:26, Masahiro Yamada wrote: >>> The type (void *) can be directly passed to a function that >>> takes a specific pointer type. >>> >>> Signed-off-b

[U-Boot] [PATCH v2 05/13] dm: spl: Allow driver model to be used

2014-10-23 Thread Simon Glass
When enabled, set up driver model for SPL. This allows SPL to use the same drivers as the main U-Boot. Signed-off-by: Simon Glass --- Changes in v2: None common/spl/spl.c | 5 + scripts/Makefile.spl | 1 + 2 files changed, 6 insertions(+) diff --git a/common/spl/spl.c b/common/spl/spl

[U-Boot] [PATCH v2 11/13] dm: arm: spl: Make driver model linker lists available

2014-10-23 Thread Simon Glass
The linker lists feature is useful in SPL as it holds the driver model platform data. So don't throw away the lists. Signed-off-by: Simon Glass --- Changes in v2: None arch/arm/cpu/u-boot-spl.lds | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/cpu/u-boot-spl.lds b/arch/arm/

  1   2   3   >